[Koha-bugs] [Bug 6506] deleting patron history missing errors

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6506

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17385|0                           |1
        is obsolete|                            |
  Attachment #17387|0                           |1
        is obsolete|                            |
  Attachment #17753|0                           |1
        is obsolete|                            |

--- Comment #18 from Mason James <mtj at kohaaloha.com> ---
Created attachment 17754
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17754&action=edit
Bug 6506: When AnonymousPatron not set, deletion of issue history silently
failed.

Remedied by:
- in Circulation.pm changing AnonymiseIssueHistory so that it returns ($rows,
$err_history_not_deleted) instead of $rows
- consequential change to misc/cronjobs/batch_anonymise.pl to handle updated
return value, and fail if there is an error
- consequential change to tools/cleanborrowers.pl although this still fails
silently (raised as bug 9944)
- update of opac-privacy.pl to check return value and pass on error
- update of opac-privacy.tt to display error if appropriate

Note bug 9942 remains unfixed, which is a similar issue upon issue return.

To test:
1. OPAC
- enable privacy mode (preference OpacPrivacy)
- leave anonymous patron set to zero (preference AnonymousPatron)
- attempt to delete user history
- observe error
- check history - still there
- change anonymous patron to a valid user
- attempt to delete user history
- observe success message
- check history - gone

2. cleanborrowers.pl
- test it functions as before.  bug 9944 has been raised for it continuing to
silently fail.

3. batch_anonymise.pl
- enable privacy mode (preference OpacPrivacy)
- leave anonymous patron set to zero (preference AnonymousPatron)
- run script (I use --days -1 for testing)
- script should fail with a Carp message
- change anonymous patron to a valid user
- run script as before
- script returns quietly
- check history - gone

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.