[Koha-bugs] [Bug 9842] SIP tests : fix for 07hold.t on Cancel Hold

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9842

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|                            |m.de.rooy at rijksmuseum.nl

--- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
I am not sure if I understand this patch..
You say that this is wrong:
    unless ($trans->ok) {
And that it should be:
    unless ($trans->ok(1)) {

For me, it looks like that you test the ok status in the first case (via
AUTOLOAD in Transaction.pm), and in the second case you set ok to 1 and this
should also return 1. So you actually say:
    $trans->ok(1); unless(1) {

So, whatever follows after this unless will never be executed. You will never
get that error message any more :)

I am setting status to Failed QA. Please convince me if I am wrong..

-- 
You are receiving this mail because:
You are watching all bug changes.