[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Apr 29 17:34:09 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #4 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Few questions:
First:
     install -m 0644 koha-tmpl/opac-tmpl/lib/yui/skin.css \
          koha-tmpl/opac-tmpl/lib/yui/reset-fonts-grids.css \
         $(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/prog/en/css
+    install -m 0644 koha-tmpl/opac-tmpl/lib/yui/skin.css \
+         koha-tmpl/opac-tmpl/lib/yui/reset-fonts-grids.css \
+        $(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/ccsr/en/css

I have the impression that Koha expects this css to be in lib/yui. So, why
install them to prog and ccsr? Better remove the lines before??

Second:
     sed -i -e
's:url(.*/reset-fonts-grids.css.*):url("/opac-tmpl/lib/yui/reset-fonts-grids/reset-fonts-grids.css"):'
\
            -e
's:url(.*/skin.css.*):url("/opac-tmpl/lib/yui/assets/skins/sam/skin.css"):' \
-        $(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/prog/en/css/opac.css \
-        $(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/prog/en/css/sco.css
+        $(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/*/en/css/opac.css \
+        $(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/*/en/css/sco.css
I think that this sed should not find anything? I grepped on
reset-fonts-grids.css but could not find references to something looking like
reset-fonts-grids.css.*  Or is that only in the scope of the install??

Third:
+    sed -i -e
's:href="/opac-tmpl/lib/yui/reset-fonts-grids.css":href="/opac-tmpl/lib/yui/reset-fonts-grids/reset-fonts-grids.css":'
\
+           -e
's:href="/opac-tmpl/lib/yui/skin.css":href="/opac-tmpl/lib/yui/assets/skins/sam/skin.css":'
\
+       
$(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/ccsr/en/includes/doc-head-close.inc
Why move this skin.css file to assets/skins/sam?
Note that I also did not find the skin.css.* occurrences..

Changing status to reflect need for clarification. After that please switch
back to Signed off. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list