[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Apr 30 15:18:41 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #44 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Katrin, here are my answers to your remarks:

1) I could rewrite this without the SELECT SQL_CALC_FOUND_ROWS part, but it
would be an important loss of performance (because I would have to relaunch the
main time-consuming request a second time)... So is it worth it? (and I say
that even though I know we're trying to get rid of mysqlisms)

2) This feature is not longer necessary, as the use of datatable for the
results allows the user to change pagination and offset once the results are
here.

3) Indeed. Removed.

4) The calendars are using datepicker, the DHTMLCalendar line was a leftover,
it has been removed. As for the dates, since the calendars are used to set
items.datelastseen, which is a date, and not a datetime, does it make sense to
use Koha::DateUtils instead of C4::Dates?

5) For the terms used, I kept the ones from HEAD when I rebased, so it might be
ok now? Also, <body> fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list