[Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Apr 30 23:20:38 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17285|0                           |1
        is obsolete|                            |

--- Comment #93 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 17857
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17857&action=edit
[SIGNED-OFF] Bug 7688: Rewrite t/db_dependant/Serials.t

A lot of tests were just a call to a funtion without any arguments,
whereas the function expect at least one argument.
These tests were kept, but all return values are now undef when a
mandatory argument is missing, so return values are consistent.

The part where subscription periodicity is changed could not work
because of ',' appended to each key in ModSubscription call. So it's
rewritten, taking into account the new API for subscription frequencies.
This script should leave your database intact because it revert any
modification made.

Also fix some warnings in C4::Serials and in C4::Items.
And fix a typo in koha-tmpl/.../subscription-numberpatterns.tt

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Comment: Work as described. No errors
Tested, again, without trouble.
With a suscription, tests successful.
No koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list