From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 01:41:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 23:41:29 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19864|0 |1 is obsolete| | --- Comment #34 from Srdjan Jankovic --- Created attachment 20029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20029&action=edit [SIGNED-OFF] C4::Branch.pm needs unit tests Unit tests are wrap in a transaction. To test: prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207. t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=36, 1 wallclock secs ( 0.02 usr 0.02 sys + 0.13 cusr 0.01 csys = 0.18 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10508 Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 01:42:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 23:42:25 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #35 from Srdjan Jankovic --- Yes it is ok, my mistake, sorry about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 02:28:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 00:28:59 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 --- Comment #6 from Srdjan Jankovic --- # Failed test 'take from holdingbranch AutomaticItemReturn on (use cost matrix) holding branch' # at t/db_dependent/HoldsQueue.t line 196. # got: 'CPL' # expected: 'IPT' # Wrong pick-up/hold for first target (pick_branch, hold_branch, reserves, hold_fill_targets, tmp_holdsqueue): $VAR1 = 'CPL'; # $VAR2 = 'IPT'; # $VAR3 = [ # { # 'priority' => '1', # 'reservenotes' => undef, # 'reservedate' => '2013-08-00', # 'found' => undef, # 'expirationdate' => undef, # 'suspend_until' => undef, # 'reminderdate' => undef, # 'biblionumber' => '92704', # 'timestamp' => '2013-08-01 12:27:34', # 'notificationdate' => undef, # 'borrowernumber' => '1000022266', # 'branchcode' => 'CPL', # 'itemnumber' => undef, # 'constrainttype' => '', # 'lowestPriority' => '0', # 'suspend' => '0', # 'waitingdate' => undef, # 'cancellationdate' => undef, # 'reserve_id' => '4361' # } # ]; # $VAR4 = [ # { # 'itemnumber' => '68955', # 'biblionumber' => '92704', # 'source_branchcode' => 'CPL', # 'borrowernumber' => '1000022266', # 'item_level_request' => '0' # } # ]; # $VAR5 = [ # { # 'firstname' => 'my firstname', # 'pickbranch' => 'CPL', # 'itemnumber' => '68955', # 'itemcallnumber' => undef, # 'reservedate' => '2013-08-00', # 'barcode' => '531703236591', # 'phone' => undef, # 'item_level_request' => '0', # 'surname' => 'my surname', # 'biblionumber' => '92704', # 'holdingbranch' => 'CPL', # 'cardnumber' => 'CARDNUMBER42', # 'notes' => undef, # 'title' => 'Test Holds Queue XXX', # 'borrowernumber' => '1000022266' # } # ]; Illegal date specified (year = 2013, month = 8, day = 00) at C4/HoldsQueue.pm line 138 # Looks like you failed 1 test of 19. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 03:31:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 01:31:05 +0000 Subject: [Koha-bugs] [Bug 9916] Use DataTables in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 03:31:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 01:31:12 +0000 Subject: [Koha-bugs] [Bug 9916] Use DataTables in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19951|0 |1 is obsolete| | --- Comment #5 from Srdjan Jankovic --- Created attachment 20030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20030&action=edit Bug 9916 - Use DataTables in the OPAC The OPAC still uses the old tablesorter plugin which isn't being actively maintained. We use DataTables in the staff client and should in the OPAC too. The plugin was added a while ago but never implemented on any pages. This patch upgrades the plugin to the latest version and places it in opac-tmpl/lib for cross-theme access. The patch implements DataTables on all pages which previously used the tablesorter plugin. The old tablesorter plugin is removed. The customized DataTable configuration script, datatables.js, has been trimmed-down from the staff client version in order to limit it to only that functionality required in the OPAC. Sorting based on date is done based on the data's enclosing title attribute as it is in the staff client: [% date | $KohaDates %] Slight modifications to Serials.pm and opac-search-history.pl have been made to accommodate this change. To test, view each page in the OPAC which uses JS-based table sorting: - The bibliographic detail page - The cart - The search history page - The suggestions page - The tags page (logged in as a user who has entered tags) - The "most popular" page (opac-topissues.pl) - The logged in user summary page (opac-user.pl) - The subscription "full history" page (opac-serial-issues.pl?selectview=full) - The self-checkout main page (with existing checkouts) Table sorting should work correctly on all pages in both the prog and ccsr themes. Sorting should work for dates whatever your dateformat system preference setting. Tables listing titles should exclude articles ("a," "an," and "the" in English) when sorting. Also test the serial collection page in the staff client, which is affected by the change to Serials.pm. Confirm that dates are displayed and sorted correctly. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 03:32:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 01:32:27 +0000 Subject: [Koha-bugs] [Bug 9916] Use DataTables in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20030|0 |1 is obsolete| | --- Comment #6 from Srdjan Jankovic --- Created attachment 20031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20031&action=edit [SIGNED-OFF] Bug 9916 - Use DataTables in the OPAC The OPAC still uses the old tablesorter plugin which isn't being actively maintained. We use DataTables in the staff client and should in the OPAC too. The plugin was added a while ago but never implemented on any pages. This patch upgrades the plugin to the latest version and places it in opac-tmpl/lib for cross-theme access. The patch implements DataTables on all pages which previously used the tablesorter plugin. The old tablesorter plugin is removed. The customized DataTable configuration script, datatables.js, has been trimmed-down from the staff client version in order to limit it to only that functionality required in the OPAC. Sorting based on date is done based on the data's enclosing title attribute as it is in the staff client: [% date | $KohaDates %] Slight modifications to Serials.pm and opac-search-history.pl have been made to accommodate this change. To test, view each page in the OPAC which uses JS-based table sorting: - The bibliographic detail page - The cart - The search history page - The suggestions page - The tags page (logged in as a user who has entered tags) - The "most popular" page (opac-topissues.pl) - The logged in user summary page (opac-user.pl) - The subscription "full history" page (opac-serial-issues.pl?selectview=full) - The self-checkout main page (with existing checkouts) Table sorting should work correctly on all pages in both the prog and ccsr themes. Sorting should work for dates whatever your dateformat system preference setting. Tables listing titles should exclude articles ("a," "an," and "the" in English) when sorting. Also test the serial collection page in the staff client, which is affected by the change to Serials.pm. Confirm that dates are displayed and sorted correctly. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 03:39:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 01:39:22 +0000 Subject: [Koha-bugs] [Bug 9916] Use DataTables in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 --- Comment #7 from Srdjan Jankovic --- I got fatal: /tmp/RDJ3G9: 657: patch contains a line longer than 998 characters warning: no patches were sent Something to worry about? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 04:20:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 02:20:37 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #2 from David Cook --- (In reply to Galen Charlton from comment #1) > (In reply to David Cook from comment #0) > > Currently, Koha only acts as a OAI-PMH server, I propose to add a harvesting > > client as well (likely using the HTTP::OAI::Harvester module), so that Koha > > can ingest records from other data sources (such as digital repositories > > like Dspace). > > Interesting idea. > I'm glad that you approve :). I think you wrote a bit on the subject a few years ago when the OAI-PMH support was first added to Koha, no? > > > I've only started reading about it but despite initial reservations about > > resumption tokens, I think the hardest part will not be with the retrieval > > of records so much as the parsing of those records into MARC. > > This may be less of a problem in the long run with my plans to allow Koha to > support multiple metadata formats (although even once that's available, you > may still want the harvester to be able to convert the source metadata into > something else). > I was thinking about that as I started my research, but I'm not sure how far along you are with your plans for metadata diversity. While I'm extremely excited for your work in that area, I suppose I wonder a bit about how feasible (both in terms of time to get there and ultimate function) it is given the current reliance of Koha on MARC data. In any case, like you say, the ability to transform incoming data might still be desired. Either in terms of changing metadata formats or even adding local data to incoming records. > > One thing I'd suggest is that the harvester keep a copy of the original > metadata record in a database table; that would be more flexible than > immediately converting it to MARC and discarding the source data. > Agreed. I was thinking of having a table to keep track of source record identifiers, since I'm still not familiar with resumption tokens, so I could certainly add columns for biblionumber and source metadata record. As you say, that would add flexibility for the future plus give people a source of truth, since data conversion isn't always precise or infallible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 08:12:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 06:12:09 +0000 Subject: [Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 08:12:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 06:12:13 +0000 Subject: [Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19991|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 20032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20032&action=edit [SIGNED-OFF] Bug 10664 : Software error in overdue_notices.pl if there is no active currency If there is no active currency, when running overdue_notices.pl you get a sofware error "Can't use an undefined value as a HASH reference" on GetCurrency() function call With this patch, if there is no active currency, fines are formated by default 0,00 and notices are correctly generated. Test plan : - have at least one borrower with overdue that should trigger a notice - verify that there is no active currency (Adminitration > Currency & Exchange rates) - run misc/cronjobs/overdue_notices.pl -v -n (to get the notice directly on output) => without the patch you get the software error => with the patch, notices are correctly generated If an active currency is defined, the script overdue_notices.pl runs the same with or without patch Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 08:14:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 06:14:37 +0000 Subject: [Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #3 from Srdjan Jankovic --- Currency stuff should be moved out of Budgets.pm ASAP. It is ridiculous for Output.pm to depend on Budgets.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 09:06:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 07:06:12 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Enhancements: SRU targets, MARC conversion, additional XSLT processing (umbrella report) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #27 from David Cook --- Hi Marcel! I'm working on a client for OAI-PMH harvesting, so I'm wondering what you're planning in regards to MARC conversion and additional XSLT processing. My plan (and WIP) at the moment is to point to a base url, harvest the records (likely in Dublin core format), store them in a MySQL table, then transform them into MARC and import into Koha. Do you see any problems with this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 09:14:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 07:14:51 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 --- Comment #7 from kenza --- (In reply to Katrin Fischer from comment #6) > Hi Kenza, > I have fixed(?) your name and email address to what it was in your last > patch going in - could you check if I did it right? You may also want to > change your git configuration to have the email address of your choice and > your full name in the patches. Hi! My name and my email address are right! And yes i'll change my git configuration right now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 09:17:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 07:17:21 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 --- Comment #8 from Katrin Fischer --- Cool, then this is ready for Galen now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 09:34:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 07:34:27 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10389 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 09:34:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 07:34:27 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10441 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 11:22:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 09:22:43 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Enhancements: SRU targets, MARC conversion, additional XSLT processing (umbrella report) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #28 from M. de Rooy --- (In reply to David Cook from comment #27) > I'm working on a client for OAI-PMH harvesting, so I'm wondering what you're > planning in regards to MARC conversion and additional XSLT processing. > > My plan (and WIP) at the moment is to point to a base url, harvest the > records (likely in Dublin core format), store them in a MySQL table, then > transform them into MARC and import into Koha. > > Do you see any problems with this? Hi David, Looks like: No problems. Will add XSLT transformations on the returned Z3950 results and will add SRU targets as Z3950 servers. (MARC conversion will be possible via the XSLTs, but I will not include it specifically anymore.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 12:13:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 10:13:18 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 12:13:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 10:13:22 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19602|0 |1 is obsolete| | --- Comment #4 from M. de Rooy --- Created attachment 20033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20033&action=edit Bug 10389: Share a list (part 2: accept the invitation) What it does: As a followup on report 9032 where you can send an invitation to share a private list, this report handles the response by the invited person. If he accepts this share, the private list of the sender will be shown under Your lists on the shelves page. In OPAC 'Your private lists' has been renamed to Your lists (just as in Staff). The Type column shows Private or Shared for these lists; a list appears as Shared as soon as an invitation has been accepted. The owner has the options to Edit, Delete or Share; the invited person does not have these options on the shared list. Test plan: Enable pref OpacAllowSharingPrivateLists user 1 creates new private list P1, perms: D-A-D, adds 2 items, sends share user 1 checks your lists display in opac or staff: P1 shows Private with options user 2 accepts share: sees P1, but cannot add or delete items user 2 checks your lists display again: P1 shows Shared without options user 1 checks your lists display again: P1 shows Shared with options user 2 tries to accept share again: should fail now user 3 tries to accept share: should also fail user 3 tries again, modifies shelfnumber and/or key in url: should also fail user 2 creates new private list P2, perms: A-A-A, no items, sends share user 2 checks your lists display: P2 shows Private with options user 1 accepts, adds one item user 1 checks your lists display: P2 shows Shared without options user 2 checks your lists display: P2 shows Shared with options user 2 deletes item of user 1 (allowed) user 2 deletes list P2 user 1 checks your lists display in opac or staff: P2 is gone Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 12:13:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 10:13:29 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 --- Comment #5 from M. de Rooy --- Created attachment 20034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20034&action=edit Bug 10389: Add unit tests for AcceptShare and IsSharedList The first patch of bug 10389 adds two new routines to VirtualShelves.pm. This patch adds unit tests for them. Test plan: Run unit test t/db_dependent/VirtualShelves.t. Do all 95 tests pass? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 13:15:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 11:15:19 +0000 Subject: [Koha-bugs] [Bug 10670] New: /etc/init.d/koha-common fails to start zebra due to log permission problem Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10670 Bug ID: 10670 Summary: /etc/init.d/koha-common fails to start zebra due to log permission problem Change sponsored?: --- Product: Koha Version: 3.6 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: dpavlin at rot13.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 13:25:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 11:25:45 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #6 from Kyle M Hall --- 9531 has passed qa at this point, so I think it's time to move forward with this now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 13:31:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 11:31:22 +0000 Subject: [Koha-bugs] [Bug 9916] Use DataTables in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 --- Comment #8 from Owen Leonard --- (In reply to Srdjan Jankovic from comment #7) > fatal: /tmp/RDJ3G9: 657: patch contains a line longer than 998 characters > warning: no patches were sent This is a common problem if you try to use git to send an patch that contains a minified JavaScript file. If it was something you needed to get to the patches mailing list you'd have to mail it by hand. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 13:36:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 11:36:52 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 --- Comment #7 from Kyle M Hall --- I'm still getting fatal: sha1 information is lacking or useless (C4/SIP/Sip.pm) Could you upload a new copy of the patch? Also, a minor stylistic suggestions: What do you think about changing $encoding ||= q{}; my $cksum; if ($encoding ne '') { $msg = encode($encoding, $msg); } to $msg = encode($encoding, $msg) if ( $encoding ); my $cksum; as it groups the code a bit more logically and tersely ( and maybe a picosecond faster ). With this, the possible undef doesn't need to be converted to an empty string, as there is no need for a string comparison. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 13:37:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 11:37:44 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 13:42:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 11:42:06 +0000 Subject: [Koha-bugs] [Bug 10670] /etc/init.d/koha-common fails to start zebra due to log permission problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10670 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 13:45:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 11:45:04 +0000 Subject: [Koha-bugs] [Bug 10670] /etc/init.d/koha-common fails to start zebra due to log permission problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10670 --- Comment #1 from Dobrica Pavlinusic --- Created attachment 20035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20035&action=edit Bug 10670 - koha-common fails to start zebra without log permissions If koha-common is started when zebra log files are owned by root it will fail to start without any useful message (since zebra can't write errors in log files because it lacks permissions to do so). This patch creates empty log files and ensure they have correct permissions. I can't pin-point why log files gets owned root, but I suspect it has something to do with zebra crashing and logrotate, but this is just theory. We have seen this behaviour since koha 3.1 every few months, and every time it happends we have root owned logs and crashed zebra so this patch will at least help sites which have some kind of automatic koha-common start if it's not running. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:03:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 12:03:42 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19978|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard --- Comment on attachment 19978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19978 one example there was a space in the description of periodicals on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:04:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 12:04:37 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 --- Comment #5 from Nicole C. Engard --- In the second example the lib is set to the same as the code - the lib_opac is set to the text. The search seems to be sorting on lib not lib_opac. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:07:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 12:07:46 +0000 Subject: [Koha-bugs] [Bug 10117] Byte Order Mark breaks Patron Import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10117 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #1 from Magnus Enger --- I have had customers complaining about not being able to import data from Excel into Koha, but when I have saved the same data from LibreOffice Calc it has worked. Could this be the same problem? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:13:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 12:13:56 +0000 Subject: [Koha-bugs] [Bug 9195] nav overlaps lists in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9195 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #5 from Owen Leonard --- Sorry, the left-hand sidebar is fixed-width in both themes. I would choose to mark this "WONTFIX," but if you can change it to an enhancement request if you prefer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:23:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 12:23:11 +0000 Subject: [Koha-bugs] [Bug 10671] New: Koha 3.14 Help Files Update Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Bug ID: 10671 Summary: Koha 3.14 Help Files Update Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org This is the running bug for the 3.14 help files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:26:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 12:26:46 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 --- Comment #7 from Kyle M Hall --- At least the date error doesn't appear to be related to my patches. It appears that mysql doens't like subtracting from dates the day it's done on line 103 for the unit test. This will fail on the first of every month! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:37:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 12:37:26 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19862|0 |1 is obsolete| | Attachment #19863|0 |1 is obsolete| | Attachment #20010|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 20036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20036&action=edit Bug 10628 - AutomaticItemReturn prevents holds queue from filling local holds with local items For some reason, C4::HoldsQueue::MapItemsToHoldRequests uses the system preference AutomaticItemReturn to decide if an attempt to fill local holds with local items. No explanation of this behavior is provided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:40:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 12:40:44 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 --- Comment #1 from Nicole C. Engard --- Created attachment 20037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20037&action=edit Bug 10671: Help files for course reserves This patch adds the missing help files for course reserves. To test: * visit every page related to course reserves in the staff client * click help in the top right * review the help file for typos/content/links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:41:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 12:41:27 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:46:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 12:46:10 +0000 Subject: [Koha-bugs] [Bug 9195] nav overlaps lists in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9195 --- Comment #6 from Nicole C. Engard --- Owen, Will your new theme solve this? If so then I'd say we wait for that. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:58:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 12:58:15 +0000 Subject: [Koha-bugs] [Bug 9195] nav overlaps lists in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9195 --- Comment #7 from Owen Leonard --- No, sorry, it won't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 15:07:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 13:07:00 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 --- Comment #6 from M. de Rooy --- Created attachment 20038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20038&action=edit Bug 10389: Remove an accepted share If a user accepted a share, this patch allows him to remove it again. A new routine is added to VirtualShelves.pm. The Remove Share button is visible on OPAC when viewing Your lists or a particular shared list. Test plan: User 1 creates private list P3, sends a share. User 1 creates private list P4, adds one item, sends a share. User 2 accepts the share for P3. User 2 checks the shelves display, and removes share P3. User 2 accepts the share for P4. User 2 views shelf P4 with one item and confirms Remove share on that form. User 2 checks shelves display again. Run the adjusted test unit too. Did all 96 tests pass? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 15:12:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 13:12:41 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 --- Comment #7 from M. de Rooy --- Together with bug 9032, I think these patches are Koha-ready imo. You can share lists, remove the shares and end sharing by deleting the list. Note that I did omit adding the share/accept functions on the staff side, just viewing it as an opac function (like others?). But if really wanted or needed, a similar staff script can be added later on. Without blocking this report too, I still plan adding the option to optionally disown instead of delete a shared or public list. (The owner wants to get rid of the list, but the other users may still like it.) That report will come with some functionality too to handle the lists without owner at staff side (including permissions). Another remaining item to discuss and perhaps handle on a new report, would be handling name clashes. See Comment 1. For now, please help with sign-off or QA.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 15:15:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 13:15:18 +0000 Subject: [Koha-bugs] [Bug 9195] nav overlaps lists in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9195 --- Comment #8 from Nicole C. Engard --- Alright, can you give me the width? So I can put it in the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 15:22:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 13:22:38 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 --- Comment #6 from Owen Leonard --- Created attachment 20039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20039&action=edit Bug 10656 - shelving locations not alpha on search Collection codes and shelving locations are displayed in the OPAC and staff client via GetAuthorisedValues which currently sorts results by "lib, lib_opac." Consequently if lib (the description for the staff client) doesn't match lib_opac (the description for the OPAC) sorting will appear to be nonsensical in the OPAC. GetAuthorisedValues can be passed an $opac parameter, so this should be used to switch how reuslts are sorted. This patch implements such a switch. To test, modify your collection code or shelving location authorized values so that lib and lib_opac do not match. Set your AdvancedSearchTypes system preference to display the modified authorized values and view the advanced search page in the OPAC and staff client. Sorting should be correct in each case according to the correct value (lib in the staff client, lib_opac in the OPAC). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 15:22:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 13:22:35 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 15:37:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 13:37:51 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20039|0 |1 is obsolete| | --- Comment #7 from Nicole C. Engard --- Created attachment 20040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20040&action=edit [SIGNED-OFF] Bug 10656 - shelving locations not alpha on search Collection codes and shelving locations are displayed in the OPAC and staff client via GetAuthorisedValues which currently sorts results by "lib, lib_opac." Consequently if lib (the description for the staff client) doesn't match lib_opac (the description for the OPAC) sorting will appear to be nonsensical in the OPAC. GetAuthorisedValues can be passed an $opac parameter, so this should be used to switch how reuslts are sorted. This patch implements such a switch. To test, modify your collection code or shelving location authorized values so that lib and lib_opac do not match. Set your AdvancedSearchTypes system preference to display the modified authorized values and view the advanced search page in the OPAC and staff client. Sorting should be correct in each case according to the correct value (lib in the staff client, lib_opac in the OPAC). Signed-off-by: Nicole C. Engard Tested in staff and opac and it works perfectly! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 15:38:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 13:38:03 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 15:47:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 13:47:49 +0000 Subject: [Koha-bugs] [Bug 10619] sco.css missing for CCSR OPAC templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 16:13:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 14:13:59 +0000 Subject: [Koha-bugs] [Bug 10619] sco.css missing for CCSR OPAC templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 16:14:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 14:14:05 +0000 Subject: [Koha-bugs] [Bug 10619] sco.css missing for CCSR OPAC templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 --- Comment #2 from Owen Leonard --- Created attachment 20041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20041&action=edit Bug 10619 - sco.css missing for CCSR OPAC templates sco.css is not missing from CCSR, but some image paths in the CSS are incorrect, resulting in some missing images. This patch corrects those broken paths. This patch also hides the Cart/Lists/login region of the template which should not be visible in self checkout. To test, enable self-checkout and switch to the CCSR theme. Load a patron for self-checkout and confirm that images associated with buttons appear correctly: By the help link in the upper-right, on the 'Finish' button, etc. Try checking out an item which is already checked out to that patron to see more examples. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 16:21:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 14:21:05 +0000 Subject: [Koha-bugs] [Bug 9195] nav overlaps lists in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9195 --- Comment #9 from Owen Leonard --- The width of the left-hand sidebar is set in em (12.3207em), so I can't tell you a pixel-specific value. You'd have to experiment to see what fit well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 16:24:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 14:24:43 +0000 Subject: [Koha-bugs] [Bug 9253] If an item is reserved, at the opac it is marked as available In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 16:38:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 14:38:15 +0000 Subject: [Koha-bugs] [Bug 5652] Patron checkout and holds summary should show subtitles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5652 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19069|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 20042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20042&action=edit [SIGNED-OFF] Bug 5652 - Patron checkout and holds summary should show subtitles This patch adds subtitles (from Keyword to MARC mapping) to following tables on the checkout page: - Checkouts - Previous checkouts - Relative's checkouts - Relative's previous checkouts - Holds Additionaly it suppresses the appearence of the superfluous word "by" in cases where the biblio has no author. Test scenario: -------------- 1) Make sure that you have one or more fields mapped to subtitle in: Home . Administration . Keyword to MARC mapping (e.g. 245 b) 2) Test the checkout page with patrons having - current checkouts (today) - previous checkouts - relatives (e.g. kids) with current /previous checkouts - holds on items - holds on biblios ...with items having: - title, subtitle, author - title, no subtitle, author - title, subtitle, no author - title, no subtitle, no author 3) Do the same on patron's detail page Signed-off-by: Nicole C. Engard All tests pass Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 16:56:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 14:56:39 +0000 Subject: [Koha-bugs] [Bug 10672] New: Add subtitle to display of checkouts, overdues, and holds on the patron summary Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672 Bug ID: 10672 Summary: Add subtitle to display of checkouts, overdues, and holds on the patron summary Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/opac-user.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org In the OPAC, the patron summary page (opac-user.pl) doesn't show subtitle in the lists of checkouts, overdues, or holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:03:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 15:03:30 +0000 Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts, overdues, and holds on the patron summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:03:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 15:03:39 +0000 Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts, overdues, and holds on the patron summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672 --- Comment #1 from Owen Leonard --- Created attachment 20043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20043&action=edit Bug 10672 - Add subtitle to display of checkouts, overdues, and holds on the patron summary In the OPAC, the patron summary page (opac-user.pl) should display subtitle along with title in the lists of checkouts, overdues, and holds. This patch adds it. To test, log in to the OPAC as a patron who has checkouts, overdues, and holds which include titles with subtitles. Titles should appear correctly with and without subtitles. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:10:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 15:10:42 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master, along with a follow-up to fix some typos in the test descriptions. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:13:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 15:13:48 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:24:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 15:24:10 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #27 from Galen Charlton --- Koha's license is GPL3+, not GPL2+. I also assume that opac/opac-overdrive-search.pl is copyright 2013 ByWater, not 2009 BibLibre. I will not push this without clarification of the licensing. I am willing to make the necessary follow-up patch to correct the headers, but I need somebody from ByWater to make the following confirmations in this bug: [1] That ByWater is licensing the code as GPL3+. [2] Whether opac/opac-overdrive-search.pl is actually copyright 2013 by ByWater. Setting to Failed QA pending those confirmations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:24:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 15:24:23 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 18:52:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 16:52:23 +0000 Subject: [Koha-bugs] [Bug 10493] Add renewal script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19155|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 20044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20044&action=edit Bug 10493 - Add renewal script Koha needs a renewal tool that functions similar to the returns where a librarian can continuously scan items for renewal. This script should block renewals that are impossible, and allow the same renewal overrides as circulation.pl Test plan: 1) Apply the patches for bug 8798 2) Apply this patch 3) Browse to /cgi-bin/koha/circ/renew.pl 4) Enter an invalid barcode, you should get an error message 5) Enter a valid, but not checked out barcode, you should get an error message. 6) Enter a valid barcode that is checkout out and should be renewable, you should get a success message. 7) Enable AllowRenewalLimitOverride 8) Enter a barcode for an item that has been renewed too many times 9) You should get a warning which you can override. 10) Disable AllowRenewalLimitOverride 11) Repeat steap 8 12) You should get a blocking error message 11) Enter a barcode for an item with unfilled holds on it, you should get an overridable warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 19:25:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 17:25:08 +0000 Subject: [Koha-bugs] [Bug 10493] Add renewal script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hbraum at nekls.org --- Comment #3 from Heather Braum --- I, Heather Braum, from NEKLS sign off on this patch. We have tested it and it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:44:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 18:44:36 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20019|0 |1 is obsolete| | --- Comment #18 from Owen Leonard --- Created attachment 20045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20045&action=edit [SIGNED-OFF] Bug 10402: Use an object for contacts In preparation for adding the ability to handle multiple contacts, this patch moves booksellers' contacts into their own class, C4::Bookseller::Contact. To test: 1) Apply patch. 2) Run database update. 3) Edit a bookseller, making sure to add a contact. 4) View the bookseller's information, making sure the contact information is there. 5) Run the unit test: > prove t/db_dependent/Bookseller.t Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:44:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 18:44:52 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20020|0 |1 is obsolete| | --- Comment #19 from Owen Leonard --- Created attachment 20046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20046&action=edit [SIGNED-OFF] Bug 10402: Move contacts to separate table This patch normalizes the data structures used for bookseller contacts. To test: 1) Repeat tests described on previous patch. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:45:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 18:45:06 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20021|0 |1 is obsolete| | --- Comment #20 from Owen Leonard --- Created attachment 20047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20047&action=edit [SIGNED-OFF] Bug 10402: Add ability to enter multiple contacts Some vendors may have more than one contact. For example, a technical contact and a billing contact, or a contact for journals and a contact for monographs. Rather than require that each contact be either made into a separate vendor or recorded somewhere outside of Koha, it would be really useful of Koha had the ability to add multiple additional contacts to vendors in the Acquisitions module. To test: 1) Apply patch. 2) Edit a bookseller, making sure to add a contact. 3) View the bookseller's information, making sure the contact information is there. 4) Run the unit test: > prove t/db_dependent/Bookseller.t 5) Add multiple contacts to a vendor, see that they show up. 6) Delete one contact from a vendor with multiple contacts, see that the result is correct. 7) Sign off. Note: This test plan can supersede that on the previous two patches, as all functionality of the previous two patches is required by this one. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:45:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 18:45:12 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 --- Comment #21 from Owen Leonard --- Created attachment 20048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20048&action=edit Bug 10402 [Template follow-up] Add multiple contacts for vendors This template-only follow-up tweaks the button labels and restructures the vendor view layout a little bit to make it more amenable to multiple contacts: - Add spaces after button icons - Change "Add contact" to "Add another contact" in hopes of making it less ambiguous whether clicking it will submit the whole form. - Eliminate duplicate headers on the vendor view page by making the contact name the subheading for each individual contact. To test, view details for vendors with one or more contacts, and try editing to add additional contacts. Everything should look good and work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:49:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 18:49:32 +0000 Subject: [Koha-bugs] [Bug 10493] Add renewal script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #4 from Owen Leonard --- I would like to test this too but it doesn't apply. Applying: Bug 10493 - Add renewal script Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... CONFLICT (modify/delete): Koha/Schema/Result/Item.pm deleted in HEAD and modified in Bug 10493 - Add renewal script. Version Bug 10493 - Add renewal script of Koha/Schema/Result/Item.pm left in tree. CONFLICT (modify/delete): Koha/Schema/Result/Issue.pm deleted in HEAD and modified in Bug 10493 - Add renewal script. Version Bug 10493 - Add renewal script of Koha/Schema/Result/Issue.pm left in tree. Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:59:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 18:59:44 +0000 Subject: [Koha-bugs] [Bug 10493] Add renewal script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #5 from Owen Leonard --- Oh sorry, probably the dependency, which I missed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 21:54:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 19:54:07 +0000 Subject: [Koha-bugs] [Bug 10493] Add renewal script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20044|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 20049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20049&action=edit [SIGNED-OFF] Bug 10493 - Add renewal script Koha needs a renewal tool that functions similar to the returns where a librarian can continuously scan items for renewal. This script should block renewals that are impossible, and allow the same renewal overrides as circulation.pl Test plan: 1) Apply the patches for bug 8798 2) Apply this patch 3) Browse to /cgi-bin/koha/circ/renew.pl 4) Enter an invalid barcode, you should get an error message 5) Enter a valid, but not checked out barcode, you should get an error message. 6) Enter a valid barcode that is checkout out and should be renewable, you should get a success message. 7) Enable AllowRenewalLimitOverride 8) Enter a barcode for an item that has been renewed too many times 9) You should get a warning which you can override. 10) Disable AllowRenewalLimitOverride 11) Repeat steap 8 12) You should get a blocking error message 11) Enter a barcode for an item with unfilled holds on it, you should get an overridable warning Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 21:55:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 19:55:21 +0000 Subject: [Koha-bugs] [Bug 10493] Add renewal script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 21:55:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 19:55:25 +0000 Subject: [Koha-bugs] [Bug 10493] Add renewal script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493 --- Comment #7 from Owen Leonard --- Created attachment 20050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20050&action=edit Bug 10493 [Template follow-up] Add renewal script This template followup fixes some minor template errors and adds some style to dialog buttons matching those seen on the circulation page. To test, submit barcodes to trigger the various error conditions: Non-existant barcode, over the renew limit, restricted patron, item on hold. Override and Ignore buttons should be properly styled and functional. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 22:24:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 20:24:20 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 22:24:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 20:24:24 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19976|0 |1 is obsolete| | --- Comment #13 from Owen Leonard --- Created attachment 20051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20051&action=edit [SIGNED-OFF] Bug 10513 - Light up a warning/message when returning a chosen item type This patch adds a new column to item types. Text in this column is displayed as a warning when an item of the given type is checked in. The type of message can also be chosen, affecting how the message is displayed. Use case: Items that are on inter-library loan can have a separate item type, and when items of this type are checked in a message saying something like "ILL! Remember to return it to the owning library!" can be displayed. To test: - Apply the patch - Go to Home > Administration > Item types administration - Check that there is a new column, called "Check in message" - Edit an item type and add a check in message - Check that the check in message you added is displayed in the table - Check in an item with an item type that has a check in message - Check that the message is displayed - Repeat the steps above, but select "Alert" instead of the default "Message" as the "Check in message type". Check that the message is displayed in a yellow alert box, not a blue message box. - Check in an item with an item type that does *not* have a check in message, and make sure no false messages are displayed - Create a new item type from scratch and check that it works the way it is supposed to - Run the tests in t/ItemType.t, which are updated by this patch This patch also removes backticks around column names in the itemtypes table in installer/data/mysql/kohastructure.sql UPDATE 2013-07-22 - Rebased on current master (no changes) - Added "AFTER summary" to the SQL statement in updatedatabase.pl - Added another placeholder on line 170 of admin/itemtypes.pl Thanks Katrin! UPDATE 2013-07-29 - Make this message independent of all other messages - thanks Owen! - Make it possible to choose the type of message ("alert" or "message") Sponsored-by: Kultur i Halland - Regionbibliotek Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 01:22:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 23:22:36 +0000 Subject: [Koha-bugs] [Bug 9916] Use DataTables in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 --- Comment #9 from Srdjan Jankovic --- Ok, so you want me to email it separately? I mean how important it is? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 01:29:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 23:29:59 +0000 Subject: [Koha-bugs] [Bug 10673] New: Message hide timeout can go out of sync in preferences.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10673 Bug ID: 10673 Summary: Message hide timeout can go out of sync in preferences.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, jcamins at cpbibliography.com Quote from IRC: <@jcamins> pianohacker: [the save notification] won't hide, but then when you click save again, it'll hide the new one immediately after it displays. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 01:32:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 23:32:24 +0000 Subject: [Koha-bugs] [Bug 10674] New: System preferences not marked as modified after paste Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10674 Bug ID: 10674 Summary: System preferences not marked as modified after paste Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, wizzyrea at gmail.com When text is pasted into a field in preferences.pl, it is not marked as modified, and must be touched manually before it can be saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 01:53:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 23:53:26 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 01:53:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 23:53:30 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20036|0 |1 is obsolete| | --- Comment #9 from Srdjan Jankovic --- Created attachment 20052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20052&action=edit [SIGNED-OFF] Bug 10628 - AutomaticItemReturn prevents holds queue from filling local holds with local items For some reason, C4::HoldsQueue::MapItemsToHoldRequests uses the system preference AutomaticItemReturn to decide if an attempt to fill local holds with local items. No explanation of this behavior is provided. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 01:56:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2013 23:56:49 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 --- Comment #10 from Srdjan Jankovic --- I'll make a mental note - MySQL is *NOT* Oracle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 04:48:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 02:48:11 +0000 Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts, overdues, and holds on the patron summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 04:48:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 02:48:15 +0000 Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts, overdues, and holds on the patron summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20043|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 20053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20053&action=edit [SIGNED-OFF] Bug 10672 - Add subtitle to display of checkouts, overdues, and holds on the patron summary In the OPAC, the patron summary page (opac-user.pl) should display subtitle along with title in the lists of checkouts, overdues, and holds. This patch adds it. To test, log in to the OPAC as a patron who has checkouts, overdues, and holds which include titles with subtitles. Titles should appear correctly with and without subtitles. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 05:25:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 03:25:00 +0000 Subject: [Koha-bugs] [Bug 10619] sco.css missing for CCSR OPAC templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 05:25:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 03:25:16 +0000 Subject: [Koha-bugs] [Bug 10619] sco.css missing for CCSR OPAC templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20041|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic --- Created attachment 20054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20054&action=edit [SIGNED-OFF] Bug 10619 - sco.css missing for CCSR OPAC templates sco.css is not missing from CCSR, but some image paths in the CSS are incorrect, resulting in some missing images. This patch corrects those broken paths. This patch also hides the Cart/Lists/login region of the template which should not be visible in self checkout. To test, enable self-checkout and switch to the CCSR theme. Load a patron for self-checkout and confirm that images associated with buttons appear correctly: By the help link in the upper-right, on the 'Finish' button, etc. Try checking out an item which is already checked out to that patron to see more examples. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 05:30:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 03:30:26 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #6 from Srdjan Jankovic --- # Testing Batch->get_attr() method. # Testing Batch->add_item() method. # Testing Batch->retrieve() method. # Failed test at t/db_dependent/Labels/t_Batch.t line 100. # Structures begin differing at: # $got = '-2' # $expected = C4::Labels::Batch=HASH(0x3aaa5b8) # Retrieved batch object FAILED to verify. # Testing Batch->remove_item() method. # Failed test at t/db_dependent/Labels/t_Batch.t line 109. # Structures begin differing at: # $got = '-2' # $expected = C4::Labels::Batch=HASH(0x3aaa5b8) # Updated batch object FAILED to verify. # Testing Batch->delete() method. # Looks like you planned 33 tests but ran 13. Do I need some setup first? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 05:42:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 03:42:25 +0000 Subject: [Koha-bugs] [Bug 10668] Improve suggestion detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- It is a bit nicer to say return confirm(_("Are you sure you want to delete this suggestion?")); rather than var is_confirmed = confirm(_("Are you sure you want to delete this suggestion?")); if (is_confirmed) { return true; } else { return false; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 08:23:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 06:23:22 +0000 Subject: [Koha-bugs] [Bug 10675] New: Move spinelabel.css to system preference Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10675 Bug ID: 10675 Summary: Move spinelabel.css to system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label printing Assignee: cnighswonger at foundations.edu Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Editing of the spinelabel.css file should be done via a system preference as this is thought to be library specific. The spinelabel.css file is used for formatting labels printed with the quick spine label creator. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 08:56:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 06:56:31 +0000 Subject: [Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 10:14:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 08:14:30 +0000 Subject: [Koha-bugs] [Bug 10676] New: OpacHiddenItems not working for restricted Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Bug ID: 10676 Summary: OpacHiddenItems not working for restricted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 10:23:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 08:23:11 +0000 Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #1 from Katrin Fischer --- For this configuration in OpacHiddenItems wthdrawn and notforloan work, but restricted does not: notforloan: [2] wthdrawn: [2] restricted: [2] Looking at the code I didn't see a reason for this. If someone could test and confirm/invalidate this bug it would be appreciated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 11:42:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 09:42:54 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19837|0 |1 is obsolete| | --- Comment #8 from Fridolyn SOMERS --- Created attachment 20055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20055&action=edit Bug 10588 - opac-topissues first branch always selected in filters (revised) Revised patch, same test plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 11:43:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 09:43:18 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 11:50:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 09:50:18 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 --- Comment #9 from Fridolyn SOMERS --- (In reply to Galen Charlton from comment #7) Indeed, I changed my mind about '__ANY__'. Because the purpose of this patch is to distinguish form display and form post with a filter on all branches. There is already a way to do this : use the hidden input named 'do_it' which is undef when form is displayed and '1' when form is posted. This is used in a lot of pages and seems to me more clear code than using '__ANY__'. I think '__ANY__' is only used in suggestions because there are suggestions with no branch and so there may be a filter with 3 cases : a branch selected, any branch and no branch. Setting to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 14:46:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 12:46:45 +0000 Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 --- Comment #4 from Owen Leonard --- Created attachment 20056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20056&action=edit Screenshot of batch operation after applying the patch This patch doesn't solve the problem for me. See the attached screenshot. I still don't get the option to make any modifications. The table and its related controls shouldn't be shown at all. All I should see is the message ("Too many items" -- and properly styled in a
) and the form for making modifications. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 14:47:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 12:47:11 +0000 Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- Also, please provide a proper test plan with any new patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:10:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 14:10:08 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:14:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 14:14:07 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal --- Comment #2 from Nicole C. Engard --- upping severity on this because it causes a lot of confusion in the trainings i'm doing lately -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:15:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 14:15:28 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:17:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 14:17:19 +0000 Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:19:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 14:19:31 +0000 Subject: [Koha-bugs] [Bug 10339] make the content of some help files templates marflavor dependent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10339 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:20:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 14:20:57 +0000 Subject: [Koha-bugs] [Bug 10344] add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:22:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 14:22:03 +0000 Subject: [Koha-bugs] [Bug 10345] Copy number should be incremented when adding multiple items at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10345 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:30:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 14:30:51 +0000 Subject: [Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #3 from Galen Charlton --- (In reply to Srdjan Jankovic from comment #2) > I propose something even better then - get rid of prepare() all together. > For example: > > * GetClassSources(): > return $dbh->selectall_hashref("SELECT...", undef, 'cn_source'); > > * AddClassSource() > return $dbh->do("INSERT...", undef, @params) > > etc. How often are those used to get advantage of prepare_cached()? > Good databases (tm) cache queries anyway, however not sure that MySQL does. Getting rid of $sth->finish() and replacing prepare_cached() with prepare() suffices as a minimal change, but doesn't preclude going further and using selectall_hashref. As far as the current patch is concerned, I do think it would be useful to at least get rid of prepare_cached(). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:31:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 14:31:12 +0000 Subject: [Koha-bugs] [Bug 10349] Don't show empty Descriptions/Title notes tabs in OPAC and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:51:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 14:51:20 +0000 Subject: [Koha-bugs] [Bug 6293] Add a button to the intranet for registering with the Koha community In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6293 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:02:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 15:02:24 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19643|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 20057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20057&action=edit Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:02:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 15:02:47 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:02:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 15:02:56 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19644|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 20058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20058&action=edit Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:10:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 15:10:40 +0000 Subject: [Koha-bugs] [Bug 10498] Place Hold on Order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:27:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 15:27:53 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:28:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 15:28:09 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18894|0 |1 is obsolete| | --- Comment #103 from Kyle M Hall --- Created attachment 20059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20059&action=edit Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:44:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 15:44:33 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:44:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 15:44:46 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #104 from Kyle M Hall --- Created attachment 20060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20060&action=edit Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:46:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 15:46:24 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20059|Bug 6874: Move uploadPath |[SIGNED-OFF] Bug 6874: Move description|syspref to koha-conf.xml |uploadPath syspref to | |koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:02:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:02:45 +0000 Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18598|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Created attachment 20061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20061&action=edit Bug 10013 - Ability to link directly from an item in the Staff client to budget information. To Test: 1) Create budget and fund under budget administration. 2) Create Vendor in acquisitons module. 3) Create basket under vendor. 4) Create order and choose budget while creating order. 5) Receive shipment. 6) Check in catalog details, in holding tab budget information column is displayed , on click it should display the budget information. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:03:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:03:17 +0000 Subject: [Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372 --- Comment #11 from Sophie MEYNIEUX --- Created attachment 20062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20062&action=edit Bug 9372 : Replaces carriage return with
in printed html files for overdues. For pdf generation, html files need explicit
html tags. With this patch, carriage return are replaced by
when letters are written into html files. Test plan : - Ensure you've got at least one reader with overdue triggering notice - Ensure that your notice template got html checked - Run misc/cronjobs/overdue_notices.pl -v -n -html and misc/cronjobs/printoverdues.sh Without patch, the content of the letter is all on one line in pdf file With the patch, pdf file is correctly formated - remove your reader email - Run misc/cronjobs/overdue_notices.pl -v -html and misc/cronjobs/printoverdues.sh Without patch, the content of pdf file is all on one line with the patch, pdf file is correctly formated. - restore reader email - run misc/cronjobs/overdue_notice.pl -v -html Verify that the a message has been generated in message_queue table With or without patch, the message is the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:03:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:03:31 +0000 Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18600|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 20063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20063&action=edit Bug-10013-New unit tests for routine: GetBudgetInfoFromItemnumber Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:05:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:05:01 +0000 Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:05:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:05:51 +0000 Subject: [Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |sophie.meynieux at biblibre.co | |m Assignee|stephane.delaune at biblibre.c |sophie.meynieux at biblibre.co |om |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:06:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:06:20 +0000 Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18600|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:06:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:06:26 +0000 Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20063|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:06:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:06:31 +0000 Subject: [Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14547|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:07:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:07:23 +0000 Subject: [Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14548|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:07:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:07:27 +0000 Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18600|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 20064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20064&action=edit Bug-10013-New unit tests for routine: GetBudgetInfoFromItemnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:09:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:09:56 +0000 Subject: [Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372 --- Comment #12 from Sophie MEYNIEUX --- To take Kratin's comment into account, I propose this new patch that changes carriage returns with
only in printed files if paramter file format is html. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:10:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:10:09 +0000 Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Kyle M Hall --- The feature patch works as advertised, but I'm a bit confused by the unit test. There is language in it that says it's a stub, it it's not. Additionally, it doesn't mock any data, and fails for me. It makes invalid assumptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:17:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:17:09 +0000 Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:19:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:19:27 +0000 Subject: [Koha-bugs] [Bug 10677] New: C4::Search::GetSearchHistory is broken and unused Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10677 Bug ID: 10677 Summary: C4::Search::GetSearchHistory is broken and unused Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org C4::Search::GetSearchHistory does not work, as it contains a SQL syntax error: SELECT FROM search_history WHERE... Its broken state is not visible to users, however, because that routine is not used -- opac-search-history.pl is doing a direct SQL query, which is not ideal. GetSearchHistory should be fixed, then put in use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:20:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:20:04 +0000 Subject: [Koha-bugs] [Bug 10365] Using published date on routing slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10365 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:20:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:20:16 +0000 Subject: [Koha-bugs] [Bug 10365] Using published date on routing slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10365 --- Comment #2 from Kyle M Hall --- Created attachment 20065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20065&action=edit bug 10365 change routing slips to use date published rather than planned date Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:20:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:20:41 +0000 Subject: [Koha-bugs] [Bug 10472] Receipt by line or invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10472 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:25:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:25:15 +0000 Subject: [Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:25:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:25:26 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:25:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:25:24 +0000 Subject: [Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19950|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 20066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20066&action=edit Bug 10645: Missing zebra languages in koha-create manpage There where some missing zebra language options in the man page for koha-create. Trivial string change. To+ Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:25:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:25:36 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18839|0 |1 is obsolete| | --- Comment #8 from Galen Charlton --- Created attachment 20067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20067&action=edit Bug 10361: (follow-up) add tests for search history functions This adds tests for the new PurgeSearchHistory function and AddSearchHistory. GetSearchHistory is not tested due to its current broken state (see bug 10667). To test: [1] Run prove -v t/db_dependent/Search_SearchHistory.t [2] Verify that all tests pass. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:26:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:26:47 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20067|0 |1 is obsolete| | --- Comment #9 from Galen Charlton --- Created attachment 20068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20068&action=edit Bug 10361: Add option to cleanup_database.pl to purge OPAC search history Add an option to cleanup_database.pl to purge the search_history entries older than X days. Test plan: - Apply patch - Check that your test DB has some entries a little older than 30 days and a few ones even older than that in search_history: SELECT * FROM search_history WHERE time < DATE_SUB( NOW(), INTERVAL 30 DAY ); If not, modify some existing entries. - Run cleanup_database with a fixed number of days (replace XX with something higher than 30) /misc/cronjobs/cleanup_database.pl --searchhistory XX - Check that entries older than XX days got deleted from search_history - Run without the day parameter /misc/cronjobs/cleanup_database.pl --searchhistory - Check that entries older than 30 days got deleted from search_history Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:27:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:27:16 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 --- Comment #10 from Galen Charlton --- Created attachment 20069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20069&action=edit Bug 10361: (follow-up) add tests for search history functions This adds tests for the new PurgeSearchHistory function and AddSearchHistory. GetSearchHistory is not tested due to its current broken state (see bug 10667). To test: [1] Run prove -v t/db_dependent/Search_SearchHistory.t [2] Verify that all tests pass. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:27:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:27:59 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 --- Comment #11 from Galen Charlton --- I've signed off on the patch and added a follow-up that adds some tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:31:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:31:02 +0000 Subject: [Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:31:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:31:16 +0000 Subject: [Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19673|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 20070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20070&action=edit Bug 10593 - AuthoritiesLog should default to yes This trivial patch set the default to 'yes' for this system preference. To test, On a clean install - Navigate Home > Administration > Global System preferences > Logs - AuthoritiesLog is set to "Don't log" Apply the patch, install koha on a new DB. - Navigate Home > Administration > Global System preferences > Logs - AuthoritiesLog should be set to "Log" Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:39:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:39:08 +0000 Subject: [Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:39:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:39:18 +0000 Subject: [Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20062|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 20071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20071&action=edit Bug 9372 : Replaces carriage return with
in printed html files for overdues. For pdf generation, html files need explicit
html tags. With this patch, carriage return are replaced by
when letters are written into html files. Test plan : - Ensure you've got at least one reader with overdue triggering notice - Ensure that your notice template got html checked - Run misc/cronjobs/overdue_notices.pl -v -n -html and misc/cronjobs/printoverdues.sh Without patch, the content of the letter is all on one line in pdf file With the patch, pdf file is correctly formated - remove your reader email - Run misc/cronjobs/overdue_notices.pl -v -html and misc/cronjobs/printoverdues.sh Without patch, the content of pdf file is all on one line with the patch, pdf file is correctly formated. - restore reader email - run misc/cronjobs/overdue_notice.pl -v -html Verify that the a message has been generated in message_queue table With or without patch, the message is the same Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:48:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:48:32 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:50:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:50:59 +0000 Subject: [Koha-bugs] [Bug 10668] Improve suggestion detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:51:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:51:11 +0000 Subject: [Koha-bugs] [Bug 10668] Improve suggestion detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20018|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20072&action=edit Bug 10668 - Improve suggestion detail page This patch makes several improvements to the suggestions template: - Improved breadcrumbs and page title. - Fixed a JavaScript error which appeared when viewing or editing a suggestion. - Added an 'Edit' and a 'Delete' button to the suggestion detail page. - Corrected capitalization. To test: - Perform various operations with suggestions management and confirm that page titles and breadcrumbs are correct. - View the detail page for an individual suggestion and confirm that the edit and delete buttons work correctly. - Confirm that there are no JavaScript errors when viewing or editing a suggestion, in particular when changing Acquisition information (quantity, currency, price). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:52:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:52:05 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #28 from Jesse Weaver --- Confirmed with Brendan. Yes, this code is all licensed under GPLv3+ and copyright 2013 ByWater. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:52:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 16:52:53 +0000 Subject: [Koha-bugs] [Bug 10668] Improve suggestion detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 --- Comment #4 from Kyle M Hall --- Created attachment 20073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20073&action=edit Bug 10668 - Improve suggestion detail page - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:13:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 17:13:30 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle at bywatersolutions.com --- Comment #20 from Kyle M Hall --- Jonathan, your patches work quite well, but there is no way to disable all the options at once. When I deslect them all, and hit the save button, I get the "Nothing to save" message. Not required, but it might be nice to implement something like https://code.google.com/p/dropdown-check-list/ as a fair number of people may not know about ctrl-click to select/deselect individual items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:14:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 17:14:31 +0000 Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12507|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:35:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 17:35:16 +0000 Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:35:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 17:35:30 +0000 Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19793|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 20074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20074&action=edit Bug 8821 - Receive shipment page should hide inactive funds like new order form This patch adapts the fund-handling code from neworderempty.pl in order to limit the display of funds by default to active ones, with the option to check a box to display all funds. This patch also adds "(inactive)" to the display of funds on this and the neworderempty.tt template because it seemed like that was useful information. To test, make sure you have both active and inactive funds. Start the process of receiving a shipment. The "fund" option in the receive shipment form should show only active funds. Checking the "show all" checkbox should allow you to choose from both active and inactive funds. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:43:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 17:43:04 +0000 Subject: [Koha-bugs] [Bug 10572] Add phone to message_transport_types table for new installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:43:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 17:43:20 +0000 Subject: [Koha-bugs] [Bug 10572] Add phone to message_transport_types table for new installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19548|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 20075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20075&action=edit Bug 10572: Add phone to message_transport_types table for new installs In connection to bug 4246 commit 591bae324d77d285b27dfa6e10dc7001671f53cc added phone to the message_transport_types table in updatedatabase.pl This should be done also for new installs via the .sql files of the web installer. I am adding it only to English now, basing this change upon the work in reports 10509 and 10520. (I discovered this tiny omission there too.) Test plan: Apply patches 10509/10520. Run new install or run this particular sql file from command line. Note: If you only run this particular file, you do not need patch 10509. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:56:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 17:56:55 +0000 Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in webinstaller mysql files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19310|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 20076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20076&action=edit Bug 10509: Using i18n function for translation of MySQL web installer files This patch makes the changes needed to progressively use a i18n function to translate strings in the web installer's MySQL files. The English scripts may contain fields like i18n(columnvalue); for English i18n(a) is a, but for the other languages i18n(a) is the translation of a. The corresponding script in the language folder contains the i18n definition. The work is done in such a way that current installations are not affected. Subsequent patches will make the changes in the .sql files themselves. This can be done per folder, per language. Using the extension .i18n in the last subfolder name triggers the new translation mechanism. (See also test plan.) In Installer.pm the all_languages parameter is removed from load_sql_in_order. This code was not used. This change also affects the call in install.pl. The most important change is the use of a new subroutine _run_mysql_file in load_sql. This new routine contains the above logic. Although I also tested changing marc_framework_sql_list and sample_data_sql_list, it proved imo to be easier (and more maintainable) to do this via load_sql. Test plan: Since no .sql files are changed in this patch, please test if you can install English and e.g. German (or another one) in the web installer without any changes. Bonus points for the following additional tests :) They serve to illustrate the i18n concept more clearly. 1) Place in en/mandatory/userflags.sql around a few strings i18n('...'). Run English install again and check the userflags table. No changes expected. 2) Place in de-DE/mandatory/userflags.sql i18n around a few strings too. Also precede the insert statements with this definition: DROP FUNCTION IF EXISTS i18n; CREATE FUNCTION i18n (d text) RETURNS text DETERMINISTIC RETURN concat(d,'xx'); Now run German install again; some of the userflag strings (with i18n) should now end with xx. 3) Before retesting German install, make some changes: Edit en/optional/sample_holidays.sql. Add i18n calls around strings. Create an additional folder optional.i18n in de-DE. Copy sample_holidays.sql and sample_holidays.txt from de-DE/optional. Edit de-DE/optional.i18n/sample_holidays.sql. Remove all text! Add: DROP FUNCTION IF EXISTS i18n; CREATE FUNCTION i18n (d text) RETURNS text DETERMINISTIC RETURN CASE d WHEN 'Sundays' THEN 'Sonntag' ELSE d END; Now run German install again; in the optional part of the install mark sample holidays (in the last section standing separately; do not confuse with the other one). Check the repeatable_holidays table afterwards. The string above should have been translated only, the others are still English. Undo the changes in .sql files; remove optional.i18n folder. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:57:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 17:57:23 +0000 Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in webinstaller mysql files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:57:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 17:57:33 +0000 Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in webinstaller mysql files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19311|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 20077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20077&action=edit Bug 10509: Followup for load_sql_in_order in unit tests Although I assume that the unit tests in t/db_dependent/lib are actually obsolete and should probably be removed, the two calls of load_sql_in_order are updated to reflect the current parameter list. (The all_languages parameter has been dropped.) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:57:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 17:57:45 +0000 Subject: [Koha-bugs] [Bug 7257] Add a link to remove an individual title from a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:58:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 17:58:16 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19439|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 20078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20078&action=edit Bug 10520: Add i18n function to en/mandatory mysql files Main goal: Adds i18n calls around translatable columns. Additionally: Removes backtics. Adds column names in inserts (where missing). Uses consistent style (based on my interpretation of coding guidelines). Test plan: Make sure that you apply this patch on top of the 10509 patches! Run English mysql install. Verify that you include all mandatory files. Check if webinstaller does not report errors. Inspect table contents via interface or mysql. Search for a column not using i18n where you would expect translation. Note: If you prefer to run the mysql files from command line, please make sure now that you define a 'fake' i18n, doing nothing (see Installer.pm code). Signed-off-by: Marcel de Rooy Tested both ways myself. Noticed that I missed one message_transport_type (phone) and one language description (180 vs. 181). If needed, will handle these on a separate report. They do not directly relate to this patch. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:58:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 17:58:43 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:58:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 17:58:55 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19440|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 20079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20079&action=edit Bug 10520: Add i18n function to en/optional mysql files Main goal: Adds i18n calls around translatable columns. Additionally: Removes backtics. Adds column names in inserts (where missing). Uses consistent style (based on my interpretation of coding guidelines). Removed some locking statements in sample_creator_data. NOTE: Some scripts insert numbers in auto-increment columns. Although this works, I would not prefer to do so. This patch however is not meant to change that, so leaves them for now. Test plan: Make sure that you apply this patch on top of the 10509 patches! Run English mysql install. Verify that you include all OPTIONAL files (in the OTHER DATA section). Check if webinstaller does not report errors. Inspect table contents via interface or mysql. Search for a column not using i18n where you would expect translation. Note: If you prefer to run the mysql files from command line, please make sure now that you define a 'fake' i18n, doing nothing (see Installer.pm code). Signed-off-by: Marcel de Rooy Tested all optional data via webinstaller. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 20:02:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 18:02:47 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19542|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 20:03:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 18:03:39 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #11 from Kyle M Hall --- Created attachment 20080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20080&action=edit [PATCH_IN_GZIP] Bug 10520: Add i18n function to en/marflavour mysql files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 20:30:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 18:30:28 +0000 Subject: [Koha-bugs] [Bug 10678] New: Allow framework selection when creating from Z39.50 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Bug ID: 10678 Summary: Allow framework selection when creating from Z39.50 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 20:33:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 18:33:29 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9742 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 20:33:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 18:33:29 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |tomascohen at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10678 --- Comment #1 from Tom?s Cohen Arazi --- I think the confirm popup should remain as long as you are sitting on the MARC cataloguing form. Simply it costs less than checking every field for data. This should be considered as a usability discussion. I have a proposal to avoid having to choose a framework and *then* doing the search. Please look at bug 10678 Katrin. Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 20:35:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 18:35:00 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 20:35:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 18:35:19 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 20081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20081&action=edit Bug 10678 - Allow framework selection when creating from Z39.50 If we are creating a new record, we are forced to use the default framework and then change it after we have the cataloguing form filled. This patch adds the option to choose (from a splitted button dropdown) which framework to use. To test: - Apply the patch. - Go to More > Cataloguing - Check there's a nice split button that says "New from Z39.50" a) Click the button, the usual Z39.50 search popup should appear and work as expected (check the URL parameters and see frameworkcode= has no value b) Click on the dropdown arrow, choose a framework and the usual Z39.50 search popup should appear, this time frameworkcode= should have the chosen value. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 20:36:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 18:36:47 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 20:38:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 18:38:26 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 20082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20082&action=edit Snapshot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 20:45:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 18:45:12 +0000 Subject: [Koha-bugs] [Bug 7257] Add a link to remove an individual title from a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 20:45:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 18:45:24 +0000 Subject: [Koha-bugs] [Bug 7257] Add a link to remove an individual title from a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257 --- Comment #2 from Owen Leonard --- Created attachment 20083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20083&action=edit Bug 7257 - Add a link to remove an individual title from a list It should be possible when viewing the contents of a list to click a link to remove an individual title from the list without having to check a checkbox and click another button. This patch adds a link to each list item to "Remove from this list." The functionality is JavaScript-dependent, automatically checking the appropriate checkbox and submitting the form to delete. To test, view a list for which you have delete permission. There should be a "Remove from this list" link next to each item on the list. Test delete functionality by: - Clicking the link and then clicking cancel. - Clicking the link and confirming. - Checking more than one checkbox and then clicking a single remove link (only the one corresponding record should be removed). - Checking one or more checkboxes and clicking the "Remove from list" link at the top of the page. If JavaScript is disabled the links should not appear. There are now two delete confirmation messages: One if you're removing only one item, another if you're removing more than one. This is true whether you use the links or the checkboxes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 20:47:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 18:47:20 +0000 Subject: [Koha-bugs] [Bug 7257] Add a link to remove an individual title from a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 21:08:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 19:08:49 +0000 Subject: [Koha-bugs] [Bug 10679] New: Lists interface offers delete option when user doesn't have permission Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679 Bug ID: 10679 Summary: Lists interface offers delete option when user doesn't have permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: m.de.rooy at rijksmuseum.nl Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In both the OPAC and the staff client a "allowremovingitems" variable is used in the template to determine whether the logged in user should be able to delete items from a list. In both the OPAC and staff client this variable is true when it should be false. Fortunately the user can't actually remove something from the list. Instead the page returns an error message. However, the "remove" option should not be visible in that case. To confirm this bug, log in to the OPAC or staff client and open a public list which was created by another user. The "remove from list" option will be available but submitting the form will return an error like "You could not delete any selected items from this shelf." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 21:17:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 19:17:15 +0000 Subject: [Koha-bugs] [Bug 7257] Add a link to remove an individual title from a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257 --- Comment #3 from Owen Leonard --- Note that because of Bug 10679 you can't test whether the "Remove from this list" links are correctly shown or hidden based on the logged-in user's permission to remove items from a list. The links will always appear to a logged-in user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 21:29:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 19:29:49 +0000 Subject: [Koha-bugs] [Bug 10680] New: "Modification log" gives wrong data Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10680 Bug ID: 10680 Summary: "Modification log" gives wrong data Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Transaction logs Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When viewing a record, the "Modification log" tab on the left hand side should display the modifications for that biblionumber, but instead it will pull the modifications for the itemnumber instead. That is, if the record you are viewing has a biblionumber of 42, and you follow the "Modification log" link, you will be seeing the modifications for the item whose itemnumber is 42 instead! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 21:32:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 19:32:55 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- Everything looks good and works well with one exception: If I click the button without choosing one of the menu choices the framworkcode is passed as "undefined" instead of being empty. With "undefined" the default framework isn't loaded and I get an MARC edit screen with no fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 21:36:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 19:36:59 +0000 Subject: [Koha-bugs] [Bug 10680] "Modification log" gives wrong data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10680 --- Comment #1 from Kyle M Hall --- One issue is that the biblionumber is not stored in the log for cataloging modifications, so the only way to get the list of modifications by biblionumber is to select where "object IN ( SELECT itemnumber FROM items UNION deleteditems WHERE biblionumber = ?". So, basically we need a special case in GetLogs for modules=CATALOGUING and action=MODIFY. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 21:42:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 19:42:44 +0000 Subject: [Koha-bugs] [Bug 10680] "Modification log" gives wrong data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10680 --- Comment #2 from Kyle M Hall --- Or, I think the correct answer is to update the object to the biblionumber for modules=CATALOGUING and action=MODIFY, as we can never view the specific item logs from a link in the intranet. If we do this, we can pull modification both via biblionumber ( via object ) and itemnumber ( via searching the info field with "'itemnumber' => '63661'". It's really a bit of a mess, as 'object' is used for biblionumber in some circumstances, and as itemnumber in others ( biblio vs item edit ) yet there is no way to specify what you are looking for at that level. There is no way to know if you are asking for biblio edits or item edits. The only sensible way to solve this to me is to make 'object' always be biblionumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 21:49:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 19:49:32 +0000 Subject: [Koha-bugs] [Bug 8937] Translation process removes CDATA in HTML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Component|Architecture, internals, |I18N/L10N |and plumbing | Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org --- Comment #1 from Owen Leonard --- I notice the fr-FR version of opac-opensearch.tt is also missing the XML declaration at the top (""). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 22:06:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 20:06:37 +0000 Subject: [Koha-bugs] [Bug 7809] Edit Items screen should be sorted by home branch instead of holding branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7809 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Severity|enhancement |normal --- Comment #1 from Owen Leonard --- Is this as simple as changing line 722 from this: my ($holdingbrtagf,$holdingbrtagsubf) = &GetMarcFromKohaField("items.holdingbranch",$frameworkcode); to this: my ($holdingbrtagf,$holdingbrtagsubf) = &GetMarcFromKohaField("items.homebranch",$frameworkcode); ? Or does that have a ramification I'm not seeing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 22:18:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 20:18:54 +0000 Subject: [Koha-bugs] [Bug 10494] KohaBranchName sends useless warnings to log if supplied library code is null or not present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10494 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 22:20:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 20:20:45 +0000 Subject: [Koha-bugs] [Bug 10484] serials-edit.pl not checking for barcode field before checking for barcode subfield In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10484 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 22:20:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 20:20:55 +0000 Subject: [Koha-bugs] [Bug 9393] Fix bad label and add note to circulation.pl if borrower has pending modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 --- Comment #4 from Owen Leonard --- (In reply to M. de Rooy from comment #3) > > I am wondering if we can do the other phone change like this. Lots of people > may have entered mobile phone numbers here, and suddenly it is just an other > phone. The staff client already uses the "other phone" label. This patch simply makes the two interfaces consistent. The other issue (with members-update.pl) seems like it could be handled in a separate patch and shouldn't block this one in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 22:21:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 20:21:38 +0000 Subject: [Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #20 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 22:22:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 20:22:26 +0000 Subject: [Koha-bugs] [Bug 10497] star ratings not showing right in ccsr detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 22:27:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 20:27:15 +0000 Subject: [Koha-bugs] [Bug 6775] Add option to use authorized values as reasons for restrictions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6775 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW Summary|Allow reason to be |Add option to use |specified when debarring |authorized values as | |reasons for restrictions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 22:44:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 20:44:04 +0000 Subject: [Koha-bugs] [Bug 10666] Daily quotes tests are failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 22:45:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 20:45:18 +0000 Subject: [Koha-bugs] [Bug 10666] Daily quotes tests are failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Galen Charlton --- Works for me, and since it would be nice to make Jenkins happy (and hopefully no longer have it noisily report essentially false test suite failures), I've pushed this to master. Fridolyn, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 22:59:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 20:59:10 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 22:59:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 20:59:14 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 --- Comment #2 from Galen Charlton --- Created attachment 20084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20084&action=edit Bug 10671: Help files for course reserves This patch adds the missing help files for course reserves. To test: * visit every page related to course reserves in the staff client * click help in the top right * review the help file for typos/content/links Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 22:59:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 20:59:17 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 22:59:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 20:59:22 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20081|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 20085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20085&action=edit Bug 10678 - Allow framework selection when creating from Z39.50 If we are creating a new record, we are forced to use the default framework and then change it after we have the cataloguing form filled. This patch adds the option to choose (from a splitted button dropdown) which framework to use. To test: - Apply the patch. - Go to More > Cataloguing - Check there's a nice split button that says "New from Z39.50" a) Click the button, the usual Z39.50 search popup should appear and work as expected (check the URL parameters and see frameworkcode= has no value b) Click on the dropdown arrow, choose a framework and the usual Z39.50 search popup should appear, this time frameworkcode= should have the chosen value. Regards To+ Edit: fixed a small bug that prevented the default framework to be called. Thanks Owen for testing. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 22:59:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 20:59:23 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 --- Comment #3 from Galen Charlton --- Created attachment 20086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20086&action=edit Bug 10671: correct minor issues in course reserves help - fix a typo - rename the help file for the course reserves home page so that it gets picked up when the user clicks the help link there. To test: [1] Go to the course reserves home page, then click on the "Help" link. Verify that a help page with contents is displayed. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 22:59:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 20:59:58 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20037|0 |1 is obsolete| | CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 23:16:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 21:16:09 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20086|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard --- Created attachment 20087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20087&action=edit [SIGNED-OFF] Bug 10671: correct minor issues in course reserves help - fix a typo - rename the help file for the course reserves home page so that it gets picked up when the user clicks the help link there. To test: [1] Go to the course reserves home page, then click on the "Help" link. Verify that a help page with contents is displayed. Signed-off-by: Galen Charlton Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 23:37:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2013 21:37:37 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 20088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20088&action=edit Bug 10678 - Update addbooks help page The button's name changed, and a caret was added. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 02:11:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 00:11:53 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- I did some testing of this today (and blogged about it: http://galencharlton.com/blog/2013/08/playing-around-with-coce/). The upshot is that it works for me, and I'm not averse to the general idea, but I have a few concerns: - It should be able to function under HTTPS without mixed content warnings, and that is not the case at the moment - I think that the Coce client should be able to specify the image size rather than have the Coce server set it -- this would allow, for example, OPAC results to use small images and the OPAC details page to use large ones. - It would be nice if this were available in the staff interface as well as the OPAC. - The patch should add the new sysprefs to installer/data/mysql/sysprefs.sql and installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 19:54:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 17:54:14 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #68 from Katrin Fischer --- Hi Kyle, there is a conflict in Reserves.pm I am not sure how to fix - could you take a look please? I think it's because your patch for using reserve_id is in now, so it might need a little work there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 19:56:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 17:56:05 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17257|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 20:12:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 18:12:44 +0000 Subject: [Koha-bugs] [Bug 10510] OPAC's renew selected link has glitchy icon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 20:13:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 18:13:28 +0000 Subject: [Koha-bugs] [Bug 10029] CAS authentication fails in OPAC reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10029 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 20:13:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 18:13:51 +0000 Subject: [Koha-bugs] [Bug 10428] undefined check in add additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10428 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 20:14:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 18:14:16 +0000 Subject: [Koha-bugs] [Bug 10346] "Add multiple copies" should be labelled "Add multiple items" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10346 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #11 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 20:14:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 18:14:54 +0000 Subject: [Koha-bugs] [Bug 5894] Adding multiple items from a cart to a list shows only the first title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5894 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 20:16:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 18:16:33 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 20:16:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 18:16:38 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19388|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer --- Created attachment 20089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20089&action=edit [3.10.x][PASSED QA] Bug 9902 - item subfields not populating Test Plan: 1) Create a new serial with a default location, call number, and library ( the library will need to be any but the one you are logged in as ) 2) Click the "Recieve" button for this serial 3) Click "Click to add item" 4) Note those values are not populated 5) Apply the patch 6) Reload the page 7) Click "Click to add item" 8) Note those values are now populated Signed-off-by: Nicole C. Engard All tests pass! Signed-off-by: Chris Cormack This seems to restore the former behaviour. Signed-off-by: Liz Rea signing for 3.10.x - restores former behaviour. Signed-off-by: Katrin Fischer Works nicely. Before applying the patch callnumber, location and branches are not carried over correctly. After applying the patch, this works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 20:18:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 18:18:40 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Version|master |3.10 QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 20:26:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 18:26:43 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #15 from Katrin Fischer --- Comment on attachment 17951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17951 [SIGNED-OFF] Bug 5262 - authority plugin doesn't copy indicators -- ver. 0.3 Review of attachment 17951: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5262&attachment=17951) ----------------------------------------------------------------- ::: authorities/blinddetail-biblio-search.pl @@ +102,5 @@ > push( @subfield_loop, { marc_subfield => 'w', marc_values => $relationship } ) if ( $relationship ); > + if (C4::Context->preference('marcflavour') eq 'UNIMARC') { > + $indicator1 = $field->indicator('1'); > + $indicator2 = $field->indicator('2'); > + } elsif (C4::Context->preference('marcflavour') eq 'MARC21') { I wonder if we could add something for NORMARC here too? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 20:42:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 18:42:49 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #16 from Janusz Kaczmarek --- (In reply to Katrin Fischer from comment #15) > I wonder if we could add something for NORMARC here too? Katrin, thank you very much for your comment. If you know any resources concerning NORMARC in a generally comprehensible language, let me know, I could try to add some lines. (What I have found is only http://www.nb.no/Bibliotekutvikling/Kunnskapsorganisering/Den-norske-katalogkomite/NORMARC -- I regret but I cannot read Norwegian :( ) Or feel free to add your insertion if you feel competent about NORMARC. Or maybe somebody else could add his contribution... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 21:01:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 19:01:26 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #17 from Katrin Fischer --- Created attachment 20090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20090&action=edit [PASSED QA] Bug 5262 - authority plugin doesn't copy indicators -- ver. 0.3 With this patch Koha should Koha should correctly copy indicators (and create $2 subfield in MARC-21 if need) from the chosen authority record to the edited bibliographic record (according to discussion in bugzilla). UNIMARC and MARC-21 flavors are covered. Signed-off-by: Bernardo Gonzalez Kriegel Comment: work as described, testing in comments 9 and 12. No errors. Signed-off-by: Katrin Fischer Passes QA script and tests. Tested functionality repeating some of the tests noted by Bernardo - checking mostly 1xx, 490, and 7xx. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 21:01:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 19:01:48 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 21:01:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 19:01:53 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17951|0 |1 is obsolete| | Attachment #20090|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 20091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20091&action=edit [PASSED QA] Bug 5262 - authority plugin doesn't copy indicators -- ver. 0.3 With this patch Koha should Koha should correctly copy indicators (and create $2 subfield in MARC-21 if need) from the chosen authority record to the edited bibliographic record (according to discussion in bugzilla). UNIMARC and MARC-21 flavors are covered. Signed-off-by: Bernardo Gonzalez Kriegel Comment: work as described, testing in comments 9 and 12. No errors. Signed-off-by: Katrin Fischer Passes QA script and tests. Tested functionality repeating some of the tests noted by Bernardo - checking mostly 1xx, 490, and 7xx. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 21:02:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 19:02:45 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no QA Contact|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 21:32:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 19:32:12 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #19 from Katrin Fischer --- Hi Janusz, just seeing your comment - I have added Magnus to the cc list, he will know :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 21:53:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 19:53:05 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #65 from Katrin Fischer --- I think if we have UNIMARC and MARC21, we should not forget about NORMARC. Kyle, could you add a follow up for NORMARC please? I will continue testing these. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 22:09:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 20:09:41 +0000 Subject: [Koha-bugs] [Bug 9113] batch modification removes + In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9113 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 22:10:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 20:10:05 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #24 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 22:10:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 20:10:52 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 --- Comment #23 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 22:12:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 20:12:49 +0000 Subject: [Koha-bugs] [Bug 10088] software error when filling a basket with staged record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10088 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- Bug 9902 in now on 3.10.x, so we need this. Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 22:13:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 20:13:36 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 22:14:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 20:14:23 +0000 Subject: [Koha-bugs] [Bug 10384] Software error when LDAP connexion fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10384 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 22:14:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 20:14:49 +0000 Subject: [Koha-bugs] [Bug 9519] Wrong language code for Italian in the advanced search language limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9519 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 22:42:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 20:42:09 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #66 from Katrin Fischer --- There is a problem in the non-XSLT display: Availability: Copies available: Demo Library (1), Demo Library (1), Items look like this: home library:holding library demo library:springfield demo library:demo library It works nicely for the XSLT view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 3 22:52:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Aug 2013 20:52:38 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl |katrin.fischer at bsz-bw.de --- Comment #31 from Katrin Fischer --- This works, but I am a bit torn on the constructs: + + + + + This could be: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 08:39:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 06:39:44 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20084|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 20092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20092&action=edit Bug 10671: Help files for course reserves This patch adds the missing help files for course reserves. To test: * visit every page related to course reserves in the staff client * click help in the top right * review the help file for typos/content/links Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 08:40:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 06:40:00 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 08:40:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 06:40:06 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20087|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 20093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20093&action=edit Bug 10671: correct minor issues in course reserves help - fix a typo - rename the help file for the course reserves home page so that it gets picked up when the user clicks the help link there. To test: [1] Go to the course reserves home page, then click on the "Help" link. Verify that a help page with contents is displayed. Signed-off-by: Galen Charlton Signed-off-by: Nicole C. Engard Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 11:52:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 09:52:26 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |liz at catalyst.net.nz, | |oleonard at myacpl.org --- Comment #26 from Katrin Fischer --- There is a lot I like about this :) I just would like some other people to take a look, as this is a really important feature/page for libraries/librarians. Some notes from testing: - The styling of the datatables toolbar is still a bit off/different to how it looks in other places like subscriptions. Maybe Owen could take a look? - If no results are found it would be nicer to not display all the controls but just a short message. - There is a big change in behaviour as the page loads all borrowers on loading the page. I am worried about the performance of this for bigger databases. - I wonder if we could also offer a general search field like we have for subscriptions? - The search options are doubled up now on the left and on the top. The search on the left is working a bit nicer for me, because it's easier to see and handle. It would be interesting what other people think about this. Adding Owen CC in hope he might have some time to take a look. Also Liz as she has worked on the patron search in the past. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 11:56:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 09:56:35 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19633|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 11:57:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 09:57:04 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 11:57:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 09:57:10 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19056|0 |1 is obsolete| | Attachment #19057|0 |1 is obsolete| | Attachment #19642|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer --- Created attachment 20094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20094&action=edit [PASSED QA] Bug 9811: Patron search improvement This patch add DataTables using server-side processing for the patrons search. It adds: - 1 module C4/Utils/DataTables/Members.pm - 1 service svc/members/search - 1 template members/tables/members_results.tt - 1 new practice which is to add template for DataTables in a subdirectory named 'tables'. Impacted scripts: members/members-home.pl and members/members.pl To go further: We can imagine that all patrons searches use the same service with no big changes: 1 little template creates a JSON file and to implement DataTables on the template page, that's all. Test plan: - Check that there is no regression on searching patrons. - Try filters on the left of the screen - Try to sort each column - Try the "Browse by last name" links. - Check that the "Clear" button clears yours filters. - Try with IndependantBranches ON and OFF Signed-off-by: Cedric Vita Signed-off-by: Katrin Fischer Passes all tests and QA script, couldn't find any regressions or problems. Some notes left on the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 11:57:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 09:57:26 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #28 from Katrin Fischer --- Created attachment 20095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20095&action=edit [PASSED QA] Bug 9811: Add unit tests for C4::Utils::DT::Members Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 11:57:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 09:57:46 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #29 from Katrin Fischer --- Created attachment 20096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20096&action=edit [PASSED QA] Bug 9811: QA followup - removes 2 tabs - removes mysqlisms - add sort on borrowernotes - fix wrong capitalization - cat => Category Signed-off-by: Katrin Fischer Thx for fixing these! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 11:58:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 09:58:52 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #30 from Katrin Fischer --- Funcionaltiy wise this works well for me, so found nothing to not pass QA :) - I'd just like to get some more comments and eyes on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 12:19:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 10:19:49 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 12:19:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 10:19:52 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20092|0 |1 is obsolete| | Attachment #20093|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 20097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20097&action=edit [PASSED QA] Bug 10671: Help files for course reserves This patch adds the missing help files for course reserves. To test: * visit every page related to course reserves in the staff client * click help in the top right * review the help file for typos/content/links Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 12:20:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 10:20:09 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 --- Comment #8 from Katrin Fischer --- Created attachment 20098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20098&action=edit [PASSED QA] Bug 10671: correct minor issues in course reserves help - fix a typo - rename the help file for the course reserves home page so that it gets picked up when the user clicks the help link there. To test: [1] Go to the course reserves home page, then click on the "Help" link. Verify that a help page with contents is displayed. Signed-off-by: Galen Charlton Signed-off-by: Nicole C. Engard Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 12:20:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 10:20:36 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 15:05:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 13:05:24 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 15:05:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 13:05:30 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 15:18:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 13:18:17 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #29 from Katrin Fischer --- I have spent some time looking at those patches and I am worried that they try to do too many things. I think i have identified what they do, but I am not sure (which is not a good sign :) ). I think we have 3 things here, that ideally should be broken up into 3 different bugs to make this easier testable: - Merging GetPendingOrders and GetOrders + regression tests - Adding basket group name search - Adding datatables to the pending oders page Jonathan, do you think you could break it up on different bugs with test plans for each? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 15:22:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 13:22:49 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #22 from Katrin Fischer --- Switching this to failed QA because of Jonathan's last comment and the fact that it does not apply currently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 15:26:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 13:26:54 +0000 Subject: [Koha-bugs] [Bug 10572] Add phone to message_transport_types table for new installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Kyle, this could go in as a bugfix to earlier versions as well, but the new web installer translations probably can't. Could you provide a follow-up please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 15:29:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 13:29:39 +0000 Subject: [Koha-bugs] [Bug 10572] Add phone to message_transport_types table for new installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- Also, I think to fix this properly we shoudl include a database update. It looks like 4246 has been released with 3.10, so there is a good chance of people installing 3.10 or 3.12 will have missed the database update and will have the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 15:41:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 13:41:37 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #18 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 15:42:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 13:42:28 +0000 Subject: [Koha-bugs] [Bug 9353] Missing subfields on MARC21 frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 --- Comment #11 from Bernardo Gonzalez Kriegel --- Needed for Bug 5858 Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 15:43:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 13:43:22 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #47 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 15:43:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 13:43:51 +0000 Subject: [Koha-bugs] [Bug 4907] Suggestions "organize by" menu doesn't reflect current choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4907 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #10 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 15:44:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 13:44:20 +0000 Subject: [Koha-bugs] [Bug 10548] koha_perl_deps.pl miscounts dependencies displayed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 16:17:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 14:17:30 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19891|0 |1 is obsolete| | --- Comment #12 from Jared Camins-Esakov --- Created attachment 20099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20099&action=edit Bug 5202: merge authorities from the authority file and reservoir This patch gives Koha the ability to merge authority records using the same interface used by bibliographic records, though slightly different methods for selecting which records to merge. The two ways to select records are as follows: 1) Records can be selected from authority search results by clicking the "Merge" link for two records. 2) Authority records can be merged from the reservoir by clicking the merge-related links in the Manage staged MARC batch screen. To test: 1) Apply patch. 2) Do a search for an authority record that will turn up multiple identical records (or at least two records that you don't mind merging). 3) Click the "Merge" link for the first record. 4) Click the "Merge" link for the second record. 5) Choose which fields from which record you want to appear in the resulting record. 6) Confirm that those are the fields that exist in the resulting record. 7) Stage an authority record (for example, an authority record you saved from your catalog. 8) Search for a record to merge with it using the "Search for a record to merge in a new window" link. 9) Merge these records, confirming that the resulting record (after going through the entire merging process) matches your expectations. 10) Set up a matching rule for authorities, and export an authority from your catalog that will match based on that rule. For MARC21, the following is a good choice for a rule: Matching rule code: AUTHPER Description: Personal name main entry Match threshold: 999 Record type: Authority record [Match point 1:] Search index: mainmainentry Score: 1000 Tag: 100 Subfields: a 11) Stage the record you just exported, choosing the matching rule you just created. 12) Merge the record using the "Merge" link, confirming that the resulting record (after going through the entire merging process) matches your expectations. 13) Sign off. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 16:17:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 14:17:36 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19892|0 |1 is obsolete| | --- Comment #13 from Jared Camins-Esakov --- Created attachment 20100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20100&action=edit Bug 5202 QA follow-up: quiet warnings Due to massively incorrect data in the default authority frameworks, we were getting warnings about undefined values and spaces from checking which tab subfields/fields were displayed in. This patch eliminates those warnings. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 16:17:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 14:17:40 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #14 from Jared Camins-Esakov --- Created attachment 20101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20101&action=edit Bug 5202 QA follow-up 2: fix overeager error message When rebasing the patch for this, I accidentally moved the line setting the mergereference when merging from breeding to *before* I checked whether we were merging from breeding. Needless to say, this caused problems. This patch fixes that, and: * Makes the error translatable. * Adds a missing authtypesloop argument for the template. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 16:23:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 14:23:28 +0000 Subject: [Koha-bugs] [Bug 9290] Restricting patron category for online purchase suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 vinod changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 21:13:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 19:13:13 +0000 Subject: [Koha-bugs] [Bug 10529] Dollar sign hardcoded in patron message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10529 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel --- This does not apply cleanly to 3.10.x, please submit one formatted for 3.10.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 21:56:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 19:56:16 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #10 from Bernardo Gonzalez Kriegel --- First patch pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 21:57:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 19:57:03 +0000 Subject: [Koha-bugs] [Bug 10560] No way to disable english In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10560 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 21:57:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 19:57:34 +0000 Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 21:58:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 19:58:11 +0000 Subject: [Koha-bugs] [Bug 10475] Item form in acquisition not hiding subfields properly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10475 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 21:58:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 19:58:49 +0000 Subject: [Koha-bugs] [Bug 10507] Typo when warning about creating duplicate patron attribute In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10507 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 21:59:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 19:59:17 +0000 Subject: [Koha-bugs] [Bug 10411] Add cache control headers to static resources in the apache config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 21:59:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 19:59:57 +0000 Subject: [Koha-bugs] [Bug 8911] docs/history.txt file missing for about.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8911 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 4 22:04:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 20:04:13 +0000 Subject: [Koha-bugs] [Bug 10679] Lists interface offers delete option when user doesn't have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679 --- Comment #1 from M. de Rooy --- Just from recall: Isn't it so that the variable is set to true (and the remove button is displayed) as long as it is possible that this user might be able to delete at least some items of this list? The permissions now differentiate deleting items you added yourself and items of someone else. It would not be very effective to do this check on item level every time you display a list? BICBW.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 00:51:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 22:51:03 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #15 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 00:54:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 22:54:03 +0000 Subject: [Koha-bugs] [Bug 10448] Changing framework when cataloguing clears all fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10448 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 00:55:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 22:55:19 +0000 Subject: [Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #14 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 00:55:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 22:55:48 +0000 Subject: [Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #21 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 00:56:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 22:56:23 +0000 Subject: [Koha-bugs] [Bug 10189] French values in cataloging plugins for unimarc 128b and 128c fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 00:57:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 22:57:44 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #53 from Bernardo Gonzalez Kriegel --- Followup pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 00:58:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 22:58:28 +0000 Subject: [Koha-bugs] [Bug 10422] Remove references to unused and non-existent wizard.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10422 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 01:38:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Aug 2013 23:38:10 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #15 from Bernardo Gonzalez Kriegel --- This does not apply cleanly to 3.10.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 02:34:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 00:34:39 +0000 Subject: [Koha-bugs] [Bug 10527] C4::Branch::get_branch_code_from_name is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10527 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 02:35:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 00:35:36 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #17 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 02:36:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 00:36:25 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #13 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 02:37:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 00:37:16 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #13 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 04:02:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 02:02:57 +0000 Subject: [Koha-bugs] [Bug 10668] Improve suggestion detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20073|0 |1 is obsolete| | --- Comment #5 from Srdjan Jankovic --- Created attachment 20102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20102&action=edit [SIGNED-OFF] Bug 10668 - Improve suggestion detail page - QA Followup Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 08:03:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 06:03:31 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 08:03:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 06:03:35 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 --- Comment #10 from Srdjan Jankovic --- Created attachment 20103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20103&action=edit [SIGNED-OFF] Bug 10588 - opac-topissues first branch always selected in filters In OPAC most popular items page: With user is logged-in his branch should be selected. When a branch is manually selected and form is submitted, this branch should be selected in results page. When looking at HTML, you see that all options are selected in combobox. This patch corrects by using the hidden input 'do_it' to distinguish form display and no branch filter selected. Test plan : - Make sure there are issues on records created in the past 3 month - Go to OPAC not logged-in - Click on "Most popular" => You get to page with results, "All libraries" is selected - Select a branch and submit => You get to page with results, the branch is selected [testing opac-topissues.inc from] - Select a branch and perform a search that does not have results (for example an item type never issued) => You get to page without results, the branch is selected [testing opac-topissues.tt form] - Log-in with a user - Click on "Most popular" => You get to page with results, user's branch is selected - Select "All libraries" and submit => You get to page with results, "All libraries" is selected [testing opac-topissues.inc from] - Select "All libraries" and perform a search that does not have results (for example an item type never issued) => You get to page without results, "All libraries" is selected [testing opac-topissues.tt form] Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 08:14:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 06:14:05 +0000 Subject: [Koha-bugs] [Bug 10078] show location facet for all In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 08:14:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 06:14:09 +0000 Subject: [Koha-bugs] [Bug 10078] show location facet for all In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19331|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 20104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20104&action=edit [SIGNED-OFF] Bug 10078 - show location facet for all Currently, the location facet only shows if you have singlebranch mode enabled. In other words, you can either see the library branch or the shelving location. This patch simply changes the location facet so that it will always show the shelving location (if one is available), regardless of the singlebranch system preference. Test Plan: BEFORE APPLYING: 0) Disable singlebranch mode if it is on 1) Do an OPAC or Staff Client search for a record that has items with shelving locations. 2) Note that you can see the library branch facet under Libraries but no shelving locations. 3) Enable singlebranch mode 4) Repeat your search 5) Note that you can no longer see the library branch facet under Libraries. However, you can see the shelving location under Location N.B. If you don't have more than one branch or the search results are all from one branch, you might not get a library branch facet. If this is the case, create additional branches and/or change the branch for items in your search results so that you have multiple branches to prompt the appearance of a library branch facet. AFTER APPLYING 1) Do an OPAC or Staff Client search for a record that has items with shelving locations. 2) Note that you see a facet under Location on the left sidebar, regardless of there being a singlebranch mode or the number of branches there are being represented in the search results. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 08:28:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 06:28:36 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 09:59:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 07:59:08 +0000 Subject: [Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19948|0 |1 is obsolete| | --- Comment #4 from kenza --- Created attachment 20105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20105&action=edit Bug 10643: Inappropriate uses of $sth->finish() in C4::ClassSource.pm This patch gets rid of finish() and replace prepare_cached by prepare. >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 10:36:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 08:36:15 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19986|0 |1 is obsolete| | --- Comment #5 from kenza --- Created attachment 20106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20106&action=edit Bug 10653: C4::RotatingCollections.pm needs unit tests The tests are wrap in a database transaction. Test plan: prove t/db_dependent/RotatingCollections.t t/db_dependent/RotatingCollections.t .. 1/41 attempting to use non-existent class sorting routine Use of uninitialized value $cn_class in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_item in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_class in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_item in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. t/db_dependent/RotatingCollections.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.04 usr 0.02 sys + 0.99 cusr 0.08 csys = 1.13 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 10:41:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 08:41:57 +0000 Subject: [Koha-bugs] [Bug 7013] required format is not enforced for authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|adrien.saurat at biblibre.com |christophe.croullebois at bibl | |ibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 10:45:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 08:45:33 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 --- Comment #6 from kenza --- (In reply to kenza from comment #5) > Created attachment 20106 [details] [review] > Bug 10653: C4::RotatingCollections.pm needs unit tests > > The tests are wrap in a database transaction. > > Test plan: > prove t/db_dependent/RotatingCollections.t > t/db_dependent/RotatingCollections.t .. 1/41 attempting to use non-existent > class sorting routine > Use of uninitialized value $cn_class in concatenation (.) or string at > C4/ClassSortRoutine.pm line 118. > Use of uninitialized value $cn_item in concatenation (.) or string at > C4/ClassSortRoutine.pm line 118. > Use of uninitialized value $cn_class in concatenation (.) or string at > C4/ClassSortRoutine.pm line 118. > Use of uninitialized value $cn_item in concatenation (.) or string at > C4/ClassSortRoutine.pm line 118. > t/db_dependent/RotatingCollections.t .. ok > All tests successful. > Files=1, Tests=41, 2 wallclock secs ( 0.04 usr 0.02 sys + 0.99 cusr 0.08 > csys = 1.13 CPU) > Result: PASS I add the deletion of 'categories' ,'branches' and 'branchcategories'. It should work but it still not: if i do : prove t/db_dependent/RotatingCollections.t t/db_dependent/RotatingCollections.t .. 1/41 DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) at t/db_dependent/RotatingCollections.t line 41. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) at t/db_dependent/RotatingCollections.t line 41. # Looks like you planned 41 tests but ran 2. # Looks like your test exited with 255 just after 2. t/db_dependent/RotatingCollections.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 39/41 subtests Test Summary Report ------------------- t/db_dependent/RotatingCollections.t (Wstat: 65280 Tests: 2 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 41 tests but ran 2. Files=1, Tests=2, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.34 cusr 0.02 csys = 0.38 CPU) Result: FAIL But if i do: sudo prove t/db_dependent/RotatingCollections.t t/db_dependent/RotatingCollections.t .. 1/41 attempting to use non-existent class sorting routine Use of uninitialized value $cn_class in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_item in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_class in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_item in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. t/db_dependent/RotatingCollections.t .. ok All tests successful. Files=1, Tests=41, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.37 cusr 0.00 csys = 0.39 CPU) Result: PASS I really don't understand ! So if someone has an idea which can help me... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 10:49:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 08:49:47 +0000 Subject: [Koha-bugs] [Bug 7469] Focus on 1st field of creation form instead of search textbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7469 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m Assignee|adrien.saurat at biblibre.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 10:52:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 08:52:54 +0000 Subject: [Koha-bugs] [Bug 7422] Prevent creation of vendors with the same name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m Assignee|adrien.saurat at biblibre.com |christophe.croullebois at bibl | |ibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:06:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:06:46 +0000 Subject: [Koha-bugs] [Bug 7013] required format is not enforced for authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013 --- Comment #20 from Katrin Fischer --- I think in order to fix this properly we need to fix how MANUAL_INV works. It uses the code as description and the description for the amount. We could use the code as a real code and then the description as description... and the opac description for the amount. But it would still be bending something to do what it was not supposed to do in the first place. And do we still need to fix the security issue?? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:09:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:09:48 +0000 Subject: [Koha-bugs] [Bug 10237] Enforce authorized value character limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10237 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #13 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 7013 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:09:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:09:48 +0000 Subject: [Koha-bugs] [Bug 7013] required format is not enforced for authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #21 from Katrin Fischer --- *** Bug 10237 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:10:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:10:15 +0000 Subject: [Koha-bugs] [Bug 7013] required format is not enforced for authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:20:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:20:05 +0000 Subject: [Koha-bugs] [Bug 10681] New: Inappropriate uses of finish() in C4::Circulation.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 Bug ID: 10681 Summary: Inappropriate uses of finish() in C4::Circulation.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:20:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:20:25 +0000 Subject: [Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:31:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:31:23 +0000 Subject: [Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:31:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:31:27 +0000 Subject: [Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 --- Comment #1 from kenza --- Created attachment 20107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20107&action=edit Bug 10681: Inappropriate uses of finish() in C4::Circulation.pm This patch gets rid of finish(). >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:42:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:42:05 +0000 Subject: [Koha-bugs] [Bug 10682] New: Inappropriate uses of finish() in C4::Reserve.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 Bug ID: 10682 Summary: Inappropriate uses of finish() in C4::Reserve.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:42:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:42:23 +0000 Subject: [Koha-bugs] [Bug 10682] Inappropriate uses of finish() in C4::Reserve.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:50:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:50:58 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #31 from Paul Poulain --- (In reply to Katrin Fischer from comment #30) > Funcionaltiy wise this works well for me, so found nothing to not pass QA :) > - I'd just like to get some more comments and eyes on this. Hi Katrin, you're asking for more eyes, but I don't see any mail to warn/ask on mailing lists, so I fear that your request will stay as is. Maybe sending a mail to koha@ mailing list (with some screenshots to present the feature, and/or link to sandboxes for ppl to test it) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:52:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:52:25 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #32 from Katrin Fischer --- Sounds like a good idea :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:53:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:53:10 +0000 Subject: [Koha-bugs] [Bug 10682] Inappropriate uses of finish() in C4::Reserve.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:53:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:53:14 +0000 Subject: [Koha-bugs] [Bug 10682] Inappropriate uses of finish() in C4::Reserve.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 --- Comment #1 from kenza --- Created attachment 20108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20108&action=edit Bug 10682 : Inappropriate uses of finish() in C4::Reserves This patch gets rid of finish. >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:53:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:53:44 +0000 Subject: [Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 11:54:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 09:54:04 +0000 Subject: [Koha-bugs] [Bug 10682] Inappropriate uses of finish() in C4::Reserve.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 12:04:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 10:04:28 +0000 Subject: [Koha-bugs] [Bug 10683] New: CRUD routines in C4::Circulation need unit tests Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683 Bug ID: 10683 Summary: CRUD routines in C4::Circulation need unit tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org Unit tests for Add*, Get* and Del* routines in C4::Circulation.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 12:04:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 10:04:43 +0000 Subject: [Koha-bugs] [Bug 10683] CRUD routines in C4::Circulation need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 12:05:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 10:05:25 +0000 Subject: [Koha-bugs] [Bug 10683] CRUD routines in C4::Circulation need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 12:06:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 10:06:26 +0000 Subject: [Koha-bugs] [Bug 10683] CRUD routines in C4::Circulation need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10681 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 12:06:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 10:06:26 +0000 Subject: [Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10683 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 13:26:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 11:26:28 +0000 Subject: [Koha-bugs] [Bug 10680] "Modification log" gives wrong data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10680 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 14:47:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 12:47:51 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #33 from Owen Leonard --- I just tried this out with a copy of our production database of patrons (62,000+ records) and I don't get any results. When I first load the page it looks like the table is trying to process *all* patron records? The POST response has this: "iTotalRecords": 62459, "iTotalDisplayRecords": 62459, ...but they are never displayed. I don't get any results from clicking on the "browse by last name" alphabet links, and I don't get any results after performing a simple search by last name. In all cases I see the "processing" message on the screen but nothing is ever displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 14:59:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 12:59:37 +0000 Subject: [Koha-bugs] [Bug 10679] Lists interface offers delete option when user doesn't have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679 --- Comment #2 from Owen Leonard --- (In reply to M. de Rooy from comment #1) > Isn't it so that the variable is set to true > as long as it is possible that this user might > be able to delete at least some items of this list? Why would it be possible that I might be able to delete some items from a list which I didn't create and which wasn't created with permission for others to add items? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 15:17:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 13:17:34 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 --- Comment #2 from Owen Leonard --- Two comments I made in IRC that I will copy here so they are not forgotten: - I would put browser.js in intranet-tmpl/js rather than intranet-tmpl/lib/koha. Generally speaking /lib/ is for 3rd-party libraries, /js/ is for scripts written for Koha. - There is commented-out code in results.tt, [% dumper.dump(SEARCH_RESULTS) %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 15:24:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 13:24:55 +0000 Subject: [Koha-bugs] [Bug 10684] New: Koha search dies on undecodable records Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Bug ID: 10684 Summary: Koha search dies on undecodable records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When a record fails to decode during a search, Koha dies with an error. Koha should ignore bad records and continue on ( and log the error ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 15:25:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 13:25:04 +0000 Subject: [Koha-bugs] [Bug 10684] Koha search dies on undecodable records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 15:28:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 13:28:58 +0000 Subject: [Koha-bugs] [Bug 10684] Koha search dies on undecodable records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 15:29:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 13:29:04 +0000 Subject: [Koha-bugs] [Bug 10684] Koha search dies on undecodable records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 --- Comment #1 from Kyle M Hall --- Created attachment 20109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20109&action=edit Bug 10684 - Koha search dies on undecodable records When a record fails to decode during a search, Koha dies with an error. Koha should ignore bad records and continue on ( and log the error ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 15:50:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 13:50:46 +0000 Subject: [Koha-bugs] [Bug 10685] New: Inappropriate uses of finish() in C4::Accounts.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 Bug ID: 10685 Summary: Inappropriate uses of finish() in C4::Accounts.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 15:51:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 13:51:41 +0000 Subject: [Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 15:57:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 13:57:56 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed latest patches to master. Thanks, Nicole. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 15:58:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 13:58:08 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20097|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 15:58:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 13:58:20 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20098|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 15:58:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 13:58:29 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 16:06:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 14:06:25 +0000 Subject: [Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 --- Comment #5 from Owen Leonard --- None of these "$sth->finish()" patches have a test plan. I assume there's no way to detect an improvement, but how can we confirm that this change hasn't broken anything? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 16:07:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 14:07:23 +0000 Subject: [Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 16:07:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 14:07:27 +0000 Subject: [Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 --- Comment #1 from kenza --- Created attachment 20110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20110&action=edit Bug 10685: Inappropriate uses of finish in C4::Accounts.pm This patch gets rid of finish. >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 16:08:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 14:08:46 +0000 Subject: [Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Owen Leonard --- Could you look at this again Katrin? I'm not getting any errors from the QA script when I run it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 16:13:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 14:13:34 +0000 Subject: [Koha-bugs] [Bug 10684] Koha search dies on undecodable records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- Please add a test plan. How can one load/modify a record so as to reproduce the error and confirm the fix? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 16:13:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 14:13:47 +0000 Subject: [Koha-bugs] [Bug 10684] Koha search dies on undecodable records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 16:34:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 14:34:15 +0000 Subject: [Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 --- Comment #6 from kenza --- (In reply to Owen Leonard from comment #5) > None of these "$sth->finish()" patches have a test plan. I assume there's no > way to detect an improvement, but how can we confirm that this change hasn't > broken anything? For this patch , the t/db_dependent/ClassSource.t exists. So we can be sure that nothing is broken by doing 'prove t/db_dependent/ClassSource.t' after applying this patch: t/db_dependent/ClassSource.t .. 1/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.06 cusr 0.01 csys = 0.09 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 16:35:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 14:35:56 +0000 Subject: [Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 16:35:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 14:35:59 +0000 Subject: [Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19971|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 20111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20111&action=edit [SIGNED-OFF] Bug 10652 - Ajaxfileupload.js failing in IE9 for local image upload This patch adds a try/catch to the Javascript for adding the iframe element. The try will work for IE8 and older versions, while newer versions and other browsers will be covered by the check. Test Plan: 1) Try uploading a local cover image in IE9 2) Notice that your page is reloaded with no result (except the pop-up of a Javascript error, if you have error reporting on in your browser). 3) Apply the patch 4) Trying uploading a local cover image again 5) Notice that it uploads correctly 6) Repeat steps 4 and 5 for IE8, IE7, and/or other modern browsers. Signed-off-by: Owen Leonard Tested in IE10 in IE10 "browser mode" and IE9 mode as well as in Firefox. Uploads work correctly with book cover images and in MARC uploads. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 16:41:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 14:41:57 +0000 Subject: [Koha-bugs] [Bug 10430] status filter not working in serial claims when translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #7 from Fridolyn SOMERS --- I set back to Need Signoff. The QA validation will say if using a class is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 16:44:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 14:44:58 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10127 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 16:44:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 14:44:58 +0000 Subject: [Koha-bugs] [Bug 10127] Printoverdues.sh should tar only pdf files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10127 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6030 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 16:55:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 14:55:49 +0000 Subject: [Koha-bugs] [Bug 10679] Lists interface offers delete option when user doesn't have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679 --- Comment #3 from M. de Rooy --- (In reply to Owen Leonard from comment #2) > Why would it be possible that I might be able to delete some items from a > list which I didn't create and which wasn't created with permission for > others to add items? Just thinking: Permissions can be changed at any time. So if I just disallowed adding items by others on my list, there could still be items added earlier on? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 19:19:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 17:19:57 +0000 Subject: [Koha-bugs] [Bug 10684] Koha search dies on undecodable records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Kyle M Hall --- That is something I've yet to figure out. This is a fix I wrote for a production server where the database marc and marcxml are valid, but the marc sent by zebra is bad. I have no idea how to intentionally cause this issue. However, one can prove the patch is not deleterious simply by applying the patch and searching for records within Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 19:26:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 17:26:52 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 21:33:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 19:33:31 +0000 Subject: [Koha-bugs] [Bug 6455] Warning message Patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6455 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard --- This doesn't appear to be a problem in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 21:37:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 19:37:15 +0000 Subject: [Koha-bugs] [Bug 6382] Automatic Status Changing on Check In In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6382 --- Comment #1 from Owen Leonard --- This would be completely contrary to the way my library uses the notforloan status. I think you'd have to design a system which allowed you to create specific status workflows: "If item with status A is checked in, move to status B, if item with status B is checked in, move to status C." I think that's the only way you could make it flexible enough that libraries who are used to Koha's existing workflow wouldn't object. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 21:58:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 19:58:47 +0000 Subject: [Koha-bugs] [Bug 6567] adding and removing advanced search options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6567 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 22:05:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 20:05:22 +0000 Subject: [Koha-bugs] [Bug 5920] remove html from downloaded reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #1 from Owen Leonard --- You would probably have to fully re-build the SQL for output as CSV. If you simply stripped out the concatenated text you would potentially be outputting two or more fields crammed together in one column: SELECT biblionumber, CONCAT('',title,'') AS Title -------------------------------------------- | biblionumber | Title | -------------------------------------------- | 29839 | 29839The stand | -------------------------------------------- -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 5 22:42:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 20:42:19 +0000 Subject: [Koha-bugs] [Bug 5678] Translations Manager In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5678 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |z.tajoli at cineca.it Resolution|--- |WONTFIX --- Comment #3 from Zeno Tajoli --- After more than 2 years no one writes a line of code for a feature like this. I close the bug with a 'WontFix'. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 00:46:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 22:46:24 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 00:46:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 22:46:29 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18743|0 |1 is obsolete| | --- Comment #14 from Chris Cormack --- Created attachment 20112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20112&action=edit Bug 10419: Script for deleting patrons This patch provides a cronjob script for deleting patrons. It takes 3 options: -not_borrowered_since -expired_date -category_code See the perldoc misc/cronjobs/delete_patrons.pl use the -v flag for a verbose mode. Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 00:46:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 22:46:46 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18990|0 |1 is obsolete| | --- Comment #15 from Chris Cormack --- Created attachment 20113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20113&action=edit Bug 10419: Followup - Script for deleting patrons This followup adds: - execute flag (+x) for the cronjob script. - replaces --dry-run with --confirm (according with existing scripts). - changes output text (remove 'first person' style). - updates the doc and simplifies the dates parameters. - changes flags PrintError and RaiseError for the dbh in order to catch something if an error occurs... Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 00:46:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 22:46:58 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19651|0 |1 is obsolete| | --- Comment #16 from Chris Cormack --- Created attachment 20114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20114&action=edit Bug 10419: Add the branchcode parameter. Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 00:47:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 22:47:12 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #17 from Chris Cormack --- Created attachment 20115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20115&action=edit Bug 10419 : Fixing license number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 00:49:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 22:49:25 +0000 Subject: [Koha-bugs] [Bug 5652] Patron checkout and holds summary should show subtitles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5652 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 00:49:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 22:49:29 +0000 Subject: [Koha-bugs] [Bug 5652] Patron checkout and holds summary should show subtitles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5652 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20042|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 20116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20116&action=edit Bug 5652 - Patron checkout and holds summary should show subtitles This patch adds subtitles (from Keyword to MARC mapping) to following tables on the checkout page: - Checkouts - Previous checkouts - Relative's checkouts - Relative's previous checkouts - Holds Additionaly it suppresses the appearence of the superfluous word "by" in cases where the biblio has no author. Test scenario: -------------- 1) Make sure that you have one or more fields mapped to subtitle in: Home . Administration . Keyword to MARC mapping (e.g. 245 b) 2) Test the checkout page with patrons having - current checkouts (today) - previous checkouts - relatives (e.g. kids) with current /previous checkouts - holds on items - holds on biblios ...with items having: - title, subtitle, author - title, no subtitle, author - title, subtitle, no author - title, no subtitle, no author 3) Do the same on patron's detail page Signed-off-by: Nicole C. Engard All tests pass Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 00:53:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Aug 2013 22:53:12 +0000 Subject: [Koha-bugs] [Bug 10487] UT: GetMaxPickupDate needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10487 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Signed Off |Patch doesn't apply --- Comment #3 from Chris Cormack --- Conflicts now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 02:39:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 00:39:39 +0000 Subject: [Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 02:39:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 00:39:43 +0000 Subject: [Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16822|0 |1 is obsolete| | --- Comment #7 from Jared Camins-Esakov --- Created attachment 20117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20117&action=edit bug 9820: display titles in MARC21 name headings better in XSLT mode Prior to this patch, if a 100/700 had a $c, it would be displayed with no space between the contents of $a and $c in XSLT mode. For example, 100 1#$aSeuss,$cDr. would be displayed as SeussDr The problem was caused by the original version of the stylesheets drawing a bit too much from the MARC21 to MODS transformation. To test: [1] In a MARC21 database, turn on XSLT display mode for staff and OPAC. [2] Create or identify a bib that has a 100 or 700 field with both a $a and a $c. [3] Before applying the patch, verify that the name is displayed in bib details and search results with the name and title squashed together. For example, "SeussDr" [3] After applying the patch, verify that the name displays in bib details and search results with a space and intervening punctuation between the name and the title. For example, "Seuss, Dr." Signed-off-by: Galen Charlton Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 02:39:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 00:39:53 +0000 Subject: [Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 --- Comment #8 from Jared Camins-Esakov --- Created attachment 20118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20118&action=edit Bug 9820 follow-up: fix a typo Although the XSLT template was renamed to nameABCQ, one instance of the old name (nameABCDQ) was not corrected. This patch corrects that. To test: Follow test plan on previous patch Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 02:45:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 00:45:48 +0000 Subject: [Koha-bugs] [Bug 10686] New: Fielded searches confuse highlighter Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Bug ID: 10686 Summary: Fielded searches confuse highlighter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: jcamins at cpbibliography.com Reporter: jcamins at cpbibliography.com QA Contact: testopia at bugs.koha-community.org If you do a fielded search like au:smith, "Smith" will not get highlighted on the results page because the Javascript is looking for the exact string "au:smith" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 03:02:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 01:02:02 +0000 Subject: [Koha-bugs] [Bug 10686] Fielded searches confuse highlighter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 03:02:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 01:02:07 +0000 Subject: [Koha-bugs] [Bug 10686] Fielded searches confuse highlighter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 --- Comment #1 from Jared Camins-Esakov --- Created attachment 20119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20119&action=edit Bug 10686: Remove fields from searches for highlighting If you do a fielded search like au:smith, "Smith" will not get highlighted on the results page because the Javascript is looking for the exact string "au:smith." To test: 1) Turn on OpacHighlightedWords. 2) Do a simple keyword search. 3) Confirm that the word is highlighted on the results and details page. 4) Do a fielded search by entering au:smith (or whatever). 5) Confirm that the word is highlighted on the results and details page. 6) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 03:12:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 01:12:16 +0000 Subject: [Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 03:12:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 01:12:20 +0000 Subject: [Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20105|0 |1 is obsolete| | --- Comment #7 from Srdjan Jankovic --- Created attachment 20120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20120&action=edit [SIGNED-OFF] Bug 10643: Inappropriate uses of $sth->finish() in C4::ClassSource.pm This patch gets rid of finish() and replace prepare_cached by prepare. >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 03:20:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 01:20:31 +0000 Subject: [Koha-bugs] [Bug 10687] New: Incorrect tab information for tags 86a and 86b on default MARC21 auth framework Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bug ID: 10687 Summary: Incorrect tab information for tags 86a and 86b on default MARC21 auth framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Tab information for subtags of 86a and 86b is incorrect. They are listed on tab 0, when they belong to tab 6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 03:21:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 01:21:00 +0000 Subject: [Koha-bugs] [Bug 10687] Incorrect tab information for tags 86a and 86b on default MARC21 auth framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 03:29:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 01:29:11 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #34 from Chris Cormack --- (In reply to Owen Leonard from comment #33) > I just tried this out with a copy of our production database of patrons > (62,000+ records) and I don't get any results. > > When I first load the page it looks like the table is trying to process > *all* patron records? The POST response has this: > > "iTotalRecords": 62459, > "iTotalDisplayRecords": 62459, > > ...but they are never displayed. I don't get any results from clicking on > the "browse by last name" alphabet links, and I don't get any results after > performing a simple search by last name. In all cases I see the "processing" > message on the screen but nothing is ever displayed. Ouch, let me test that on a big database also. Testing now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 03:31:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 01:31:27 +0000 Subject: [Koha-bugs] [Bug 10687] Incorrect tab information for tags 86a and 86b on default MARC21 auth framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 20121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20121&action=edit Bug 10687 - Incorrect tab information for tags 86a and 86b on default MARC21 auth framework This patch correct tab information for default MARC21 auth framework on tags 68a and 68b. Also added update for current installs. To test with current authorities_normal_marc21.sql loaded 1) run on database select distinct tagfield from auth_subfield_structure where cast(substr(tagfield,1,1) as unsigned) <> tab; 68a and 68b should be listed 2) apply the patch 3a) delete all auth frameworks and reload file ... OR ... 3b) run updatedatabase.pl 4) repeat step 1, no tags should be listed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 03:31:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 01:31:52 +0000 Subject: [Koha-bugs] [Bug 10687] Incorrect tab information for tags 86a and 86b on default MARC21 auth framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 03:33:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 01:33:51 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #35 from Chris Cormack --- Before the patches, 2.1s to load the page After the patches, up around 3 mins before I hit stop, and yes it was loading every single borrower. This is simply unusable with a library with a decent number of borrowers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 03:34:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 01:34:48 +0000 Subject: [Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Bob Birchall --- Works for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 06:24:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 04:24:09 +0000 Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 06:24:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 04:24:14 +0000 Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19259|0 |1 is obsolete| | --- Comment #10 from Srdjan Jankovic --- Created attachment 20122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20122&action=edit [SIGNED-OFF] Bug 5904: ysearch.pl members improvements (Independent branches behaviour) Test plan: - Add a staff user foo in a library A - Add a staff user bar in a library B - log in as foo and try to search 'bar' - Switch on (Prevent) the new pref IndependentBranchPatron - the search returns no result - log in as a superlibrarian - Check that you are allow to search all patrons. Signed-off-by: Srdjan -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 06:27:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 04:27:46 +0000 Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #11 from Srdjan Jankovic --- I've signed this off, but not sure how much sense it makes. It is just for auto-complete, so used only for the checkouts. If you search eg patrons on /members/member.pl it is not used. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 06:43:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 04:43:14 +0000 Subject: [Koha-bugs] [Bug 10688] New: QueryParser doesn't recognize QP queries when used in a fielded search box Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Bug ID: 10688 Summary: QueryParser doesn't recognize QP queries when used in a fielded search box Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: jcamins at cpbibliography.com Reporter: jcamins at cpbibliography.com QA Contact: testopia at bugs.koha-community.org If you select an index in the search dropdown and then enter in a QP query starting with the field, Koha will prepend the index you do not want to use at the beginning of the search, resulting in a search that problem does not match what you were hoping for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 06:50:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 04:50:46 +0000 Subject: [Koha-bugs] [Bug 10688] QueryParser doesn't recognize QP queries when used in a fielded search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 06:50:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 04:50:50 +0000 Subject: [Koha-bugs] [Bug 10688] QueryParser doesn't recognize QP queries when used in a fielded search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 --- Comment #1 from Jared Camins-Esakov --- Created attachment 20123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20123&action=edit Bug 10688: Don't prefix index inappropriately If you select an index in the search dropdown and then enter in a QP query starting with the field, Koha will prepend the index you do not want to use at the beginning of the search, resulting in a search that problem does not match what you were hoping for. To test: 1) Select an index in the search dropdown in the OPAC. Author is fine. 2) Enter a search term using manually entered indexes. For example: ti:cat in the hat 3) Note that the search fails. 4) Apply patch. 5) Repeat steps 1 and 2. 6) Note that the search succeeds. 7) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 07:13:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 05:13:43 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 --- Comment #7 from Srdjan Jankovic --- That's because you have DELETE FROM branches. You can try placing DELETE FROM borrowers before branches, but then you'll have problems with issues. And if you add DELETE FROM issues it will take forever to do that. I think that deleting from base tables is a bad idea. Unlike deleting from specific purpose tables, eg issuingrules, which is ok. I can see that test have progressed in the past couple of years, so this may not be relevant, but what I used to do is either: a) create my own data b) use random existing data, ie SELECT * FROM branches WHERE some_condition ORDER BY random, and take the top one; some_condition is eg has borrowers etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 12:00:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 10:00:26 +0000 Subject: [Koha-bugs] [Bug 10689] New: public note does not appear in subscriptions search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 Bug ID: 10689 Summary: public note does not appear in subscriptions search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com In a serials module, when searching subscriptions, the results table as a "Notes" column. In TT code, you see that it tries to display public note "subscription.notes" and internal note "subscription.internalnotes". Internal note is well displayed but not public note. You can see the 2 notes in serial details in summary tab. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 12:24:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 10:24:44 +0000 Subject: [Koha-bugs] [Bug 10689] public note does not appear in subscriptions search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 20124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20124&action=edit Bug 10689 - public note does not appear in subscriptions search See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 12:24:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 10:24:59 +0000 Subject: [Koha-bugs] [Bug 10689] public note does not appear in subscriptions search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 12:28:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 10:28:44 +0000 Subject: [Koha-bugs] [Bug 10689] public note does not appear in subscriptions search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20124|0 |1 is obsolete| | --- Comment #2 from Fridolyn SOMERS --- Created attachment 20125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20125&action=edit Bug 10689 - public note does not appear in subscriptions search better commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 12:38:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 10:38:07 +0000 Subject: [Koha-bugs] [Bug 10034] "kw,rld:" in Z39.50 research In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10034 --- Comment #1 from Silvia Simonetti --- Created attachment 20126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20126&action=edit patch to remove the "kw,wrdl" string This patch removes the "kw,wrdl" string that automaticaly appears in the search field when we have no result with a simple search request on the intranet and that we choose to proceed to a Z39.50 search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 12:44:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 10:44:00 +0000 Subject: [Koha-bugs] [Bug 10034] "kw,rld:" in Z39.50 research In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10034 --- Comment #2 from Silvia Simonetti --- Created attachment 20127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20127&action=edit patch to remove the "kw,wrdl" string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 15:28:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 13:28:10 +0000 Subject: [Koha-bugs] [Bug 7469] Focus on 1st field of creation form instead of search textbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7469 --- Comment #1 from Fridolyn SOMERS --- Created attachment 20128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20128&action=edit Bug 7469 - Focus on 1st field of creation form instead of search textbox (Acquisition) See commit message. This patch only modifies Acquisition module. For other modules, the search toolbar is mostly on check-out to allow the direct use of a barcode scanner. So modifying the focus may be discussed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 15:30:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 13:30:08 +0000 Subject: [Koha-bugs] [Bug 7469] Focus on 1st field of creation form instead of search textbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7469 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 15:30:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 13:30:20 +0000 Subject: [Koha-bugs] [Bug 7469] Focus on 1st field of creation form instead of search textbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7469 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 15:51:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 13:51:34 +0000 Subject: [Koha-bugs] [Bug 10690] New: Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10690 Bug ID: 10690 Summary: Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The descriptions of OPACBaseURL and staffClientBaseURL are not explicit about whether a trailing slash should be included in the URLs or not. But: Folks: if you have a trailing slash in your OPACBaseURL or staffClientBaseURL, REMOVE IT! I've been trying to troubleshoot weird firewall issues with 3.12 for one of my clients ever since the upgrade, and it turns out that the firewall was going nuts because of URLs like catalog.com//cgi-bin/koha/opac-detail.pl. Almost certainly a firewall misconfiguration, of course, but it's easy enough to work around on the server. Patch coming up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 15:52:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 13:52:31 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 20129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20129&action=edit But 10663 - Revert and use CheckReserves for CanBookBeRenewed It makes renewal lock by holds work again. Unit tests as follow up Regards To+ Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 15:52:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 13:52:41 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #9 from Nicole C. Engard --- I just tested this today so I could get a screenshot of the warning for the manual and was not warned. I did set the preference to 'Warn' and then clicked receive and entered in an invoice number that was already used in the system ... no warning. When will the warning appear? Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 15:55:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 13:55:48 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 --- Comment #10 from Nicole C. Engard --- Created attachment 20130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20130&action=edit my two invoices with the same number - even with pref set to warn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 15:57:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 13:57:54 +0000 Subject: [Koha-bugs] [Bug 5920] remove html from downloaded reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #2 from Nicole C. Engard --- This is how we do it now - but that means 2 reports - one for viewing and clicking and one for exporting. The library wanted way to use the same report for both (clicking and exporting). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 16:05:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 14:05:17 +0000 Subject: [Koha-bugs] [Bug 10690] Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10690 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 16:05:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 14:05:21 +0000 Subject: [Koha-bugs] [Bug 10690] Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10690 --- Comment #1 from Magnus Enger --- Created attachment 20131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20131&action=edit Bug 10690 - Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL The descriptions for OPACBaseURL and staffClientBaseURL are not explicit about including a trailing slash or not. This patch makes it explicit that the trailing slash should *not* be included. To test: - Apply the patch - Search for "baseurl" in the system preferences - Check that the description of both sysprefs includes a warning about not including a trailing slash. - Sign off If you want to check that the trailing slash is in fact superfluous you can do something like 'grep -r "BaseURL" *' and check that these sysprefs are usually concatenated with some string that starts with a slash. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 16:07:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 14:07:55 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 --- Comment #11 from Jared Camins-Esakov --- (In reply to Nicole C. Engard from comment #9) > I just tested this today so I could get a screenshot of the warning for the > manual and was not warned. I did set the preference to 'Warn' and then > clicked receive and entered in an invoice number that was already used in > the system ... no warning. When will the warning appear? Could you paste the results of the query "SELECT * FROM systempreferences WHERE variable = 'AcqWarnOnDuplicateInvoice';"? The syspref display appears to be glitchy, since when I tried this on master it did not work until I turned AcqWarnOnDuplicateInvoice off and back on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 16:48:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 14:48:34 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 --- Comment #12 from Nicole C. Engard --- Okay so I only turned it on once and here's the results: mysql> SELECT * FROM systempreferences WHERE variable = 'AcqWarnOnDuplicateInvoice' \G *************************** 1. row *************************** variable: AcqWarnOnDuplicateInvoice value: 1 options: explanation: Warn librarians when they try to create a duplicate invoice type: YesNo 1 row in set (0.00 sec) I can try to turn it off and on again but if that's the problem we might want to check the db update to make sure it's doing the right thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 16:49:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 14:49:57 +0000 Subject: [Koha-bugs] [Bug 10436] Identify Holds During receipting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10436 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 16:50:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 14:50:27 +0000 Subject: [Koha-bugs] [Bug 10437] Greater flexibility on Marc Edit screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10437 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 16:50:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 14:50:41 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 --- Comment #13 from Jared Camins-Esakov --- (In reply to Nicole C. Engard from comment #12) > Okay so I only turned it on once and here's the results: > > > mysql> SELECT * FROM systempreferences WHERE variable = > 'AcqWarnOnDuplicateInvoice' \G > *************************** 1. row *************************** > variable: AcqWarnOnDuplicateInvoice > value: 1 > options: > explanation: Warn librarians when they try to create a duplicate invoice > type: YesNo > 1 row in set (0.00 sec) > > > I can try to turn it off and on again but if that's the problem we might > want to check the db update to make sure it's doing the right thing. What's weird is that looks the same as what I have now that it's working. Let me know if the toggle fixes it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 16:53:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 14:53:28 +0000 Subject: [Koha-bugs] [Bug 10436] Identify Holds During receipting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10436 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Nicole C. Engard --- I think this is a duplicate. *** This bug has been marked as a duplicate of bug 10440 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 16:53:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 14:53:28 +0000 Subject: [Koha-bugs] [Bug 10440] During receipting for any holds attached to items being receipted, to be identified during the receipting process. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10440 --- Comment #3 from Nicole C. Engard --- *** Bug 10436 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 16:53:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 14:53:32 +0000 Subject: [Koha-bugs] [Bug 5652] Patron checkout and holds summary should show subtitles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5652 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master, along with a followup that adds the subtitle to the title hyperlink to make the display consistent with other uses of the subtitle in the staff interface. Thanks, Marc! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 16:56:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 14:56:59 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:09:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:09:13 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:10:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:10:19 +0000 Subject: [Koha-bugs] [Bug 7492] Split item-level_itypes in two In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7492 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:10:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:10:35 +0000 Subject: [Koha-bugs] [Bug 10385] item-level_itype checks need to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10385 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:11:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:11:38 +0000 Subject: [Koha-bugs] [Bug 10489] Add comments to news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10489 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:14:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:14:01 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 --- Comment #14 from Nicole C. Engard --- Nope ... no warning. So, here's what I'm doing: 1. search for invoices so I can find a number 2. copy an invoice number 3. click a vendor on the invoice search results 4. click receive shipment on that vendor detail page 5. enter the invoice number i copied 6. leave shipping blank 7. submit and get no warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:20:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:20:03 +0000 Subject: [Koha-bugs] [Bug 10493] Add renewal script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:20:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:20:32 +0000 Subject: [Koha-bugs] [Bug 10498] Place Hold on Order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:21:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:21:04 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:25:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:25:39 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:25:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:25:42 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20025|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov --- Created attachment 20132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20132&action=edit Bug 10404: add previous/next browsing to staff client Although previous/next browsing was added for searches in the OPAC in 2011, the staff client has been without any sort of search browsing. Until now. This patch is an all-singing, all-dancing, all-compatible implementation of search browsing that will work across multiple browser tabs and on any browser since IE7 (though the staff client layout is broken on IE7). To test: 1) Perform a search that will bring up multiple results. 2) View one of the results. 3) Use the Previous and Next links to browse along the search results. 4) Use the "Return to results" button to check that you end up at the correct page of results, even if you page through more than 20 records. 5) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:30:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:30:04 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #36 from Fridolyn SOMERS --- (In reply to Chris Cormack from comment #35) > After the patches, up around 3 mins before I hit stop I think searchable borrowers column need a SQL index : surname, ... I'll try to propose a new bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:32:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:32:58 +0000 Subject: [Koha-bugs] [Bug 10537] Super Librarian Access In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10537 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:33:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:33:37 +0000 Subject: [Koha-bugs] [Bug 7648] staff can make themselves superlibrarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7648 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10537 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:33:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:33:37 +0000 Subject: [Koha-bugs] [Bug 10537] Super Librarian Access In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10537 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7648 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:34:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:34:51 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:49:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:49:05 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:49:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:49:10 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20112|0 |1 is obsolete| | Attachment #20113|0 |1 is obsolete| | Attachment #20114|0 |1 is obsolete| | Attachment #20115|0 |1 is obsolete| | --- Comment #18 from Galen Charlton --- Created attachment 20133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20133&action=edit Bug 10419: new cronjob for deleting patrons This patch provides a cronjob script for deleting patrons. It takes 3 options: --not_borrowed_since --expired_date --category_code See the perldoc misc/cronjobs/delete_patrons.pl. Use the -v flag for a verbose mode. Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:49:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:49:20 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #19 from Galen Charlton --- Created attachment 20134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20134&action=edit Bug 10419: (followup) - tidy up cronjob for deleting patrons This followup adds: - execute flag (+x) for the cronjob script. - replaces --dry-run with --confirm (according with existing scripts). - changes output text (remove 'first person' style). - updates the doc and simplifies the dates parameters. - changes flags PrintError and RaiseError for the dbh in order to catch something if an error occurs... Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:49:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:49:33 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #20 from Galen Charlton --- Created attachment 20135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20135&action=edit Bug 10419: add branchcode parameter to patron deletion script Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:49:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:49:42 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #21 from Galen Charlton --- Created attachment 20136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20136&action=edit Bug 10419: (followup) fix license statement Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:49:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:49:51 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #22 from Galen Charlton --- Created attachment 20137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20137&action=edit Bug 10419: (follow-up) tidy names of command-line switches [1] Use --library instead of --branchcode to be consistent with other scripts and user-facing Koha terminology. [2] Use --not_borrowed_since instead of --not_borrowered_since; no need to expose typos in the API to the user. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:49:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:49:57 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #23 from Galen Charlton --- Created attachment 20138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20138&action=edit Bug 10419: (follow-up) functional improvements [1] Patron deletion now happens atomically; if one part of the process fails, the record isn't left in a partially deleted state. [2] The routine for handling lists properly during patron deletion is now invoked. [3] The script now prints an indication if it's run without --confirm; otherwise, one might think that patron records were actually being deleted. [4] --verbose now actually does something. Without --verbose, the script will print the dry-run warning (if applicable), the number of patrons to be deleted, and error messages. With --verbose, the script will also print a line with the borrowernumber of each patron to be deleted. To test: [1] Run the script with and without --verbose and compare the, well, verbosity. [2] Run the script without --confirm and note that the script prints a message saying that it's running in dry-run mode. [3] Use the script to try to delete one or more patrons that have loans. Confirm that error messages are printed reporting foreign constraints preventing the deletion. Also confirm that no new rows are added to deletedborrowers for those patrons that could not be completely deleted. [4] Use the script to delete a patron that has a public list. Verify that after the deletion, the public list still exists but now has a null owner. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 17:51:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 15:51:21 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #24 from Galen Charlton --- I ended up making two follow-ups that add two major and several minor improvements. Setting to 'Signed Off' and requesting QA of the follow-ups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 18:35:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 16:35:42 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 19:28:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 17:28:03 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20129|0 |1 is obsolete| | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 22:02:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 20:02:48 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #37 from Chris Cormack --- (In reply to Fridolyn SOMERS from comment #36) > (In reply to Chris Cormack from comment #35) > > After the patches, up around 3 mins before I hit stop > I think searchable borrowers column need a SQL index : surname, ... > I'll try to propose a new bug. That might speed it up, but no that is not the problem. The problem is that page returns every single borrower. Doing it a little faster will still be wrong. You will just crash the browser faster that way. There is no way we can have the whole borrower table loaded in and sorted with javascript. A better solution (lazy loading, server side chunking, or something similar will have to be done.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 22:04:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 20:04:06 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 22:12:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 20:12:27 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 22:12:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 20:12:31 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19987|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 20139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20139&action=edit Bug 10663: Holds never block renewals Based on Katrin's patch, this one fixes GetReserveStatus to look for biblio-level holds when an itemtype is passed and no item-level hold is set. Please test using Katrin's test plan. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 22:13:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 20:13:43 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #12 from Tom?s Cohen Arazi --- (In reply to Tom?s Cohen Arazi from comment #11) > Created attachment 20139 [details] [review] > Bug 10663: Holds never block renewals > > Based on Katrin's patch, this one fixes GetReserveStatus to look for > biblio-level > holds when an itemtype is passed and no item-level hold is set. ^^^^^^^^ Of course I meant to write itemnumber, right? :-P -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 22:16:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 20:16:53 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #38 from Chris Cormack --- Oh and Galen just reminded me Datatables supports lazy loading, so it shouldnt be too hard to add that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 22:48:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 20:48:35 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #13 from Katrin Fischer --- I think we should go with the first patch - fixing GetReserveStatus will take a lot more work and testing all the places it is in now too. The only reserve status interesting for renewals is if something can actually fill a hold. If it's checked out, it will not be waiting on the pickup shelf (W). Also it being filled (F) would not be blocking renewal - and GetReserveStatus is not querying the right table for that status anyway (old_reserves). I think fixing this bug, we need to revert to using CheckReserves - it's the same routine that is used on checkin, so it makes the most sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 23:12:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 21:12:30 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20129|1 |0 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 23:12:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 21:12:50 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20139|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 23:39:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 21:39:24 +0000 Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 Rendi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rhodge at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 6 23:51:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Aug 2013 21:51:27 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #14 from Tom?s Cohen Arazi --- Created attachment 20140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20140&action=edit Bug 10663 - Unit tests for CanBookBeRenewed Initial work on unit tests for CanBookBeRenewed. More scenarios are needed. Also made Circulation.t use autocommit=0. Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 02:00:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 00:00:25 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel --- Kyle, all seems allright, but on loaded frameworks we still have incorrect values, I think we need something like UPDATE marc_subfield_structure SET kohafield = 'items.withdrawn' WHERE kohafield = 'items.wthdrawn'; Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 10:11:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 08:11:16 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Katrin Fischer --- Thx Bernardo for spotting this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 12:21:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 10:21:51 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #39 from Fridolyn SOMERS --- (In reply to Chris Cormack from comment #38) > Oh and Galen just reminded me Datatables supports lazy loading, so it > shouldnt be too hard to add that. Yes, I also was thinking about Datatables, they already exist in many places in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 12:32:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 10:32:57 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #40 from Chris Cormack --- (In reply to Fridolyn SOMERS from comment #39) > (In reply to Chris Cormack from comment #38) > > Oh and Galen just reminded me Datatables supports lazy loading, so it > > shouldnt be too hard to add that. > > Yes, I also was thinking about Datatables, they already exist in many places > in Koha. Yes, and this set of patches adds them, but in doing so, it renders the members-home.pl page utterly unusable on any system with lots of borrowers. I think you may be misunderstanding, these patches add datatables, but they also change the behaviour so when you visit the members page it fetches every single borrower from the database. This is not acceptable, hence the failed qa, nor will an index fix it. It either needs to be rewritten to lazy load, or to not fetch all borrowers, or some other fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 14:13:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 12:13:06 +0000 Subject: [Koha-bugs] [Bug 10691] New: 5xx not properly linked by authid in authority search result list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Bug ID: 10691 Summary: 5xx not properly linked by authid in authority search result list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: jcamins at cpbibliography.com Authority search in OPAC does not use the authid for creating the link in the result list, but it does on the detail page. Example: https://eh-freiburg.bsz-bw.de/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&authtypecode=PERSO_NAME&operator=start&value=Schmidt&marclist=mainentry&and_or=and&orderby=HeadingAsc Heading: Schmidt, Andrea Link: Betriebswirtin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 14:13:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 12:13:16 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 14:14:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 12:14:41 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #8 from Kyle M Hall --- Indeed, good catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 14:16:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 12:16:17 +0000 Subject: [Koha-bugs] [Bug 7257] Add a link to remove an individual title from a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20083|0 |1 is obsolete| | --- Comment #4 from M. de Rooy --- Created attachment 20141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20141&action=edit Bug 7257 - Add a link to remove an individual title from a list It should be possible when viewing the contents of a list to click a link to remove an individual title from the list without having to check a checkbox and click another button. This patch adds a link to each list item to "Remove from this list." The functionality is JavaScript-dependent, automatically checking the appropriate checkbox and submitting the form to delete. To test, view a list for which you have delete permission. There should be a "Remove from this list" link next to each item on the list. Test delete functionality by: - Clicking the link and then clicking cancel. - Clicking the link and confirming. - Checking more than one checkbox and then clicking a single remove link (only the one corresponding record should be removed). - Checking one or more checkboxes and clicking the "Remove from list" link at the top of the page. If JavaScript is disabled the links should not appear. There are now two delete confirmation messages: One if you're removing only one item, another if you're removing more than one. This is true whether you use the links or the checkboxes. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 14:16:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 12:16:43 +0000 Subject: [Koha-bugs] [Bug 7257] Add a link to remove an individual title from a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 14:17:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 12:17:53 +0000 Subject: [Koha-bugs] [Bug 7257] Add a link to remove an individual title from a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from M. de Rooy --- QA Comment: Works as advertised. Looks good to me. No complaints from koha-qa. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 14:31:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 12:31:59 +0000 Subject: [Koha-bugs] [Bug 10572] Add phone to message_transport_types table for new installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 --- Comment #5 from M. de Rooy --- Created attachment 20142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20142&action=edit Bug 10572: Followup: dbrev for phone message_transport_type Test plan: Run the updatestructure step of web installer. Check if you have a phone message_transport_type. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 14:35:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 12:35:32 +0000 Subject: [Koha-bugs] [Bug 10572] Add phone to message_transport_types table for new installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from M. de Rooy --- Back to Signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 14:55:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 12:55:06 +0000 Subject: [Koha-bugs] [Bug 10493] Add renewal script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 14:55:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 12:55:10 +0000 Subject: [Koha-bugs] [Bug 10493] Add renewal script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20050|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 20143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20143&action=edit Bug 10493 [Template follow-up] Add renewal script This template followup fixes some minor template errors and adds some style to dialog buttons matching those seen on the circulation page. To test, submit barcodes to trigger the various error conditions: Non-existant barcode, over the renew limit, restricted patron, item on hold. Override and Ignore buttons should be properly styled and functional. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 15:47:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 13:47:44 +0000 Subject: [Koha-bugs] [Bug 10692] New: UT: Routines about transfers in C4::Circulation.pm need unit tests Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692 Bug ID: 10692 Summary: UT: Routines about transfers in C4::Circulation.pm need unit tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org "CreateBranchTransferLimit", "DeleteBranchTransferLimits", "DeleteTransfer", "GetTransfers", "GetTransfersFromTo" need unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 15:48:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 13:48:18 +0000 Subject: [Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki at biblibre.com Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 16:08:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 14:08:51 +0000 Subject: [Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 16:08:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 14:08:53 +0000 Subject: [Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692 --- Comment #1 from kenza --- Created attachment 20144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20144&action=edit Bug 10692: Routines about transfers in C4::Circulation.pm need unit tests The tests are wrap in a transaction. NOTE: Currently, some tests should pass but don't because of incoherences in the code. These tests are in comments and preceded by FIXME. To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=12, 18 wallclock secs ( 0.02 usr 0.01 sys + 0.37 cusr 0.06 csys = 0.46 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 16:12:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 14:12:52 +0000 Subject: [Koha-bugs] [Bug 10693] New: CreateBranchTransferLimit in C4::Circulation.pm should have return values Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10693 Bug ID: 10693 Summary: CreateBranchTransferLimit in C4::Circulation.pm should have return values Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 16:13:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 14:13:14 +0000 Subject: [Koha-bugs] [Bug 10693] CreateBranchTransferLimit in C4::Circulation.pm should have return values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10693 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki at biblibre.com Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 16:14:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 14:14:09 +0000 Subject: [Koha-bugs] [Bug 10693] CreateBranchTransferLimit in C4::Circulation.pm should have return values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10693 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10692 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 16:14:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 14:14:09 +0000 Subject: [Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10693 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 16:20:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 14:20:01 +0000 Subject: [Koha-bugs] [Bug 10693] CreateBranchTransferLimit's return values in C4::Circulation.pm should be more explicit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10693 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|CreateBranchTransferLimit |CreateBranchTransferLimit's |in C4::Circulation.pm |return values in |should have return values |C4::Circulation.pm should | |be more explicit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 16:43:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 14:43:22 +0000 Subject: [Koha-bugs] [Bug 10693] CreateBranchTransferLimit's return values in C4::Circulation.pm should be more explicit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10693 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 16:43:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 14:43:25 +0000 Subject: [Koha-bugs] [Bug 10693] CreateBranchTransferLimit's return values in C4::Circulation.pm should be more explicit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10693 --- Comment #1 from kenza --- Created attachment 20145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20145&action=edit Bug 10693: CreateBranchTransferLimit's return value in C4::Circulation.pm should be more explicit This patch test if the parameters $toBranch and $fromBranch are given. If not, CreateBranchTransferLimit now returns undef. This patch also fixes and adds some regression tests in t/db_dependent/Circulation_transfers.t NOTE: Currently, we can add a transferlimit to nonexistent branches because in the database branch_transfer_limits.toBranch and branch_transfer_limits.fromBranch aren't foreign keys. To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=15, 18 wallclock secs ( 0.02 usr 0.01 sys + 0.42 cusr 0.00 csys = 0.45 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 16:46:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 14:46:20 +0000 Subject: [Koha-bugs] [Bug 7257] Add a link to remove an individual title from a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:02:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:02:01 +0000 Subject: [Koha-bugs] [Bug 10694] New: Allow arbitrary backdating of returns Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Bug ID: 10694 Summary: Allow arbitrary backdating of returns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Sometimes libraries need to backdate returns further back in time than Koha's dropbox mode will allow. The returns backdating will check in an item as if it had been returned on the specified date, and will reduce any fine accordingly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:02:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:02:16 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10694 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:02:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:02:16 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8769 Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:05:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:05:49 +0000 Subject: [Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10681 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:05:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:05:49 +0000 Subject: [Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10692 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:08:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:08:00 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 --- Comment #21 from Fridolyn SOMERS --- *** Bug 8036 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:08:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:08:00 +0000 Subject: [Koha-bugs] [Bug 8036] item type on purchase suggestion blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8036 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Fridolyn SOMERS --- *** This bug has been marked as a duplicate of bug 9223 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:08:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:08:13 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:08:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:08:16 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 --- Comment #1 from Kyle M Hall --- Created attachment 20146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20146&action=edit Bug 10694 - Allow arbitrary backdating of returns Sometimes libraries need to backdate returns further back in time than Koha's dropbox mode will allow. The returns backdating will check in an item as if it had been returned on the specified date, and will reduce any fine accordingly. Test Plan: 1) Apply the patch for bug 8769 2) Apply this patch 3) Check out an item, and backdate the due date by 1 month or so * This issue needs to generate a fine 4) Run fines.pl to generate the fine 5) Browse to returns.pl 6) Specify a return date of the day after the specified due date 7) Check the borrowers issue history, you should see the backdated return date, rather than today's date 8) Check the fine, it should be reduced to a fine for a single day overdue, rather than the previous larger fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:13:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:13:56 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9223 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:13:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:13:56 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10588 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:15:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:15:34 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20055|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:17:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:17:10 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 --- Comment #11 from Fridolyn SOMERS --- Added link to Bug 9223 because the code of opac-top issues should use C4::Koha::GetSupportList. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:19:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:19:10 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20146|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 20147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20147&action=edit Bug 10694 - Allow arbitrary backdating of returns Sometimes libraries need to backdate returns further back in time than Koha's dropbox mode will allow. The returns backdating will check in an item as if it had been returned on the specified date, and will reduce any fine accordingly. Test Plan: 1) Apply the patch for bug 8769 2) Apply this patch 3) Check out an item, and backdate the due date by 1 month or so * This issue needs to generate a fine 4) Run fines.pl to generate the fine 5) Browse to returns.pl 6) Specify a return date of the day after the specified due date 7) Check the borrowers issue history, you should see the backdated return date, rather than today's date 8) Check the fine, it should be reduced to a fine for a single day overdue, rather than the previous larger fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:27:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:27:41 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 --- Comment #22 from Fridolyn SOMERS --- I'd like to discuss more on this bug. How can the syspref concerne only suggestions when it is used in C4::Koha::GetSupportList() ? This is the method doc : "Returns an array ref containing informations about Support (since itemtype is rather a circulation code when item-level-itypes is used)." This is the point, we need to have a syspref telling where to find the physical category of the record (itemtype or ccode). This code is used for suggestions (both intranet and opac) and should be used in other places like opac-topissues.pl filter (actually also broken if AdvancedSearchTypes is multivalued). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 17:49:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 15:49:28 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 --- Comment #23 from Katrin Fischer --- Hi Fridolyn, I think this assumption is not quite right: >This is the point, we need to have a syspref telling where to find the physical >category of the record (itemtype or ccode). There is not guarantee or reason that a library will use itemtype or ccode to define the physical category of a record. They can use it for whatever they like and from my experience they do use it in a lot of different ways. I think we schould just make it a pref that defines what to show on the suggestion form with a correct label: Location, (Circulation?) type, Collection. And use that for suggestons in staff and OPAC. Also it might make sense for a library to have different values used for suggestions and opac-topissues - so maybe we should not tie those together. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 19:27:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 17:27:51 +0000 Subject: [Koha-bugs] [Bug 10695] New: Koha does not warn about holds when renewing an item via checkboxes on circulation.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10695 Bug ID: 10695 Summary: Koha does not warn about holds when renewing an item via checkboxes on circulation.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If you scan an item for renewal on circulation.pl, and the item has holds that should block renewal, you will get a message for confirmation/override. On the other hand, if you select the renewal checkbox and click the "Renew or Return checked items" button, the item will be renewed without warning. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 7 21:46:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Aug 2013 19:46:53 +0000 Subject: [Koha-bugs] [Bug 10696] New: Shelf browser in mobile theme. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10696 Bug ID: 10696 Summary: Shelf browser in mobile theme. Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: ed.veal at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When you view the OPAC in mobile view based on the CCSR theme the () appear that surround the Brows Shelf link but the link is absent so all that appears are empty (). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 02:03:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 00:03:30 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20129|0 |1 is obsolete| | Attachment #20140|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 20148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20148&action=edit Bug 10633: Follow-up - Unit tests for CanBookBeRenewed Follow-up fixing some and adding more unit tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 02:05:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 00:05:46 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #16 from Katrin Fischer --- Created attachment 20149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20149&action=edit [SIGNED-OFF] Bug 10663 - Unit tests for CanBookBeRenewed Initial work on unit tests for CanBookBeRenewed. More scenarios are needed. Also made Circulation.t use autocommit=0. Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Katrin Fischer Adding some more unit tests in follow up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 02:06:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 00:06:04 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20148|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 20150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20150&action=edit Bug 10633: Follow-up - Unit tests for CanBookBeRenewed Follow-up fixing some and adding more unit tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 02:06:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 00:06:26 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #18 from Katrin Fischer --- Created attachment 20151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20151&action=edit [SIGNED OFF] Bug 10663 - Revert and use CheckReserves for CanBookBeRenewed It makes renewal lock by holds work again. Unit tests as follow up Regards To+ Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Katrin Fischer This reverts changes made to CanBookBeRenewed by patches from bug 9376. GetReserveStatus is not suitable to recognize if an item can fild a hold on return and CheckReserves is restored. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 02:06:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 00:06:37 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #19 from Katrin Fischer --- Created attachment 20152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20152&action=edit Bug 10663: Follow-up - Revert and use CheckReserves for CanBookBeRenewed CheckReserves returns '' when no reserve is found, so $resfound will always be defined and we need to check if it's true. This is part of the revert. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 02:15:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 00:15:14 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #20 from Katrin Fischer --- Some more notes about testing this: A 0) Allow OPAC renewals (OpacRenewalAllowed) Create a new record with one item. 1) Check out the item to patron A. 2) Place an item level hold for patron B. 3) Try to renew the item in the OPAC for patron A. > Renewal should be blocked after patches are applied. B 4) Cancel item level hold 5) Place title level hold for patron B. 6) Try to renew the item in the OPAC for patron A. > Renewal should be blocked, after patches are applied Also: a) Apply first 2 patches - run t/db_dependent/Circulation.t Tests related to checking if an item is reserved will fail. b) Apply last 2 patches - run tests again. Tests should all pass now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 02:26:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 00:26:42 +0000 Subject: [Koha-bugs] [Bug 6382] Automatic Status Changing on Check In In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6382 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I agree with Owen that this would need to be configurable and not changing current workflows. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 02:40:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 00:40:54 +0000 Subject: [Koha-bugs] [Bug 10695] Koha does not warn about holds when renewing an item via checkboxes on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10695 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Could be related to bug 10663. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 04:18:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 02:18:50 +0000 Subject: [Koha-bugs] [Bug 10695] Koha does not warn about holds when renewing an item via checkboxes on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10695 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea --- This bug has been around for AGES. AGES. I'm not even sure how you'd go about displaying this in a properly useful way... 10 reserve boxes on a page? I think it would be better to simply remove the checkin functionality from this page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 06:49:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 04:49:58 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #21 from Chris Cormack --- Created attachment 20153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20153&action=edit Bug 10663 - Unit tests for CanBookBeRenewed Initial work on unit tests for CanBookBeRenewed. More scenarios are needed. Also made Circulation.t use autocommit=0. Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Katrin Fischer Adding some more unit tests in follow up. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 06:50:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 04:50:33 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20149|0 |1 is obsolete| | Attachment #20150|0 |1 is obsolete| | --- Comment #22 from Chris Cormack --- Created attachment 20154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20154&action=edit Bug 10663: Follow-up - Unit tests for CanBookBeRenewed Follow-up fixing some and adding more unit tests. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 06:51:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 04:51:05 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #23 from Chris Cormack --- Created attachment 20155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20155&action=edit Bug 10663 - Revert and use CheckReserves for CanBookBeRenewed It makes renewal lock by holds work again. Unit tests as follow up Regards To+ Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Katrin Fischer This reverts changes made to CanBookBeRenewed by patches from bug 9376. GetReserveStatus is not suitable to recognize if an item can fild a hold on return and CheckReserves is restored. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 06:51:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 04:51:21 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 06:51:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 04:51:26 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20151|0 |1 is obsolete| | Attachment #20152|0 |1 is obsolete| | --- Comment #24 from Chris Cormack --- Created attachment 20156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20156&action=edit Bug 10663: Follow-up - Revert and use CheckReserves for CanBookBeRenewed CheckReserves returns '' when no reserve is found, so $resfound will always be defined and we need to check if it's true. This is part of the revert. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 07:40:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 05:40:15 +0000 Subject: [Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 07:40:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 05:40:20 +0000 Subject: [Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20107|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 20157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20157&action=edit Bug 10681: Inappropriate uses of finish() in C4::Circulation.pm This patch gets rid of finish(). >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 07:41:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 05:41:55 +0000 Subject: [Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 07:41:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 05:41:59 +0000 Subject: [Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20144|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 20158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20158&action=edit Bug 10692: Routines about transfers in C4::Circulation.pm need unit tests The tests are wrap in a transaction. NOTE: Currently, some tests should pass but don't because of incoherences in the code. These tests are in comments and preceded by FIXME. To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=12, 18 wallclock secs ( 0.02 usr 0.01 sys + 0.37 cusr 0.06 csys = 0.46 CPU) Result: PASS Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 07:43:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 05:43:56 +0000 Subject: [Koha-bugs] [Bug 10693] CreateBranchTransferLimit's return values in C4::Circulation.pm should be more explicit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10693 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 07:44:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 05:44:00 +0000 Subject: [Koha-bugs] [Bug 10693] CreateBranchTransferLimit's return values in C4::Circulation.pm should be more explicit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10693 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20145|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 20159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20159&action=edit Bug 10693: CreateBranchTransferLimit's return value in C4::Circulation.pm should be more explicit This patch test if the parameters $toBranch and $fromBranch are given. If not, CreateBranchTransferLimit now returns undef. This patch also fixes and adds some regression tests in t/db_dependent/Circulation_transfers.t NOTE: Currently, we can add a transferlimit to nonexistent branches because in the database branch_transfer_limits.toBranch and branch_transfer_limits.fromBranch aren't foreign keys. To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=15, 18 wallclock secs ( 0.02 usr 0.01 sys + 0.42 cusr 0.00 csys = 0.45 CPU) Result: PASS Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 10:06:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 08:06:32 +0000 Subject: [Koha-bugs] [Bug 10697] New: Revert from using GetReserveStatus to use CheckReserves Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 Bug ID: 10697 Summary: Revert from using GetReserveStatus to use CheckReserves Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The GetReserveStatus subroutine doesn't cover all needed use cases and the change done by bug 9367 need to be reverted for that reason. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 10:07:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 08:07:24 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9367, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10663 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 10:07:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 08:07:24 +0000 Subject: [Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10697 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 10:07:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 08:07:24 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10697 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 10:07:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 08:07:43 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 10:14:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 08:14:06 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from M. de Rooy --- (In reply to Katrin Fischer from comment #0) > The GetReserveStatus subroutine doesn't cover all needed use cases and the > change done by bug 9367 need to be reverted for that reason. Do you have more specific information? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 10:25:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 08:25:55 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 --- Comment #2 from Katrin Fischer --- Yes, it's on bug 10663. Current state of things is that GetReserveStatus does: - not return Filled (Finished) correctly, because it checks the wrong table. - not return Reserved correctly because it leaves out lots of the logic that CheckReserves has to determine if an item can actually fill a hold and totally ignores title level holds when only called with itemnumber. - not return Waiting correctly, because the condition is wrong (see obsoleted partial fix patch on bug 10663) I have spent hours on this as have others and a revert is IMO the best option to fix the regression introduced by bug 9367. It was too late to revert it from git, so doing it in smaller steps accompanied by unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 10:36:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 08:36:52 +0000 Subject: [Koha-bugs] [Bug 10698] New: DeleteTransfer in C4::Circulation.pm needs return value Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 Bug ID: 10698 Summary: DeleteTransfer in C4::Circulation.pm needs return value Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 10:37:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 08:37:42 +0000 Subject: [Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10692 Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 10:37:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 08:37:42 +0000 Subject: [Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10698 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 10:44:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 08:44:40 +0000 Subject: [Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 10:44:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 08:44:43 +0000 Subject: [Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 --- Comment #1 from kenza --- Created attachment 20160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20160&action=edit Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value This patch adds return values to DeleteTransfer: Undef if no parameters are given 1 if a Transfer is deleted 0E0 if a wrong parameter is given It also fixes some unit tests in t/db_dependent/Circulation_transfers.t To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=14, 20 wallclock secs ( 0.03 usr 0.00 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 10:46:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 08:46:11 +0000 Subject: [Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 11:00:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 09:00:49 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 --- Comment #8 from kenza --- Created attachment 20161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20161&action=edit Bug 10642 : Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 11:12:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 09:12:41 +0000 Subject: [Koha-bugs] [Bug 10034] "kw,rld:" in Z39.50 research In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10034 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20126|1 |0 is patch| | Attachment #20126|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 11:16:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 09:16:09 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20161|1 |0 is patch| | Attachment #20161|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 11:22:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 09:22:53 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20106|0 |1 is obsolete| | --- Comment #9 from kenza --- Created attachment 20162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20162&action=edit Bug 10653: C4::RotatingCollections.pm needs unit tests The tests are wrap in a database transaction. Test plan: prove t/db_dependent/RotatingCollections.t t/db_dependent/RotatingCollections.t .. ok All tests successful. Files=1, Tests=41, 20 wallclock secs ( 0.02 usr 0.01 sys + 0.41 cusr 0.02 csys = 0.46 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 11:25:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 09:25:36 +0000 Subject: [Koha-bugs] [Bug 10699] New: DeleteBranchTransferLimits in C4/Circulation.pm needs return value Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699 Bug ID: 10699 Summary: DeleteBranchTransferLimits in C4/Circulation.pm needs return value Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 11:26:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 09:26:43 +0000 Subject: [Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in C4/Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki at biblibre.com Depends on| |10692 Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 11:26:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 09:26:43 +0000 Subject: [Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10699 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 11:45:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 09:45:25 +0000 Subject: [Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in C4/Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699 --- Comment #1 from kenza --- Created attachment 20163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20163&action=edit Bug 10699:DeleteBranchTransferLimits in C4/Circulation.pm needs return value This patch adds return values to DeleteBranchTransferLimits: 1 if a Transfer Limit is deleted undef if no parameters is given 0E0 if a wrong parameter is given More, it fixes and adds some tests in t/db_dependent/Circulation_transfers.t To test : prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=14, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 11:45:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 09:45:21 +0000 Subject: [Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in C4/Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 12:02:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 10:02:05 +0000 Subject: [Koha-bugs] [Bug 10034] "kw,rld:" in Z39.50 research In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10034 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |magnus at enger.priv.no --- Comment #3 from Magnus Enger --- Setting the status to "Needs Signoff", as there is a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 12:20:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 10:20:32 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 --- Comment #3 from Katrin Fischer --- Ah I see now, that I got a little confused - Waiting works fine, which is why the patch here won't make much difference in most cases. I still think reverting is the safer option and maybe we should just remove GetReserveStatus and instead create something new and light weight that just checks for the 'Waiting' status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 12:33:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 10:33:03 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 --- Comment #4 from Katrin Fischer --- Created attachment 20164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20164&action=edit Bug 10697 - Adding more unit tests to CheckReserves Adding more unit tests for CheckReserves to cover more use cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 12:33:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 10:33:16 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 --- Comment #5 from Katrin Fischer --- Created attachment 20165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20165&action=edit Bug 10697: Revert from using GetReserveStatus to use CheckReserves Patch reverts switch from CheckReserves to GetReserveStatus done by 9367 in various places. Note: You will need the patches from bug 10663 to check renewal related functionality. Note: When the check is only done for "Waiting" it will work the same before and after applying this patch as this part of GetReserveStatus works fine. In order to test this, create item and title level holds on some records, make sure that there are holds not yet pulled and items waiting for pickup in the library. Search.pm - searchResult XSLT.pm - buildKohaItemsNamespace Check item status in search result list are shown correctly using XSLT and non-XSLT views. Only checked for 'Waiting', so verify no regressions. opac-detail.pl Check on item status is shown correctly on detail pages in OPAC. if( $reserve_status eq "Reserved"){ $itm->{'onhold'} = 1; } seems to be not used, verify no regressions. circulation.pl - build_issue_data opac-user.pl Check items on hold are properly marked in the list of checkouts and can not be renewed for - patron account pages in the staff interface - patron account pages in the OPAC $it->{'renew_error'} = ( $restype eq "Waiting" or $restype eq "Reserved" ) ? 1 : 0; seems to be not used, verify no regressions. Run unit tests from first patch and any additional tests you can think of. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 12:37:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 10:37:29 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|major |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 13:25:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 11:25:03 +0000 Subject: [Koha-bugs] [Bug 6206] can't change framework in the middle of cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6206 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Nicole C. Engard --- *** This bug has been marked as a duplicate of bug 10448 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 13:25:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 11:25:04 +0000 Subject: [Koha-bugs] [Bug 10448] Changing framework when cataloguing clears all fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10448 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #10 from Nicole C. Engard --- *** Bug 6206 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 14:55:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 12:55:50 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 15:11:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 13:11:52 +0000 Subject: [Koha-bugs] [Bug 5832] rss.pl limited to 15 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5832 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Owen Leonard --- The templates for this rss script haven't been updated since before we switched to Template Toolkit. Since then we've added the ability to make SQL reports public. I think it's time to get rid of /misc/cronjobs/rss altogether. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 15:17:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 13:17:34 +0000 Subject: [Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521 --- Comment #1 from M. de Rooy --- Created attachment 20166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20166&action=edit Bug 10521: Prepare de-DE mandatory sql files for conversion Makes some manual changes to .sql files before converting them to new format for use with i18n function. Sample notices: remove newline between last quote and ); Stopwords: Add column name Userflags: Convert into one insert statement with multiple values Test plan: See second patch for de-DE mandatory files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 15:17:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 13:17:40 +0000 Subject: [Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521 --- Comment #2 from M. de Rooy --- Created attachment 20167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20167&action=edit Bug 10521: Define i18n function for de-DE/mandatory files This patch adjusts the de-DE/mandatory files. Test plan: Run German install, including all mandatory files. Check translated strings from several tables touched in Mandatory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 15:17:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 13:17:45 +0000 Subject: [Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521 --- Comment #3 from M. de Rooy --- Created attachment 20168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20168&action=edit Bug 10521: Prepare de-DE optional sql files for conversion Makes some manual changes to .sql files before converting them to new format for use with i18n function. Sample creator data: Remove lock statements, add column names Sample holidays: Add column names Sample itemtypes: Convert into one insert statement with multiple values Sample news: Add column name Test plan: See next patch for de-DE optional files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 15:17:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 13:17:50 +0000 Subject: [Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521 --- Comment #4 from M. de Rooy --- Created attachment 20169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20169&action=edit Bug 10521: Define i18n function for de-DE/optional files This patch adjusts the de-DE/optional files. Test plan: Run German install, including all optional files. Check translated strings from several tables touched in Optional. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 15:17:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 13:17:55 +0000 Subject: [Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521 --- Comment #5 from M. de Rooy --- Created attachment 20170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20170&action=edit Bug 10521: Followup for relator terms and quotes These files were still missing in the German install. Test plan: Select relator terms and quotes in German optional install. Since nothing is translated yet, you should see English strings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 15:17:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 13:17:59 +0000 Subject: [Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521 --- Comment #6 from M. de Rooy --- Created attachment 20171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20171&action=edit Bug 10521: Prepare de-DE marc21/optional files for conversion Makes some manual changes to .sql files before converting them to new format for use with i18n function. Default matching rules: added only some comment lines to skip a few INSERT..SELECT constructs during conversion. Fastadd framework: Add column names. Test plan: See next patch for de-DE marc21/optional files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 15:22:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 13:22:27 +0000 Subject: [Koha-bugs] [Bug 10700] New: Remove misc/cronjobs/rss Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10700 Bug ID: 10700 Summary: Remove misc/cronjobs/rss Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The RSS cron script hasn't been touched for years, and the associated template files predate our switch to Template Toolkit. Since we now have the ability to make the results of saved SQL reports public, I think we should consider this RSS system dead and remove it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 15:25:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 13:25:37 +0000 Subject: [Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 --- Comment #8 from Owen Leonard --- A test plan is a simple description of the steps one would take to confirm that a patch works. Usually this means confirming that a patch fixes a particular problem and doesn't cause other problems. Is there a real-world case where this fixes a browser error? If not, you should describe how to test each affected page/action to confirm that the patch hasn't caused any problems. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 15:25:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 13:25:56 +0000 Subject: [Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521 --- Comment #7 from M. de Rooy --- Created attachment 20172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20172&action=edit [PATCH_IN_GZ] Bug 10521: Define i18n function for de-DE/marc21/mandatory Patch in zipped attachment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 15:27:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 13:27:15 +0000 Subject: [Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521 --- Comment #8 from M. de Rooy --- Created attachment 20173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20173&action=edit [PATCH_IN_GZ] Bug 10521: Define i18n function for de-DE/marc21/optional Patch zipped in attachment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 15:28:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 13:28:04 +0000 Subject: [Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 15:30:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 13:30:27 +0000 Subject: [Koha-bugs] [Bug 2806] issuingbranch isn't used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 --- Comment #2 from Owen Leonard --- (In reply to Liz Rea from comment #1) > Which still leaves the question, populate issuingbranch or just depend on > items.branchcode and remove issuingbranch? Since items.branchcode is updated with the branchcode of the issuing branch, and then issues.branchcode is updated with the same value, what is the point of having a second field, issues.issuingbranch? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 15:34:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 13:34:08 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #41 from Fridolyn SOMERS --- Created attachment 20174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20174&action=edit Bug 9811 - multilines notes brakes JSON A small bug that brakes Ajax call and causes a forever loading member search. See commit mesage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 16:05:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 14:05:18 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 --- Comment #8 from Nicole C. Engard --- A suggestion I got today is 'consolidate' or 'consolidate emails' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 16:05:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 14:05:42 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 --- Comment #9 from Nicole C. Engard --- better suggestion: 'consolidate messages' or 'consolidate msgs' to save space -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 16:07:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 14:07:51 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #42 from Fridolyn SOMERS --- (In reply to Chris Cormack from comment #40) > these patches add datatables, but they also change the behaviour > so when you visit the members page it fetches every single borrower from the database. In C4/Utils/DataTables/Members.pm : The SQL query does not fetch all borrowers, it uses iDisplayStart and iDisplayLength to limit to the first page (usually 20 borrowers). And when there is not filter, there is only a select count(*) from borrowers, this should not take a long time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 16:08:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 14:08:22 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 --- Comment #10 from Katrin Fischer --- 'consolidate msgs' might save space, but really confuse translators. I would have no idea how to translate that seeing it out of context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 16:08:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 14:08:34 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20174|Bug 9811 - multilines notes |Bug 9811 - multilines notes description|brakes JSON |breaks JSON -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 16:11:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 14:11:22 +0000 Subject: [Koha-bugs] [Bug 7463] don't show item number on fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7463 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Severity|enhancement |normal --- Comment #1 from Owen Leonard --- This appears to be fixed in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 16:42:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 14:42:49 +0000 Subject: [Koha-bugs] [Bug 10570] Show internal note from subscription in results on check expiration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10570 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 16:42:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 14:42:54 +0000 Subject: [Koha-bugs] [Bug 10570] Show internal note from subscription in results on check expiration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10570 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19530|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 20175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20175&action=edit [SIGNED-OFF] Bug 10570: Show nonpublic note on check expiration page The check expiration page in serials only showed the OPAC note, but it makes sense to also show the nonpublic note here. This patch adds it. To test: - Add a subscription, make sure to enter different notes in nonpublic note and OPAC note to check for display later on. - Go to the check expiration page and search for your subscription. - Check both notes show up correctly. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 17:02:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 15:02:06 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 17:02:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 15:02:11 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20132|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 20176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20176&action=edit [SIGNED-OFF] Bug 10404: add previous/next browsing to staff client Although previous/next browsing was added for searches in the OPAC in 2011, the staff client has been without any sort of search browsing. Until now. This patch is an all-singing, all-dancing, all-compatible implementation of search browsing that will work across multiple browser tabs and on any browser since IE7 (though the staff client layout is broken on IE7). To test: 1) Perform a search that will bring up multiple results. 2) View one of the results. 3) Use the Previous and Next links to browse along the search results. 4) Use the "Return to results" button to check that you end up at the correct page of results, even if you page through more than 20 records. 5) Sign off. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 17:08:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 15:08:12 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 17:08:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 15:08:16 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 --- Comment #5 from Owen Leonard --- Created attachment 20177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20177&action=edit Bug 10404 [CSS follow-up] Add previous/next browsing to staff client search results This patch slightly modifies the styles of the previous/next links in a way that I think is simpler and clearer. To test, apply the patch and clear your browser cache if necessary. Perform a search in the staff client, click any result, and look at the prevous/next links. If you think this is an improvement, sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 17:20:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 15:20:28 +0000 Subject: [Koha-bugs] [Bug 6035] Mobile interface for OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6035 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Owen Leonard --- (In reply to Magnus Enger from comment #5) > Did the CCSR theme make this obsolete? I would say yes, not to mention Bug 10309 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 17:24:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 15:24:43 +0000 Subject: [Koha-bugs] [Bug 8902] Many columns do not appear in batch modification if selected records do not include them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8902 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 18:12:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 16:12:21 +0000 Subject: [Koha-bugs] [Bug 10007] Totals in checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10007 --- Comment #1 from Owen Leonard --- It looks like Koha is displaying the total amount owed by the patron regardless of whether that amount is from a rental charge listed in the checkouts table or a charge for something else (like a lost item). The total for this column should add up only rental charges listed in that table if it is to be correct. However, it should be noted that the rental charges listed in the table of checkouts are not shown based on charges which are actually on the patron's account (in the accountlines table), the charges are listed according to the current policy. If I checked out a DVD last week when there was no rental charge, and then check out a DVD today after a $3.00 rental fee was added the screen will show a $3.00 charge for both of those items even though accountlines will only have a line for the $3.00 I actually incurred after the rental fee policy change. We can't fix the total until we fix the way rental fees are calculated by the script. This leads me to wonder... Is there a good reason to be displaying the rental fee at all on this page? Do libraries who charge rental fees have policies which require them to be paid on a higher priority basis than other fines? If not, showing the total of all fines and charges on this screen (as we do) should be enough. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 18:36:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 16:36:17 +0000 Subject: [Koha-bugs] [Bug 8287] remove filter on checked out from overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8287 --- Comment #3 from Owen Leonard --- (In reply to Nicole C. Engard from comment #2) > So, then maybe that box needs to say "Ignore Due-Date filter above" instead > - or something more accurate. The checkbox basically switches this from a report of overdues to a report of checkouts. "Show all checkouts regardless of date due" might be more accurate? It's a strange feature to include in a report for showing overdues. If you check the box the title of the report really should change to reflect that it's showing more than just overdues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 18:37:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 16:37:34 +0000 Subject: [Koha-bugs] [Bug 9861] Solr: HTTP 404 when i click on title or author in search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9861 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|i get HTTP 404 when i |Solr: HTTP 404 when i click |click on title or author in |on title or author in |search results. |search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 19:03:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 17:03:04 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #12 from Nicole C. Engard --- It's been a while on this, but can we get an updated patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 19:16:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 17:16:23 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 19:16:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 17:16:26 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19502|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 20178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20178&action=edit Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 20:13:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 18:13:24 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20178|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 20179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20179&action=edit [SIGNED-OFF] Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Save for translation files (that will be fixed on next release), only occurrence of wthdrawn is on updatedatabase.pl No koha-qa errors. This touch many files, and I did not test everything, but all seems normal. I think that any problem could be fixed later. Perhaps both entries in updatedatabase.pl could be joined into one, but thats for QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 20:13:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 18:13:55 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 20:38:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 18:38:49 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16763|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 20180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20180&action=edit Bug 9011 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the field items.last_borrower, foreign key to borrowers.borrowernumber * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha set this new field to the patron who last returned this item. * If this new field has a value, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the given borrowernumber. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 20:39:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 18:39:44 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 20:39:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 18:39:47 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16773|0 |1 is obsolete| | Attachment #18676|0 |1 is obsolete| | Attachment #20180|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 20181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20181&action=edit Bug 9011 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the field items.last_borrower, foreign key to borrowers.borrowernumber * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha set this new field to the patron who last returned this item. * If this new field has a value, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the given borrowernumber. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 20:43:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 18:43:59 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 20:44:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 18:44:06 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 20182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20182&action=edit Bug 8507: koha-create should be updated to use DOM indexing for bib This patch makes the koha-create script install the file zebra-biblios-dom.cfg with the proper string substitutions inside on the new instance. It also adds two option switches that control the indexing mode for the instance: --biblio-idx {dom|grs1} --auth-idx {dom|grs1} DOM indexing is set as the default for both authorities and bibliographic records. To test: - Apply the patch - Build your own packages and install them on a test server a) Create a new instance without using the new switches like: $ koha-create --create-db domtest - Check there's a file /etc/koha/sites/domtest/zebra-biblios-dom.cfg - Check that /etc/koha/sites/domtest/koha-conf.xml points to: * zebra-biblios-dom.cfg (biblioserver section) * zebra-biblios-dom.cfg (publicserver section) * zebra-authorities-dom.cfg (authorityserver section) - Success means the new default is DOM b) Play with the 4 possible combination of option switches $ koha-create --create-db --auth-idx grs1 --biblio-idx grs1 domtest $ koha-create --create-db --auth-idx grs1 --biblio-idx dom domtest $ koha-create --create-db --auth-idx dom --biblio-idx grs1 domtest $ koha-create --create-db --auth-idx dom --biblio-idx dom domtest - Check the koha-conf.xml file reflects the chosen options. c) Run $ koha-create --help - It should advertise this addition accordingly. d) Run $ man koha-create - Man page for koha-create should provide good information on the new switches behaviour Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 20:44:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 18:44:28 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 20:51:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 18:51:28 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19674|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 20183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20183&action=edit Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable Some libraries would like to sort by columns for the records of an import batch. This seems like a good use of ajax DataTables. Test plan: 1) Apply this patch 2) Import a record batch into Koha a) Use some form of matching b) Have some records that will match and some that won't c) Have at least 30 records so you can test the pager 3) Verify the new table is functionally equivilent to the old static one Signed-off-by: Owen Leonard Tests fine and looks good with the exception of the corrections I put in a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 20:51:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 18:51:38 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19682|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 20184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20184&action=edit Bug 10558 [Follow-up] Convert records table in manage-marc-import.pl to ajax DataTable This patch makes improvements to the default DataTables CSS and corrects a couple of errors in the original patch. CSS for the "full numbers" type pagination, used by this and the quotes editor, has been cleaned up and made more visually consistent with the brief pagination style. Also changed: - removed some hard-coded paths containing "http://staff.kohadev..." - Added a column header to the column showing record match details. This provides both information and a clearer target for clicking to resort - Expanding the default table pager controls for this page and the quotes editor (for consistency) - Correction to quotes.css to fix pager display problem on wide screens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 20:51:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 18:51:50 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 20:51:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 18:51:53 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19692|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall --- Created attachment 20185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20185&action=edit Bug 10558 [QA Follow-up] Convert records table in manage-marc-import.pl to ajax DataTable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 20:57:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 18:57:48 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19577|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 20186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20186&action=edit Bug 10573: French translation for printing a basketgroup If you want to print a basketgroup with pdf format, it will be in english. The pdf is done with layout2pages.pm or layout3pages.pm which call layout2pages.pdf or layout3pages.pdf. This patch adds layout3pagesfr.pm in src/acqui/pdfformat/ which calls layout3pagesfr.pdf. And adds in basketgroup.pl the check for layout3pagesfr To use it you have to change the systempreferences to pdfformat::layout3pagesfr Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described, koha-qa reports some tab errors. Corrected in a followup. Please, always add a test plan, it's easier to test. Test: 1) apply the patch 2) change syspref OrderPdfFormat to pdfformat::layout3pagesfr 3) select a vendor 4) create a basket group (empty works) 5) close basket group 6) print basket group 7) PDF is in french -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 20:58:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 18:58:59 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 20187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20187&action=edit Bug 10573 - Folloup - French translation for printing a basketgroup small followup to fix tabs Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 20:59:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 18:59:49 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 21:25:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 19:25:18 +0000 Subject: [Koha-bugs] [Bug 9247] Add two more usage examples to the manpage for koha-mysql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9247 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19988|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 20188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20188&action=edit Bug 9247 - Add two more usage examples to the manpage for koha-mysql It might not be immediately obvious that it is possible to send SQL queries "directly" to the koha-mysql command, or that files from mysqldump can be loaded with it. This patch adds these as "example usage" to the man page for koha-mysql. To test: Run these commands and look at the formatted man page: $?xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-mysql.xml $?man -l koha-mysql.8 Make sure this test passes: $?prove -v xt/verify-debian-docbook.t This patch also corrects a couple places where "Koha" was written as "koha". Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 21:25:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 19:25:37 +0000 Subject: [Koha-bugs] [Bug 9247] Add two more usage examples to the manpage for koha-mysql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9247 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 21:29:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 19:29:13 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20182|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 20189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20189&action=edit Bug 8507: koha-create should be updated to use DOM indexing for bib This patch makes the koha-create script install the file zebra-biblios-dom.cfg with the proper string substitutions inside on the new instance. It also adds two option switches that control the indexing mode for the instance: --biblio-idx {dom|grs1} --auth-idx {dom|grs1} DOM indexing is set as the default for both authorities and bibliographic records. To test: - Apply the patch - Build your own packages and install them on a test server a) Create a new instance without using the new switches like: $ koha-create --create-db domtest - Check there's a file /etc/koha/sites/domtest/zebra-biblios-dom.cfg - Check that /etc/koha/sites/domtest/koha-conf.xml points to: * zebra-biblios-dom.cfg (biblioserver section) * zebra-biblios-dom.cfg (publicserver section) * zebra-authorities-dom.cfg (authorityserver section) - Success means the new default is DOM b) Play with the 4 possible combination of option switches $ koha-create --create-db --auth-idx grs1 --biblio-idx grs1 domtest $ koha-create --create-db --auth-idx grs1 --biblio-idx dom domtest $ koha-create --create-db --auth-idx dom --biblio-idx grs1 domtest $ koha-create --create-db --auth-idx dom --biblio-idx dom domtest - Check the koha-conf.xml file reflects the chosen options. c) Run $ koha-create --help - It should advertise this addition accordingly. d) Run $ man koha-create - Man page for koha-create should provide good information on the new switches behaviour Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 21:36:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 19:36:20 +0000 Subject: [Koha-bugs] [Bug 10690] Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10690 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20131|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 20190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20190&action=edit Bug 10690 - Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL The descriptions for OPACBaseURL and staffClientBaseURL are not explicit about including a trailing slash or not. This patch makes it explicit that the trailing slash should *not* be included. To test: - Apply the patch - Search for "baseurl" in the system preferences - Check that the description of both sysprefs includes a warning about not including a trailing slash. - Sign off If you want to check that the trailing slash is in fact superfluous you can do something like 'grep -r "BaseURL" *' and check that these sysprefs are usually concatenated with some string that starts with a slash. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 21:37:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 19:37:53 +0000 Subject: [Koha-bugs] [Bug 10701] New: In transit information doesn't display on the bibliographic detail page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 Bug ID: 10701 Summary: In transit information doesn't display on the bibliographic detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org My patch for Bug 10083 may have made the in-transit strings translatable, but it messed up the template variable names so that the details don't show. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 21:38:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 19:38:22 +0000 Subject: [Koha-bugs] [Bug 10690] Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10690 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 21:38:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 19:38:42 +0000 Subject: [Koha-bugs] [Bug 10702] New: can't create notices for a specific branch Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10702 Bug ID: 10702 Summary: can't create notices for a specific branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org When creating a new notice if I choose my branch and then the module the branch changes back to 'all libraries'. I then change the branch back to mine and enter the code and text and have everything in place and hit save. When I save it doesn't save. The notice is lost. Right now you have to create the notice for 'all libraries' and then copy the notice to my library and then delete the 'all libraries copy'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 21:43:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 19:43:57 +0000 Subject: [Koha-bugs] [Bug 10701] In transit information doesn't display on the bibliographic detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 21:44:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 19:44:03 +0000 Subject: [Koha-bugs] [Bug 10701] In transit information doesn't display on the bibliographic detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 --- Comment #1 from Owen Leonard --- Created attachment 20191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20191&action=edit Bug 10701 - In transit information doesn't display on the bibliographic detail page The patch for Bug 10083 incorrectly changed some template variable names so that in-transit details could not be shown on the biblio detail page. This patch corrects the error. To test, perform any action that will trigger an transfer between libraries (for instance, check in an item from Library A at Library B). View the detail page for that title and look for the transfer details in the status column of the holdings table. It should show correct information: "In transit from Athens to Nelsonville since 08/08/2013" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 21:44:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 19:44:06 +0000 Subject: [Koha-bugs] [Bug 10686] Fielded searches confuse highlighter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20119|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 20192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20192&action=edit Bug 10686: Remove fields from searches for highlighting If you do a fielded search like au:smith, "Smith" will not get highlighted on the results page because the Javascript is looking for the exact string "au:smith." To test: 1) Turn on OpacHighlightedWords. 2) Do a simple keyword search. 3) Confirm that the word is highlighted on the results and details page. 4) Do a fielded search by entering au:smith (or whatever). 5) Confirm that the word is highlighted on the results and details page. 6) Sign off. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 21:45:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 19:45:10 +0000 Subject: [Koha-bugs] [Bug 10686] Fielded searches confuse highlighter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 21:51:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 19:51:50 +0000 Subject: [Koha-bugs] [Bug 6489] cancelling hold from holds awaiting pickup does not trigger transit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED --- Comment #12 from Owen Leonard --- This appears to have been fixed in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 21:52:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 19:52:21 +0000 Subject: [Koha-bugs] [Bug 6489] cancelling hold from holds awaiting pickup does not trigger transit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 21:52:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 19:52:23 +0000 Subject: [Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh dependency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20009|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 20193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20193&action=edit Bug 10665 - koha-index-daemon-ctl.sh dependency The daemon koha-index-daemon needs a connexion to MySQL server. This patch sets start dependance to "all" in order to wait for local MySQL server or not wait if using a remote MySQL server. Signed-off-by: Bernardo Gonzalez Kriegel Small fix, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 21:52:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 19:52:52 +0000 Subject: [Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh dependency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 22:05:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 20:05:57 +0000 Subject: [Koha-bugs] [Bug 5825] Add Item Type column to Holds Queue report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5825 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|kyle.m.hall at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 22:08:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 20:08:41 +0000 Subject: [Koha-bugs] [Bug 10701] In transit information doesn't display on the bibliographic detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20191|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 20194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20194&action=edit Bug 10701 - In transit information doesn't display on the bibliographic detail page The patch for Bug 10083 incorrectly changed some template variable names so that in-transit details could not be shown on the biblio detail page. This patch corrects the error. To test, perform any action that will trigger an transfer between libraries (for instance, check in an item from Library A at Library B). View the detail page for that title and look for the transfer details in the status column of the holdings table. It should show correct information: "In transit from Athens to Nelsonville since 08/08/2013" Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described, no errors. Before patch incorrect information: "In transit from to since" after patch correct information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 22:09:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 20:09:01 +0000 Subject: [Koha-bugs] [Bug 10701] In transit information doesn't display on the bibliographic detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 22:10:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 20:10:52 +0000 Subject: [Koha-bugs] [Bug 5825] Add Item Type column to Holds Queue report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5825 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 22:10:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 20:10:57 +0000 Subject: [Koha-bugs] [Bug 5825] Add Item Type column to Holds Queue report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5825 --- Comment #2 from Owen Leonard --- Created attachment 20195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20195&action=edit Bug 5825 - Add Item Type column to Holds Queue report The hold queue report shows collection code but not item type. This patch adds it. Also added is use of the KohaAuthorisedValues template plugin to display the collection code description instead of code. To test, apply the patch and view the holds queue. There should be a new item type column showing an item type description for each row. The collection column should now show the collection description instead of code. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 23:15:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 21:15:14 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- Hi Kyle, i am trying to figure out SIP right now and was hoping to use your script. But I am running into problems - with your follow up, it looks like this: patron admin --password admin main::help() called too early to check prototype at ./sip_cli_emulator.pl line 46. Use of uninitialized value $terminator in string eq at ./sip_cli_emulator.pl line 50. OUTBOUND: 9300CNsip|COsip|CPMPL| Use of uninitialized value $data in concatenation (.) or string at ./sip_cli_emulator.pl line 69. INBOUND: Use of uninitialized value $data in pattern match (m//) at ./sip_cli_emulator.pl line 71. Login Failed! Without, the warns are gone, but my login still fails? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 23:31:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 21:31:04 +0000 Subject: [Koha-bugs] [Bug 10600] Duplicate authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10600 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19716|0 |1 is obsolete| | CC| |nengard at gmail.com --- Comment #2 from Nicole C. Engard --- Created attachment 20196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20196&action=edit [SIGNED-OFF] Bug 10600: Duplicate an authority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 23:31:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 21:31:11 +0000 Subject: [Koha-bugs] [Bug 10600] Duplicate authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10600 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 23:49:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 21:49:24 +0000 Subject: [Koha-bugs] [Bug 10430] status filter not working in serial claims when translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 23:49:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 21:49:28 +0000 Subject: [Koha-bugs] [Bug 10430] status filter not working in serial claims when translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18748|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 20197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20197&action=edit Bug 10430 - status filter not working in serial claims when translated With a translated intranet (ie fr-FR) the status filter does not work for "Late" status. It is because status in combobox filter is translated "Retard" and status in table is translated "En retard". This patch changed javascript filter to work on a status code instead of status name. The new classes may be used to change CSS depending on status. Test plan : - Use a translated intranet (ie fr-FR) - Go to serials claim of a vendor with issues of multiple status - Check that status filter does its work Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 23:49:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 21:49:37 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #4 from Mirko Tietgen --- While --biblio-idx seems to be working, i can't see a difference for --auth-idx. koha-conf.xml always points to zebra-authority.cfg (the GRS1 file). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 8 23:50:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 21:50:26 +0000 Subject: [Koha-bugs] [Bug 10430] status filter not working in serial claims when translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #9 from Chris Cormack --- You do realise I am on the QA team right? However I have signed off, someone elses problem now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 00:35:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 22:35:23 +0000 Subject: [Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- I cant get this to apply, even after apply 10692 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 00:37:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 22:37:13 +0000 Subject: [Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in C4/Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 00:37:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 22:37:17 +0000 Subject: [Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in C4/Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20163|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 20198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20198&action=edit Bug 10699:DeleteBranchTransferLimits in C4/Circulation.pm needs return value This patch adds return values to DeleteBranchTransferLimits: 1 if a Transfer Limit is deleted undef if no parameters is given 0E0 if a wrong parameter is given More, it fixes and adds some tests in t/db_dependent/Circulation_transfers.t To test : prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=14, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 00:42:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 22:42:43 +0000 Subject: [Koha-bugs] [Bug 10688] QueryParser doesn't recognize QP queries when used in a fielded search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 00:42:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 22:42:46 +0000 Subject: [Koha-bugs] [Bug 10688] QueryParser doesn't recognize QP queries when used in a fielded search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20123|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 20199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20199&action=edit Bug 10688: Don't prefix index inappropriately If you select an index in the search dropdown and then enter in a QP query starting with the field, Koha will prepend the index you do not want to use at the beginning of the search, resulting in a search that problem does not match what you were hoping for. To test: 1) Select an index in the search dropdown in the OPAC. Author is fine. 2) Enter a search term using manually entered indexes. For example: ti:cat in the hat 3) Note that the search fails. 4) Apply patch. 5) Repeat steps 1 and 2. 6) Note that the search succeeds. 7) Sign off. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 01:01:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 23:01:45 +0000 Subject: [Koha-bugs] [Bug 10684] Koha search dies on undecodable records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 01:01:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 23:01:49 +0000 Subject: [Koha-bugs] [Bug 10684] Koha search dies on undecodable records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20109|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 20200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20200&action=edit Bug 10684 - Koha search dies on undecodable records When a record fails to decode during a search, Koha dies with an error. Koha should ignore bad records and continue on ( and log the error ). Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 01:13:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 23:13:35 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 01:13:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 23:13:39 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20162|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 20201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20201&action=edit Bug 10653: C4::RotatingCollections.pm needs unit tests The tests are wrap in a database transaction. Test plan: prove t/db_dependent/RotatingCollections.t t/db_dependent/RotatingCollections.t .. ok All tests successful. Files=1, Tests=41, 20 wallclock secs ( 0.02 usr 0.01 sys + 0.41 cusr 0.02 csys = 0.46 CPU) Result: PASS Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 01:15:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 23:15:28 +0000 Subject: [Koha-bugs] [Bug 10642] Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10642 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 01:15:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 23:15:31 +0000 Subject: [Koha-bugs] [Bug 10642] Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10642 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19946|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 20202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20202&action=edit Bug 10642 : Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 01:27:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 23:27:24 +0000 Subject: [Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 01:27:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 23:27:28 +0000 Subject: [Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19937|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 20203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20203&action=edit Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm This patch makes DelBookseller returns the number of supplier it has deleted or undef if nothing has been deleted. It also fixes a test which doesn't pass before in t/db_dependent/Bookseller.t To test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 1/54 All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.48 cusr 0.02 csys = 0.52 CPU) Result: PASS Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 01:43:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 23:43:41 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 01:43:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 23:43:45 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19867|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 20204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20204&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaAuthorisedValues.pm AuthorisedValues.pm Test Plan: 1) Apply this patch 2) View the pages that this patch has modified, make sure the branch name is still visible Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 01:43:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Aug 2013 23:43:56 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19870|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 20205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20205&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaBranchName.pm Branches.pm Test Plan: 1) Apply this patch 2) View a basket group, note the branch name is displayed 3) View a subscription's details, note the branch name is displayed 4) View suggestions, note the branch names are displayed 5) Return an item that needs transfered, note the branch name is displayed 6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t' Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 02:06:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 00:06:59 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19009|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 20206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20206&action=edit Bug 10298: Mock C4::Context->preference t::lib::Mocks::Context tried to deal with preferences but did not manage to. This patch removes this module and add 2 routines in t::lib::Mocks in order to mock C4::context->preference and C4::Context->config. To test: ===START t/test.pl=== use Modern::Perl; use t::lib::Mocks; use C4::Context; say "initial value for version: " . C4::Context->preference('Version'); say "initial value for language: " . C4::Context->preference('language'); t::lib::Mocks::mock_preference('Version', "new version for testing"); say "version is mocked with: " . C4::Context->preference('Version'); say "language is not yet mocked: " . C4::Context->preference('language'); t::lib::Mocks::mock_preference('language', 'new langage for testing'); t::lib::Mocks::mock_preference('Version', 'another version for testing'); say "version is mocked with another value: " . C4::Context->preference('Version'); say "language is finally mocked: " . C4::Context->preference('language'); ===END=== Try to execute this file and check that the output is consistent. Signed-off-by: Julian Maurice Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 02:07:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 00:07:17 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 02:07:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 00:07:21 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19010|0 |1 is obsolete| | --- Comment #11 from Chris Cormack --- Created attachment 20207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20207&action=edit Bug 10298: Adapt existing code set_solr and set_zebra is not really useful. It is preferable to use mock_preference directly. To test: 1/ Launch Solr 2/ prove -r t/searchengine/ It should produce: % prove -r t/searchengine/ t/searchengine/000_conn/conn.t ........... ok t/searchengine/001_search/search_base.t .. ok t/searchengine/002_index/index_base.t .... IndexRecord called with biblio 2 Indexing biblio 2 t/searchengine/002_index/index_base.t .... ok t/searchengine/003_query/buildquery.t .... ok t/searchengine/004_config/load_config.t .. ok All tests successful. Files=5, Tests=21, 4 wallclock secs ( 0.03 usr 0.01 sys + 2.74 cusr 0.20 csys = 2.98 CPU) Result: PASS Signed-off-by: Julian Maurice Signed-off-by: Chris Cormack Had to get Solr going again to test this, man .. they could make that easier -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 02:54:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 00:54:35 +0000 Subject: [Koha-bugs] [Bug 10703] New: add/update database documentation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 Bug ID: 10703 Summary: add/update database documentation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org a continuation of bug 6716 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 03:02:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 01:02:11 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 03:02:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 01:02:42 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 --- Comment #1 from Nicole C. Engard --- Created attachment 20208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20208&action=edit Bug 10703: Add db documentation for biblioimages table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 03:03:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 01:03:12 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 --- Comment #2 from Nicole C. Engard --- Created attachment 20209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20209&action=edit Bug 10703: Document quotes table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 03:10:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 01:10:29 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 --- Comment #3 from Nicole C. Engard --- Created attachment 20210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20210&action=edit Bug 10703: Document borrower_files table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 03:15:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 01:15:15 +0000 Subject: [Koha-bugs] [Bug 10028] ModReceiveOrder works unexpectedly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 03:15:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 01:15:19 +0000 Subject: [Koha-bugs] [Bug 10028] ModReceiveOrder works unexpectedly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17370|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 20211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20211&action=edit Bug 10028: ModReceiveOrder unexpectedly works. In C4::Acquisition::ModReceiveOrder, a call to NewOrder is badly used. NewOrder returns ($basketno, $ordernumber) but in ModReceiveOrder the ordernumber is got with my $ordernumber = NewOrder( $args ); It works because: sub t{ return ("a", "b"); } my $a = t(); say $a; Will display 'b'. But it is not really clear. Test plan: Check that there is no regression for partial receives. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 03:33:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 01:33:32 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20189|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 20212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20212&action=edit Bug 8507: koha-create should be updated to use DOM indexing for bib This patch makes the koha-create script install the file zebra-biblios-dom.cfg with the proper string substitutions inside on the new instance. It also adds two option switches that control the indexing mode for the instance: --biblio-idx {dom|grs1} --auth-idx {dom|grs1} DOM indexing is set as the default for both authorities and bibliographic records. To test: - Apply the patch - Build your own packages and install them on a test server a) Create a new instance without using the new switches like: $ koha-create --create-db domtest - Check there's a file /etc/koha/sites/domtest/zebra-biblios-dom.cfg - Check that /etc/koha/sites/domtest/koha-conf.xml points to: * zebra-biblios-dom.cfg (biblioserver section) * zebra-biblios-dom.cfg (publicserver section) * zebra-authorities-dom.cfg (authorityserver section) - Success means the new default is DOM b) Play with the 4 possible combination of option switches $ koha-create --create-db --auth-idx grs1 --biblio-idx grs1 domtest $ koha-create --create-db --auth-idx grs1 --biblio-idx dom domtest $ koha-create --create-db --auth-idx dom --biblio-idx grs1 domtest $ koha-create --create-db --auth-idx dom --biblio-idx dom domtest - Check the koha-conf.xml file reflects the chosen options. c) Run $ koha-create --help - It should advertise this addition accordingly. d) Run $ man koha-create - Man page for koha-create should provide good information on the new switches behaviour Regards To+ Edit: Fixed a small typo that prevented DOM indexing to be set for authorities. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 06:48:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 04:48:03 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 --- Comment #6 from Mirko Tietgen --- After the fix koha-create works for publicserver, authorityserver and biblioserver. I noticed that - there is still one unchanged instance of /var/lib/koha/domdom2/zebra-biblios.cfg in koha-conf.xml, in the "mergeserver" part at the beginning of the file - there is no reference to retrieval-info-bib-dom.xml in koha-conf.xml (cf. http://wiki.koha-community.org/wiki/Switching_to_dom_indexing ) Please let me know if it is supposed to be that way or update the patch and I'll try actual indexing and sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 09:54:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 07:54:09 +0000 Subject: [Koha-bugs] [Bug 10622] Add --sip and --nosip switches to koha-list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 09:54:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 07:54:14 +0000 Subject: [Koha-bugs] [Bug 10622] Add --sip and --nosip switches to koha-list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19852|0 |1 is obsolete| | --- Comment #4 from Magnus Enger --- Created attachment 20213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20213&action=edit Bug 10622: [SIGNED OFF] add --sip and --nosip switches to koha-list Just added those switches. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Magnus Enger I applied the patch on my local dev install, and then copied the patched koha-list script to a couple of servers with actual instances running off the packages, to test the script. - It seems that the -h switch did not work before this patch, now both -h and --help works nicely - --sip and --nosip work as expected, also in combination with --email and --noemail The patch does not add --sip and --nosip to the man page for koha-list, but I will do a followup for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 09:56:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 07:56:40 +0000 Subject: [Koha-bugs] [Bug 10430] status filter not working in serial claims when translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #10 from Fridolyn SOMERS --- (In reply to Chris Cormack from comment #9) > You do realise I am on the QA team right? Yes sorry, of course I know it, I surly had an amnesia moment. In fact I do not understand how it could use an id. Could you give a piece of code ? Looking at Bug 10429 it appears there are several bugs on those filters. They all could be solved by using a JQuery Datatable for claims table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 10:01:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 08:01:54 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 --- Comment #24 from Fridolyn SOMERS --- (In reply to Katrin Fischer from comment #23) Hie Katrin, Ok, I understand. In this cas the code C4::Koha::GetSupportList() and C4::Koha::GetSupportName() must be moved into C4::Suggestion and renamed. It is this code who speaks about a "support" definition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 10:11:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 08:11:46 +0000 Subject: [Koha-bugs] [Bug 10622] Add --sip and --nosip switches to koha-list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 --- Comment #5 from Magnus Enger --- Created attachment 20214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20214&action=edit Bug 10622 - Followup: Add --sip, --nosip and --help to man page The original patch for bug 10622 added the --sip, --nosip and --help switches to the koha-list command, but did not update the manpage for the command. This patch does. To test: Run these commands and look at the formatted man page: $ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-list.xml $ man -l koha-list.8 Make sure this test passes: $ prove -v xt/verify-debian-docbook.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 10:53:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 08:53:14 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #29 from Magnus Enger --- (In reply to M. de Rooy from comment #28) > What I did mean, was: If we let the user just once insert http or https for > his server, and we do not prefix it anymore, we have a solution.. But isn't it possible to have the same domain available both with and without HTTPS? So both of these can work at the same time: http://koha.example.org/ https://koha.example.org/ Then it would seem to be a bad idea to "hard code" the protocol in a syspref, and better to figure it out on a per request basis, perhaps? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 11:49:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 09:49:49 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Medium patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 11:49:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 09:49:52 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20177|0 |1 is obsolete| | --- Comment #6 from Magnus Enger --- Created attachment 20215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20215&action=edit Bug 10404 [CSS follow-up] [SIGNED-OFF] Add previous/next browsing to staff client search results This patch slightly modifies the styles of the previous/next links in a way that I think is simpler and clearer. To test, apply the patch and clear your browser cache if necessary. Perform a search in the staff client, click any result, and look at the prevous/next links. If you think this is an improvement, sign off! Signed-off-by: Magnus Enger Looks like an improvement to me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 12:50:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 10:50:20 +0000 Subject: [Koha-bugs] [Bug 9231] Batch revert staged MARC records fails if one or more records in a batch have been deleted. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9231 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #10 from Magnus Enger --- (In reply to Kyle M Hall from comment #9) > To keep the failure from causing the script to die, we just need > to eval it. Then, even if it fails, the batch revert will keep > going. It looks like earlier versions of this patch used eval, but the latest one does not. Maybe update the commit message, if it isn't too much trouble? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 13:04:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 11:04:23 +0000 Subject: [Koha-bugs] [Bug 10704] New: Search term highlighting doesn't work beyond the first results page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Bug ID: 10704 Summary: Search term highlighting doesn't work beyond the first results page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Reporting this bug on behalf of a customer. When 'OpacHighlightedWords' is set to 'Highlight' in the system preferences only the first page of search results appear to be highlighted. Any following results pages do not obey this preference. To test; 1. Enable the above preference 2. Run a search that is known to get at least two pages wroth of results in the OPAC 3. Verify that on page one of the results, the terms you searched for are all highlighted in the results. 4. Verify that on page two (and beyond), the terms you searched for are not highlighted in the results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 13:06:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 11:06:14 +0000 Subject: [Koha-bugs] [Bug 10704] Search term highlighting doesn't work beyond the first results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6149 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 13:06:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 11:06:14 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10704 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 13:14:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 11:14:44 +0000 Subject: [Koha-bugs] [Bug 10704] Search term highlighting doesn't work beyond the first results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Jonathan Field changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com --- Comment #1 from Jonathan Field --- To be clear, it is the paging with the "Next" / "Previous" buttons which are affected. So :- Enable 'OpacHighlightedWords' 1) Run a search with multiple results 2) Click on a title to get the full record display. Hit highlighting SHOULD work on this page. 3) Use either the "Next" or "Previous" buttons on this page (opac-detail). 4) Moving forward or back, the highlighting disappears. Moving from results to the first full record the URL contains the query_desc param from the session data. This is dropped as you navigate back and forth, leaving only the biblionumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 13:16:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 11:16:55 +0000 Subject: [Koha-bugs] [Bug 7844] plack scripts for developers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7844 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |magnus at enger.priv.no --- Comment #20 from Magnus Enger --- Dobrica: Would you be OK with having this outside Koha, e.g. in contrib/global.git? Setting to "in discussion". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 13:23:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 11:23:16 +0000 Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than "any" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no Depends on| |9830, 9352, 9828 --- Comment #14 from Magnus Enger --- Adding some bugs to "Depends on", based on earlier comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 13:23:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 11:23:16 +0000 Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC 7XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8962 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 13:23:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 11:23:16 +0000 Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8962 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 13:23:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 11:23:16 +0000 Subject: [Koha-bugs] [Bug 9830] Some UNIMARC item indexes could be broken whith Queryweightfields syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9830 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8962 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 13:24:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 11:24:16 +0000 Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than "any" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #15 from Magnus Enger --- Setting status t o(In reply to mathieu saby from comment #13) > you can test it, but please do not sign this patch before other patches > regarding Unimarc Zebra are pushed : 9830, 9352, 9828 (there will be a lot > of conflicts, and the logic of these patchs are diffrent from this one). Setting the status to BLOCKED since thos bugs are still "needs signoff". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 13:43:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 11:43:49 +0000 Subject: [Koha-bugs] [Bug 10704] Search term highlighting doesn't work beyond the first results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 --- Comment #2 from Jonathan Field --- Created attachment 20216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20216&action=edit fix for search term highlighting on record navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 13:46:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 11:46:28 +0000 Subject: [Koha-bugs] [Bug 10704] Search term highlighting doesn't work beyond the first results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Jonathan Field changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Jonathan Field --- To test Enable 'OpacHighlightedWords' 1) Run a search with multiple results 2) Click on a title of one of the results to get the full record display. Hit highlighting SHOULD work on this page. 3) Use either the "Next" or "Previous" buttons on this page (opac-detail) to move to the next or previous record. 4) Moving forward or back, the highlighting should still be working on the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 13:58:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 11:58:58 +0000 Subject: [Koha-bugs] [Bug 10043] Clear notforloan on receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10043 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8307 --- Comment #4 from Magnus Enger --- "Bug 8307 - Set a value for items when receiving" is now "Passed QA". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 13:58:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 11:58:58 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10043 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 14:25:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 12:25:16 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 14:25:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 12:25:20 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 --- Comment #56 from Kyle M Hall --- Created attachment 20217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20217&action=edit Bug 7720 - Ambiguity in OPAC Details location - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 14:31:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 12:31:41 +0000 Subject: [Koha-bugs] [Bug 10704] Search term highlighting doesn't work beyond the first results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 14:31:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 12:31:44 +0000 Subject: [Koha-bugs] [Bug 10704] Search term highlighting doesn't work beyond the first results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20216|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 20218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20218&action=edit Hit highlighting not working on Previous & Next buttons http://bugs.koha-community.org/show_bug.cgi?id=10704 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 14:34:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 12:34:43 +0000 Subject: [Koha-bugs] [Bug 9231] Batch revert staged MARC records fails if one or more records in a batch have been deleted. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9231 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19350|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 20219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20219&action=edit Bug 9231 - Batch revert staged MARC records fails if one or more records in a batch have been deleted. If a record in an imported batch is deleted, any attempt to revert the batch will result in the progress bar never reaching 100%. The background job dies when it hits the already deleted record, with the error occurring in C4::Items::DelItem for the line: $copy2deleted->execute( $record->as_usmarc(), $itemnumber ); which fails because $record is undefined. To keep the failure from causing the script to die, we just need to check the record to see if it loaded before working on it. Test Plan: 1) Stage a batch of marc records 2) Import those records 3) Delete one of those records 4) Attempt to revert the batch, it will hang. 5) Apply this patch 6) Repeat steps 1-4, the revert should succeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 14:39:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 12:39:15 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #17 from Kyle M Hall --- Katrin, it looks like the full set of parameters you passed to the script didn't get pasted in correctly. Can you please repost your parameters? Kyle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 14:42:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 12:42:18 +0000 Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 14:42:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 12:42:22 +0000 Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421 --- Comment #4 from Magnus Enger --- Created attachment 20220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20220&action=edit Bug 10421 - [SIGNED-OFF] Add cron script to delete deleted records This script will batch delete all records where the leader's record status ( position 5 ) is set to 'd' ( Deleted ). Test Plan: 1) Edit a few records, set the leader 05 to 'd' for deleted 2) Run delete_deleted_records.pl 3) Records that are deletable should be deleted! Signed-off-by: Magnus Enger I can confirm that NORMARC uses leader position 5 in the same way as MARC21, and as far as I can see from this document, UNIMARC does too: http://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf -h and --help as well as running the script without arguments give a nice "help" message -c and --confirm makes the script do its job Records with leader position 5 = d are deleted. If there are items attached to the record, an error is reported: Deleting biblionumber 562 ... ERROR: ( | This Biblio has items attached, please delete them first before deleting this biblio ) Looks good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 14:42:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 12:42:39 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #18 from Katrin Fischer --- Ah, I see. I used the same paraemters with and without the follow up - one time with errors, the other now. I had all parameters in the sequence suggested and always the long form -- as the short form seemed to give me some trouble. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 14:42:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 12:42:48 +0000 Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18678|0 |1 is obsolete| | CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 14:55:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 12:55:03 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #20 from Magnus Enger --- (In reply to Katrin Fischer from comment #19) > Hi Janusz, just seeing your comment - I have added Magnus to the cc list, he > will know :) NORMARC does not support authorities at all at the moment. But thanks for thinking about us! :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 14:57:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 12:57:40 +0000 Subject: [Koha-bugs] [Bug 10622] Add --sip and --nosip switches to koha-list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 14:57:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 12:57:47 +0000 Subject: [Koha-bugs] [Bug 10622] Add --sip and --nosip switches to koha-list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20214|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 20221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20221&action=edit Bug 10622 - [SIGNED OFF] Followup: Add --sip, --nosip and --help to man page The original patch for bug 10622 added the --sip, --nosip and --help switches to the koha-list command, but did not update the manpage for the command. This patch does. To test: Run these commands and look at the formatted man page: $ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-list.xml $ man -l koha-list.8 Make sure this test passes: $ prove -v xt/verify-debian-docbook.t Signed-off-by: Tomas Cohen Arazi Forgot the docs this time, good catch Magnus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 14:59:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 12:59:10 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19700|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 20222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20222&action=edit Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved Signed-off-by: Srdjan Signed-off-by: Kyle M Hall Passes koha-qa, works as advertised -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 15:02:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 13:02:28 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 15:02:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 13:02:32 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19701|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 20223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20223&action=edit Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved [3.12.x] Signed-off-by: Srdjan Signed-off-by: Kyle M Hall Passes all valid koha-qa test ( fails for IndependantBranches test ). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 15:05:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 13:05:48 +0000 Subject: [Koha-bugs] [Bug 10393] To add some shortcuts to acquisitions main screen e.g. RECEIVE SHIPMENT and the FILTER BOX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10393 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 15:05:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 13:05:52 +0000 Subject: [Koha-bugs] [Bug 10393] To add some shortcuts to acquisitions main screen e.g. RECEIVE SHIPMENT and the FILTER BOX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10393 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19956|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 20224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20224&action=edit Bug 10393 - Receive shipment link in acquisitions main page To add some shortcuts to acquisitions main screen e.g. RECEIVE SHIPMENT and the FILTER BOX Test plan: 1) Click on Receive shipment link on the left hand side. 2) It will give all the vendor list click on recieve shipment link to receive items. 3) For creating new basket click on "New Basket" link. Sponsored-by: Staffordshire University/Halton Borough Council/PTFS Europe Signed-off-by: Srdjan Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 15:17:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 13:17:51 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20176|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 20225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20225&action=edit Bug 10404: add previous/next browsing to staff client Although previous/next browsing was added for searches in the OPAC in 2011, the staff client has been without any sort of search browsing. Until now. This patch is an all-singing, all-dancing, all-compatible implementation of search browsing that will work across multiple browser tabs and on any browser since IE7 (though the staff client layout is broken on IE7). To test: 1) Perform a search that will bring up multiple results. 2) View one of the results. 3) Use the Previous and Next links to browse along the search results. 4) Use the "Return to results" button to check that you end up at the correct page of results, even if you page through more than 20 records. 5) Sign off. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 15:18:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 13:18:14 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 15:18:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 13:18:17 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20225|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 20226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20226&action=edit Bug 10404 [CSS follow-up] Add previous/next browsing to staff client search results This patch slightly modifies the styles of the previous/next links in a way that I think is simpler and clearer. To test, apply the patch and clear your browser cache if necessary. Perform a search in the staff client, click any result, and look at the prevous/next links. If you think this is an improvement, sign off! Signed-off-by: Magnus Enger Looks like an improvement to me! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 15:25:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 13:25:23 +0000 Subject: [Koha-bugs] [Bug 10305] Duplicate code in Search.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 15:25:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 13:25:26 +0000 Subject: [Koha-bugs] [Bug 10305] Duplicate code in Search.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18281|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20227&action=edit Bug 10305 - _increment_barcode is called twice For some reason, _increment_barcode is called twice in succession in cataloguing/additem.pl Test Plan: 1) Enable autobarcode = incremental 2) Catalog an item, not the barcode 3) Apply this patch 4) Catalog another item, the barcode should be the next in line as previously. No change should be noted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 15:25:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 13:25:48 +0000 Subject: [Koha-bugs] [Bug 10305] _increment_barcode is called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Summary|Duplicate code in Search.pm |_increment_barcode is | |called twice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 16:23:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 14:23:59 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 16:24:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 14:24:02 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18374|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 20228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20228&action=edit Bug 10325 - Allow system preferences to be overridable from koha-httpd.conf For Koha installations with multiple OPAC URLs, It would be nice to be able to override systeprefs from the http conf file. Case in point, a library wants to have two separate opacs, one the is only viewable from within the library that allows patrons to place holds, and a second public one that does not. In this case, overriding the system preference RequestOnOpac would accomplish this simply, and with no ill affects. This feature would of course be should only be used to override cosmetic effects on the system, and should not be used for system preferences such as CircControl, but would be great for preferences such as OpacStarRatings, opacuserjs, OpacHighlightedWords and many others! Test Plan: 1) Apply this patch 2) Disable the system pref OpacHighlightedWords 3) Do a seach in the OPAC, not the term is not highlighted 4) Edit your koha-http.conf file, add the line SetEnv OVERRIDE_SYSPREF_OpacHighlightedWords "1" to your koha-http.conf file's OPAC section. Also add the line SetEnv OVERRIDE_SYSPREF_NAMES "OpacHighlightedWords" to the Intranet section 5) Restart your web server, or just reload it's config 6) Do a seach, now your search term should be highlighted! 7) From the intranet preference editor, view the pref, You should see a warning the this preference has been overridden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 16:26:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 14:26:57 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20228|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Created attachment 20229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20229&action=edit Bug 10325 - Allow system preferences to be overridable from koha-httpd.conf For Koha installations with multiple OPAC URLs, It would be nice to be able to override systeprefs from the http conf file. Case in point, a library wants to have two separate opacs, one the is only viewable from within the library that allows patrons to place holds, and a second public one that does not. In this case, overriding the system preference RequestOnOpac would accomplish this simply, and with no ill affects. This feature would of course be should only be used to override cosmetic effects on the system, and should not be used for system preferences such as CircControl, but would be great for preferences such as OpacStarRatings, opacuserjs, OpacHighlightedWords and many others! Test Plan: 1) Apply this patch 2) Disable the system pref OpacHighlightedWords 3) Do a seach in the OPAC, not the term is not highlighted 4) Edit your koha-http.conf file, add the line SetEnv OVERRIDE_SYSPREF_OpacHighlightedWords "1" to your koha-http.conf file's OPAC section. Also add the line SetEnv OVERRIDE_SYSPREF_NAMES "OpacHighlightedWords" to the Intranet section 5) Restart your web server, or just reload it's config 6) Do a seach, now your search term should be highlighted! 7) From the intranet preference editor, view the pref, You should see a warning the this preference has been overridden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 16:28:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 14:28:03 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20229|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 20230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20230&action=edit Bug 10325 - Allow system preferences to be overridable from koha-httpd.conf For Koha installations with multiple OPAC URLs, It would be nice to be able to override systeprefs from the http conf file. Case in point, a library wants to have two separate opacs, one the is only viewable from within the library that allows patrons to place holds, and a second public one that does not. In this case, overriding the system preference RequestOnOpac would accomplish this simply, and with no ill affects. This feature would of course be should only be used to override cosmetic effects on the system, and should not be used for system preferences such as CircControl, but would be great for preferences such as OpacStarRatings, opacuserjs, OpacHighlightedWords and many others! Test Plan: 1) Apply this patch 2) Disable the system pref OpacHighlightedWords 3) Do a seach in the OPAC, not the term is not highlighted 4) Edit your koha-http.conf file, add the line SetEnv OVERRIDE_SYSPREF_OpacHighlightedWords "1" to your koha-http.conf file's OPAC section. Also add the line SetEnv OVERRIDE_SYSPREF_NAMES "OpacHighlightedWords" to the Intranet section 5) Restart your web server, or just reload it's config 6) Do a seach, now your search term should be highlighted! 7) From the intranet preference editor, view the pref, You should see a warning the this preference has been overridden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 16:30:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 14:30:39 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 16:30:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 14:30:43 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 --- Comment #6 from Kyle M Hall --- Created attachment 20231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20231&action=edit Bug 10314 - CanItemBeReserved does not respect the holds policies - Followup - QA Bugfix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 16:40:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 14:40:39 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19011|0 |1 is obsolete| | Attachment #20206|0 |1 is obsolete| | Attachment #20207|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 20232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20232&action=edit Bug 10298: Followup: Adapt existing code This unit tests file does not need the t::lib::Mocks::Context module. To test: prove t/db_dependent/Circulation_issuingrules.t Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall Passes koha-qa.pl, test checks out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 16:40:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 14:40:49 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 --- Comment #13 from Kyle M Hall --- Created attachment 20233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20233&action=edit Bug 10298: Mock C4::Context->preference t::lib::Mocks::Context tried to deal with preferences but did not manage to. This patch removes this module and add 2 routines in t::lib::Mocks in order to mock C4::context->preference and C4::Context->config. To test: ===START t/test.pl=== use Modern::Perl; use t::lib::Mocks; use C4::Context; say "initial value for version: " . C4::Context->preference('Version'); say "initial value for language: " . C4::Context->preference('language'); t::lib::Mocks::mock_preference('Version', "new version for testing"); say "version is mocked with: " . C4::Context->preference('Version'); say "language is not yet mocked: " . C4::Context->preference('language'); t::lib::Mocks::mock_preference('language', 'new langage for testing'); t::lib::Mocks::mock_preference('Version', 'another version for testing'); say "version is mocked with another value: " . C4::Context->preference('Version'); say "language is finally mocked: " . C4::Context->preference('language'); ===END=== Try to execute this file and check that the output is consistent. Signed-off-by: Julian Maurice Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 16:41:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 14:41:00 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 16:41:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 14:41:06 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 --- Comment #14 from Kyle M Hall --- Created attachment 20234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20234&action=edit Bug 10298: Adapt existing code set_solr and set_zebra is not really useful. It is preferable to use mock_preference directly. To test: 1/ Launch Solr 2/ prove -r t/searchengine/ It should produce: % prove -r t/searchengine/ t/searchengine/000_conn/conn.t ........... ok t/searchengine/001_search/search_base.t .. ok t/searchengine/002_index/index_base.t .... IndexRecord called with biblio 2 Indexing biblio 2 t/searchengine/002_index/index_base.t .... ok t/searchengine/003_query/buildquery.t .... ok t/searchengine/004_config/load_config.t .. ok All tests successful. Files=5, Tests=21, 4 wallclock secs ( 0.03 usr 0.01 sys + 2.74 cusr 0.20 csys = 2.98 CPU) Result: PASS Signed-off-by: Julian Maurice Signed-off-by: Chris Cormack Had to get Solr going again to test this, man .. they could make that easier Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:06:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:06:31 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20215|0 |1 is obsolete| | --- Comment #9 from Galen Charlton --- Comment on attachment 20215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20215 Bug 10404 [CSS follow-up] [SIGNED-OFF] Add previous/next browsing to staff client search results Looks like wrong patch was marked obsolete during the final QA round, fixing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:06:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:06:49 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20225|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:13:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:13:47 +0000 Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:13:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:13:51 +0000 Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19875|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20235&action=edit Bug 10533: basketgroup js functions should in a separated js file This patch moves js functions used for managing basketgroup into a separated js file. Test plan: - Try all actions for basketgroup ( drag/drop, add, delete, close, print, reopen, edit, export as csv). - Check that there is no regression on others acquisition pages: * acqui/neworderempty.tt * acqui/uncertainprice.tt * acqui/addorderiso2709.tt * acqui/basketheader.tt * admin/aqbudgets.tt * admin/aqcontract.tt * admin/aqbudgetperiods.tt * admin/aqplan.tt * suggestion/suggestion.tt Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:17:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:17:33 +0000 Subject: [Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:17:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:17:38 +0000 Subject: [Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20120|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 20236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20236&action=edit Bug 10643: Inappropriate uses of $sth->finish() in C4::ClassSource.pm This patch gets rid of finish() and replace prepare_cached by prepare. >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:19:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:19:36 +0000 Subject: [Koha-bugs] [Bug 10629] Inappropriate uses of $sth->finish() in C4::Branch.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:19:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:19:39 +0000 Subject: [Koha-bugs] [Bug 10629] Inappropriate uses of $sth->finish() in C4::Branch.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19910|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 20237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20237&action=edit Bug 10629 : Inappropriate uses of $sth->finish() in C4::Branch.pm Test plan : Check if the regression tests still works prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207. t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=36, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.12 cusr 0.00 csys = 0.16 CPU) Result: PASS Signed-off-by: Chris Cormack >From the man page finsh() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:19:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:19:58 +0000 Subject: [Koha-bugs] [Bug 7478] Template/translation problem in catalogue_out.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:20:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:20:02 +0000 Subject: [Koha-bugs] [Bug 7478] Template/translation problem in catalogue_out.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 --- Comment #1 from Owen Leonard --- Created attachment 20238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20238&action=edit Bug 7478 - Template/translation problem in catalogue_out.tt The items with no checkouts template has a sections that uses DEFAULT to set some strings: [% DEFAULT loopro.itemcallnumber="No Call Number" %] This appears to be untranslatable with our current translation tool. This patch changes the template so that it uses a simple [% IF %] block to display the default text if no value is set. Added is use of the Branches template plugin to show library name instead of code. This patch also fixes an error introduced in my fix for Bug 8124 causing the page to default to CSV download instead of output to screen. To test, apply the patch and confirm that the default text appears onscreen in reports which include results that have a missing barcode, title, or call number. Results should be displayed on screen correctly. Run "perl translate update" for any language and confirm that the newly generated po file includes "No call number," "No barcode," and "NO TITLE" for catalogue_out.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:28:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:28:15 +0000 Subject: [Koha-bugs] [Bug 9590] serial notes wrong on search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9590 --- Comment #1 from Owen Leonard --- I find that subscription search results show both the notes from the MARC record and the non-public note added to the subscription (but not the public note). Does this sound correct? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:28:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:28:55 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Jared! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:34:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:34:50 +0000 Subject: [Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Kenza! I notice, however, that the author line is wrong: root Please use git config to set its user.name and user.email attributes to your correct name and email address. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:44:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:44:34 +0000 Subject: [Koha-bugs] [Bug 10587] HTML errors on authority detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:44:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:44:38 +0000 Subject: [Koha-bugs] [Bug 10587] HTML errors on authority detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 --- Comment #1 from Owen Leonard --- Created attachment 20239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20239&action=edit Bug 10587 - HTML errors on authority detail page in OPAC A validator check of the OPAC's authority detail returns a few minor errors. This patch corrects the errors. To test, apply the patch and run an OPAC authority detail page through an HTML validator. There should be no errors which are specific to the authorities detail template (as opposed to header and footer includes). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:49:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:49:46 +0000 Subject: [Koha-bugs] [Bug 9888] Holds to pull report shows no results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9888 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard --- With no more information forthcoming I'm going to assume this was a local intallation/configuration issue. I can't reproduce the problem either. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:51:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:51:42 +0000 Subject: [Koha-bugs] [Bug 6435] False "no items" in search results [intranet] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 17:58:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 15:58:38 +0000 Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Comparing the acq.js with the new basketgroup.js reveals a bunch of diffs like this: - var answer = confirm(MSG_CONFIRM_CLOSE_BASKETGROUP); + var answer=confirm(_("Are you sure you want to close this basketgroup?")); - alert(MSG_CLOSE_EMPTY_BASKET); + alert(_("Why close an empty basket?")); - cantprint.innerHTML = MSG_SAVE_BEFORE_PRINTING; + cantprint.innerHTML=_("You need to save the page before printing"); In other words, this patch effectively causes a partial regression on bug 7598. Please try again; it may be better to start from scratch rather than to edit the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 18:01:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 16:01:03 +0000 Subject: [Koha-bugs] [Bug 6933] Add a view of titles with a particular tag to the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6933 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212 at gmail.com --- Comment #12 from Owen Leonard --- *** Bug 8118 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 18:01:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 16:01:03 +0000 Subject: [Koha-bugs] [Bug 8118] Dont know tag for approval related to which book In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8118 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 6933 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 18:09:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 16:09:19 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Created attachment 20240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20240&action=edit Patch to add syspref controlled stopwords to highlighting. This is an initial patch to implement some additional control upon the search result term highlighting features. It add a stopwords system preference where a pipe delimited list of words can be added which will prevent these words from being highlighted in search results. To Test 1. Enable OpacHighlightWords in the staff client 2. Run a search where results will be obtained 3. Note that all serach terms (including operators like 'and') are highlighted 4. Click through to the detailed display for one of the results 5. Note that all search terms are highlighted. 6. Apply patch 7. Add some 'stopwords' to new OpacHighlightStopWords system preference. 8. Run another search that includes some of the words you've just added to stopwords 9. Note that the stopwords are no longer highlighted, all other search terms should still appear highlighted. 10. Click through to the detailed display for a record 11. Note that the stopwrods are no longer highlighted, all other search terms should still be highlighted. Note for QA.. I'm sure there's a follow-up required for this patch with the correct DB additions for adding a syspref, but I'm reminding myself on the etiquette for that before submitting the follow-up. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 18:24:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 16:24:00 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|INSTALL.ubuntu needs |INSTALL.ubuntu needs to be |updating |updated Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 18:39:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 16:39:03 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #15 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 18:44:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 16:44:08 +0000 Subject: [Koha-bugs] [Bug 10608] Add accessioning date information to catalogue report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10608 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 7683 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 18:44:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 16:44:08 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vanoudt at gmail.com --- Comment #23 from Owen Leonard --- *** Bug 10608 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 19:04:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 17:04:53 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16327|0 |1 is obsolete| | --- Comment #24 from Owen Leonard --- Created attachment 20241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20241&action=edit Bug 7683: Cataloguing statistics wizard improvements - Add 3 options for cells value - Titles count "COUNT (biblionumber)" - Items count "COUNT (itemnumber)" (current behavior) - Deleted items count "COUNT (deleteditems.itemnumber)" - Add to selectable rows, colums and filters: - items.notforloan - items.materials - items.statisticvalue For each of these fields, retrieve the label in the default cataloging framework. If no MARC field is mapped to the field in question, it does not show this line in the wizard. If the MARC field is associated with a list of authorized values, it displays a dropdown list for the filter, otherwise it displays a text field. - Add to selectable rows, columns and filters: - items.dateaccessioned (creation date) - deleteditems.timestamp (deletion date) (Only if the third option (eg count deleted items) is selected) Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 19:05:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 17:05:05 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16328|0 |1 is obsolete| | --- Comment #25 from Owen Leonard --- Created attachment 20242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20242&action=edit Bug 7683 fix POD doc Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 19:05:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 17:05:12 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16329|0 |1 is obsolete| | --- Comment #26 from Owen Leonard --- Created attachment 20243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20243&action=edit Bug 7683: Fix plack compatibility Signed-off-by: Paul Poulain Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 19:05:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 17:05:19 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16367|0 |1 is obsolete| | --- Comment #27 from Owen Leonard --- Created attachment 20244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20244&action=edit Bug 7683: Add unit tests for GetMarcSubfieldStructureFromKohaField Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 19:05:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 17:05:27 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16775|0 |1 is obsolete| | --- Comment #28 from Owen Leonard --- Created attachment 20245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20245&action=edit Bug 7683 [Follow-up] Avoid printing useless '=1' This was caused by 'like/not like' select which had no description in catalogue_stats.pl Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 19:05:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 17:05:59 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 19:44:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 17:44:07 +0000 Subject: [Koha-bugs] [Bug 9943] Pay fines page "Pay selected" button give invalid amount when nothing is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9943 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|3.10 |master Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 19:47:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 17:47:52 +0000 Subject: [Koha-bugs] [Bug 9943] Pay fines page "Pay selected" button give invalid amount when nothing is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9943 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 19:47:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 17:47:56 +0000 Subject: [Koha-bugs] [Bug 9943] Pay fines page "Pay selected" button give invalid amount when nothing is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9943 --- Comment #3 from Owen Leonard --- Created attachment 20246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20246&action=edit Bug 9943 - Pay fines page "Pay selected" button give invalid amount when nothing is selected If you select no fines but click the "pay selected" button the resulting screen offers to let you pay against all fines, which is confusing. To simplify things this patch disables the "pay selected" button if no lines are selected. To test, apply the patch and find a patron with outstanding fines. From the "pay fines" page (members/pay.pl) try selecting and deselecting checkboxes and using the "select all" and "clear all" links. When no item is selected the "Pay selected" button should become disabled. Confirm that the form submits correctly when one or more fines is selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 19:50:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 17:50:55 +0000 Subject: [Koha-bugs] [Bug 3470] Track changes to borrower record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3470 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All Version|rel_3_0 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 20:02:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 18:02:41 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Galen Charlton --- I've pushed this to master, along with a regression test. Thanks, Julian! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 20:24:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 18:24:16 +0000 Subject: [Koha-bugs] [Bug 10614] have add order form at top and bottom In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10614 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 20:52:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 18:52:00 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20212|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 20247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20247&action=edit Bug 8507: koha-create should be updated to use DOM indexing for bib This patch makes the koha-create script install the file zebra-biblios-dom.cfg with the proper string substitutions inside on the new instance koha-conf.xml file. It also adds two option switches that control the indexing mode for the instance: --biblio-idx {dom|grs1} --auth-idx {dom|grs1} DOM indexing is set as the default for both authorities and bibliographic records. Following drojf (thanks!) advise I arranged stuff like explained here: http://wiki.koha-community.org/wiki/Switching_to_dom_indexing To test: - Apply the patch - Build your own packages and install them on a test server a) Create a new instance without using the new switches like: $ koha-create --create-db domtest - Check there's a file /etc/koha/sites/domtest/zebra-biblios-dom.cfg - Check that /etc/koha/sites/domtest/koha-conf.xml points to: * zebra-biblios-dom.cfg (biblioserver section) * zebra-biblios-dom.cfg (publicserver section) * zebra-authorities-dom.cfg (authorityserver section) - Success means the new default is DOM b) Play with the 4 possible combination of option switches $ koha-create --create-db --auth-idx grs1 --biblio-idx grs1 domtest $ koha-create --create-db --auth-idx grs1 --biblio-idx dom domtest $ koha-create --create-db --auth-idx dom --biblio-idx grs1 domtest $ koha-create --create-db --auth-idx dom --biblio-idx dom domtest - Check the koha-conf.xml file reflects the chosen options. c) Run $ koha-create --help - It should advertise this addition accordingly. d) Run $ man koha-create - Man page for koha-create should provide good information on the new switches behaviour Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 20:58:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 18:58:52 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 --- Comment #10 from Galen Charlton --- I've pushed a follow-up to remove a Perl 5.14ism that had crept in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 22:03:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 20:03:48 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #10 from Katrin Fischer --- Hi Jesse, any news on this? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 23:07:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 21:07:12 +0000 Subject: [Koha-bugs] [Bug 10393] To add some shortcuts to acquisitions main screen e.g. RECEIVE SHIPMENT and the FILTER BOX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10393 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- (In reply to Katrin Fischer from comment #2) > Hi Amit, I am not sure how this link is a shortcut to the current behaviour? > Searching for the vendor for example by sending an empty search and then > clicking the receive shipment link there? To me it seems to just reverse the > order of things. I agree with Katrin -- simply adding a link to /cgi-bin/koha/acqui/booksellers.pl (though I'm not sure about calling the link 'Receive shipments', as you can also open baskets) would also produce a list of vendors without requiring additional code. Could you or the sponsoring organization expand a bit on the motivation for this work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 23:36:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 21:36:45 +0000 Subject: [Koha-bugs] [Bug 9231] Batch revert staged MARC records fails if one or more records in a batch have been deleted. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9231 --- Comment #12 from Galen Charlton --- Comment on attachment 20219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20219 Bug 9231 - Batch revert staged MARC records fails if one or more records in a batch have been deleted. Review of attachment 20219: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9231&attachment=20219) ----------------------------------------------------------------- Marking failed QA because of the infinite loop condition that this patch introduces. Also, I will not push any patch for this bug that does not include a regression test in the DB-dependent test suite. ::: C4/Items.pm @@ +611,5 @@ > + > + # FIXME: Why pass $dbh in? We can get it from C4::Context > + # FIXME: Why pass $biblionumber in? It would be safer to get it via the itemnumber > + > + return unless ( DelItemCheck( $dbh, $biblionumber, $itemnumber ) eq '1' ); DelItemCheck calls DelItem, so adding a call to DelItemCheck here creates an infinite loop -- which I've verified actually happens. Since DelItemCheck is meant as the entry point (although that is problematic since DelItemCheck currently checks userenv), and DelItem is the internal routine, I think a better implementation would be for DelItemCheck to check the results of its call to GetItem and return if the item doesn't exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 23:36:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 21:36:52 +0000 Subject: [Koha-bugs] [Bug 9231] Batch revert staged MARC records fails if one or more records in a batch have been deleted. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9231 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 23:42:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 21:42:05 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20208|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 20248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20248&action=edit [SIGNED-OFF] Bug 10703: Add db documentation for biblioimages table This patch adds db documentation to the biblioimages table. To test: Apply patch Review kohastructure.sql to be sure that the documentation is there Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 23:42:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 21:42:14 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20209|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 20249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20249&action=edit [SIGNED-OFF] Bug 10703: Document quotes table Add db documentation for the quotes table To test: apply patch review kohastructure.sql to be sure documentation is there Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 23:42:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 21:42:24 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20210|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 20250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20250&action=edit [SIGNED-OFF] Bug 10703: Document borrower_files table Add db documentation to borrower_files table. To test: apply review kohastructure.sql to be sure documentation is there Signed-off-by: Bernardo Gonzalez Kriegel Comment: No errors. Tested loading on new database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 9 23:42:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 21:42:49 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 00:50:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 22:50:51 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20247|0 |1 is obsolete| | --- Comment #8 from Mirko Tietgen --- Created attachment 20251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20251&action=edit Bug 8507: koha-create should be updated to use DOM indexing for bib This patch makes the koha-create script install the file zebra-biblios-dom.cfg with the proper string substitutions inside on the new instance koha-conf.xml file. It also adds two option switches that control the indexing mode for the instance: --biblio-idx {dom|grs1} --auth-idx {dom|grs1} DOM indexing is set as the default for both authorities and bibliographic records. Following drojf (thanks!) advise I arranged stuff like explained here: http://wiki.koha-community.org/wiki/Switching_to_dom_indexing To test: - Apply the patch - Build your own packages and install them on a test server a) Create a new instance without using the new switches like: $ koha-create --create-db domtest - Check there's a file /etc/koha/sites/domtest/zebra-biblios-dom.cfg - Check that /etc/koha/sites/domtest/koha-conf.xml points to: * zebra-biblios-dom.cfg (biblioserver section) * zebra-biblios-dom.cfg (publicserver section) * zebra-authorities-dom.cfg (authorityserver section) - Success means the new default is DOM b) Play with the 4 possible combination of option switches $ koha-create --create-db --auth-idx grs1 --biblio-idx grs1 domtest $ koha-create --create-db --auth-idx grs1 --biblio-idx dom domtest $ koha-create --create-db --auth-idx dom --biblio-idx grs1 domtest $ koha-create --create-db --auth-idx dom --biblio-idx dom domtest - Check the koha-conf.xml file reflects the chosen options. c) Run $ koha-create --help - It should advertise this addition accordingly. d) Run $ man koha-create - Man page for koha-create should provide good information on the new switches behaviour Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 00:51:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 22:51:11 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 00:55:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 22:55:46 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 00:55:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 22:55:50 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15518|0 |1 is obsolete| | Attachment #15520|0 |1 is obsolete| | Attachment #15521|0 |1 is obsolete| | Attachment #15522|0 |1 is obsolete| | Attachment #17203|0 |1 is obsolete| | Attachment #17204|0 |1 is obsolete| | --- Comment #43 from Galen Charlton --- Created attachment 20252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20252&action=edit Bug 9611: Change the password hashing algorithm from MD5 to Bcrypt What this patch aims to accomplish? * All new passwords are stored as Bcrypt-hashes * For password verification: - If the user was created before this patch was applied then use MD5 to hash the entered password <-- backwards compatibility - If the user was created after this patch was applied then use Bcrypt to hash the entered password * Any password change made via the staff interface or the OPAC will be automatically Bcrypt-hashed; this applies to old users whose passwords were stored as MD5 hashes previously Test plan: 1) Add new users and check whether their passwords are stored as Bcrypt hashes or not. 2) To test that authentication works for both old as well as new users: a) Login as an existing user whose password is stored as a MD5 hash b) Login as an existing user whose password is stored as a Bcrypt hash 3) In the staff interface, change the password of an existing user whose password is stored as an MD5 hash a) Check the new password is stored as a Bcrypt-hash in the database b) Try to login with the new password 4) In the OPAC, verify that a) Old user with old pass can change password, new format b) New user with new pass can change password c) Old and new user with self-updated pass can login Whitespace cleanup was contributed by Bernardo Gonzalez Kriegel. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Mason James Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 00:56:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 22:56:00 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #44 from Galen Charlton --- Created attachment 20253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20253&action=edit bug 9611: removing external dependency for password salt generator To address packaging issues with Crypt::Random::Source, this patch replaces the salt generation with a wrapper for /dev/urandom and /dev/random. The test plan for this patch is the same as that for the base patch for bug 9611. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 00:56:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 22:56:09 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #45 from Galen Charlton --- Created attachment 20254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20254&action=edit Bug 9611: Database update, changing password from varchar(30) to varchar(60) This is necessary because Bcrypt hashes are longer than MD5 hashes. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Mason James Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 00:56:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 22:56:21 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #46 from Galen Charlton --- Created attachment 20255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20255&action=edit Bug 9611: add Crypt::Eksblowfish::Bcrypt to list of Perl dependencies Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Mason James Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:00:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:00:45 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 --- Comment #9 from Mirko Tietgen --- Created attachment 20256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20256&action=edit Bug 8507 Follow-Up: Fix path Fixed the path to __ZEBRA_BIBLIOS_CFG__ for -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:03:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:03:42 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #47 from Galen Charlton --- I've squashed the patch series into a set of four that reduce the flapping while retaining author attribution, and have signed off on them. I am not, however, setting this bug to signed off, but to assigned. This is because patron records using the new hash would be unable to authenticate using SIP or ILS-DI. Note that the following files are using md5_base64 exclusive when comparing hashes: C4/SIP/ILS/Patron.pm C4/ILSDI/Utility.pm Also, although of less import, C4/Auth_with_ldap.pm isn't using the new hashing style either when caching the password. Consequently, follow-ups are needed. I may poke at this some more this weekend, but the field is free if anybody else wants to work on it. I'm inclined to think that it may be time to get started on a Koha::Auth module, if only for the initial reason of creating a home for a single password verification routine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:03:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:03:56 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #10 from Mirko Tietgen --- I followed the test plan and then tried DOM and GRS1 indexing and search for biblio and authorities. Works for me. I added a tiny follow-up to fix the path for "mergeserver" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:06:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:06:01 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #48 from Galen Charlton --- Also, just to raise the inevitable question: do we care about the portability issues of using /dev/random and /dev/urandom? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:09:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:09:41 +0000 Subject: [Koha-bugs] [Bug 10705] New: Shipment cost should be 'shipping' Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705 Bug ID: 10705 Summary: Shipment cost should be 'shipping' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org For the US English translation Shipment cost should probably read 'Shipping cost' on the receive page and the invoice page. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:10:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:10:37 +0000 Subject: [Koha-bugs] [Bug 10706] New: keyword search on reports should search report number Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Bug ID: 10706 Summary: keyword search on reports should search report number Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org When using the keyword filter on the reports page it should also let you search the report number - or there should be a report number filter, but I think expanding the keyword is probably easier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:11:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:11:52 +0000 Subject: [Koha-bugs] [Bug 10707] New: inventory not removing lost status Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10707 Bug ID: 10707 Summary: inventory not removing lost status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org When doing inventory it should remove the lost status if an item is marked seen ... cause if it's seen it's not lost. The problem / discussion here is on what should happen to items that are still 'checked out' and marked lost - should the patron be refunded? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:13:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:13:22 +0000 Subject: [Koha-bugs] [Bug 10708] New: make fine receipt customizable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 Bug ID: 10708 Summary: make fine receipt customizable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org The fine receipt should be brought under 'Notices & Slips' for customization. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:15:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:15:29 +0000 Subject: [Koha-bugs] [Bug 10709] New: only overdue notices & slips can be branch specific Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10709 Bug ID: 10709 Summary: only overdue notices & slips can be branch specific Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org If you create a custom notice that is not an overdue for your branch the system still sends the notice for 'all libraries'. This is not true for slips and overdues which can be customized on a per branch basis. Either this is a bug or if it's a development it needs to be clear on the notices & slips page that you can't create certain notices for your library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:15:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:15:35 +0000 Subject: [Koha-bugs] [Bug 10709] only overdue notices & slips can be branch specific In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10709 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10702 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:15:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:15:35 +0000 Subject: [Koha-bugs] [Bug 10702] can't create notices for a specific branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10702 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10709 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:23:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:23:52 +0000 Subject: [Koha-bugs] [Bug 5825] Add Item Type column to Holds Queue report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5825 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20195|0 |1 is obsolete| | CC| |melia at bywatersolutions.com --- Comment #3 from Melia Meggs --- Created attachment 20257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20257&action=edit [Signed off] Bug 5825 - Add item type column to holds queue After applying this patch, I can now see a column for Item Type on the Holds Queue report. I can also see the description of the correct collection code in the Collection column. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:24:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:24:03 +0000 Subject: [Koha-bugs] [Bug 5825] Add Item Type column to Holds Queue report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5825 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:31:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:31:23 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20069|0 |1 is obsolete| | --- Comment #12 from Mirko Tietgen --- Created attachment 20258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20258&action=edit Bug 10361: (follow-up) add tests for search history functions This adds tests for the new PurgeSearchHistory function and AddSearchHistory. GetSearchHistory is not tested due to its current broken state (see bug 10667). To test: [1] Run prove -v t/db_dependent/Search_SearchHistory.t [2] Verify that all tests pass. Signed-off-by: Galen Charlton Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:31:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:31:54 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:32:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:32:47 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Mirko Tietgen --- t/db_dependent/Search_SearchHistory.t .. 1..6 ok 1 - use C4::Search; ok 2 - starting off with nothing in search_history ok 3 - successfully added four search_history rows ok 4 - purged history older than 45 days ok 5 - purged history older than 30 days ok 6 - purged all history ok All tests successful. Thanks Galen for adding the tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:42:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:42:26 +0000 Subject: [Koha-bugs] [Bug 9943] Pay fines page "Pay selected" button give invalid amount when nothing is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9943 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20246|0 |1 is obsolete| | CC| |melia at bywatersolutions.com --- Comment #4 from Melia Meggs --- Created attachment 20259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20259&action=edit [Signed off] Bug 9943 - Pay fines page "Pay selected" button give invalid amount when nothing is selected I confirmed the behavior that Pongtawat described on master. After applying this patch, I went to the pay fines page for a patron with fines. I selected and deselected each checkbox one by one, and I used the Select All and Clear All links successfully. I confirmed that the "Pay Selected" button is disabled when nothing is selected. I paid off one selected fine, and also paid off multiple fines with the pay selected button. All behaves as expected, so I am signing off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 01:42:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Aug 2013 23:42:36 +0000 Subject: [Koha-bugs] [Bug 9943] Pay fines page "Pay selected" button give invalid amount when nothing is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9943 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 02:08:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Aug 2013 00:08:35 +0000 Subject: [Koha-bugs] [Bug 7469] Focus on 1st field of creation form instead of search textbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7469 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20128|0 |1 is obsolete| | --- Comment #2 from Melia Meggs --- Created attachment 20260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20260&action=edit [Signed off] Bug 7469 - Focus on 1st field of creation form instead of search textbox (Acquisition) I tested these pages and noticed that the focus had shifted from the search box at the top of the screen to the first field on the screen: - acqui/basketgroup.pl : focus on "Basket group name:" - acqui/basketheader.pl : focus on "Basket name:" - acqui/invoices.tt : focus on "Invoice no:" - acqui/modordernotes.pl : focus on "Notes:" - acqui/neworderempty.pl : focus on "Title:" - acqui/supplier.pl : focus on "Name:" - acqui/z3950_search.pl : focus on "Title:" The only one that I'm not sure about is acqui/neworderempty.pl. I'm not sure if I am looking at the correct screen for testing, but I am on this page and the focus is still on the Vendor Search box at the top of the screen: http://staff-melia.test.bywatersolutions.com/cgi-bin/koha/acqui/neworderempty.pl?ordernumber=2&booksellerid=1&basketno=2 Since all of the others listed here worked for me, I am signing off. Could someone else please test acqui/neworderempty to be sure, and if a problem is found, could that one be addressed in a follow up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 02:08:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Aug 2013 00:08:58 +0000 Subject: [Koha-bugs] [Bug 7469] Focus on 1st field of creation form instead of search textbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7469 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 02:27:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Aug 2013 00:27:15 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20085|0 |1 is obsolete| | --- Comment #6 from Melia Meggs --- Created attachment 20261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20261&action=edit [Signed off] Bug 10678 - Allow framework selection when creating from Z39.50 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 02:27:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Aug 2013 00:27:54 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20088|0 |1 is obsolete| | CC| |melia at bywatersolutions.com --- Comment #7 from Melia Meggs --- Created attachment 20262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20262&action=edit [Signed off] Bug 10678 - Update addbooks help page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 02:28:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Aug 2013 00:28:16 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20262|0 |1 is patch| | Attachment #20262|application/mbox |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 02:31:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Aug 2013 00:31:21 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Melia Meggs --- After applying these patches, I can see the "New from Z39.50" button with the arrow for a dropdown of frameworks. I tested this by just clicking the button, going through the usual Z39.50 search and import, and my record was imported with the default framework. I then chose a different framework from the dropdown, went through the usual Z39.50 search and import, and my record was imported with the framework I had selected. I read the update to the help page, and I think everything looks good, so I am signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 02:37:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Aug 2013 00:37:12 +0000 Subject: [Koha-bugs] [Bug 10034] "kw,rld:" in Z39.50 research In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10034 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia at bywatersolutions.com --- Comment #4 from Melia Meggs --- I tried testing this on master today and do not see the "kw,rld: XXXX" in the title field in Z39.50 like in this attachment. My title search field looks correct even without before applying this patch, so I wonder if perhaps this has been fixed in master since the bug was reported. Does anyone else see the "kw,rld: XXXX" in the title field of Z39.50 search on master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 18:43:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Aug 2013 16:43:31 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 10 18:43:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Aug 2013 16:43:37 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20256|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 20263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20263&action=edit Bug 8507: [SIGNEF OFF] Follow-Up: Fix path Fixed the path to __ZEBRA_BIBLIOS_CFG__ for Signed-off-by: Tomas Cohen Arazi Good catach drojf. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 11 04:17:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Aug 2013 02:17:46 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 11 04:17:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Aug 2013 02:17:51 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19084|0 |1 is obsolete| | --- Comment #19 from Chris Cormack --- Created attachment 20264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20264&action=edit Bug 9252 - Add option to send patron's home branch in AF field This patch gives you the option of sending a patrons home branch code in an AF field for patron status requests. It is controlled at the account login level, so it can be enable on a per-sip-login basis. Test Plan: 1) Apply patch 2) Edit SIPconfig.xml, add the parameter 'send_patron_home_library_in_af="1"' to the login you will be using to test. 3) Start your SIP2 server. 4) Connect to it via telnet ( something like: '9300CNterm1|COterm1|CPCPL|' ) 5) Send a patron status request ( like: '2300120121110 82925AOCPL|AA23529000035676|ACterm1|ADletmein' ) 6) Examine reponse you should see something like this: "24 00120121210 085332AEHenry Acevedo|AA23529000035676|BLY|CQN|AFGreetings from Koha. |AFMPL|AO|" Note the second AF field with the value MPL. Signed-off-by: George Williams Signed-off-by: Christopher Brannon Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 11 04:18:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Aug 2013 02:18:19 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19469|0 |1 is obsolete| | --- Comment #20 from Chris Cormack --- Created attachment 20265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20265&action=edit Bug 9252 - Add option to send patron's home branch in AF field - QA Followup Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 11 10:49:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Aug 2013 08:49:34 +0000 Subject: [Koha-bugs] [Bug 9899] Can't create new patrons with the database administrator account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9899 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- Hm, I have tried recreating this but it works nicely for me - maybe it was fixed with another bug? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 11 10:53:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Aug 2013 08:53:35 +0000 Subject: [Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 --- Comment #9 from Katrin Fischer --- Chris, could you maybe take another look at this? I think it would be a really nice and helpful feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 11 10:57:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Aug 2013 08:57:08 +0000 Subject: [Koha-bugs] [Bug 9548] Store bibliographic information in aqorders table ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hm, I am not sure how this would work. If you delete a record, you can still query the biblionumber in the deleted* tables for your reports, so it's not lost. But if you merge 2 records - which information should be stored? I think some libraires might say that it's right that the old information is discarded at least for some use cases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 11 20:21:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Aug 2013 18:21:50 +0000 Subject: [Koha-bugs] [Bug 9548] Store bibliographic information in aqorders table ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 --- Comment #3 from Nicole C. Engard --- The problem I see is that the basket says 'deleted title' or something like that - so it's not querying the deleted tables to show the basket info. We need a way to keep the basket showing the info that was on the order even if it has been deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 11 20:33:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Aug 2013 18:33:06 +0000 Subject: [Koha-bugs] [Bug 9548] Store bibliographic information in aqorders table ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 --- Comment #4 from Katrin Fischer --- I think the answer is to query the table then :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 11 22:01:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Aug 2013 20:01:37 +0000 Subject: [Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 --- Comment #10 from Chris Cormack --- (In reply to Katrin Fischer from comment #9) > Chris, could you maybe take another look at this? I think it would be a > really nice and helpful feature. Maybe, it's just something I was doing on my own time, and I don't have much of that at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 09:42:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 07:42:53 +0000 Subject: [Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10681 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 09:42:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 07:42:53 +0000 Subject: [Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10698 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 09:46:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 07:46:36 +0000 Subject: [Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from kenza --- (In reply to Chris Cormack from comment #2) > I cant get this to apply, even after apply 10692 Sorry i forgot to mention it, but this patch also needs to apply 10681. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 10:31:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 08:31:20 +0000 Subject: [Koha-bugs] [Bug 10034] "kw,rld:" in Z39.50 research In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10034 --- Comment #5 from Silvia Simonetti --- I see the "kw,rld: XXXX" in the title field of Z39.50 search when I find in simple search and I have no result, or with Advanced search in keyword field and I have no result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 10:43:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 08:43:33 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Owen, Could you explain why this patch adds dataTables.fnReloadAjax.js and jquery.dataTables.columnFilter.js? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 12:55:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 10:55:38 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #43 from Jonathan Druart --- I am not able to reproduce Owen and Chris issues. (In reply to Owen Leonard from comment #33) > I just tried this out with a copy of our production database of patrons > (62,000+ records) and I don't get any results. > > When I first load the page it looks like the table is trying to process > *all* patron records? The POST response has this: > > "iTotalRecords": 62459, > "iTotalDisplayRecords": 62459, > > ...but they are never displayed. I don't get any results from clicking on > the "browse by last name" alphabet links, and I don't get any results after > performing a simple search by last name. In all cases I see the "processing" > message on the screen but nothing is ever displayed. Without any errors in your koha logs (or js error)? (In reply to Chris Cormack from comment #40) > I think you may be misunderstanding, these patches add datatables, but they > also change the behaviour so when you visit the members page it fetches > every single borrower from the database. This is not acceptable, hence the > failed qa, nor will an index fix it. It either needs to be rewritten to lazy > load, or to not fetch all borrowers, or some other fix This patch normally does that! :) Of course, the goal of this patch is to retrieve only the xx first results, not all. After applying these patches, I go on members/members-home.pl and the generated sql query is: SELECT borrowers.borrowernumber, borrowers.surname, borrowers.firstname, borrowers.address, borrowers.address2, borrowers.city, borrowers.zipcode, borrowers.country, CAST(borrowers.cardnumber AS UNSIGNED) AS cardnumber, borrowers.dateexpiry, borrowers.borrowernotes, borrowers.branchcode, categories.description AS category_description, categories.category_type, branches.branchname FROM borrowers LEFT JOIN branches ON borrowers.branchcode = branches.branchcode LEFT JOIN categories ON borrowers.categorycode = categories.categorycode ORDER BY borrowers.surname asc,borrowers.firstname asc LIMIT 0,20 The limit clause exists! You can display this query in the log, warning the $query var in C4::Utils::DataTables::Members l.102. Maybe the executing time issue is caused by the 2 COUNT(*) queries. But since we don't want the "SELECT SQL_CALC_FOUND_ROWS" mysqlism, I don't know how we can do that on a different way. I will submit a patch replacing the count(*) with count(borrowers.borrowernumber), but I am not sure it could be useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 12:56:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 10:56:50 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 12:56:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 10:56:56 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #44 from Jonathan Druart --- Created attachment 20266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20266&action=edit Bug 9811: use count(primary_key) instead of count(*) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 13:44:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 11:44:04 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #45 from Jonathan Druart --- With 35k patrons in the DB, the table is displayed in 2sec (on my dev instance). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 14:09:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 12:09:20 +0000 Subject: [Koha-bugs] [Bug 10710] New: OfflineOperation's routines in C4/Circulation.t need unit tests. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 Bug ID: 10710 Summary: OfflineOperation's routines in C4/Circulation.t need unit tests. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org AddOfflineOperation, GetOfflineOperation, GetOfflineOperations, DeleteOfflineOperation need unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 14:10:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 12:10:10 +0000 Subject: [Koha-bugs] [Bug 10710] OfflineOperation's routines in C4/Circulation.t need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki at biblibre.com Blocks| |10681 Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 14:10:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 12:10:10 +0000 Subject: [Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10710 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 14:21:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 12:21:52 +0000 Subject: [Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OfflineOperation's routines |UT : OfflineOperation's |in C4/Circulation.t need |routines in |unit tests. |C4/Circulation.t need unit | |tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 14:24:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 12:24:57 +0000 Subject: [Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 --- Comment #1 from kenza --- Created attachment 20267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20267&action=edit Bug 10710 : OfflineOperation's routines in C4/Circulation.pm need unit tests. This patch test AddOfflineOperation,GetOfflineOperation and DeleteOfflineOperation in C4/Circulation.pm. The tests are wrap in a transaction. Note: Currently, GetOfflineOperations is not tested because we cannot mock C4::Context->userenv in unit tests To test: prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.01 usr 0.01 sys + 0.33 cusr 0.02 csys = 0.37 CPU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 14:24:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 12:24:54 +0000 Subject: [Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 14:33:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 12:33:46 +0000 Subject: [Koha-bugs] [Bug 10711] New: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Bug ID: 10711 Summary: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 14:34:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 12:34:20 +0000 Subject: [Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki at biblibre.com Depends on| |10681, 10710 Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 14:34:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 12:34:20 +0000 Subject: [Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10711 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 14:34:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 12:34:20 +0000 Subject: [Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10711 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 14:38:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 12:38:41 +0000 Subject: [Koha-bugs] [Bug 10614] have add order form at top and bottom In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10614 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 14:38:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 12:38:44 +0000 Subject: [Koha-bugs] [Bug 10614] have add order form at top and bottom In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10614 --- Comment #1 from Owen Leonard --- Created attachment 20268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20268&action=edit Bug 10614 - have add order form at top and bottom If a basket has a lot of items it may be inconvenient to scroll to the bottom of the patch to reach the "add to basket" form. This patch adds as "Add to basket" button to the toolbar which uses JavaScript to copy the form into a modal dialog for quick access. To test, apply the patch and view an open basket. You should be able to click the "Add to basket" button to trigger a modal dialog with the full "Add to basket" list of options. All options in the list should function normally. If you view a closed basket the new button should not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 14:43:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 12:43:28 +0000 Subject: [Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 14:43:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 12:43:30 +0000 Subject: [Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 --- Comment #1 from kenza --- Created attachment 20269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20269&action=edit Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result To test : prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.24 cusr 0.02 csys = 0.29 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 14:48:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 12:48:36 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 --- Comment #5 from Owen Leonard --- (In reply to Jonathan Druart from comment #4) > Owen, Could you explain why this patch adds dataTables.fnReloadAjax.js and > jquery.dataTables.columnFilter.js? They already exist, I'm just copying them to the new location. I thought it was sensible to move them at the same time I moved the other DataTables library js even though the templates where they are used (detail.tt and quotes.tt) are not affected by this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:03:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:03:26 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #76 from Jonathan Druart --- I get a really weird js error when I click on the Items header: TypeError: y[(("string" + "-") + m[Q][1])] is not a function Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:08:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:08:16 +0000 Subject: [Koha-bugs] [Bug 9652] Call number column on list view displays commas when no callnumbers exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9652 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard --- Fixed by Bug 9757 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:09:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:09:25 +0000 Subject: [Koha-bugs] [Bug 10614] have add order form at top and bottom In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10614 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20268|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 20270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20270&action=edit [SIGNED-OFF] Bug 10614 - have add order form at top and bottom If a basket has a lot of items it may be inconvenient to scroll to the bottom of the patch to reach the "add to basket" form. This patch adds as "Add to basket" button to the toolbar which uses JavaScript to copy the form into a modal dialog for quick access. To test, apply the patch and view an open basket. You should be able to click the "Add to basket" button to trigger a modal dialog with the full "Add to basket" list of options. All options in the list should function normally. If you view a closed basket the new button should not appear. Signed-off-by: Nicole C. Engard All tests pass and I love it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:09:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:09:35 +0000 Subject: [Koha-bugs] [Bug 10614] have add order form at top and bottom In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10614 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:10:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:10:03 +0000 Subject: [Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- QA comment: The described ergonomic issue has been fixed. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:10:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:10:28 +0000 Subject: [Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19783|0 |1 is obsolete| | Attachment #19850|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 20271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20271&action=edit Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled An error in the onclick for phone notices causes the "Do not notify" checkbox to be checked when the phone checkbox is checked. Also, checking "Do not notify" does not uncheck the phone checkbox. Test plan: 1) Enable TalkingTechItivaPhoneNotification 2) Browse to the new patron screen ( memberentry.pl ) 3) In the patron messaging preferences check the Phone checkbox 4) Not the "do not notify" checkbox is then checked 5) Uncheck the "do not notify" checkbox, and check the Email checkbox as well 6) Now check the "do not notify" checkbox, note the Phone checkbox remains checked 7) Apply this patch 8) Repeat steps 3-6, noting the odd behavior is no longer present Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:10:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:10:55 +0000 Subject: [Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 --- Comment #7 from Jonathan Druart --- Created attachment 20272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20272&action=edit Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled - QA Followup Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:20:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:20:24 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19765|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 20273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20273&action=edit Bug 10611: Use mysql_auto_reconnect instead of ping DBD::Mysql provides a mysql_auto_reconnect flag. Using it avoid to do a ping. Benchmarks: use Modern::Perl; use C4::Context; for ( 1 .. 1000 ) { $dbh = C4::Context->dbh; } * without this patch on a local DB: perl t.pl 0,49s user 0,02s system 98% cpu 0,525 total * without this patch on a remote DB: perl t.pl 0,52s user 0,05s system 1% cpu 37,358 total * with this patch on a local DB: perl t.pl 0,46s user 0,04s system 99% cpu 0,509 total * with this patch on a remote DB: perl t.pl 0,49s user 0,02s system 56% cpu 0,892 total Testing the auto reconnect: use Modern::Perl; use C4::Context; my $ping = $dbh->ping; say $ping; $dbh->disconnect; $ping = $dbh->ping; say $ping; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:20:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:20:21 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:20:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:20:49 +0000 Subject: [Koha-bugs] [Bug 6711] 'No more renewals' message has empty pull down In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6711 --- Comment #3 from Owen Leonard --- Is this fixed now? I can't reproduce the problem by following the steps listed above, and Bug 6712 is marked as resolved. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:21:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:21:08 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 --- Comment #4 from Jonathan Druart --- (In reply to Galen Charlton from comment #2) > This patch breaks test cases that mock C4::Context->_new_dbh() Good catch, the db_driver variable was not defined! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:24:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:24:25 +0000 Subject: [Koha-bugs] [Bug 6604] without OPACXSLTResultsDisplay, some entries are "no items available" in opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6604 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- This bug is quite old, so it's hard to tell what was going on here. However it sounds as if it was a simple indexing problem. If Zebra hasn't indexed newly-added items how can they be displayed? If someone knows better and can explain, please re-open. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:45:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:45:42 +0000 Subject: [Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|paul.poulain at biblibre.com |jonathan.druart at biblibre.co | |m --- Comment #19 from Jonathan Druart --- Looks good to me. Can be tested on tools/import_borrowers.pl?sample=1 Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:46:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:46:47 +0000 Subject: [Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19901|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 20274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20274&action=edit Bug 7785 - MySQL-specific syntax in C4::Members columns() The initial thought was to remove this function. However, tools/import_borrowers.pl uses it. So rather than remove it to solve the problem, it was reworked to a more generic solution which runs faster. By accessing $sth->{NAME} directly, the driver becomes responsible for filling it correctly. This happens when a SELECT is done on the borrowers table. It does not even have to have data in the result set! The columns method could be more generic and used elsewhere too. Comparison between the old method and the STH method showed a significant time difference. The old method took 35 seconds for 40k iterations versus 19 seconds for the same amount of iterations with the STH method regardless of the size of the borrowers table. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:54:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:54:29 +0000 Subject: [Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |5766 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 15:54:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 13:54:29 +0000 Subject: [Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7019 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 16:11:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 14:11:18 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 16:11:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 14:11:22 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19764|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 20275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20275&action=edit iBug 10610: sysprefs.sql should be sorted by syspref names By sorting the sql syspref file, the developpers will be happy to avoid conflicts on this file each time a patch modifying it is pushed. Test plan: - create a new DB with a new table named systempreferences (with the same structure as the one you know). - insert the current sysprefs.sql file into this table. - note the number of rows in the systempreferences table. - apply this patch. - delete all rows of the systempreferences table. - insert the new sysprefs.sql file. - verify the number of rows is the same as the previous. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 16:14:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 14:14:22 +0000 Subject: [Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 16:56:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 14:56:06 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #7 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #6) > Do I need some setup first? No, this should be done by this unit tests file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 17:04:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 15:04:52 +0000 Subject: [Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 17:08:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 15:08:53 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 17:08:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 15:08:56 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 --- Comment #8 from Jonathan Druart --- Created attachment 20276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20276&action=edit Bug 10333: remove_item should be called just one time If there is no remaining items, the retrieve routine returns -2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 17:20:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 15:20:44 +0000 Subject: [Koha-bugs] [Bug 10362] on return with reserve or transfer the alerts are not shown In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10362 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 17:24:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 15:24:23 +0000 Subject: [Koha-bugs] [Bug 10712] New: Some values not saved in koha install log Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10712 Bug ID: 10712 Summary: Some values not saved in koha install log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org when running perl Makefile.PL --prev-install-log for an upgrade you are still prompted to choose the authorities indexing mode and the tokenizer value they should be saved with the other variables in the koha-install-log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 17:44:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 15:44:21 +0000 Subject: [Koha-bugs] [Bug 10712] Some values not saved in koha install log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10712 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell --- Created attachment 20277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20277&action=edit Proposed Patch To test. On a system installed/upgraded without the patch running 'perl Makefile.PL --prev-install-log /path/to/koha-install-log' will still prompt you to choose authorities indexing mode and select between chr and icu, after upgrading with this patch applied the same command should get the responses from the install log and not require user intervention. The values can be seen written into misc/koha-install-log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 17:48:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 15:48:44 +0000 Subject: [Koha-bugs] [Bug 10246] OPAC items table CSS classes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10246 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Assignee|chrish at catalyst.net.nz |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 17:54:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 15:54:04 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 --- Comment #3 from Galen Charlton --- Noting that a Koha user recently reported an instance of purchase suggestion spam: http://lists.katipo.co.nz/pipermail/koha/2013-July/036898.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 17:54:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 15:54:59 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #2 from Galen Charlton --- Is there a patch forthcoming? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 17:59:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 15:59:55 +0000 Subject: [Koha-bugs] [Bug 7075] Fine in days values are returned for patrons with past overdues when fine in days is set to 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7075 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #8 from Galen Charlton --- This bug was made moot by the patch for bug 6328. Setting to RESO/INVALID. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:02:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:02:00 +0000 Subject: [Koha-bugs] [Bug 8031] get rid of older notices from the patron notices tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8031 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:02:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:02:06 +0000 Subject: [Koha-bugs] [Bug 8031] get rid of older notices from the patron notices tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8031 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:02:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:02:36 +0000 Subject: [Koha-bugs] [Bug 7536] delete permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7536 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:02:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:02:42 +0000 Subject: [Koha-bugs] [Bug 7536] delete permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7536 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:03:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:03:03 +0000 Subject: [Koha-bugs] [Bug 7881] display additional fields in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7881 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:03:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:03:09 +0000 Subject: [Koha-bugs] [Bug 7881] display additional fields in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7881 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:04:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:04:22 +0000 Subject: [Koha-bugs] [Bug 7032] can select multiple layouts to edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:04:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:04:31 +0000 Subject: [Koha-bugs] [Bug 7032] can select multiple layouts to edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:05:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:05:58 +0000 Subject: [Koha-bugs] [Bug 10127] Printoverdues.sh should tar only pdf files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10127 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Sophie! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:07:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:07:00 +0000 Subject: [Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After Patron Delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- (In reply to David Cook from comment #5) > Why don't we call the new reorder function on patron delete? I see that > there is already a function for handling patron deletes in regards to > Lists/VirtualShelves. That probably makes the most sense. I prefer this option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:23:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:23:33 +0000 Subject: [Koha-bugs] [Bug 8887] Search preferences: Strange behaviour with exact matches (default instead of custom favicon used, displays to much results) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:23:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:23:37 +0000 Subject: [Koha-bugs] [Bug 8887] Search preferences: Strange behaviour with exact matches (default instead of custom favicon used, displays to much results) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12726|0 |1 is obsolete| | --- Comment #8 from Galen Charlton --- Created attachment 20278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20278&action=edit Bug 8887: only display desired result when doing exact syspref search This patch fixes an issue where entering the complete name of a system preference when doing a syspref search in the staff interface resulted in the display of *all* preferences belonging to the desired one's module. Since providing a more specific search string should result in getting back more specific results, the previous behavior was not intuitive. Test scenario: a) In sysprefs, do a search with partial match (e.g. intranetcolor) -> Result shows one entry: intranetcolorstylesheet b) Do an exact search. e.g. intranetcolorstylesheet -> Result shows all Staff Client preferences Apply patch, test again. Now b) behaves like a). Signed-off-by: Mirko Tietgen Signed-off-by: Galen Charlton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:37:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:37:23 +0000 Subject: [Koha-bugs] [Bug 8887] Search preferences: Strange behaviour with exact matches (default instead of custom favicon used, displays to much results) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 --- Comment #9 from Galen Charlton --- (In reply to Jonathan Druart from comment #6) > I don't know if it is what the users want. It is what *this* user wants -- this has been annoying me for years, albeit not enough to do anything about it. I do not find it intuitive that providing a more specific search string yields more hits, not fewer. The existing behavior was intentional -- see commit cdb3d52423f9 -- but IMO the "jump to preference" is only effective if the module (e.g., Circulation) has enough preferences to make the page long enough that the desired preference is scrolled to the top of the browser viewport. For most sysprefs, though, I end up having the scan the page for the one I just searched for, and it would be easier if the search just gave me only the one I was looking for. I recognize that opinions can differ on this, but thus far no contrary ones have actually been expressed. I've signed off on the patch and adjusted the wording of the commit description a bit. I did remove mention of the favicon, as I wasn't able to reproduce it and I think it's a moot issue. Status => Signed Off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:40:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:40:08 +0000 Subject: [Koha-bugs] [Bug 7136] language inconsistency on serials status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136 --- Comment #4 from Owen Leonard --- I still don't know what to do with this. If an issue goes from "expected" to "waiting" to "late" like the help file says, how can we replace "waiting" with "expected?" Or are they really the same, and the help file is inaccurate? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:41:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:41:45 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- (In reply to claire.hernandez at biblibre.com from comment #5) > We are currently working on this patch, please do not consider this > submission for the moment Any updates? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:46:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:46:25 +0000 Subject: [Koha-bugs] [Bug 6833] Notifications Rewrite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6833 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |gmcharlt at gmail.com Resolution|--- |WISHLIST --- Comment #4 from Galen Charlton --- As it is approaching nearly two years since the bug was opened with no sign that the notifications RFC is being worked on, setting to RESOLVED/WISHLIST. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:46:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:46:57 +0000 Subject: [Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour customizable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #3 from Galen Charlton --- (In reply to claire.hernandez at biblibre.com from comment #2) > We are currently working on this patch, please do not consider this > submission for the moment Any updates? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:53:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:53:17 +0000 Subject: [Koha-bugs] [Bug 7207] Cannot export label batches in IE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Bug 7207 depends on bug 6697, which changed state. Bug 6697 Summary: Empty Organisation(s) field for organisational patrons http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6697 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 18:53:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 16:53:17 +0000 Subject: [Koha-bugs] [Bug 6697] Empty Organisation(s) field for organisational patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6697 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Owen Leonard --- If the display problem is fixed, isn't this bug fixed? If there is functionality which hasn't been implemented that belongs in another bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 19:03:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 17:03:19 +0000 Subject: [Koha-bugs] [Bug 9904] Link to plugins management should not be in global navigation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9904 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |gmcharlt at gmail.com Resolution|--- |FIXED --- Comment #7 from Galen Charlton --- (In reply to Kyle M Hall from comment #6) > I also think this is a bad move. It's going to confuse, not clarify. Both > the tool and report plugin links filter some of the plugins and aren't meant > to be for full plugin management. I believe this commit should be reverted. I won't be the one to revert it, and I'm setting the status accordingly. >From the POV of an ordinary user, plugins are *not* a separate module -- they are simply a mechanism by which additional tools and reports can be made available. There really should be no separate plugins home page, just: - an admin page to upload and manage them - list of tool plugins (with "Home > Tools > Tool Plugins" as the breadcrumb list and the tools sidebar) - list of report plugins (with "Home > Reports > Report Plugins" as the breadcrumb list and the reports sidebar) The later two pages should *not* offer the upload link in the sidebar -- that is purely an administrative function. I'll file a separate bug for the above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 19:03:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 17:03:26 +0000 Subject: [Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Owen! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 19:05:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 17:05:57 +0000 Subject: [Koha-bugs] [Bug 10713] New: integrate tools and reports plugins into staff interface better Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10713 Bug ID: 10713 Summary: integrate tools and reports plugins into staff interface better Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com >From the POV of an ordinary user, plugins are *not* a separate module -- they are simply a mechanism by which additional tools and reports can be made available. Consequently, they should integrate better with the tools and reports sections of the staff interface. There should be no separate plugins home page, just: - an admin page to upload and manage them - list of tool plugins (with "Home > Tools > Tool Plugins" as the breadcrumb list and the tools sidebar) - list of report plugins (with "Home > Reports > Report Plugins" as the breadcrumb list and the reports sidebar) The later two pages should *not* offer the upload link in the sidebar -- that is purely an administrative function. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 19:08:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 17:08:18 +0000 Subject: [Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #21 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 19:09:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 17:09:36 +0000 Subject: [Koha-bugs] [Bug 10563] Link to edit subscription from 'check expiraton' page is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10563 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 19:15:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 17:15:58 +0000 Subject: [Koha-bugs] [Bug 6124] In transferstoreceive.pl some biblios are empty. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6124 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #7 from Galen Charlton --- Setting to RESOLVED/INVALID -- it's been over a year since the question was posed, and the FK on branchtransfers.itemnumber should make the bug impossible unless the wrong storage engine was being used. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 19:24:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 17:24:31 +0000 Subject: [Koha-bugs] [Bug 7515] authorized value code showing in opac for public note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #22 from Galen Charlton --- (In reply to Kyle M Hall from comment #21) > 2) Solve at the .tt level: i.e. use > Koha::Template::Plugin::KohaAuthorisedValues and patch as we go along at the > template level. We can patch this sub to check for an authorised value > mapping and return either the correct mapping or the original passed in > data. The will greatly simplify the amount of code necessary to support the > use of authorised values mapping. I prefer this option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 19:46:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 17:46:45 +0000 Subject: [Koha-bugs] [Bug 10712] Some values not saved in koha install log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10712 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 19:46:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 17:46:49 +0000 Subject: [Koha-bugs] [Bug 10712] Some values not saved in koha install log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10712 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20277|0 |1 is obsolete| | --- Comment #2 from Galen Charlton --- Created attachment 20279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20279&action=edit Bug 10712: Save missing config variables to install log The variables for AUTH_INDEX_MODE and ZEBRA_TOKENIZER were not being saved to the koha_install_log file. As a result when using the --prev-install-log option in Makefile.PL the user was still prompted to select them. This patch adds the appropriate variables to the list saved in the install log. To test: On a (non-package) system installed/upgraded without the patch running 'perl Makefile.PL --prev-install-log /path/to/koha-install-log' will still prompt you to choose authorities indexing mode and select between chr and icu, after upgrading with this patch applied the same command should get the responses from the install log and not require user intervention. The values can be seen written into misc/koha-install-log Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 20:48:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 18:48:26 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #46 from Galen Charlton --- I've spent a bit of time with the current patch series, and I've *not* been able to reproduce the problem where going to members/member.pl induced DataTables to try loading the entire patron database. Chris, Owen, could you try again? I'd be particularly interested to know exact browser versions if you're still encountering the problem. Looking at the code, I do see a place in C4/Utils/DataTables/Members.pm where some defensive coding is in order: my $limit; if(defined $dt_params->{iDisplayStart} and defined $dt_params->{iDisplayLength}) { # In order to avoir sql injection $dt_params->{iDisplayStart} =~ s/\D//g; $dt_params->{iDisplayLength} =~ s/\D//g; $limit = "LIMIT $dt_params->{iDisplayStart},$dt_params->{iDisplayLength}"; } The problem is that if iDisplayStart is never passed as a CGI parameter (because of a DataTables bug or some unrelated JavaScript bug interfering with the proper initialization of the DataTables object), the patron query will be unlimited. To avoid that, a LIMIT clause should *always* be added to the patron query, with sensible default values if iDisplayStart and/or iDisplayLength are not supplied. 0 and 20, respectively, I'd say. We may also want to consider hardcoding an absolute cap (say 100?) on iDisplayLength. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 20:53:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 18:53:36 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #47 from Galen Charlton --- (In reply to Jonathan Druart from comment #43) > Maybe the executing time issue is caused by the 2 COUNT(*) queries. But > since we don't want the "SELECT SQL_CALC_FOUND_ROWS" mysqlism, I don't know > how we can do that on a different way. And FWIW, even if we allowed the MySQLism, it might not actually be any faster than running two queries: http://www.mysqlperformanceblog.com/2007/08/28/to-sql_calc_found_rows-or-not-to-sql_calc_found_rows/ That blog post is pretty old, of course, so things may have changed, but benchmarking would be in order either way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 20:58:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 18:58:55 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #48 from Galen Charlton --- As a final comment, for the moment, I think it is best if merely going to the patron home page does not do a search -- retrieving 20 records isn't a huge performance hit, of course, but the first 20 records are very unlikely to be useful. It would be better to omit the search so that the search form can be rendered more quickly. This should be distinguished (by checking for POST vs. GET, presumably) from the case where the staff user intentionally does a blank patron search as a way of bringing up a list of all patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 21:05:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 19:05:50 +0000 Subject: [Koha-bugs] [Bug 8324] User created lists sort by title just after editing sort order (call by opac-shelves.pl without sort parameter) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 21:07:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 19:07:18 +0000 Subject: [Koha-bugs] [Bug 8324] Redisplay OPAC list with correct sort after edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|User created lists sort by |Redisplay OPAC list with |title just after editing |correct sort after edit |sort order (call by | |opac-shelves.pl without | |sort parameter) | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 21:10:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 19:10:41 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #49 from Galen Charlton --- I lied, one more comment: there is a minor but annoying change of behavior. Prior to the patch, if you start from the patron home page and do a search that retrieves a single hit, it automatically redirects to the details page for that patron. You can then use the back button to get back to the patrons home page. After the patch, the back button is effectively broken -- you can go back, but it will then immediately re-run the search and redirect you back to the patron record. It would be *really* nice if it didn't do that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 21:13:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 19:13:32 +0000 Subject: [Koha-bugs] [Bug 8324] Redisplay OPAC list with correct sort after edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 21:13:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 19:13:35 +0000 Subject: [Koha-bugs] [Bug 8324] Redisplay OPAC list with correct sort after edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 --- Comment #1 from Owen Leonard --- Created attachment 20280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20280&action=edit Bug 8324 - Redisplay OPAC list with correct sort after edit If you are viewing the contents of a list, edit it, change the default sort, and save your list will be redisplayed sorted by title no matter what default sort you chose. Lists do not automatically sort by their default sort, they must be opened with the sort parameter. This patch adds the list's sort parameter to the redirect after editing. To test, open an existing list in the OPAC which contains items. Click the "Edit list" link at the top of the list contents view. Change the default sort to something new. Click "Save." If the list is redisplayed using the new default sort the patch worked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 21:30:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 19:30:36 +0000 Subject: [Koha-bugs] [Bug 10714] New: Redirect to list contents view upon save after initiating edit from list contents view Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 Bug ID: 10714 Summary: Redirect to list contents view upon save after initiating edit from list contents view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Lists Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In the OPAC, if you edit a list from the list contents view you are redirected to the contents of that same list after you save your changes. In the staff client you are redirected back to the list of lists. The staff client interface should match the OPAC in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 21:35:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 19:35:12 +0000 Subject: [Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 21:35:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 19:35:17 +0000 Subject: [Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 --- Comment #1 from Owen Leonard --- Created attachment 20281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20281&action=edit Bug 10714 - Redirect to list contents view upon save after initiating edit from list contents view In the staff client, if you initiate a list edit from the list contents view you should be redirected to that same view after saving your changes. The OPAC already works this way. To test, view the contents of an existing list. Click the "Edit list" item under the "Edit" menu. Click save on the list edit form and you should be redirected back to the contents view of that list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 21:51:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 19:51:02 +0000 Subject: [Koha-bugs] [Bug 9798] Add html id to the Online Resources label of the OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9798 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |nengard at gmail.com Resolution|--- |FIXED --- Comment #3 from Nicole C. Engard --- This seems to be done in master already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 22:33:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 20:33:04 +0000 Subject: [Koha-bugs] [Bug 10059] admin user can't see budgets on acq page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10059 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- (In reply to Nicole C. Engard from comment #3) > The warning is good - and it should be there for the average user, but this > development has made it difficult as a company supporting libraries to > continue to support them. Wouldn't it suffice to create a normal superlibrarian account, but hang on to the root DB credentials in case you need to recreate the superlibrarian account? Also, the normal patron purge specifically excludes patron records whose category type is staff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 22:34:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 20:34:21 +0000 Subject: [Koha-bugs] [Bug 10059] admin user can't see budgets on acq page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10059 --- Comment #6 from Nicole C. Engard --- Well library staff can manually delete any users they want .. so they could (and probably will by accident) delete the user we don't want deleted. Of course we're creating users for this - I just think that it will effect other companies out there. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 22:52:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 20:52:34 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #5 from Galen Charlton --- Comment on attachment 19767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19767 Bug 10612 - Add ability to delete patrons with batch patron modification tool Review of attachment 19767: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10612&attachment=19767) ----------------------------------------------------------------- ::: tools/modborrowers.pl @@ +259,5 @@ > + { error => "fees_owed", borrower => $borrower } ); > + } > + else { > + MoveMemberToDeleted($borrowernumber); > + DelMember($borrowernumber); This is missing a call to C4::VirtualShelves::HandleDelBorrower. Also, with the proposed patron purging cronjob (bug 10419) also in play, I am getting concerned about the number of different places in the code that (a) check whether a patron record is allowed to be deleted and (b) do the deletion, particularly since the original patch series for bug 10419 had also missed HandleDelBorrower. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 23:08:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 21:08:44 +0000 Subject: [Koha-bugs] [Bug 10059] admin user can't see budgets on acq page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10059 --- Comment #7 from Chris Cormack --- (In reply to Nicole C. Engard from comment #6) > Well library staff can manually delete any users they want .. so they could > (and probably will by accident) delete the user we don't want deleted. Of > course we're creating users for this - I just think that it will effect > other companies out there. > > Nicole Catalyst is cool with it, we tell our clients not to delete the test/catalyst users. And we also ask them to create them. Works for us. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 12 23:40:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Aug 2013 21:40:53 +0000 Subject: [Koha-bugs] [Bug 10059] admin user can't see budgets on acq page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10059 --- Comment #8 from Galen Charlton --- (In reply to Chris Cormack from comment #7) > (In reply to Nicole C. Engard from comment #6) > > Well library staff can manually delete any users they want .. so they could > > (and probably will by accident) delete the user we don't want deleted. Of > > course we're creating users for this - I just think that it will effect > > other companies out there. [snip] > Catalyst is cool with it, we tell our clients not to delete the > test/catalyst users. And we also ask them to create them. Works for us. The current state of affairs works for Equinox as well. IOW, the support company I work for also sees no need to regularly use the DB credentials to log into Koha, particularly since the staff interface nowadays explicitly recommends against doing that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 04:13:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 02:13:22 +0000 Subject: [Koha-bugs] [Bug 10715] New: MARC21 007 Plugin Editor doesn't load position 01 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Bug ID: 10715 Summary: MARC21 007 Plugin Editor doesn't load position 01 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Currently, position 01 isn't loaded into the plugin editor for the 007 field in MARC21. This is because the template expects 1 character but the perl script is trying to pass in 4 characters. I can see no reason for this and when I do a git blame, it looks like this might be an accidental holdover from a past implementation of the plugin editor. If we switch the perl script to pass 1 character instead of 4, the plugin editor works as it should and I see no undesirable behaviours. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 04:21:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 02:21:04 +0000 Subject: [Koha-bugs] [Bug 10715] MARC21 007 Plugin Editor doesn't load position 01 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 04:21:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 02:21:08 +0000 Subject: [Koha-bugs] [Bug 10715] MARC21 007 Plugin Editor doesn't load position 01 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 --- Comment #1 from David Cook --- Created attachment 20282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20282&action=edit Bug 10715 - MARC21 007 Plugin Editor doesn't load position 01 This patch changes the MARC21 007 plugin editor so that it uses 1 character instead of 4 characters for position 01. TEST PLAN: 1) Create new record/edit an existing record 2) Using the tag editor for the 007 field, choose "Videorecording" 3) Click OK 4) Change the second character in the 007 from "c" to "d" 5) Open the tag editor again 6) Note that position 01 will still say "c - Videocartridge" rather than "d - Videodisc". 7) Exit tag editor 8) Apply patch 9) Reload the page (Shift + Refresh is always useful) 10) Open the tag editor again 11) Note that position 01 will now say "d - Videodisc" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 04:21:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 02:21:33 +0000 Subject: [Koha-bugs] [Bug 10715] MARC21 007 Plugin Editor doesn't load position 01 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 06:59:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 04:59:44 +0000 Subject: [Koha-bugs] [Bug 6223] Patron categories should have a default set of permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6223 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 07:01:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 05:01:26 +0000 Subject: [Koha-bugs] [Bug 6223] Patron categories should have a default set of permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6223 --- Comment #1 from David Cook --- I think that this is a great idea. I've recently had a library ask if this is a possibility, so it would be great to see this get into Koha. I have other priorities at the moment, but I would be happy to test any patches and maybe write my own sometime in the future. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 07:10:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 05:10:59 +0000 Subject: [Koha-bugs] [Bug 4456] Enable addition of PO Number to order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456 --- Comment #3 from Amit --- Created attachment 20283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20283&action=edit Enable addition of PO Number to order The ability to have a running purchase order sequence Test Plan: 1) Set systempreference EnablePONumber to Enable for auto generating purchase order number. 2) Select prefix for ex: Direct to requestor (Create PONUMPREFIX in authorized value and insert values). 3) Create an basket. 4) Create an order. 5) Select prefix value for ex: Direct to requestor. 6) Purchase order number will come in purchase order section for ex: DIR0000001. 7) Click on save button -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 07:11:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 05:11:11 +0000 Subject: [Koha-bugs] [Bug 4456] Enable addition of PO Number to order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 07:18:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 05:18:04 +0000 Subject: [Koha-bugs] [Bug 10530] PO number search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10530 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com --- Comment #1 from Amit --- Created attachment 20284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20284&action=edit PO number search Ability to search the purchase order Test plan: 1) Create an basket 2) Create an order 3) Click on order search link and click on plus symbol 4) Purchase order no input box will come give the no and click on sumbit 5) Click on Advance search link search order screen will appear enter value in the purcahse ordernumber textbox. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 07:18:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 05:18:17 +0000 Subject: [Koha-bugs] [Bug 10530] PO number search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10530 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 07:19:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 05:19:04 +0000 Subject: [Koha-bugs] [Bug 10531] Basket name and PO number on receipt screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com --- Comment #1 from Amit --- Created attachment 20285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20285&action=edit Basket name and PO number on receipt screen To list the basket name or PO number on the receipt screen to identify the lot that you are receiving Test Plan: 1) Create an basket 2) Create an order 3) Click on Receive shipment button enter vendor invoice no and shipment date click on Next button. 4) Basket name and Purchase order number will display both in pending and already receive screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 07:19:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 05:19:14 +0000 Subject: [Koha-bugs] [Bug 10531] Basket name and PO number on receipt screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 08:16:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 06:16:54 +0000 Subject: [Koha-bugs] [Bug 10059] admin user can't see budgets on acq page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10059 --- Comment #9 from Katrin Fischer --- We have to use personal admin accounts, so using the database user is out of question for us anyway. Libraries deleting those has never happened so far, we have notes and names that make it very clear that those belong to us and are not to be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 09:06:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 07:06:58 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 10:27:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 08:27:46 +0000 Subject: [Koha-bugs] [Bug 10712] Some values not saved in koha install log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10712 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 10:27:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 08:27:50 +0000 Subject: [Koha-bugs] [Bug 10712] Some values not saved in koha install log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10712 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20279|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 20286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20286&action=edit Bug 10712: Save missing config variables to install log The variables for AUTH_INDEX_MODE and ZEBRA_TOKENIZER were not being saved to the koha_install_log file. As a result when using the --prev-install-log option in Makefile.PL the user was still prompted to select them. This patch adds the appropriate variables to the list saved in the install log. To test: On a (non-package) system installed/upgraded without the patch running 'perl Makefile.PL --prev-install-log /path/to/koha-install-log' will still prompt you to choose authorities indexing mode and select between chr and icu, after upgrading with this patch applied the same command should get the responses from the install log and not require user intervention. The values can be seen written into misc/koha-install-log Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 10:32:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 08:32:01 +0000 Subject: [Koha-bugs] [Bug 10614] have add order form at top and bottom In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10614 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 10:32:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 08:32:05 +0000 Subject: [Koha-bugs] [Bug 10614] have add order form at top and bottom In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10614 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20270|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 20287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20287&action=edit Bug 10614 - have add order form at top and bottom If a basket has a lot of items it may be inconvenient to scroll to the bottom of the patch to reach the "add to basket" form. This patch adds as "Add to basket" button to the toolbar which uses JavaScript to copy the form into a modal dialog for quick access. To test, apply the patch and view an open basket. You should be able to click the "Add to basket" button to trigger a modal dialog with the full "Add to basket" list of options. All options in the list should function normally. If you view a closed basket the new button should not appear. Signed-off-by: Nicole C. Engard All tests pass and I love it :) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 11:05:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 09:05:47 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 11:05:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 09:05:51 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20251|0 |1 is obsolete| | --- Comment #12 from Chris Cormack --- Created attachment 20288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20288&action=edit Bug 8507: koha-create should be updated to use DOM indexing for bib This patch makes the koha-create script install the file zebra-biblios-dom.cfg with the proper string substitutions inside on the new instance koha-conf.xml file. It also adds two option switches that control the indexing mode for the instance: --biblio-idx {dom|grs1} --auth-idx {dom|grs1} DOM indexing is set as the default for both authorities and bibliographic records. Following drojf (thanks!) advise I arranged stuff like explained here: http://wiki.koha-community.org/wiki/Switching_to_dom_indexing To test: - Apply the patch - Build your own packages and install them on a test server a) Create a new instance without using the new switches like: $ koha-create --create-db domtest - Check there's a file /etc/koha/sites/domtest/zebra-biblios-dom.cfg - Check that /etc/koha/sites/domtest/koha-conf.xml points to: * zebra-biblios-dom.cfg (biblioserver section) * zebra-biblios-dom.cfg (publicserver section) * zebra-authorities-dom.cfg (authorityserver section) - Success means the new default is DOM b) Play with the 4 possible combination of option switches $ koha-create --create-db --auth-idx grs1 --biblio-idx grs1 domtest $ koha-create --create-db --auth-idx grs1 --biblio-idx dom domtest $ koha-create --create-db --auth-idx dom --biblio-idx grs1 domtest $ koha-create --create-db --auth-idx dom --biblio-idx dom domtest - Check the koha-conf.xml file reflects the chosen options. c) Run $ koha-create --help - It should advertise this addition accordingly. d) Run $ man koha-create - Man page for koha-create should provide good information on the new switches behaviour Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mirko Tietgen Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 11:06:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 09:06:06 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20263|0 |1 is obsolete| | --- Comment #13 from Chris Cormack --- Created attachment 20289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20289&action=edit Bug 8507: [SIGNEF OFF] Follow-Up: Fix path Fixed the path to __ZEBRA_BIBLIOS_CFG__ for Signed-off-by: Tomas Cohen Arazi Good catach drojf. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 11:56:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 09:56:00 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #50 from Jonathan Druart --- (In reply to Galen Charlton from comment #46) > I've spent a bit of time with the current patch series, and I've *not* been > able to reproduce the problem where going to members/member.pl induced > DataTables to try loading the entire patron database. Thanks for testing Galen! > To avoid that, a LIMIT clause should *always* be added to the patron query, > with sensible default values if iDisplayStart and/or iDisplayLength are not > supplied. 0 and 20, respectively, I'd say. > > We may also want to consider hardcoding an absolute cap (say 100?) on > iDisplayLength. Will be fixed, using 20 by default (like the DT default value). (In reply to Galen Charlton from comment #48) > As a final comment, for the moment, I think it is best if merely going to > the patron home page does not do a search -- retrieving 20 records isn't a > huge performance hit, of course, but the first 20 records are very unlikely > to be useful. It would be better to omit the search so that the search form > can be rendered more quickly. > > This should be distinguished (by checking for POST vs. GET, presumably) from > the case where the staff user intentionally does a blank patron search as a > way of bringing up a list of all patrons. Will be fixed too, the table will be hidden by default. (In reply to Galen Charlton from comment #49) > I lied, one more comment: there is a minor but annoying change of behavior. > > Prior to the patch, if you start from the patron home page and do a search > that retrieves a single hit, it automatically redirects to the details page > for that patron. You can then use the back button to get back to the > patrons home page. > > After the patch, the back button is effectively broken -- you can go back, > but it will then immediately re-run the search and redirect you back to the > patron record. > > It would be *really* nice if it didn't do that. It was a feature :) The goal was to display the same results using the back button. The former request already lead to the disappearance of this feature (with the side-effect too). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 11:56:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 09:56:32 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #51 from Jonathan Druart --- Created attachment 20290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20290&action=edit Bug 9811: A limit clause should be always added. By default, we want to retrieve 20 first results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 11:56:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 09:56:42 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #52 from Jonathan Druart --- Created attachment 20291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20291&action=edit Bug 9811: Load the page without any data. Displaying the first 20 patrons is not useful. With this patch, the table is hidden and no record is retrieved by default. On the same way, the existing side effect on redirect disappears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 12:02:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 10:02:33 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 12:10:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 10:10:58 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 --- Comment #6 from Jonathan Druart --- I think it is a great idea to have a dt.inc. But I disagree with the idea to duplicate files. Particularly if catalogue/detail.tt and tools/quotes.tt are not modified. I let someone else QA this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 12:19:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 10:19:26 +0000 Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 --- Comment #5 from Jonathan Druart --- (In reply to Galen Charlton from comment #4) > Comparing the acq.js with the new basketgroup.js reveals a bunch of diffs > like this: > > - var answer = confirm(MSG_CONFIRM_CLOSE_BASKETGROUP); > + var answer=confirm(_("Are you sure you want to close this > basketgroup?")); > > - alert(MSG_CLOSE_EMPTY_BASKET); > + alert(_("Why close an empty basket?")); > > - cantprint.innerHTML = MSG_SAVE_BEFORE_PRINTING; > + cantprint.innerHTML=_("You need to save the page before printing"); > > In other words, this patch effectively causes a partial regression on bug > 7598. > > Please try again; it may be better to start from scratch rather than to edit > the patch. It seems to be a merge error on the signed off patch. I will resubmit a new patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 12:19:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 10:19:43 +0000 Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 12:19:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 10:19:46 +0000 Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20235|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 20292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20292&action=edit Bug 10533: basketgroup js functions should in a separated js file This patch moves js functions used for managing basketgroup into a separated js file. Test plan: - Try all actions for basketgroup ( drag/drop, add, delete, close, print, reopen, edit, export as csv). - Check that there is no regression on others acquisition pages: * acqui/neworderempty.tt * acqui/uncertainprice.tt * acqui/addorderiso2709.tt * acqui/basketheader.tt * admin/aqbudgets.tt * admin/aqcontract.tt * admin/aqbudgetperiods.tt * admin/aqplan.tt * suggestion/suggestion.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 12:25:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 10:25:15 +0000 Subject: [Koha-bugs] [Bug 10716] New: The booksellers template generates a JS error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10716 Bug ID: 10716 Summary: The booksellers template generates a JS error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 5766 introduces a js error on acqui/basketgroup.tt because it is bad formed (does not include all datatable file). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 12:27:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 10:27:42 +0000 Subject: [Koha-bugs] [Bug 10716] The booksellers template generates a JS error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10716 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 12:27:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 10:27:46 +0000 Subject: [Koha-bugs] [Bug 10716] The booksellers template generates a JS error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10716 --- Comment #1 from Jonathan Druart --- Created attachment 20293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20293&action=edit Bug 10716: the basketgroup template does not include all datatables file. Go on acqui/basketgroup.tt and verify a js error occurred (ReferenceError: CONFIG_EXCLUDE_ARTICLES_FROM_SORT is not defined). Apply the patch and verify the error does not appear anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 12:28:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 10:28:29 +0000 Subject: [Koha-bugs] [Bug 10716] The booksellers template generates a JS error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10716 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m Blocks| |10533 Depends on| |5766 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 12:28:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 10:28:29 +0000 Subject: [Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10716 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 12:28:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 10:28:29 +0000 Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10716 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 13:02:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 11:02:11 +0000 Subject: [Koha-bugs] [Bug 6435] False "no items" in search results [intranet] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #17 from Fridolyn SOMERS --- (In reply to Doug Kingston from comment #16) > Created attachment 19710 [details] [review] Your patch is very odd. Did you create it with git format-patch ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 14:06:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 12:06:22 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20136|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 20294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20294&action=edit Bug 10419: (followup) fix license statement Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 14:06:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 12:06:29 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20137|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 20295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20295&action=edit Bug 10419: (follow-up) tidy names of command-line switches [1] Use --library instead of --branchcode to be consistent with other scripts and user-facing Koha terminology. [2] Use --not_borrowed_since instead of --not_borrowered_since; no need to expose typos in the API to the user. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 14:06:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 12:06:35 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20138|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 20296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20296&action=edit Bug 10419: (follow-up) functional improvements [1] Patron deletion now happens atomically; if one part of the process fails, the record isn't left in a partially deleted state. [2] The routine for handling lists properly during patron deletion is now invoked. [3] The script now prints an indication if it's run without --confirm; otherwise, one might think that patron records were actually being deleted. [4] --verbose now actually does something. Without --verbose, the script will print the dry-run warning (if applicable), the number of patrons to be deleted, and error messages. With --verbose, the script will also print a line with the borrowernumber of each patron to be deleted. To test: [1] Run the script with and without --verbose and compare the, well, verbosity. [2] Run the script without --confirm and note that the script prints a message saying that it's running in dry-run mode. [3] Use the script to try to delete one or more patrons that have loans. Confirm that error messages are printed reporting foreign constraints preventing the deletion. Also confirm that no new rows are added to deletedborrowers for those patrons that could not be completely deleted. [4] Use the script to delete a patron that has a public list. Verify that after the deletion, the public list still exists but now has a null owner. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 14:06:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 12:06:41 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #28 from Jonathan Druart --- Created attachment 20297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20297&action=edit Bug 10419: FIX hardcoded records and pod Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 14:48:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 12:48:16 +0000 Subject: [Koha-bugs] [Bug 10403] Add ability to set fund/budget on receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10403 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19050|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov --- Created attachment 20298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20298&action=edit Bug 10403: add ability to change fund on receipt Right now there is no way to change the budget or fund when receiving an item, which is annoying, particularly at the end of the fiscal year when every item not already received has to be switched to the following year's budget. This patch adds the ability to change the budget and fund when receiving. To test: 1) Apply patch. 2) Create an order for a vendor, choosing a fund to use for that order. 3) Receive the order, leaving the fund unchanged. Make sure the fund did not change. 4) Create another order for a vendor, choosing a fund to use for that order. 5) Receive the order, this time changing the fund. Make sure the fund is changed. 6) Run the unit test: > prove t/db_dependent/Acquisition.t 7) Sign off. (Notes: this patch depends on the Acquisitions.t unit test improvements in bug 10274; the seemingly-unrelated change in SQLHelper quiets an irritating warning caused by the NewOrder call in ModReceiveOrder) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 14:48:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 12:48:25 +0000 Subject: [Koha-bugs] [Bug 10403] Add ability to set fund/budget on receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10403 --- Comment #3 from Jared Camins-Esakov --- Created attachment 20299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20299&action=edit Bug 10403: Show inactive but unlocked budgets on orderreceive I have heard from several libraries that at the end of the budget year even though a budget is inactive for new acquisitions, an inactive budget should remain modifiable until the books are closed and the budget is marked inactive. This patch makes it so that all budgets that are unlocked are available on the order receipt page (only). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 14:51:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 12:51:42 +0000 Subject: [Koha-bugs] [Bug 10717] New: no way to sort search results in ccsr Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10717 Bug ID: 10717 Summary: no way to sort search results in ccsr Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org There is no way to use the search sort function on a mobile device with ccsr. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 14:54:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 12:54:44 +0000 Subject: [Koha-bugs] [Bug 10718] New: items with no checkouts report does not work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Bug ID: 10718 Summary: items with no checkouts report does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 8124 has commented the option to download results items with no checkouts report into a file. But the perl code of this page uses the export into a file has default behavior since the input "output" is no more present. The consequence is that there are never results in page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:04:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:04:44 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 --- Comment #1 from Owen Leonard --- I believe this is fixed by my patch for Bug 7478. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:10:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:10:14 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19180|0 |1 is obsolete| | Attachment #19182|0 |1 is obsolete| | Attachment #19360|0 |1 is obsolete| | Attachment #19362|0 |1 is obsolete| | --- Comment #69 from Jonathan Druart --- Created attachment 20300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20300&action=edit Bug 8367: Add more granular level for ReservesMaxPickUpDelay This patch adds: - a new column in the issuing rules - a new column reserves.maxpickupdate (+old_reserves) It contains the waitingdate + the corresponding max pickup delay. Each time the waitingdate is modified, this value will be modified too. - a new field issuingrules.holdspickupdelay This patch removes the ReservesMaxPickUpDelay syspref. The update database script will update the issuingrules table with the correct value before removing it. You can now specify a pickup delay for an hold function of a patron category and/or a item type and/or a library. To test: Check there is no regression with a normal reserve workflow. Add one or more issuingrules. Update the new column 'Holds pickup delay' in your issuing rules. In 4 templates, you can see the max pickup delay for an hold (circ/circulation.tt, circ/waitingreserves.tt, members/moremember.tt, opac-user.tt). According to a library and an item type, the maxpickupdate value will be equal to the waiting date + the pickup delay defined. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:11:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:11:03 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:11:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:11:08 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20300|0 |1 is obsolete| | --- Comment #70 from Jonathan Druart --- Created attachment 20301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20301&action=edit Bug 8367: Add more granular level for ReservesMaxPickUpDelay This patch adds: - a new column in the issuing rules - a new column reserves.maxpickupdate (+old_reserves) It contains the waitingdate + the corresponding max pickup delay. Each time the waitingdate is modified, this value will be modified too. - a new field issuingrules.holdspickupdelay This patch removes the ReservesMaxPickUpDelay syspref. The update database script will update the issuingrules table with the correct value before removing it. You can now specify a pickup delay for an hold function of a patron category and/or a item type and/or a library. To test: Check there is no regression with a normal reserve workflow. Add one or more issuingrules. Update the new column 'Holds pickup delay' in your issuing rules. In 4 templates, you can see the max pickup delay for an hold (circ/circulation.tt, circ/waitingreserves.tt, members/moremember.tt, opac-user.tt). According to a library and an item type, the maxpickupdate value will be equal to the waiting date + the pickup delay defined. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:11:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:11:16 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #71 from Jonathan Druart --- Created attachment 20302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20302&action=edit Bug 8367: Followup FIX a sql statement (bad conflict merge) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:11:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:11:22 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #72 from Jonathan Druart --- Created attachment 20303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20303&action=edit Bug 8367: Skip to next open day if max pickup date is a holiday Test plan: 1) Note your ReservesMaxPickUpDelay setting. 2) Create and trap a hold 3) View waitingreserves.pl, note the last pickup date, and the pickup location 4) Cancel this hold 5) Edit the calendar for the given location, and make the pickup date a holiday 6) Repeat step 2 7) View waitingreserves.pl, the last pickup date for this new hold should now be the increased by one day Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:11:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:11:28 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #73 from Jonathan Druart --- Created attachment 20304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20304&action=edit Bug 8367: Fix the maxpickupdate when we set waitingdate to NOW() ModReserveAffect get the maxpickupdate before changing the waitingdate to NOW. We should update the waitingdate and next calculate the maxpickupdate. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:12:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:12:09 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #74 from Jonathan Druart --- (In reply to Katrin Fischer from comment #68) > Hi Kyle, > there is a conflict in Reserves.pm I am not sure how to fix - could you take > a look please? I think it's because your patch for using reserve_id is in > now, so it might need a little work there. Conflicts solved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:33:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:33:08 +0000 Subject: [Koha-bugs] [Bug 10127] Printoverdues.sh should tar only pdf files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10127 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #12 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:33:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:33:59 +0000 Subject: [Koha-bugs] [Bug 10563] Link to edit subscription from 'check expiraton' page is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10563 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:36:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:36:09 +0000 Subject: [Koha-bugs] [Bug 10246] OPAC items table CSS classes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10246 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #5 from Bernardo Gonzalez Kriegel --- 3.10 patch pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:36:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:36:28 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:36:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:36:54 +0000 Subject: [Koha-bugs] [Bug 10566] Improve OPAC course reserves pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:43:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:43:49 +0000 Subject: [Koha-bugs] [Bug 10719] New: UT GetUpcomingDueIssues Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10719 Bug ID: 10719 Summary: UT GetUpcomingDueIssues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org C4::Circulation::GetUpcomingDueIssues needs some unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:47:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:47:13 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:47:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:47:39 +0000 Subject: [Koha-bugs] [Bug 10719] UT GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10719 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:47:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:47:48 +0000 Subject: [Koha-bugs] [Bug 10719] UT GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10719 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 20305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20305&action=edit Bug 10719 - UT GetUpcomingDueIssues Some unit tests related to Bug 9362. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:48:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:48:09 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:48:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:48:43 +0000 Subject: [Koha-bugs] [Bug 10719] UT GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10719 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9362 Depends on| |10663 Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:48:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:48:43 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10719 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:48:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:48:43 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10719 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:49:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:49:46 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:50:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:50:06 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #2 from Fridolyn SOMERS --- Created attachment 20306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20306&action=edit Bug 10718 - items with no checkouts report does not work Main patch, see commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:50:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:50:31 +0000 Subject: [Koha-bugs] [Bug 10591] Why do we allow holds on restricted items (952$5=Use restrictions)? Place a hold for reference? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10591 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:50:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:50:41 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 --- Comment #3 from Fridolyn SOMERS --- Created attachment 20307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20307&action=edit Bug 10718 - select user branch as default Followup 1 : select user branch as default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:50:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:50:48 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:51:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:51:07 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |/cgi-bin/koha/reports/catal | |ogue_out.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:52:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:52:11 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 --- Comment #4 from Fridolyn SOMERS --- Created attachment 20308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20308&action=edit Bug 10718 - items with no checkouts report permission is execute_reports Follow-up 2 : page permissions are too strong, set to reports/execute_reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:53:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:53:14 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 --- Comment #5 from Fridolyn SOMERS --- Created attachment 20309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20309&action=edit Bug 10718 - redefine limit input Followup 3 : redefine limit input to avoid huge results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:53:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:53:48 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 --- Comment #6 from Fridolyn SOMERS --- Created attachment 20310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20310&action=edit Bug 10718 - perltidy on reports/catalogue_out.pl Followup 4 : perltidy on reports/catalogue_out.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:56:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:56:34 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:56:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:56:43 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7478 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:56:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:56:43 +0000 Subject: [Koha-bugs] [Bug 7478] Template/translation problem in catalogue_out.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10718 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:57:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:57:31 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 --- Comment #7 from Fridolyn SOMERS --- (In reply to Owen Leonard from comment #1) > I believe this is fixed by my patch for Bug 7478. This is a correct solution, but isn't it better to remove the obsolete code ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:57:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:57:30 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Summary|query in |MySQLism in |GetUpcomingDueIssues |GetUpcomingDueIssues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:58:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:58:48 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 15:59:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 13:59:00 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 20311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20311&action=edit Bug 10606: Remove MySQLism in GetUpcomingDueIssues Removing this mysqlism as Galen proposed. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:00:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:00:00 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10719 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:00:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:00:00 +0000 Subject: [Koha-bugs] [Bug 10719] UT GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10719 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10606 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:04:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:04:23 +0000 Subject: [Koha-bugs] [Bug 10702] can't create notices for a specific branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10702 --- Comment #1 from Nicole C. Engard --- Is this the same as what's fixed in bug 10439 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:04:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:04:37 +0000 Subject: [Koha-bugs] [Bug 10439] Cannot modify the notice's library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10439 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:06:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:06:41 +0000 Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:08:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:08:45 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:13:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:13:49 +0000 Subject: [Koha-bugs] [Bug 9238] fund pull down says 'select budget' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:13:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:13:51 +0000 Subject: [Koha-bugs] [Bug 9238] fund pull down says 'select budget' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 --- Comment #1 from Owen Leonard --- Created attachment 20312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20312&action=edit Bug 9238 - fund pull down says 'select budget' When adding a new order to a basket the fund selection field is labeled "Fund:" but the default option is "Select a budget." This patch changes this string to "Select a fund" and also corrects the associated JavaScript error message text displayed when one doesn't choose a fund. To test, add an order to basket. The "New order" form should show "Select a fund" as the default option for "Fund" in the "Accounting details" section. If you submit the form without selecting a fund the error message should read "You must select a fund." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:14:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:14:56 +0000 Subject: [Koha-bugs] [Bug 10712] Some values not saved in koha install log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10712 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:19:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:19:32 +0000 Subject: [Koha-bugs] [Bug 10614] have add order form at top and bottom In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10614 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:23:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:23:12 +0000 Subject: [Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:25:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:25:42 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #52 from Jonathan Druart --- (In reply to Katrin Fischer from comment #50) Katrin, thank you for your patch! I will submit 2 patchs. 1 fixes the checkboxes issues, the other allow the translation for csv headers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:26:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:26:17 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19819|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart --- Created attachment 20313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20313&action=edit Bug 7298: Follow-up fixing capitalization and moving supplier id Fixes a few capitalization errors on the late orders page like - Claim orders - filter - Search results Also moves the supplierid from the order date column to the vendor column. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:26:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:26:26 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #54 from Jonathan Druart --- Created attachment 20314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20314&action=edit Bug 7298: FIX checkboxes binding on load Click on checkboxes should be bound on load. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:26:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:26:33 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #55 from Jonathan Druart --- Created attachment 20315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20315&action=edit Bug 7298: CSV strings are translatables. Using a template file, the CSV headers become translatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:27:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:27:06 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:38:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:38:20 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #14 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:54:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:54:04 +0000 Subject: [Koha-bugs] [Bug 9706] xslt icon for artifacts isn't quite right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9706 --- Comment #1 from Owen Leonard --- Right now the label for $leader6='g' or $leader6='k' or $leader6='r' is "Visual material." Is that label one which is defined by MARC somewhere? If we add an icon specifically for 'Three-dimensional artifact or naturally occurring object' should that be the corresponding label? Or is there a more succinct label we could use? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:54:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:54:12 +0000 Subject: [Koha-bugs] [Bug 10304] Add avanced search filter for "not for loan" items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:56:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:56:18 +0000 Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts, overdues, and holds on the patron summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:59:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:59:11 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19150|0 |1 is obsolete| | Attachment #19151|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 20316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20316&action=edit Bug 9043: Syspref improvement: add new type "multiple" This patch adds a new type "multiple" for syspref. This new type allows to select several values for one syspref. http://bugs.koha-community.org/show_bug.cgi?id=9456 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:59:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:59:18 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #22 from Jonathan Druart --- Created attachment 20317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20317&action=edit Bug 9043: Changes to the advanced search page New syspref: OpacAdvSearch. This syspref is multivalued and you can add or remove some elements on the adv search page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:59:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:59:26 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #23 from Jonathan Druart --- Created attachment 20318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20318&action=edit Bug 9043: Add the dropdown check list jquery plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:59:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:59:40 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 16:59:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 14:59:54 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20316|Bug 9043: Syspref |[ALT 1/2] Bug 9043: Syspref description|improvement: add new type |improvement: add new type |"multiple" |"multiple" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 17:00:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 15:00:06 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20317|Bug 9043: Changes to the |[ALT 2/3] Bug 9043: Changes description|advanced search page |to the advanced search page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 17:00:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 15:00:14 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20318|Bug 9043: Add the dropdown |[ALT 3/3] Bug 9043: Add the description|check list jquery plugin |dropdown check list jquery | |plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 17:00:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 15:00:30 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20316|[ALT 1/2] Bug 9043: Syspref |[ALT 1/3] Bug 9043: Syspref description|improvement: add new type |improvement: add new type |"multiple" |"multiple" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 17:01:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 15:01:58 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #24 from Jonathan Druart --- (In reply to Kyle M Hall from comment #20) > Jonathan, your patches work quite well, but there is no way to disable all > the options at once. When I deslect them all, and hit the save button, I get > the "Nothing to save" message. > > Not required, but it might be nice to implement something like > https://code.google.com/p/dropdown-check-list/ as a fair number of people > may not know about ctrl-click to select/deselect individual items. Thank for the idea, done! I cannot reproduce your issue, but should be fixed by the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 17:20:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 15:20:18 +0000 Subject: [Koha-bugs] [Bug 8074] Holds to pull In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074 --- Comment #1 from Owen Leonard --- Fridolyn, are you working on this? I would think it would make sense to either have the user select a library before displaying the results or filter by default on the logged-in user's branch. Then you could offer a non-JavaScript filter in the sidebar if the user wanted to resubmit with a different library selection (or to show all libraries). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 17:21:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 15:21:09 +0000 Subject: [Koha-bugs] [Bug 8074] Define default library for holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds to pull |Define default library for | |holds to pull report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 17:22:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 15:22:39 +0000 Subject: [Koha-bugs] [Bug 6223] Patron categories should have a default set of permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6223 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 17:26:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 15:26:45 +0000 Subject: [Koha-bugs] [Bug 7504] cannot put a comma in a price when adding a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7504 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master Assignee|henridamien at koha-fr.org |koha-bugs at lists.koha-commun | |ity.org Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 17:29:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 15:29:14 +0000 Subject: [Koha-bugs] [Bug 9238] fund pull down says 'select budget' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20312|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 20319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20319&action=edit [SIGNED-OFF] Bug 9238 - fund pull down says 'select budget' When adding a new order to a basket the fund selection field is labeled "Fund:" but the default option is "Select a budget." This patch changes this string to "Select a fund" and also corrects the associated JavaScript error message text displayed when one doesn't choose a fund. To test, add an order to basket. The "New order" form should show "Select a fund" as the default option for "Fund" in the "Accounting details" section. If you submit the form without selecting a fund the error message should read "You must select a fund." Signed-off-by: Nicole C. Engard tests pass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 17:30:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 15:30:43 +0000 Subject: [Koha-bugs] [Bug 9238] fund pull down says 'select budget' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 17:49:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 15:49:21 +0000 Subject: [Koha-bugs] [Bug 10720] New: Substitution term in overdue notices shouldn't be removed even if they don't match Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720 Bug ID: 10720 Summary: Substitution term in overdue notices shouldn't be removed even if they don't match Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: sophie.meynieux at biblibre.com QA Contact: testopia at bugs.koha-community.org In overdue notices we use some text enclosed by << >> or < > for substitution. At the end of the process, if some of this text still remains, a warn is printed in logfile and the remaining substitution is erased. This procedure prevents to use html tag in notices, needed to format display with css for example. If a susbstitution text does not match any valid term and is not a valid html tag, it should be corrected notice template itself (and warn help to do this) but not systematically deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 18:05:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 16:05:18 +0000 Subject: [Koha-bugs] [Bug 8074] Define default library for holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074 --- Comment #2 from Fridolyn SOMERS --- (In reply to Owen Leonard from comment #1) I'm not working on it yet. > you could offer a non-JavaScript filter in the sidebar Yes, good idea, with a GET form to allow the bookmarking of the URL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 18:18:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 16:18:08 +0000 Subject: [Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Galen Charlton --- Pushed to master, along with a follow-up. Thanks, Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 18:22:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 16:22:12 +0000 Subject: [Koha-bugs] [Bug 10720] Substitution term in overdue notices shouldn't be removed even if they don't match In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720 --- Comment #1 from Sophie MEYNIEUX --- Created attachment 20320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20320&action=edit Bug 10720 : substitution term in overdue notices shouldn't be removed if they don't match. It prevents use of html in notices to use with css Test plan : - define an overdue notice containing some valid substitution terms + some valid html tags ( or
Without patch, your html tags are missing in your html file With the patch, they are present and can be used with a css to generate a formatted pdf file. If you add some invalid substitution term, with the patch, they are still in the final letter, but the warn in the log helps you to correct your notice template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 18:22:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 16:22:39 +0000 Subject: [Koha-bugs] [Bug 10720] Substitution term in overdue notices shouldn't be removed even if they don't match In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 18:23:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 16:23:07 +0000 Subject: [Koha-bugs] [Bug 10720] Substitution term in overdue notices shouldn't be removed even if they don't match In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6030 Assignee|koha-bugs at lists.koha-commun |sophie.meynieux at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 18:23:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 16:23:07 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10720 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 18:29:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 16:29:45 +0000 Subject: [Koha-bugs] [Bug 10081] IndependentBranches error message missing the library name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Summary|HomeOrHoldingBranch error |IndependentBranches error |missing a library name |message missing the library | |name --- Comment #1 from Owen Leonard --- I can't tell what HomeOrHoldingBranch has to do with this bug. I can only trigger the error if IndependentBranches is on and I'm checking out an item from another branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 18:40:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 16:40:53 +0000 Subject: [Koha-bugs] [Bug 10081] IndependentBranches error message missing the library name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 18:41:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 16:41:00 +0000 Subject: [Koha-bugs] [Bug 10081] IndependentBranches error message missing the library name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 --- Comment #2 from Owen Leonard --- Created attachment 20321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20321&action=edit Bug 10081 - IndependentBranches error message missing the library name With IndependentBranches turned on, if you try to check out an item which belongs to another library you will get an error message which is missing the library name. This patch corrects the problem by passing the necessary variable to the template and outputting the library name using the KohaBranchName TT plugin. To test, turn on IndependentBranches and try to check out an item belonging to another library (note that you must test with a staff user who is not a superlibrarian). The error message you see should include the name of the library to which the item belongs: "This item belongs to Nelsonville and cannot be checked out from this location." Checkouts of items belonging to the library should be unaffected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 18:46:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 16:46:24 +0000 Subject: [Koha-bugs] [Bug 10515] The prototype for GetBranchCategory and GetBranchCategories is not consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch (along with Galen's regression tests) has been pushed to 3.12.x, will be in 3.12.4. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 18:47:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 16:47:47 +0000 Subject: [Koha-bugs] [Bug 10541] Enable cross-browser AJAX in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10541 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 18:52:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 16:52:00 +0000 Subject: [Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Mirko! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 18:53:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 16:53:57 +0000 Subject: [Koha-bugs] [Bug 8474] Holds done by librarians cause silent errors in koha-error_log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8474 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master --- Comment #1 from Owen Leonard --- This bug still affects master, but the patch isn't formatted correctly to even try to apply. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 18:56:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 16:56:17 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 20:46:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 18:46:30 +0000 Subject: [Koha-bugs] [Bug 8238] Hold limits broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8238 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4045 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 20:46:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 18:46:30 +0000 Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8238 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 20:48:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 18:48:52 +0000 Subject: [Koha-bugs] [Bug 10721] New: Improve DataTables configuration on transfers to receive report Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10721 Bug ID: 10721 Summary: Improve DataTables configuration on transfers to receive report Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/transferstoreceive.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The transfers to receive report could take advantage of the new sorting configuration options which allow format-agnostic date sorting and title sorting which excludes articles. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 20:58:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 18:58:14 +0000 Subject: [Koha-bugs] [Bug 10721] Improve DataTables configuration on transfers to receive report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10721 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 20:58:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 18:58:19 +0000 Subject: [Koha-bugs] [Bug 10721] Improve DataTables configuration on transfers to receive report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10721 --- Comment #1 from Owen Leonard --- Created attachment 20322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20322&action=edit Bug 10721 - Improve DataTables configuration on transfers to receive report I noticed this template used a hidden span to allow correct sorting of titles--a relic of the previous table sorting plugin. I have removed that and added an improved DataTables configuration. To test apply the patch and view the transfers to receive report for a library which has multiple transfers to receive. Sorting should work correctly on all columns, including correct date sorting regardless of dateformat system preference. Title sorting should correctly exclude articles. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 21:16:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 19:16:35 +0000 Subject: [Koha-bugs] [Bug 5345] DataTables in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #67 from Owen Leonard --- I'm marking this fixed because the staff client now has wide use of DataTables, with all pages (with the exception of the cart, Bug 9456) having been converted from the old tablesorter plugin. Future enhancements using DataTables can get their own individual bug reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 21:16:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 19:16:37 +0000 Subject: [Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 Bug 7163 depends on bug 5345, which changed state. Bug 5345 Summary: DataTables in Koha http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 21:16:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 19:16:37 +0000 Subject: [Koha-bugs] [Bug 7647] Checkout History Sort In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7647 Bug 7647 depends on bug 5345, which changed state. Bug 5345 Summary: DataTables in Koha http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 21:23:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 19:23:06 +0000 Subject: [Koha-bugs] [Bug 9959] Filters for 'Most popular' page in OPAC show wrong behaviour In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9959 --- Comment #1 from Owen Leonard --- I can't reproduce 1). 2) and 3) I think should be fixed by Bug 10588. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 21:27:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 19:27:29 +0000 Subject: [Koha-bugs] [Bug 5316] Limit Z39.50 targets to specific users In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5316 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Limit 39.50 targets to |Limit Z39.50 targets to |specific users |specific users -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 22:00:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 20:00:23 +0000 Subject: [Koha-bugs] [Bug 6645] attaching items loses hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6645 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 8723 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 13 22:00:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Aug 2013 20:00:23 +0000 Subject: [Koha-bugs] [Bug 8723] holds don't transfer when moving items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 --- Comment #8 from Owen Leonard --- *** Bug 6645 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 02:59:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 00:59:54 +0000 Subject: [Koha-bugs] [Bug 10720] Substitution term in overdue notices shouldn't be removed even if they don't match In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720 Derryn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |derrynj at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 03:24:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 01:24:11 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 --- Comment #5 from Srdjan Jankovic --- I got 414 with the current script (master a36b3ad43a6a91f800d0d8a148a217d738236d7e), and 416 with the patch. Can you please check, and if you don't get the same I'll dump and compare. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 03:40:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 01:40:02 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 --- Comment #9 from Srdjan Jankovic --- # Testing Batch->new() method. # Testing Batch->get_attr() method. # Testing Batch->add_item() method. Use of uninitialized value $encoding in string eq at C4/Biblio.pm line 3281. Use of uninitialized value $encoding in pattern match (m//) at C4/Biblio.pm line 3301. # Testing Batch->retrieve() method. # Failed test at t/db_dependent/Labels/t_Batch.t line 100. # Structures begin differing at: # $got = '-2' # $expected = C4::Labels::Batch=HASH(0x2df33c0) # Retrieved batch object FAILED to verify. # Testing Batch->remove_item() method. # Failed test at t/db_dependent/Labels/t_Batch.t line 108. # Structures begin differing at: # $got = '-2' # $expected = C4::Labels::Batch=HASH(0x2df33c0) # Updated batch object FAILED to verify. # Testing Batch->delete() method. # Looks like you planned 24 tests but ran 14. # Looks like you failed 2 tests of 14 run. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 07:26:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 05:26:16 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 08:33:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 06:33:54 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 --- Comment #46 from David Cook --- Maybe it's worth teasing apart what needs to happen here... Architecture: 1) Add nonpublicnote to the items and deleteditems tables for all installs using updatebase.pl (it shouldn't matter if the column is in the items table for old installs). 2) Change kohastructure and default framework SQL so that new installs map 952$x (and the other flavour equivalents) to the nonpublicnote DB column. Display (Show on): 1) detail page 2) moredetail page 3) circulation pages 4) returns pages 5) serial collections pages? Utilities: 1) Iterate through all frameworks -> If a mapping for item Non-public note is found, copy the data into the nonpublicnote column. -> If no mapping is found, use the subfield in the framework (probably X) to interrogate the more_subfield_xml for an element with that subfield, and copy that data into the publicnote column. 2) Set the mapping for all frameworks for Non-public note to nonpublicnote DB column. -- Concerns: When iterating through the frameworks, we need to have a way of defining the entry for which we're looking. I don't think it's enough to look for the string "Non-public note" as that might be changed (or translated?). Is it enough to look for the 952$x? This probably only applies to MARC21 so we'll need to take into account the other marc tags used for the other MARC flavours. It might be an idea to make the utility interactive to make sure that the 952$x (or whatever) is the right framework entry to be analyzing...although if the script is interactive, it might make it more difficult for some people to do upgrades. Thoughts anyone? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 08:35:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 06:35:31 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 --- Comment #47 from David Cook --- Another idea would be to just parse the data from more_subfields_xml (rather than changing the architecture of the database), but I think that would bring us back to the possibility that we might not necessarily know for sure that 952$x is always the MARC21 field/subfield for the non-public note. I'd be happy for someone to prove me wrong on that one though, as that might just be the easiest way to do this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 09:27:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 07:27:05 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20275|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 20323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20323&action=edit iBug 10610: sysprefs.sql should be sorted by syspref names By sorting the sql syspref file, the developpers will be happy to avoid conflicts on this file each time a patch modifying it is pushed. Test plan: - create a new DB with a new table named systempreferences (with the same structure as the one you know). - insert the current sysprefs.sql file into this table. - note the number of rows in the systempreferences table. - apply this patch. - delete all rows of the systempreferences table. - insert the new sysprefs.sql file. - verify the number of rows is the same as the previous. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 09:28:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 07:28:01 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 --- Comment #7 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #5) > I got 414 with the current script (master > a36b3ad43a6a91f800d0d8a148a217d738236d7e), and 416 with the patch. Can you > please check, and if you don't get the same I'll dump and compare. Oops, I suspect I was not on master when I generate the file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 09:36:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 07:36:27 +0000 Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 09:40:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 07:40:33 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 --- Comment #10 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #9) > Use of uninitialized value $encoding in string eq at C4/Biblio.pm line 3281. > Use of uninitialized value $encoding in pattern match (m//) at C4/Biblio.pm > line 3301. I have no idea where is the problem. But there 2 lines intrigues me. $encoding is C4::Context->preference("marcflavour"). Don't you have the marcflavour syspref in your DB? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:42:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:42:18 +0000 Subject: [Koha-bugs] [Bug 10722] New: The log in bar "Log in to your account" floats incorrectly in the middle of the page on iPhone Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10722 Bug ID: 10722 Summary: The log in bar "Log in to your account" floats incorrectly in the middle of the page on iPhone Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: Other Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: viktor.sarge at regionhalland.se QA Contact: testopia at bugs.koha-community.org Created attachment 20324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20324&action=edit Screenshot of how 3.13 looks in Safari on iPhone 5 and 4S The bar to log into ones account in Opac floats inccorectly at the middle of the page overlaying the content. It seems to occur at least on Koha 3.12 and 3.13 in Safari running on iPhone 4S and iPhone 5. The 3.12 release has had some CSS-modifications but it also occurs on 3.13 updated daily with the latest code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:51:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:51:52 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #30 from Jonathan Druart --- (In reply to Katrin Fischer from comment #29) > I have spent some time looking at those patches and I am worried that they > try to do too many things. I think i have identified what they do, but I am > not sure (which is not a good sign :) ). I think we have 3 things here, that > ideally should be broken up into 3 different bugs to make this easier > testable: > > - Merging GetPendingOrders and GetOrders + regression tests > - Adding basket group name search > - Adding datatables to the pending oders page > > Jonathan, do you think you could break it up on different bugs with test > plans for each? The 3 patchs can be tested together so I don't think it is relevant, but I will do that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:53:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:53:02 +0000 Subject: [Koha-bugs] [Bug 10723] New: GetPendingOrders and SearchOrders can be merged Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723 Bug ID: 10723 Summary: GetPendingOrders and SearchOrders can be merged Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org There two routines does the same thing. They can be merge into one routine and improved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:53:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:53:25 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10723 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:53:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:53:25 +0000 Subject: [Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |10124 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:54:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:54:23 +0000 Subject: [Koha-bugs] [Bug 10724] New: Search by basket group on the parcel page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724 Bug ID: 10724 Summary: Search by basket group on the parcel page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:54:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:54:46 +0000 Subject: [Koha-bugs] [Bug 10724] Search by basket group on the parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |10124 Depends on| |10723 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:54:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:54:46 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10724 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:54:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:54:46 +0000 Subject: [Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10724 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:56:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:56:21 +0000 Subject: [Koha-bugs] [Bug 10725] New: Add filters on the pending orders table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725 Bug ID: 10725 Summary: Add filters on the pending orders table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Datatable allows to easily adds filters on the table headers. It would be great to have them on the pending orders table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:56:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:56:58 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10725 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:56:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:56:58 +0000 Subject: [Koha-bugs] [Bug 10725] Add filters on the pending orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED URL| |acqui/parcel.pl Blocks| |10124 Depends on| |10724 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:56:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:56:58 +0000 Subject: [Koha-bugs] [Bug 10724] Search by basket group on the parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10725 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:58:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:58:22 +0000 Subject: [Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723 --- Comment #1 from Jonathan Druart --- Created attachment 20325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20325&action=edit Bug 10723: Merge GetPendingOrders and SearchOrders routines In the C4::Acquisition module, 2 routines do the same work. This patch merges these 2 routines. Test plan: test the acqui/orderreceive.pl, acqui/uncertainprice.pl and serials/acqui-search-result.pl, acqui/parcel.pl scripts. Note: on acqui/parcel the basket filter is a search on basket name (was on basket id, which was not relevant). Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:58:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:58:37 +0000 Subject: [Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 10:58:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 08:58:44 +0000 Subject: [Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 11:00:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 09:00:04 +0000 Subject: [Koha-bugs] [Bug 10724] Search by basket group on the parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724 --- Comment #1 from Jonathan Druart --- Created attachment 20326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20326&action=edit Bug 10724: Pending orders: add basket group name in filters This patch adds a new filter "basket group name" for pending orders searches. Test plan: Try different filters and check that results are consistent. Try to filter by basket group name. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 11:00:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 09:00:26 +0000 Subject: [Koha-bugs] [Bug 10724] Search by basket group on the parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff URL| |acqui/parcel.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 11:00:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 09:00:31 +0000 Subject: [Koha-bugs] [Bug 10724] Search by basket group on the parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 11:01:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 09:01:20 +0000 Subject: [Koha-bugs] [Bug 10725] Add filters on the pending orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725 --- Comment #1 from Jonathan Druart --- Created attachment 20327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20327&action=edit Bug 10725: Add filters on the pending orders table Since the parcel.pl script get *all* pending orders, there is no reason not to display all of them. Like that, DataTable manages pagination and sorting correctly (on all data). This patch adds filters on the table header (using columnFilter). Test plan: Try filters on the left of the screen and filters on the table header. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 11:01:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 09:01:30 +0000 Subject: [Koha-bugs] [Bug 10725] Add filters on the pending orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 11:01:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 09:01:35 +0000 Subject: [Koha-bugs] [Bug 10725] Add filters on the pending orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 11:02:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 09:02:54 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |MOVED --- Comment #31 from Jonathan Druart --- Please see bug 10723, bug 10724 and bug 10725. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 11:17:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 09:17:46 +0000 Subject: [Koha-bugs] [Bug 10726] New: Default Unimarc framework in accordance with new edition of the Unimarc manual Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726 Bug ID: 10726 Summary: Default Unimarc framework in accordance with new edition of the Unimarc manual Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: sonia.lemaire at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl On November 4th 2013, bibliographic and authorities unimarc formats will change. Default unimarc frameworks should be adapted to these changes. Affected fields for Unimarc/ Biblio: - 205$d and 208$d generate "=" - 4XX$t is repeatable - 501: new subfields $m and $r added - 503: new subfield $o - 510, 512, 513, 514, 515, 516, 517, 518, 520, 540: new subfield $n - 545: new subfields $e $h $i $j $n $z - 930: new subfields $w and $z Affected fields for Unimarc/ Authorities - 033: new field (Thoses changes are also needed for versions 3.08 and 3.10) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 11:19:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 09:19:00 +0000 Subject: [Koha-bugs] [Bug 10726] Default Unimarc framework in accordance with new edition of the Unimarc manual In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726 Sonia Lemaire changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |sonia.lemaire at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 11:29:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 09:29:08 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart --- QA comment: 1/ The screen is not obvious: Last borrowed:14/08/2013 Last returned by: 23529001223640 Last borrower: 23529001223640 Previous borrower: 23529001223641 The "last returned by" and the "last borrower" is the same value when AnonymousPatron is not in use. 2/ Could you use the template plugin to get the syspref value (rather than to pass it from the pl script). Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 11:37:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 09:37:55 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from Jonathan Druart --- Kyle, the js error still occurred. To reproduce: - open firebug on the console tab - go to tools/tools-home.pl - click on the "Staged MARC record management" link caused by tools/manage-marc-import.tt l. 49: aoData.push( { "name": "import_batch_id", "value": [% import_batch_id %] } ); The import_batch_id var is not defined on this view. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 15:29:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 13:29:57 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 15:30:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 13:30:00 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #27 from Kyle M Hall --- Created attachment 20328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20328&action=edit Bug 10558 [QA Follow-up 2] - Fix JavaScript Error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 15:47:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 13:47:21 +0000 Subject: [Koha-bugs] [Bug 10727] New: Replace carriage return with
when writing hold notices Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Bug ID: 10727 Summary: Replace carriage return with
when writing hold notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: sophie.meynieux at biblibre.com QA Contact: testopia at bugs.koha-community.org This patch replaces carriage return with
in the content of hold notices for printing. This is necessary to convert html file into well formatted pdf file. Test plan : - return an item reserved by a borrower that has not activated email notification - verify in message_queue table that you've got a new HOLD_PRINT notice with status 'pending' - run gather_print_notices.pl Without the patch, the script generates a html file without
tags. If you run printoverdues.sh , the text in the resulting pdf file is all on one line With the patch, the script generates a html file with
tags and pdf file created by printoverdues.sh is well formatted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 15:47:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 13:47:35 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 15:47:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 13:47:38 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #18 from Kyle M Hall --- Created attachment 20329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20329&action=edit Bug 9011 - QA Followup * Use template plugin to get syspref values * Hide "last returned by" if AnonymousPatron is not set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 15:54:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 13:54:49 +0000 Subject: [Koha-bugs] [Bug 10727] Replace carriage return with
when writing hold notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 --- Comment #1 from Sophie MEYNIEUX --- Created attachment 20330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20330&action=edit Bug 10727 : Replace carriage return with
when printing hold notices This patch replaces carriage return with
in the content of hold notices for printing. This is necessary to convert html file into well formatted pdf file. Test plan : - checkin an item reserved by a borrower that has not activated email notification - verify in message_queue table that you've got a new HOLD_PRINT notice with status 'pending' - run gather_print_notices.pl Without the patch, the script generates a html file without
tags. If you run printoverdues.sh , the text in the resulting pdf file is all on one line With the patch, the script generates a html file with
tags and pdf file created by printoverdues.sh is well formatted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 15:55:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 13:55:08 +0000 Subject: [Koha-bugs] [Bug 10727] Replace carriage return with
when writing hold notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |sophie.meynieux at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 15:55:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 13:55:23 +0000 Subject: [Koha-bugs] [Bug 10727] Replace carriage return with
when writing hold notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6030 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 15:55:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 13:55:23 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10727 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:15:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:15:55 +0000 Subject: [Koha-bugs] [Bug 10081] IndependentBranches error message missing the library name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:15:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:15:58 +0000 Subject: [Koha-bugs] [Bug 10081] IndependentBranches error message missing the library name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20321|0 |1 is obsolete| | --- Comment #3 from Galen Charlton --- Created attachment 20331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20331&action=edit Bug 10081: add library name to IndependentBranches error message With IndependentBranches turned on, if you try to check out an item which belongs to another library you will get an error message which is missing the library name. This patch corrects the problem by passing the necessary variable to the template and outputting the library name using the KohaBranchName TT plugin. To test, turn on IndependentBranches and try to check out an item belonging to another library (note that you must test with a staff user who is not a superlibrarian). The error message you see should include the name of the library to which the item belongs: "This item belongs to Nelsonville and cannot be checked out from this location." Checkouts of items belonging to the library should be unaffected. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:21:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:21:54 +0000 Subject: [Koha-bugs] [Bug 10728] New: subscription-renew generates unnecessary warnings in logs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728 Bug ID: 10728 Summary: subscription-renew generates unnecessary warnings in logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com subscription-renew.pl generates warnings in the logs if mode is undefined, set a default value to cut down the noise. Can use the mode variable which is otherwise created for no reason -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:22:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:22:02 +0000 Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #15 from Jonathan Druart --- A customer asked me the same request then I developed a patch and completely forgot this one. So I will provide a followup with what I needed some months ago :) But after a little reflexion, I don't know if it is relevant. I think it is not pleasant not to let the choice to the user. Are you sure it is legal not to let the user deactivate notifications? Switch to in discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:22:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:22:12 +0000 Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:22:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:22:32 +0000 Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #16 from Jonathan Druart --- Created attachment 20332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20332&action=edit Bug 9254: redirect to 404 if at least 1 pref is off And set the value of EnhancedMessagingPreferencesOPAC = EnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:24:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:24:57 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:25:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:25:00 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20311|0 |1 is obsolete| | --- Comment #2 from Galen Charlton --- Created attachment 20333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20333&action=edit Bug 10606: Remove MySQLism in GetUpcomingDueIssues To test: [1] Arrange to have at least one loan in your test database due one day from now. [2] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 and note the number of loans reported. [3] Apply the patch. [4] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 again and verify that the number of loans reported remains the same. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:29:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:29:55 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:30:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:30:26 +0000 Subject: [Koha-bugs] [Bug 9801] location facet shows even if no locations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9801 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:31:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:31:27 +0000 Subject: [Koha-bugs] [Bug 10715] MARC21 007 Plugin Editor doesn't load position 01 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:31:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:31:31 +0000 Subject: [Koha-bugs] [Bug 10715] MARC21 007 Plugin Editor doesn't load position 01 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20282|0 |1 is obsolete| | --- Comment #2 from Galen Charlton --- Created attachment 20334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20334&action=edit Bug 10715 - MARC21 007 Plugin Editor doesn't load position 01 This patch changes the MARC21 007 plugin editor so that it uses 1 character instead of 4 characters for position 01. TEST PLAN: 1) Create new record/edit an existing record 2) Using the tag editor for the 007 field, choose "Videorecording" 3) Click OK 4) Change the second character in the 007 from "c" to "d" 5) Open the tag editor again 6) Note that position 01 will still say "c - Videocartridge" rather than "d - Videodisc". 7) Exit tag editor 8) Apply patch 9) Reload the page (Shift + Refresh is always useful) 10) Open the tag editor again 11) Note that position 01 will now say "d - Videodisc" Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:32:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:32:03 +0000 Subject: [Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #24 from Tom?s Cohen Arazi --- Latest patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:32:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:32:53 +0000 Subject: [Koha-bugs] [Bug 10559] noisy statement handle still active warnings when generating notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10559 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:33:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:33:08 +0000 Subject: [Koha-bugs] [Bug 10728] subscription-renew generates unnecessary warnings in logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 20335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20335&action=edit Proposed patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:33:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:33:35 +0000 Subject: [Koha-bugs] [Bug 10597] Search to hold button broken on record details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:33:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:33:48 +0000 Subject: [Koha-bugs] [Bug 10728] subscription-renew generates unnecessary warnings in logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:34:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:34:13 +0000 Subject: [Koha-bugs] [Bug 10595] OpacTopissue page still accessible when system preference is turned off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Mirko! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:41:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:41:33 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Jonathan Druart --- QA comment: 1/ There is no pod in the new file (yes I know, I am not the best person to make this remark...). 2/ The license version should be replaced with the GPLv3. 3/ I don't know why but the ajax script is called twice! (maybe can you have a look at my patch for bug 9811 where I use a script to populate a table with the server side processing method). Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:42:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:42:27 +0000 Subject: [Koha-bugs] [Bug 10587] HTML errors on authority detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:42:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:42:31 +0000 Subject: [Koha-bugs] [Bug 10587] HTML errors on authority detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20239|0 |1 is obsolete| | --- Comment #2 from Galen Charlton --- Created attachment 20336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20336&action=edit Bug 10587: fix HTML errors on authority detail page in OPAC A validator check of the OPAC's authority detail returns a few minor errors. This patch corrects the errors. To test, apply the patch and run an OPAC authority detail page through an HTML validator. There should be no errors which are specific to the authorities detail template (as opposed to header and footer includes). Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:55:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:55:00 +0000 Subject: [Koha-bugs] [Bug 10728] subscription-renew generates unnecessary warnings in logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:55:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:55:10 +0000 Subject: [Koha-bugs] [Bug 10728] subscription-renew generates unnecessary warnings in logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728 --- Comment #3 from Galen Charlton --- Created attachment 20338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20338&action=edit bug 10728: fix additional log noise generated by subscription-renew.pl To test: [1] Use the renew link to bring up the subscription renewal form. [2] Verify that a warning message containing the text 'Problem = a value of 1 has been passed to param without key' was not added to the Apache error log. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:55:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:55:05 +0000 Subject: [Koha-bugs] [Bug 10728] subscription-renew generates unnecessary warnings in logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20335|0 |1 is obsolete| | --- Comment #2 from Galen Charlton --- Created attachment 20337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20337&action=edit Bug 10728: fix log noise generated by subscription-renew.pl Error log is showing warnings because mode is undefined and we are doing string comparisons on it. Set it to a default value (we were already assigning it a variable which we were not using) and use the the result in the comparison To test, after applying the patch: [1] Use the renew link from the subscription detail page to renew a subscription. [2] Verifying that doing this did not add a warning containing 'subscription-renew.pl: Use of uninitialized value $mode in string eq ' to the Apache error log. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:59:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:59:23 +0000 Subject: [Koha-bugs] [Bug 10716] The booksellers template generates a JS error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10716 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:59:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:59:22 +0000 Subject: [Koha-bugs] [Bug 10487] UT: GetMaxPickupDate needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:59:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:59:25 +0000 Subject: [Koha-bugs] [Bug 10487] UT: GetMaxPickupDate needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19183|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 20339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20339&action=edit Bug 10487: UT: GetMaxPickupDate needs unit tests GetMaxPickupDate is introduced by bug 8367. It needs unit tests. $ prove t/db_dependent/Reserves.t should produce: t/db_dependent/Reserves.t .. 1/14 # # Creating biblio instance for testing. # Creating item instance for testing. ERROR: GetMaxPickupDate is called without reserve and without itemnumber ERROR: GetMaxPickupDate is called without reserve and without itemnumber t/db_dependent/Reserves.t .. 11/14 # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=14, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.06 csys = 0.51 CPU) Result: PASS Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 16:59:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 14:59:26 +0000 Subject: [Koha-bugs] [Bug 10716] The booksellers template generates a JS error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10716 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20293|0 |1 is obsolete| | --- Comment #2 from Galen Charlton --- Created attachment 20340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20340&action=edit Bug 10716: fix JavaScript error on basket groups page To test: Go on acqui/basketgroup.tt and verify a js error occurred (ReferenceError: CONFIG_EXCLUDE_ARTICLES_FROM_SORT is not defined). Apply the patch and verify the error does not appear anymore. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 17:02:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 15:02:16 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 17:02:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 15:02:19 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19849|0 |1 is obsolete| | --- Comment #77 from Kyle M Hall --- Created attachment 20341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20341&action=edit Bug 9456 - Add callnumber column to the cart - QA Followup 2 - Sort on callnumber only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 17:02:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 15:02:59 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #78 from Kyle M Hall --- Please check again to see if this error still occurs. (In reply to Jonathan Druart from comment #76) > I get a really weird js error when I click on the Items header: > TypeError: y[(("string" + "-") + m[Q][1])] is not a function > > Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 17:14:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 15:14:28 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Jonathan Druart --- Last patch fixes the issues. Thanks Kyle. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 17:14:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 15:14:33 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|paul.poulain at biblibre.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 17:14:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 15:14:48 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20181|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 20342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20342&action=edit Bug 9011 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the field items.last_borrower, foreign key to borrowers.borrowernumber * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha set this new field to the patron who last returned this item. * If this new field has a value, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the given borrowernumber. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 17:14:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 15:14:55 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20329|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 20343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20343&action=edit Bug 9011 - QA Followup * Use template plugin to get syspref values * Hide "last returned by" if AnonymousPatron is not set Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 17:15:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 15:15:00 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #22 from Jonathan Druart --- Created attachment 20344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20344&action=edit Bug 9011: Update GPL license -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 17:19:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 15:19:22 +0000 Subject: [Koha-bugs] [Bug 10729] New: Support phrases-icu.xml in install and upgrade Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729 Bug ID: 10729 Summary: Support phrases-icu.xml in install and upgrade Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org While resolving some indexing probs for customers using icu in zebra, noted that recommendations for using icu suggested copying phrases-icu.xml from the zerbra install into koha. That procedure is a bit at odds with standard install and upgrade procedure. Need to add a useable phrases-icu.xml to koha and to ensure that install now updates default.idx correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 17:31:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 15:31:22 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #79 from Owen Leonard --- I just tested this and got an error at first because I didn't clear my browser cache. After a shift-reload it worked without errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 17:33:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 15:33:59 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #29 from Kyle M Hall --- Created attachment 20345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20345&action=edit Bug 10558 [QA Follow-up 3] - Change GPL version number and add POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 17:35:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 15:35:28 +0000 Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell --- Created attachment 20346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20346&action=edit Proposed patch Testing: With icu enabled, default.idx will now use icuchain phrases-icu.xml for phrase indexes after a make install or make upgrade. word indexes will state icuchain words-icu.xml The new file will be copied to etc/zebradb/etc by install/upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 17:39:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 15:39:33 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #30 from Kyle M Hall --- Is this followup 3 what you are looking for? I examined the network access of the page and did find two calls to batch_records_ajax.pl, but the first was a 302 redirect that did not send any content, with the second one being a 200 that does send content. (In reply to Jonathan Druart from comment #28) > QA comment: > > 1/ There is no pod in the new file (yes I know, I am not the best person to > make this remark...). > > 2/ The license version should be replaced with the GPLv3. > > 3/ I don't know why but the ajax script is called twice! (maybe can you have > a look at my patch for bug 9811 where I use a script to populate a table > with the server side processing method). > > Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 18:09:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 16:09:32 +0000 Subject: [Koha-bugs] [Bug 10730] New: Use DataTables on the tag review page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10730 Bug ID: 10730 Summary: Use DataTables on the tag review page Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tags/review.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The tag review page in the staff client could benefit from having a sortable table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 18:09:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 16:09:57 +0000 Subject: [Koha-bugs] [Bug 10730] Use DataTables on the tag review page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10730 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10649 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 18:09:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 16:09:57 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10730 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 18:22:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 16:22:15 +0000 Subject: [Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 18:22:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 16:22:18 +0000 Subject: [Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20281|0 |1 is obsolete| | --- Comment #2 from Galen Charlton --- Created attachment 20347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20347&action=edit Bug 10714: Redirect to list contents view upon save after initiating edit from list contents view In the staff client, if you initiate a list edit from the list contents view you should be redirected to that same view after saving your changes. The OPAC already works this way. To test, view the contents of an existing list. Click the "Edit list" item under the "Edit" menu. Click save on the list edit form and you should be redirected back to the contents view of that list. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 18:27:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 16:27:59 +0000 Subject: [Koha-bugs] [Bug 8324] Redisplay OPAC list with correct sort after edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 18:28:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 16:28:03 +0000 Subject: [Koha-bugs] [Bug 8324] Redisplay OPAC list with correct sort after edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20280|0 |1 is obsolete| | --- Comment #2 from Galen Charlton --- Created attachment 20348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20348&action=edit Bug 8324 - Redisplay OPAC list with correct sort after edit If you are viewing the contents of a list, edit it, change the default sort, and save your list will be redisplayed sorted by title no matter what default sort you chose. Lists do not automatically sort by their default sort, they must be opened with the sort parameter. This patch adds the list's sort parameter to the redirect after editing. To test, open an existing list in the OPAC which contains items. Click the "Edit list" link at the top of the list contents view. Change the default sort to something new. Click "Save." If the list is redisplayed using the new default sort the patch worked. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 18:45:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 16:45:33 +0000 Subject: [Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 18:45:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 16:45:37 +0000 Subject: [Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20267|0 |1 is obsolete| | --- Comment #2 from Galen Charlton --- Created attachment 20349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20349&action=edit Bug 10710: add unit tests for OfflineOperation's routines in C4/Circulation.pm This patch test AddOfflineOperation,GetOfflineOperation and DeleteOfflineOperation in C4/Circulation.pm. The tests are wrapped in a transaction. Note: Currently, GetOfflineOperations is not tested because we cannot mock C4::Context->userenv in unit tests To test: prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.01 usr 0.01 sys + 0.33 cusr 0.02 csys = 0.37 CPU Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 18:45:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 16:45:46 +0000 Subject: [Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 --- Comment #3 from Galen Charlton --- Created attachment 20350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20350&action=edit Bug 10710: (follow-up) perltidy new code Also, I prefer the use of parentheses for function calls, even when no arguments are being passed. One missed comma turns is(GetOfflineOperation, ...) into is(GetOfflineOperation ...) Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 19:04:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 17:04:57 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Two thoughts: - I think using Regexp::Common::URI to get the regular expressions would be easier to maintain. - What about having the plugin also actively verify that the link is good? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 19:18:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 17:18:44 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #21 from Galen Charlton --- Pushed to master. Thanks, Janusz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 19:51:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 17:51:59 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #100 from Tom?s Cohen Arazi --- Latest patches have been pushed to 3.12.x, will be in 3.12.4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 19:53:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 17:53:02 +0000 Subject: [Koha-bugs] [Bug 10197] Add CSS classes to patron info list in patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10197 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Nicole! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 20:25:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 18:25:48 +0000 Subject: [Koha-bugs] [Bug 10731] New: IntranetSlipPrinterJS is not working for hold slips Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Bug ID: 10731 Summary: IntranetSlipPrinterJS is not working for hold slips Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 20:27:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 18:27:02 +0000 Subject: [Koha-bugs] [Bug 10732] New: use a stricter SQL_MODE Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10732 Bug ID: 10732 Summary: use a stricter SQL_MODE Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org It would be nice to have Koha use a stricter MySQL/MariaDB SQL_MODE. Currently, Koha essentially expects that SQL_MODE is NULL. In particular, STRICT_TRANS_TABLES would add better type checking -- for example, no more inserting strings into an int field and expecting things to magically work. Another mode to consider is NO_ZERO_DATE [2]. It appears that MySQL on OS X ships with SQL_MODE set to a value that includes STRICT_TRANS_TABLES; a user report indicates that at least one seed data script cannot be loaded as a consequence. [3] [1] http://dev.mysql.com/doc/refman/5.6/en/server-sql-mode.html#sqlmode_strict_trans_tables [2] http://dev.mysql.com/doc/refman/5.6/en/server-sql-mode.html#sqlmode_no_zero_date [3] http://lists.katipo.co.nz/pipermail/koha/2013-August/037031.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 20:28:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 18:28:29 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 20:28:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 18:28:33 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 --- Comment #1 from Kyle M Hall --- Created attachment 20351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20351&action=edit Bug 10731 - IntranetSlipPrinterJS is not working for hold slips Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 20:29:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 18:29:28 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 20:37:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 18:37:09 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 --- Comment #2 from Kyle M Hall --- Created attachment 20352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20352&action=edit Bug 10731 - IntranetSlipPrinterJS is not working for hold slips [3.10.x] Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 20:38:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 18:38:47 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20352|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20353&action=edit Bug 10731 - IntranetSlipPrinterJS is not working for hold slips [v3.10/v3.12] Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 20:42:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 18:42:33 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 21:42:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 19:42:47 +0000 Subject: [Koha-bugs] [Bug 10733] New: Memcached on package installs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 Bug ID: 10733 Summary: Memcached on package installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz We should provide a proper way of configuring the use of memcached on packages setups. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 21:56:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 19:56:08 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 21:56:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 19:56:12 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 20354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20354&action=edit Bug 10733 - Memcached on package installs This patch makes the koha-create script adjust the koha-conf.xml file with the proper string substitutions to enable the use of memcached for the created Koha instance. It adds three option switches that control this: --use-memcached (defaults to "no") --memcached-servers "host1:port1,..." (defaults to 127.0.0.1:11211) --memcached-namespace "desired_namespace" (defaults to koha_${instance}) Note: the docs discourage setting user's own namespace. Using memcached is off as the default. The relevant configuration variables will remain empty if the user doesn't pass --use-memcached to the command. It matches the current behaviour. To test: - Apply the patch - Build your own packages and install them on a test server a) Create a new instance without using the new switches like: $ koha-create --create-db memctest - Check that /etc/koha/sites/memctest/koha-conf.xml contains: * Empty tag. * Empty tag. b) Play with the possible combination of option switches (Note that the code defaults to empty and will remain like that if --use-memcached is not used, so less tests...) $ koha-create --create-db --use-memcached memctest $ koha-create --create-db --use-memcached --memcached-servers "anything:xxx" memctest $ koha-create --create-db --use-memcached --memcached-servers "anything:xxx" --memcached-namespace "something" memctest $ koha-create --create-db --use-memcached --memcached-namespace "something" memctest - Check the koha-conf.xml file reflects the chosen options. c) Run $ koha-create --help - It should advertise this addition accordingly. d) Run $ man koha-create - Man page for koha-create should provide good information on the new switches behaviour Enjoy To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 22:10:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 20:10:48 +0000 Subject: [Koha-bugs] [Bug 9782] Cancel button doesn't work when importing MARC bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 22:10:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 20:10:50 +0000 Subject: [Koha-bugs] [Bug 9782] Cancel button doesn't work when importing MARC bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 --- Comment #1 from Owen Leonard --- Created attachment 20355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20355&action=edit Bug 9782 - Cancel button doesn't work when importing MARC bibliographic frameworks When importing frameworks the "cancel" button should be hidden once an import is initiated since it is not possible to cancel the import in progress. This patch uses this bug as an excuse to replace the old import/export pop-ups with modal dialogs for all import/export functions. To test: - Try exporting both the default framework and at least one other framework. - Try importing both a default framework and at least one other framework. - When importing, observe that the modal dialog controls are hidden as soon as the import is initiated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 22:14:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 20:14:36 +0000 Subject: [Koha-bugs] [Bug 10722] The log in bar "Log in to your account" floats incorrectly in the middle of the page on iPhone In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10722 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 22:18:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 20:18:34 +0000 Subject: [Koha-bugs] [Bug 10661] Mandatory item fields should be formatted the same on all forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10661 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 23:19:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 21:19:46 +0000 Subject: [Koha-bugs] [Bug 10483] check_uniqueness.pl does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10483 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 23:32:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 21:32:19 +0000 Subject: [Koha-bugs] [Bug 8425] Autobarcode generates duplicate barcodes with AcqCreateItems = on order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- I'm not able to reproduce the problem -- I suspect it was fixed by the patch for bug 8495. David: could you check to see if you're still seeing this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 23:42:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 21:42:43 +0000 Subject: [Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #36 from Galen Charlton --- I've pushed to two QAed patches to master. Thanks, Srikanth! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 23:42:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 21:42:54 +0000 Subject: [Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18784|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 23:43:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 21:43:06 +0000 Subject: [Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18785|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 14 23:44:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 21:44:20 +0000 Subject: [Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 00:00:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 22:00:29 +0000 Subject: [Koha-bugs] [Bug 10405] User-editable sections should have ids In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10405 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Jared! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 00:08:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 22:08:13 +0000 Subject: [Koha-bugs] [Bug 9487] Allow items fields to be used in the HOLDPLACED notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9487 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 00:09:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 22:09:49 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20354|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 20356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20356&action=edit Removed some cruft from other tries. Enjoy To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 00:29:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 22:29:37 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20356|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 20357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20357&action=edit Bug 10733: Memcached on package installs This patch makes the koha-create script adjust the koha-conf.xml file with the proper string substitutions to enable the use of memcached for the created Koha instance. It adds three option switches that control this: --use-memcached (defaults to "no") --memcached-servers "host1:port1,..." (defaults to 127.0.0.1:11211) --memcached-namespace "desired_namespace" (defaults to koha_${instance}) Note: the docs discourage setting user's own namespace. Using memcached is off as the default. The relevant configuration variables will remain empty if the user doesn't pass --use-memcached to the command. It matches the current behaviour. To test: - Apply the patch - Build your own packages and install them on a test server a) Create a new instance without using the new switches like: $ koha-create --create-db memctest - Check that /etc/koha/sites/memctest/koha-conf.xml contains: * Empty tag. * Empty tag. b) Play with the possible combination of option switches (Note that the code defaults to empty and will remain like that if --use-memcached is not used, so less tests...) $ koha-create --create-db --use-memcached memctest $ koha-create --create-db --use-memcached --memcached-servers "anything:xxx" memctest $ koha-create --create-db --use-memcached --memcached-servers "anything:xxx" --memcached-namespace "something" memctest $ koha-create --create-db --use-memcached --memcached-namespace "something" memctest - Check the koha-conf.xml file reflects the chosen options. c) Run $ koha-create --help - It should advertise this addition accordingly. d) Run $ man koha-create - Man page for koha-create should provide good information on the new switches behaviour Enjoy To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 00:29:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 22:29:49 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 20358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20358&action=edit Bug 10733: add 'memcached' as suggested dependency Adds 'memcached' to the control.in file so the user is suggested by apt to install it. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 01:45:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 23:45:01 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 --- Comment #11 from Srdjan Jankovic --- Yes, I was doing something else and removed the syspref erroneously. When I put it back there are no warnings. But the test failures stayed. Do you need any more details eg table dumps? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 01:52:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 23:52:41 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 01:52:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Aug 2013 23:52:45 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20323|0 |1 is obsolete| | --- Comment #8 from Srdjan Jankovic --- Created attachment 20359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20359&action=edit iBug 10610: sysprefs.sql should be sorted by syspref names By sorting the sql syspref file, the developpers will be happy to avoid conflicts on this file each time a patch modifying it is pushed. Test plan: - create a new DB with a new table named systempreferences (with the same structure as the one you know). - insert the current sysprefs.sql file into this table. - note the number of rows in the systempreferences table. - apply this patch. - delete all rows of the systempreferences table. - insert the new sysprefs.sql file. - verify the number of rows is the same as the previous. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 07:12:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 05:12:10 +0000 Subject: [Koha-bugs] [Bug 8026] Facets code should allow to build facets on controlfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8026 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- (In reply to Katrin Fischer from comment #0) > In order to build a facet for the document type (serial, analytic, set etc.) > facets need to be build using the controlfields and specified position. The Leader is also necessary to build facets for document/record type. A Record Type facet should probably operate the same as the XSLT (i.e. use the Leader and 008 to determine a meaningful record type). A Publication date facet would also be nice, although I'm not sure what the best way to do that would be. I suppose we could use the 260$c or 264$c...but maybe the 008 dates are the best to use for it. Mind you, Date1 and Date2 can get somewhat complicated depending on the type of date that is encoded... What are other types of facets that we could/should be getting out of the controlfields? I've already made a rudimentary record type facet using the Leader using just Leader position 06, but I'm sure that we could do better... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 07:14:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 05:14:18 +0000 Subject: [Koha-bugs] [Bug 10734] New: Add Publication Date Facet in Searching Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734 Bug ID: 10734 Summary: Add Publication Date Facet in Searching Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org I propose that we add another search facet for publication date. This is fairly common amongst other ILSes and it's been asked for by a few people now. However, I'm not certain about how to proceed. I suppose we could use the 260$c or 264$c...but maybe the 008 dates are the best to use for it. Mind you, Date1 and Date2 can get somewhat complicated depending on the type of date that is encoded... If we are to use controlfields we'll need to refactor how facets are generated...see bug 8026 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 07:14:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 05:14:26 +0000 Subject: [Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8026 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 07:14:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 05:14:26 +0000 Subject: [Koha-bugs] [Bug 8026] Facets code should allow to build facets on controlfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8026 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10734 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 08:47:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 06:47:27 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 --- Comment #5 from Robin Sheat --- I wonder if it should also listen to koha-sites for its default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 09:16:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 07:16:45 +0000 Subject: [Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from M. de Rooy --- QA Comment: This works fine if you click Save. But it does not when you click Cancel. I think that if we correct this, we should do that too for Cancel. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 09:22:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 07:22:05 +0000 Subject: [Koha-bugs] [Bug 10735] New: koha-dump not working Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10735 Bug ID: 10735 Summary: koha-dump not working Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: trebbu at googlemail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Steps to Reproduce (on Debian, installing via apt-get koha-common): (1) Use koha-run-backups on an older Koha version (I used 3.10 which has been updated from an even older installation). (2) koha-restore data and configuration from step (1) into a Koha 3.12 installation. (3) Run /usr/sbin/koha-dump. Actual Result: It says "Dumping Koha site [...]:". Nothing else happens. Expected Result: Two dump files. Workaround: Remove the "set -e" line in /usr/sbin/koha-dump Additional Information: The older configuration doesn't have a config/backupdir entry. backupdir="$( xmlstarlet sel -t -v 'yazgfs/config/backupdir' $kohaconfig )" therefore returns 1 and exits koha-dump. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 10:32:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 08:32:45 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20230|0 |1 is obsolete| | --- Comment #21 from M. de Rooy --- Created attachment 20360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20360&action=edit Bug 10325 - Allow system preferences to be overridable from koha-httpd.conf For Koha installations with multiple OPAC URLs, It would be nice to be able to override systeprefs from the http conf file. Case in point, a library wants to have two separate opacs, one the is only viewable from within the library that allows patrons to place holds, and a second public one that does not. In this case, overriding the system preference RequestOnOpac would accomplish this simply, and with no ill affects. This feature would of course be should only be used to override cosmetic effects on the system, and should not be used for system preferences such as CircControl, but would be great for preferences such as OpacStarRatings, opacuserjs, OpacHighlightedWords and many others! Test Plan: 1) Apply this patch 2) Disable the system pref OpacHighlightedWords 3) Do a seach in the OPAC, not the term is not highlighted 4) Edit your koha-http.conf file, add the line SetEnv OVERRIDE_SYSPREF_OpacHighlightedWords "1" to your koha-http.conf file's OPAC section. Also add the line SetEnv OVERRIDE_SYSPREF_NAMES "OpacHighlightedWords" to the Intranet section 5) Restart your web server, or just reload it's config 6) Do a seach, now your search term should be highlighted! 7) From the intranet preference editor, view the pref, You should see a warning the this preference has been overridden. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 10:34:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 08:34:42 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #22 from M. de Rooy --- Created attachment 20361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20361&action=edit Bug 10325: QA Followup for lowercase in pref hash and few typos Restoring the lowercase behavior for entries in pref hash in Context.pm. Textual change in preferences.tt: $pref been -> value for $pref may have been. Typo in koha-httpd.conf: SevEnv -> SetEnv. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 10:37:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 08:37:36 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #23 from M. de Rooy --- QA Comment: Fine addition! I added a small (trivial) QA followup. Code looks good to me. No complaints from koha-qa. Before passing QA on this one, I have still two (simple) requests in connection with case insensitive pref names in koha-httpd.conf (easier use): 1) Would it be possible to make the check in Context.pm: defined $ENV{"OVERRIDE_SYSPREF_$var"} case insensitive somehow? Replace it perhaps by something like: my @k= grep {/OVERRIDE_SYSPREF_$var/i} keys %ENV; if ( @k ) { $value = $ENV{$k[0]}; 2) Check in preferences.pl with any: Could this be case insensitive too? any { lc $name eq lc $_ } @override_syspref_names ? If you could add a followup for this, I will be happy to sign it off too :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 10:38:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 08:38:31 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 11:21:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 09:21:45 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #24 from M. de Rooy --- my @k= grep {/OVERRIDE_SYSPREF_$var/i} keys %ENV; Safer variant: my @k= grep {/^OVERRIDE_SYSPREF_${var}$/i} keys %ENV; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 11:34:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 09:34:57 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 --- Comment #6 from M. de Rooy --- I know that more tests contain references to patron type S and home branch MPL but if my test database does not contain them, these kind of tests will always fail.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 11:35:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 09:35:34 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #25 from M. de Rooy --- I know that more tests contain references to patron type S and home branch MPL but if my test database does not contain them, these kind of tests will always fail.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 11:37:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 09:37:52 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 12:06:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 10:06:21 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #26 from M. de Rooy --- I am looking at this patch now. But I have the idea that we are not completely resolving the actual problem. The error is in GetReserveStatus and is not corrected with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 13:08:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 11:08:09 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #27 from M. de Rooy --- The circulation.tt template also contains another problem: If I cannot renew because of a hold, it should still be possible to check in the item. But this is not possible due to the same condition used: [% IF ( todayissue.renew_error_on_reserve ) %] On hold [% ELSE %] [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 13:17:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 11:17:11 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20153|Bug 10663 - Unit tests for |[SIGNED_OFF] Bug 10663 - description|CanBookBeRenewed |Unit tests for | |CanBookBeRenewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 13:17:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 11:17:28 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20154|Bug 10663: Follow-up - Unit |[SIGNED_OFF] Bug 10663: description|tests for CanBookBeRenewed |Follow-up - Unit tests for | |CanBookBeRenewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 13:17:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 11:17:35 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 13:22:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 11:22:37 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20155|0 |1 is obsolete| | Attachment #20156|0 |1 is obsolete| | --- Comment #28 from M. de Rooy --- Created attachment 20362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20362&action=edit Bug 10663 - Revert and use CheckReserves for CanBookBeRenewed It makes renewal lock by holds work again. Unit tests as follow up Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Katrin Fischer This reverts changes made to CanBookBeRenewed by patches from bug 9376. GetReserveStatus is not suitable to recognize if an item can fild a hold on return and CheckReserves is restored. Signed-off-by: Chris Cormack Bug 10663: Follow-up - Revert and use CheckReserves for CanBookBeRenewed CheckReserves returns '' when no reserve is found, so $resfound will always be defined and we need to check if it's true. This is part of the revert. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Squashed the above two patches. Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 13:22:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 11:22:52 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 13:23:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 11:23:00 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 13:23:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 11:23:28 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20362|Bug 10663 - Revert and use |[PASSED_QA] Bug 10663 - description|CheckReserves for |Revert and use |CanBookBeRenewed |CheckReserves for | |CanBookBeRenewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 13:23:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 11:23:46 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20362|[PASSED_QA] Bug 10663 - |[PASSED_QA_OPTION_1] Bug description|Revert and use |10663 - Revert and use |CheckReserves for |CheckReserves for |CanBookBeRenewed |CanBookBeRenewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 13:25:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 11:25:10 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #29 from M. de Rooy --- Created attachment 20363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20363&action=edit Bug 10663: Correcting GetReserveStatus so that holds block renewal This patch is a counterproposal for the patch already present on 10663. Instead of replacing the call to GetReserveStatus, it repairs GetReserveStatus. Note that the biblionumber parameter of GetReserveStatus is actually not used. It can be removed. The sql statement is adjusted to include title level holds. And that solves the problem reported. Test plan: Issue a book. Enter a title level hold. Check if you can renew on circulation page. Remove the title level hold. Enter an item level hold. Check again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 13:25:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 11:25:58 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #30 from M. de Rooy --- Created attachment 20364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20364&action=edit Bug 10663: QA Followup: Typo in comment in renewscript Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 13:33:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 11:33:46 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #31 from M. de Rooy --- QA Comment: I skipped the unit tests for now. They are not that critical. And see also my earlier comment on hardcoded assumptions. Attachment 20362 is fine for me. But it leaves the problem in GetReserveStatus. So I do not mind pushing this patch, because it resolves the reported issue. But I think it would be better to repair the problem in GetReserveStatus. For that reason I submitted attachment 20363. I tested it, but I leave it to Galen if he wants another signoff on that one. The last attachment just resolves a minor typo that I stumbled about when testing this.. Setting to Passed QA to attract the attention of RM. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 13:50:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 11:50:33 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20363|Bug 10663: Correcting |[COUNTER_PATCH] Bug 10663: description|GetReserveStatus so that |Correcting GetReserveStatus |holds block renewal |so that holds block renewal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 13:50:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 11:50:55 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20362|[PASSED_QA_OPTION_1] Bug |[PASSED_QA] Bug 10663 - description|10663 - Revert and use |Revert and use |CheckReserves for |CheckReserves for |CanBookBeRenewed |CanBookBeRenewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 14:16:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 12:16:42 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 --- Comment #7 from M. de Rooy --- I submitted a counterpatch on bug 10663 to resolve problems with GetReserveStatus. Could you tell me how that impacts this report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 14:31:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 12:31:36 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 --- Comment #6 from Tom?s Cohen Arazi --- (In reply to Robin Sheat from comment #5) > I wonder if it should also listen to koha-sites for its default. It does Robin. But it is not advertised. Maybe I should change MEMCACHED_NAMESPACE for MEMCACHED_PREFFIX. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 15:23:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 13:23:25 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 20365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20365&action=edit Bug 10733: Follow-up - use koha-sites.conf In order to respect the current schema, where configuration values are pondered like this: hardcoded < koha-sites.conf < koha-create option switches I changed the patch a bit. I even changed MEMCACHED_NAMESPACE for MEMCACHED_PREFIX that seems to fit better in the current schema. Any feedback is welcome. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 15:33:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 13:33:45 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 --- Comment #48 from M. de Rooy --- Created attachment 20366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20366&action=edit Bug 8044: First draft for Koha localization using Locale::Maketext You have to use the new module Koha::I18N Code example: use Koha::I18N; use CGI; my $input = new CGI; my $lh = Koha::I18N->get_handle_from_context($input, 'intranet'); print $lh->maketext("Localized string!"); PO files are in misc/translator/po/LANG-messages.po. Creation of PO files are integrated to existing workflow, so to create PO file for a language, just run in misc/translator: ./translate create LANG To update: ./translate update LANG You can then translate the PO with your favorite editor. Strings will be localized at runtime. Signed-off-by: Marcel de Rooy Works as advertised. Some details needing further attention noted on bug report. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 15:33:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 13:33:51 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 --- Comment #49 from M. de Rooy --- Created attachment 20367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20367&action=edit Bug 8044 follow-up: Fix warning and error messages in translate.pl CHARSET is now automatically replaced by UTF-8, and 'update' create the PO file if it does not exist. Also do not try to create PO files if POT file creation failed (when there is no messages to translate for example). + add some verbosity + add Locale::Maketext and Locale::Maketext::Lexicon to Koha dependencies Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 15:33:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 13:33:55 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 --- Comment #50 from M. de Rooy --- Created attachment 20368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20368&action=edit Bug 8044 follow-up: Add copyright block and use Modern::Perl Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 15:34:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 13:34:00 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 --- Comment #51 from M. de Rooy --- Created attachment 20369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20369&action=edit Bug 8044: Translate basket CSV column names using Koha::I18N This is a test case for new module Koha::I18N. It translate CSV columns headers when you export a basket as CSV. To test: - go to a basket page in staff interface with english interface - click on "Export this basket as CSV" and check that column titles are there and in english - change language and click on the same button. - column titles are still in english - now open a terminal, go to misc/translator and run: ./translate create LANG (e.g. fr-FR) - translate the po misc/translator/po/LANG-messages.po with your favorite po editor. - go back to the navigator and click again on the Export button - column names must be translated, according to the PO file. Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 15:34:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 13:34:04 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 --- Comment #52 from M. de Rooy --- Created attachment 20370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20370&action=edit Bug 8044: QA Followup to silence koha-qa Just moving the line for Modern::Perl Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 15:34:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 13:34:43 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 15:34:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 13:34:45 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19100|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 15:34:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 13:34:48 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19101|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 15:34:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 13:34:50 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19102|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 15:34:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 13:34:53 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 15:35:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 13:35:29 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 15:39:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 13:39:21 +0000 Subject: [Koha-bugs] [Bug 10661] Mandatory item fields should be formatted the same on all forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10661 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 15:47:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 13:47:53 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 --- Comment #15 from Nicole C. Engard --- Any other ideas? Is this specific to just me? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 16:19:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 14:19:52 +0000 Subject: [Koha-bugs] [Bug 10661] Mandatory item fields should be formatted the same on all forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10661 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 16:19:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 14:19:54 +0000 Subject: [Koha-bugs] [Bug 10661] Mandatory item fields should be formatted the same on all forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10661 --- Comment #1 from Owen Leonard --- Created attachment 20371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20371&action=edit Bug 10661 - Mandatory item fields should be formatted the same on all forms Mandatory item fields are not indicated the same way in all places. This patch corrects two places where required fields were shown in bold rather than using the standard "required" class: When adding an order from a staged file and when adding an item for a new issue of a serial. Unrelated changes: Added $KohaDates formatting of date and time and corrected capitalization on a heading on the add order from staged file page. It would be nice to be able to use the same method for displaying the item form as we use on neworderentry.tt -- pulling in the form from a separate include. However that system is designed for handling multiple items and would need to be adapted for these cases. To test, you must have a staged file from which to add an order. Open an existing basket or create a new one and choose to add an order "From a staged file." Choose a staged file from which to order. The item entry form under the "Import all" heading should show required fields in red. To test in serials: Begin the process for receiving an item from an existing subscription. On the serials-edit page, find the "Click to add item" links and click to open the item edit forms. There should be one under the numbered issue and the supplemental issue forms. In both cases the item edit screen should show the mandatory item fields in red. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 16:28:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 14:28:26 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 --- Comment #16 from Nicole C. Engard --- Check this out: http://screencast.com/t/vEWbzykXgc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 16:28:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 14:28:26 +0000 Subject: [Koha-bugs] [Bug 8026] Facets code should allow to build facets on controlfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8026 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |MARC Bibliographic data | |support Assignee|oleonard at myacpl.org |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 17:08:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 15:08:24 +0000 Subject: [Koha-bugs] [Bug 10736] New: AcqWarnOnDuplicateInvoice doesn't warn for duplications - just triplications+ Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 Bug ID: 10736 Summary: AcqWarnOnDuplicateInvoice doesn't warn for duplications - just triplications+ Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 10366 If you have AcqWarnOnDuplicateInvoice set to warn it only warns if you have 2 or more invoices with the same number. It should warn if you're trying to create a duplicate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 17:08:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 15:08:24 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10736 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 17:30:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 15:30:36 +0000 Subject: [Koha-bugs] [Bug 10736] AcqWarnOnDuplicateInvoice doesn't warn for duplications - just triplications+ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 17:30:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 15:30:38 +0000 Subject: [Koha-bugs] [Bug 10736] AcqWarnOnDuplicateInvoice doesn't warn for duplications - just triplications+ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 --- Comment #1 from Jared Camins-Esakov --- Created attachment 20372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20372&action=edit Bug 10736: show duplicate invoice warning on second invoice If you have AcqWarnOnDuplicateInvoice set to warn it only warns if you have 2 or more invoices with the same number. It should warn if you're trying to create a duplicate. To test: 1) Turn on AcqWarnOnDuplicateInvoice. 2) Try to create an invoice that duplicates an invoice number you are already using exactly once. 3) Note that you get a warning after applying this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 18:03:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 16:03:59 +0000 Subject: [Koha-bugs] [Bug 10736] AcqWarnOnDuplicateInvoice doesn't warn for duplications - just triplications+ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 18:04:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 16:04:02 +0000 Subject: [Koha-bugs] [Bug 10736] AcqWarnOnDuplicateInvoice doesn't warn for duplications - just triplications+ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20372|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 20373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20373&action=edit [SIGNED-OFF] Bug 10736: show duplicate invoice warning on second invoice If you have AcqWarnOnDuplicateInvoice set to warn it only warns if you have 2 or more invoices with the same number. It should warn if you're trying to create a duplicate. To test: 1) Turn on AcqWarnOnDuplicateInvoice. 2) Try to create an invoice that duplicates an invoice number you are already using exactly once. 3) Note that you get a warning after applying this patch. Signed-off-by: Nicole C. Engard all tests pass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 18:06:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 16:06:54 +0000 Subject: [Koha-bugs] [Bug 10737] New: Add "Add to basket" link on vendor search results page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737 Bug ID: 10737 Summary: Add "Add to basket" link on vendor search results page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org I think it would be convenient to have a shortcut to the "add to basket" options on the vendor search results page. With that you wouldn't have to click to view the basket before adding something to it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 18:30:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 16:30:04 +0000 Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 18:30:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 16:30:08 +0000 Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737 --- Comment #1 from Owen Leonard --- Created attachment 20374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20374&action=edit Bug 10737 - Add "Add to basket" link on vendor search results page This patch adds an "add to basket" link to the vendor search results page for each open basket associated with each vendor. Clicking it triggers a modal window with the "add to basket" choices for that vendor and basket. Other changes in this patch: - "New basket" and "Receive shipment" buttons associated with each vendor search result have been converted to Bootstrap-styled buttons. - Basket closed date has been moved into its own column so that the table can be sorted by that value. - Table columns containing dates now use the "title-string" sort option, eliminating the need for a special date sorting algorithm. - Converted some &'s to &'s To test, apply the patch and search for a vendor. For each vendor in your search results baskets which are open should include an "add to basket" link. Clicking it should open a modal dialog with the same "add to basket" options offered on the basket page. The correct vendor ID and basket number should be associated with each link. The newly-styled "new basket" and "receive shipment" buttons should work correctly. Table sorting should work correctly, including the new "closed" column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 18:37:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 16:37:53 +0000 Subject: [Koha-bugs] [Bug 9290] Restricting patron category for online purchase suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P5 - low CC| |gmcharlt at gmail.com, | |kyle.m.hall at gmail.com Component|OPAC |Patrons Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 18:49:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 16:49:10 +0000 Subject: [Koha-bugs] [Bug 9817] Add Goodreads reviews tab to the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9817 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Version|3.14 |master Resolution|--- |WONTFIX Assignee|oleonard at myacpl.org |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 18:49:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 16:49:10 +0000 Subject: [Koha-bugs] [Bug 9816] Ominbus bug for adding Goodreads features In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9816 Bug 9816 depends on bug 9817, which changed state. Bug 9817 Summary: Add Goodreads reviews tab to the OPAC http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9817 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 18:49:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 16:49:10 +0000 Subject: [Koha-bugs] [Bug 9910] Get goodreads series info In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9910 Bug 9910 depends on bug 9817, which changed state. Bug 9817 Summary: Add Goodreads reviews tab to the OPAC http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9817 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 18:49:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 16:49:33 +0000 Subject: [Koha-bugs] [Bug 9910] Get goodreads series info In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9910 Bug 9910 depends on bug 9816, which changed state. Bug 9816 Summary: Ominbus bug for adding Goodreads features http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9816 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 18:49:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 16:49:33 +0000 Subject: [Koha-bugs] [Bug 9816] Ominbus bug for adding Goodreads features In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9816 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 18:49:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 16:49:45 +0000 Subject: [Koha-bugs] [Bug 9910] Get goodreads series info In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9910 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 19:50:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 17:50:02 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20361|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall --- Created attachment 20375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20375&action=edit Bug 10325 - QA Followup - Fix typos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 20:05:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 18:05:05 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #26 from Kyle M Hall --- Marcel, I've been talking to Galen about the case insensitivity for system preferences. We are both of the opinion that it's not good and it should go away. It's extremely odd in that the preference value is looked up in a case sensitive fashion, but cached in all lowercase. This situation where the first call to C4::Context->preference() *must* be correctly cased, but any further calls do not have to be. I had thought that it was possible that somewhere in the code base this situation might occur, so I wrote a script to extract the preference strings from all the calls to C4::Context->preference() anywhere in the code base. The script proved to me that there are no incorrectly cased calls to preference(). I will attach it for your perusal. So, in summary: 1) Galen and I both agree your followup to add case insensitivity for this particular feature, as per your request, is not necessary. 2) Galen and I both agree we should not cache the preferences in a case sensitive fashion. 3) I have written a script that proves no system preferences are called in an incorrectly cased manner. 3) My patch on it's own removes the case insensitivity from caching, while your qa followup re-adds it. Do to points 2 and 3, I think it's best that we do not use your followup ( except for the typo correction ), Though I do thank your for thinking of it and providing a followup! If that was the only issue of note, I believe it's now safe to pass QA on this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 20:05:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 18:05:55 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20375|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall --- Created attachment 20376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20376&action=edit Bug 10325 - QA Followup - Fix typos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 20:08:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 18:08:28 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #28 from Kyle M Hall --- Created attachment 20377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20377&action=edit Script to test for badly cases preference calls To run, copy this to the root directory of your git Koha clone and execute it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 21:13:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 19:13:35 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 21:13:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 19:13:38 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 --- Comment #1 from Owen Leonard --- Created attachment 20378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20378&action=edit Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." The triggered form is now labelled "Number of additional copies of this item to add" in an attempt to convey the fact that the number entered will be added to the one item represented by the item form above. i.e. if you enter "3" as the number of additional copies, you will end up with 4. Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 21:40:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 19:40:25 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #32 from Chris Cormack --- (In reply to M. de Rooy from comment #31) > QA Comment: > I skipped the unit tests for now. They are not that critical. And see also > my earlier comment on hardcoded assumptions. > Attachment 20362 [details] is fine for me. But it leaves the problem in > GetReserveStatus. > So I do not mind pushing this patch, because it resolves the reported issue. > But I think it would be better to repair the problem in GetReserveStatus. I think undoing the regression created should be first priority, ie pushing these patches because they undo the bad refactoring that created this problem > For that reason I submitted attachment 20363 [details] [review]. I tested > it, but I leave it to Galen if he wants another signoff on that one. I think this should go on it's own bug, and go through the proper signoff and qa process, separate to this. I am going to make a tshirt, REVERT REGRESSIONS !!! That should be our first policy, get it back to the behaviour that used to work. Then try the refactor again, this time with unit tests, so that we dont just bust things trying to be clever again. However it is of course Galens call. > The last attachment just resolves a minor typo that I stumbled about when > testing this.. > > Setting to Passed QA to attract the attention of RM. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 21:41:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 19:41:06 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #29 from M. de Rooy --- (In reply to Kyle M Hall from comment #26) > I've been talking to Galen about the case insensitivity for system > preferences. We are both of the opinion that it's not good and it should go > away. It's extremely odd in that the preference value is looked up in a case > sensitive fashion, but cached in all lowercase. It is not a matter of life and death, of course. But I would opt for case insensitive. For me, you may look it up in uppercase or whatever if you like that better :) So I do not simply agree with "It is not good and it should go away" (without further reasons given). But no problem for me to pass qa on this patch either. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 21:47:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 19:47:38 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #53 from M. de Rooy --- QA Comment: Final comment. Looks good to me. Older comments have been incorporated. This has been waiting for long. Thanks for your patience, Julian. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 21:47:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 19:47:54 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 21:51:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 19:51:46 +0000 Subject: [Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 21:51:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 19:51:49 +0000 Subject: [Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19801|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 20379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20379&action=edit Bug 10615 - Move saved reports action items into dropdown menu This patch moves saved reports "action" links (view, edit, run, etc) into a dropdown menu triggered by clicking an "Actions" button. To test you must have saved reports. View the saved reports page and click the "Actions" button in the last column of the table. This should trigger a menu. All options in the menu should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 21:52:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 19:52:12 +0000 Subject: [Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19799|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 21:58:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 19:58:39 +0000 Subject: [Koha-bugs] [Bug 10661] Mandatory item fields should be formatted the same on all forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10661 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20371|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 20380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20380&action=edit Bug 10661 - Mandatory item fields should be formatted the same on all forms Mandatory item fields are not indicated the same way in all places. This patch corrects two places where required fields were shown in bold rather than using the standard "required" class: When adding an order from a staged file and when adding an item for a new issue of a serial. Unrelated changes: Added $KohaDates formatting of date and time and corrected capitalization on a heading on the add order from staged file page. It would be nice to be able to use the same method for displaying the item form as we use on neworderentry.tt -- pulling in the form from a separate include. However that system is designed for handling multiple items and would need to be adapted for these cases. To test, you must have a staged file from which to add an order. Open an existing basket or create a new one and choose to add an order "From a staged file." Choose a staged file from which to order. The item entry form under the "Import all" heading should show required fields in red. To test in serials: Begin the process for receiving an item from an existing subscription. On the serials-edit page, find the "Click to add item" links and click to open the item edit forms. There should be one under the numbered issue and the supplemental issue forms. In both cases the item edit screen should show the mandatory item fields in red. Revision: Left out the "required" note which should appear after each required field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 22:07:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 20:07:23 +0000 Subject: [Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 22:07:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 20:07:25 +0000 Subject: [Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20379|0 |1 is obsolete| | --- Comment #5 from Nicole C. Engard --- Created attachment 20381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20381&action=edit [SIGNED-OFF] Bug 10615 - Move saved reports action items into dropdown menu This patch moves saved reports "action" links (view, edit, run, etc) into a dropdown menu triggered by clicking an "Actions" button. To test you must have saved reports. View the saved reports page and click the "Actions" button in the last column of the table. This should trigger a menu. All options in the menu should work correctly. Signed-off-by: Nicole C. Engard works and looks awesome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 22:23:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 20:23:32 +0000 Subject: [Koha-bugs] [Bug 9294] Move JavaScript out of circulation template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9294 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 22:23:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 20:23:35 +0000 Subject: [Koha-bugs] [Bug 9294] Move JavaScript out of circulation template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9294 --- Comment #16 from Owen Leonard --- Created attachment 20382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20382&action=edit Bug 9294 - Move JavaScript out of circulation template This patch creates a new js file, js/pages/circulation.js, and begins the process of moving JavaScript into it from circulation.tt. I have started the process by focusing on sections which are least dependent on template variables. To test, load a patron for checkout who has something checked out. There should be no JavaScript errors: - Tabs should work. - Showing and hiding the "Add message" form should work. - The "specify due date" datepicker should work. - Controls for selecting checkboxes in the checkouts table should work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 22:53:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 20:53:43 +0000 Subject: [Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20381|0 |1 is obsolete| | --- Comment #6 from Liz Rea --- Created attachment 20383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20383&action=edit Bug 10615 - Move saved reports action items into dropdown menu This patch moves saved reports "action" links (view, edit, run, etc) into a dropdown menu triggered by clicking an "Actions" button. To test you must have saved reports. View the saved reports page and click the "Actions" button in the last column of the table. This should trigger a menu. All options in the menu should work correctly. Signed-off-by: Nicole C. Engard works and looks awesome Signed-off-by: Liz Rea Yes, exactly what I had in mind. Great improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 22:57:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 20:57:54 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 22:57:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 20:57:57 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20378|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 20384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20384&action=edit Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." The triggered form is now labelled "Number of additional copies of this item to add" in an attempt to convey the fact that the number entered will be added to the one item represented by the item form above. i.e. if you enter "3" as the number of additional copies, you will end up with 4. Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. Signed-off-by: Liz Rea All cases tested. I like this change, much clearer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 15 23:52:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 21:52:07 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #33 from Liz Rea --- All, Guys, this was an embarrassing regression - this is functionality that has never been broken, and now we are "discussing" the solution to fixing it, when it really just needs to be fixed *right now*. This is essential functionality for a library, and I don't think we can afford to be waiting on cleverness, or arguing over the solution for this one. Please let's go with the original patch. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 00:52:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 22:52:44 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #34 from Galen Charlton --- I have pushed all that I intend to push for this bug, to master. I've included a follow-up to set issuingrules explicitly for the purposes of Circulation.t. Some observations: - While fixing the regression is extremely important, of course, the most important part of the patch series from the POV of Koha's maintainability are the new test cases. My thanks to Tom?s and Katrin for writing them. My particular thanks to Katrin for taking this opportunity to start learning how to write DB-dependent tests. - This incident further strengthens my disinclination to push patches that aim to refactor or "clean up" code that are not accompanied by test cases that completely (as humanly possible) exercise the visible behavior whose implementation is being reworked. - I acknowledge that the DB-dependent test suites currently make assumptions about which sample data is in place that are unwarranted. I also know that many people, myself included, have been chipping away at those issues. - Obviously there /is/ quite a bit of infelicity in the C4::Reserves API -- and it needs to be improved. Yea, I say unto you, it even needs to be refactored. :) But that's not going to happen without test cases. As a starting point, I suggest that those who are interested go through C4/Reserves.pm, identify problematic routines, file bugs for each, and write test cases demonstrating what the expected behavior is. - I am not opposed to squashing patches, particularly in cases where there's been flip-flopping or if judicious squashing would significantly improve the readability of the patch series. I am /strenuously/ opposed to squashes that remove author attribution, even inadvertently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 01:48:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Aug 2013 23:48:58 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #35 from Katrin Fischer --- Hi Galen, thx for taking a look at this, pushing the patches and improving the tests. In addition to what you wrote, I want to try to explain, why I think fixing GetReserveStatus like Marcel suggested is not the way to go. Writing GetReserveStatus without using CheckReserves is trying to simplify something that is really complicated: Before you block renewal on an item, you want to check if it can actually fill the hold. There are lots of things that should be taken into account here - branches, item types, circulation rules, item statuses... CheckReseves is used on checking in the items to determine that - so I think there is the logic we need and we should try to not replicate this logic in the code. The counter patch will pass the unit tests probably, but only because I didn't manage to cover all use cases. There are a lot more tests to be written here. After looking through the code trying to figure it all out I came to the conclusion that we should go back to use GetReserveStatus like it was used before the refactoring - only checking for 'waiting'. Or even better, refactor and have a properly named sub that does just this - backed up by unit tests - and remove GetReserveStatus. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 02:37:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 00:37:48 +0000 Subject: [Koha-bugs] [Bug 10735] koha-dump not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10735 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #1 from Liz Rea --- Did you specify an instance to dump when you ran koha-dump? The correct syntax is: koha-dump instancename Just making sure. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 02:38:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 00:38:49 +0000 Subject: [Koha-bugs] [Bug 10666] Daily quotes tests are failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666 --- Comment #4 from Galen Charlton --- Worked for me -- because my VM was set to UTC+0. I've pushed a follow-up that improves the fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 03:34:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 01:34:10 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 --- Comment #17 from Srdjan Jankovic --- Same for me. Something must have changed meanwhile. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 07:17:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 05:17:05 +0000 Subject: [Koha-bugs] [Bug 5789] Fines don't work when items have null homebranch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789 John.Seymour at nal.gov.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |John.Seymour at nal.gov.au --- Comment #2 from John.Seymour at nal.gov.au --- I am having the same problem with the fines cron job. I also have a problem with checking in items which have a NULL homebranch. I get the following error. "No branchcode argument passed to Koha::Calendar->new at /usr/share/koha/lib/C4/Overdues.pm line 310". This is probably due to the fact that my database contains items which where created using a much earlier version of KOHA. A possible solution would be a script to add the missing data to the database for these old items. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 07:50:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 05:50:41 +0000 Subject: [Koha-bugs] [Bug 10738] New: date does not displayed in fine slip Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10738 Bug ID: 10738 Summary: date does not displayed in fine slip Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Date in fine slip does not display in print slip. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 08:28:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 06:28:25 +0000 Subject: [Koha-bugs] [Bug 8425] Autobarcode generates duplicate barcodes with AcqCreateItems = on order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425 --- Comment #11 from David Cook --- (In reply to Galen Charlton from comment #10) > I'm not able to reproduce the problem -- I suspect it was fixed by the patch > for bug 8495. > > David: could you check to see if you're still seeing this? Really? That's odd. Admittedly, I don't fully comprehend the black magic that is the AJAX item add form in Acquisitions but I'm still seeing this :/. The first item you add will have a new barcode ($nextnum in comparison to the database). However, each new item you add to an order will have the exact same barcode as that one since they're all using the same database data, right? I don't see any checks against the barcode for items already in the order... Steps to Reproduce: 1) Syspref "AcqCreateItem" to "placing an order" 2) Autobarcode to any of the options (although I do get a Javascript error for " generated in the form yymm0001.". So probably try the others for the time being...) 3) UniqueItemFields to "barcode" 4) Go to acquisitions > new basket 5) Click on the "barcode" field for a new item, and add that item 6) Repeat step #5 and observe that they all have the same barcode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 08:48:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 06:48:24 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #36 from M. de Rooy --- Good to see that the reported issue has been resolved now. Since we do not solve the real problem but provided a partial workaround, bug 10697 will have to finish the job. Please note that the "being clever"-comments (imo) are not really motivating me or other people to spend more time on Koha. About squashing two patches (one with perhaps 5 lines and the other one 1 line): if the second patch just corrects one of the other 5 lines, I think we should squash them. I just used the squash of git rebase -i for that, and did not advertently remove authorship (git apparently ignores that). (And note that this is about one trivial line, my counterpatch contains a lot of lines more, but goes to waste without notice.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 08:55:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 06:55:02 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #37 from Katrin Fischer --- Marcel, did you take the time to read my comment? I have tried to explain why I think your counter patch won't work - it's not being ignored. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 09:10:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 07:10:39 +0000 Subject: [Koha-bugs] [Bug 10739] New: Template caching produces software errors when using templates in batch mode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10739 Bug ID: 10739 Summary: Template caching produces software errors when using templates in batch mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: sophie.meynieux at biblibre.com QA Contact: testopia at bugs.koha-community.org This bug was introduced by Bug 7511 When templates are used without GUI, the use of in KOHA_CONF generate some software errors. For example : - add /tmp in your KOHA_CONF file - returns a book that a borrower has reserved. Make sure this borrower has not activated email or sms notification so that a print notice wil be created - run misc/cronjobs/gather_print_notices.pl You've got some software errors : koha at sophie-Latitude-E5420:~/versions/community34/misc/cronjobs$ ./gather_print_notices.pl /tmp Use of uninitialized value in hash element at /home/koha/versions/community34/C4/Languages.pm line 322. Use of uninitialized value in hash element at /home/koha/versions/community34/C4/Languages.pm line 323. Use of uninitialized value in string eq at /home/koha/versions/community34/C4/Languages.pm line 332. Use of uninitialized value in string eq at /home/koha/versions/community34/C4/Languages.pm line 332. Use of uninitialized value in string eq at /home/koha/versions/community34/C4/Languages.pm line 332. If you from your KOKA_CONF_FILE, and redo the test, the notice is correctly printed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 09:31:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 07:31:57 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #80 from Jonathan Druart --- Last followup fixes the js error, thanks Kyle. All work great now, marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 09:32:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 07:32:50 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19844|0 |1 is obsolete| | --- Comment #81 from Jonathan Druart --- Created attachment 20385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20385&action=edit Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 09:32:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 07:32:56 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19845|0 |1 is obsolete| | --- Comment #82 from Jonathan Druart --- Created attachment 20386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20386&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip Signed-off-by: Cedric Vita Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 09:33:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 07:33:02 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19846|0 |1 is obsolete| | --- Comment #83 from Jonathan Druart --- Created attachment 20387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20387&action=edit Bug 9456 - Add callnumber column to the cart - Followup - Move sort filters to datatables.js Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 09:33:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 07:33:08 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19847|0 |1 is obsolete| | --- Comment #84 from Jonathan Druart --- Created attachment 20388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20388&action=edit Bug 9456 - Add callnumber column to the cart - QA Followup - Remove useless CSS Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 09:33:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 07:33:13 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20341|0 |1 is obsolete| | --- Comment #85 from Jonathan Druart --- Created attachment 20389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20389&action=edit Bug 9456 - Add callnumber column to the cart - QA Followup 2 - Sort on callnumber only Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 09:36:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 07:36:53 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #86 from Jonathan Druart --- Created attachment 20390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20390&action=edit Bug 9456: Remove whitespaces and tab Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 09:56:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 07:56:56 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #31 from Jonathan Druart --- (In reply to Kyle M Hall from comment #30) > Is this followup 3 what you are looking for? I examined the network access > of the page and did find two calls to batch_records_ajax.pl, but the first > was a 302 redirect that did not send any content, with the second one being > a 200 that does send content. The 2 calls get the records and return a JSON content. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 10:04:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 08:04:38 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #32 from Jonathan Druart --- Using $.ajax instead of $.getJSON (2 GET), there is only one call (1 POST) to the ajax script: - $.getJSON( sSource, aoData, function (json) { - fnCallback(json) - } ); + $.ajax({ + 'dataType': 'json', + 'type': 'POST', + 'url': sSource, + 'data': aoData, + 'success': function(json){ + fnCallback(json); + } + }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 10:05:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 08:05:56 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #38 from M. de Rooy --- (In reply to Katrin Fischer from comment #37) > Marcel, did you take the time to read my comment? I have tried to explain > why I think your counter patch won't work - it's not being ignored. Thanks for responding. Probably it would have been helpful to have your explanation before starting, or maybe I should have read the other report better :) The information on reverting is now scattered over two reports, and that does not make it easier.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 10:24:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 08:24:11 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 --- Comment #12 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #11) > Yes, I was doing something else and removed the syspref erroneously. When I > put it back there are no warnings. > But the test failures stayed. Do you need any more details eg table dumps? I read the code but I have no idea why they don't pass. First step, the batch is created and the batch_id is backed-up into the $batch_id var. Items are added to the batch and the retrieve method returns -2 if the batch does not contain items. Maybe could you warn the $batch_id var (l. 56)? Should be > 1. To check if items have been added could be interesting too (SELECT * FROM creator_batches WHERE batch_id = $batch_id). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 10:28:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 08:28:50 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9367 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 10:28:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 08:28:50 +0000 Subject: [Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10663 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 10:45:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 08:45:31 +0000 Subject: [Koha-bugs] [Bug 10735] koha-dump not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10735 --- Comment #2 from Robin Sheat --- The best solution would be a fallback for the backup path. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 11:35:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 09:35:08 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #30 from Kyle M Hall --- (In reply to M. de Rooy from comment #29) > (In reply to Kyle M Hall from comment #26) > > I've been talking to Galen about the case insensitivity for system > > preferences. We are both of the opinion that it's not good and it should go > > away. It's extremely odd in that the preference value is looked up in a case > > sensitive fashion, but cached in all lowercase. > > It is not a matter of life and death, of course. But I would opt for case > insensitive. For me, you may look it up in uppercase or whatever if you like > that better :) > > So I do not simply agree with "It is not good and it should go away" > (without further reasons given). > > But no problem for me to pass qa on this patch either. > > Passed QA Excellent. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 12:01:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 10:01:12 +0000 Subject: [Koha-bugs] [Bug 10736] AcqWarnOnDuplicateInvoice doesn't warn for duplications - just triplications+ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jcamins at cpbibliography.com |ity.org | QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #3 from Jonathan Druart --- Works as expected, marked as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 12:01:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 10:01:29 +0000 Subject: [Koha-bugs] [Bug 10736] AcqWarnOnDuplicateInvoice doesn't warn for duplications - just triplications+ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20373|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 20391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20391&action=edit Bug 10736: show duplicate invoice warning on second invoice If you have AcqWarnOnDuplicateInvoice set to warn it only warns if you have 2 or more invoices with the same number. It should warn if you're trying to create a duplicate. To test: 1) Turn on AcqWarnOnDuplicateInvoice. 2) Try to create an invoice that duplicates an invoice number you are already using exactly once. 3) Note that you get a warning after applying this patch. Signed-off-by: Nicole C. Engard all tests pass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 12:09:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 10:09:44 +0000 Subject: [Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #7 from Jonathan Druart --- Great ergonomic improvement. All actions work as before. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 12:10:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 10:10:07 +0000 Subject: [Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20383|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 20392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20392&action=edit Bug 10615 - Move saved reports action items into dropdown menu This patch moves saved reports "action" links (view, edit, run, etc) into a dropdown menu triggered by clicking an "Actions" button. To test you must have saved reports. View the saved reports page and click the "Actions" button in the last column of the table. This should trigger a menu. All options in the menu should work correctly. Signed-off-by: Nicole C. Engard works and looks awesome Signed-off-by: Liz Rea Yes, exactly what I had in mind. Great improvement. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 12:28:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 10:28:46 +0000 Subject: [Koha-bugs] [Bug 10740] New: date created and modified indexes in ccl.properties Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 Bug ID: 10740 Summary: date created and modified indexes in ccl.properties Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org date created and modified indexes are defined in bib1.att as : 1011 date-entered-on-file 1012 Date/time-last-modified This should be used in ccl.properties. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 12:36:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 10:36:04 +0000 Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 20393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20393&action=edit Bug 10740 - date created and modified indexes in ccl.properties See commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 12:36:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 10:36:09 +0000 Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 12:37:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 10:37:54 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- QA comment: Owen, the label is wrong. Currently, the "add multiple copies" does not add additional copies but the total amount of items. e.g. if I enter 3, it adds the first item + 2 copies. Following your test plan, it should 1 + 3 copies. I will provide a followup in order to scroll at bottom after clicking on the "add multiple copies" button. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 12:38:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 10:38:05 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 --- Comment #4 from Jonathan Druart --- Created attachment 20394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20394&action=edit Bug 10347: Scroll down clicking on the "Add multiple copies" button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 12:47:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 10:47:55 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #33 from Kyle M Hall --- Thanks Jonathan! I'll implement this change and add another followup shortly. (In reply to Jonathan Druart from comment #32) > Using $.ajax instead of $.getJSON (2 GET), there is only one call (1 POST) > to the ajax script: > > - $.getJSON( sSource, aoData, function (json) { > - fnCallback(json) > - } ); > + $.ajax({ > + 'dataType': 'json', > + 'type': 'POST', > + 'url': sSource, > + 'data': aoData, > + 'success': function(json){ > + fnCallback(json); > + } > + }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 12:48:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 10:48:11 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #34 from Kyle M Hall --- Created attachment 20395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20395&action=edit Bug 10558 [QA Follow-up 4] - switch $.getJSON to $.ajax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 12:59:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 10:59:29 +0000 Subject: [Koha-bugs] [Bug 8975] search results should say on order in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8975 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4319 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 12:59:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 10:59:29 +0000 Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8975 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:00:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:00:23 +0000 Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #17 from Fridolyn SOMERS --- I think this is solved by Bug 8975 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:11:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:11:46 +0000 Subject: [Koha-bugs] [Bug 10735] koha-dump not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10735 Bert Burgemeister changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |trebbu at googlemail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:15:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:15:35 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #97 from Kyle M Hall --- Thanks Jonathan! (In reply to Jonathan Druart from comment #96) > I updated the git branch just now. > > All patches (submitted on this report) are rebased against master (just 2 > conflicts with the first patch on updatedatabase.pl and kohastructure.sql). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:23:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:23:17 +0000 Subject: [Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20032|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 20396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20396&action=edit Bug 10664 : Software error in overdue_notices.pl if there is no active currency If there is no active currency, when running overdue_notices.pl you get a sofware error "Can't use an undefined value as a HASH reference" on GetCurrency() function call With this patch, if there is no active currency, fines are formated by default 0,00 and notices are correctly generated. Test plan : - have at least one borrower with overdue that should trigger a notice - verify that there is no active currency (Adminitration > Currency & Exchange rates) - run misc/cronjobs/overdue_notices.pl -v -n (to get the notice directly on output) => without the patch you get the software error => with the patch, notices are correctly generated If an active currency is defined, the script overdue_notices.pl runs the same with or without patch Signed-off-by: Srdjan Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:23:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:23:26 +0000 Subject: [Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:23:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:23:29 +0000 Subject: [Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 --- Comment #5 from Kyle M Hall --- Created attachment 20397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20397&action=edit Bug 10664 [QA Followup] - Software error in overdue_notices.pl if there is no active currency Fixes the following koha-qa.pl error: FAIL misc/cronjobs/overdue_notices.pl OK pod OK forbidden patterns OK valid FAIL critic # Variables::ProhibitConditionalDeclarations: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:35:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:35:53 +0000 Subject: [Koha-bugs] [Bug 10741] New: Can not place a hold on an item in transit and for loan Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10741 Bug ID: 10741 Summary: Can not place a hold on an item in transit and for loan Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In search results, one can not place a hold on an item in transit and for loan (items.notforloan=0). This appears when AllowOnShelfHolds is allowed and AllowHoldsOnDamagedItems is not allowed. Depends on Bug 8975 code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:36:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:36:41 +0000 Subject: [Koha-bugs] [Bug 10741] Can not place a hold on an item in transit and for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10741 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Depends on| |8975 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:36:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:36:41 +0000 Subject: [Koha-bugs] [Bug 8975] search results should say on order in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8975 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10741 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:38:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:38:31 +0000 Subject: [Koha-bugs] [Bug 10741] Can not place a hold on an item in transit and for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10741 --- Comment #1 from Fridolyn SOMERS --- Correction : This appears when AllowOnShelfHolds is allowed and item is not damaged (does not depend on AllowHoldsOnDamagedItems). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:39:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:39:33 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #35 from Jonathan Druart --- Comment on attachment 20345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20345 Bug 10558 [QA Follow-up 3] - Change GPL version number and add POD Review of attachment 20345: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10558&attachment=20345) ----------------------------------------------------------------- ::: tools/batch_records_ajax.pl @@ +2,4 @@ > > # This software is placed under the gnu General Public License, v2 (http://www.gnu.org/licenses/gpl.html) > > +# Copyright 2013 ByWater Solutions Does the original code is from Tamil or is it a wrong copy/paste? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:46:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:46:33 +0000 Subject: [Koha-bugs] [Bug 10078] show location facet for all In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:46:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:46:36 +0000 Subject: [Koha-bugs] [Bug 10078] show location facet for all In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20104|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20398&action=edit Bug 10078 - show location facet for all Currently, the location facet only shows if you have singlebranch mode enabled. In other words, you can either see the library branch or the shelving location. This patch simply changes the location facet so that it will always show the shelving location (if one is available), regardless of the singlebranch system preference. Test Plan: BEFORE APPLYING: 0) Disable singlebranch mode if it is on 1) Do an OPAC or Staff Client search for a record that has items with shelving locations. 2) Note that you can see the library branch facet under Libraries but no shelving locations. 3) Enable singlebranch mode 4) Repeat your search 5) Note that you can no longer see the library branch facet under Libraries. However, you can see the shelving location under Location N.B. If you don't have more than one branch or the search results are all from one branch, you might not get a library branch facet. If this is the case, create additional branches and/or change the branch for items in your search results so that you have multiple branches to prompt the appearance of a library branch facet. AFTER APPLYING 1) Do an OPAC or Staff Client search for a record that has items with shelving locations. 2) Note that you see a facet under Location on the left sidebar, regardless of there being a singlebranch mode or the number of branches there are being represented in the search results. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:50:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:50:29 +0000 Subject: [Koha-bugs] [Bug 10715] MARC21 007 Plugin Editor doesn't load position 01 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:50:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:50:32 +0000 Subject: [Koha-bugs] [Bug 10715] MARC21 007 Plugin Editor doesn't load position 01 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20334|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20399&action=edit Bug 10715 - MARC21 007 Plugin Editor doesn't load position 01 This patch changes the MARC21 007 plugin editor so that it uses 1 character instead of 4 characters for position 01. TEST PLAN: 1) Create new record/edit an existing record 2) Using the tag editor for the 007 field, choose "Videorecording" 3) Click OK 4) Change the second character in the 007 from "c" to "d" 5) Open the tag editor again 6) Note that position 01 will still say "c - Videocartridge" rather than "d - Videodisc". 7) Exit tag editor 8) Apply patch 9) Reload the page (Shift + Refresh is always useful) 10) Open the tag editor again 11) Note that position 01 will now say "d - Videodisc" Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:52:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:52:12 +0000 Subject: [Koha-bugs] [Bug 7469] Focus on 1st field of creation form instead of search textbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7469 --- Comment #3 from Kyle M Hall --- Created attachment 20400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20400&action=edit Bug 7469 - Focus on 1st field of creation form instead of search textbox (Acquisition) When a user creates a new vendor, a new borrower or a new basket (maybe on others pages too, to be listed), a creation form is displayed, but the focus is still on the search textbox on page top. It would be probably better to switch the focus to the first field of the creation form. This patch adds the focus, for acquisition module, on first input for pages with a data creation or modification or pages with only one form (like Z3950 search). Test plan : Go to pages and look where is the focus : - acqui/basketgroup.pl : focus on "Basket group name:" - acqui/basketheader.pl : focus on "Basket name:" - acqui/invoices.tt : focus on "Invoice no:" - acqui/modordernotes.pl : focus on "Notes:" - acqui/neworderempty.pl : focus on "Title:" - acqui/supplier.pl : focus on "Name:" - acqui/z3950_search.pl : focus on "Title:" Signed-off-by: Melia Meggs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:52:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:52:30 +0000 Subject: [Koha-bugs] [Bug 7469] Focus on 1st field of creation form instead of search textbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7469 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20260|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:53:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:53:54 +0000 Subject: [Koha-bugs] [Bug 10741] Can not place a hold on an item in transit and for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10741 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #2 from Fridolyn SOMERS --- Created attachment 20401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20401&action=edit Bug 10741 - Can not place a hold on an item in transit and for loan See commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:55:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:55:21 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Tom?s, It seems that TO_DAYS is a mysqlism. It is not in the postgres documentation http://www.postgresql.org/docs/9.2/static/functions-datetime.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 13:55:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 11:55:26 +0000 Subject: [Koha-bugs] [Bug 10741] Can not place a hold on an item in transit and for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10741 --- Comment #3 from Fridolyn SOMERS --- Created attachment 20402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20402&action=edit Bug 10741 - Formatting can place hold test Follow-up to rewrite the test in a single if test. Removes duplicated test on notforloan that caused this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 14:00:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 12:00:47 +0000 Subject: [Koha-bugs] [Bug 10738] date does not displayed in fine slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10738 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10708 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 14:00:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 12:00:47 +0000 Subject: [Koha-bugs] [Bug 10708] make fine receipt customizable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10738 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 14:19:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 12:19:18 +0000 Subject: [Koha-bugs] [Bug 8324] Redisplay OPAC list with correct sort after edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Quite odd, I cannot reproduce the issue. Without the patch: Opac > lists > my list. The default sort is "title". I am on the list results view and I click on the "Edit list" link. I change the "Sort this list by" value to "author", save. The results list is sorted by author. What I miss? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 14:34:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 12:34:58 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 14:35:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 12:35:01 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20333|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 20403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20403&action=edit Bug 10606: Remove MySQLism in GetUpcomingDueIssues To test: [1] Arrange to have at least one loan in your test database due one day from now. [2] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 and note the number of loans reported. [3] Apply the patch. [4] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 again and verify that the number of loans reported remains the same. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 14:39:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 12:39:55 +0000 Subject: [Koha-bugs] [Bug 10686] Fielded searches confuse highlighter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 14:39:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 12:39:57 +0000 Subject: [Koha-bugs] [Bug 10686] Fielded searches confuse highlighter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20192|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20404&action=edit Bug 10686: Remove fields from searches for highlighting If you do a fielded search like au:smith, "Smith" will not get highlighted on the results page because the Javascript is looking for the exact string "au:smith." To test: 1) Turn on OpacHighlightedWords. 2) Do a simple keyword search. 3) Confirm that the word is highlighted on the results and details page. 4) Do a fielded search by entering au:smith (or whatever). 5) Confirm that the word is highlighted on the results and details page. 6) Sign off. Signed-off-by: Mirko Tietgen Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 14:49:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 12:49:05 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 --- Comment #5 from Owen Leonard --- (In reply to Jonathan Druart from comment #3) > e.g. if I enter 3, it adds the first item + 2 copies. Following your test > plan, it should 1 + 3 copies. Are you sure? I definitely get 1 + 3 copies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 14:55:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 12:55:58 +0000 Subject: [Koha-bugs] [Bug 10028] ModReceiveOrder works unexpectedly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 14:56:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 12:56:01 +0000 Subject: [Koha-bugs] [Bug 10028] ModReceiveOrder works unexpectedly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20211|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20405&action=edit Bug 10028: ModReceiveOrder unexpectedly works. In C4::Acquisition::ModReceiveOrder, a call to NewOrder is badly used. NewOrder returns ($basketno, $ordernumber) but in ModReceiveOrder the ordernumber is got with my $ordernumber = NewOrder( $args ); It works because: sub t{ return ("a", "b"); } my $a = t(); say $a; Will display 'b'. But it is not really clear. Test plan: Check that there is no regression for partial receives. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:01:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:01:26 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19694|0 |1 is obsolete| | Attachment #19797|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 20406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20406&action=edit Bug 10481: FIX No enrollment fee when changing patron category. When a patron changes to a category with enrollment fee, they are not generated. Test plan: - Choose a category without fee (e.g. Kid) - Add an enrollment fee for another category (e.g. Young adult) - Choose a kid and change his category to "Young adult". - Note the warning message "Fees & Charges: Patron has Outstanding fees & charges of XX" on the check out page. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:01:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:01:35 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:01:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:01:38 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #24 from Kyle M Hall --- Created attachment 20407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20407&action=edit Bug 10481: Unit tests for C4::Members::AddEnrolmentFeeIfNeeded prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t .. ok All tests successful. Files=1, Tests=3, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.38 cusr 0.01 csys = 0.41 CPU) Result: PASS Signed-off-by: Srdjan Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:07:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:07:17 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:07:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:07:20 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20359|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 20408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20408&action=edit iBug 10610: sysprefs.sql should be sorted by syspref names By sorting the sql syspref file, the developpers will be happy to avoid conflicts on this file each time a patch modifying it is pushed. Test plan: - create a new DB with a new table named systempreferences (with the same structure as the one you know). - insert the current sysprefs.sql file into this table. - note the number of rows in the systempreferences table. - apply this patch. - delete all rows of the systempreferences table. - insert the new sysprefs.sql file. - verify the number of rows is the same as the previous. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:08:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:08:35 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Excellent idea! I wonder if there is any way to add a check for out of order sysprefs in koha-qa.pl, after this patch has been pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:09:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:09:47 +0000 Subject: [Koha-bugs] [Bug 10742] New: simple search to z39.50 search keeps index Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Bug ID: 10742 Summary: simple search to z39.50 search keeps index Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In intranet, when search does not return results, there is a button to perform the same search on Z39.50 servers. This works well when coming from advanced search. But when using simple search from header, in the Z39.50 search box "kw,wrdl" is added to the operand in title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:18:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:18:25 +0000 Subject: [Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 20409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20409&action=edit Bug 10742 - simple search to z39.50 search keeps index See commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:18:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:18:33 +0000 Subject: [Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:22:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:22:48 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:23:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:23:26 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 --- Comment #5 from Jonathan Druart --- Kyle, did you seen my comment ? postgres=# select TO_DAYS( NOW() ); ERREUR: la fonction to_days(timestamp with time zone) n'existe pas LIGNE 1 : select TO_DAYS( NOW() ); In english: The do_days function does not exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:23:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:23:32 +0000 Subject: [Koha-bugs] [Bug 10552] Several preferences missing from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:24:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:24:08 +0000 Subject: [Koha-bugs] [Bug 10576] Untranslatable strings in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Owen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:25:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:25:04 +0000 Subject: [Koha-bugs] [Bug 10578] Escaping CGI breaks results sort feature (librarian's interface) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10578 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Janusz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:25:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:25:32 +0000 Subject: [Koha-bugs] [Bug 10586] Printing cart from Firefox seems to be missing CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:26:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:26:06 +0000 Subject: [Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:26:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:26:21 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 --- Comment #11 from Jonathan Druart --- (In reply to Kyle M Hall from comment #10) > Excellent idea! I wonder if there is any way to add a check for out of order > sysprefs in koha-qa.pl, after this patch has been pushed. Yep, it should certainly be possible to do something. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:34:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:34:55 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #6 from Nicole C. Engard --- That's not how it has worked for me in the past - it has only added the number in the box ... so that might be a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:53:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:53:46 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:53:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:53:55 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20403|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 20410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20410&action=edit Bug 10606: Remove MySQLism in GetUpcomingDueIssues To test: [1] Arrange to have at least one loan in your test database due one day from now. [2] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 and note the number of loans reported. [3] Apply the patch. [4] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 again and verify that the number of loans reported remains the same. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 15:55:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 13:55:24 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 --- Comment #7 from Tom?s Cohen Arazi --- New version passes tests form Bug 10719 too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:11:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:11:31 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- (In reply to Jonathan Druart from comment #11) > (In reply to Kyle M Hall from comment #10) > > Excellent idea! I wonder if there is any way to add a check for out of order > > sysprefs in koha-qa.pl, after this patch has been pushed. > > Yep, it should certainly be possible to do something. I like the idea of this patch, and will push it shortly unless I find something wrong, but I'm opposed to putting a sorting requirement into koha-qa.pl. Sorting the script provides a small convenience by reducing the chance of merge conflicts, but doesn't per se provide a functional benefit. I'd really hate to see a patch fail QA on account of a new syspref getting inserted in the "wrong" place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:13:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:13:29 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 --- Comment #7 from Owen Leonard --- (In reply to Owen Leonard from comment #5) > Are you sure? I definitely get 1 + 3 copies. ...and I seem to be the only one for whom this is true. I'll have to do more investigation to find out why. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:16:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:16:13 +0000 Subject: [Koha-bugs] [Bug 10715] MARC21 007 Plugin Editor doesn't load position 01 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:17:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:17:38 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 --- Comment #13 from Jonathan Druart --- (In reply to Galen Charlton from comment #12) > (In reply to Jonathan Druart from comment #11) > > (In reply to Kyle M Hall from comment #10) > > > Excellent idea! I wonder if there is any way to add a check for out of order > > > sysprefs in koha-qa.pl, after this patch has been pushed. > > > > Yep, it should certainly be possible to do something. > > I like the idea of this patch, and will push it shortly unless I find > something wrong, but I'm opposed to putting a sorting requirement into > koha-qa.pl. Sorting the script provides a small convenience by reducing the > chance of merge conflicts, but doesn't per se provide a functional benefit. > I'd really hate to see a patch fail QA on account of a new syspref getting > inserted in the "wrong" place. I rather imagined that as a warning than a blocker stuff. The change could be made by the QAer with a small followup if the pref is not inserted in the good place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:20:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:20:48 +0000 Subject: [Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:27:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:27:05 +0000 Subject: [Koha-bugs] [Bug 10601] Add a counter on batch items modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10601 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19741|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20411&action=edit Bug 10601: Add a counter on batch items modifications After executing a batch items modifications, a dialog is displayed above the result table. It contains the number of items (and total fields) which has been modified. Test plan: 1/ Go to tools/batchMod.pl 2/ Enter a barcodes list 3/ Check/uncheck items and fill some values to apply 4/ Save 5/ The table summary will be displayed with a dialog box on top: XX item(s) modified (with YY fields modified) Check that XX and YY correspond with what you expected. Signed-off-by: Liz Rea batch modification still seems to work correctly, with the helpful addition of the counter. Thanks! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:27:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:27:23 +0000 Subject: [Koha-bugs] [Bug 10601] Add a counter on batch items modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10601 --- Comment #4 from Kyle M Hall --- Created attachment 20412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20412&action=edit Bug 10601 [QA Followup]: Add a counter on batch items modifications Fixes a koha-qa.pl error about the pod documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:27:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:27:43 +0000 Subject: [Koha-bugs] [Bug 10601] Add a counter on batch items modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10601 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:31:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:31:39 +0000 Subject: [Koha-bugs] [Bug 10743] New: add style to privacy rules Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Bug ID: 10743 Summary: add style to privacy rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org On the 'my privacy' page in the OPAC the privacy container includes the header, so I think we need another container for just the privacy rules so that it can be easily edited. Patch to follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:34:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:34:38 +0000 Subject: [Koha-bugs] [Bug 10688] QueryParser doesn't recognize QP queries when used in a fielded search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- I cannot reproduce the issue. I get the same results with and without the patch. Are there some prerequisites? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:35:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:35:36 +0000 Subject: [Koha-bugs] [Bug 10743] add style to privacy rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:35:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:35:38 +0000 Subject: [Koha-bugs] [Bug 10743] add style to privacy rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 --- Comment #1 from Nicole C. Engard --- Created attachment 20413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20413&action=edit Bug 10743: Add styles to 'my privacy' page in OPAC This patch does a couple things. Most importantly it adds a new div around the privacy rules summary so that it can be easily changed. It also moves the start of the form to right above the form's select box so that it's not in the new privacy rules div. To test: * Apply patch * Enable the use of privacy via the sys prefs * Log in to the OPAC * Visit the 'my privacy' tab * Make sure it looks okay * Submit the form and make sure it works * Repeat in the other theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:36:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:36:20 +0000 Subject: [Koha-bugs] [Bug 10716] The booksellers template generates a JS error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:36:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:36:23 +0000 Subject: [Koha-bugs] [Bug 10716] The booksellers template generates a JS error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20340|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20414&action=edit Bug 10716: fix JavaScript error on basket groups page To test: Go on acqui/basketgroup.tt and verify a js error occurred (ReferenceError: CONFIG_EXCLUDE_ARTICLES_FROM_SORT is not defined). Apply the patch and verify the error does not appear anymore. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:37:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:37:51 +0000 Subject: [Koha-bugs] [Bug 10743] add style to privacy rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:39:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:39:17 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20248|0 |1 is obsolete| | Attachment #20249|0 |1 is obsolete| | Attachment #20250|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 20415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20415&action=edit Bug 10703: Add db documentation for biblioimages table This patch adds db documentation to the biblioimages table. To test: Apply patch Review kohastructure.sql to be sure that the documentation is there Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:39:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:39:21 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 --- Comment #8 from Jonathan Druart --- Created attachment 20416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20416&action=edit Bug 10703: Document quotes table Add db documentation for the quotes table To test: apply patch review kohastructure.sql to be sure documentation is there Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:39:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:39:26 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 --- Comment #9 from Jonathan Druart --- Created attachment 20417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20417&action=edit Bug 10703: Document borrower_files table Add db documentation to borrower_files table. To test: apply review kohastructure.sql to be sure documentation is there Signed-off-by: Bernardo Gonzalez Kriegel Comment: No errors. Tested loading on new database. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:39:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:39:36 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:40:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:40:04 +0000 Subject: [Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Sophie! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:42:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:42:42 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed the current batch to master. Thanks, Nicole! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:42:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:42:47 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:42:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:42:55 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20415|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:43:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:43:04 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20416|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:43:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:43:15 +0000 Subject: [Koha-bugs] [Bug 10703] add/update database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20417|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:44:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:44:42 +0000 Subject: [Koha-bugs] [Bug 10716] The booksellers template generates a JS error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10716 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:44:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:44:45 +0000 Subject: [Koha-bugs] [Bug 10599] Uncheck on loan items on the batch item modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10599 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:44:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:44:46 +0000 Subject: [Koha-bugs] [Bug 5825] Add Item Type column to Holds Queue report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20257|0 |1 is patch| | Attachment #20257|application/mbox |text/plain mime type| | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:44:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:44:48 +0000 Subject: [Koha-bugs] [Bug 10599] Uncheck on loan items on the batch item modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10599 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19742|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20418&action=edit Bug 10599: Clear on loan items on the batch item modification tool Sometimes when using the batch item modification tool, we would like to automatically uncheck on loan items. Test plan: 1/ Go to tools/batchMod.pl. 2/ Enter some barcode (at least 1 should be on loan). 3/ Click on the Continue button. 4/ Click on the "Clear on loan" link. 5/ Check that on loan items are unchecked. Launch the unit test file: prove t/db_dependent/Circulation/IsItemIssued.t http://bugs.koha-community.org/show_bug.cgi?id=10572 Signed-off-by: Liz Rea Works as expected, only modifies items that are checked (still). No regression noted. Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:54:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:54:10 +0000 Subject: [Koha-bugs] [Bug 5825] Add Item Type column to Holds Queue report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:54:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:54:13 +0000 Subject: [Koha-bugs] [Bug 5825] Add Item Type column to Holds Queue report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20257|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 20419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20419&action=edit Bug 5825 - Add Item Type column to Holds Queue report The hold queue report shows collection code but not item type. This patch adds it. Also added is use of the KohaAuthorisedValues template plugin to display the collection code description instead of code. To test, apply the patch and view the holds queue. There should be a new item type column showing an item type description for each row. The collection column should now show the collection description instead of code. Signed-off-by: Melia Meggs Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:54:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:54:37 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #25 from Galen Charlton --- Comment on attachment 20407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20407 Bug 10481: Unit tests for C4::Members::AddEnrolmentFeeIfNeeded Review of attachment 20407: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10481&attachment=20407) ----------------------------------------------------------------- ::: t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t @@ +50,5 @@ > + > +# Check with calling directly AddEnrolmentFeeIfNeeded > +C4::Members::AddEnrolmentFeeIfNeeded( 'YA', $borrowernumber ); > +( $total ) = C4::Members::GetMemberAccountRecords( $borrowernumber ); > +is( $total, $enrolmentfee_K + $enrolmentfee_J + $enrolmentfee_YA, "Juvenile growing and become an young adult, he should pay " . ( $enrolmentfee_K + $enrolmentfee_J + $enrolmentfee_YA ) ); If I were a kid in this library district, I would think twice about reporting my age! ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 16:54:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 14:54:53 +0000 Subject: [Koha-bugs] [Bug 5825] Add Item Type column to Holds Queue report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m --- Comment #5 from Jonathan Druart --- Simple patch, add a new column. Marked as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:05:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:05:57 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |8215 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:05:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:05:57 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10609 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:09:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:09:18 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #26 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:09:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:09:25 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:09:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:09:33 +0000 Subject: [Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:09:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:09:35 +0000 Subject: [Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20325|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 20420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20420&action=edit Bug 10723: Merge GetPendingOrders and SearchOrders routines In the C4::Acquisition module, 2 routines do the same work. This patch merges these 2 routines. Test plan: test the acqui/orderreceive.pl, acqui/uncertainprice.pl and serials/acqui-search-result.pl, acqui/parcel.pl scripts. Note: on acqui/parcel the basket filter is a search on basket name (was on basket id, which was not relevant). Signed-off-by: Pierre Angot Signed-off-by: Kyle M Hall Passes koha-qa.pm, no adverse bahaviors noted. All sub calls updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:13:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:13:52 +0000 Subject: [Koha-bugs] [Bug 10688] QueryParser doesn't recognize QP queries when used in a fielded search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 --- Comment #4 from Jared Camins-Esakov --- You need to have QueryParser set up, which means you have to turn on UseQueryParser and have query_parser in your koha-conf.xml: /home/jcamins/kohaclone/etc/searchengine/queryparser.yaml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:21:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:21:42 +0000 Subject: [Koha-bugs] [Bug 10719] UT GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10719 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:21:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:21:45 +0000 Subject: [Koha-bugs] [Bug 10719] UT GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10719 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20305|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 20421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20421&action=edit Bug 10719 - UT GetUpcomingDueIssues Some unit tests related to Bug 9362. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart http://bugs.koha-community.org/show_bug.cgi?id=10606 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:22:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:22:14 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:22:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:22:16 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20410|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 20422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20422&action=edit Bug 10606: Remove MySQLism in GetUpcomingDueIssues To test: [1] Arrange to have at least one loan in your test database due one day from now. [2] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 and note the number of loans reported. [3] Apply the patch. [4] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 again and verify that the number of loans reported remains the same. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:27:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:27:40 +0000 Subject: [Koha-bugs] [Bug 10688] QueryParser doesn't recognize QP queries when used in a fielded search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #5 from Jonathan Druart --- (In reply to Jared Camins-Esakov from comment #4) > You need to have QueryParser set up, which means you have to turn on > UseQueryParser and have query_parser in your koha-conf.xml: > /home/jcamins/kohaclone/etc/searchengine/queryparser. > yaml Thanks, my koha-conf.xml did not contain the right path! Now I reproduce the issue and I confirm the patch fixes it. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:27:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:27:57 +0000 Subject: [Koha-bugs] [Bug 10688] QueryParser doesn't recognize QP queries when used in a fielded search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20199|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 20423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20423&action=edit Bug 10688: Don't prefix index inappropriately If you select an index in the search dropdown and then enter in a QP query starting with the field, Koha will prepend the index you do not want to use at the beginning of the search, resulting in a search that problem does not match what you were hoping for. To test: 1) Select an index in the search dropdown in the OPAC. Author is fine. 2) Enter a search term using manually entered indexes. For example: ti:cat in the hat 3) Note that the search fails. 4) Apply patch. 5) Repeat steps 1 and 2. 6) Note that the search succeeds. 7) Sign off. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:39:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:39:40 +0000 Subject: [Koha-bugs] [Bug 5825] Add Item Type column to Holds Queue report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5825 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton --- Pushed to master, along with two follow-ups: one that adds a regression test, and another that makes it respect the item-level_itypes system preference. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:57:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:57:06 +0000 Subject: [Koha-bugs] [Bug 10621] Subscription alert emails have wrong from-address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Mirko! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:57:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:57:50 +0000 Subject: [Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:58:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:58:48 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:58:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:58:48 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- This patch and Galen's follwup have been pushed to 3.12.x, will be in 3.12.4. Thanks Kenza and Galen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:58:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:58:51 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20201|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 20424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20424&action=edit Bug 10653: C4::RotatingCollections.pm needs unit tests The tests are wrap in a database transaction. Test plan: prove t/db_dependent/RotatingCollections.t t/db_dependent/RotatingCollections.t .. ok All tests successful. Files=1, Tests=41, 20 wallclock secs ( 0.02 usr 0.01 sys + 0.41 cusr 0.02 csys = 0.46 CPU) Result: PASS Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 17:59:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 15:59:49 +0000 Subject: [Koha-bugs] [Bug 10666] Daily quotes tests are failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:00:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:00:40 +0000 Subject: [Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com Version|unspecified |master --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:01:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:01:26 +0000 Subject: [Koha-bugs] [Bug 10712] Some values not saved in koha install log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10712 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:02:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:02:31 +0000 Subject: [Koha-bugs] [Bug 10642] Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10642 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:02:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:02:33 +0000 Subject: [Koha-bugs] [Bug 10642] Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10642 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20202|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20425&action=edit Bug 10642 : Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Passes koha-qa.pl, passes UT provided by bug 10653 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:02:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:02:56 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #39 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Katrin and everyone involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:03:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:03:41 +0000 Subject: [Koha-bugs] [Bug 10362] on return with reserve or transfer the alerts are not shown In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10362 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:04:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:04:59 +0000 Subject: [Koha-bugs] [Bug 9238] fund pull down says 'select budget' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:05:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:05:03 +0000 Subject: [Koha-bugs] [Bug 9238] fund pull down says 'select budget' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20319|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20426&action=edit Bug 9238 - fund pull down says 'select budget' When adding a new order to a basket the fund selection field is labeled "Fund:" but the default option is "Select a budget." This patch changes this string to "Select a fund" and also corrects the associated JavaScript error message text displayed when one doesn't choose a fund. To test, add an order to basket. The "New order" form should show "Select a fund" as the default option for "Fund" in the "Accounting details" section. If you submit the form without selecting a fund the error message should read "You must select a fund." Signed-off-by: Nicole C. Engard tests pass Signed-off-by: Kyle M Hall String updates only, passes koha-qa.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:10:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:10:48 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- Pushed to master along with a follow-up. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:12:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:12:47 +0000 Subject: [Koha-bugs] [Bug 8887] Search preferences: Strange behaviour with exact matches (default instead of custom favicon used, displays to much results) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:12:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:12:49 +0000 Subject: [Koha-bugs] [Bug 8887] Search preferences: Strange behaviour with exact matches (default instead of custom favicon used, displays to much results) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20278|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 20427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20427&action=edit Bug 8887: only display desired result when doing exact syspref search This patch fixes an issue where entering the complete name of a system preference when doing a syspref search in the staff interface resulted in the display of *all* preferences belonging to the desired one's module. Since providing a more specific search string should result in getting back more specific results, the previous behavior was not intuitive. Test scenario: a) In sysprefs, do a search with partial match (e.g. intranetcolor) -> Result shows one entry: intranetcolorstylesheet b) Do an exact search. e.g. intranetcolorstylesheet -> Result shows all Staff Client preferences Apply patch, test again. Now b) behaves like a). Signed-off-by: Mirko Tietgen Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:15:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:15:11 +0000 Subject: [Koha-bugs] [Bug 9238] fund pull down says 'select budget' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:16:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:16:24 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #20 from Kyle M Hall --- Question, would it not be better to use the KohaDates TT plugin, rather than using format_date in the source code? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:18:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:18:23 +0000 Subject: [Koha-bugs] [Bug 8887] Search preferences: Strange behaviour with exact matches (default instead of custom favicon used, displays to much results) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Marc! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:23:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:23:00 +0000 Subject: [Koha-bugs] [Bug 10642] Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10642 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:25:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:25:59 +0000 Subject: [Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:26:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:26:02 +0000 Subject: [Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19873|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 20428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20428&action=edit Bug 10195 Records hidden with OpacSuppression can still be accessed Records hidden with OpacSuppression are filtered from the search results, but the opac-detail page is still visible if you know the biblio number. This patch hides the detail page for suppressed biblios by redirecting (controlled by the syspref OpacSuppressionRedirect) either to opac-blocked (default), explaining that the record is blocked (including optional explanatory text from the syspref OpacSuppressionMessage) or to Koha's 404 page, giving no hint that a biblio with that number exists in the system. Test plan: Make sure you have at least one record with 942$n == 1. Set OpacSuppression to "Don't hide". Do an OPAC search that should bring up your hidden record and other records. Observe that your record is found. Open the detail page for the record. Observe that it is accessible. Copy the URL for later(!). Set OpacSuppression to "Hide". Leave OpacSuppressionByIPRange blank. Set OpacSuppressionRedirect to "an explanatory page ('This record is blocked')." Leave OpacSuppressionMessage blank for now. Disable queryparser(!) (because of bug 10542). Do a full zebra reindex. Do an OPAC search that should bring up your hidden record and other records. Observe that your record is not found. Open the opac-detail URL of the record (the one you copied before). Observe that you are redirected to opac-blocked and it displays a short standard message. Edit OpacSuppressionMessage and input some text. Open the opac-detail URL of the record again (the one you copied before). Observe that the text you entered in OpacSuppressionMessage is displayed under the standard text you have seen before. Set OpacSuppressionRedirect to "the 404 error page ('Not found')." Open the opac-detail URL of the record again (the one you copied before). Observe that you are redirected to Koha's 404 error page. Sign off the patch. :) Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:28:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:28:42 +0000 Subject: [Koha-bugs] [Bug 9943] Pay fines page "Pay selected" button give invalid amount when nothing is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9943 --- Comment #5 from Kyle M Hall --- Created attachment 20429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20429&action=edit Bug 9943 - Pay fines page "Pay selected" button give invalid amount when nothing is selected If you select no fines but click the "pay selected" button the resulting screen offers to let you pay against all fines, which is confusing. To simplify things this patch disables the "pay selected" button if no lines are selected. To test, apply the patch and find a patron with outstanding fines. From the "pay fines" page (members/pay.pl) try selecting and deselecting checkboxes and using the "select all" and "clear all" links. When no item is selected the "Pay selected" button should become disabled. Confirm that the form submits correctly when one or more fines is selected. Signed-off-by: Melia Meggs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:28:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:28:50 +0000 Subject: [Koha-bugs] [Bug 9943] Pay fines page "Pay selected" button give invalid amount when nothing is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9943 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20259|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:35:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:35:57 +0000 Subject: [Koha-bugs] [Bug 9916] Use DataTables in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20031|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 20430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20430&action=edit Bug 9916 - Use DataTables in the OPAC The OPAC still uses the old tablesorter plugin which isn't being actively maintained. We use DataTables in the staff client and should in the OPAC too. The plugin was added a while ago but never implemented on any pages. This patch upgrades the plugin to the latest version and places it in opac-tmpl/lib for cross-theme access. The patch implements DataTables on all pages which previously used the tablesorter plugin. The old tablesorter plugin is removed. The customized DataTable configuration script, datatables.js, has been trimmed-down from the staff client version in order to limit it to only that functionality required in the OPAC. Sorting based on date is done based on the data's enclosing title attribute as it is in the staff client: [% date | $KohaDates %] Slight modifications to Serials.pm and opac-search-history.pl have been made to accommodate this change. To test, view each page in the OPAC which uses JS-based table sorting: - The bibliographic detail page - The cart - The search history page - The suggestions page - The tags page (logged in as a user who has entered tags) - The "most popular" page (opac-topissues.pl) - The logged in user summary page (opac-user.pl) - The subscription "full history" page (opac-serial-issues.pl?selectview=full) - The self-checkout main page (with existing checkouts) Table sorting should work correctly on all pages in both the prog and ccsr themes. Sorting should work for dates whatever your dateformat system preference setting. Tables listing titles should exclude articles ("a," "an," and "the" in English) when sorting. Also test the serial collection page in the staff client, which is affected by the change to Serials.pm. Confirm that dates are displayed and sorted correctly. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:37:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:37:26 +0000 Subject: [Koha-bugs] [Bug 9916] Use DataTables in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:39:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:39:09 +0000 Subject: [Koha-bugs] [Bug 10686] Fielded searches confuse highlighter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Jared! Not quite bulletproof yet, though (not that I think it will *ever* be completely) -- consider ti,wrdl:history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:41:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:41:24 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 --- Comment #14 from Kyle M Hall --- Agreed, it's like horseshoes and hand-grenades. "Close enough" will do just fine. Kyle (In reply to Jonathan Druart from comment #13) > (In reply to Galen Charlton from comment #12) > > (In reply to Jonathan Druart from comment #11) > > > (In reply to Kyle M Hall from comment #10) > > > > Excellent idea! I wonder if there is any way to add a check for out of order > > > > sysprefs in koha-qa.pl, after this patch has been pushed. > > > > > > Yep, it should certainly be possible to do something. > > > > I like the idea of this patch, and will push it shortly unless I find > > something wrong, but I'm opposed to putting a sorting requirement into > > koha-qa.pl. Sorting the script provides a small convenience by reducing the > > chance of merge conflicts, but doesn't per se provide a functional benefit. > > I'd really hate to see a patch fail QA on account of a new syspref getting > > inserted in the "wrong" place. > > I rather imagined that as a warning than a blocker stuff. The change could > be made by the QAer with a small followup if the pref is not inserted in the > good place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 18:59:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 16:59:55 +0000 Subject: [Koha-bugs] [Bug 10028] ModReceiveOrder works unexpectedly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 19:01:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 17:01:27 +0000 Subject: [Koha-bugs] [Bug 10736] AcqWarnOnDuplicateInvoice doesn't warn for duplications - just triplications+ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Jared! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 19:11:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 17:11:51 +0000 Subject: [Koha-bugs] [Bug 10708] make fine receipt customizable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212 at gmail.com --- Comment #1 from vimal kumar --- I am waiting for the feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 19:41:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 17:41:11 +0000 Subject: [Koha-bugs] [Bug 10036] adding header search to additem page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10036 --- Comment #15 from Owen Leonard --- *** Bug 9741 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 19:41:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 17:41:11 +0000 Subject: [Koha-bugs] [Bug 9741] Search menu missing on edit items screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9741 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 10036 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 20:47:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 18:47:04 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Galen Charlton --- Pushed to master, thanks Jonathan! I'm OK with adding a warning to qa-tools provided that it never becomes a blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 21:35:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 19:35:39 +0000 Subject: [Koha-bugs] [Bug 10744] New: ExpireReservesMaxPickUpDelay has minor workflow conflicts with hold(s) over report Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Bug ID: 10744 Summary: ExpireReservesMaxPickUpDelay has minor workflow conflicts with hold(s) over report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Turning on ExpireReservesMaxPickUpDelay means that the hold(s) over part of the holds awaiting pickup report (circ/waitingreserves.pl) can be confusing. Specifically, if the hold cancellation cronjob runs before the library opens, the hold(s) over list will never contain any contents -- all of the holds that have hit the max pickup delay will have been cancelled. Having a report that will never produce results can be (and has been for at least one of our customers) confusing. I can think of a couple options for improving this: - suppress the display of the hold(s) over tab if ExpireReservesMaxPickUpDelay is on. - have the hold(s) over report display the list of waiting holds that were canceled - today or - the last time cancel_expired_holds.pl was run - as alternative or in conjunction with one of the other options, have cancel_expired_holds.pl create a report of cancelled waiting holds to assist with clearing the items from the holds shelf -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 21:49:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 19:49:32 +0000 Subject: [Koha-bugs] [Bug 10745] New: More fun on translation bug with XSLT subfieldSelect parameters Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 Bug ID: 10745 Summary: More fun on translation bug with XSLT subfieldSelect parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Some more cases as the ones solved on Bug 6278, now on NORMARCslim2intranetDetail.xsl and MARC21slim2intranetDetail.xsl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 21:49:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 19:49:53 +0000 Subject: [Koha-bugs] [Bug 10745] More fun on translation bug with XSLT subfieldSelect parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 22:25:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 20:25:30 +0000 Subject: [Koha-bugs] [Bug 9548] Store bibliographic information in aqorders table ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 --- Comment #5 from mathieu saby --- Hello Katrin Yes, using deleted tables could be a good idea, for avoiding the "deleted record" line. But... it would not be perfect, in case the record used by the order is modified by the library after the reception of the item. Ex : You mispell a title, or you put a wrong isbn or title, and you correct it after reception. If you print again the basketgroup, the information will not be exactly the same as before your changes. It is a detail, but I think Koha should have a way to print an EXACT copy of an order made 6 month ago. This could be useful for improving our relations with our vendors, and with accounting services. Currently we have to store copies of pdf basketgroups in a directory, outside Koha. Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 22:27:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 20:27:32 +0000 Subject: [Koha-bugs] [Bug 10745] More fun on translation bug with XSLT subfieldSelect parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 20431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20431&action=edit Bug 10745 - More fun on translation bug with XSLT subfieldSelect parameters As in Bug 6278, this patch replace ">at<" with ">a_t<" so not to mislead translators. Found more cases that initial description. To test: 1) Check that problem exists and only on xslt files, using your preferred language egrep -B10 "^msgid \"at\"" misc/translator/po/xx-YY-i-staff-t* 2) Apply the patch 3) Update translation file (cd misc/translator; perl translate update xx-YY) 4) Verify the problem is gone, repeat 1 5) If you like verify new entries in PO file egrep -B15 "^msgid \"a_t\"" misc/translator/po/xx-YY-i-staff-t* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 16 22:28:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Aug 2013 20:28:04 +0000 Subject: [Koha-bugs] [Bug 10745] More fun on translation bug with XSLT subfieldSelect parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 09:39:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 07:39:17 +0000 Subject: [Koha-bugs] [Bug 9548] Store bibliographic information in aqorders table ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 --- Comment #6 from Katrin Fischer --- But what if you want to print a corrected copy? If you have made mistakes and want to resend a corrected order to your vendor? - I am just saying this is a bit complicated and storing the created order or logging the data might be the better approach. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 09:40:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 07:40:55 +0000 Subject: [Koha-bugs] [Bug 9548] Store bibliographic information in aqorders table ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 --- Comment #7 from Katrin Fischer --- Complicated in that it's not easy to tell what the expected behaviour is for everyone in every situation... hope I make sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 10:05:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 08:05:08 +0000 Subject: [Koha-bugs] [Bug 10078] show location facet for all In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I am not sure every library will be happy about this change. If I am not mistaken combining the branches and the location facet will give you 'wrong' results as always all items are taken into account for the search result. So if you your items look like this: Item 1: Branch A, location C Item 2: Branch B, location D And you limit on Branch A and location D, the record will still be found. This will always happen when you combine item related facets. Maybe we need a way to hide this facet for libraries who don't want to offer it. It could be as simple as having ids for CSS or a pref that lets you specify which facets you want to show. I think the search could probably be improved using DOM, but I am not sure this has been done yet and it would also still not work for libraries using GRS-1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 11:20:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 09:20:57 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10680 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 11:20:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 09:20:57 +0000 Subject: [Koha-bugs] [Bug 10680] "Modification log" gives wrong data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10680 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10352 --- Comment #3 from Katrin Fischer --- Hi Kyle, I have run into this a while ago I think and left some confused notes on bug 10352. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 11:23:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 09:23:55 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #32 from Katrin Fischer --- Kyle, could you please take a look at my comment please? I am still torn if this is a fail, but it just doesn't look right to me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 15:37:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 13:37:51 +0000 Subject: [Koha-bugs] [Bug 9548] Store bibliographic information in aqorders table ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 --- Comment #8 from mathieu saby --- If the prices of the order were wrong, and does not match the invoiced price, I think the accounting department will ask us for the invoice, not a corrected version of the order. If an "basket group" in Koha is to be understood as a "Purchase order" (http://en.wikipedia.org/wiki/Purchase_order), it is not supposed to be changed after it is send to the bookseller. Or maybe it could be changed only in very special occasion, and voluntarily. Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 16:07:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 14:07:03 +0000 Subject: [Koha-bugs] [Bug 9548] Store bibliographic information in aqorders table ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 --- Comment #9 from Katrin Fischer --- Mathieu, I never said I don't see a need to store the information, but I still doubt that the aqorders table is the right place to do it. Changing the bibliographic data is only one part of it. You will also be able to move order lines in the future and you can undo every step in the ordering workflow and potentially modify data. So I think if we want to 'freeze' information we should think about a different technical solution. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 16:42:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 14:42:09 +0000 Subject: [Koha-bugs] [Bug 7942] Allow modification of basket group pdf template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7942 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Basket group pdf file |Allow modification of | |basket group pdf template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 16:49:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 14:49:37 +0000 Subject: [Koha-bugs] [Bug 10746] New: Improving PDF printing of baskets - Omnibus Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10746 Bug ID: 10746 Summary: Improving PDF printing of baskets - Omnibus Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org There are several existing bugs about the PDF printing functionality for baskets and basket groups in acquisitions. Templates for the PDF are not using the notices & slips and can currently not be modified without modifying files on server side. Also they are not translatable and libraires cannot add their own templates easily. I will link related bugs to this omnibus bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 16:50:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 14:50:12 +0000 Subject: [Koha-bugs] [Bug 10746] Improving PDF printing of baskets - Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10746 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7942, 7267, 10135, 5016 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 16:50:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 14:50:12 +0000 Subject: [Koha-bugs] [Bug 5016] Basket PDF has several non-translatable issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10746 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 16:50:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 14:50:12 +0000 Subject: [Koha-bugs] [Bug 7267] Display accountnumber in PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7267 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10746 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 16:50:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 14:50:12 +0000 Subject: [Koha-bugs] [Bug 7942] Allow modification of basket group pdf template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7942 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10746 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 16:50:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 14:50:12 +0000 Subject: [Koha-bugs] [Bug 10135] Adding the ability to define customised basketgroups pdf layouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10135 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10746 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 16:54:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 14:54:18 +0000 Subject: [Koha-bugs] [Bug 10746] Improving PDF printing of baskets - Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10746 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10573 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 16:54:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 14:54:18 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10746 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 17:07:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 15:07:04 +0000 Subject: [Koha-bugs] [Bug 10747] New: PDF template for order printing should be selectable per order Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10747 Bug ID: 10747 Summary: PDF template for order printing should be selectable per order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Currently you have to decide globally in a system preference, which template you want to use for PDF printing of basket groups. It would be nice to have this option available on order level with a global default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 17:07:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 15:07:11 +0000 Subject: [Koha-bugs] [Bug 10747] PDF template for order printing should be selectable per order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10747 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10746 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 17:07:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 15:07:11 +0000 Subject: [Koha-bugs] [Bug 10746] Improving PDF printing of baskets - Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10746 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10747 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 17:16:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 15:16:03 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 --- Comment #10 from Katrin Fischer --- Hi Christophe, I found a small thing you missed: Page 2 / 3 Could you explain how you did the translation? Is it enough to just translate the odt and print it as PDF to create the PDF file? I am passing QA on this. The current system of handling the templates for basket group printing is not good, but I can understand the need to have a translated template available. I have created an omnibus bug to bundle all related bug reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 17:17:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 15:17:04 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 17:17:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 15:17:09 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20186|0 |1 is obsolete| | Attachment #20187|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 20432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20432&action=edit [PASSED QA] Bug 10573: French translation for printing a basketgroup If you want to print a basketgroup with pdf format, it will be in english. The pdf is done with layout2pages.pm or layout3pages.pm which call layout2pages.pdf or layout3pages.pdf. This patch adds layout3pagesfr.pm in src/acqui/pdfformat/ which calls layout3pagesfr.pdf. And adds in basketgroup.pl the check for layout3pagesfr To use it you have to change the systempreferences to pdfformat::layout3pagesfr Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described, koha-qa reports some tab errors. Corrected in a followup. Please, always add a test plan, it's easier to test. Test: 1) apply the patch 2) change syspref OrderPdfFormat to pdfformat::layout3pagesfr 3) select a vendor 4) create a basket group (empty works) 5) close basket group 6) print basket group 7) PDF is in french Signed-off-by: Katrin Fischer This works nicely, although it would be better if we could find a more general solution to make the templates editable and translatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 17:17:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 15:17:34 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 --- Comment #12 from Katrin Fischer --- Created attachment 20433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20433&action=edit [PASSED QA] Bug 10573 - Followup - French translation for printing a basketgroup small followup to fix tabs Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 18:08:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 16:08:05 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- Pushed to master. Thanks, Christophe! I agree that a more general solution is required for the future. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 18:20:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 16:20:33 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #19 from Katrin Fischer --- Kyle, could you give an example on how to call the script that works for you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 18:29:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 16:29:32 +0000 Subject: [Koha-bugs] [Bug 9519] Wrong language code for Italian in the advanced search language limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 23:53:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 21:53:19 +0000 Subject: [Koha-bugs] [Bug 10701] In transit information doesn't display on the bibliographic detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 17 23:53:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 21:53:23 +0000 Subject: [Koha-bugs] [Bug 10701] In transit information doesn't display on the bibliographic detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20194|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20434&action=edit [PASSED QA] Bug 10701 - In transit information doesn't display on the bibliographic detail page The patch for Bug 10083 incorrectly changed some template variable names so that in-transit details could not be shown on the biblio detail page. This patch corrects the error. To test, perform any action that will trigger an transfer between libraries (for instance, check in an item from Library A at Library B). View the detail page for that title and look for the transfer details in the status column of the holdings table. It should show correct information: "In transit from Athens to Nelsonville since 08/08/2013" Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described, no errors. Before patch incorrect information: "In transit from to since" after patch correct information. Signed-off-by: Katrin Fischer Works perfectly and passes all tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 00:11:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 22:11:31 +0000 Subject: [Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 --- Comment #5 from Katrin Fischer --- Hm this is weird, I am still getting the error running the latest version of the QA script. Trying to see what is causing it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 00:29:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 22:29:00 +0000 Subject: [Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 --- Comment #6 from Katrin Fischer --- Comment on attachment 17404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17404 Bug 9924 - Simplify and rename patron card creator error message include Review of attachment 17404: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9924&attachment=17404) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt @@ +152,4 @@ >
> > > + [% INCLUDE 'patroncards-batches-toolbar.inc' %] Hi Owen, I think it's this line - and I can't spot a file with this name in the includes directory? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 00:29:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 22:29:25 +0000 Subject: [Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 00:41:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 22:41:09 +0000 Subject: [Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 00:41:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 22:41:22 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 00:42:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 22:42:12 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 00:55:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 22:55:52 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #11 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 00:59:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 22:59:01 +0000 Subject: [Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #9 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 01:03:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 23:03:50 +0000 Subject: [Koha-bugs] [Bug 10484] serials-edit.pl not checking for barcode field before checking for barcode subfield In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10484 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #7 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 01:08:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 23:08:19 +0000 Subject: [Koha-bugs] [Bug 10497] star ratings not showing right in ccsr detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #10 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 01:09:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Aug 2013 23:09:46 +0000 Subject: [Koha-bugs] [Bug 10029] CAS authentication fails in OPAC reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10029 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #10 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 06:23:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 04:23:22 +0000 Subject: [Koha-bugs] [Bug 10428] undefined check in add additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10428 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #9 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 06:25:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 04:25:46 +0000 Subject: [Koha-bugs] [Bug 5894] Adding multiple items from a cart to a list shows only the first title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5894 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #8 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 06:27:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 04:27:01 +0000 Subject: [Koha-bugs] [Bug 9113] batch modification removes + In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9113 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #9 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 06:28:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 04:28:20 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #25 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 06:31:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 04:31:53 +0000 Subject: [Koha-bugs] [Bug 10088] software error when filling a basket with staged record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10088 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #9 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 06:33:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 04:33:05 +0000 Subject: [Koha-bugs] [Bug 10384] Software error when LDAP connexion fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10384 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #9 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 06:38:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 04:38:18 +0000 Subject: [Koha-bugs] [Bug 9519] Wrong language code for Italian in the advanced search language limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9519 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #7 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 06:51:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 04:51:06 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #11 from Chris Hall --- First patch pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 06:52:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 04:52:08 +0000 Subject: [Koha-bugs] [Bug 10560] No way to disable english In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10560 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #7 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 07:33:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 05:33:29 +0000 Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #10 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 13:02:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 11:02:20 +0000 Subject: [Koha-bugs] [Bug 10735] koha-dump not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10735 --- Comment #3 from Bert Burgemeister --- (In reply to Robin Sheat from comment #2) > The best solution would be a fallback for the backup path. The fallback is already sort of implemented. It just doesn't work because xmlstarlet returns non-zero which kills koha-dump immediately due to its "set -e" setting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 14:18:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 12:18:18 +0000 Subject: [Koha-bugs] [Bug 9916] Use DataTables in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20430|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 20435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20435&action=edit [PASSED QA] Bug 9916 - Use DataTables in the OPAC The OPAC still uses the old tablesorter plugin which isn't being actively maintained. We use DataTables in the staff client and should in the OPAC too. The plugin was added a while ago but never implemented on any pages. This patch upgrades the plugin to the latest version and places it in opac-tmpl/lib for cross-theme access. The patch implements DataTables on all pages which previously used the tablesorter plugin. The old tablesorter plugin is removed. The customized DataTable configuration script, datatables.js, has been trimmed-down from the staff client version in order to limit it to only that functionality required in the OPAC. Sorting based on date is done based on the data's enclosing title attribute as it is in the staff client: [% date | $KohaDates %] Slight modifications to Serials.pm and opac-search-history.pl have been made to accommodate this change. To test, view each page in the OPAC which uses JS-based table sorting: - The bibliographic detail page - The cart - The search history page - The suggestions page - The tags page (logged in as a user who has entered tags) - The "most popular" page (opac-topissues.pl) - The logged in user summary page (opac-user.pl) - The subscription "full history" page (opac-serial-issues.pl?selectview=full) - The self-checkout main page (with existing checkouts) Table sorting should work correctly on all pages in both the prog and ccsr themes. Sorting should work for dates whatever your dateformat system preference setting. Tables listing titles should exclude articles ("a," "an," and "the" in English) when sorting. Also test the serial collection page in the staff client, which is affected by the change to Serials.pm. Confirm that dates are displayed and sorted correctly. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised! Signed-off-by: Katrin Fischer Works really nicely on all pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 14:29:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 12:29:47 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|paul.poulain at biblibre.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 15:23:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 13:23:40 +0000 Subject: [Koha-bugs] [Bug 10748] New: Add option to block return of lost items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748 Bug ID: 10748 Summary: Add option to block return of lost items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It seems there is currently no way to block users from returning an item that has been marked as lost. We already have BlockReturnOfWithdrawnItems to block the return of withdrawn items, so something similar for lost items would make sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 15:36:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 13:36:01 +0000 Subject: [Koha-bugs] [Bug 3849] Acq Permissions unclear In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 --- Comment #5 from Nicole C. Engard --- (In reply to Katrin Fischer from comment #4) > order_manage Manage orders & basket > order_receive Manage orders & basket > >Looks all the same? I just got a report of this from a library - they were confused - this is still an issue. Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 16:27:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 14:27:36 +0000 Subject: [Koha-bugs] [Bug 10749] New: patron permissions typos Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10749 Bug ID: 10749 Summary: patron permissions typos Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org In Home > Patrons > Set permissions for {staff member}, it says "edit_patronsPerform batch modifivation of patrons" which should be "edit_patronsPerform batch modification of patrons" It also says "budget_add_delAdd and delete budgets (but cant modify budgets)" which should be "budget_add_delAdd and delete budgets (but can't modify budgets)" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 17:44:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 15:44:36 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 17:44:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 15:44:40 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19654|0 |1 is obsolete| | Attachment #19655|0 |1 is obsolete| | Attachment #19656|0 |1 is obsolete| | Attachment #19657|0 |1 is obsolete| | --- Comment #46 from Katrin Fischer --- Created attachment 20436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20436&action=edit [PASSED QA] Bug 7639 - system preference to forgive fines on lost items Forgive fine when an item is set to lost status, fines are forgiven only when syspref ForgiveFineWhenLost is set to yes. Item can be set to lost status from: catalogue/moredetail.pl cataloguing/additem.pl tools/batchMod.pl misc/cronjobs/longoverdue.pl Changed sub C4::Circulation::LostItem to forgive fines on the item depending on the value of syspref ForgiveFineWhenLost. This sub is currently used to return an item and charge a replacement cost. Also added a new syspref in C4::Circulation::LostItem - ChargeReplFeeWhenLost. Replacement fee will now be charged only if this syspref is set to yes. Signed-off-by: Kyle M Hall Signed-off-by: Alex Hatley Signed-off-by: Katrin Fischer Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 17:44:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 15:44:55 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 --- Comment #47 from Katrin Fischer --- Created attachment 20437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20437&action=edit [PASSED QA] Bug 7639 - system preference to forgive fines on lost items - QA Followup Test Plan: 1) Apply the patch 2) Run updatedatabase.pl 3) Set WhenLostForgiveFine to Forgive & WhenLostChargeReplacementFee to Charge 4) Issue an item to a borrower, then set to lost from catalogue/moredetail.pl 5) Observe the replacement fee has been charged 6) Return the item 7) Observe the charged fee has been forgiven 8) Set WhenLostForgiveFine to Don't Forgive 9) Repeat 4-6 10) Observe the charged fee has not been forgiven 11) Set WhenLostChargeReplacementFee to Don't Charge 12) Repeat 4 13) Observe that a fee was not charged Signed-off-by: Alex Hatley Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 17:45:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 15:45:06 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 --- Comment #48 from Katrin Fischer --- Created attachment 20438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20438&action=edit [PASSED QA] Bug 7639 tiny QA follow-up no need to create a variable just to call to send it as parameter the line after Signed off by: Alex Hatley Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 17:45:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 15:45:15 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 --- Comment #49 from Katrin Fischer --- Created attachment 20439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20439&action=edit [PASSED QA] Bug 7639 - system preference to forgive fines on lost items - QA Followup - Fix update description Signed-off-by: Katrin Fischer With these patches we now have 3 preferences that deal with fines/fees and lost items: Replacement price - On marking lost: WhenLostChargeReplacementFee - On return: RefundLostItemFeeOnReturn (preexisting) Overdue fines - On marking lost: WhenLostForgiveFine System preferences work according to their description. Further notes: - Patches pass all tests and QA script. - LostItem is changed and needs unit tests. All occurrences of LostItem have been changed. - Database update is ok. I had to fix the sysprefs.sql file that has been recently rewritten and alphabetized. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 17:47:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 15:47:24 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 --- Comment #50 from Katrin Fischer --- I couldn't find any problems with these patches, but I would _really_ like to see some unit tests/regression tests for LostItem before setting this to 'Passed QA'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 17:52:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 15:52:40 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 18:19:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 16:19:23 +0000 Subject: [Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi David, the publication date range search on the advanced search page I think is based on 008 Date1 - so using 008 for the facet would make sense to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 18:20:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 16:20:12 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 18:41:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 16:41:54 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #15 from Jared Camins-Esakov --- Created attachment 20440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20440&action=edit Bug 5202: quiet warning $mergereference is not always defined, so we should check it is defined before checking its value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 19:02:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 17:02:19 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #16 from Jared Camins-Esakov --- Created attachment 20441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20441&action=edit Bug 5202 QA follow-up: improve merge reference selection The link on the merge reference had been wrong, and framework types were not indicated when you were merging records of two types. This patch fixes those problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 19:48:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 17:48:56 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20441|0 |1 is obsolete| | --- Comment #17 from Jared Camins-Esakov --- Created attachment 20442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20442&action=edit Bug 5202 QA follow-up: improve merge reference selection The link on the merge reference had been wrong, and framework types were not indicated when you were merging records of two types. This patch fixes those problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 20:45:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 18:45:36 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #18 from Jared Camins-Esakov --- Created attachment 20443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20443&action=edit Bug 5202 QA follow-up: correct license and POD errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 20:50:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 18:50:03 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 20:50:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 18:50:08 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20099|0 |1 is obsolete| | Attachment #20100|0 |1 is obsolete| | Attachment #20101|0 |1 is obsolete| | Attachment #20440|0 |1 is obsolete| | Attachment #20442|0 |1 is obsolete| | Attachment #20443|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 20444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20444&action=edit [PASSED QA] Bug 5202: merge authorities from the authority file and reservoir This patch gives Koha the ability to merge authority records using the same interface used by bibliographic records, though slightly different methods for selecting which records to merge. The two ways to select records are as follows: 1) Records can be selected from authority search results by clicking the "Merge" link for two records. 2) Authority records can be merged from the reservoir by clicking the merge-related links in the Manage staged MARC batch screen. To test: 1) Apply patch. 2) Do a search for an authority record that will turn up multiple identical records (or at least two records that you don't mind merging). 3) Click the "Merge" link for the first record. 4) Click the "Merge" link for the second record. 5) Choose which fields from which record you want to appear in the resulting record. 6) Confirm that those are the fields that exist in the resulting record. 7) Stage an authority record (for example, an authority record you saved from your catalog. 8) Search for a record to merge with it using the "Search for a record to merge in a new window" link. 9) Merge these records, confirming that the resulting record (after going through the entire merging process) matches your expectations. 10) Set up a matching rule for authorities, and export an authority from your catalog that will match based on that rule. For MARC21, the following is a good choice for a rule: Matching rule code: AUTHPER Description: Personal name main entry Match threshold: 999 Record type: Authority record [Match point 1:] Search index: mainmainentry Score: 1000 Tag: 100 Subfields: a 11) Stage the record you just exported, choosing the matching rule you just created. 12) Merge the record using the "Merge" link, confirming that the resulting record (after going through the entire merging process) matches your expectations. 13) Sign off. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 20:50:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 18:50:39 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #20 from Katrin Fischer --- Created attachment 20445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20445&action=edit [PASSED QA] Bug 5202 QA follow-up: quiet warnings Due to massively incorrect data in the default authority frameworks, we were getting warnings about undefined values and spaces from checking which tab subfields/fields were displayed in. This patch eliminates those warnings. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 20:50:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 18:50:49 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #21 from Katrin Fischer --- Created attachment 20446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20446&action=edit [PASSED QA] Bug 5202 QA follow-up 2: fix overeager error message When rebasing the patch for this, I accidentally moved the line setting the mergereference when merging from breeding to *before* I checked whether we were merging from breeding. Needless to say, this caused problems. This patch fixes that, and: * Makes the error translatable. * Adds a missing authtypesloop argument for the template. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 20:50:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 18:50:58 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #22 from Katrin Fischer --- Created attachment 20447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20447&action=edit [PASSED QA] Bug 5202: Quiet warning $mergereference is not always defined, so we should check it is defined before checking its value. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 20:51:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 18:51:34 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #23 from Katrin Fischer --- Created attachment 20448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20448&action=edit [PASSED QA] Bug 5202 QA follow-up: improve merge reference selection The link on the merge reference had been wrong, and framework types were not indicated when you were merging records of two types. This patch fixes those problems. Signed-off-by: Katrin Fischer Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 20:51:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 18:51:45 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #24 from Katrin Fischer --- Created attachment 20449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20449&action=edit [PASSED QA] Bug 5202 QA follow-up: correct license and POD errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 21:20:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 19:20:06 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #9 from Katrin Fischer --- Hi Owen, could you rebase your patch please? I tried but might have gone wrong somewhere. Would it be possible that you provide a unit test for the changed sub delete_report? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 21:24:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 19:24:23 +0000 Subject: [Koha-bugs] [Bug 10750] New: Correct capitalization on suggestion form in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750 Bug ID: 10750 Summary: Correct capitalization on suggestion form in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org There are a few strings not capitalized according to our rules in the OPAC suggestion form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 21:29:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 19:29:47 +0000 Subject: [Koha-bugs] [Bug 10750] Correct capitalization on suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750 --- Comment #1 from Katrin Fischer --- Created attachment 20450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20450&action=edit Bug 10750: Correct capitalization on suggestion form in OPAC Create a new suggestion from your patron account in the OPAC. Verify that all strings are correctly capitalized on the form and submit buttons. - Copyright date - Standard number ... and other - Submit your suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 21:29:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 19:29:44 +0000 Subject: [Koha-bugs] [Bug 10750] Correct capitalization on suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 21:39:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 19:39:51 +0000 Subject: [Koha-bugs] [Bug 10751] New: Title should be mandatory for creating suggestions in staff Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10751 Bug ID: 10751 Summary: Title should be mandatory for creating suggestions in staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When creating a suggestion in the staff interface, Title is not a mandatory field like in the OPAC. If you try to add a suggestion without a title it won't be saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 21:47:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 19:47:09 +0000 Subject: [Koha-bugs] [Bug 10752] New: Impossible to add 2 identical suggestions, but without any explanation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Bug ID: 10752 Summary: Impossible to add 2 identical suggestions, but without any explanation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To reproduce: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. It won't save and there is no error message or explanation given. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 21:47:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 19:47:21 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 21:51:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 19:51:50 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer --- Fridolyn, it might be a separate bug, but it means that your follow-up does not work - there is currently no way to have a suggestion which an empty branchcode. When you don't allow the patron to pick the branch in the OPAC the homelibrary will be used. When you create a suggestion for any library in staff, the branchcode is _ANY_ - so your change to the SQL query will currently have no effect: + $query .= q{ AND (branchcode='' OR branchcode=?) }; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 21:56:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 19:56:42 +0000 Subject: [Koha-bugs] [Bug 10753] New: Creating suggestions for 'Any library' uses _ANY as branchcode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Bug ID: 10753 Summary: Creating suggestions for 'Any library' uses _ANY as branchcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: fridolyn.somers at biblibre.com The staff interface allows creating suggestions for "Any library". In this case the branchcode used in the suggestions table is _ANY_. I think this creates a few problem. I think one will be that we can't create a FK constraint on the branchcode for the suggestions table. It would also be more consistent with other code in Koha to use an empty branchcode for any library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 21:57:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 19:57:02 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10753 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 21:57:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 19:57:02 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10449 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 18 23:46:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 21:46:04 +0000 Subject: [Koha-bugs] [Bug 10754] New: HomeOrHoldingBranch and CircControl are described identically in the system preference editor Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 Bug ID: 10754 Summary: HomeOrHoldingBranch and CircControl are described identically in the system preference editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 20451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20451&action=edit screenshot of system preference editor We have 2 system preferences that from their description in the system preferences editor do exactly the same thing, but offer different options: CircControl: Use the checkout and fines rules of ... - the library the item is from - the library the patron is from - the library you are logged in at HomeOrHoldingBranch: Use the checkout and fines rules of ... - the ibrary the item is from - the library the item was checked out from In the systempreferences table the description is different: CircControl: Used by Circulation to determine which branch of an item to check with independent branches on, and by search to determine which branch to choose for availability HomeOrHoldingBranch: Specify the agency that controls the circulation and fines policy Both preferences are used a multiple times in the code. I am currently not sure what the difference is. Bug 5159 also claims that CircControl is not only used when independentbranches is turned on. Can someone clarify and help updating the documentation? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 01:38:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 23:38:49 +0000 Subject: [Koha-bugs] [Bug 9093] 008 forgetting what material type was chosen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com --- Comment #1 from bondiurbano --- This happens in 3.12.3 too. Issue very claimed by staff users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 01:39:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Aug 2013 23:39:03 +0000 Subject: [Koha-bugs] [Bug 10078] show location facet for all In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078 --- Comment #5 from David Cook --- (In reply to Katrin Fischer from comment #4) > I am not sure every library will be happy about this change. If I am not > mistaken combining the branches and the location facet will give you 'wrong' > results as always all items are taken into account for the search result. So > if you your items look like this: > > Item 1: Branch A, location C > Item 2: Branch B, location D > > And you limit on Branch A and location D, the record will still be found. > This will always happen when you combine item related facets. > > Maybe we need a way to hide this facet for libraries who don't want to offer > it. It could be as simple as having ids for CSS or a pref that lets you > specify which facets you want to show. > > I think the search could probably be improved using DOM, but I am not sure > this has been done yet and it would also still not work for libraries using > GRS-1. I'm not sure that I understand your example, Katrin. 1) If you limit on Branch A and location D, you should get no results in your scenario. 2) In what scenario would you be able to use both those facets? (Using the Advanced Search, you could, but that's unrelated to the facets.) If you choose Branch A from the Libraries facet, you would only be presented with location C as a Locations facet. If you choose location D, you would only be presented with Branch B as a Libraries facet. The only time where that would be different is if you had: Item 1 (Bib #1): Branch A, location C Item 2 (Bib #2): Branch B, location D Item 3 (Bib #1): Branch A, location D In that case, you could limit on Branch A and location D, and you would get a search result for Bib #1 showing item availability for Item 1 and Item 3. In that sense, I suppose that could be a type of wrong result, because you would only want to show availability for Item 3. I don't think it's an indexing issue though. From what I've seen so far, it seems to me that DOM and GRS-1 fill the same indexes, they just do it in different ways. In this case, I think the issue would be with how we're displaying items. If we want to limit what item availability shows up in the search results, we would need to start checking our limits when building item displays in the "searchResults" sub. I don't think that's really a blocker for this bug though, as I mentioned, that same incorrect item availability would still occur by doing a Branch + Location query in the Advanced Search. I think that would be a separate issue. That said, I'm certainly in favour of including facet IDs for CSS and/or using a system preference so that libraries can choose which facets to show. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 02:11:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 00:11:30 +0000 Subject: [Koha-bugs] [Bug 10078] show location facet for all In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078 --- Comment #6 from David Cook --- Jared did an excellent job just now in IRC of clarifying your example, Katrin :). I think the best option will probably be to hide the Location facet in some way (probably CSS). The problem I see with hiding Location based on singleBranch mode is that some libraries with a single physical branch might use several virtual branches, thus not wanting to use singleBranch mode, but still wanting to have the Location facet. I've actually just looked at the code, and all the facets already have IDs. Location's is "location_id". Shall we set this back to Passed QA? Perhaps it might be an idea to open another bug report to look at building facets better? Perhaps we could pass the @limits into the getRecords sub, or extract limits from the query within the sub...perhaps by testing against existing limits our search/facets would "narrow" rather than presenting all options (even ones that might not be make sense/that are incorrect). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 02:23:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 00:23:00 +0000 Subject: [Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734 --- Comment #2 from David Cook --- (In reply to Katrin Fischer from comment #1) > Hi David, > > the publication date range search on the advanced search page I think is > based on 008 Date1 - so using 008 for the facet would make sense to me. Good point. I wonder how we should handle dates like uuuu or 190u or 19uu. Maybe it makes sense just to include definite completely numeric dates? Or maybe do a label for uuuu like "Unknown" and change the u to a question mark for other cases like 190? or 19??, perhaps? I wrote a little TT plugin a while ago to change codes into nice labels for the facets, which I think I mentioned to you, but the problem was that it had hardcoded strings :/. Is there a way of maybe using the "language_descriptions" table to use translated strings? We would run into the same problem with a record type facet. Actually...with record type...we could probably use authorized values like we have for item type and shelving location. I suppose that's not hardcoded but I suppose that probably still presents translation issues. Any ideas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 03:20:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 01:20:21 +0000 Subject: [Koha-bugs] [Bug 10755] New: Add "Keyword as Phrase" to staff client advanced search indexes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 Bug ID: 10755 Summary: Add "Keyword as Phrase" to staff client advanced search indexes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, there are "...as Phrase" indexes for title, author, subject, corporate name, personal name, and conference name in the staff client. At the request of several librarians, this patch adds one for "Keyword". While we have had some discussion/debate about the best way to go forward with the available indexes in the OPAC, there's really no reason not to include this one in the staff client, especially since your more advanced searchers are (possibly) going to be librarians using the staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 03:38:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 01:38:17 +0000 Subject: [Koha-bugs] [Bug 10755] Add "Keyword as Phrase" to staff client advanced search indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 03:38:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 01:38:20 +0000 Subject: [Koha-bugs] [Bug 10755] Add "Keyword as Phrase" to staff client advanced search indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 --- Comment #1 from David Cook --- Created attachment 20452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20452&action=edit Bug 10755 - Add "Keyword as Phrase" to staff client advanced search indexes This patch adds a "Keyword as Phrase" index to the search options in the staff client. Test Plan: 1) Go to the Advanced Search in the staff client and click on the "Keyword" drop-down list. 2) Note that there is only a "Keyword" not a "Keyword as Phrase" option 3) Apply the patch 4) Reload the Advanced Search 5) Note that there is now a "Keyword as Phrase" option as well If you want to test the functionality...it will depend on your catalogue data. Basically, a phrase search will allow you to find "Keyword Adjacent To Keyword" rather than a more scattershot search that finds the keywords regardless of their position to each other. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 03:38:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 01:38:35 +0000 Subject: [Koha-bugs] [Bug 10755] Add "Keyword as Phrase" to staff client advanced search indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 04:35:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 02:35:15 +0000 Subject: [Koha-bugs] [Bug 8752] Log circulation renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Assignee|amit.gupta at osslabs.biz |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 04:45:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 02:45:57 +0000 Subject: [Koha-bugs] [Bug 8752] Log circulation renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 04:46:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 02:46:00 +0000 Subject: [Koha-bugs] [Bug 8752] Log circulation renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 --- Comment #1 from David Cook --- Created attachment 20453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20453&action=edit Bug 8752 - Log circulation renewal Currently, circulation renewals are not being logged. This patch logs renewals under the Circulation module with an action of RENEW. At the moment, it relies on the "IssueLog" preference, but we could add a new syspref for "RenewLog". Personally, I figure it's just a "re-issue" so I don't know that we need another preference, but system preferences are cheap, so if people think a follow-up is necessary, I'm open to the idea. Test Plan: 0) Turn on IssueLog and ReturnLog in the system preferences 1) Checkout an item 2) Note that there is a CIRCULATION ISSUE log entry 3) Renew that item 4) Note that there is NOT a log entry 5) Return that item 6) Note that there is a CIRCULATION RETURN log entry 7) Apply patch 8) Repeat Step #3 (i.e. renew that item). 9) Note that there is now a CIRCULATION RENEW log entry N.B. Logs can be viewed by directly querying the database, viewing the Modification Log for the patron attached to the checkout/renew/ return, or by viewing the logs in the Tools module using the item's itemnumber as the "Object". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 04:48:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 02:48:53 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 04:48:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 02:48:57 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19201|0 |1 is obsolete| | Attachment #20276|0 |1 is obsolete| | --- Comment #13 from Srdjan Jankovic --- Created attachment 20454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20454&action=edit Bug 10333: Labels/t_Batch.t needs to create its own data prove t/db_dependent/Labels/t_Batch.t db_dependent/Labels/t_Batch.t .. 1/33 # Testing Batch->new() method. db_dependent/Labels/t_Batch.t .. ok All tests successful. Files=1, Tests=33, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.34 cusr 0.00 csys = 0.37 CPU) Result: PASS Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 04:54:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 02:54:05 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 --- Comment #14 from Srdjan Jankovic --- C4::Items::AddItemBatchFromMarc was failing (no records returned), I had no CPL branches. You may wish to add some check there, but om if you don't (it's that testing data bug request that is still being discussed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 07:52:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 05:52:10 +0000 Subject: [Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734 --- Comment #3 from Katrin Fischer --- > Good point. I wonder how we should handle dates like uuuu or 190u or 19uu. > Maybe it makes sense just to include definite completely numeric dates? Or > maybe do a label for uuuu like "Unknown" and change the u to a question mark > for other cases like 190? or 19??, perhaps? I think the second would make a bit more sense to me. > I wrote a little TT plugin a while ago to change codes into nice labels for > the facets, which I think I mentioned to you, but the problem was that it > had hardcoded strings :/. Hm, not sure I remember. If the strings can be in an include or similar, we can translate them. > Is there a way of maybe using the "language_descriptions" table to use > translated strings? I think that would probably be the best option for a language facet. > We would run into the same problem with a record type facet. I think it is solvable especially when the options and descriptions you want to have are somehow limited by the standard. > Actually...with record type...we could probably use authorized values like > we have for item type and shelving location. I suppose that's not hardcoded > but I suppose that probably still presents translation issues. I always prefer template translation over using authorised values because the latter are one language only currently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 08:00:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 06:00:47 +0000 Subject: [Koha-bugs] [Bug 10078] show location facet for all In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #7 from Katrin Fischer --- Hi David, I had checked for the ids, but somehow I still missed them - sorry! I am setting it back to 'Passed QA', but still a bit worried that this might cause some unhappiness because the item based facets don't work as libraries expect. I recently had some trouble explaining that when it came to new books: When you are are a library with multiple branches a combined search for acquisition date and branch for example doesn't give you the results you'd expect. So in general a more precise way to search item data would be nice, but is out of the scope of this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 08:44:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 06:44:39 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #21 from M. de Rooy --- (In reply to Kyle M Hall from comment #20) > Question, would it not be better to use the KohaDates TT plugin, rather than > using format_date in the source code? This patch does not focus on transition to KohaDates; since format_date from C4::Dates is used several times in the context of this change, I probably copied it. If we change this, we should update them all. But isn't that outside the scope of this report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 08:49:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 06:49:40 +0000 Subject: [Koha-bugs] [Bug 10078] show location facet for all In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078 --- Comment #8 from Katrin Fischer --- Hm maybe for others reading this we should clarify: > 1) If you limit on Branch A and location D, you should get no results in > your scenario. That would be how we want it, but it's not going to happen as for the facets always everything that appears in the record is taken into account. So all item information is mixed together - if you have a branch and a location appearing in your record, the facets will show up, even if the information belongs to different items. > 2) In what scenario would you be able to use both those facets? (Using the > Advanced Search, you could, but that's unrelated to the facets.) Yes, advanced search can give confusing results too - but I think it's a lot less obvious and users are not so likely to try. > If you choose Branch A from the Libraries facet, you would only be presented > with location C as a Locations facet. If you choose location D, you would > only be presented with Branch B as a Libraries facet. Unfortunately that's not the case - see explanation above. > I don't think it's an indexing issue though. From what I've seen so far, it > seems to me that DOM and GRS-1 fill the same indexes, they just do it in > different ways. With DOM indexing, I think, the issue could be solved, but not with GRS - and it's currently not implemented. Just trying to explain why I think this change is likely to cause some confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 08:57:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 06:57:54 +0000 Subject: [Koha-bugs] [Bug 3206] OAI repositry deleted record support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- (In reply to Fr?d?ric Demians from comment #1) > This is an easy enhancement. 'deletedbiblio' table contains all the > information required to add deleted records support to Koha OAI Server. > Currently, selective harvesting replies with added/modified biblio > records. We just have to request 'deletedbiblio' table to send back also > deleted records. Sounds right to me. We'd also need to add in a status element saying "deleted". I suppose declaring the repo "persistent" vs "transient" would depend on if the library ever deletes their deletedbiblio table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 09:10:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 07:10:55 +0000 Subject: [Koha-bugs] [Bug 3206] OAI repositry deleted record support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 --- Comment #3 from David Cook --- (In reply to David Cook from comment #2) > (In reply to Fr?d?ric Demians from comment #1) > > This is an easy enhancement. 'deletedbiblio' table contains all the > > information required to add deleted records support to Koha OAI Server. > > Currently, selective harvesting replies with added/modified biblio > > records. We just have to request 'deletedbiblio' table to send back also > > deleted records. > > Sounds right to me. We'd also need to add in a status element saying > "deleted". I suppose declaring the repo "persistent" vs "transient" would > depend on if the library ever deletes their deletedbiblio table. My mistake...the header element should actually have an attribute with a value of deleted, based on the examples from http://www.openarchives.org/OAI/openarchivesprotocol.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 09:12:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 07:12:18 +0000 Subject: [Koha-bugs] [Bug 10756] New: Carousel Display of New Titles on OPAC home page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Bug ID: 10756 Summary: Carousel Display of New Titles on OPAC home page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: bob at calyx.net.au QA Contact: testopia at bugs.koha-community.org This feature displays recently added items to your Koha's main OPAC page, using a 'carousel' style display. This feature can be enabled/disabled via a Koha syspref, and requires memcached. This feature can be styled and configured using CSS. A demo of the feature (Koha-3.10) is available at http://demo.calyx.net.au This feature adds to Koha the ContentFlow library by JacksAsylum.eu (MIT license): http://jacksasylum.eu/ContentFlow/index.php Special thanks to Harvest Bible College, Australia for sponsoring this feature. Thanks also to Albany Senior High School,New Zealand and KohaAloha for an earlier prototype. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 09:32:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 07:32:45 +0000 Subject: [Koha-bugs] [Bug 10188] Top Most-circulated items doesn't count current loans In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10188 Mayank changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |mayanksri1989 at gmail.com --- Comment #1 from Mayank --- If you generate a report of Most Circulated Items, you get a list of titles and their respective number of checkouts. When you click on one of the titles you see all the details about that record, from that screen you can view the checkout history of that record. The figures of Number of checkouts from the generated report(Most Circulated Items) and the checkout history for that record are different. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 09:33:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 07:33:34 +0000 Subject: [Koha-bugs] [Bug 10757] New: OAI-PMH records should also include setSpec in their headers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10757 Bug ID: 10757 Summary: OAI-PMH records should also include setSpec in their headers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, we're only including datestamp and identifier in the header of outgoing OAI-PMH records. However, according to the spec (http://www.openarchives.org/OAI/openarchivesprotocol.html#Record), it seems that we should also be including elements for setSpec. While our OAI-PMH verbs allow for selective harvesting using setSpec (which is really the most important feature), it seems like we should still be providing the setSpecs (there may be multiple) for outgoing records as well. -- Bug 3206 is another header related bug where we might want to start including the status attribute in the header element for deleted records...(using the deletedbiblios table as per Fr?d?ric's suggestion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 10:04:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 08:04:03 +0000 Subject: [Koha-bugs] [Bug 10108] can't print more than one page of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10108 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6291 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 10:04:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 08:04:03 +0000 Subject: [Koha-bugs] [Bug 6291] Cart printing truncated in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6291 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10108 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 10:07:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 08:07:54 +0000 Subject: [Koha-bugs] [Bug 7279] intranet print.css width settings causing 'squashing' of columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7279 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6291 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 10:07:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 08:07:54 +0000 Subject: [Koha-bugs] [Bug 6291] Cart printing truncated in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6291 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7279 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 10:32:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 08:32:45 +0000 Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than "any" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #16 from mathieu saby --- Thank you Magnus. But even if some conflicts could occur for UNIMARC (and maybe for Marc21 : I did not check, and the patch is rather old now...), you can try to do a 1st test anyway, or just give your opinion about the logic of the patch ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 11:10:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 09:10:00 +0000 Subject: [Koha-bugs] [Bug 9548] Store bibliographic information in aqorders table ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 --- Comment #10 from mathieu saby --- OK My point of view : We should focus on taking into account the deleted tables could be easily done, and backported to 3.12/10/8. For the "freezing" of the basketgroups, it would be a more important enhancement, maybe only for new versions, and it deserves more thinking to find the right solution. Do you agree wuith that ? If so, we could keep this bug for the "freezing", and create a new bug for taking into account the deleted tables ? Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 11:12:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 09:12:47 +0000 Subject: [Koha-bugs] [Bug 9548] Store bibliographic information in aqorders table ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 --- Comment #11 from Katrin Fischer --- Sounds good to me. Maybe change the bug title to reflect the general goal? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 11:14:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 09:14:09 +0000 Subject: [Koha-bugs] [Bug 9548] Add a way to 'freeze' the content of a basket group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Store bibliographic |Add a way to 'freeze' the |information in aqorders |content of a basket group |table ? | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 11:14:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 09:14:33 +0000 Subject: [Koha-bugs] [Bug 9548] Add a way to 'freeze' the content of a basket group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 --- Comment #12 from mathieu saby --- done ;-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 11:16:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 09:16:38 +0000 Subject: [Koha-bugs] [Bug 9548] Add a way to 'freeze' the content of a basket group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 --- Comment #13 from mathieu saby --- I won't have time to create a new bug today for implementing the use of 'deleted*' tables (I'm struggling with inventory...). Do you have time to do that? Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 11:23:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 09:23:23 +0000 Subject: [Koha-bugs] [Bug 10758] New: Show bibliographic information of deleted records in acquisitions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Bug ID: 10758 Summary: Show bibliographic information of deleted records in acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: mathieu.saby at univ-rennes2.fr When a record is deleted the order information in acquisition is missing the title and other information otherwise shown. As we store the information in the deleted* tables we could use that for display. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 11:23:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 09:23:34 +0000 Subject: [Koha-bugs] [Bug 9548] Add a way to 'freeze' the content of a basket group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10758 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 11:23:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 09:23:34 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9548 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 11:27:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 09:27:57 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #1 from mathieu saby --- +1 ;-) Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 12:09:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 10:09:55 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 --- Comment #16 from Jonathan Druart --- I added a new test for qa tools: http://git.koha-community.org/gitweb/?p=qa-test-tools.git;a=commit;h=fa56a572468d7582c20be0149c16ec11b1970deb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 12:45:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 10:45:54 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #14 from M. de Rooy --- Katrin, If I add suggestions from two libraries (and two users), and I leave them in pending state, and I organize by Library, there is only one tab (the first library name) and I see one suggestion in this list from the second library. I had a glance through the code, but it is hard to see [quickly] where this comes from. Could you please check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 12:54:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 10:54:51 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 --- Comment #15 from Katrin Fischer --- Thx for taking a look Marcel - I will try to reproduce. Especially the Library filter is a bit tricky. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 13:00:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 11:00:29 +0000 Subject: [Koha-bugs] [Bug 10236] software error greek authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10236 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl --- Comment #3 from M. de Rooy --- QA Comment: Could not get this to apply in an older 3.8 install (that I did not want to upgrade for this reason). But the 'code' looks good to me. It corrects a trivial typo in a variable name. Setting the status to Pushed to Stable to get attention of Rmaint 3.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 13:00:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 11:00:47 +0000 Subject: [Koha-bugs] [Bug 10236] software error greek authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10236 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 13:44:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 11:44:48 +0000 Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18968|0 |1 is obsolete| | --- Comment #42 from M. de Rooy --- Created attachment 20455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20455&action=edit Bug 7131 - Followup 2 - Allow overlaying by barcode This patch adds the ability to overlay by either itemnumber, or barcode. Itemnumbers take precendence over barcodes, which allows us to batch update item barcodes with an overlay. Test Plan: 1) Create a new record with 2 items, make sure to give it a unique ISBN 2) Download the record as MARCXML 3) Edit the MARC XML a) Delete one of the two items b) Change the barcode in the barcode field to something unused 4) Transform the xml file into marc with xml2marc 5) Browse to 'Stage MARC records for import' 6) Upload the binary marc file 7) Choose the following options: Record matching rule: ISBN Action if matching record found: Ignore incoming record Action if no match is found: Ignore incoming record Check for embedded item record data: Yes How to process items: Replace items if matching bib was found 8) Click 'Stage for import' button 9) Verify a matching record was found, then click 'Manage staged records' link 10) Verify the rules are still set correctly 11) Click 'Import this batch into the catalog' 12) The import should tell you: 1 record was ignored 1 item was replaced 13) View the record details and verify the item's barcode was replaced with your updated barcode value 14) Download the record as MARCXML 15) Edit the MARC XML a) Delete one of the two items b) Delete the itemnumber field for the remaining item c) Alter the item's callnumber to a new value 16) Repeat steps 4 through 12 17) View the record details and verify the item's callnumber was replace with your updated callnumber value Signed-off-by: Henry Bankhead -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 13:45:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 11:45:32 +0000 Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #43 from M. de Rooy --- Trivial rebase for followup no 2 (updatedatabase) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 13:58:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 11:58:27 +0000 Subject: [Koha-bugs] [Bug 10759] New: "Warning: Using a password on the command line interface can be insecure." message Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10759 Bug ID: 10759 Summary: "Warning: Using a password on the command line interface can be insecure." message Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: victorp at netmedia.com.sg QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com MySQL version 5.6.5 and above will now produce a warning message "Warning: Using a password on the command line interface can be insecure." when a MySQL user password is used or prompted from the command line. As such, when the Web Installer is importing .sql files to populate the structures and tables into the Koha database, one will get this warning message for every import. In fact, when the Web Installer is importing the database table structures, it will finish but will not let one to continue importing the basic default settings. However, it is easy to rectify - just run the Web Installer again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 13:58:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 11:58:54 +0000 Subject: [Koha-bugs] [Bug 10759] "Warning: Using a password on the command line interface can be insecure." message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10759 Victor Pang changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:01:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:01:48 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:01:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:01:51 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 --- Comment #51 from Kyle M Hall --- Created attachment 20456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20456&action=edit Bug 7639 - system preference to forgive fines on lost items - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:04:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:04:28 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #22 from Kyle M Hall --- Agreed, it would be better to file a separate bug report later to transition all the calls at once. (In reply to M. de Rooy from comment #21) > (In reply to Kyle M Hall from comment #20) > > Question, would it not be better to use the KohaDates TT plugin, rather than > > using format_date in the source code? > > This patch does not focus on transition to KohaDates; since format_date from > C4::Dates is used several times in the context of this change, I probably > copied it. If we change this, we should update them all. But isn't that > outside the scope of this report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:05:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:05:25 +0000 Subject: [Koha-bugs] [Bug 10760] New: Street Number field is missing from the Alternate Address section Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 Bug ID: 10760 Summary: Street Number field is missing from the Alternate Address section Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: victorp at netmedia.com.sg QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The Street Number field seems to be missing from the Alternate Address section. Peeking into the borrowers table in the Koha database, there is a B_streetnumber field defined but it is not exposed in the Koha GUI interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:05:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:05:59 +0000 Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131 --- Comment #44 from M. de Rooy --- When I import the test file test.marc, no items are created (though the form says that two items have been added). Item processing was Always add items. (There was no match.) BTW My log contains several lines like: stage-marc-import.pl: Filehandle STDOUT reopened as FH only for input at /usr/local/lib64/perl5/Template/Provider.pm line 964., referer: http://libdevelop.rijksmuseum.nl:8009/cgi-bin/koha/tools/stage-marc-import.pl Can you reproduce or clarify? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:11:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:11:14 +0000 Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131 --- Comment #45 from Katrin Fischer --- Hi Marcel, maybe you don't have the branchcode in your installation? There is a known bug for it giving you a false positive message when that is the case and the items are not added. We had this happening quite recently when testing something. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:12:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:12:34 +0000 Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131 --- Comment #46 from Kyle M Hall --- > BTW My log contains several lines like: > stage-marc-import.pl: Filehandle STDOUT reopened as FH only for input at > /usr/local/lib64/perl5/Template/Provider.pm line 964., referer: > http://libdevelop.rijksmuseum.nl:8009/cgi-bin/koha/tools/stage-marc-import.pl I've never seen any errors like that. Do you get them on master? It seems very odd that these patches would trigger those errors, as none of them modify file IO in any way! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:14:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:14:16 +0000 Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131 --- Comment #47 from M. de Rooy --- (In reply to Kyle M Hall from comment #46) > > BTW My log contains several lines like: > > stage-marc-import.pl: Filehandle STDOUT reopened as FH only for input at > > /usr/local/lib64/perl5/Template/Provider.pm line 964., referer: > > http://libdevelop.rijksmuseum.nl:8009/cgi-bin/koha/tools/stage-marc-import.pl > > I've never seen any errors like that. Do you get them on master? It seems > very odd that these patches would trigger those errors, as none of them > modify file IO in any way! Will try the same import without these patches and check the log :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:16:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:16:44 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenza.zaki at biblibre.com --- Comment #10 from kenza --- (In reply to Katrin Fischer from comment #9) > Hi Owen, > could you rebase your patch please? I tried but might have gone wrong > somewhere. Would it be possible that you provide a unit test for the changed > sub delete_report? I can provide the unit test for delete_report if necessary. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:18:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:18:23 +0000 Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131 --- Comment #48 from M. de Rooy --- > Will try the same import without these patches and check the log :) The import step produces these warnings already in current master for me.. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:24:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:24:47 +0000 Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131 --- Comment #49 from M. de Rooy --- (In reply to Katrin Fischer from comment #45) > Hi Marcel, maybe you don't have the branchcode in your installation? There > is a known bug for it giving you a false positive message when that is the > case and the items are not added. We had this happening quite recently when > testing something. Katrin, Thanks! I found that bug 6852. So I understand that the item contains a branchcode, and if that is not found, it just reports Fine but adds no items. Great :) I added MPL for this report and now the items appear. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:26:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:26:27 +0000 Subject: [Koha-bugs] [Bug 10754] HomeOrHoldingBranch and CircControl are described identically in the system preference editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5159 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:26:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:26:27 +0000 Subject: [Koha-bugs] [Bug 5159] HomeOrHoldingBranch syspref description misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5159 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10754 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:27:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:27:31 +0000 Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:29:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:29:38 +0000 Subject: [Koha-bugs] [Bug 3765] Road Types and Street Numbers on Patron Rec Inconsistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3765 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10760 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:29:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:29:38 +0000 Subject: [Koha-bugs] [Bug 10760] Street Number field is missing from the Alternate Address section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3765 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 14:46:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 12:46:49 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 --- Comment #2 from mathieu saby --- I think it deserves P3 or P4 priority Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:06:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:06:18 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #36 from mathieu saby --- Do you know if this feature really work in the past? I find strange to pay again to fix a feature broken by somebody's code 2 or 3 years ago. Is not it really possible to fix this feature, and to make an other bug for improving safety ? M. Saby -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:09:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:09:28 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart --- QA comment: All looks good. Note that 1 authorized value named "WTHDRAWN" still exists. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:09:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:09:48 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20179|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 20457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20457&action=edit Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Save for translation files (that will be fixed on next release), only occurrence of wthdrawn is on updatedatabase.pl No koha-qa errors. This touch many files, and I did not test everything, but all seems normal. I think that any problem could be fixed later. Perhaps both entries in updatedatabase.pl could be joined into one, but thats for QA. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:09:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:09:53 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #13 from Jonathan Druart --- Created attachment 20458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20458&action=edit Bug 10550: Merge 2 updatedatabase entries into 1 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:21:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:21:15 +0000 Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131 --- Comment #50 from M. de Rooy --- Step-by-step :) If I import with matching and no match is found, it follows Add incoming record, but if i chose Replace existing items for Item processing, now I am facing that the record is added but no items are added/replaced. This makes me wonder if we also need some two-way choice for item processing: what if we found a match and what if we did not? Or would it make more sense to just add items when there is no match and the items rule is Replace? Note that the combo already contains two conditional options (add only if..). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:29:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:29:32 +0000 Subject: [Koha-bugs] [Bug 10761] New: UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 Bug ID: 10761 Summary: UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:30:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:30:07 +0000 Subject: [Koha-bugs] [Bug 10761] UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki at biblibre.com Depends on| |3134 Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:30:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:30:07 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10761 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:33:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:33:17 +0000 Subject: [Koha-bugs] [Bug 10704] Search term highlighting doesn't work beyond the first results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #5 from Jonathan Druart --- QA comment: Simple patch. Fix the described issue. I will c/p the test plan on my SO patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:33:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:33:35 +0000 Subject: [Koha-bugs] [Bug 10704] Search term highlighting doesn't work beyond the first results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20218|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 20459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20459&action=edit Bug 10704: Hit highlighting not working on Previous & Next buttons To test Enable 'OpacHighlightedWords' 1) Run a search with multiple results 2) Click on a title of one of the results to get the full record display. Hit highlighting SHOULD work on this page. 3) Use either the "Next" or "Previous" buttons on this page (opac-detail) to move to the next or previous record. 4) Moving forward or back, the highlighting should still be working on the page. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:34:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:34:56 +0000 Subject: [Koha-bugs] [Bug 10761] UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:34:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:34:58 +0000 Subject: [Koha-bugs] [Bug 10761] UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 --- Comment #1 from kenza --- Created attachment 20460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20460&action=edit Bug 10761:UT:save_report and delete_report in C4::Reports::Report_Guided.pm need unit tests The test are wrap in a transaction. Note : The last test (in comment) currently doesn't pass because it needs some modifications of delete_report. To test: prove t/db_dependent/Reports_Guided.t t/db_dependent/Reports_Guided.t .. ok All tests successful. Files=1, Tests=7, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.28 cusr 0.02 csys = 0.32 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:36:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:36:27 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #11 from kenza --- (In reply to kenza from comment #10) > (In reply to Katrin Fischer from comment #9) > > Hi Owen, > > could you rebase your patch please? I tried but might have gone wrong > > somewhere. Would it be possible that you provide a unit test for the changed > > sub delete_report? > > I can provide the unit test for delete_report if necessary. Bug 10761 - UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:37:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:37:04 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #12 from Owen Leonard --- (In reply to kenza from comment #10) > I can provide the unit test for delete_report if necessary. I would appreciate that very much kenza. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:39:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:39:09 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- (In reply to Martin Renvoize from comment #4) > Note for QA.. I'm sure there's a follow-up required for this patch with the > correct DB additions for adding a syspref, but I'm reminding myself on the > etiquette for that before submitting the follow-up. Martin, take a look at the installer/data/mysql/updatedatabase.pl file. You should add a new entry (as the 3.13.00.015 entry). You have to add the new syspref to the installer/data/mysql/sysprefs.sql file too. This patch does not apply anymore. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:47:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:47:54 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:47:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:47:56 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19843|0 |1 is obsolete| | --- Comment #13 from Owen Leonard --- Created attachment 20461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20461&action=edit [SIGNED-OFF] Bug 3134 - Ability to selelct multiple reports to delete at once This patch adds the option to select multiple saved reports for deletion. To test you must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. Signed-off-by: Liz Rea Functional tests pass, template tests pass. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:55:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:55:42 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r Summary|Ability to selelct multiple |Ability to select multiple |reports to delete at once |reports to delete at once -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:56:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:56:05 +0000 Subject: [Koha-bugs] [Bug 10728] subscription-renew generates unnecessary warnings in logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20337|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 20462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20462&action=edit Bug 10728: fix log noise generated by subscription-renew.pl Error log is showing warnings because mode is undefined and we are doing string comparisons on it. Set it to a default value (we were already assigning it a variable which we were not using) and use the the result in the comparison To test, after applying the patch: [1] Use the renew link from the subscription detail page to renew a subscription. [2] Verifying that doing this did not add a warning containing 'subscription-renew.pl: Use of uninitialized value $mode in string eq ' to the Apache error log. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:56:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:56:09 +0000 Subject: [Koha-bugs] [Bug 10728] subscription-renew generates unnecessary warnings in logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20338|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 20463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20463&action=edit bug 10728: fix additional log noise generated by subscription-renew.pl To test: [1] Use the renew link to bring up the subscription renewal form. [2] Verify that a warning message containing the text 'Problem = a value of 1 has been passed to param without key' was not added to the Apache error log. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 15:56:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 13:56:20 +0000 Subject: [Koha-bugs] [Bug 10728] subscription-renew generates unnecessary warnings in logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:01:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:01:06 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #14 from Jonathan Druart --- QA comment: The first column contains the report id *and* a checkbox => checkboxes are not aligned. I suspect a wrong rebase. I think we want only the checkbox. Marked as Failed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:02:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:02:01 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #15 from Jonathan Druart --- (In reply to Jonathan Druart from comment #14) > QA comment: > > The first column contains the report id *and* a checkbox => checkboxes are > not aligned. I suspect a wrong rebase. I think we want only the checkbox. > > Marked as Failed QA. Or maybe the checkbox should be before the id. Like that, checkboxes will be aligned. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:05:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:05:54 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #56 from Koha Team Lyon 3 --- Hello, I test this patch with a sandbox. Everything seems to work as define in the test plan. I try only with 3 orders. But, as katrin mentionned, in the csv file, the header wasn't translate in french... Can you verify before I change the status in "signed off" Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:06:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:06:15 +0000 Subject: [Koha-bugs] [Bug 10762] New: Not able to adjust size of barcode numbers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Bug ID: 10762 Summary: Not able to adjust size of barcode numbers Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jesse at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org I created a new layout (section 2.5.3.1 in the manual) that just shows the barcode, and I set the font size big. First I did 14, then 32 just to make sure my eyes weren't deceiving me. The numbers below the barcode didn't change size! It seems like the font settings only affect the bibliographic data. What I want to change is the barcode number itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:11:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:11:15 +0000 Subject: [Koha-bugs] [Bug 10728] subscription-renew generates unnecessary warnings in logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:16:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:16:02 +0000 Subject: [Koha-bugs] [Bug 10704] Search term highlighting doesn't work beyond the first results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:24:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:24:32 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #57 from Jonathan Druart --- (In reply to Koha Team Lyon 3 from comment #56) > Hello, > I test this patch with a sandbox. Everything seems to work as define in the > test plan. I try only with 3 orders. > But, as katrin mentionned, in the csv file, the header wasn't translate in > french... > Can you verify before I change the status in "signed off" > Sonia Hello Sonia, Headers are new strings, so they are not translatable on sandboxes without a manual modification of po files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:27:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:27:32 +0000 Subject: [Koha-bugs] [Bug 10761] UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20460|0 |1 is obsolete| | --- Comment #2 from kenza --- Created attachment 20464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20464&action=edit Bug 10761:UT:save_report and delete_report in C4::Reports::Report_Guided.pm need unit tests The test are wrap in a transaction. Note : The last test (in comment) currently doesn't pass because it needs some modifications of delete_report. To test: prove t/db_dependent/Reports_Guided.t t/db_dependent/Reports_Guided.t .. ok All tests successful. Files=1, Tests=7, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.28 cusr 0.02 csys = 0.32 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:30:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:30:28 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #16 from Owen Leonard --- Created attachment 20465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20465&action=edit Bug 3134 [Follow-up] Ability to select multiple reports to delete at once This follow-up moves the checkboxes into a separate column from the report ID in order to prevent visual inconsistencies. To test, repeat the test plan from the original patch: You must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:31:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:31:20 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:40:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:40:27 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:40:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:40:30 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19970|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 20466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20466&action=edit Bug 10625 - Inventory/Stocktaking tool cannot handle windows file uploads The inventory/stocktaking tool interprets windows text editor file as a single large barcode because the text editor only uses carriage returns for line breaks, rather than a carriage return and line break combination. This tools should be able to handle \r, \n, and/or \r\n. Test Plan: 1) Download the attached sample file of barcodes 2) Upload this file to the inventory/stocktaking tool. For this test, it doesn't matter that these barcodes aren't cataloged in your system. 3) Note that the "barcode not found" is a single extremely long barcode 4) Apply this patch 5) Repeat step 2 6) Note that you now get a "barcode not found" error for each barcode individually. Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:40:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:40:41 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:40:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:40:49 +0000 Subject: [Koha-bugs] [Bug 7684] inventory : datatable fix actions etc. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10625 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:40:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:40:49 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7684 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:41:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:41:45 +0000 Subject: [Koha-bugs] [Bug 9931] marc_subfield_structure.tt should get the floating toolbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9931 --- Comment #1 from Owen Leonard --- Is this necessary now that the page uses the jQueryUI accordion plugin to show/hide sections? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:46:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:46:19 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #80 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Kohateam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:47:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:47:29 +0000 Subject: [Koha-bugs] [Bug 7684] inventory : datatable fix actions etc. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18705|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart --- Created attachment 20467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20467&action=edit Bug 7684: multiple fixes for inventory * when a file was uploaded and the comparison with catalogue range requested, the comparison was wrong: the logic was wrong * items that were not supposed to be scanned (ie: supposed to be on another shelf) didn't had the author and title, it was hard to retrieve them on the shelved * some useful fields were missing, like homebranch, location, status * the CSV export contained all the item information. It should contain the same informations as the screen Behaviour now: * scan a list of barcode & select a range of location * if a barcode has been scanned and should not be (mis placed item), the information is displayed * if you choose "compare barcodes list to result option", the resulting list contains all items that have been scanned and those that were supposed to be. Any item not in both list appears with a specific message on the last column Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:47:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:47:36 +0000 Subject: [Koha-bugs] [Bug 7684] inventory : datatable fix actions etc. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19215|0 |1 is obsolete| | --- Comment #55 from Jonathan Druart --- Created attachment 20468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20468&action=edit Bug 7684: QA Followup and bugfixes This followup fixes some QA issues: - replace the MySQLism SQL_CALC_FOUND_ROWS - use Koha::DateUtils instead of C4::Dates - replace "branch" and "location" with "library" - fixe wrong capitalisation on "Clear all" and "Select all" and fixes some behaviors: - the inventory tools can be used without barcode file (fixed for the csv export too). - mark as not scanned a non scanned item. - update the datelastseen 1 time per biblio (and fixes the displayed count) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:53:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:53:16 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #81 from Koha Team Lyon 3 --- Tested on a sandbox. For me, everything is working as expected. I can't see if the translation is ok. I'm not bothered by the fact of pop-up is a full-sized window in a new tab... This patch will be really useful for the librarians who manage commands. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:56:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:56:09 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20240|0 |1 is obsolete| | Status|ASSIGNED |Needs Signoff Assignee|savitra.sirohi at osslabs.biz |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Created attachment 20469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20469&action=edit Patch to add syspref controlled stopwords to highlighting Updated to apply to current master and also added db updates as suggested by Jonathan (thanks for the reminder). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:56:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:56:12 +0000 Subject: [Koha-bugs] [Bug 8670] Update POD of C4::Branch::GetBranches() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8670 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nengard at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:58:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:58:25 +0000 Subject: [Koha-bugs] [Bug 8670] Update POD of C4::Branch::GetBranches() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8670 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:58:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:58:27 +0000 Subject: [Koha-bugs] [Bug 9916] Use DataTables in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- Pushed to master, along with some follow-ups to set the default sort order on some pages back to where it was before this patch. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 16:58:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 14:58:28 +0000 Subject: [Koha-bugs] [Bug 8670] Update POD of C4::Branch::GetBranches() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8670 --- Comment #2 from Owen Leonard --- Created attachment 20470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20470&action=edit Bug 8670 - Update POD of C4::Branch::GetBranches() to use TT syntax This patch updates the example template syntax in the POD for C4::Branch::GetBranches() to use Template Toolkit syntax. To test, view the POD for C4::Branch::GetBranches() and confirm that it looks correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:00:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:00:18 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #58 from sandboxes at biblibre.com --- Patch tested with a sandbox, by sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:00:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:00:49 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:00:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:00:54 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20313|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:01:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:01:00 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:01:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:01:07 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20315|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:01:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:01:16 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #59 from sandboxes at biblibre.com --- Created attachment 20471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20471&action=edit Bug 7298 Export late orders as csv This patch allows to export late orders as csv. Test plan: - Go on the late orders page (acqui/lateorders.pl) - Select one or more order and click on the button "export as CSV". - The generated file should contains some information on the orders (order date, estimated delivery date, vendor name, information field, cost, basket name (and basketid), claims count and the claimed date) The last line of the file is the total of orders. - You are not allow to select order from different vendor. - The check/uncheck all links appears only if a vendor is selected. - Check that the check/uncheck works for all pages of the table. Signed-off-by: Nicole C. Engard Signed-off-by: Mathieu Saby Signed-off-by: Paul Poulain Signed-off-by: sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:01:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:01:20 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #60 from sandboxes at biblibre.com --- Created attachment 20472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20472&action=edit Bug 7298: Follow-up fixing capitalization and moving supplier id Fixes a few capitalization errors on the late orders page like - Claim orders - filter - Search results Also moves the supplierid from the order date column to the vendor column. Signed-off-by: Jonathan Druart Signed-off-by: sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:01:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:01:23 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #61 from sandboxes at biblibre.com --- Created attachment 20473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20473&action=edit Bug 7298: FIX checkboxes binding on load Click on checkboxes should be bound on load. Signed-off-by: sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:01:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:01:27 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #62 from sandboxes at biblibre.com --- Created attachment 20474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20474&action=edit Bug 7298: CSV strings are translatables. Using a template file, the CSV headers become translatable. Signed-off-by: sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:02:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:02:57 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #63 from Koha Team Lyon 3 --- Hello Jonathan. So for me everything works fine. I change in Signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:14:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:14:45 +0000 Subject: [Koha-bugs] [Bug 10763] New: Update POD of C4::Creators::Lib::html_table() to use TT syntax Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10763 Bug ID: 10763 Summary: Update POD of C4::Creators::Lib::html_table() to use TT syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Documentation Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The POD of C4::Creators::Lib::html_table() has an example of how to create an HTML table based on the output of the function, but it uses the old template syntax, not TT syntax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:15:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:15:46 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10441|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:16:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:16:47 +0000 Subject: [Koha-bugs] [Bug 10701] In transit information doesn't display on the bibliographic detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:18:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:18:11 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #64 from Jonathan Druart --- (In reply to Koha Team Lyon 3 from comment #63) > Hello Jonathan. So for me everything works fine. I change in Signed off. Thanks for testing Sonia! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:18:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:18:51 +0000 Subject: [Koha-bugs] [Bug 10763] Update POD of C4::Creators::Lib::html_table() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10763 --- Comment #1 from Owen Leonard --- Created attachment 20475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20475&action=edit Bug 10763 - Update POD of C4::Creators::Lib::html_table() to use TT syntax This patch updates the example template syntax in the POD for C4::Creators::Lib::html_table() to use Template Toolkit syntax. To test, view the POD for C4::Creators::Lib::html_table() and confirm that it looks correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:18:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:18:49 +0000 Subject: [Koha-bugs] [Bug 10763] Update POD of C4::Creators::Lib::html_table() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10763 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:20:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:20:36 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19917|0 |1 is obsolete| | Attachment #19918|0 |1 is obsolete| | Attachment #19919|0 |1 is obsolete| | Attachment #19920|0 |1 is obsolete| | Attachment #19921|0 |1 is obsolete| | Attachment #19922|0 |1 is obsolete| | --- Comment #82 from Jonathan Druart --- Created attachment 20476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20476&action=edit Bug 5349: Order line transfers On basket.pl and parcel.pl there is a 'Transfer' link which allow you to transfer order lines from a basket to another. The link lead to a new page which allow you to search for a bookseller, then display this bookseller's baskets. Then you can pickup a basket and the transfer will be done. This add a message in new column aqorders.internalnotes which is displayed in basket.pl Signed-off-by: Marc Veron Signed-off-by: Mathieu Saby Signed-off-by: sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:20:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:20:42 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #83 from Jonathan Druart --- Created attachment 20477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20477&action=edit Bug 5349 follow-up: run transferorder.pl in a popup Signed-off-by: Marc Veron Signed-off-by: Mathieu Saby Signed-off-by: sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:20:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:20:48 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #84 from Jonathan Druart --- Created attachment 20478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20478&action=edit Bug 5349: Fix a logical test in TransferOrder Signed-off-by: Mathieu Saby Signed-off-by: sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:20:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:20:53 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #85 from Jonathan Druart --- Created attachment 20479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20479&action=edit Bug 5349: Add unit tests for TransferOrder Signed-off-by: sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:20:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:20:59 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #86 from Jonathan Druart --- Created attachment 20480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20480&action=edit Bug 5349: Use DB transaction/rollback in unit tests Signed-off-by: sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:21:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:21:05 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #87 from Jonathan Druart --- Created attachment 20481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20481&action=edit Bug 5349: Create a table for order line transfers This allow to keep transfers informations without having untranslatable strings in database. Signed-off-by: sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:23:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:23:09 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #88 from Jonathan Druart --- Note: The sandbox fails to signoff these patchs. Error from the WWW::Bugzilla package: WWW::Mechanize find_all_links gave us a bogus URL at ./cron/sandbox_signoff.cron line 78. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:31:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:31:23 +0000 Subject: [Koha-bugs] [Bug 9931] marc_subfield_structure.tt should get the floating toolbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9931 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Tom?s Cohen Arazi --- As Owen answered, now we use the jQueryUI accordion plugin, there's no need for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:34:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:34:23 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #23 from Galen Charlton --- (In reply to Kyle M Hall from comment #8) > > 3 should we keep the information limitless ? In France, I think it would be > > illegal, as all libraries must use tools/cleanborrowers.pl. Shouldn't we add > > an option in this script to remove information after a specific period, even > > if the patron is still the last borrower ? > > This I don't think will work, as the data never expiring what this is all > about! This feature is not enabled by default so I don't think that should > be a problem, right? There's a difference between keeping a link to the last borrower for a longer period of time and keeping it forever. Consequently, I agree with Paul's suggestion that cleanborrowers.pl should have an option to clear issues.last_returned_by after a specified amount of time. However, since the new feature is not on by default, I do not consider this a blocker for pushing the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:36:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:36:05 +0000 Subject: [Koha-bugs] [Bug 10764] New: Update POD of C4::Items::GetItemStatus() to use TT syntax Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Bug ID: 10764 Summary: Update POD of C4::Items::GetItemStatus() to use TT syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Documentation Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The POD of C4::Items::GetItemStatus() has an example of how to create a selector based on the output of the function, but it uses the old template syntax, not TT syntax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:39:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:39:17 +0000 Subject: [Koha-bugs] [Bug 10764] Update POD of C4::Items::GetItemStatus() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 17:39:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 15:39:19 +0000 Subject: [Koha-bugs] [Bug 10764] Update POD of C4::Items::GetItemStatus() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 --- Comment #1 from Owen Leonard --- Created attachment 20482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20482&action=edit Bug 10764 - Update POD of C4::Items::GetItemStatus() to use TT syntax This patch updates the example template syntax in the POD for C4::Items::GetItemStatus() to use Template Toolkit syntax. To test, view the POD for C4::Items::GetItemStatus() and confirm that it looks correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 18:06:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 16:06:14 +0000 Subject: [Koha-bugs] [Bug 10765] New: Update POD of C4::Koha::GetSupportList() to use TT syntax Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10765 Bug ID: 10765 Summary: Update POD of C4::Koha::GetSupportList() to use TT syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Documentation Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The POD of C4::Koha::GetSupportList() has an example of how to create an item type selector based on the output of the function, but it uses the old template syntax, not TT syntax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 18:08:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 16:08:08 +0000 Subject: [Koha-bugs] [Bug 10765] Update POD of C4::Koha::GetSupportList() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10765 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 18:08:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 16:08:12 +0000 Subject: [Koha-bugs] [Bug 10765] Update POD of C4::Koha::GetSupportList() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10765 --- Comment #1 from Owen Leonard --- Created attachment 20483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20483&action=edit Bug 10765 - Update POD of C4::Koha::GetSupportList() to use TT syntax This patch updates the example template syntax in the POD for C4::Koha::GetSupportList() to use Template Toolkit syntax. To test, view the POD for C4::Koha::GetSupportList() and confirm that it looks correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 18:13:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 16:13:09 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #24 from Galen Charlton --- Comment on attachment 20343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20343 Bug 9011 - QA Followup Review of attachment 20343: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9011&attachment=20343) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt @@ +214,4 @@ > >
  • Last seen:[% IF ( ITEM_DAT.datelastseen ) %][% ITEM_DAT.datelastseen | $KohaDates %] [%END %] 
  • >
  • Last borrowed:[% IF (ITEM_DAT.datelastborrowed ) %][% ITEM_DAT.datelastborrowed | $KohaDates %][% END %] 
  • > + [% IF ( ITEM_DAT.last_returned_by && Koha.Preference('StoreLastBorrower') && !Koha.Preference('AnonymousPatron') ) %]
  • Last returned by: [% KohaBorrowers.BorrowernumberToCardnumber( ITEM_DAT.last_returned_by ) %] 
  • [% END %] Is "Koha.Preference('AnonymousPatron')" what is meant, not "!Koha.Preference('AnonymousPatron')"? The AnonymousPatron system preference is not a Boolean, it's the borrowernumber of the record to which anonymized transactions should be linked. Consequently, I think the QA follow-up has exactly the opposite of the intended effect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 18:16:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 16:16:50 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #25 from Galen Charlton --- Setting to In Discussion and requesting a response from Jonathan to the question I asked in my previous comment. Broader question: do we really need another field in the items table? Why not just tweak AnonymiseIssueHistory() so that if StoreLastBorrower is set, old_issue rows that are the most recent return for their items are not anonymized? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 18:25:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 16:25:25 +0000 Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Hardware|PC |All Assignee|colin.campbell at ptfs-europe. |oleonard at myacpl.org |com | Severity|enhancement |normal -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 18:35:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 16:35:21 +0000 Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 18:35:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 16:35:25 +0000 Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934 --- Comment #1 from Owen Leonard --- Created attachment 20484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20484&action=edit Bug 3934 - move test prediction pattern button On the subscription add/edit screen the buttons related to numbering patterns are grouped with the "save" button, which is potentially confusing. This patch moves the buttons into the "serials planning" region so they are visually grouped with related functionality. Unrelated changes: Removed a few redundant "javascript:" pseudo-protocols from event handlers, and added a "Cancel" link. To test, edit an existing subscription and confirm that the prediction pattern buttons are grouped inside the "serials planning" region. Confirm that each button triggers the correct event. Confirm that clicking the "cancel" link returns you to the subscription detail view. Also test creating a new subscription. Again buttons should work correctly. The "Cancel" link should return you to the Serials module home page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 18:40:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 16:40:34 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 19:46:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 17:46:18 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- The sample file does not actually use \r\n as its delimiter -- it's using \r. Can you confirm the source of the sample file you attached to the bug, as does not appear to actually be produced by a Windows text editor -- or in any event, not one that uses the DOS newline. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 20:18:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 18:18:52 +0000 Subject: [Koha-bugs] [Bug 10766] New: Cataloging reservoir search broken if UseQueryParser is off Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10766 Bug ID: 10766 Summary: Cataloging reservoir search broken if UseQueryParser is off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Commit 144c7f4e caused a regression on reservoir search. When UseQueryParser is off, the $query variable is munged to include an index specifier -- for example, "harry" becomes "kw,wrdl,rtrn=harry". However, BreedingSearch() does not recognize that form of query. Consequently, when UseQueryParser is off, cataloging search will essentially never turn up any results from the reservoir. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 20:26:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 18:26:44 +0000 Subject: [Koha-bugs] [Bug 10766] Cataloging reservoir search broken if UseQueryParser is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10766 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 20:26:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 18:26:47 +0000 Subject: [Koha-bugs] [Bug 10766] Cataloging reservoir search broken if UseQueryParser is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10766 --- Comment #1 from Galen Charlton --- Created attachment 20485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20485&action=edit Bug 10766: unbreak reservoir search when UseQueryParser is OFF To test: [1] Turn UseQueryParser off. [2] Ensure that your database has records in the reservoir. Performing a Z39.50 search will do this. [3] Perform a broad cataloging (i.e., cataloguing/addbooks.pl search). Note that results are returned from the main catalog but that no reservoir results are returned. [4] Apply the patch. [5] Perform the search again. This time, there should be both catalog and reservoir results. [7] Enable QueryParser. Perform the search again, and verify that the catalog and reservoir results are the same. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 21:12:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 19:12:48 +0000 Subject: [Koha-bugs] [Bug 10130] Input fields for branch configuration are too short In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 21:12:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 19:12:50 +0000 Subject: [Koha-bugs] [Bug 10130] Input fields for branch configuration are too short In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 --- Comment #1 from Owen Leonard --- Created attachment 20486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20486&action=edit Bug 10130 - Input fields for branch configuration are too short Most input fields in the library entry form (admin/branches.pl) have no explicit with, so they display with a browser-default width. This patch gives explicit widths to those fields, giving more room for entry. Other fields have been given an explicit width and/or maxwidth according to the database table structure. To test, add or edit a library in Administration -> Libraries and Groups. Form fields should be more comfortable for entry, and add/edit actions should complete correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 21:30:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 19:30:41 +0000 Subject: [Koha-bugs] [Bug 10047] Cataloguing search maybe useless? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- (In reply to Nicole C. Engard from comment #5) > The history of this is that the cataloging search used to be the only place > with the edit items and edit record links ... but now that's on the regular > search as well so I agree it's still to have two searches. I think the > cataloging search should only search the reservoir and be renamed such. Not entirely true, you could always edit biblios and items from the staff Catalogue, even as far back as 1.0. Back then there was also the catalogue maintenance module where you could undelete biblio and items, and move items to different biblioitems (groups). Cataloguing search has also always been there, because yes it searches not only what is in the catalogue but what has been staged also. In one search. I'd like to be sure people aren't using it before we attempt yet another refactoring exercise and cause regressions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 21:35:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 19:35:46 +0000 Subject: [Koha-bugs] [Bug 9862] Cart image and footer are removed when i search for something in opac using Solr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9862 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |Searching Summary|Cart image and footer are |Cart image and footer are |removed when i search for |removed when i search for |something in opac |something in opac using | |Solr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 21:37:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 19:37:31 +0000 Subject: [Koha-bugs] [Bug 10047] Cataloguing search maybe useless? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047 --- Comment #8 from Galen Charlton --- An additional point -- there are targets where it can cost money to perform Z39.50 searches ... per search! I believe that this was the case with OCLC at one point, and there may be other cases. The reservoir offers a way of reducing cataloging costs by checking it first before resorting to a Z39.50 search. How well this works in practice, I don't know, but I would be curious to hear from catalogers who use Koha on a daily basis. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 22:23:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 20:23:53 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 19 22:23:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Aug 2013 20:23:57 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20456|0 |1 is obsolete| | --- Comment #52 from Katrin Fischer --- Created attachment 20487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20487&action=edit [PASSED QA] Bug 7639 - system preference to forgive fines on lost items - Add Unit Tests Signed-off-by: Katrin Fischer All tests and QA script pass. I fixed a redundant 'my' that the QA script pointed out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 07:51:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 05:51:19 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 07:51:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 05:51:22 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18485|0 |1 is obsolete| | Attachment #18486|0 |1 is obsolete| | Attachment #20231|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 20488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20488&action=edit [PASSED QA] Bug 10314 - CanItemBeReserved does not respect the holds policies CanItemBeReserved will return 1 as long as the circulation rules have a non-zero number of holds allowed and the patron hasn't reached his or her "Holds allowed" count. However, the subroutine completely ignores the holds policies which would contravene reserving the item even if the patron has not reached the maximum holds allowed count. Test Plan: 1) Place an item on hold for a patron 2) Clear any existing hold policies 3) Set the appropriate circ rule so that the patron should be allowed 4) Attempt to place am item-level hold for this item/patron, it should succeed 5) Create a hold policy rule that would stop this patron from placing a hold on this item 6) Attempt to place an item-level hold on this item/patron, it should fail, but instead it will succeed 7) Apply this patch 8) Repeat step 6, this time you should be unable to place a specific hold on this item Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 07:51:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 05:51:37 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 --- Comment #8 from Katrin Fischer --- Created attachment 20489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20489&action=edit [PASSED QA] Bug 10314 - CanItemBeReserved does not respect the holds policies - Followup - Tidy up CanItemBeReserved Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 07:51:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 05:51:45 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 --- Comment #9 from Katrin Fischer --- Created attachment 20490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20490&action=edit [PASSED QA] Bug 10314 - CanItemBeReserved does not respect the holds policies - Followup - QA Bugfix Signed-off-by: Katrin Fischer Passes all tests and QA script. Note: Unit tests to ensure the fix has the desired effect and behaviour is not accidentally changed in the future should be added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 07:53:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 05:53:30 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Passing QA as this is kind of a bad bug - we shouldn't offer configuration options that are not taken into account. But some unit tests would be really nice to have... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 07:54:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 05:54:27 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #30 from David Cook --- (In reply to Magnus Enger from comment #29) > (In reply to M. de Rooy from comment #28) > > What I did mean, was: If we let the user just once insert http or https for > > his server, and we do not prefix it anymore, we have a solution.. > > But isn't it possible to have the same domain available both with and > without HTTPS? So both of these can work at the same time: > http://koha.example.org/ > https://koha.example.org/ > > Then it would seem to be a bad idea to "hard code" the protocol in a > syspref, and better to figure it out on a per request basis, perhaps? I think figuring it out on a per request basis is probably best, but it seems like there is a problem using the CGI method https() when Plack is in use, yes? I know next to nothing about Plack but maybe something like this? (https://github.com/plack/Plack/wiki/How-to-detect-reverse-proxy-and-SSL-frontend). Now that I think about it, if you're using a proxy, CGI->https() will probably always return NO too unless one's using SSL internally too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 08:13:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 06:13:08 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 --- Comment #31 from David Cook --- It's also worth noting that Internet Explorer and at least one feedreader I've tried renders RSS links incorrectly if http or https isn't included with the URL. For some reason, it treats them like relative links, which makes a useless URL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 08:42:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 06:42:28 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Hi Kyle, the code does look alright, but I tried testing it and it didn't give me the results I expected. I turned on the cost matrix and entered and made it look something like this: A B A _ 0 B 0 _ Now I am in A, putting a hold on a record with items from A and B, pickup location is B. I would expect the routine to pick up the available item from B, but it doesn't. I have reran build_holds_queue multiple times. Any hints? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 08:52:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 06:52:37 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 --- Comment #12 from Katrin Fischer --- I made sure that there are no hold policies set in circulation rules, there are only items from A and B and they are all of the same itemtype. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 08:57:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 06:57:28 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 --- Comment #13 from Katrin Fischer --- I found it... my items were checked out... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 08:58:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 06:58:13 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 08:58:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 06:58:16 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20052|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 20491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20491&action=edit [PASSED QA] Bug 10628 - AutomaticItemReturn prevents holds queue from filling local holds with local items For some reason, C4::HoldsQueue::MapItemsToHoldRequests uses the system preference AutomaticItemReturn to decide if an attempt to fill local holds with local items. No explanation of this behavior is provided. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Passes QA script and adds unit tests. Tested with some examples and those worked correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 09:18:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 07:18:43 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #26 from Jonathan Druart --- (In reply to Galen Charlton from comment #24) > Comment on attachment 20343 [details] [review] > Bug 9011 - QA Followup > > Review of attachment 20343 [details] [review]: > ----------------------------------------------------------------- > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt > @@ +214,4 @@ > > > >
  • Last seen:[% IF ( ITEM_DAT.datelastseen ) %][% ITEM_DAT.datelastseen | $KohaDates %] [%END %] 
  • > >
  • Last borrowed:[% IF (ITEM_DAT.datelastborrowed ) %][% ITEM_DAT.datelastborrowed | $KohaDates %][% END %] 
  • > > + [% IF ( ITEM_DAT.last_returned_by && Koha.Preference('StoreLastBorrower') && !Koha.Preference('AnonymousPatron') ) %]
  • Last returned by: [% KohaBorrowers.BorrowernumberToCardnumber( ITEM_DAT.last_returned_by ) %] 
  • [% END %] > > Is "Koha.Preference('AnonymousPatron')" what is meant, not > "!Koha.Preference('AnonymousPatron')"? > > The AnonymousPatron system preference is not a Boolean, it's the > borrowernumber of the record to which anonymized transactions should be > linked. > > Consequently, I think the QA follow-up has exactly the opposite of the > intended effect. If the pref AnonymousPatron is set to 0, that means that the feature is disabled. Else, it contains a borrowernumber and the feature is enabled. So !Koha.Preference('AnonymousPatron') means: the feature is enabled, we want to display the "last returned by" value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 09:25:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 07:25:39 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #27 from Jonathan Druart --- (In reply to Galen Charlton from comment #25) > Setting to In Discussion and requesting a response from Jonathan to the > question I asked in my previous comment. > > Broader question: do we really need another field in the items table? Why > not just tweak AnonymiseIssueHistory() so that if StoreLastBorrower is set, > old_issue rows that are the most recent return for their items are not > anonymized? If anonymouspatron is enabled, C4::Circ::MarkIssueReturn can change the borrowernumber with the anonymouspatron value. So the information does not exist in the old_issues table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 09:44:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 07:44:54 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #6 from Jonathan Druart --- (In reply to Galen Charlton from comment #5) > The sample file does not actually use \r\n as its delimiter -- it's using \r. > > Can you confirm the source of the sample file you attached to the bug, as > does not appear to actually be produced by a Windows text editor -- or in > any event, not one that uses the DOS newline. Galen, yes you are right, \r\n is under windows and it worked before this patch. But \r (Mac OS) did not worked before. The sample file contains \r. I tested the \r\n too : I added a newline character after \r in order to have a \r\n and it still works with the patch. Maybe should we change the commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 09:50:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 07:50:22 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #7 from Jonathan Druart --- With vim, you can use :set ff=[unix dos mac] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 09:56:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 07:56:47 +0000 Subject: [Koha-bugs] [Bug 9862] Cart image and footer are removed when i search for something in opac using Solr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9862 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |LATER --- Comment #3 from Jonathan Druart --- Maybe, one day... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:07:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:07:06 +0000 Subject: [Koha-bugs] [Bug 8670] Update POD of C4::Branch::GetBranches() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8670 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:07:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:07:09 +0000 Subject: [Koha-bugs] [Bug 8670] Update POD of C4::Branch::GetBranches() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8670 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20470|0 |1 is obsolete| | --- Comment #3 from Magnus Enger --- Created attachment 20492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20492&action=edit Bug 8670 - Update POD of C4::Branch::GetBranches() to use TT syntax This patch updates the example template syntax in the POD for C4::Branch::GetBranches() to use Template Toolkit syntax. To test, view the POD for C4::Branch::GetBranches() and confirm that it looks correct. Signed-off-by: Magnus Enger Checked the POD with "perldoc C4/Branch.pm" before and after applying the patch. The example now uses TT syntax, and looks sensible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:08:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:08:50 +0000 Subject: [Koha-bugs] [Bug 8670] Update POD of C4::Branch::GetBranches() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8670 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10763, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10764, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10765 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:08:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:08:50 +0000 Subject: [Koha-bugs] [Bug 10763] Update POD of C4::Creators::Lib::html_table() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10763 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8670 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:08:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:08:50 +0000 Subject: [Koha-bugs] [Bug 10764] Update POD of C4::Items::GetItemStatus() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8670 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:08:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:08:50 +0000 Subject: [Koha-bugs] [Bug 10765] Update POD of C4::Koha::GetSupportList() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10765 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8670 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:13:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:13:05 +0000 Subject: [Koha-bugs] [Bug 10763] Update POD of C4::Creators::Lib::html_table() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10763 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:13:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:13:08 +0000 Subject: [Koha-bugs] [Bug 10763] Update POD of C4::Creators::Lib::html_table() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10763 --- Comment #2 from Magnus Enger --- Created attachment 20493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20493&action=edit Bug 10763 - [SIGNED-OFF] Update POD of C4::Creators::Lib::html_table() to use TT syntax This patch updates the example template syntax in the POD for C4::Creators::Lib::html_table() to use Template Toolkit syntax. To test, view the POD for C4::Creators::Lib::html_table() and confirm that it looks correct. Signed-off-by: Magnus Enger Checked the POD with "perldoc C4/Creators/Lib.pm" before and after applying the patch. The example now uses TT syntax, and looks sensible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:13:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:13:30 +0000 Subject: [Koha-bugs] [Bug 10763] Update POD of C4::Creators::Lib::html_table() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10763 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20475|0 |1 is obsolete| | CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:21:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:21:19 +0000 Subject: [Koha-bugs] [Bug 10764] Update POD of C4::Items::GetItemStatus() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:21:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:21:22 +0000 Subject: [Koha-bugs] [Bug 10764] Update POD of C4::Items::GetItemStatus() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20482|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 20494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20494&action=edit Bug 10764 - Update POD of C4::Items::GetItemStatus() to use TT syntax This patch updates the example template syntax in the POD for C4::Items::GetItemStatus() to use Template Toolkit syntax. To test, view the POD for C4::Items::GetItemStatus() and confirm that it looks correct. Signed-off-by: Magnus Enger This patch works as advertised (verified with "perldoc C4::Items"), for GetItemStatus, but it does not fix a a similar example for GetItemLocation in the same file, which still has the old template syntax. So a followup or separate bug for that is called for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:24:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:24:35 +0000 Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- This template has been completely rewritten by bug 7688 (Passed QA). Maybe it would be wise to wait until it is pushed to master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:27:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:27:55 +0000 Subject: [Koha-bugs] [Bug 10765] Update POD of C4::Koha::GetSupportList() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10765 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:27:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:27:58 +0000 Subject: [Koha-bugs] [Bug 10765] Update POD of C4::Koha::GetSupportList() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10765 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20483|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 20495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20495&action=edit Bug 10765 - [SIGNED-OFF] Update POD of C4::Koha::GetSupportList() to use TT syntax This patch updates the example template syntax in the POD for C4::Koha::GetSupportList() to use Template Toolkit syntax. To test, view the POD for C4::Koha::GetSupportList() and confirm that it looks correct. Signed-off-by: Magnus Enger This patch works as advertised (verified with "perldoc C4::Koha"), for GetSupportList, but it does not fix a a similar example for GetItemTypes, getauthtypes and getframework in the same file, which still has the old template syntax. So a followup or separate bug(s) for those are called for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:37:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:37:35 +0000 Subject: [Koha-bugs] [Bug 10767] New: UT: Routines which interact with the table issuingrules in C4/Circulation need unit test Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10767 Bug ID: 10767 Summary: UT: Routines which interact with the table issuingrules in C4/Circulation need unit test Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org Test for GetHardDueDate GetIssuingRule GetLoanLength -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:38:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:38:00 +0000 Subject: [Koha-bugs] [Bug 10767] UT: Routines which interact with the table issuingrules in C4/Circulation need unit test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10767 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki at biblibre.com Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:43:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:43:31 +0000 Subject: [Koha-bugs] [Bug 10767] UT: Routines which interact with the table issuingrules in C4/Circulation need unit test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10767 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 10:43:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 08:43:33 +0000 Subject: [Koha-bugs] [Bug 10767] UT: Routines which interact with the table issuingrules in C4/Circulation need unit test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10767 --- Comment #1 from kenza --- Created attachment 20496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20496&action=edit Bug 10767: UT:Routines which interact with the table issuingrules in C4/Circulation need unit tests The test are wrap in a transaction. NOTE: Some tests (in comment) don't pass, the routines have to be fixed To test: prove t/db_dependent/Circulation_Issuingrule.t t/db_dependent/Circulation_Issuingrule.t .. ok All tests successful. Files=1, Tests=9, 17 wallclock secs ( 0.02 usr 0.00 sys + 0.34 cusr 0.04 csys = 0.40 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 11:02:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 09:02:29 +0000 Subject: [Koha-bugs] [Bug 7494] Use partial barcode or callnumber as a fallback for the barcode search in checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7494 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #18 from Magnus Enger --- Searching Bugzilla for itemBarcodeFallbackSearch did not turn up this bug, but with this comment it will. :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 11:04:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 09:04:22 +0000 Subject: [Koha-bugs] [Bug 10411] Add cache control headers to static resources in the apache config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #8 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 11:09:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 09:09:05 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #16 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 11:09:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 09:09:43 +0000 Subject: [Koha-bugs] [Bug 7494] Use partial barcode or callnumber as a fallback for the barcode search in checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7494 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10768 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 11:09:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 09:09:43 +0000 Subject: [Koha-bugs] [Bug 10768] New: Improve the interface related to itemBarcodeFallbackSearch Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10768 Bug ID: 10768 Summary: Improve the interface related to itemBarcodeFallbackSearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 7494 Created attachment 20497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20497&action=edit Screenshot from the documentation Bug 7494 introduced a really nice feature, and the itemBarcodeFallbackSearch syspref. Here are a couple of suggestions for improving the interface related to this syspref: - When the syspref is on, change the text above the barcode field from "Enter item barcode" to something like "Enter item barcode or keyword" - In the yellow warning box, make the phrase that was searched for stand out more. Now it is just run into one string like in the attached screenshot from the manual: "The barcode was not found outside the book Fast cataloging". "outside the book" in this example could be e.g. in bold or italics. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 11:10:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 09:10:23 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #101 from Chris Hall --- Latest patches have been pushed to 3.8.x and will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 11:14:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 09:14:33 +0000 Subject: [Koha-bugs] [Bug 10448] Changing framework when cataloguing clears all fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10448 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #11 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 11:16:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 09:16:33 +0000 Subject: [Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #15 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 11:20:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 09:20:07 +0000 Subject: [Koha-bugs] [Bug 10422] Remove references to unused and non-existent wizard.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10422 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #7 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 11:23:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 09:23:35 +0000 Subject: [Koha-bugs] [Bug 10527] C4::Branch::get_branch_code_from_name is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10527 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #7 from Chris Hall --- pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 11:26:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 09:26:14 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #14 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 11:53:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 09:53:29 +0000 Subject: [Koha-bugs] [Bug 10127] Printoverdues.sh should tar only pdf files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10127 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #13 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 11:55:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 09:55:12 +0000 Subject: [Koha-bugs] [Bug 10563] Link to edit subscription from 'check expiraton' page is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10563 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #7 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 13:45:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 11:45:56 +0000 Subject: [Koha-bugs] [Bug 8670] Update POD of C4::Branch::GetBranches() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20492|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 20498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20498&action=edit Bug 8670 - Update POD of C4::Branch::GetBranches() to use TT syntax This patch updates the example template syntax in the POD for C4::Branch::GetBranches() to use Template Toolkit syntax. To test, view the POD for C4::Branch::GetBranches() and confirm that it looks correct. Signed-off-by: Magnus Enger Checked the POD with "perldoc C4/Branch.pm" before and after applying the patch. The example now uses TT syntax, and looks sensible. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 13:45:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 11:45:53 +0000 Subject: [Koha-bugs] [Bug 8670] Update POD of C4::Branch::GetBranches() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 13:46:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 11:46:08 +0000 Subject: [Koha-bugs] [Bug 8670] Update POD of C4::Branch::GetBranches() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 13:47:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 11:47:46 +0000 Subject: [Koha-bugs] [Bug 10763] Update POD of C4::Creators::Lib::html_table() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10763 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 13:47:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 11:47:50 +0000 Subject: [Koha-bugs] [Bug 10763] Update POD of C4::Creators::Lib::html_table() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10763 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20493|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 20499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20499&action=edit Bug 10763 - [SIGNED-OFF] Update POD of C4::Creators::Lib::html_table() to use TT syntax This patch updates the example template syntax in the POD for C4::Creators::Lib::html_table() to use Template Toolkit syntax. To test, view the POD for C4::Creators::Lib::html_table() and confirm that it looks correct. Signed-off-by: Magnus Enger Checked the POD with "perldoc C4/Creators/Lib.pm" before and after applying the patch. The example now uses TT syntax, and looks sensible. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 13:48:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 11:48:01 +0000 Subject: [Koha-bugs] [Bug 10763] Update POD of C4::Creators::Lib::html_table() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10763 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 13:51:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 11:51:48 +0000 Subject: [Koha-bugs] [Bug 10764] Update POD of C4::Items::GetItemStatus() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 13:51:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 11:51:51 +0000 Subject: [Koha-bugs] [Bug 10764] Update POD of C4::Items::GetItemStatus() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20494|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 20500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20500&action=edit Bug 10764 - Update POD of C4::Items::GetItemStatus() to use TT syntax This patch updates the example template syntax in the POD for C4::Items::GetItemStatus() to use Template Toolkit syntax. To test, view the POD for C4::Items::GetItemStatus() and confirm that it looks correct. Signed-off-by: Magnus Enger This patch works as advertised (verified with "perldoc C4::Items"), for GetItemStatus, but it does not fix a a similar example for GetItemLocation in the same file, which still has the old template syntax. So a followup or separate bug for that is called for. Signed-off-by: Jonathan Druart It seems the default option is not in used in templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 13:52:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 11:52:00 +0000 Subject: [Koha-bugs] [Bug 10764] Update POD of C4::Items::GetItemStatus() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 13:54:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 11:54:38 +0000 Subject: [Koha-bugs] [Bug 10765] Update POD of C4::Koha::GetSupportList() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10765 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20495|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 20501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20501&action=edit Bug 10765 - [SIGNED-OFF] Update POD of C4::Koha::GetSupportList() to use TT syntax This patch updates the example template syntax in the POD for C4::Koha::GetSupportList() to use Template Toolkit syntax. To test, view the POD for C4::Koha::GetSupportList() and confirm that it looks correct. Signed-off-by: Magnus Enger This patch works as advertised (verified with "perldoc C4::Koha"), for GetSupportList, but it does not fix a a similar example for GetItemTypes, getauthtypes and getframework in the same file, which still has the old template syntax. So a followup or separate bug(s) for those are called for. Signed-off-by: Jonathan Druart It seems the default option is not in used in templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 13:54:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 11:54:35 +0000 Subject: [Koha-bugs] [Bug 10765] Update POD of C4::Koha::GetSupportList() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10765 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 13:54:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 11:54:55 +0000 Subject: [Koha-bugs] [Bug 10765] Update POD of C4::Koha::GetSupportList() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10765 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 15:03:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 13:03:39 +0000 Subject: [Koha-bugs] [Bug 10769] New: Simplify clearing of input fields when duplicating a patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10769 Bug ID: 10769 Summary: Simplify clearing of input fields when duplicating a patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently the patron entry template has a lot of logic handling form fields when the operation being performed is "duplicate:" [% IF ( opduplicate ) %] [% ELSE %] [% END %] I propose to set a class on fields which require this behavior so that the event can be handled in the script block. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 15:22:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 13:22:59 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20040|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 20502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20502&action=edit Bug 10656 - shelving locations not alpha on search Collection codes and shelving locations are displayed in the OPAC and staff client via GetAuthorisedValues which currently sorts results by "lib, lib_opac." Consequently if lib (the description for the staff client) doesn't match lib_opac (the description for the OPAC) sorting will appear to be nonsensical in the OPAC. GetAuthorisedValues can be passed an $opac parameter, so this should be used to switch how reuslts are sorted. This patch implements such a switch. To test, modify your collection code or shelving location authorized values so that lib and lib_opac do not match. Set your AdvancedSearchTypes system preference to display the modified authorized values and view the advanced search page in the OPAC and staff client. Sorting should be correct in each case according to the correct value (lib in the staff client, lib_opac in the OPAC). Signed-off-by: Nicole C. Engard Tested in staff and opac and it works perfectly! Signed-off-by: Jonathan Druart I did not test the patch but the change looks logical. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 15:22:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 13:22:56 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 15:23:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 13:23:12 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 15:26:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 13:26:59 +0000 Subject: [Koha-bugs] [Bug 10769] Simplify clearing of input fields when duplicating a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10769 --- Comment #1 from Owen Leonard --- Created attachment 20503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20503&action=edit Bug 10769 - Simplify clearing of input fields when duplicating a patron When duplicating a patron record an onclick event is added to many fields in order to make then clear when focused. This patch updates the template so that the logic for this can be simplified. A template variable is set based on the 'opduplicate' variable, and a class added to the relevant fields. All fields with that class are cleared on focus. Also changed are several markup issues which were causing validation errors. To test, find or create a patron record which has all standard text fields filled with data. Use the "duplicate" button on the detail view of that patron to initiate the duplication process. Focus on each field in the patron entry form in succession. Fields which contain data should be cleared in the same way they were before the patch. Also test a regular edit operation to confirm that fields are not cleared. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 15:26:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 13:26:56 +0000 Subject: [Koha-bugs] [Bug 10769] Simplify clearing of input fields when duplicating a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10769 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 15:33:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 13:33:16 +0000 Subject: [Koha-bugs] [Bug 10081] IndependentBranches error message missing the library name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 15:33:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 13:33:19 +0000 Subject: [Koha-bugs] [Bug 10081] IndependentBranches error message missing the library name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20331|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 20504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20504&action=edit Bug 10081: add library name to IndependentBranches error message With IndependentBranches turned on, if you try to check out an item which belongs to another library you will get an error message which is missing the library name. This patch corrects the problem by passing the necessary variable to the template and outputting the library name using the KohaBranchName TT plugin. To test, turn on IndependentBranches and try to check out an item belonging to another library (note that you must test with a staff user who is not a superlibrarian). The error message you see should include the name of the library to which the item belongs: "This item belongs to Nelsonville and cannot be checked out from this location." Checkouts of items belonging to the library should be unaffected. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 15:33:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 13:33:35 +0000 Subject: [Koha-bugs] [Bug 10081] IndependentBranches error message missing the library name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 16:22:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 14:22:37 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #26 from Jonathan Druart --- QA comment: The code: - Perltidies the new file please. - Use the CPLv3 license: FAIL opac/opac-shareshelf.pl FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) - The new letter should be added to others languages. - The new pl file contains a lot of routines. Some of them use global variables which are not defined as global. - Maybe SHARE_INVITATION_EXPIRY_DAYS should be a new syspref? Hum... or not. - Note that ADDDATE is a mysqlism, but Koha doesn't offer a better way to do. The ergonomic: - The page opac-shelves.pl?display=privateshelves displays a link for editing and deleting, but a button for sharing. Is it intentional? - There is no back button if I enter a bad email address. The feature: The invitation is sent to the message queue. The doc suggests process_message_queue.pl runs every 1 to 4 hours. We can imagine that a user tells to his friend: "I just share a list with you. You will receive an email!". The friend refresh, refresh, refresh his inbox and nothing append. The guy will resent the invitation again and again :) I have 2 suggestions: * directly use the sendmail command. * Add a check: if an invitation for this list and this email address has been sent some time ago, an alert is raised and no new invitation is sent. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 16:27:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 14:27:01 +0000 Subject: [Koha-bugs] [Bug 10081] IndependentBranches error message missing the library name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 16:33:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 14:33:00 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 --- Comment #11 from Jonathan Druart --- Created attachment 20505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20505&action=edit Bug 10441: UT: Create patrons for Virtualshelves.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 16:33:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 14:33:15 +0000 Subject: [Koha-bugs] [Bug 8670] Update POD of C4::Branch::GetBranches() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8670 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 16:33:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 14:33:36 +0000 Subject: [Koha-bugs] [Bug 10763] Update POD of C4::Creators::Lib::html_table() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10763 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 16:33:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 14:33:48 +0000 Subject: [Koha-bugs] [Bug 10764] Update POD of C4::Items::GetItemStatus() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 16:34:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 14:34:03 +0000 Subject: [Koha-bugs] [Bug 10765] Update POD of C4::Koha::GetSupportList() to use TT syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10765 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 17:38:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 15:38:50 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Galen Charlton --- Pushed to master. Thanks, Kyle! By the way, Srdjan, since you had written the code that added the dependence on AutomaticItemReturn to MapItemsToHoldRequests(), I'm taking your participation in the bug discussion as tacit agreement that there isn't a known use case for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 17:56:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 15:56:13 +0000 Subject: [Koha-bugs] [Bug 10770] New: reserve slip don't print correctly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10770 Bug ID: 10770 Summary: reserve slip don't print correctly Change sponsored?: --- Product: Koha Version: 3.8 Hardware: PC OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hi, Code html put on RESERVESLIP do not print correctly all fields. Here the code put in RESERVESLIP:

    Date: <>

    Expire le <>

    Pour <> <>

    <>, <>
    <>

    Document r?serv?

    Titre: <>
    Auteur: <>
    Cote:<>
    Mis de c?t? depuis le <>

    Notes:

    <>

    Then the first print, the field reserves.expirationdate, items.itemcallnumber and reserves.waitingdate did not print. On the other side when i print a second time, all fields are print. Thanks. Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 18:07:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 16:07:43 +0000 Subject: [Koha-bugs] [Bug 10743] add style to privacy rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 18:07:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 16:07:46 +0000 Subject: [Koha-bugs] [Bug 10743] add style to privacy rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20413|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 20506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20506&action=edit [SIGNED-OFF] Bug 10743: Add styles to 'my privacy' page in OPAC This patch does a couple things. Most importantly it adds a new div around the privacy rules summary so that it can be easily changed. It also moves the start of the form to right above the form's select box so that it's not in the new privacy rules div. To test: * Apply patch * Enable the use of privacy via the sys prefs * Log in to the OPAC * Visit the 'my privacy' tab * Make sure it looks okay * Submit the form and make sure it works * Repeat in the other theme Signed-off-by: Owen Leonard Edit: Replaced a few tabs with spaces to keep the QA script happy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 18:20:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 16:20:17 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #11 from Galen Charlton --- (In reply to Kyle M Hall from comment #1) > 5) Create a hold policy rule that would stop this patron from placing > a hold on this item > 6) Attempt to place an item-level hold on this item/patron, it should > fail, but instead it will succeed How exactly are you managing to place the item-level hold? Both request.pl and opac-request.pl do call GetBranchItemRule(), and any items that cannot be requested because of the policy are prevented from being selected: http://screencast.com/t/pOF9zM4IChk Of course, maybe I'm just missing another avenue for a patron or staff user to manage to place such requests. To be clear, I'm not opposed to the general idea of the change -- for one thing, the ILS-DI and SIP hold placement code currently doesn't do enough checking, so moving checks into CanItemBeReserved() can certainly simplify things. Also, it looks like it might be useful as a way of preventing patrons from placing forbidden hold requests by manipulating the parameters passed to opac-request.pl. That said, unless there's more of a visible way for users to bypass the library/item-type hold policies, I think this patch can be held back a bit longer for: - unit tests - removing calls to GetBranchItemRule() that would be made redundant by this change - (maybe) tweaking the return of CanItemBeReserved() so that higher-level code can distinguish between an item not being requestable due to a patron exceeding the limit and to it not being requestable because of library/item-type policy. Per a discussion I had with Katrin, I'm setting this to in discussion so that she can review her testing notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 19:45:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 17:45:32 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 19:45:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 17:45:35 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20502|0 |1 is obsolete| | --- Comment #9 from Galen Charlton --- Created attachment 20507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20507&action=edit Bug 10656: add regression test This patch adds regression tests to verify the sort order when fetching authorised values in either staff or OPAC mode. This patch also wraps the Koha.t tests in a transaction, and better handles skipping tests if Test::Deep is not installed. To test: [1] Verify that prove -v t/db_dependent/Koha.t passes Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 19:45:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 17:45:41 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 --- Comment #10 from Galen Charlton --- Created attachment 20508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20508&action=edit Bug 10656: improve sorting of shelving location and collections on OPAC advanced search form Collection codes and shelving locations are displayed in the OPAC and staff client via GetAuthorisedValues which currently sorts results by "lib, lib_opac." Consequently if lib (the description for the staff client) doesn't match lib_opac (the description for the OPAC) sorting will appear to be nonsensical in the OPAC. GetAuthorisedValues can be passed an $opac parameter, so this should be used to switch how reuslts are sorted. This patch implements such a switch. To test, modify your collection code or shelving location authorized values so that lib and lib_opac do not match. Set your AdvancedSearchTypes system preference to display the modified authorized values and view the advanced search page in the OPAC and staff client. Sorting should be correct in each case according to the correct value (lib in the staff client, lib_opac in the OPAC). Signed-off-by: Nicole C. Engard Tested in staff and opac and it works perfectly! Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 19:45:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 17:45:45 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 --- Comment #11 from Galen Charlton --- Created attachment 20509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20509&action=edit Bug 10656: (follow-up) handle OPAC sorting of authvals where lib_opac is NULL The OPAC description for an authorized value is not required to be populated. In particular, if it is NULL, the staff description is displayed instead. This match makes sure that the sort order (in OPAC mode) uses either the staff description or the OPAC description as needed for each value. To test: [1] Make sure that AdvancedSearchTypes includes "ccode" [1] Arrange your CCODE values so the sort order for staff labels is different from the sort order for OPAC descriptions. Also, ensure that one of the OPAC descriptions is NULL. For example, authorised_value | lib | lib_opac -------------------------------------- ZZZ | A_STAFF | Z_PUBLIC DDD | D_STAFF | NULL AAA | Z_STAFF | A_PUBLIC [2] Prior to the patch, any CCODE values where the OPAC description is NULL will sort first in the OPAC advanced search page, even if the displayed label shouldn't come first. [3] Apply the patch. [4] Verify that the collection list on the OPAC advanced search page is now correct. [5] Verify that the sort order on the staff advanced search page has not changed. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 19:48:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 17:48:08 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- Sometimes patches that appear to be trivially correct ... aren't. On the other hand, if you really want to get my attention, combining a signoff with a note that one has not actually tested the patch in question is a very good way to do so. :) I've added a regression test and a follow-up that handles the case when lib_opac is null. Setting to signed-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 20:11:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 18:11:48 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #8 from Galen Charlton --- (In reply to Jonathan Druart from comment #6) > Galen, yes you are right, \r\n is under windows and it worked before this > patch. > But \r (Mac OS) did not worked before. Ancient versions of Mac OS, not recent ones. Are there folks actually using MacOS 9 or earlier with Koha? > The sample file contains \r. > I tested the \r\n too : I added a newline character after \r in order to > have a \r\n and it still works with the patch. DOS/Windows line endings also worked without the patch -- see commit 890f673d64e2. Since the use of File::Slurp means loading the entire input barcode file into memory, this patch also changes the performance characters of the inventory tool when processing very large files. Admittedly, this may not be a big deal in practice, but I would appreciate confirmation as to whether there are barcode scanners or other utilities that are *actually* producing files that use \r as a delimiter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 21:03:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 19:03:28 +0000 Subject: [Koha-bugs] [Bug 10771] New: three disused scripts in misc/cronjobs/stats should be removed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Bug ID: 10771 Summary: three disused scripts in misc/cronjobs/stats should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org The following scripts in misc/cronjobs/stats/ were added in 2008: monthly_circulation_statistics.pl monthly_new_items_statistics.pl monthly_new_patron_statistics.pl The commit message indicate that they were added for the Athens County Public Library. IRC conversation with Owen Leonard today indicates that ACPL doesn't use them at present. The commit message also says that "they don't work 100% with stock 3.0 yet". All three scripts make reference to a column that doesn't exist, biblioitems.ccode, and attempts to run them result in a lot of warning messages. There's been next to no work on them over the years. Consequently, I think that they should be removed as dead code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 21:04:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 19:04:05 +0000 Subject: [Koha-bugs] [Bug 10426] Remove unused sub GetCcodes from C4::Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Depends on| |10771 --- Comment #4 from Galen Charlton --- (In reply to Kyle M Hall from comment #3) > In addition to Srdjan's comment, this sub is used in > misc/cronjobs/stats/monthly_circulation_statistics.pl > > To remove the GetCcodes sub, this script will need to be refactored or > deleted. This may not be a long term blocker. See bug 10771. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 21:04:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 19:04:05 +0000 Subject: [Koha-bugs] [Bug 10771] three disused scripts in misc/cronjobs/stats should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10426 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 21:05:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 19:05:20 +0000 Subject: [Koha-bugs] [Bug 10426] Remove unused sub GetCcodes from C4::Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 --- Comment #5 from Galen Charlton --- (In reply to Srdjan Jankovic from comment #2) > Needs removing from t/db_dependent/lib/KohaTest/Koha.pm as well I guess. Yes, but not necessarily a blocker overall: see bug 10539. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 21:07:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 19:07:22 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10426 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 21:07:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 19:07:22 +0000 Subject: [Koha-bugs] [Bug 10426] Remove unused sub GetCcodes from C4::Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Depends on| |10539 --- Comment #6 from Galen Charlton --- On balance, I think the issues raised by Srdjan and Kyle need not block testing and signoff of the proposed patch, although the dependent bugs will block pushing to master. Setting to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 21:17:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 19:17:32 +0000 Subject: [Koha-bugs] [Bug 10771] three disused scripts in misc/cronjobs/stats should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 21:17:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 19:17:35 +0000 Subject: [Koha-bugs] [Bug 10771] three disused scripts in misc/cronjobs/stats should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 --- Comment #1 from Galen Charlton --- Created attachment 20510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20510&action=edit Bug 10771: remove disused statistical reports cronjobs This patch removes three cronjobs that are believed to be unused for the following reasons: [1] The commit message that introduces them indicates that they were written for a particular library. A staff member from that library has confirmed that they are not in use. [2] The scripts have received essentially no patches since they were introduced except for being caught up in a broader code-improvement patch. [3] They refer to a column that no longer exists in biblioitems. [4] They no longer adhere to guidelines for command-line utilities, and there's been no sign that anybody has felt the urge to correct that. [5] They are not referenced by another code or the manual, and the mailing list archives do not include any substantive discussion of their use. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 21:29:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 19:29:15 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #18 from mathieu saby --- Kyle, there is a problem in master when you try to copy the LAST field of the record you destroy to the destination record (942 field in your example). The problem occur even withou this patch. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 21:39:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 19:39:08 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #27 from Galen Charlton --- (In reply to Jonathan Druart from comment #26) > The invitation is sent to the message queue. The doc suggests > process_message_queue.pl runs every 1 to 4 hours. We can imagine that a user > tells to his friend: "I just share a list with you. You will receive an > email!". The friend refresh, refresh, refresh his inbox and nothing append. > The guy will resent the invitation again and again :) > I have 2 suggestions: > * directly use the sendmail command. I disagree with this. There is nothing preventing process_message_queue.pl from being run more frequently; in fact, the crontab that goes with the Debian package runs it every 15 minutes -- and it would be reasonable for a library to run it more frequently. I would be loath to give up the centralization and templating options that the message queue gives us. I see that crontab.example does need to be updated, though: it runs the message queue every hour, and it probably wouldn't hurt to bump up the frequencye. > * Add a check: if an invitation for this list and this email address has > been sent some time ago, an alert is raised and no new invitation is sent. This would be reasonable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 21:53:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 19:53:12 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #28 from Owen Leonard --- (In reply to Galen Charlton from comment #27) > I disagree with this. There is nothing preventing process_message_queue.pl > from being run more frequently; This is the same issue that came up in discussions of Bug 7067 - allow patron self registration via the opac. If your patrons are registering through the OPAC and expecting a confirmation email you would want process_message_queue.pl to run as often as once a minute. The snag is that then your message queue "digest" options don't work because the digest never has the time to accumulate messages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 22:15:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 20:15:38 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #29 from Galen Charlton --- (In reply to Owen Leonard from comment #28) > (In reply to Galen Charlton from comment #27) > > I disagree with this. There is nothing preventing process_message_queue.pl > > from being run more frequently; > > This is the same issue that came up in discussions of Bug 7067 - allow > patron self registration via the opac. If your patrons are registering > through the OPAC and expecting a confirmation email you would want > process_message_queue.pl to run as often as once a minute. The snag is that > then your message queue "digest" options don't work because the digest never > has the time to accumulate messages. Fair point. One possibility would be to allow certain message types be marked as high-priority (which would include the interpretation that they're not meant to ever be digested), then add a switch to process_message_queue.pl to have it process just the high-priority ones. I'm willing to put a bit of time into that if folks are amenable to this approach. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 22:45:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 20:45:31 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #30 from Katrin Fischer --- I think the only messages digested like Owen describes are the checkin and checkout slips - so maybe we could turn it around and have a setting to only send those out every x minutes? I think the other mails could be sent out pretty immediately after being generated without problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 22:58:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 20:58:59 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 23:07:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 21:07:04 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 23:07:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 21:07:07 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19761|0 |1 is obsolete| | Attachment #19762|0 |1 is obsolete| | Attachment #19770|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Created attachment 20511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20511&action=edit [SIGNED-OFf] Bug 10656: add regression test This patch adds regression tests to verify the sort order when fetching authorised values in either staff or OPAC mode. This patch also wraps the Koha.t tests in a transaction, and better handles skipping tests if Test::Deep is not installed. To test: [1] Verify that prove -v t/db_dependent/Koha.t passes Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer Tests pass with all patches applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 23:10:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 21:10:20 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19761|1 |0 is obsolete| | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 23:10:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 21:10:33 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20511|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 23:11:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 21:11:30 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19762|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 23:11:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 21:11:51 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19770|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 23:12:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 21:12:26 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #21 from Katrin Fischer --- Sorry... typoed the bug number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 23:13:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 21:13:08 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20507|0 |1 is obsolete| | Attachment #20508|0 |1 is obsolete| | Attachment #20509|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 20512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20512&action=edit [SIGNED-OFF] Bug 10656: add regression test This patch adds regression tests to verify the sort order when fetching authorised values in either staff or OPAC mode. This patch also wraps the Koha.t tests in a transaction, and better handles skipping tests if Test::Deep is not installed. To test: [1] Verify that prove -v t/db_dependent/Koha.t passes Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer Tests pass with all patches applied. http://bugs.koha-community.org/show_bug.cgi?id=10565 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 23:13:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 21:13:20 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 --- Comment #14 from Katrin Fischer --- Created attachment 20513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20513&action=edit [SIGNED OFF] Bug 10656: improve sorting of shelving location and collections on OPAC advanced search form Collection codes and shelving locations are displayed in the OPAC and staff client via GetAuthorisedValues which currently sorts results by "lib, lib_opac." Consequently if lib (the description for the staff client) doesn't match lib_opac (the description for the OPAC) sorting will appear to be nonsensical in the OPAC. GetAuthorisedValues can be passed an $opac parameter, so this should be used to switch how reuslts are sorted. This patch implements such a switch. To test, modify your collection code or shelving location authorized values so that lib and lib_opac do not match. Set your AdvancedSearchTypes system preference to display the modified authorized values and view the advanced search page in the OPAC and staff client. Sorting should be correct in each case according to the correct value (lib in the staff client, lib_opac in the OPAC). Signed-off-by: Nicole C. Engard Tested in staff and opac and it works perfectly! Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 23:13:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 21:13:30 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 --- Comment #15 from Katrin Fischer --- Created attachment 20514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20514&action=edit [SIGNED OFF] Bug 10656: (follow-up) handle OPAC sorting of authvals where lib_opac is NULL The OPAC description for an authorized value is not required to be populated. In particular, if it is NULL, the staff description is displayed instead. This match makes sure that the sort order (in OPAC mode) uses either the staff description or the OPAC description as needed for each value. To test: [1] Make sure that AdvancedSearchTypes includes "ccode" [1] Arrange your CCODE values so the sort order for staff labels is different from the sort order for OPAC descriptions. Also, ensure that one of the OPAC descriptions is NULL. For example, authorised_value | lib | lib_opac -------------------------------------- ZZZ | A_STAFF | Z_PUBLIC DDD | D_STAFF | NULL AAA | Z_STAFF | A_PUBLIC [2] Prior to the patch, any CCODE values where the OPAC description is NULL will sort first in the OPAC advanced search page, even if the displayed label shouldn't come first. [3] Apply the patch. [4] Verify that the collection list on the OPAC advanced search page is now correct. [5] Verify that the sort order on the staff advanced search page has not changed. Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer Works nicely, tested in staff and OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 23:42:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 21:42:19 +0000 Subject: [Koha-bugs] [Bug 10761] UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 23:42:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 21:42:22 +0000 Subject: [Koha-bugs] [Bug 10761] UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20464|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20515&action=edit [SIGNED OFF] Bug 10761:UT:save_report and delete_report in C4::Reports::Report_Guided.pm need unit tests The test are wrap in a transaction. Note : The last test (in comment) currently doesn't pass because it needs some modifications of delete_report. To test: prove t/db_dependent/Reports_Guided.t t/db_dependent/Reports_Guided.t .. ok All tests successful. Files=1, Tests=7, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.28 cusr 0.02 csys = 0.32 CPU) Result: PASS Signed-off-by: Katrin Fischer Works nicely, tested with patch for bug 10761 applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 23:43:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 21:43:24 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 23:43:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 21:43:27 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20461|0 |1 is obsolete| | Attachment #20465|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 20516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20516&action=edit [SIGNED-OFF] Bug 3134 - Ability to selelct multiple reports to delete at once This patch adds the option to select multiple saved reports for deletion. To test you must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. Signed-off-by: Liz Rea Functional tests pass, template tests pass. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 20 23:43:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Aug 2013 21:43:41 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #18 from Katrin Fischer --- Created attachment 20517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20517&action=edit [SIGNED OFF] Bug 3134 [Follow-up] Ability to select multiple reports to delete at once This follow-up moves the checkboxes into a separate column from the report ID in order to prevent visual inconsistencies. To test, repeat the test plan from the original patch: You must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. Signed-off-by: Katrin Fischer This works really nicely, passes all tests and the QA script. There is one little thing to note: If you delete a single report using the option from the menu, the line you want to delete is highlighted in red. It would be nice to do that also for deleting multiple reports. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 02:53:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 00:53:49 +0000 Subject: [Koha-bugs] [Bug 10426] Remove unused sub GetCcodes from C4::Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 02:53:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 00:53:52 +0000 Subject: [Koha-bugs] [Bug 10426] Remove unused sub GetCcodes from C4::Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18702|0 |1 is obsolete| | --- Comment #7 from Srdjan Jankovic --- Created attachment 20518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20518&action=edit Bug 10426 Remove unused sub GetCcodes from Koha.pm Remove uncalled sub GetCcodes Also remove comment in opac-search.pl which is remaining reference to it and serves no useful purpose Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 03:06:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 01:06:36 +0000 Subject: [Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 --- Comment #4 from David Cook --- (In reply to M. de Rooy from comment #3) > (In reply to comment #2) > > I don't like all the whitespace changes in this patch. Making whitespace > > changes as well as code/markup changes is generally speaking a violation > > of coding guidelines. However, this is not a frequently-modified > > template and a diff which ignores whitespace changes shows that the real > > changes are minor and effective. > > > > I'm signing off and correcting the commit message to include a > > description of the fix and the test plan. > > Do not like these whitespace changes too. Could the author resolve this > please and make life easier for QA? Thanks! If you use the -w flag to not show whitespace changes, you should be all right. However, I'm working on this patch again locally today, so I'll look at uploading a new version with code changes in one patch and whitespace changes in the other. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 04:10:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 02:10:41 +0000 Subject: [Koha-bugs] [Bug 10772] New: IE7 not loading reset-fonts-grids.css in staff client Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10772 Bug ID: 10772 Summary: IE7 not loading reset-fonts-grids.css in staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, we're importing "reset-fonts-grids.css" into the staff client using "@import url("../lib/yui/reset-fonts-grids.css") screen;" in staff-global.css. This works great in Chrome, (probably Firefox), and IE8+. However, "reset-fonts-grids.css" isn't being loaded in IE7 (and probably under) in the staff client, because IE doesn't seem to support media queries with the @import rule. It'll work fine without the media query, but with it...we get nothing. Currently, we're using a "screen" media query, which Owen added with Bug 10108, so that we can generate print outs without using the YUI grid system. This was important because a lot of print outs in the staff client were getting formatted poorly due to the use of the YUI grids when printing. -- The only solutions to this problem that I see are either creating print specific stylesheets (which modern browsers would import but that IE7 wouldn't) or to create IE7 (and under) style sheets that we target using IE-specific HTML comments.) Owen/others have any thoughts on this one? I know that the popular vote is not to support older versions of IE, but there are still lots of people out there using it. Lots of Koha users use it. So I would prefer to give them the best possible interface that we can, even if it is irritating to ensure backwards compatibility. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 04:14:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 02:14:49 +0000 Subject: [Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 04:14:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 02:14:52 +0000 Subject: [Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15305|0 |1 is obsolete| | --- Comment #5 from David Cook --- Created attachment 20519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20519&action=edit Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE Currently, the layout for the Edit/Add Layout screen of the Patron Card Creator is in complete disarray, when viewed in Internet Explorer (of any version). The nav bar is pushed to the bottom of the page, every fieldset is empty (as their contents have been pushed out into different parts of the page), and the checkboxes don't work. The cause appears to be some extraneous mark-up (a few extra fieldset and li elements)and some missing mark-up (ol elements to wrap the list elements, especially when nesting lists within each other and within div elements). --- This patch removes empty and extraneous fieldset and li elements. It also adds ol elements to all of the nested li elements, which were creating layout problems in IE, especially when they were interwoven with div elements. IE had problems opening and closing tags, which created some major chaos. --- Test Plan: Before applying the patch: 1) Open Koha using any version of Internet Explorer 2) Go to the Patron Card Creator in the Tools module 3) Go to Manage Layouts 4) Add or Edit a layout 5) Note that all the elements on the page are presented in haphazard fashion with the navbar pushed to the bottom of the page. Apply the patch. 6) Refresh the page 7) Note that the elements are now laid out on the page in the same way that they would appear in a modern browser like Firefox or Chrome (look at the same page in one of those browsers to confirm). (N.B. The exception is IE7. While the layout has been improved, it is now displayed linearly (i.e. without the YUI grid system). I've opened up Bug 10772 to start discussing this problem.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 04:17:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 02:17:40 +0000 Subject: [Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 --- Comment #6 from David Cook --- Actually, I'm not sure that it's necessary to add a patch for the whitespace. I will if folks think it's a good idea, but this is the essence of the patch. P.S. It looks like I forgot to include Owen's sign off in this latest patch. Could QA folks add that back in if necessary? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 07:15:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 05:15:41 +0000 Subject: [Koha-bugs] [Bug 10773] New: Replace item-level codes with names/descriptions for Label Printing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Bug ID: 10773 Summary: Replace item-level codes with names/descriptions for Label Printing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label printing Assignee: cnighswonger at foundations.edu Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, if you include "ccode","homebranch","holdingbranch","location", or "permanent_location" when printing labels, you'll end up with a code rather than a descriptive name/label. While I don't know how often you would necessarily use all of these, I have had a request come in for a label (instead of a code) for "homebranch" as they want their labels to include their library name. Makes sense to me. We already do it with item type. Collection code might be another one or location/permanent_location, depending on how they work their collections. "Holdingbranch" probably never but best perhaps to throw it in for good measure... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 07:24:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 05:24:33 +0000 Subject: [Koha-bugs] [Bug 10773] Replace item-level codes with names/descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 07:24:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 05:24:36 +0000 Subject: [Koha-bugs] [Bug 10773] Replace item-level codes with names/descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 --- Comment #1 from David Cook --- Created attachment 20520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20520&action=edit Bug 10773 - Replace item-level codes with names/descriptions for Label Printing This patch replaces item-level codes for certain fields so that names and descriptions are printed out instead of codes when using the Label Creator. The fields in question are "ccode", "homebranch", "holdingbranch", "location", and "permanent_location". Test Plan: 1) Edit a layout in the Label Creator so that it includes any of these fields. I suggest including "homebranch" and perhaps "ccode" if you have them in your item data. 2) Add items to a batch in the Label Creator. 3) Export the batch using the layout, and view as PDF 4) Note how the codes for homebranch (and ccode if available) come up instead of the name of the homebranch (and ccode). 5) Apply patch 6) Export the batch again 7) Note how the branch name and category name are now displaying instead of the codes that showed before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 07:25:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 05:25:09 +0000 Subject: [Koha-bugs] [Bug 10773] Replace item-level codes with names/descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |dcook at prosentient.com.au |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 07:46:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 05:46:45 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #12 from Katrin Fischer --- I have done some more testing and it looks like this already works ok on master. I think I must have missed to test it thorougly without the patches applied. I am not sure if there is a condition where the exsiting code wouldn't work. Kyle - can you please take a look at this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 08:44:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 06:44:15 +0000 Subject: [Koha-bugs] [Bug 10743] add style to privacy rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 08:44:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 06:44:19 +0000 Subject: [Koha-bugs] [Bug 10743] add style to privacy rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20506|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20521&action=edit [PASSED QA] Bug 10743: Add styles to 'my privacy' page in OPAC This patch does a couple things. Most importantly it adds a new div around the privacy rules summary so that it can be easily changed. It also moves the start of the form to right above the form's select box so that it's not in the new privacy rules div. To test: * Apply patch * Enable the use of privacy via the sys prefs * Log in to the OPAC * Visit the 'my privacy' tab * Make sure it looks okay * Submit the form and make sure it works * Repeat in the other theme Signed-off-by: Owen Leonard Edit: Replaced a few tabs with spaces to keep the QA script happy. Signed-off-by: Katrin Fischer Works nicely, privacy options can still be edited. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 09:40:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 07:40:17 +0000 Subject: [Koha-bugs] [Bug 9782] Cancel button doesn't work when importing MARC bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 09:40:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 07:40:21 +0000 Subject: [Koha-bugs] [Bug 9782] Cancel button doesn't work when importing MARC bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20355|0 |1 is obsolete| | --- Comment #2 from David Cook --- Created attachment 20522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20522&action=edit Bug 9782 - Cancel button doesn't work when importing MARC bibliographic frameworks When importing frameworks the "cancel" button should be hidden once an import is initiated since it is not possible to cancel the import in progress. This patch uses this bug as an excuse to replace the old import/export pop-ups with modal dialogs for all import/export functions. To test: - Try exporting both the default framework and at least one other framework. - Try importing both a default framework and at least one other framework. - When importing, observe that the modal dialog controls are hidden as soon as the import is initiated. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 09:50:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 07:50:37 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart at biblibre.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 10:15:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 08:15:23 +0000 Subject: [Koha-bugs] [Bug 10721] Improve DataTables configuration on transfers to receive report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10721 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 10:15:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 08:15:26 +0000 Subject: [Koha-bugs] [Bug 10721] Improve DataTables configuration on transfers to receive report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10721 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20322|0 |1 is obsolete| | --- Comment #2 from David Cook --- Created attachment 20523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20523&action=edit Bug 10721 - Improve DataTables configuration on transfers to receive report I noticed this template used a hidden span to allow correct sorting of titles--a relic of the previous table sorting plugin. I have removed that and added an improved DataTables configuration. To test apply the patch and view the transfers to receive report for a library which has multiple transfers to receive. Sorting should work correctly on all columns, including correct date sorting regardless of dateformat system preference. Title sorting should correctly exclude articles. Signed-off-by: David Cook There is no observable difference. The funcitonality is still there. I notice the hidden span is gone when I look at the source. Looks good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 10:46:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 08:46:31 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m --- Comment #19 from Jonathan Druart --- QA comment: These patches add the ability to delete multiple reports. The second one fixes the ergonomic issue (described in comment 14). I will provide 3 followups: 1/ Fix the following issue: (In reply to Katrin Fischer from comment #18) > There is one little thing to note: If you delete a single report > using the option from the menu, the line you want to delete > is highlighted in red. It would be nice to do that also for > deleting multiple reports. 2/ Fix the sort on id and report name 3/ Reindent the delete_report routine (shouldn't it be delete_reports?) and remove the $sth->finish statement. Note for RM: feel free to push only the 2 first patches and to ask for a new report for the 3 followups. Marked as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 10:47:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 08:47:02 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20516|0 |1 is obsolete| | Attachment #20517|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 20524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20524&action=edit Bug 3134 - Ability to selelct multiple reports to delete at once This patch adds the option to select multiple saved reports for deletion. To test you must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. Signed-off-by: Liz Rea Functional tests pass, template tests pass. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 10:47:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 08:47:08 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #21 from Jonathan Druart --- Created attachment 20525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20525&action=edit Bug 3134 [Follow-up] Ability to select multiple reports to delete at once This follow-up moves the checkboxes into a separate column from the report ID in order to prevent visual inconsistencies. To test, repeat the test plan from the original patch: You must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. Signed-off-by: Katrin Fischer This works really nicely, passes all tests and the QA script. There is one little thing to note: If you delete a single report using the option from the menu, the line you want to delete is highlighted in red. It would be nice to do that also for deleting multiple reports. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 10:47:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 08:47:13 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #22 from Jonathan Druart --- Created attachment 20526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20526&action=edit Bug 3134: Add the warn class on tr elements This patch adds the same behavior when deleting 1 or more reports. When checkboxes are checked and the "delete selected" button is pressed, checked lines are hightlighted in red. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 10:47:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 08:47:17 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #23 from Jonathan Druart --- Created attachment 20527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20527&action=edit Bug 3134: ID and Report name columns are not well sorted. The sort for ID is alpha instead of numerical, same for the report names. To test: create id=1, name=Report 1 create id=2, name=Report 2 create id=10, name=Report 10 create id=11, name=Report 11 Sorting by id: without this patch 1, 10, 11, 2 with this patch: 1, 2, 10, 11 Sorting by name: without this patch: Report 1, Report 10, Report 11, Report 2 with this patch: Report 1, Report 2, Report 10, Report 11 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 10:47:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 08:47:22 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #24 from Jonathan Druart --- Created attachment 20528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20528&action=edit Bug 3134: Reindent delete_report The first patch add a bad indentation for this routine. This patch fixes that. The $sth->finish statement is useless and should be removed. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 11:07:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 09:07:30 +0000 Subject: [Koha-bugs] [Bug 10761] UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #4 from Jonathan Druart --- QA comment: I found some improvements for this routine, I will submit a qa followup. If the $sth->finish statement is removed (see bug 3134 comment 24), it is possible to know how many rows are affected by the DELETE query. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 11:07:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 09:07:58 +0000 Subject: [Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 11:08:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 09:08:01 +0000 Subject: [Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20409|0 |1 is obsolete| | --- Comment #2 from David Cook --- Created attachment 20529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20529&action=edit Bug 10742 - simple search to z39.50 search keeps index In intranet, when search does not return results, there is a button to perform the same search on Z39.50 servers. This works well when coming from advanced search. But when using simple search from header, in the Z39.50 search box "kw,wrdl" is added to the operand in title. This patch simply adds kw as default value when the cgi does not have idx parameter. Test plan : - In intranet, perform a search from header that does not return any result. For example "afalseword" - Click on "Z39.50 Search" => you get a popup with the searched word in title. For example : Title: afalseword - Go to advanced search page - Enter the same word into first input and submit - Click on "Z39.50 Search" => you get a popup with the searched word in title. Signed-off-by: David Cook Patch works as described. This is much nicer than before. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 11:08:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 09:08:05 +0000 Subject: [Koha-bugs] [Bug 10761] UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20515|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 20530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20530&action=edit Bug 10761:UT:save_report and delete_report in C4::Reports::Report_Guided.pm need unit tests The test are wrap in a transaction. Note : The last test (in comment) currently doesn't pass because it needs some modifications of delete_report. To test: prove t/db_dependent/Reports_Guided.t t/db_dependent/Reports_Guided.t .. ok All tests successful. Files=1, Tests=7, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.28 cusr 0.02 csys = 0.32 CPU) Result: PASS Signed-off-by: Katrin Fischer Works nicely, tested with patch for bug 10761 applied. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 11:08:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 09:08:09 +0000 Subject: [Koha-bugs] [Bug 10761] UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 --- Comment #6 from Jonathan Druart --- Created attachment 20531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20531&action=edit Bug 10761: UT: Improvement for Reports_guided.t 1/ delete_report should return undef is no parameter is given. 2/ delete_report returns the number of affected rows. 3/ delete_report should be tested with 1 and more parameters. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 11:10:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 09:10:27 +0000 Subject: [Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- The only thing I wonder about is whether the contents of the simple search should go into "Title" or "Raw (any)", since "Raw" is more of a "keyword" search. I looked a bit at how to make it go into "Raw (any)" instead of "Title" but couldn't get it to work so I guess it would require more poking around. Perhaps "Title" makes the most sense, as people might be more likely to search for titles using the simple search than anything else? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 11:27:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 09:27:19 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #37 from MJ Ray (software.coop) --- "I find strange to pay again to fix a feature broken by somebody's code 2 or 3 years ago." - ah well, this happens with most software, where a feature is added without a good-enough test set for it, or where some other design change is seen as desirable enough to be breaking other features, which is maybe what happened here (security is good). Customers are paying for this sort of maintenance in other software - some developers joke "plan to throw one away - you will anyway" - and it's just more visible in open software like Koha. So if this feature is readded (maybe with a task-runner script something like drupal's cron.php, maybe with a proper cronjob), it should be added with some test to help avoid breaking it again. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 11:28:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 09:28:44 +0000 Subject: [Koha-bugs] [Bug 3681] No bimonthly frequency option for serials subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3681 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart --- Will be fixed by bug 7688. *** This bug has been marked as a duplicate of bug 7688 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 11:28:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 09:28:44 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.sekjal at gmail.com --- Comment #111 from Jonathan Druart --- *** Bug 3681 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 11:37:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 09:37:21 +0000 Subject: [Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 --- Comment #4 from Fridolyn SOMERS --- (In reply to David Cook from comment #3) > Perhaps "Title" makes the most sense, as people might be more likely to > search for titles using the simple search than anything else? It makes sense for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 12:14:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 10:14:11 +0000 Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14930|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 20532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20532&action=edit Bug 8369: Merge tables for circulation rules. This patch adds 3 new tables: - circ_rules - borrower_circ_rules - item_circ_rules It removes 6 tables: - default_borrower_circ_rules - default_branch_circ_rules - default_branch_item_rules - default_circ_rules - branch_borrower_circ_rules - branch_item_rules The goal is to merge circulations rules into 3 tables instead of 6 without add or remove features. Previous behaviours do not change. The wildcard '*' character is a rule for the default values. Then it is possible to merge 2 tables into one if we consider that the default value is the value with a branchcode eq '*'. I removed the foreign key constraint with branchcode and added 3 queries in the C4::Branch::DelBranch routine in order to remove records about a deleted branch. Signed-off-by: Kyle M Hall Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 12:14:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 10:14:17 +0000 Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14931|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 20533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20533&action=edit Bug 8369: Followup: indent sql queries in admin/smart-rules.pl Signed-off-by: Kyle M Hall Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 12:18:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 10:18:04 +0000 Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #25 from Jonathan Druart --- Galen, I change the status to Passed QA. Like that, you will show this report in your list. I can provide unit tests for changed routines but before, I would like to get your opinion on comment 18-22 and on this change in general. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 12:50:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 10:50:35 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #9 from Kyle M Hall --- > Since the use of File::Slurp means loading the entire input barcode file > into memory, this patch also changes the performance characters of the > inventory tool when processing very large files. Admittedly, this may not > be a big deal in practice, but I would appreciate confirmation as to whether > there are barcode scanners or other utilities that are *actually* producing > files that use \r as a delimiter. I agree, that using File::Slurp was also a concern of mine, but one would need to upload a barcode file with hundreds of thousands of barcodes to have a plain text file of any appreciable size, right? I can confirm at least one library is having this issue in practice, as the example file of barcodes was provided by the library having this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 13:32:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 11:32:52 +0000 Subject: [Koha-bugs] [Bug 10774] New: Allow individual holds to be suspended and resumed from the OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Bug ID: 10774 Summary: Allow individual holds to be suspended and resumed from the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 13:38:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 11:38:19 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 13:38:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 11:38:21 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 --- Comment #1 from Kyle M Hall --- Created attachment 20534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20534&action=edit Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 13:38:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 11:38:55 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 13:41:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 11:41:35 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20534|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 20535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20535&action=edit Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold 6) Disable AutoResumeSuspendedHolds, ensure the suspend until date field is no longer visible. 7) Disable SuspendHoldsOpac, ensure all suspension related fields are no longer visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 14:24:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 12:24:21 +0000 Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435 --- Comment #46 from Jonathan Druart --- Created attachment 20536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20536&action=edit Bug 8435: The unit tests should create the biblio Previous version does not create the biblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 14:30:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 12:30:05 +0000 Subject: [Koha-bugs] [Bug 10772] IE7 not loading reset-fonts-grids.css in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10772 --- Comment #1 from Owen Leonard --- Official we don't even support "modern" versions of IE, but in practice we do our best to fix bugs as they are reported. I have no interest in making dramatic changes to support IE7, but I don't object to a conditional comment in doc-head-close.inc targeting < IE7 in order to load reset-fonts-grids.css: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 14:40:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 12:40:53 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16456|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 20537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20537&action=edit Bug 7677: New areas in subscriptions and new functions when receiving. When enabling the makePreviousSerialAvailable syspref, the previously received serial's itemtype is set as defined in the subscription. (Please note that the item-level_itypes syspref must be set to specific item.) It is also made available. You can define the serialsFieldsToAV syspref to associate authorized values to the domain, origin and/or support fields. 995$l is automatically prefilled when receiving. Signed-off-by: Frederic Durand http://bugs.koha-community.org/show_bug.cgi?id=8435 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 14:41:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 12:41:00 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #10 from Jonathan Druart --- Created attachment 20538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20538&action=edit Bug 7677: UT: add unit tests for GetPreviousSerialid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 14:42:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 12:42:48 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |jonathan.druart at biblibre.co | |m Depends on| |8435 Assignee|colin.campbell at ptfs-europe. |matthias.meusburger at biblibr |com |e.com QA Contact|koha.sekjal at gmail.com | --- Comment #11 from Jonathan Druart --- attachment 20537 is a rebased patch. attachment 20538 is the unit tests for GetPreviousSerialid Now this patch depends on bug 8435 (in order to avoir conflicts on the unit tests). Needs QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 14:42:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 12:42:48 +0000 Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7677 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 14:44:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 12:44:21 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Depends on|8435 | Assignee|matthias.meusburger at biblibr |colin.campbell at ptfs-europe. |e.com |com QA Contact| |koha.sekjal at gmail.com --- Comment #12 from Katrin Fischer --- Hi Jonathan and Frederic, could you please add some documentation about the use of the new fields? Also the commit message states that 995... will be automatically filled. And this is indeed hardcoded: + // Also prefilling 995$l + subfieldid = "subfield" + itemid.substr(4) + "l"; + $("#" + subfieldid + " input[type='text']").val($("#serialseq" + serialId).val()); + // And prefilling for supplemental issue + $("#subfieldNEWl input[type='text']").val($("#serialseqNEW").val()); + -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 14:44:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 12:44:21 +0000 Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7677 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 14:57:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 12:57:13 +0000 Subject: [Koha-bugs] [Bug 10460] way to stop a run away report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10460 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #1 from Kyle M Hall --- This is a pretty complicated process. I think it would require something likes this: a) Add a system preference "StopReports" ( or something similar ) and/or a new staff permission. b) When enabled, running a report would immediately send a partial html page with a "Stop Report" button at the top, along with the PID of the process that is generating the report. c) Clicking the "Stop Report" button would launch another script via ajax which sends the PID to a new script that does nothing but kill processes. d) The script would attempt to kill the process generating the report and send back a confirmation to the requester. e) If the processes cannot be killed, the web page would pop up an alert, if the process was killed successfully, the page would redirect back to the report that had been run. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 14:58:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 12:58:27 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #13 from Katrin Fischer --- Hm, I see now that I had already commented in comment 7... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 15:08:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 13:08:46 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Kyle M Hall --- 1) OpacHighlightStopWords is used the database update and sysprefs sql file, but OpacHighlightedStopWords is used everywhere else. 2) Please use the TT plugin function Koha.Preference() to get the preference, rather than passing it it from the perl script 3) It's not working for me! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 15:10:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 13:10:58 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 --- Comment #53 from Kyle M Hall --- (In reply to Katrin Fischer from comment #52) > I fixed a redundant 'my' that the QA script pointed out. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 15:10:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 13:10:59 +0000 Subject: [Koha-bugs] [Bug 5968] News display on opac-main.pl is particular about browser language settings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5968 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Component|OPAC |I18N/L10N Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Severity|enhancement |normal -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 15:55:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 13:55:33 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #14 from Matthias Meusburger --- Hi ! The new field previousitemtype is used to automatically set a given item type to the previously received serial (when a new one is received). The fields domain origin and ccode are used to provide statistics, like counting the number of items per domain, origin and ccode. As for the 995l, yes, it should be marc-agnostic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 15:58:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 13:58:39 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #15 from Katrin Fischer --- Could you describe domain and origin in a sentence or two? I am really confused what to put in those fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 16:48:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 14:48:35 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #25 from Galen Charlton --- Pushed to master. Thanks, Owen and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 16:49:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 14:49:13 +0000 Subject: [Koha-bugs] [Bug 10761] UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master, along with a follow-up to explicitly return from C4::Reports::Guided::delete_report(). Thanks, Kenza and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 16:51:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 14:51:01 +0000 Subject: [Koha-bugs] [Bug 2693] Tagging: Add filter by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Hardware|PC |All Assignee|gmcharlt at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 16:56:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 14:56:06 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 --- Comment #32 from M. de Rooy --- (In reply to Magnus Enger from comment #29) > But isn't it possible to have the same domain available both with and > without HTTPS? So both of these can work at the same time: > http://koha.example.org/ > https://koha.example.org/ > > Then it would seem to be a bad idea to "hard code" the protocol in a > syspref, and better to figure it out on a per request basis, perhaps? Yes, both could be available. I think that bug 10325 can help us out here. It allows you to override a systempreference via koha-httpd.conf. In that case you could override the base url for the https port. At the same time I am wondering if both are available, would it be so bad to let opacbaseurl redirect to one of the two? (Just a pragmatic thought.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 16:59:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 14:59:55 +0000 Subject: [Koha-bugs] [Bug 2693] Tagging: Add filter by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 16:59:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 14:59:57 +0000 Subject: [Koha-bugs] [Bug 2693] Tagging: Add filter by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693 --- Comment #1 from Owen Leonard --- Created attachment 20539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20539&action=edit Bug 2693 - Tagging: Add filter by name If you want to filter results on the tags management page by the reviewer you have to know their borrowernumber. It would be better to be able to search by name, but in the meantime this patch adds an autocomplete widget to the form field so that you can do a name search and populate the field with the borrowernumber. To test you must have approved or rejected tags. From the tags review page (tags/review.pl), view all, approved, or rejected tags. Type a name in the "reviewer" form field in the left sidebar filter. You should get an autocomplete dropdown with names matching your search. When you select one the form field should be populated by the borrowernumber. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 17:15:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 15:15:20 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20469|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 20540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20540&action=edit Patch to add syspref controlled stopwords to highlighting Patch updated to reflect Kyles comments: 1. OpacHightlightedStopWords used consistently throughout files 2. TT Plugin used for sysprefs inside the template instead of adding logic to koha pl files where not required. 3. See follow-up comment. Patch also rebased against master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 17:17:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 15:17:50 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #9 from Martin Renvoize --- Thanks for the comments Kyle, I've done as asked with regard to silly mistakes in the sql update files and using the TT Plugin to fetch the preference now. (I didn't realise we had that yet.. oops) As for 'It's not working!', could you elaborate at all? What browser are you using, is javascript enabled (without it highlighting won't work at all)? Cheers Martin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 17:21:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 15:21:28 +0000 Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #26 from Galen Charlton --- (In reply to Jonathan Druart from comment #25) > Galen, I change the status to Passed QA. Like that, you will show this > report in your list. > > I can provide unit tests for changed routines but before, I would like to > get your opinion on comment 18-22 and on this change in general. Thanks! My general opinion of the change as a whole: I would hate to lose the foreign key constraints, the change doesn't seem to have any user-visible benefit, and I don't see that the goal of reducing the number of tables involved is worth the risk of regressions. I'm not fond of the use of '*' in issuing rules, either -- I'd rather that NULL be usable to signal "don't care/matches any" and that brancode, itemtype, and categorycode be FKs -- but composite UKs don't enforce uniqueness if one of the values is NULL. We could dispense with the composite PK on issuingrules, perhaps, but then would have to write more code to ensure that duplicate rows couldn't slip in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 17:26:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 15:26:32 +0000 Subject: [Koha-bugs] [Bug 10743] add style to privacy rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Nicole! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 17:35:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 15:35:24 +0000 Subject: [Koha-bugs] [Bug 10773] Replace item-level codes with names/descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20520|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 20541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20541&action=edit Bug 10773 - Replace item-level codes with names/descriptions for Label Printing This patch replaces item-level codes for certain fields so that names and descriptions are printed out instead of codes when using the Label Creator. The fields in question are "ccode", "homebranch", "holdingbranch", "location", and "permanent_location". Test Plan: 1) Edit a layout in the Label Creator so that it includes any of these fields. I suggest including "homebranch" and perhaps "ccode" if you have them in your item data. 2) Add items to a batch in the Label Creator. 3) Export the batch using the layout, and view as PDF 4) Note how the codes for homebranch (and ccode if available) come up instead of the name of the homebranch (and ccode). 5) Apply patch 6) Export the batch again 7) Note how the branch name and category name are now displaying instead of the codes that showed before. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 17:35:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 15:35:21 +0000 Subject: [Koha-bugs] [Bug 10773] Replace item-level codes with names/descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 17:43:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 15:43:34 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #48 from Koha Team Lyon 3 --- Hello Fridolyn, I'm not sure that the patch of bug 6739 has the same goal : - with this patch we want to prevent renewing if patrons have overdues or restriction. - with bug 6739, it wants to prevent renewing if patrons who have a card no more valid. It's not the same behaviour. Can you confirm that I have understood well and switch back this patch "need signoff" ? Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 17:52:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 15:52:42 +0000 Subject: [Koha-bugs] [Bug 7478] Template/translation problem in catalogue_out.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|frederic at tamil.fr |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 18:39:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 16:39:42 +0000 Subject: [Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 18:39:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 16:39:45 +0000 Subject: [Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17404|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 20542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20542&action=edit [SIGNED-OFF] Bug 9924 - Simplify and rename patron card creator error message include The patron card creator error message include uses a non-standard method for displaying error messages, and is poorly-named. This patch converts the method of displaying error messages for various patron card creator options to the standard one ('
    ') and renames the include file to make it clear that it relates only to patron card creator operations. To test, perform various operations: - Go to 'manage images' and try to upload a file which exceeds the 500KBfile size limit - Go to the edit batch page and manually append an error code to the URL: /cgi-bin/koha/patroncards/edit-batch.pl?op=new&error=403 - Go to one of the manage pages and manually append an error code to the URL: /cgi-bin/koha/patroncards/manage.pl?card_element=profile&error=201 Correct display of an error message indicates that the include file is being found. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 18:47:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 16:47:26 +0000 Subject: [Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 --- Comment #8 from Owen Leonard --- (In reply to Katrin Fischer from comment #6) > > + [% INCLUDE 'patroncards-batches-toolbar.inc' %] I think this was caused by a merge error following Bug 9697. I have corrected the patch but kept the signoff. I hope that's okay. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 19:05:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 17:05:42 +0000 Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|oleonard at myacpl.org |bob at calyx.net.au OS|Linux |All -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 19:51:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 17:51:40 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #10 from Kyle M Hall --- I'm using chrome. Enabling the feature and setting it to "OR|or|Or" did not stop the "or"s in my results from being highlighted. I'll retest and let you know if I find any errors. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 20:12:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 18:12:03 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #11 from Kyle M Hall --- Martin, I've retested and discovered my problem. I had assumed this would affect the staff intranet! It works great in the OPAC. Do you think you could provide a followup to add this functionality to the staff intranet as well? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 22:03:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 20:03:27 +0000 Subject: [Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Another reason to keep the title might be that you can probably expect the Z39.50 target to support title search, but probably not all support raw? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 22:38:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 20:38:05 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #12 from Martin Renvoize --- That's a relief, I hadn't got a clue why it wasn't working otherwise. Patch coming up to also add the stopwords to the staff client.. to be honest, I'de completely forgotten the staff client also does the highlighting.. looking through it, the code is very inconsistent with the opac method and doesn't apply to the detailed result view, only the search results page. Anywho.. I'll patch the results page as is. Martin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 22:39:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 20:39:46 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20540|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 20543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20543&action=edit Patch to add syspref controlled stopwords to highlighting Followup patch: Adds same stopwords to Staff Client Search Results page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 23:21:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 21:21:48 +0000 Subject: [Koha-bugs] [Bug 10775] New: Create humans.txt from the history document Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10775 Bug ID: 10775 Summary: Create humans.txt from the history document Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Inspired by http://humanstxt.org/ - we should create this so every OPAC has one of these. Just a nice way to (again) recognise the people who contribute and give time/money/resources to Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 21 23:46:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 21:46:26 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 --- Comment #8 from Tom?s Cohen Arazi --- Created attachment 20544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20544&action=edit Bug 10733: Follow-up - Forgot apache-site.conf.in I just forgot to put the SetEnv definitions there. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 00:02:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 22:02:13 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11400|1 |0 is obsolete| | CC| |gmcharlt at gmail.com --- Comment #44 from Galen Charlton --- Comment on attachment 11400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11400 Bug 8089: Use Koha::Cache for all caching Un-obsoleting the latest version of the "Use Koha::Cache for all caching" patch. My aim is to write some test cases and have another go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 01:50:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 23:50:39 +0000 Subject: [Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 --- Comment #6 from David Cook --- (In reply to Katrin Fischer from comment #5) > Another reason to keep the title might be that you can probably expect the > Z39.50 target to support title search, but probably not all support raw? Mmm, I suppose that's a possibility, although I think the Bib-1 attribute for raw (1016) is fairly ubiquitous. I'm not too fussed either way. I just thought it might be worth raising :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 01:55:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Aug 2013 23:55:16 +0000 Subject: [Koha-bugs] [Bug 10772] IE7 not loading reset-fonts-grids.css in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10772 --- Comment #2 from David Cook --- (In reply to Owen Leonard from comment #1) > Official we don't even support "modern" versions of IE, but in practice we > do our best to fix bugs as they are reported. > > I have no interest in making dramatic changes to support IE7, but I don't > object to a conditional comment in doc-head-close.inc targeting < IE7 in > order to load reset-fonts-grids.css: > > That sounds like a reasonable suggestion to me :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 02:03:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 00:03:21 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #49 from David Cook --- (In reply to Koha Team Lyon 3 from comment #48) > Hello Fridolyn, > I'm not sure that the patch of bug 6739 has the same goal : > - with this patch we want to prevent renewing if patrons have overdues or > restriction. > - with bug 6739, it wants to prevent renewing if patrons who have a card no > more valid. > > It's not the same behaviour. Can you confirm that I have understood well and > switch back this patch "need signoff" ? > Sonia I agree with Sonia's evaluation of the patches, Fridolyn. It seems like they are doing quite different things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 06:59:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 04:59:20 +0000 Subject: [Koha-bugs] [Bug 10776] New: Subscription notification screen has awkward wording Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776 Bug ID: 10776 Summary: Subscription notification screen has awkward wording Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org There is a bit of awkwardness in the wording on the "receive notifications when a new volume of this serial arrives?" screen. Patch incoming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 07:03:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 05:03:22 +0000 Subject: [Koha-bugs] [Bug 10776] Subscription notification screen has awkward wording In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 07:03:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 05:03:25 +0000 Subject: [Koha-bugs] [Bug 10776] Subscription notification screen has awkward wording In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776 --- Comment #1 from Liz Rea --- Created attachment 20545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20545&action=edit Bug 10776 - subscription notification screen has awkward wording to test: - make a subscription available to be notified about - log into the opac, click the subscriptions tab, then More details - click "Subscribe to email notification on new issues" - observe the text without the patch - there seems to be an extra "arrive?" - apply the patch, refresh - wording should flow a bit better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 09:30:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 07:30:00 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vanoudt at gmail.com --- Comment #38 from Nicholas van Oudtshoorn --- Hopefully this is the right bug to write about this in. Just noticed that runreport.pl (which I'm calling manually from a cron job), whilst allowing for a format of html, doesn't set the "Content-Type" on such emails to "text/html". A simple patch replaces: if ($email){ my %mail = ( To => $to, From => $from, Subject => encode('utf8', $subject ), Message => encode('utf8', $message ) ); sendmail(%mail) or carp 'mail not sent:' . $Mail::Sendmail::error; } else { print $message; } with if ($email){ my %mail; if ($format eq 'html') { $message = "$message"; %mail = ( To => $to, From => $from, 'Content-Type' => 'text/html', Subject => encode('utf8', $subject ), Message => encode('utf8', $message ) ); } else { %mail = ( To => $to, From => $from, Subject => encode('utf8', $subject ), Message => encode('utf8', $message ) ); } sendmail(%mail) or carp 'mail not sent:' . $Mail::Sendmail::error; } else { print $message; } -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 09:44:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 07:44:40 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #39 from M. de Rooy --- (In reply to Nicholas van Oudtshoorn from comment #38) > Hopefully this is the right bug to write about this in. Just noticed that > runreport.pl (which I'm calling manually from a cron job), whilst allowing > for a format of html, doesn't set the "Content-Type" on such emails to > "text/html". > I am not sure about that, Nicholas. This bug is about scheduling running reports, not about mailing in html format. If you can't find a more specific bug, please open a new report for it. And your patch is welcome too. Preferably as formatted by git. (Look for instructions on using git-bz; that will make it easier for you.) Thanks. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 10:02:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 08:02:47 +0000 Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #27 from Jonathan Druart --- (In reply to Galen Charlton from comment #26) > My general opinion of the change as a whole: I would hate to lose the > foreign key constraints, the change doesn't seem to have any user-visible > benefit, and I don't see that the goal of reducing the number of tables > involved is worth the risk of regressions. The goal of this patch is not to offer something to the final user. With this approach, the code and sql queries in the smart-rules script are more readable and cleaner. It is enough for me to provide a patch. > I'm not fond of the use of '*' in issuing rules, either -- I'd rather that > NULL be usable to signal "don't care/matches any" and that brancode, > itemtype, and categorycode be FKs -- but composite UKs don't enforce > uniqueness if one of the values is NULL. We could dispense with the > composite PK on issuingrules, perhaps, but then would have to write more > code to ensure that duplicate rows couldn't slip in. I will try to propose a followup. Thanks for your feedback! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 10:28:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 08:28:10 +0000 Subject: [Koha-bugs] [Bug 8562] RandomizeHoldsQueueWeight ignored if StaticHoldsQueueWeight is empty. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8562 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #15 from M. de Rooy --- (In reply to Kyle M Hall from comment #14) > > I do not think that this is correct. The branches are shuffled regardless of > > the value of RandomizeHoldsQueueWeight. Perhaps better would be: > > @branches_to_use ||= keys %{GetBranches()}; # (or the correct version of > > that statement, since I didn't test my suggestion) > > right after the definition of @branches_to_use? > > The justification for this is that it is extremely unlikely that a library > would want to fill holds from libraries in alphabetical order in the case > that the library has not populated StaticHoldsQueueWeight. Do you believe > this is an unreasonable assumption? I tend to agree with Jared here. If the Randomize pref is not set, you should not shuffle. Otherwise this pref is really useless. You have a point however. I think that what you say, more pertains to the default values set for these prefs in Koha. Randomize should be 1 by default. The description on the pref form could be improved/extended. I also think you should take into account the '0' default value. Just interpret it as all branches here (empty string as advertised). If we definitely want to get rid of this zero, it could be removed completely on a new report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 10:29:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 08:29:11 +0000 Subject: [Koha-bugs] [Bug 8562] RandomizeHoldsQueueWeight ignored if StaticHoldsQueueWeight is empty. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8562 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 10:31:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 08:31:27 +0000 Subject: [Koha-bugs] [Bug 10777] New: runreport.pl allows for sending html reports via email, but mimetype is wrong Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10777 Bug ID: 10777 Summary: runreport.pl allows for sending html reports via email, but mimetype is wrong Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: vanoudt at gmail.com QA Contact: testopia at bugs.koha-community.org runreport.pl allows for sending html reports via email. The problem is that the Content-Type isn't set to text/html, which means that the generated html email isn't displayed properly. The patch for this sets the content type, and also adds a tiny bit of css to alternate row colours (just to make long reports a bit easier on the eye!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 10:32:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 08:32:34 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #40 from Nicholas van Oudtshoorn --- Sorry about the noise. Have created the new bug report (10777), and will upload patch there shortly! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 10:37:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 08:37:44 +0000 Subject: [Koha-bugs] [Bug 10777] runreport.pl allows for sending html reports via email, but mimetype is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10777 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 10:38:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 08:38:18 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #41 from M. de Rooy --- (In reply to Nicholas van Oudtshoorn from comment #40) > Sorry about the noise. Have created the new bug report (10777), and will > upload patch there shortly! Thx -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 10:39:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 08:39:27 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #42 from Chris Cormack --- (In reply to Nicholas van Oudtshoorn from comment #40) > Sorry about the noise. Have created the new bug report (10777), and will > upload patch there shortly! A patch more than makes up for it, people can make as much noise as they want, if they also send patches ;) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 10:39:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 08:39:29 +0000 Subject: [Koha-bugs] [Bug 10777] runreport.pl allows for sending html reports via email, but mimetype is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10777 --- Comment #1 from M. de Rooy --- Nicholas: If you send a patch, you can overwrite the default assignee. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 10:51:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 08:51:43 +0000 Subject: [Koha-bugs] [Bug 10460] way to stop a run away report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10460 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 10:57:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 08:57:38 +0000 Subject: [Koha-bugs] [Bug 10777] runreport.pl allows for sending html reports via email, but mimetype is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10777 --- Comment #2 from Nicholas van Oudtshoorn --- Created attachment 20546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20546&action=edit Send html reports with the proper Content-Type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 10:58:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 08:58:08 +0000 Subject: [Koha-bugs] [Bug 10777] runreport.pl allows for sending html reports via email, but mimetype is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10777 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |vanoudt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 11:21:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 09:21:46 +0000 Subject: [Koha-bugs] [Bug 10777] runreport.pl allows for sending html reports via email, but mimetype is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10777 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #3 from Liz Rea --- Sorry to be a bother, may we have a test plan please? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 12:14:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 10:14:38 +0000 Subject: [Koha-bugs] [Bug 10778] New: Store more information in statistics table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10778 Bug ID: 10778 Summary: Store more information in statistics table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org Curently, statistic table contains some information about the item and the borrower (http://schema.koha-community.org/tables/statistics.html): For the item : - itemnumber - itemtype - ccode For the borrower - borrowernumber - associatedborrower - and maybe "usercode" (not documented in schemaspy, so I don't know what it means). I think we should store more information for the borrower : if the borrower record is deleted, we will not be able to get the useful informations (categorycode...) with a JOIN. I am not sure of Koha's behavior if the item or biblio is deleted : if the itemnumber and biblionumber is deleted from statistic table, we could also store more information (as homebranch, location, biblio.serial, biblioitems.itemtype) For the borrowers, I think we need : - categorycode - branchcode - sex - sort1 - sort2 and optionally the ability to record 3 or 4 custom fields with a syspref (for example, to store the extended attributes). Do you agree with that ? M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 13:13:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 11:13:39 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #50 from Fridolyn SOMERS --- Indeed, this patch does not provide the same behavior. I set back to "Needs Signoff" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 13:21:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 11:21:59 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 Dan Scott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dan at coffeecode.net --- Comment #1 from Dan Scott --- https://github.com/dbs/Koha/tree/schema.org may be of interest; thanks to Chris Cormack for taking the time to point me at the OPAC XSLT. I have tested the XSLT from the command line, but the TT2 changes for the holdings markup in the OPAC are as of yet untested. This is meant as a quick proof of concept at this point (although if someone else tries it out and it works for them, feel free to use the code!). The mappings from MARC & holdings to schema.org types & properties are based on similar work I have done with Evergreen and VuFind, informed by my participation in the W3C Schema Bib Extend community group. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 13:46:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 11:46:38 +0000 Subject: [Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from M. de Rooy --- KOHA -> Koha ? Just a few questions: 1) What about: use FindBin; my $module="$FindBin::Bin/../kohalib.pl"; eval { require $module }; Seems to overcome the warning: "require" statement with library name as string at line 26, column 12. Use a bareword instead. 2) You want to modify pos 22-24 (Language of cataloging). You do that by: $subfield =~ s/fre/$default_unimarc_language/g Why global? You only want to do this once? Since there actually is no check on the contents of the preference, this variable may contain a string that is too short or too long. In that case you are shifting characters in field 100 and corrupting your data. Could you check the length? And simply replace positions 22-24? Also note that fre is hardcoded here. I would favor moving it to a script parameter. Looking at the code of ModBiblioMarc, I wonder if you need this regexp at all. The code there appears to correct the language in 100a while checking the length! 3) Why use ModBiblioMarc and not ModBiblio? See POD comment for ModBiblioMarc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 14:15:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 12:15:32 +0000 Subject: [Koha-bugs] [Bug 10745] More fun on translation bug with XSLT subfieldSelect parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20431|0 |1 is obsolete| | --- Comment #2 from M. de Rooy --- Created attachment 20547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20547&action=edit Bug 10745 - More fun on translation bug with XSLT subfieldSelect parameters As in Bug 6278, this patch replace ">at<" with ">a_t<" so not to mislead translators. Found more cases that initial description. To test: 1) Check that problem exists and only on xslt files, using your preferred language egrep -B10 "^msgid \"at\"" misc/translator/po/xx-YY-i-staff-t* 2) Apply the patch 3) Update translation file (cd misc/translator; perl translate update xx-YY) 4) Verify the problem is gone, repeat 1 5) If you like verify new entries in PO file egrep -B15 "^msgid \"a_t\"" misc/translator/po/xx-YY-i-staff-t* Signed-off-by: Marcel de Rooy Tested this with field 780 and running a Dutch translation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 14:15:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 12:15:47 +0000 Subject: [Koha-bugs] [Bug 10745] More fun on translation bug with XSLT subfieldSelect parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 14:17:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 12:17:49 +0000 Subject: [Koha-bugs] [Bug 10745] More fun on translation bug with XSLT subfieldSelect parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from M. de Rooy --- QA Comment: I know the author of the 6278 patch :) Since this construct works and is in the current code, we are making a consistent use of this workaround. Moving it to Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 14:18:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 12:18:40 +0000 Subject: [Koha-bugs] [Bug 10745] More fun on translation bug with XSLT subfieldSelect parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 14:24:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 12:24:33 +0000 Subject: [Koha-bugs] [Bug 8169] No LCCN field on Z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8169 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from M. de Rooy --- Changing status, especially in connection with the first point of the former comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 14:25:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 12:25:05 +0000 Subject: [Koha-bugs] [Bug 8169] No LCCN field on Z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8169 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All Version|3.6 |master OS|Windows |All -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 14:48:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 12:48:22 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #25 from M. de Rooy --- Created attachment 20548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20548&action=edit Bug 9312: Followup for one tab character To satisfy qa tools, removing one tab somewhere.. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 14:50:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 12:50:10 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #26 from M. de Rooy --- I got this error on uploading one image file: Can't use string ("1") as a HASH ref while "strict refs" in use at /usr/share/koha/testclone/tools/picture-upload.pl line 138 It seems that $results can be just 1. Line 138 refers to it as a hash: if ( %$results || %errors ) { And perl does not like that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 14:50:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 12:50:17 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- This looks good and is a nice improvement. I do see one issue: I'm pretty sure you shouldn't be able to suspend a hold on an item which is in transit. You can't cancel a hold while it is in transit, and the staff client blocks you from suspending. If that sounds correct and you'll submit a revision, there is also an orphan

    which needs to be removed, right after the "clear date" link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 15:04:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 13:04:50 +0000 Subject: [Koha-bugs] [Bug 10038] Doubled 'default' entry when creating a new authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10038 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from M. de Rooy --- When you added the auth type but not yet copied the framework, you get a list with label Create authority framework for .. using .. This list is not yet sorted. Is that in the scope of this report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 15:14:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 13:14:38 +0000 Subject: [Koha-bugs] [Bug 10687] Incorrect tab information for tags 86a and 86b on default MARC21 auth framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #2 from M. de Rooy --- Bernardo: Could you provide a link to LOC for the description of these fields? I was looking for 68a History note, but I can't find it. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 15:16:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 13:16:52 +0000 Subject: [Koha-bugs] [Bug 10687] Incorrect tab information for tags 86a and 86b on default MARC21 auth framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #3 from M. de Rooy --- Please note also that your commit message and title also refer to 86? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 15:17:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 13:17:19 +0000 Subject: [Koha-bugs] [Bug 10741] Can not place a hold on an item in transit and for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10741 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 15:17:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 13:17:21 +0000 Subject: [Koha-bugs] [Bug 10741] Can not place a hold on an item in transit and for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10741 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20401|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 20549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20549&action=edit [SIGNED-OFF] Bug 10741 - Can not place a hold on an item in transit and for loan In search results, one can not place a hold on an item in transit and for loan (items.notforloan=0). This appears when AllowOnShelfHolds is allowed. Depends on Bug 8975 code : a simple if condition is missing when not damaged. Test plan : - Set AllowOnShelfHolds to on - Create a record with a normal item : not lost, not withdrawn, not damaged, notforloan=0 - Index this record - Perform a search on OPAC that returns this record (and others) => You see in actions "Place hold" - Add this item in transit : /cgi-bin/koha/circ/branchtransfers.pl - Re-perform the search on OPAC => You see in actions "Place hold" and item "in transit" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 15:17:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 13:17:32 +0000 Subject: [Koha-bugs] [Bug 10741] Can not place a hold on an item in transit and for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10741 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20402|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 20550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20550&action=edit [SIGNED-OFF] Bug 10741 - Formatting can place hold test Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 15:23:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 13:23:40 +0000 Subject: [Koha-bugs] [Bug 10766] Cataloging reservoir search broken if UseQueryParser is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10766 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 15:23:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 13:23:43 +0000 Subject: [Koha-bugs] [Bug 10766] Cataloging reservoir search broken if UseQueryParser is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10766 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20485|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 20551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20551&action=edit [SIGNED-OFF] Bug 10766: unbreak reservoir search when UseQueryParser is OFF To test: [1] Turn UseQueryParser off. [2] Ensure that your database has records in the reservoir. Performing a Z39.50 search will do this. [3] Perform a broad cataloging (i.e., cataloguing/addbooks.pl search). Note that results are returned from the main catalog but that no reservoir results are returned. [4] Apply the patch. [5] Perform the search again. This time, there should be both catalog and reservoir results. [7] Enable QueryParser. Perform the search again, and verify that the catalog and reservoir results are the same. Signed-off-by: Galen Charlton Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 15:35:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 13:35:22 +0000 Subject: [Koha-bugs] [Bug 10755] Add "Keyword as Phrase" to staff client advanced search indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 15:35:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 13:35:25 +0000 Subject: [Koha-bugs] [Bug 10755] Add "Keyword as Phrase" to staff client advanced search indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20452|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 20552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20552&action=edit [SIGNED-OFF] Bug 10755 - Add "Keyword as Phrase" to staff client advanced search indexes This patch adds a "Keyword as Phrase" index to the search options in the staff client. Test Plan: 1) Go to the Advanced Search in the staff client and click on the "Keyword" drop-down list. 2) Note that there is only a "Keyword" not a "Keyword as Phrase" option 3) Apply the patch 4) Reload the Advanced Search 5) Note that there is now a "Keyword as Phrase" option as well If you want to test the functionality...it will depend on your catalogue data. Basically, a phrase search will allow you to find "Keyword Adjacent To Keyword" rather than a more scattershot search that finds the keywords regardless of their position to each other. Signed-off-by: Owen Leonard Template change is correct, and in my tests the searching behavior was correctly modified: Using "keyword as phrase" returned only results where the terms were adjacent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 15:43:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 13:43:28 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #19 from Jared Camins-Esakov --- I just tested the most recent version of this patch (which has not been signed off), and I'm not sure it works. I get the following message when I click the Merge button: Following required subfields are missing: - 003$@ - 008$@ - 005$@ However, all three fields are in my target record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 15:48:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 13:48:03 +0000 Subject: [Koha-bugs] [Bug 10038] Doubled 'default' entry when creating a new authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10038 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 15:48:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 13:48:07 +0000 Subject: [Koha-bugs] [Bug 10038] Doubled 'default' entry when creating a new authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10038 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19719|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 20553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20553&action=edit Bug 10038: Doubled 'default' entry when creating a new authority type Test plan: - Create a new authority type - Click MARC structure - Verify the pull down has only 1 entry for Default - Go on the authority type home (admin/authtypes.pl) - Click on the "MARC structure" link for the default type - Verify the pull down has only 1 entry for Default This patch adds a sort (on the authtypecode) for these 2 lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 15:50:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 13:50:55 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #105 from Jared Camins-Esakov --- Unfortunately the fourth patch, "Move uploadPath syspref to koha-conf.xml" will not apply at all because of missing sha1 information for sysprefs.sql. Could you please rebase this patchset and reupload? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 15:53:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 13:53:05 +0000 Subject: [Koha-bugs] [Bug 10308] Authorities linker should handle the "local subject added entry" fields. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10308 --- Comment #2 from Jared Camins-Esakov --- Is there a reason you didn't mark 696-699 as subjects? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:04:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:04:33 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #106 from M. Tompsett --- I'm attempting to backport to 3.12.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:07:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:07:52 +0000 Subject: [Koha-bugs] [Bug 10779] New: Keyword Highlighting highlights partial words Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10779 Bug ID: 10779 Summary: Keyword Highlighting highlights partial words Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org I'm not 100% sure this is a bug or a 'feature'.. If you do a search on "Chitty on contracts" for example, every instance of 'Chitty' and 'on' is highlighted including the 'on' contained within 'contracts'. Surely the hole word 'contracts' should be highlighted and every occurrence of 'on' inside a word should not..? I've found that if you change the order of the search words to 'chitty contracts on' then you'll get 'contracts' highlighted correctly. but you will also still get 'on' within other words highlighted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:08:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:08:02 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19204|0 |1 is obsolete| | --- Comment #27 from Jared Camins-Esakov --- Created attachment 20554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20554&action=edit Bug 10240: Offline circulation using HTML5 and IndexedDB This patch adds an HTML5-based offline mode to Koha's existing circulation module, allowing librarians to check out items using a basically familiar interface. The feature will be implemented using the Application Cache and IndexedDB features of the HTML5 specification, both of which are fully supported on Firefox 10+ and Chrome 23+, with limited support going back to Firefox 4 and Chrome 11. The basic workflow enabled by this patch is as follows: Part 1: While connected to the Internet 1. Enable offline functionality by turning on the "AllowOfflineCirculation" system preference. 2. Sync the offline circulation database on the computer that will be used for offline circulation by following the "Offline circulation interface" link on the Circulation home page, choosing "Synchronize (must be online)", and clicking the "Download records" button. This process may take a while. 3. Bookmark /cgi-bin/koha/circ/offline.pl (the page you are currently on) for easy access when offline. Part 2: While disconnected from the Internet 4. Navigate to /cgi-bin/koha/circ/offline.pl using the bookmark you created while online. 5. Start checking books in by scanning the barcode of an item that has been returned into the box in the "Check in" tab. 6. Scan the barcodes of any additional items that have been returned. 7. Start checking out books to a patron by scanning the patron's barcode in the box in the "Check out" tab. 8. Set a due date (the "Remember for session" box will be checked by default, since circulation rules are not computed during offline transactions and therefore a due date must be specified by the librarian). 9. Scan an item barcode (if you did not set a due date, it will prompt you) to check the item out to the patron. 10. If a patron has a fine you can see the total amount (current to when the offline module was synced), and record a payment. Unlike when in online mode, there will be no breakdown of what item(s) fines are for, and you will only be able to record the payment amount and not associate it with a particular item. Part 3: While connected to the Internet 11. Click the "Synchronize" link and choose "Upload transactions" to upload the transactions recorded during the offline circulation session. 12. Navigate to /cgi-bin/koha/offline_circ/list.pl (there will be a link from the Offline circulation page) and review the transactions, as described in the documentation for the Firefox Offline circulation plugin: http://wiki.koha-community.org/wiki/Offline_circulation_firefox_plugin Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:08:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:08:09 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19353|0 |1 is obsolete| | --- Comment #28 from Jared Camins-Esakov --- Created attachment 20555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20555&action=edit Bug 10240 QA follow-up Address the following issues: 1/ Address minor qa issues with the templates: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 24) [etc.] OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 509) [etc.] FAIL tt_valid lines 5, 5 2/ Run perltidy on new scripts 3/ download.pl returns data.finished = 1 if number of returned data < 5000 (avoids 1 ajax call) 4/ Replace qq{} around sql queries with q{} Also, a race condition existed that resulted in pending transactions only getting deleted from the local database in certain circumstances (fast connections under Chrome, mostly). This patch fixes that so that successfully-uploaded transactions are always deleted. This patch also addresses Jonathan's suggestion: 3/ add a message on check in (currently the input becomes empty but the user is not informed). ... and Magnus's suggestion about moving the Synchronize link to the right on the homepage. Also, this addresses the further issues Jonathan noted: - The tab of checkouts always shows "*0* Checkouts" - If I am not well-educated, I click on the "Check out" link on the offline home page, I enter a barcode, click on "Check out" and I get a js error (without user message): "TypeError: curpatron is undefined" (with chromium I get: Numeric transaction modes are deprecated in IDBDatabase.transaction. Use "readonly" or "readwrite"). - There is a "border-right" css rule on the h5.patron-title. It is display when there is no patron selected) [really minor!]. - tables are displayed even if there is no data - The "Clear screen" link (X) points to an old script: circ/offline-circulation.pl - There is a warning when clicking on the "Synchronize" link when the user is offline, but not for the "Pending offline circulation actions" link. - Still exists: > The "Checked in item." message text never disappear (even if I go on the > offline home page (circ/offline.pl#offline-home)). Finally, this patch adds a link to the Pending offline operations page on the synchronize page for easier navigation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:08:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:08:19 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19528|0 |1 is obsolete| | --- Comment #29 from Jared Camins-Esakov --- Created attachment 20556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20556&action=edit Bug 10240 follow-up: don't delete transactions if auth fails When uploading transactions, we were not checking that authentication had succeeded before deleting the transactions from the local database. That was bad. With this patch, we check. That is good. Rebased on latest master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:09:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:09:20 +0000 Subject: [Koha-bugs] [Bug 10530] PO number search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10530 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20284|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 20557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20557&action=edit [SIGNED-OFF] Bug 10530 - PO number search Ability to search the purchase order Test plan: 1) Create an basket 2) Create an order 3) Click on order search link and click on plus symbol 4) Purchase order no input box will come give the no and click on sumbit 5) Click on Advance search link search order screen will appear enter value in the purcahse ordernumber textbox. Signed-off-by: Owen Leonard Made minor edit during signoff: Changed "ordernumber" in table header to "order number." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:09:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:09:18 +0000 Subject: [Koha-bugs] [Bug 10530] PO number search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10530 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:11:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:11:31 +0000 Subject: [Koha-bugs] [Bug 10401] Add ability to merge invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10401 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19865|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov --- Created attachment 20558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20558&action=edit Bug 10401: Add ability to merge invoices Given how easy it is to accidentally receive items from one invoice on multiple invoices, the ability to merge invoices can be quite handy. This patch adds that ability to Koha's Acquisitions module. To test: 1) Apply patch. 2) Run unit test: > prove t/db_dependent/Acquisition/Invoices.t 3) Create two invoices from the same vendor for merging, and receive at least one order on each. 4) Do a search on the Invoices page that brings up both the invoices you created. 5) Check the boxes next to the two invoices. 6) Click "Merge selected invoices." 7) Choose which invoice you want to keep (the default will be the first). 8) Click "Merge." 9) Confirm that the resulting invoice has all the orders you received listed on it. 10) Sign off. Rebased on latest master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:18:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:18:31 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20045|0 |1 is obsolete| | --- Comment #22 from Jared Camins-Esakov --- Created attachment 20559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20559&action=edit Bug 10402: Use an object for contacts In preparation for adding the ability to handle multiple contacts, this patch moves booksellers' contacts into their own class, C4::Bookseller::Contact. To test: 1) Apply patch. 2) Run database update. 3) Edit a bookseller, making sure to add a contact. 4) View the bookseller's information, making sure the contact information is there. 5) Run the unit test: > prove t/db_dependent/Bookseller.t Signed-off-by: Owen Leonard Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:18:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:18:40 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20046|0 |1 is obsolete| | --- Comment #23 from Jared Camins-Esakov --- Created attachment 20560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20560&action=edit Bug 10402: Move contacts to separate table This patch normalizes the data structures used for bookseller contacts. To test: 1) Repeat tests described on previous patch. Signed-off-by: Owen Leonard Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:18:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:18:48 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20047|0 |1 is obsolete| | --- Comment #24 from Jared Camins-Esakov --- Created attachment 20561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20561&action=edit Bug 10402: Add ability to enter multiple contacts Some vendors may have more than one contact. For example, a technical contact and a billing contact, or a contact for journals and a contact for monographs. Rather than require that each contact be either made into a separate vendor or recorded somewhere outside of Koha, it would be really useful of Koha had the ability to add multiple additional contacts to vendors in the Acquisitions module. To test: 1) Apply patch. 2) Edit a bookseller, making sure to add a contact. 3) View the bookseller's information, making sure the contact information is there. 4) Run the unit test: > prove t/db_dependent/Bookseller.t 5) Add multiple contacts to a vendor, see that they show up. 6) Delete one contact from a vendor with multiple contacts, see that the result is correct. 7) Sign off. Note: This test plan can supersede that on the previous two patches, as all functionality of the previous two patches is required by this one. Signed-off-by: Owen Leonard Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:19:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:19:31 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:19:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:19:33 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20048|0 |1 is obsolete| | --- Comment #25 from Jared Camins-Esakov --- Created attachment 20562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20562&action=edit Bug 10402 [Template follow-up] Add multiple contacts for vendors This template-only follow-up tweaks the button labels and restructures the vendor view layout a little bit to make it more amenable to multiple contacts: - Add spaces after button icons - Change "Add contact" to "Add another contact" in hopes of making it less ambiguous whether clicking it will submit the whole form. - Eliminate duplicate headers on the vendor view page by making the contact name the subheading for each individual contact. To test, view details for vendors with one or more contacts, and try editing to add additional contacts. Everything should look good and work correctly. Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:21:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:21:54 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|julian.maurice at biblibre.com |jcamins at cpbibliography.com --- Comment #32 from Jared Camins-Esakov --- Several people have asked about a test plan, so I am repeating my test plan from comment 30, since that comment is so long it can be hard to find: To test using the sample records attached to the bug (MARC21 only): 1) Apply patches. 2) Import the sample records (sampleauths.mrc) file into Koha and make sure that they get indexed (by waiting until rebuild_zebra.pl runs automatically or by running rebuild_zebra.pl -a -z [-x] manually) 3) Deduplicate based on LCCN (replace {FIRSTAUTH} with the authid of the first imported record; on my system that number is 367123668; this is not actually necessary, but if you have a lot of authority records, the process could take quite a while otherwise): > misc/migration_tools/dedup_records.pl -t -v -a \ -l "authid >= {FIRSTAUTH}" -r -m "lc-card/010a" -s date 4) Check that you have 21 duplicate records replaced from amongst the new records (you will quite possibly have more than 21 duplicate records reported, depending on whether you have any of these authorities already, but you should have at least the 21). 5) Deduplicate based on genre heading, preferring Library of Congress authorities to local authorities: > misc/migration_tools/dedup_records.pl -t -v -a \ -l "authid >= {FIRSTAUTH}" -r -m "he/155a" -s "source=DLC" -s date 6) Check that you have 3 duplicate records replaced from amongst the new records. 7) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:25:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:25:53 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:25:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:25:55 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19579|0 |1 is obsolete| | --- Comment #12 from Jared Camins-Esakov --- Created attachment 20563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20563&action=edit Bug 10535: (follow-up) add test case This adds a test case for the new default sort order for GetBudgets(). Signed-off-by: Galen Charlton Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:27:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:27:52 +0000 Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #2 from Jared Camins-Esakov --- Is it really a good idea to put a slash in the index name? What we usually do is replace all punctuation with hyphens. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:31:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:31:39 +0000 Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20374|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov --- Created attachment 20564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20564&action=edit Bug 10737 - Add "Add to basket" link on vendor search results page This patch adds an "add to basket" link to the vendor search results page for each open basket associated with each vendor. Clicking it triggers a modal window with the "add to basket" choices for that vendor and basket. Other changes in this patch: - "New basket" and "Receive shipment" buttons associated with each vendor search result have been converted to Bootstrap-styled buttons. - Basket closed date has been moved into its own column so that the table can be sorted by that value. - Table columns containing dates now use the "title-string" sort option, eliminating the need for a special date sorting algorithm. - Converted some &'s to &'s To test, apply the patch and search for a vendor. For each vendor in your search results baskets which are open should include an "add to basket" link. Clicking it should open a modal dialog with the same "add to basket" options offered on the basket page. The correct vendor ID and basket number should be associated with each link. The newly-styled "new basket" and "receive shipment" buttons should work correctly. Table sorting should work correctly, including the new "closed" column. Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:31:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:31:37 +0000 Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:49:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:49:35 +0000 Subject: [Koha-bugs] [Bug 10745] More fun on translation bug with XSLT subfieldSelect parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Could we please get another sign-off on this one? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:58:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:58:04 +0000 Subject: [Koha-bugs] [Bug 10745] More fun on translation bug with XSLT subfieldSelect parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 16:58:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 14:58:06 +0000 Subject: [Koha-bugs] [Bug 10745] More fun on translation bug with XSLT subfieldSelect parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20547|0 |1 is obsolete| | --- Comment #5 from Jared Camins-Esakov --- Created attachment 20565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20565&action=edit Bug 10745 - More fun on translation bug with XSLT subfieldSelect parameters As in Bug 6278, this patch replace ">at<" with ">a_t<" so not to mislead translators. Found more cases that initial description. To test: 1) Check that problem exists and only on xslt files, using your preferred language egrep -B10 "^msgid \"at\"" misc/translator/po/xx-YY-i-staff-t* 2) Apply the patch 3) Update translation file (cd misc/translator; perl translate update xx-YY) 4) Verify the problem is gone, repeat 1 5) If you like verify new entries in PO file egrep -B15 "^msgid \"a_t\"" misc/translator/po/xx-YY-i-staff-t* Signed-off-by: Marcel de Rooy Tested this with field 780 and running a Dutch translation. Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 17:02:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 15:02:07 +0000 Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #3 from Fridolyn SOMERS --- (In reply to Jared Camins-Esakov from comment #2) > Is it really a good idea to put a slash in the index name? What we usually > do is replace all punctuation with hyphens. The index is actually like this. But I agree to modify. I'd say : Datetime-last-modified What do you say ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 17:04:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 15:04:26 +0000 Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #4 from Jared Camins-Esakov --- (In reply to Fridolyn SOMERS from comment #3) > (In reply to Jared Camins-Esakov from comment #2) > > Is it really a good idea to put a slash in the index name? What we usually > > do is replace all punctuation with hyphens. > The index is actually like this. > But I agree to modify. I'd say : Datetime-last-modified > What do you say ? I think that's the best idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 17:23:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 15:23:45 +0000 Subject: [Koha-bugs] [Bug 10745] More fun on translation bug with XSLT subfieldSelect parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 17:41:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 15:41:11 +0000 Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #5 from mathieu saby --- Hello Fridolyn I wanted to reword this index in bug 8252 (needs signoff), but changed my mind after Paul's comment. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 17:56:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 15:56:36 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 --- Comment #2 from Jared Camins-Esakov --- Created attachment 20566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20566&action=edit Bug 6594: Schema.org structured data for OPAC display To support schema.org processors, such as Google, Bing, and Yandex, structure our data so that it has machine-readable attributes. This pass declares the CreativeWork sub-types as well as Product for the main bibliographic record details, and uses the Offer type for holdings information per the W3C Schema Bib Extend community group discussions. Signed-off-by: Dan Scott Signed-off-by: Jared Camins-Esakov Comments on final patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 17:56:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 15:56:45 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 --- Comment #3 from Jared Camins-Esakov --- Created attachment 20567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20567&action=edit Bug 6594: Move subject keywords schema.org markup into element Google's rich snippets tool gets confused by the approach, so stuff another span inside the element to remove confusion with the href attribute. Signed-off-by: Dan Scott Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 17:56:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 15:56:53 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 --- Comment #4 from Jared Camins-Esakov --- Created attachment 20568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20568&action=edit Bug 6594: Correct schema.org context for item status We were inserting the element inside an open element, which HTML parsers, even the most forgiving, do not like very much. Signed-off-by: Dan Scott Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 17:57:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 15:57:10 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 --- Comment #5 from Jared Camins-Esakov --- Created attachment 20569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20569&action=edit Bug 6594: Schema.org span nesting improvements So, it turns out that the was causing a new "chain" to be invoked, thus nesting the elements for properties within the actually caused the properties to be attached to that new chain rather than the containing object. Therefore, wrap the elements around the elements where applicable. Thanks to Manu Sporny in #rdfa for helping me to sort this out. Signed-off-by: Dan Scott Signed-off-by: Jared Camins-Esakov I tested by validating against the Google rich snippet tool, validator.nu, and linter.structured-data.org. All were satisfied with the microdata markup, and the properties that are set make sense. These patches are only for MARC21 XSLT view, but I think it is worth pushing them even without the NORMARC and UNIMARC markup, so that people can start to test out schema.org microdata in Koha, and refine the implementation. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 17:57:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 15:57:08 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 17:57:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 15:57:22 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 19:17:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 17:17:15 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Mickey Coalwell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mcoalwell at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 22 23:30:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 21:30:35 +0000 Subject: [Koha-bugs] [Bug 6435] False "no items" in search results [intranet] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |liz at catalyst.net.nz --- Comment #18 from Liz Rea --- Hi Doug, I would like to test this patch, however it appears to be formatted incorrectly - please see http://wiki.koha-community.org/wiki/Version_Control_Using_Git for help on setting up git and sending in patches. If you are having trouble with any of that, do say and I'll see about making a git formatted patch for you - but please have a try at doing it with git first. :) Thanks, Liz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 00:33:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 22:33:51 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 00:33:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 22:33:54 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20306|0 |1 is obsolete| | Attachment #20307|0 |1 is obsolete| | Attachment #20308|0 |1 is obsolete| | Attachment #20309|0 |1 is obsolete| | Attachment #20310|0 |1 is obsolete| | --- Comment #8 from Liz Rea --- Created attachment 20570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20570&action=edit Bug 10718 - items with no checkouts report does not work Bug 8124 has commented the option to download results items with no checkouts report into a file. But the perl code of this page uses the export into a file has default behavior since the input "output" is no more present. The consequence is that there are never results in page. This patch removes the code concerning file output from template and perl. Such a feature exists in guided reports. Test plan : Play with cgi-bin/koha/reports/catalogue_out.pl form and see if you get results Bug 10718 - select user branch as default In cgi-bin/koha/reports/catalogue_out.pl report, select in library filter the user logged-in. Test plan : - Log into intranet with a normal user - Got to "Items with no checkouts" reports => Your branch is selected - Run report => You see "Filtered on : Branch = " - Come back to report - Select "Any library" - Run report => You do not see "Filtered on : Branch" Bug 10718 - items with no checkouts report permission is execute_reports This report only executes SQL to change reports/catalogue_out.pl permissions from all reports subpermissions to reports/execute_reports. Test plan : Test you can access and run this report with only execute_reports subpermission into reports permission. Bug 10718 - redefine limit input In reports/catalogue_out.pl form, the limit input is by defaut none. So by default the report queries all the catalogue. This may take a very long time (fall into timeout) and since now the results are displayed in page, the page may be huge. This patch modifies limit input to removes the "none" option. Also reduces the number of options (same options as guided reports results per page). Test plan: - Go to reports/catalogue_out.pl => first value "10" is selected - Launch report => You see "Filtered on: limit = 10" Bug 10718 - perltidy on reports/catalogue_out.pl Signed-off-by: Liz Rea Tested all of these things, all ok - squashed patch for neatness. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 00:44:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 22:44:37 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #27 from Srdjan Jankovic --- Newer versions of Perl shouldn't mind that. Older versions required, and up until 5.12 I believe preferred keys(%whatever). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 01:42:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Aug 2013 23:42:12 +0000 Subject: [Koha-bugs] [Bug 10661] Mandatory item fields should be formatted the same on all forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10661 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |liz at catalyst.net.nz --- Comment #3 from Liz Rea --- Hi Owen, Looks like it works, but on my display, in serials, the width of the table seems to bump the red "required" text to the next line - http://img547.imageshack.us/img547/5568/qjij.png I hate to mark it failed because it's not a failure per-se... just needs a tweak. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 02:52:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 00:52:18 +0000 Subject: [Koha-bugs] [Bug 10777] runreport.pl allows for sending html reports via email, but mimetype is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10777 --- Comment #4 from Nicholas van Oudtshoorn --- Will provide one next week, when I'm back in that office! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 03:03:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 01:03:11 +0000 Subject: [Koha-bugs] [Bug 9614] Fines not assessed after renewing an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9614 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 05:17:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 03:17:17 +0000 Subject: [Koha-bugs] [Bug 10741] Can not place a hold on an item in transit and for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10741 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20549|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 20571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20571&action=edit Bug 10741 - Formatting can place hold test Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 05:17:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 03:17:38 +0000 Subject: [Koha-bugs] [Bug 10741] Can not place a hold on an item in transit and for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10741 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20550|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 20572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20572&action=edit Bug 10741 - Can not place a hold on an item in transit and for loan In search results, one can not place a hold on an item in transit and for loan (items.notforloan=0). This appears when AllowOnShelfHolds is allowed. Depends on Bug 8975 code : a simple if condition is missing when not damaged. Test plan : - Set AllowOnShelfHolds to on - Create a record with a normal item : not lost, not withdrawn, not damaged, notforloan=0 - Index this record - Perform a search on OPAC that returns this record (and others) => You see in actions "Place hold" - Add this item in transit : /cgi-bin/koha/circ/branchtransfers.pl - Re-perform the search on OPAC => You see in actions "Place hold" and item "in transit" Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 05:17:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 03:17:51 +0000 Subject: [Koha-bugs] [Bug 10741] Can not place a hold on an item in transit and for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10741 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 05:17:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 03:17:54 +0000 Subject: [Koha-bugs] [Bug 10741] Can not place a hold on an item in transit and for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10741 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20571|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 20573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20573&action=edit Bug 10741 - Formatting can place hold test Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 05:57:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 03:57:24 +0000 Subject: [Koha-bugs] [Bug 6435] False "no items" in search results [intranet] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #19 from M. Tompsett --- Created attachment 20574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20574&action=edit My attempt to generate a useful patch from Doug's bizarre diff file. I wanted to accomplish something today. :) The one problem with his patch that I noticed thus far would include: -- Failed to update the HELP to give information regarding the parameters added. test: $ ./misc/migration_tools/rebuild_zebra.pl --help Take this patch, and fix it up, Doug. :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 05:59:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 03:59:19 +0000 Subject: [Koha-bugs] [Bug 6435] Added daemon mode parameters to rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|False "no items" in search |Added daemon mode |results [intranet] |parameters to | |rebuild_zebra.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 06:03:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 04:03:14 +0000 Subject: [Koha-bugs] [Bug 6435] Added daemon mode parameters to rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20574|0 |1 is obsolete| | --- Comment #20 from M. Tompsett --- Created attachment 20575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20575&action=edit Convert Doug's diff into a patch. Oops! Had a space problem that would have triggered a QA issue. :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 06:28:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 04:28:20 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz Assignee|gmcharlt at gmail.com |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 06:36:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 04:36:28 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20252|0 |1 is obsolete| | --- Comment #49 from Srdjan Jankovic --- Created attachment 20576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20576&action=edit Bug 9611: Change the password hashing algorithm from MD5 to Bcrypt What this patch aims to accomplish? * All new passwords are stored as Bcrypt-hashes * For password verification: - If the user was created before this patch was applied then use MD5 to hash the entered password <-- backwards compatibility - If the user was created after this patch was applied then use Bcrypt to hash the entered password * Any password change made via the staff interface or the OPAC will be automatically Bcrypt-hashed; this applies to old users whose passwords were stored as MD5 hashes previously Test plan: 1) Add new users and check whether their passwords are stored as Bcrypt hashes or not. 2) To test that authentication works for both old as well as new users: a) Login as an existing user whose password is stored as a MD5 hash b) Login as an existing user whose password is stored as a Bcrypt hash 3) In the staff interface, change the password of an existing user whose password is stored as an MD5 hash a) Check the new password is stored as a Bcrypt-hash in the database b) Try to login with the new password 4) In the OPAC, verify that a) Old user with old pass can change password, new format b) New user with new pass can change password c) Old and new user with self-updated pass can login Whitespace cleanup was contributed by Bernardo Gonzalez Kriegel. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Mason James Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 06:41:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 04:41:53 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20253|0 |1 is obsolete| | --- Comment #50 from Srdjan Jankovic --- Created attachment 20577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20577&action=edit bug 9611: removing external dependency for password salt generator To address packaging issues with Crypt::Random::Source, this patch replaces the salt generation with a wrapper for /dev/urandom and /dev/random. The test plan for this patch is the same as that for the base patch for bug 9611. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 06:56:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 04:56:41 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20576|0 |1 is obsolete| | Attachment #20577|0 |1 is obsolete| | --- Comment #51 from Srdjan Jankovic --- Created attachment 20578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20578&action=edit Bug 9611: Change the password hashing algorithm from MD5 to Bcrypt What this patch aims to accomplish? * All new passwords are stored as Bcrypt-hashes * For password verification: - If the user was created before this patch was applied then use MD5 to hash the entered password <-- backwards compatibility - If the user was created after this patch was applied then use Bcrypt to hash the entered password * Any password change made via the staff interface or the OPAC will be automatically Bcrypt-hashed; this applies to old users whose passwords were stored as MD5 hashes previously Test plan: 1) Add new users and check whether their passwords are stored as Bcrypt hashes or not. 2) To test that authentication works for both old as well as new users: a) Login as an existing user whose password is stored as a MD5 hash b) Login as an existing user whose password is stored as a Bcrypt hash 3) In the staff interface, change the password of an existing user whose password is stored as an MD5 hash a) Check the new password is stored as a Bcrypt-hash in the database b) Try to login with the new password 4) In the OPAC, verify that a) Old user with old pass can change password, new format b) New user with new pass can change password c) Old and new user with self-updated pass can login Whitespace cleanup was contributed by Bernardo Gonzalez Kriegel. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Mason James Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 08:47:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 06:47:10 +0000 Subject: [Koha-bugs] [Bug 9614] Fines not assessed after renewing an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9614 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- There is not a lot of information on this, I wonder if it's only true if you recalculate fines on return or if it is a problem with the fines script? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 10:20:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 08:20:57 +0000 Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #6 from Fridolyn SOMERS --- (In reply to mathieu saby from comment #5) > Hello Fridolyn > I wanted to reword this index in bug 8252 (needs signoff), but changed my > mind after Paul's comment. > > Mathieu Oh, yes. @Jared : What do you think about bug 8252 ? I'd say it is dangerous to use a "/" in indexes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 10:23:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 08:23:03 +0000 Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #7 from mathieu saby --- I thought it was dangerous too ;-) But bug 8252 is already quite complex to test, so I won't replace the / in it... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 10:37:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 08:37:43 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 10:37:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 08:37:46 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20563|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 20579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20579&action=edit Bug 10535: (follow-up) add test case This adds a test case for the new default sort order for GetBudgets(). Signed-off-by: Galen Charlton Signed-off-by: Jared Camins-Esakov Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 11:02:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 09:02:34 +0000 Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- QA comment: All works as expected. 1/ 1 remark: The "Add to basket" link is only added for closed basket (normal!) so an empty column appears on bookseller with only closed basket. Maybe should we group the 2 action links into 1 column? 2/ 1 question: Isn't it possible to add the fieldset "Add order to " into an include (in order to be shared between the acqui/basket.pl page and this page? Marked as Failed QA for 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 15:21:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 13:21:31 +0000 Subject: [Koha-bugs] [Bug 8752] Log circulation renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 15:21:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 13:21:33 +0000 Subject: [Koha-bugs] [Bug 8752] Log circulation renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20453|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 20580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20580&action=edit [SIGNED-OFF] Bug 8752 - Log circulation renewal Currently, circulation renewals are not being logged. This patch logs renewals under the Circulation module with an action of RENEW. At the moment, it relies on the "IssueLog" preference, but we could add a new syspref for "RenewLog". Personally, I figure it's just a "re-issue" so I don't know that we need another preference, but system preferences are cheap, so if people think a follow-up is necessary, I'm open to the idea. Test Plan: 0) Turn on IssueLog and ReturnLog in the system preferences 1) Checkout an item 2) Note that there is a CIRCULATION ISSUE log entry 3) Renew that item 4) Note that there is NOT a log entry 5) Return that item 6) Note that there is a CIRCULATION RETURN log entry 7) Apply patch 8) Repeat Step #3 (i.e. renew that item). 9) Note that there is now a CIRCULATION RENEW log entry N.B. Logs can be viewed by directly querying the database, viewing the Modification Log for the patron attached to the checkout/renew/ return, or by viewing the logs in the Tools module using the item's itemnumber as the "Object". Signed-off-by: Owen Leonard This works as advertised, and I think it's an appropriate extension to the scope of IssueLog. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 16:04:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 14:04:22 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 16:04:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 14:04:25 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18077|0 |1 is obsolete| | --- Comment #20 from Owen Leonard --- Created attachment 20581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20581&action=edit [SIGNED-OFF] Bug 8231 Systematic warning at check in if borrower is restricted Display, at check in, a reminder of an already existing suspension date even if the returned document is not late Test plan : 1) Apply the patch 2) Go to a borrower checkout page and checkout some documents with different passed duedate using "Specify due date" function. Checkout out one with the default duedate. 3) Check in the document with the bigger delay : You will get the message : 'X is now restricted until ...' 4) Check in one of the document with a smaller delay : You'll get a different message : 'Reminder : Patron was earlier restricted until...' 5) Check in the document which is not late : You'll get the same message as the previous one Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 16:11:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 14:11:23 +0000 Subject: [Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Owen Leonard --- Kyle if you could please squash these two patches I will test again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 16:12:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 14:12:44 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 --- Comment #4 from Owen Leonard --- One patch is labeled "[v3.10/v3.12]" and the other is unlabeled. What's the difference? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 16:28:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 14:28:23 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #7 from Jonathan Druart --- Owen, does the last patch fix your error? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 16:58:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 14:58:30 +0000 Subject: [Koha-bugs] [Bug 8004] Items on hold lose transfer after being scanned twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 16:58:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 14:58:33 +0000 Subject: [Koha-bugs] [Bug 8004] Items on hold lose transfer after being scanned twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17911|0 |1 is obsolete| | --- Comment #11 from Owen Leonard --- Created attachment 20582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20582&action=edit [SIGNED-OFF] Bug 8004 - Followup - Rename KohaBranchName filter to BranchName This patch renames the TT filter KohaBranchName to just BranchName, as the Koha is superfluous. Test Plan: 1) Apply patch 2) Attempt to transfer an item to the incorrect branch, you should see the name of the branch in the "please return to" message. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 16:58:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 14:58:46 +0000 Subject: [Koha-bugs] [Bug 8004] Items on hold lose transfer after being scanned twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 --- Comment #12 from Owen Leonard --- Created attachment 20583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20583&action=edit Bug 8004 - Followup [follow-up] Rename KohaBranchName filter to BranchName Since the original follow-up to 8004 was submitted the KohaBranchName filter was put to use in several other templates and a test was added. This patch corrects the filter name in the templates and changes the name of, and in, the test. To test: - Enable IndependentBranches and log in to Koha as a non-superlibrarian. Try to check out an item which belongs to another library. The library name should appear correctly in the warning message. - In Acquisitions, view the list of basket groups for any vendor. The "billing place" and "delivery place" columns should show library names correctly. - View the detail page for a subscription (serials/subscription-detail.pl?subscriptionid=X). The library name should appear correctly. - In suggestions management, view the details for a suggestion (/suggestion/suggestion.pl?suggestionid=X&op=show). Library names should appear correctly in the "suggestions management" table and in the "acquisition information" block. - Test the Koha_template_plugin_BranchName.t test: In a test database that has the sample branchesloaded, run prove -v t/db_dependent/Koha_template_plugin_BranchName.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 16:59:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 14:59:07 +0000 Subject: [Koha-bugs] [Bug 8004] Items on hold lose transfer after being scanned twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 17:42:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 15:42:18 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #8 from Owen Leonard --- (In reply to Jonathan Druart from comment #7) > Owen, does the last patch fix your error? I can now read the configuration settings page without errors, and it seems to work with the circulation checkouts table. However, it had no effect on the holds table. I also don't see a "show/hide columns" control on the holds tab. I still get a JavaScript error on the circulation page. Perhaps this is the cause? TypeError: a.aoColumns[c] is undefined /intranet-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.min.js Line 29 In my informal tests it didn't seem to slow down loading of the circulation page compared to master. I'd like to make the "show/hide columns" box less obtrusive, but I don't have any suggestions for how to do that at the moment. Is the yml file translatable? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 17:59:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 15:59:11 +0000 Subject: [Koha-bugs] [Bug 10741] Can not place a hold on an item in transit and for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10741 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master, along with a follow-up that adds a regression test. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 18:16:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 16:16:25 +0000 Subject: [Koha-bugs] [Bug 10745] More fun on translation bug with XSLT subfieldSelect parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 18:36:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 16:36:20 +0000 Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #4 from Owen Leonard --- > 2/ 1 question: Isn't it possible to add the fieldset "Add order to " into an > include In fact there already is one I should be using. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 20:48:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 18:48:51 +0000 Subject: [Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Sophie! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 23 20:49:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 18:49:17 +0000 Subject: [Koha-bugs] [Bug 10745] More fun on translation bug with XSLT subfieldSelect parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 24 01:38:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Aug 2013 23:38:54 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #107 from M. Tompsett --- Okay, I accidentally messed up and got what I think is this working for master. However, I have some concerns. misc/strip_value_from_tag.pl The patches containing this were obsoleted (see first 5 ones, I think). Is this module not useful? t/lib/Mocks/Context.pm This exists in part in the non-obsoleted patches ([SIGNED-OFF] Bug 6874: Move uploadPath syspref to koha-conf.xml), but I think something substituting for t::lib::Mocks would be sufficient based on my reading of the code. 3-5 lines of code are missing in the patch, so I can't reconstruct what I think is the original file. I hunted through all the obsoleted patches too. I would very much prefer the original developer/author to rebase their patch, but am willing to provide what I have reconstructed. I know that my colleagues have asked for this patch, and so I'll make sure to back port to 3.12.x too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 24 13:29:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Aug 2013 11:29:01 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #4 from mathieu saby --- Hello I have just realized I've created a bug for the same idea, but with other informations to store. Could you take a look? (Bug 10778). If you agree I can write a patch. M. Saby -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 24 17:39:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Aug 2013 15:39:16 +0000 Subject: [Koha-bugs] [Bug 10687] Incorrect tab information for tags 68a and 68b on default MARC21 auth framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Incorrect tab information |Incorrect tab information |for tags 86a and 86b on |for tags 68a and 68b on |default MARC21 auth |default MARC21 auth |framework |framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 24 17:40:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Aug 2013 15:40:05 +0000 Subject: [Koha-bugs] [Bug 10687] Incorrect tab information for tags 68a and 68b on default MARC21 auth framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20121|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 20584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20584&action=edit Bug 10687 - Incorrect tab information for tags 68a and 68b on default MARC21 auth framework This patch correct tab information for default MARC21 auth framework on tags 68a and 68b. Also added update for current installs. To test with current authorities_normal_marc21.sql loaded 1) run on database select distinct tagfield from auth_subfield_structure where cast(substr(tagfield,1,1) as unsigned) <> tab; 68a and 68b should be listed 2) apply the patch 3a) delete all auth frameworks and reload file ... OR ... 3b) run updatedatabase.pl 4) repeat step 1, no tags should be listed. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 24 17:40:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Aug 2013 15:40:46 +0000 Subject: [Koha-bugs] [Bug 10687] Incorrect tab information for tags 68a and 68b on default MARC21 auth framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #5 from Bernardo Gonzalez Kriegel --- (In reply to M. de Rooy from comment #3) > Please note also that your commit message and title also refer to 86? Ooops! Fixed commit message and description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 24 17:52:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Aug 2013 15:52:05 +0000 Subject: [Koha-bugs] [Bug 10687] Incorrect tab information for tags 68a and 68b on default MARC21 auth framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #6 from Bernardo Gonzalez Kriegel --- (In reply to M. de Rooy from comment #2) > Bernardo: > Could you provide a link to LOC for the description of these fields? > I was looking for 68a History note, but I can't find it. > Thanks. Marcel: Sorry but I can't, I couldn't find any information about those tags. They are in the framework since Nov 8 2007, a patch by thd I think that they could be removed, but the policy is not to remove anything. Perhaps they are a typo, or are a strange and old set of tags, really don't know. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 13:19:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 11:19:03 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #36 from Katrin Fischer --- Hi Kenza, I see a problem running the QA script - could you take a look at that? QA SCRIPT testing 1 commit(s) (applied to b341d4e 'Bug 10629 : Inappropriate uses of $st') FAIL t/db_dependent/Branch.t OK pod OK forbidden patterns FAIL valid Using a hash as a reference is deprecated OK critic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 13:19:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 11:19:48 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #37 from Katrin Fischer --- Ah, I should mention, that I applied 10629 before this patch, following the dependency note. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 13:27:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 11:27:55 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #21 from Katrin Fischer --- All the tests pass nicely, but there are a lot of warnings when you run the test with prove: Use of uninitialized value $calculated in substitution (s///) at /home/katrin/kohaclone/C4/Serials.pm line 985. Use of uninitialized value $pattern in numeric eq (==) at /home/katrin/kohaclone/C4/Serials.pm line 988. Maybe something for another bug? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 13:39:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 11:39:39 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 13:39:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 11:39:43 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19953|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer --- Created attachment 20585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20585&action=edit [PASSED QA] C4::Bookseller.pm need unit tests The tests are wrap in a transaction. NOTE: some tests should pass but doesn't because of incoherences in the code. These tests are in comments and preceded by FIXME Test plan: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 15/53 [Some warnings about uninitialised values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=53, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.46 cusr 0.03 csys = 0.51 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10528 Signed-off-by: Srdjan Signed-off-by: Katrin Fischer The new tests pass nicely, as do all old tests and the QA script. All patches marked as dependencies have been pushed to master already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 13:58:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 11:58:58 +0000 Subject: [Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 13:59:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 11:59:02 +0000 Subject: [Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20203|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 20586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20586&action=edit [PASSED QA] Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm This patch makes DelBookseller returns the number of supplier it has deleted or undef if nothing has been deleted. It also fixes a test which doesn't pass before in t/db_dependent/Bookseller.t To test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 1/54 All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.48 cusr 0.02 csys = 0.52 CPU) Result: PASS Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Logical change and makes another test pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 13:59:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 11:59:24 +0000 Subject: [Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Tested with patch for 10528 applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 14:54:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 12:54:55 +0000 Subject: [Koha-bugs] [Bug 10640] ModBookseller needs more explicit return values in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 14:54:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 12:54:58 +0000 Subject: [Koha-bugs] [Bug 10640] ModBookseller needs more explicit return values in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19990|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 20587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20587&action=edit [PASSED QA] ModBookseller needs more explicit return values in C4::Bookseller.pm Before, ModBookseller always returns undef. This patch modifies it in order to be more explicit. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given It also fix one of the tests which didn't pass before in t/db_dependent/Bookseller.t To Test: prove t/db_dependent/Bookseller.t Bookseller.t .. 1/54 [Some warnings about uninitialized values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.04 csys = 0.53 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10640 Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Change is logical and passes new and old tests. Fixed the author line to have Kenza's correct email address. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 18:12:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 16:12:46 +0000 Subject: [Koha-bugs] [Bug 10430] status filter not working in serial claims when translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #11 from Katrin Fischer --- This patch works nicely and the classes are correct, as every status can show up multiple times in this table. But I am a bit confused about "Arrived" and "Stopped" showing up in this list. I checked the code and I think the pull down of filters should only have: Missing, Expected, Late, and Claimed. ----- =head2 GetLateOrMissingIssues ... AND (serial.STATUS = 4 OR ((planneddate < now() AND serial.STATUS =1) OR serial.STATUS = 3 OR serial.STATUS = 7)) >From the reports help: 1 = Expected 2 = Arrived 3 = Late 4 = Missing 5 = Not Available 6 = Delete 7 = Claimed 8 = Stopped This patch only adds 'Stopped', the other status have been there before. I think this can be fixed in a follow up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 18:16:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 16:16:32 +0000 Subject: [Koha-bugs] [Bug 10430] status filter not working in serial claims when translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 18:16:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 16:16:35 +0000 Subject: [Koha-bugs] [Bug 10430] status filter not working in serial claims when translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20197|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 20588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20588&action=edit [PASSED QA] Bug 10430 - status filter not working in serial claims when translated With a translated intranet (ie fr-FR) the status filter does not work for "Late" status. It is because status in combobox filter is translated "Retard" and status in table is translated "En retard". This patch changed javascript filter to work on a status code instead of status name. The new classes may be used to change CSS depending on status. Test plan : - Use a translated intranet (ie fr-FR) - Go to serials claim of a vendor with issues of multiple status - Check that status filter does its work Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Patch passes all tests and QA script. The status filter should probably be changed to only allow filtering on status that can appear on the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 18:38:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 16:38:08 +0000 Subject: [Koha-bugs] [Bug 10766] Cataloging reservoir search broken if UseQueryParser is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 18:38:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 16:38:11 +0000 Subject: [Koha-bugs] [Bug 10766] Cataloging reservoir search broken if UseQueryParser is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20551|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20589&action=edit [PASSED QA] Bug 10766: unbreak reservoir search when UseQueryParser is OFF To test: [1] Turn UseQueryParser off. [2] Ensure that your database has records in the reservoir. Performing a Z39.50 search will do this. [3] Perform a broad cataloging (i.e., cataloguing/addbooks.pl search). Note that results are returned from the main catalog but that no reservoir results are returned. [4] Apply the patch. [5] Perform the search again. This time, there should be both catalog and reservoir results. [7] Enable QueryParser. Perform the search again, and verify that the catalog and reservoir results are the same. Signed-off-by: Galen Charlton Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Patch works nicely, passes all tests, and the QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 18:45:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 16:45:53 +0000 Subject: [Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:00:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:00:06 +0000 Subject: [Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:00:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:00:09 +0000 Subject: [Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20542|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 20590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20590&action=edit [PASSED QA] Bug 9924 - Simplify and rename patron card creator error message include The patron card creator error message include uses a non-standard method for displaying error messages, and is poorly-named. This patch converts the method of displaying error messages for various patron card creator options to the standard one ('
    ') and renames the include file to make it clear that it relates only to patron card creator operations. To test, perform various operations: - Go to 'manage images' and try to upload a file which exceeds the 500KBfile size limit - Go to the edit batch page and manually append an error code to the URL: /cgi-bin/koha/patroncards/edit-batch.pl?op=new&error=403 - Go to one of the manage pages and manually append an error code to the URL: /cgi-bin/koha/patroncards/manage.pl?card_element=profile&error=201 Correct display of an error message indicates that the include file is being found. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes test plan, test suite and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:01:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:01:07 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:15:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:15:28 +0000 Subject: [Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20117|0 |1 is obsolete| | Attachment #20118|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 20591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20591&action=edit [PASSED QA] Bug 9820: display titles in MARC21 name headings better in XSLT mode Prior to this patch, if a 100/700 had a $c, it would be displayed with no space between the contents of $a and $c in XSLT mode. For example, 100 1#$aSeuss,$cDr. would be displayed as SeussDr The problem was caused by the original version of the stylesheets drawing a bit too much from the MARC21 to MODS transformation. To test: [1] In a MARC21 database, turn on XSLT display mode for staff and OPAC. [2] Create or identify a bib that has a 100 or 700 field with both a $a and a $c. [3] Before applying the patch, verify that the name is displayed in bib details and search results with the name and title squashed together. For example, "SeussDr" [3] After applying the patch, verify that the name displays in bib details and search results with a space and intervening punctuation between the name and the title. For example, "Seuss, Dr." Signed-off-by: Galen Charlton Signed-off-by: Jared Camins-Esakov Signed-off-by: Katrin Fischer Passes test plan, works nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:15:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:15:24 +0000 Subject: [Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:15:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:15:43 +0000 Subject: [Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 --- Comment #11 from Katrin Fischer --- Created attachment 20592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20592&action=edit [PASSED QA] Bug 9820 follow-up: fix a typo Although the XSLT template was renamed to nameABCQ, one instance of the old name (nameABCDQ) was not corrected. This patch corrects that. To test: Follow test plan on previous patch Signed-off-by: Jared Camins-Esakov Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:17:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:17:03 +0000 Subject: [Koha-bugs] [Bug 10766] Cataloging reservoir search broken if UseQueryParser is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10766 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:26:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:26:56 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:26:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:26:59 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20454|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 20593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20593&action=edit [PASSED QA] Bug 10333: Labels/t_Batch.t needs to create its own data prove t/db_dependent/Labels/t_Batch.t db_dependent/Labels/t_Batch.t .. 1/33 # Testing Batch->new() method. db_dependent/Labels/t_Batch.t .. ok All tests successful. Files=1, Tests=33, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.34 cusr 0.00 csys = 0.37 CPU) Result: PASS Signed-off-by: Srdjan Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:27:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:27:40 +0000 Subject: [Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh dependency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Looks like a small change - is there an easy way to verify the effect? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:34:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:34:10 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:42:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:42:32 +0000 Subject: [Koha-bugs] [Bug 10619] sco.css missing for CCSR OPAC templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 --- Comment #4 from Katrin Fischer --- Created attachment 20594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20594&action=edit [PASSED QA] Bug 10619 - sco.css missing for CCSR OPAC templates sco.css is not missing from CCSR, but some image paths in the CSS are incorrect, resulting in some missing images. This patch corrects those broken paths. This patch also hides the Cart/Lists/login region of the template which should not be visible in self checkout. To test, enable self-checkout and switch to the CCSR theme. Load a patron for self-checkout and confirm that images associated with buttons appear correctly: By the help link in the upper-right, on the 'Finish' button, etc. Try checking out an item which is already checked out to that patron to see more examples. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer CSS changes only, works nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:42:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:42:53 +0000 Subject: [Koha-bugs] [Bug 10619] sco.css missing for CCSR OPAC templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:42:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:42:56 +0000 Subject: [Koha-bugs] [Bug 10619] sco.css missing for CCSR OPAC templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20054|0 |1 is obsolete| | Attachment #20594|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 20595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20595&action=edit [PASSED QA] Bug 10619 - sco.css missing for CCSR OPAC templates sco.css is not missing from CCSR, but some image paths in the CSS are incorrect, resulting in some missing images. This patch corrects those broken paths. This patch also hides the Cart/Lists/login region of the template which should not be visible in self checkout. To test, enable self-checkout and switch to the CCSR theme. Load a patron for self-checkout and confirm that images associated with buttons appear correctly: By the help link in the upper-right, on the 'Finish' button, etc. Try checking out an item which is already checked out to that patron to see more examples. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer CSS changes only, works nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:50:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:50:32 +0000 Subject: [Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:50:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:50:35 +0000 Subject: [Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20158|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20596&action=edit [PASSED QA] Bug 10692: Routines about transfers in C4::Circulation.pm need unit tests The tests are wrap in a transaction. NOTE: Currently, some tests should pass but don't because of incoherences in the code. These tests are in comments and preceded by FIXME. To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=12, 18 wallclock secs ( 0.02 usr 0.01 sys + 0.37 cusr 0.06 csys = 0.46 CPU) Result: PASS Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:55:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:55:38 +0000 Subject: [Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in C4/Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 19:55:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 17:55:40 +0000 Subject: [Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in C4/Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20198|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20597&action=edit [PASSED QA] Bug 10699:DeleteBranchTransferLimits in C4/Circulation.pm needs return value This patch adds return values to DeleteBranchTransferLimits: 1 if a Transfer Limit is deleted undef if no parameters is given 0E0 if a wrong parameter is given More, it fixes and adds some tests in t/db_dependent/Circulation_transfers.t To test : prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=14, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Tested with patch for bug 10692 applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 20:02:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 18:02:31 +0000 Subject: [Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 20:02:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 18:02:34 +0000 Subject: [Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20349|0 |1 is obsolete| | Attachment #20350|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 20598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20598&action=edit [PASSED QA] Bug 10710: add unit tests for OfflineOperation's routines in C4/Circulation.pm This patch test AddOfflineOperation,GetOfflineOperation and DeleteOfflineOperation in C4/Circulation.pm. The tests are wrapped in a transaction. Note: Currently, GetOfflineOperations is not tested because we cannot mock C4::Context->userenv in unit tests To test: prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.01 usr 0.01 sys + 0.33 cusr 0.02 csys = 0.37 CPU Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 20:02:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 18:02:44 +0000 Subject: [Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 --- Comment #5 from Katrin Fischer --- Created attachment 20599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20599&action=edit [PASSED QA] Bug 10710: (follow-up) perltidy new code Also, I prefer the use of parentheses for function calls, even when no arguments are being passed. One missed comma turns is(GetOfflineOperation, ...) into is(GetOfflineOperation ...) Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 20:23:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 18:23:58 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- This patch doesn't seem to fix the translation problems fixed by 7478 - so I think we need both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 20:39:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 18:39:48 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 20:39:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 18:39:53 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20570|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 20600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20600&action=edit [PASSED QA] Bug 10718 - items with no checkouts report does not work Bug 8124 has commented the option to download results items with no checkouts report into a file. But the perl code of this page uses the export into a file has default behavior since the input "output" is no more present. The consequence is that there are never results in page. This patch removes the code concerning file output from template and perl. Such a feature exists in guided reports. Test plan : Play with cgi-bin/koha/reports/catalogue_out.pl form and see if you get results Bug 10718 - select user branch as default In cgi-bin/koha/reports/catalogue_out.pl report, select in library filter the user logged-in. Test plan : - Log into intranet with a normal user - Got to "Items with no checkouts" reports => Your branch is selected - Run report => You see "Filtered on : Branch = " - Come back to report - Select "Any library" - Run report => You do not see "Filtered on : Branch" Bug 10718 - items with no checkouts report permission is execute_reports This report only executes SQL to change reports/catalogue_out.pl permissions from all reports subpermissions to reports/execute_reports. Test plan : Test you can access and run this report with only execute_reports subpermission into reports permission. Bug 10718 - redefine limit input In reports/catalogue_out.pl form, the limit input is by defaut none. So by default the report queries all the catalogue. This may take a very long time (fall into timeout) and since now the results are displayed in page, the page may be huge. This patch modifies limit input to removes the "none" option. Also reduces the number of options (same options as guided reports results per page). Test plan: - Go to reports/catalogue_out.pl => first value "10" is selected - Launch report => You see "Filtered on: limit = 10" Bug 10718 - perltidy on reports/catalogue_out.pl Signed-off-by: Liz Rea Tested all of these things, all ok - squashed patch for neatness. Signed-off-by: Katrin Fischer Passes all tests and QA script. Fixed a tab in one of the comments. Improves script, but more work needed. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 20:50:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 18:50:40 +0000 Subject: [Koha-bugs] [Bug 7478] Template/translation problem in catalogue_out.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 20:50:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 18:50:42 +0000 Subject: [Koha-bugs] [Bug 7478] Template/translation problem in catalogue_out.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20238|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 20601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20601&action=edit [SIGNED OFF] Bug 7478 - Template/translation problem in catalogue_out.tt The items with no checkouts template has a sections that uses DEFAULT to set some strings: [% DEFAULT loopro.itemcallnumber="No Call Number" %] This appears to be untranslatable with our current translation tool. This patch changes the template so that it uses a simple [% IF %] block to display the default text if no value is set. Added is use of the Branches template plugin to show library name instead of code. This patch also fixes an error introduced in my fix for Bug 8124 causing the page to default to CSV download instead of output to screen. To test, apply the patch and confirm that the default text appears onscreen in reports which include results that have a missing barcode, title, or call number. Results should be displayed on screen correctly. Run "perl translate update" for any language and confirm that the newly generated po file includes "No call number," "No barcode," and "NO TITLE" for catalogue_out.tt Signed-off-by: Katrin Fischer Works nicely, thx Owen! Applied on top of 10718 for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 21:04:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 19:04:51 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 21:04:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 19:04:54 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20103|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 20602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20602&action=edit [PASSED QA] Bug 10588 - opac-topissues first branch always selected in filters In OPAC most popular items page: With user is logged-in his branch should be selected. When a branch is manually selected and form is submitted, this branch should be selected in results page. When looking at HTML, you see that all options are selected in combobox. This patch corrects by using the hidden input 'do_it' to distinguish form display and no branch filter selected. Test plan : - Make sure there are issues on records created in the past 3 month - Go to OPAC not logged-in - Click on "Most popular" => You get to page with results, "All libraries" is selected - Select a branch and submit => You get to page with results, the branch is selected [testing opac-topissues.inc from] - Select a branch and perform a search that does not have results (for example an item type never issued) => You get to page without results, the branch is selected [testing opac-topissues.tt form] - Log-in with a user - Click on "Most popular" => You get to page with results, user's branch is selected - Select "All libraries" and submit => You get to page with results, "All libraries" is selected [testing opac-topissues.inc from] - Select "All libraries" and perform a search that does not have results (for example an item type never issued) => You get to page without results, "All libraries" is selected [testing opac-topissues.tt form] Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Works nicely and passes all tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 21:06:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 19:06:25 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- I like this version a lot better, thx Fridolyn. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 21:22:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 19:22:26 +0000 Subject: [Koha-bugs] [Bug 9943] Pay fines page "Pay selected" button give invalid amount when nothing is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9943 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 21:22:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 19:22:29 +0000 Subject: [Koha-bugs] [Bug 9943] Pay fines page "Pay selected" button give invalid amount when nothing is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9943 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20429|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 20603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20603&action=edit [PASSED QA] Bug 9943 - Pay fines page "Pay selected" button give invalid amount when nothing is selected If you select no fines but click the "pay selected" button the resulting screen offers to let you pay against all fines, which is confusing. To simplify things this patch disables the "pay selected" button if no lines are selected. To test, apply the patch and find a patron with outstanding fines. From the "pay fines" page (members/pay.pl) try selecting and deselecting checkboxes and using the "select all" and "clear all" links. When no item is selected the "Pay selected" button should become disabled. Confirm that the form submits correctly when one or more fines is selected. Signed-off-by: Melia Meggs Signed-off-by: Katrin Fischer Passes all tests and QA script. Works nicely in my tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 21:25:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 19:25:08 +0000 Subject: [Koha-bugs] [Bug 10572] Add phone to message_transport_types table for new installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 --- Comment #7 from Katrin Fischer --- Kyle, could you address comment 3 please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 21:35:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 19:35:24 +0000 Subject: [Koha-bugs] [Bug 10349] Don't show empty Descriptions/Title notes tabs in OPAC and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19967|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20604&action=edit [PASSED QA] Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff The descriptions/title notes tab appears on the detail page in both staff client and OPAC even if there are no notes. This is probably a relic of the pre-T:T days when it wasn't possible to use || in an IF. This patch adds a check for the various variables which might trigger the display of the tab. To test, apply the patch and view records in the OPAC and staff client which do and do not have title notes attached (whether that be in the MARC reocrd or in the biblio.notes column). In the OPAC Syndetics content should also be tested if possible. The descriptions/title notes tab should only appear if there is content. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer That's better - thx Owen! Works nicely and passes all tests. Tested in staff and OPAC, also in combination with NotesBlacklist hiding all notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 21:35:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 19:35:22 +0000 Subject: [Koha-bugs] [Bug 10349] Don't show empty Descriptions/Title notes tabs in OPAC and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 21:36:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 19:36:00 +0000 Subject: [Koha-bugs] [Bug 10719] UT GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10719 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 21:40:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 19:40:50 +0000 Subject: [Koha-bugs] [Bug 10719] UT GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10719 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 21:40:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 19:40:52 +0000 Subject: [Koha-bugs] [Bug 10719] UT GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10719 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20421|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20605&action=edit [PASSED QA] Bug 10719 - UT GetUpcomingDueIssues Some unit tests related to Bug 9362. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart http://bugs.koha-community.org/show_bug.cgi?id=10606 Signed-off-by: Katrin Fischer New and old tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 21:51:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 19:51:41 +0000 Subject: [Koha-bugs] [Bug 10566] Improve OPAC course reserves pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 21:51:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 19:51:44 +0000 Subject: [Koha-bugs] [Bug 10566] Improve OPAC course reserves pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19689|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20606&action=edit [PASSED QA] Bug 10566 - Improve OPAC course reserves pages This patch makes various improvements to the OPAC course reserve pages: - Descriptive page titles for both pages. - More compact display of course information on course detail page (a list instead of a table, consistent with other displays of similar information in Koha). - Correct capitalization. - Added label and fieldset to course reserve search form. - Added breadcrumb navigatio nto course reserve detail page as a path back to course reserves main page. To test, apply the patch and confirm that the changes haven't broken anything and are an improvement. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests and improves the display. Tested with only 1 course, 2 courses, courses with and without items selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 21:55:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 19:55:03 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Hi Owen, there is a small conflict in basketgroup.tt, but I am not sure how to solve it - could you rebase and switch back to signed off please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 21:55:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 19:55:13 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 22:09:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 20:09:01 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- Hi Kyle - view_holdsqueue.tt is still using 'USE KohaAuthorisedValues' - circulation.tt is still using 'USE KohaBranchName' after applying your patches. Could you add 2 follow ups please? Maybe we should also add a test to the QA script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 22:40:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 20:40:07 +0000 Subject: [Koha-bugs] [Bug 9782] Cancel button doesn't work when importing MARC bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 22:40:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 20:40:11 +0000 Subject: [Koha-bugs] [Bug 9782] Cancel button doesn't work when importing MARC bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20522|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20607&action=edit [PASSED QA] Bug 9782 - Cancel button doesn't work when importing MARC bibliographic frameworks When importing frameworks the "cancel" button should be hidden once an import is initiated since it is not possible to cancel the import in progress. This patch uses this bug as an excuse to replace the old import/export pop-ups with modal dialogs for all import/export functions. To test: - Try exporting both the default framework and at least one other framework. - Try importing both a default framework and at least one other framework. - When importing, observe that the modal dialog controls are hidden as soon as the import is initiated. Signed-off-by: David Cook Signed-off-by: Katrin Fischer Works nicely, passes all tests and QA script. Also the modal works better on smaller screens. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 22:46:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 20:46:46 +0000 Subject: [Koha-bugs] [Bug 10690] Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10690 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 22:46:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 20:46:48 +0000 Subject: [Koha-bugs] [Bug 10690] Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10690 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20190|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20608&action=edit [PASSED QA] Bug 10690 - Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL The descriptions for OPACBaseURL and staffClientBaseURL are not explicit about including a trailing slash or not. This patch makes it explicit that the trailing slash should *not* be included. To test: - Apply the patch - Search for "baseurl" in the system preferences - Check that the description of both sysprefs includes a warning about not including a trailing slash. - Sign off If you want to check that the trailing slash is in fact superfluous you can do something like 'grep -r "BaseURL" *' and check that these sysprefs are usually concatenated with some string that starts with a slash. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer Changes to the description appear correctly on both system preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 23:04:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 21:04:35 +0000 Subject: [Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Tomas, I applied your patch but the change doesn't show up in the man page - I know I am missing something. Do you have some hints for me? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 23:11:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 21:11:26 +0000 Subject: [Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 23:11:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 21:11:28 +0000 Subject: [Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20529|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 20609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20609&action=edit [PASSED QA] Bug 10742 - simple search to z39.50 search keeps index In intranet, when search does not return results, there is a button to perform the same search on Z39.50 servers. This works well when coming from advanced search. But when using simple search from header, in the Z39.50 search box "kw,wrdl" is added to the operand in title. This patch simply adds kw as default value when the cgi does not have idx parameter. Test plan : - In intranet, perform a search from header that does not return any result. For example "afalseword" - Click on "Z39.50 Search" => you get a popup with the searched word in title. For example : Title: afalseword - Go to advanced search page - Enter the same word into first input and submit - Click on "Z39.50 Search" => you get a popup with the searched word in title. Signed-off-by: David Cook Signed-off-by: Katrin Fischer Small change, fixes an annoying problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 23:12:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 21:12:26 +0000 Subject: [Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645 --- Comment #4 from Tom?s Cohen Arazi --- (In reply to Katrin Fischer from comment #3) > Hi Tomas, > I applied your patch but the change doesn't show up in the man page - I know > I am missing something. Do you have some hints for me? Katrin, on bug 10622 Magnus posts a command to recreate man page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 23:25:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 21:25:08 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 23:25:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 21:25:10 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20422|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 20610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20610&action=edit [PASSED QA] Bug 10606: Remove MySQLism in GetUpcomingDueIssues To test: [1] Arrange to have at least one loan in your test database due one day from now. [2] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 and note the number of loans reported. [3] Apply the patch. [4] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 again and verify that the number of loans reported remains the same. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer All tests and QA script pass. Also tested with unit tests from bug 10719. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 23:30:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 21:30:31 +0000 Subject: [Koha-bugs] [Bug 10780] New: Updatedatabase updates permission labels incorrectly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10780 Bug ID: 10780 Summary: Updatedatabase updates permission labels incorrectly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The stock descriptions of permissions are correct, but an updatedatabase stanza updates two of them to be identical when they shouldn't be. Patch incoming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 23:52:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 21:52:55 +0000 Subject: [Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 25 23:52:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 21:52:58 +0000 Subject: [Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20066|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 20611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20611&action=edit [PASSED QA] Bug 10645: Missing zebra languages in koha-create manpage There where some missing zebra language options in the man page for koha-create. Trivial string change. To+ Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Tested using the following commands: $ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-list.xml $ man -l koha-list.8 Also: prove -v xt/verify-debian-docbook.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 00:05:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 22:05:36 +0000 Subject: [Koha-bugs] [Bug 10668] Improve suggestion detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 00:05:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 22:05:39 +0000 Subject: [Koha-bugs] [Bug 10668] Improve suggestion detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20072|0 |1 is obsolete| | Attachment #20102|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 20612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20612&action=edit [PASSED QA] Bug 10668 - Improve suggestion detail page This patch makes several improvements to the suggestions template: - Improved breadcrumbs and page title. - Fixed a JavaScript error which appeared when viewing or editing a suggestion. - Added an 'Edit' and a 'Delete' button to the suggestion detail page. - Corrected capitalization. To test: - Perform various operations with suggestions management and confirm that page titles and breadcrumbs are correct. - View the detail page for an individual suggestion and confirm that the edit and delete buttons work correctly. - Confirm that there are no JavaScript errors when viewing or editing a suggestion, in particular when changing Acquisition information (quantity, currency, price). Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests, nice improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 00:05:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 22:05:49 +0000 Subject: [Koha-bugs] [Bug 10668] Improve suggestion detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 --- Comment #7 from Katrin Fischer --- Created attachment 20613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20613&action=edit [PASSED QA] Bug 10668 - Improve suggestion detail page - QA Followup Signed-off-by: Srdjan Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 00:28:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 22:28:32 +0000 Subject: [Koha-bugs] [Bug 10682] Inappropriate uses of finish() in C4::Reserve.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20108|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 20614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20614&action=edit Bug 10682 : Inappropriate uses of finish() in C4::Reserves This patch gets rid of finish. >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Similar to other patches from the same author I run prove t/db_dependent/Reserves.t without errors don't know if more tests are needed. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 00:29:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 22:29:02 +0000 Subject: [Koha-bugs] [Bug 10682] Inappropriate uses of finish() in C4::Reserve.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 00:34:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 22:34:28 +0000 Subject: [Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20110|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 20615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20615&action=edit Bug 10685: Inappropriate uses of finish in C4::Accounts.pm This patch gets rid of finish. >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Similar to other patches from the same author. Run prove t/db_dependent/Accounts.t without errors No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 00:35:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 22:35:37 +0000 Subject: [Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 00:44:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 22:44:27 +0000 Subject: [Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20160|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 20616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20616&action=edit Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value This patch adds return values to DeleteTransfer: Undef if no parameters are given 1 if a Transfer is deleted 0E0 if a wrong parameter is given It also fixes some unit tests in t/db_dependent/Circulation_transfers.t To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=14, 20 wallclock secs ( 0.03 usr 0.00 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Comment: Applied 10681 and 10692 before 10698 Run prove t/db_dependent/Circulation_transfers.t without errors No koha-qa errors on all 3 patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 00:45:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 22:45:09 +0000 Subject: [Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 01:01:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 23:01:43 +0000 Subject: [Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20269|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 20617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20617&action=edit Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result To test : prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.24 cusr 0.02 csys = 0.29 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Comment: applied 10681 and 10710 before 10711 prove t/db_dependent/Circulation_OfflineOperation.t run without errors koha-qa reports only 2 tabulations, fixed in a follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 01:04:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 23:04:28 +0000 Subject: [Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 01:03:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 23:03:55 +0000 Subject: [Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 20618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20618&action=edit Bug 10711: (follow-up) removing tabs Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 01:11:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 23:11:17 +0000 Subject: [Koha-bugs] [Bug 10767] UT: Routines which interact with the table issuingrules in C4/Circulation need unit test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10767 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20496|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 20619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20619&action=edit Bug 10767: UT:Routines which interact with the table issuingrules in C4/Circulation need unit tests The test are wrap in a transaction. NOTE: Some tests (in comment) don't pass, the routines have to be fixed To test: prove t/db_dependent/Circulation_Issuingrule.t t/db_dependent/Circulation_Issuingrule.t .. ok All tests successful. Files=1, Tests=9, 17 wallclock secs ( 0.02 usr 0.00 sys + 0.34 cusr 0.04 csys = 0.40 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Comment: No koha-qa errors prove t/db_dependent/Circulation_Issuingrule.t run without errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 01:11:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Aug 2013 23:11:36 +0000 Subject: [Koha-bugs] [Bug 10767] UT: Routines which interact with the table issuingrules in C4/Circulation need unit test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10767 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 02:09:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 00:09:23 +0000 Subject: [Koha-bugs] [Bug 10781] New: Remove C4::ILSDI::Utility Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 Bug ID: 10781 Summary: Remove C4::ILSDI::Utility Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: srdjan at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org C4::ILSDI::Utility is not really required. It contains only two routines: * BorrowerExists() which is not used * Availability(), used only in C4::ILSDI::Services I propose we move Availability() to C4::ILSDI::Services and remove C4::ILSDI::Utility -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 02:23:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 00:23:15 +0000 Subject: [Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 --- Comment #1 from Srdjan Jankovic --- Created attachment 20620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20620&action=edit bug_10781: Removed ILSDI::Utility Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describe&verb=GetAvailability AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron ILS-DI syspref must be turned on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 02:23:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 00:23:38 +0000 Subject: [Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 03:35:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 01:35:59 +0000 Subject: [Koha-bugs] [Bug 2500] Standing enhancement request for adding/updating call number splitting algorithms in C4/Labels.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2500 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #18 from David Cook --- So I've recently encountered a call number like this: 361.250994 REP NO. 11/10 The section "361.250994" is DDC, I believe. However, "REP NO. 11/10" is entirely local. When printing labels and splitting call numbers, the slash between 11 and 10 gets removed using _split_ddcn. This isn't desirable, so I opted to use a different splitting sub. However, if I use _split_ccn, "REP NO. 11/10" gets turns into "REP NO. 11 /10", which is also undesirable, as that means "11" gets printed on one line and "/10" gets printed on the next. This is due to some regexp found in _split_ccn, which pulls apart the last element in the @parts array. Is there are a reason why the last element in the array is being pulled apart like this? I used git blame but the original 2009 commit message from Chris Nighswonger didn't really tell me much. I'm sure there is a reason, but it might make more sense for this - or another - sub to just split on spaces. -- Another thought...currently there is no way to associate splitting subs with call number classification schemes. The only way I see is to hardcode it into Label.pm. Perhaps it would be an idea to specify the call number splitting rule in the "Classification sources" part of the Administration module. This could be useful in several contexts. For instance, we're currently using the _split_lccn sub for LCC and NLM, but it could also be useful for the KF Modified classification scheme (which is a legal scheme based on LCC) and other schemes. KDC (Korean Decimal Classification) would also probably use DDC. Admittedly, since the behaviours are likely the same, people using KF Modified or KDC should probably just use "LCC" or "DDC" as classification sources rather than making new ones, so perhaps I don't actually have a good point there :p. However...there might be times when a library wants to use the DDC filing rules but have call number splitting just on spaces. Like in the above case where they want to preserve those local slashes. I don't know. Just a thought. I've already set up "z" to use _split_ccn in the past. I might adjust it so that it uses a different sub which just split on spaces... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 07:22:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 05:22:58 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Hi Kenza, I think this would be a bit better as 2 patches - one for the changes Booksellers.pm and one for the tests, so you can compare the results of the tests before and after the change. Could you split the patch up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 07:23:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 05:23:23 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer --- Failed QA always gets a bit more attention :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 08:45:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 06:45:42 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #70 from Katrin Fischer --- Patches no longer apply, I fixed the conflict in sysprefs.sql in the first patch, but got stuck on opac.tt in the third. Can you please rebase? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 08:48:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 06:48:21 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #52 from Srdjan Jankovic --- Created attachment 20621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20621&action=edit bug_9611: Extracted checkpw_internal() and checkpw_hash() from checkpw() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 08:48:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 06:48:32 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #53 from Srdjan Jankovic --- Created attachment 20622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20622&action=edit bug_9611: removed md5_base64 from imports - not used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 08:48:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 06:48:43 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #54 from Srdjan Jankovic --- Created attachment 20623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20623&action=edit bug_9611: use checkpw_hash() instead of md5 hash Test: * SIP: Have an old user and create a new user - use either tenet sip test or C4/SIP/interactive_patron_check_password.pl to check old userid/password - do the same for the new user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 08:50:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 06:50:42 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 08:50:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 06:50:45 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #55 from Srdjan Jankovic --- Created attachment 20624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20624&action=edit bug_9611: use hash_password() and checkpw_* instead of md5 hash Test: * LDAP: - Turn on LDAP auth in koha-config.xml. Sset "update" in your server config to 1 - Change user's password on LDAP - Login to Koha using LDAP - Koha password should be updated, to check - Turn off LDAP auth in koha-config.xml - You should be ble to log in with the new password I do not have a LDAP facility, so I cheated. I ran perl -e 'use C4::Auth_with_ldap; C4::Auth_with_ldap::_do_changepassword("srdjan", 1000022259, "srdjan");' and was able to change the password. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 08:52:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 06:52:30 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #56 from Srdjan Jankovic --- See also http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 09:29:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 07:29:36 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > Hi Kenza, > > I think this would be a bit better as 2 patches - one for the changes > Booksellers.pm and one for the tests, so you can compare the results of the > tests before and after the change. Could you split the patch up? Katrin, Kenza already adds a report for testing this routine (bug 10528). In this patch, a lot of lines are uncommented in order to remove previous FIXME. I am not sure to understand the goal of your request. However I think this patch needs a better test plan: the feature should be tested in the interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 09:31:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 07:31:25 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Katrin Fischer --- Jonathan, I think you are right - no tired QAing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 09:41:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 07:41:09 +0000 Subject: [Koha-bugs] [Bug 10782] New: Add a koha-mysqlcheck script Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10782 Bug ID: 10782 Summary: Add a koha-mysqlcheck script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org I'm creating this for myself anyway, so I thought I'd see if there is any interest in getting it into Koha... The idea is to add a script similar to koha-mysql, but instead of running the "mysql" command, it would run the "mysqlcheck" command: http://dev.mysql.com/doc/refman/5.0/en/mysqlcheck.html This will make it very easy to check the database of a given instance for errors. There will be command line options for what kind of checks to perform (quick, fast, changed, medium, extended) and verbosity (silent, verbose). If this sounds like a stupid idea, please feel free to mark this bug as "RESOLVED WONTFIX" or similar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 10:06:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 08:06:46 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #9 from Jonathan Druart --- (In reply to Owen Leonard from comment #8) > I still get a JavaScript error on the circulation page. Perhaps this is the > cause? > > TypeError: a.aoColumns[c] is undefined > /intranet-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.min.js > Line 29 I will submit a new rebased patch. I missed a column for the holds table. > In my informal tests it didn't seem to slow down loading of the circulation > page compared to master. I'd like to make the "show/hide columns" box less > obtrusive, but I don't have any suggestions for how to do that at the moment. Why do you think it is obtrusive? It is a small box on the top right. Maybe we can imagine (another) syspref for turning off this feature. > Is the yml file translatable? Why do you want to translate it? In fact the yaml file will be only used by Koha developers. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 10:08:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 08:08:59 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18861|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 20625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20625&action=edit Bug 10212: Columns configuration for tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 10:09:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 08:09:07 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 10:12:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 08:12:15 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 10:12:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 08:12:17 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #38 from kenza --- Created attachment 20626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20626&action=edit C4::Branch.pm needs unit tests Unit tests are wrap in a transaction. To test: prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207. t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=36, 1 wallclock secs ( 0.02 usr 0.02 sys + 0.13 cusr 0.01 csys = 0.18 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10508 Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 12:19:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 10:19:30 +0000 Subject: [Koha-bugs] [Bug 10783] New: LDAP integration in koha Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10783 Bug ID: 10783 Summary: LDAP integration in koha Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: kalpesh.prajapati at fountainheadschools.org QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org I want to do LDAP integration in koha. So please help me for the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 14:34:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 12:34:19 +0000 Subject: [Koha-bugs] [Bug 7716] Statistical/analytic item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I am thinking this would be really useful for ILL. Libraries here receive copies of articles that the user can keep, but you still want to record it in the system, noting that the ILL request has been filled and filling the ILL hold request on the item. A statistical itemtype would serve this purpose well. MJ, is there any code for this I could take a look at? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 14:39:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 12:39:56 +0000 Subject: [Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20519|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 20627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20627&action=edit [SIGNED-OFF] Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE Currently, the layout for the Edit/Add Layout screen of the Patron Card Creator is in complete disarray, when viewed in Internet Explorer (of any version). The nav bar is pushed to the bottom of the page, every fieldset is empty (as their contents have been pushed out into different parts of the page), and the checkboxes don't work. The cause appears to be some extraneous mark-up (a few extra fieldset and li elements)and some missing mark-up (ol elements to wrap the list elements, especially when nesting lists within each other and within div elements). Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 15:04:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 13:04:51 +0000 Subject: [Koha-bugs] [Bug 9614] Fines not assessed after renewing an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9614 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #2 from Kyle M Hall --- Currently testing. Here's one problematic situation. If RenewalPeriodBase is set to the "the old due date off the checkout" and the item is still overdue after renewing, Koha will close the current fine from "FU" to "F" and generate a new fine! The fine will be somewhat smaller ( since the due date has been pushed forward by X days ), but the fines still overlap and are essentially duplicate fines! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 15:14:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 13:14:57 +0000 Subject: [Koha-bugs] [Bug 9614] Fines not assessed after renewing an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9614 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.10 --- Comment #3 from Kyle M Hall --- I cannot reproduce this issue on master, nor can I reproduce on 3.10.05 which is the version the reporter is running. I'm guessing my system settings are set the same as the reporters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 16:26:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 14:26:52 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #4 from Nicole C. Engard --- This says it's assigned - is someone actually working on this? Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 16:29:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 14:29:46 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #13 from Jonathan Druart --- (In reply to Kyle M Hall from comment #12) > Created attachment 20058 [details] [review] > Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace > by CAST(now() AS date). Kyle, you forgot to add the Signed-off-by line to the second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 16:38:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 14:38:06 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- Kyle, the patch does not apply anymore against master: fatal: sha1 information is lacking or useless (C4/SIP/ILS/Patron.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Maybe it is caused by the sysprefs.sql file. Could you try to rebase it please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 16:39:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 14:39:05 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #7 from Jonathan Druart --- Oops, I missed the dependency! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 16:40:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 14:40:52 +0000 Subject: [Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 16:53:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 14:53:16 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 --- Comment #8 from Jonathan Druart --- Since this patch is easy to test, maybe it would be better to change the dependency. Making bug 10445 depends on this one will allow to pass qa it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 16:54:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 14:54:56 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 --- Comment #11 from kenza --- Created attachment 20628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20628&action=edit Bug 10641 - GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences This patch fixes some incoherences of the routine GetBooksellerWithOrders. Now it considers the field $estimateddeliverydateto and it replaces it by now() only if it is undef. More it doesn't test if $aqbookseller.deliverytime is not Null anymore but if $deliverytime = null or undef, it replaces it by 0. It also verifies if $delay is >= 0 and return undef if it is a negative value. To Test: Before, this routine sorts out the BookSellerWithLateOrders. If a Bookseller did not specify a deliverytime, he would never appears in the list of LateOrders.More if the field "Estimated delivery date to" was specified, it didn't take care of the value and it returns the late order up to today's date. Now, the returned list considers all the fields give and if the deliverytime of the Bookseller is not specified, it calculates the late orders as if the deliverytime is 0.By default , all booksellers which have orders in late until today are listed unless "estimated delivery date to" is specified. prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. [Some warnings about uninitialized values] WARNING: GetBooksellerWithLateOrders is called with a negative value at C4/Bookseller.pm line 135. t/db_dependent/Bookseller.t .. ok All tests successful. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 16:57:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 14:57:23 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20628|1 |0 is patch| | Attachment #20628|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 16:58:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 14:58:18 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19984|0 |1 is obsolete| | --- Comment #12 from kenza --- Created attachment 20629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20629&action=edit Bug 10641 - GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences This patch fixes some incoherences of the routine GetBooksellerWithOrders. Now it considers the field $estimateddeliverydateto and it replaces it by now() only if it is undef. More it doesn't test if $aqbookseller.deliverytime is not Null anymore but if $deliverytime = null or undef, it replaces it by 0. It also verifies if $delay is >= 0 and return undef if it is a negative value. To Test: Before, this routine sorts out the BookSellerWithLateOrders. If a Bookseller did not specify a deliverytime, he would never appears in the list of LateOrders.More if the field "Estimated delivery date to" was specified, it didn't take care of the value and it returns the late order up to today's date. Now, the returned list considers all the fields give and if the deliverytime of the Bookseller is not specified, it calculates the late orders as if the deliverytime is 0.By default , all booksellers which have orders in late until today are listed unless "estimated delivery date to" is specified. prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. [Some warnings about uninitialized values] WARNING: GetBooksellerWithLateOrders is called with a negative value at C4/Bookseller.pm line 135. t/db_dependent/Bookseller.t .. ok All tests successful. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 17:08:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 15:08:23 +0000 Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #7 from Jonathan Druart --- QA comment: Same code from neworderempty.pl is used on parcels.pl but not easy to refactore. The JS code should certainly be simplified. But it works. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 17:08:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 15:08:40 +0000 Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20074|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 20630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20630&action=edit Bug 8821 - Receive shipment page should hide inactive funds like new order form This patch adapts the fund-handling code from neworderempty.pl in order to limit the display of funds by default to active ones, with the option to check a box to display all funds. This patch also adds "(inactive)" to the display of funds on this and the neworderempty.tt template because it seemed like that was useful information. To test, make sure you have both active and inactive funds. Start the process of receiving a shipment. The "fund" option in the receive shipment form should show only active funds. Checking the "show all" checkbox should allow you to choose from both active and inactive funds. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 17:10:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 15:10:15 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #10 from Galen Charlton --- The bug 10719 tests do not passed when using MariaDB: # Failed test 'Bug 9362: Only one item due in more than 2 days (3 days in advance)' # at t/db_dependent/Circulation.t line 321. # got: '0' # expected: '1' not ok 35 - Bug 9362: Only one item due in more than 2 days (4 days in advance) # Failed test 'Bug 9362: Only one item due in more than 2 days (4 days in advance)' # at t/db_dependent/Circulation.t line 321. # got: '0' # expected: '1' not ok 36 - Bug 9362: Only one item due in more than 2 days (5 days in advance) # Failed test 'Bug 9362: Only one item due in more than 2 days (5 days in advance)' # at t/db_dependent/Circulation.t line 321. # got: '0' # expected: '1' # Looks like you failed 3 tests of 36. The DATE() function returns a date, but it looks like DATEDIFF(DATE( date_due ),DATE( NOW() )) works but " DATE( date_due )-DATE( NOW() )" does not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 17:11:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 15:11:16 +0000 Subject: [Koha-bugs] [Bug 10719] UT GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10719 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master, along with a follow-up to clear the slate first. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 17:14:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 15:14:48 +0000 Subject: [Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 17:16:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 15:16:19 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 17:16:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 15:16:22 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19972|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 20631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20631&action=edit [SIGNED-OFF] Bug 10649 - Upgrade DataTables and move scripts out of theme directory This patch adds an upgraded copy of the DataTables plugin to the jQuery plugin directory outside the theme directories. Copies of the old DataTables plugin scripts have been left in the old location while templates are incrementally updated. To test, visit each affected page in Acquisitions and confirm that table sorting still words correctly: - Acquisitions home - Acquisitions -> Late orders - Acquisitions -> Order search - Acquisitions -> Ordered (from table of available funds) - Acquisitions -> Spent (from table of available funds) - Acquisitions -> Vendor search - Acquisitions -> Vendor detail - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Basket -> Add order from existing record -> Add order from suggestion -> Add order from subscription -> Add order from external source -> Add order from staged file - Acquisitions -> Vendor -> Basket groups - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Vendor -> Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Acquisitions -> Vendor -> Receive shipments - Acquisitions -> Vendor -> Receive shipments -> Receipt summary (click invoice number) Also test one or more pages which have not been modified to confirm that old DataTables assets are still in place and working (ex: Circulation, Quotes editor, Saved reports, etc.) Signed-off-by: Srdjan Edit: Rebased on current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 17:21:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 15:21:08 +0000 Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- QA comment: 3 small things: - FAIL misc/cronjobs/delete_deleted_records.pl FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 78) see http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence - There are some bad indentations: 8 spaces instead of 4 - Maybe it would be great to list the deleted biblios even if the confirm flag is not set. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 17:39:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 15:39:05 +0000 Subject: [Koha-bugs] [Bug 10684] Koha search dies on undecodable records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #5 from Jonathan Druart --- QA comment: No way to reproduce but catching possible error on this method is not a bad idea. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 17:40:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 15:40:06 +0000 Subject: [Koha-bugs] [Bug 10684] Koha search dies on undecodable records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20200|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 20632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20632&action=edit Bug 10684 - Koha search dies on undecodable records When a record fails to decode during a search, Koha dies with an error. Koha should ignore bad records and continue on ( and log the error ). Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 17:40:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 15:40:10 +0000 Subject: [Koha-bugs] [Bug 10684] Koha search dies on undecodable records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 --- Comment #7 from Jonathan Druart --- Created attachment 20633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20633&action=edit Bug 10684 - Followup Koha search dies on undecodable records Prevent future error. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 18:30:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 16:30:58 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Galen Charlton --- Pushed to master. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 18:36:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 16:36:59 +0000 Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 18:37:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 16:37:01 +0000 Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20564|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 20634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20634&action=edit Bug 10737 [Revised] Add "Add to basket" link on vendor search results page This patch adds an "add to basket" link to the vendor search results page for each open basket associated with each vendor. Clicking it triggers a modal window with the "add to basket" choices for that vendor and basket. Other changes in this patch: - The add-to-basket include has been modified in order to make it more useful in this context. - booksellers.pl has been modified to check for an existing budget so that the add-to-basket include can properly display a warning if there are none. - "New basket" and "Receive shipment" buttons associated with each vendor search result have been converted to Bootstrap-styled buttons. - Basket closed date has been moved into its own column so that the table can be sorted by that value. - Table columns containing dates now use the "title-string" sort option, eliminating the need for a special date sorting algorithm. - Converted some &'s to &'s To test, apply the patch and search for a vendor. For each vendor in your search results baskets which are open should include an "add to basket" link. Clicking it should open a modal dialog with the same "add to basket" options offered on the basket page. The correct vendor ID and basket number should be associated with each link. The newly-styled "new basket" and "receive shipment" buttons should work correctly. Table sorting should work correctly, including the new "closed" column. Since the add-to-basket include file was modified, the "add to basket" button on the basket view page should also be tested (acqui/basket.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 19:05:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 17:05:41 +0000 Subject: [Koha-bugs] [Bug 10684] Koha search dies on undecodable records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20633|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 20635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20635&action=edit Bug 10684 - Followup Koha search dies on undecodable records Prevent future error. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 19:41:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 17:41:24 +0000 Subject: [Koha-bugs] [Bug 10784] New: SMS-related code needs improvements Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10784 Bug ID: 10784 Summary: SMS-related code needs improvements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org Some more or less random findings: sms/sms_listen.pl has hardcoded strings in it, in Turkish (according to Google translate): http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=sms/sms_listen.pl;h=b36b25da46baa3e49b9c0ae77dbf40fa8f3715c8;hb=9c8a1e29f8f25890c341859eb943aff64f7f37ac#l58 This comment from an earlier commit sounds ominous: "SMS - widespread cleanup and moving code away from Cyprus/Turkey-specific implementation. Much more needed." http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=9c8a1e29f8f25890c341859eb943aff64f7f37ac To bring this in line with other functionality in Koha it would probably be a good idea to make the notices editable, in the same way that other notices are. C4::SMS references two sysprefs, SMSSendUsername and SMSSendPassword, but when I search for these in 3.12.x and current master I get no results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 19:46:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 17:46:47 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #5 from Eric B?gin --- We actually have this code running on our 3.10.x version. It's juste a matter of finding time to merge on the main branch... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 20:31:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 18:31:54 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #11 from Owen Leonard --- (In reply to Jonathan Druart from comment #9) > Why do you want to translate it? In fact the yaml file will be only used by > Koha developers. On the configuration page the tables are listed by their IDs: "holdst" and "issuest." These are not understandable labels if you're not familiar with the page structure. I was thinking it would be nice to be able to give these better labels, but they would have to be translatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 21:06:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 19:06:11 +0000 Subject: [Koha-bugs] [Bug 10785] New: dropbox should be book drop Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10785 Bug ID: 10785 Summary: dropbox should be book drop Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In the US everyone thinks of dropbox as the product where you save your files and the 'book drop' where people drop books off over night. I think we should change dropbox on the checkin to be book drop based on hearing this question in training 100 times :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 21:17:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 19:17:40 +0000 Subject: [Koha-bugs] [Bug 10531] Basket name and PO number on receipt screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 21:17:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 19:17:42 +0000 Subject: [Koha-bugs] [Bug 10531] Basket name and PO number on receipt screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20285|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 20636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20636&action=edit [SIGNED-OFF] Bug 10531 - Basket name and PO number on receipt screen To list the basket name or PO number on the receipt screen to identify the lot that you are receiving Test Plan: 1) Create an basket 2) Create an order 3) Click on Receive shipment button enter vendor invoice no and shipment date click on Next button. 4) Basket name and Purchase order number will display both in pending and already receive screen. Signed-off-by: Owen Leonard Two minor edits on signoff: Changed "basketname" to "basket name," and converted tabs to spaces on added lines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 21:54:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 19:54:50 +0000 Subject: [Koha-bugs] [Bug 10661] Mandatory item fields should be formatted the same on all forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10661 --- Comment #4 from Owen Leonard --- (In reply to Liz Rea from comment #3) > Looks like it works, but on my display, in serials, the width of the table > seems to bump the red "required" text to the next line The size of the fields is consistent across different pages, the form being generated by PrepareItemrecordDisplay in Items.pm. However, the size of those fields is pretty huge: the size attribute has them at 67. Other fields are just 50. I'm not sure why the difference? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 23:15:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 21:15:11 +0000 Subject: [Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 26 23:15:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 21:15:14 +0000 Subject: [Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20157|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20637&action=edit [SIGNED OFF] Bug 10681: Inappropriate uses of finish() in C4::Circulation.pm This patch gets rid of finish(). >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 00:30:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 22:30:44 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20029|0 |1 is obsolete| | Attachment #20626|0 |1 is obsolete| | --- Comment #39 from Chris Cormack --- Created attachment 20638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20638&action=edit Bug 10508: C4::Branch.pm needs unit tests Unit tests are wrap in a transaction. To test: prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207. t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=36, 1 wallclock secs ( 0.02 usr 0.02 sys + 0.13 cusr 0.01 csys = 0.18 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10508 Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 00:30:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Aug 2013 22:30:57 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #40 from Chris Cormack --- Created attachment 20639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20639&action=edit Bug 10508 : Follow up Fixing a typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 03:46:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 01:46:36 +0000 Subject: [Koha-bugs] [Bug 10768] Improve the interface related to itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10768 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 03:56:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 01:56:48 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #33 from Mason James --- hi Tomas, could you update the ticket with info about your testing of this bug Jared mentioned you found some problems? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 09:20:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 07:20:53 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #12 from Jonathan Druart --- Created attachment 20640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20640&action=edit Bug 10212: Make the table names translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 10:09:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 08:09:08 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 --- Comment #11 from Jonathan Druart --- (In reply to Galen Charlton from comment #10) > The DATE() function returns a date, but it looks like DATEDIFF(DATE( > date_due ),DATE( NOW() )) works but " DATE( date_due )-DATE( NOW() )" does > not. I confirm they pass with MySQL and they don't pass with MariaDB. Using MariaDB: MariaDB [koha]> select to_days("2013-08-21 23:59:00")-to_days(NOW()); +-----------------------------------------------+ | to_days("2013-08-21 23:59:00")-to_days(NOW()) | +-----------------------------------------------+ | -6 | +-----------------------------------------------+ MariaDB [koha]> select date("2013-08-21 23:59:00")-date(NOW()); +-----------------------------------------+ | date("2013-08-21 23:59:00")-date(NOW()) | +-----------------------------------------+ | -6 | +-----------------------------------------+ Really odd... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 10:57:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 08:57:45 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19993|0 |1 is obsolete| | --- Comment #71 from Fridolyn SOMERS --- Created attachment 20641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20641&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions Rebased master. syspref.sql is now a single insert with alphabetical ordered sysprefs. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 10:58:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 08:58:35 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19994|0 |1 is obsolete| | --- Comment #72 from Fridolyn SOMERS --- Created attachment 20642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20642&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 1 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 11:03:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 09:03:32 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19995|0 |1 is obsolete| | --- Comment #73 from Fridolyn SOMERS --- Created attachment 20643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20643&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 2 Rebased master. I minimized the changes not directly concerning this new feature (new lines, spaces ...). They make rebase more difficult. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 11:03:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 09:03:57 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19996|0 |1 is obsolete| | --- Comment #74 from Fridolyn SOMERS --- Created attachment 20644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20644&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 11:04:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 09:04:24 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19997|0 |1 is obsolete| | --- Comment #75 from Fridolyn SOMERS --- Created attachment 20645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20645&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 11:07:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 09:07:00 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 11:39:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 09:39:43 +0000 Subject: [Koha-bugs] [Bug 10531] Basket name and PO number on receipt screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- QA comment: 1/ This patch breaks sorts on the already received table. 2/ The sort on the basket name column does not work (on the Pending orders table). 3/ Prefer to list the fields you want for the aqbasket table: + SELECT aqorders.*, biblio.*, aqbasket.* + SELECT aqorders.*, biblio.*, aqbasket.purchase_order, aqbasket.basketname Marked as Failed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 11:42:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 09:42:52 +0000 Subject: [Koha-bugs] [Bug 10682] Inappropriate uses of finish() in C4::Reserve.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 11:42:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 09:42:56 +0000 Subject: [Koha-bugs] [Bug 10682] Inappropriate uses of finish() in C4::Reserve.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20614|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 20646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20646&action=edit Bug 10682 : Inappropriate uses of finish() in C4::Reserves This patch gets rid of finish. >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Similar to other patches from the same author I run prove t/db_dependent/Reserves.t without errors don't know if more tests are needed. No koha-qa errors Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 11:44:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 09:44:32 +0000 Subject: [Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 11:44:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 09:44:35 +0000 Subject: [Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20615|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 20647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20647&action=edit Bug 10685: Inappropriate uses of finish in C4::Accounts.pm This patch gets rid of finish. >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Similar to other patches from the same author. Run prove t/db_dependent/Accounts.t without errors No koha-qa errors Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 11:49:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 09:49:47 +0000 Subject: [Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 11:49:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 09:49:50 +0000 Subject: [Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20616|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 20648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20648&action=edit Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value This patch adds return values to DeleteTransfer: Undef if no parameters are given 1 if a Transfer is deleted 0E0 if a wrong parameter is given It also fixes some unit tests in t/db_dependent/Circulation_transfers.t To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=14, 20 wallclock secs ( 0.03 usr 0.00 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Comment: Applied 10681 and 10692 before 10698 Run prove t/db_dependent/Circulation_transfers.t without errors No koha-qa errors on all 3 patches Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 11:55:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 09:55:29 +0000 Subject: [Koha-bugs] [Bug 10531] Basket name and PO number on receipt screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 --- Comment #4 from Jonathan Druart --- In fact, there is a js error on this page: ReferenceError: YAHOO is not defined Already exists on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 11:55:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 09:55:38 +0000 Subject: [Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20617|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 20649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20649&action=edit Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result To test : prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.24 cusr 0.02 csys = 0.29 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Comment: applied 10681 and 10710 before 10711 prove t/db_dependent/Circulation_OfflineOperation.t run without errors koha-qa reports only 2 tabulations, fixed in a follow-up Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 11:56:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 09:56:13 +0000 Subject: [Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 11:56:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 09:56:17 +0000 Subject: [Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20618|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 20650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20650&action=edit Bug 10711: (follow-up) removing tabs Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 12:01:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 10:01:51 +0000 Subject: [Koha-bugs] [Bug 10767] UT: Routines which interact with the table issuingrules in C4/Circulation need unit test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10767 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 12:01:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 10:01:54 +0000 Subject: [Koha-bugs] [Bug 10767] UT: Routines which interact with the table issuingrules in C4/Circulation need unit test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10767 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20619|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 20651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20651&action=edit Bug 10767: UT:Routines which interact with the table issuingrules in C4/Circulation need unit tests The test are wrap in a transaction. NOTE: Some tests (in comment) don't pass, the routines have to be fixed To test: prove t/db_dependent/Circulation_Issuingrule.t t/db_dependent/Circulation_Issuingrule.t .. ok All tests successful. Files=1, Tests=9, 17 wallclock secs ( 0.02 usr 0.00 sys + 0.34 cusr 0.04 csys = 0.40 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Comment: No koha-qa errors prove t/db_dependent/Circulation_Issuingrule.t run without errors Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 12:03:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 10:03:11 +0000 Subject: [Koha-bugs] [Bug 10786] New: Javascript error on the parcel page: YAHOO is not defined Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10786 Bug ID: 10786 Summary: Javascript error on the parcel page: YAHOO is not defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 12:03:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 10:03:34 +0000 Subject: [Koha-bugs] [Bug 10786] Javascript error on the parcel page: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10522 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 12:03:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 10:03:34 +0000 Subject: [Koha-bugs] [Bug 10522] Javascript error on acquisition pages: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10786 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 12:03:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 10:03:44 +0000 Subject: [Koha-bugs] [Bug 10531] Basket name and PO number on receipt screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > In fact, there is a js error on this page: > ReferenceError: YAHOO is not defined > > Already exists on master. error caused by the following line: It could be removed (see bug 10786). But this patch adds another one: TypeError: a.aoColumns[c] is undefined which does not exist on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 12:08:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 10:08:03 +0000 Subject: [Koha-bugs] [Bug 10786] Javascript error on the parcel page: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 12:08:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 10:08:06 +0000 Subject: [Koha-bugs] [Bug 10786] Javascript error on the parcel page: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10786 --- Comment #1 from Jonathan Druart --- Created attachment 20652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20652&action=edit Bug 10786: Javascript error on the parcel page: YAHOO is not defined The include of the yui json file generates a js error: YAHOO is not defined. This file seems not to be in use (patches for bug 8382 remove the use). To test: - go on acqui/parcel.pl?invoiceid=XXX - verify the error occurs (with firebug) - apply this patch - refresh the page - verify this error does not appear anymore - Verify there is no regression on this page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 12:08:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 10:08:21 +0000 Subject: [Koha-bugs] [Bug 10786] Javascript error on the parcel page: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 12:42:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 10:42:52 +0000 Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 Nu?o L?pez Ans?tegui changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |nunyo at masmedios.com Assignee|oleonard at myacpl.org |nunyo at masmedios.com --- Comment #1 from Nu?o L?pez Ans?tegui --- Created attachment 20653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20653&action=edit Bug 8948: MARC21 field 787 doesn't display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 12:43:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 10:43:59 +0000 Subject: [Koha-bugs] [Bug 10787] New: Linked Data/RDF Omnibus Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 Bug ID: 10787 Summary: Linked Data/RDF Omnibus Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org This bug will be an omnibus for adding support for Linked Data/RDF to Koha. Actual work will be done on bugs linked to this bug. See http://wiki.koha-community.org/wiki/Linked_Data_RFC for some thoughts on what can/will be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 12:44:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 10:44:23 +0000 Subject: [Koha-bugs] [Bug 10787] Linked Data/RDF Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7236 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 12:44:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 10:44:23 +0000 Subject: [Koha-bugs] [Bug 7236] Add "Save as RDF" option to the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7236 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10787 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 12:58:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 10:58:38 +0000 Subject: [Koha-bugs] [Bug 10788] New: Add a Linked Data/RDF browser to the OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10788 Bug ID: 10788 Summary: Add a Linked Data/RDF browser to the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org Blocks: 10787 This bug aims to add a browsing interface to the OPAC, that will make it possible to browse bibliographic records that have been converted from MARC to RDF and stored in a triplestore external to Koha. It will also be possible to browse data from external sources that has been entered into the triplestore, as well as any relations and other data that has been created in the triplestore. The browsing will be highly configurable, with SPARQL queries and related templates stored in the triplestore. One goal is to hard code as little as possible of the functionality, at least in the beginning. Future bugs will address the need for an interface to add and edit queries and templates in the triplestore, import of data from other source, manual enhancement of the data in the triplestore etc. The present bug is a functional proof of concept that aims to demonstrate the usefulness and potential that comes from utilizing Linked Data in an ILS. Conversion from MARC to RDF is outside the scope of this bug, but is being worked on by Chris Cormack. Until that work is submitted, it will be possible to do the conversion with tools external to koha, such as: - https://github.com/digibib/marc2rdf - https://github.com/edchamberlain/COMET/tree/master/conversion The features added by this bug will of course be governed by a syspref that defaults to "off". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 12:58:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 10:58:38 +0000 Subject: [Koha-bugs] [Bug 10787] Linked Data/RDF Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10788 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 16:02:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 14:02:38 +0000 Subject: [Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15627|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 17:00:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 15:00:54 +0000 Subject: [Koha-bugs] [Bug 10789] New: Excessive and often incorrect use of finish in C4::Acquisitions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10789 Bug ID: 10789 Summary: Excessive and often incorrect use of finish in C4::Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org C4/Acquisitions.pm contains a lot of calls to finish. These seem to be copied as magic by someone who is unaware of the usage (please read the DBI doc for full details) In brief finish is only required to be called after a select statement where you have not read back the full result set. It should never be called after a non-select statement. In fact there are a couple of places in C4::Acquisitions.pm where its not called where it should be. In practice a call to finish in top level code is almost always always a bad sign. Lets clean these up -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 17:26:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 15:26:00 +0000 Subject: [Koha-bugs] [Bug 10789] Excessive and often incorrect use of finish in C4::Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10789 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 20654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20654&action=edit Proposed Patch Patch should not alter functionality. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 18:24:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 16:24:24 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 --- Comment #34 from Tom?s Cohen Arazi --- (In reply to Mason James from comment #33) > hi Tomas, > could you update the ticket with info about your testing of this bug > > Jared mentioned you found some problems? The sample data and test plan didn't match, there was a problem with 155$a vs. 150$a (the second proposed test) and some warnings that needed to be addressed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 18:45:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 16:45:07 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #32 from Kyle M Hall --- > 2/ Step 8: The message concats 2 messages: > > Restricted: Patron's account is restricted until 04/08/2013 with the > comment "im restricted im restricted2" View restrictions > > message 1 is "im restricted" and message 2 is "im restricted2" Hmm, I think I should add a newline between the messages, and use the TT filter that will convert them to
    tags. That should solve that. > 4/ There is no comment for suspension in the borrower_debarments table. The original functionality of suspensions did not have comments, so I did not add one to the suspension. Do you have a suggestion for the message? > 5/ Why don't you remove the debarred and debarredcomment field in the > borrowers table? The first few comments on this bug explain it. TL;DR: By keeping them, we have to modify less code ( so fewer chances for bugs ) and it also makes everything faster as we don't have to recalculate everything each time we check for debarments, only when we modify debarments. > I will provide a followup for unit tests Thanks for the followup! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 19:06:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 17:06:00 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19419|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall --- Created attachment 20655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20655&action=edit Bug 2720 - Overdues which debar automatically should undebar automatically when returned This patch adds a more extensible and flexible debarments system to Koha. The fields borrowers.debarred and borrowers.debarredcomment are retained for compatibility and speed. This system supports having debarments for multiple reasons. There are currently three types of debarments: OVERDUES - Generated by overdue_notices.pl if the notice should debar a patron SUSPENSION - A punative debarment generated on checkin via an issuing rule MANUAL - A debarment created manually by a librarian OVERDUE debarments are cleared automatically when all overdue items have been returned, if the new system preference AutoRemoveOverduesRestrictions is enabled. It is disabled by default to retain current default functionality. Whenever a borrowers debarments are modified, the system updates the borrowers debarment fields with the highest expiration from all the borrowers debarments, and concatenates the comments from the debarments together. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the borrower_debarments table has been created and populated with the pre-existing debarments 4) Run t/db_dependent/Borrower_Debarments.t 5) Manually debar a patron, with an expiration date 6) Verify the patron cannot be issued to 7) Add another manual debarment with a different expiration date 8) Verify the 'restricted' message lists the date farthest into the future 9) Add another manual debarment with no expiration date 10) Verify the borrower is now debarred indefinitely 11) Delete the indefinite debarment 12) Verify the debarment message lists an expiration date dagain 13) Enable the new system preference AutoRemoveOverduesRestrictions 14) Set an overdue notice to debar after 1 day of being overdue 15) Check out an item to a patron and backdate the due date to yesterday 16) Run overdue_notices.pl 17) Verify the OVERDUES debarment was created 18) Return the item 19) Verify the OVERDUES debarment was removed 20) Disable AutoRemoveOverduesRestrictions 21) Repeat steps 15 though 18, verify the OVERDUES debarment was *not* removed 22) Add issuing rules so that an overdue item causes a temporary debarment 23) Check out an item to a patron and backdate the due date by a year 24) Return the item 25) Verify the SUSPENSION debarment was added to the patron Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 19:06:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 17:06:10 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19421|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall --- Created attachment 20656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20656&action=edit Bug 2720 [FOLLOW-UP] Overdues which debar automatically should undebar automatically This follow-up to Bug 2720 makes some template changes which I think make the interface a little more consistent and streamlined. Instead of incorporating the manual entry form into the table it is broken out and follows standard form structure. This lets the table be hidden altogether if there are no existing restrictions. The manual entry form is hidden by default and shown when you click a link to add a manual restriction. These changes have been applied to both the include file used for circulation and patron detail and to the patron entry form template. To test, add and remove manual restrictions from the circulation page, the patron detail page, and the patron edit page. All operations should work correctly. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 19:06:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 17:06:18 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19755|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 20657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20657&action=edit Bug 2720: Unit tests improvements Create the patron. Use a transaction. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 19:06:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 17:06:30 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 19:06:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 17:06:32 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #36 from Kyle M Hall --- Created attachment 20658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20658&action=edit Bug 2720 - QA Followup 2 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 19:06:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 17:06:42 +0000 Subject: [Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED CC| |tomascohen at gmail.com Resolution|--- |DUPLICATE --- Comment #17 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 7937 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 19:06:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 17:06:42 +0000 Subject: [Koha-bugs] [Bug 7937] Silence warns in OPAC error log (koha-opac-error_log) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hblancoca at gmail.com --- Comment #18 from Tom?s Cohen Arazi --- *** Bug 9040 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 19:14:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 17:14:29 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #10 from Kyle M Hall --- Created attachment 20659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20659&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues - Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 19:14:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 17:14:38 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 19:14:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 17:14:40 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #11 from Kyle M Hall --- Created attachment 20660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20660&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches - Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 20:48:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 18:48:29 +0000 Subject: [Koha-bugs] [Bug 10790] New: adding/editing item types screen mis aligned if noItemTypeImages not showing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10790 Bug ID: 10790 Summary: adding/editing item types screen mis aligned if noItemTypeImages not showing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 20661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20661&action=edit add item type See attached. When you have noItemTypeImages set to "Don't show" everything goes wonky on the add item type screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 21:47:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 19:47:10 +0000 Subject: [Koha-bugs] [Bug 10787] Linked Data/RDF Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 21:55:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 19:55:40 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 21:55:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 19:55:43 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20629|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 20662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20662&action=edit [PASSED QA] Bug 10641 - GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences This patch fixes some incoherences of the routine GetBooksellerWithOrders. Now it considers the field $estimateddeliverydateto and it replaces it by now() only if it is undef. More it doesn't test if $aqbookseller.deliverytime is not Null anymore but if $deliverytime = null or undef, it replaces it by 0. It also verifies if $delay is >= 0 and return undef if it is a negative value. To Test: Before, this routine sorts out the BookSellerWithLateOrders. If a Bookseller did not specify a deliverytime, he would never appears in the list of LateOrders.More if the field "Estimated delivery date to" was specified, it didn't take care of the value and it returns the late order up to today's date. Now, the returned list considers all the fields give and if the deliverytime of the Bookseller is not specified, it calculates the late orders as if the deliverytime is 0.By default , all booksellers which have orders in late until today are listed unless "estimated delivery date to" is specified. prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. [Some warnings about uninitialized values] WARNING: GetBooksellerWithLateOrders is called with a negative value at C4/Bookseller.pm line 135. t/db_dependent/Bookseller.t .. ok All tests successful. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 21:58:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 19:58:28 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- Patch this depends on is currently 'failed qa' - using blocked to indicate that this can't be QA'd right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:10:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:10:31 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:10:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:10:35 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20638|0 |1 is obsolete| | Attachment #20639|0 |1 is obsolete| | --- Comment #41 from Katrin Fischer --- Created attachment 20663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20663&action=edit [PASSED QA] C4::Branch.pm needs unit tests Unit tests are wrap in a transaction. To test: prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207. t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=36, 1 wallclock secs ( 0.02 usr 0.02 sys + 0.13 cusr 0.01 csys = 0.18 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10508 Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:10:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:10:54 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #42 from Katrin Fischer --- Created attachment 20664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20664&action=edit [PASSED QA] Bug 10508 : Follow up Fixing a typo Signed-off-by: Katrin Fischer Thx for the follow-up Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:17:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:17:13 +0000 Subject: [Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Tomas, rebasing this would be rewriting it... could you do it please? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:27:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:27:01 +0000 Subject: [Koha-bugs] [Bug 9247] Add two more usage examples to the manpage for koha-mysql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9247 --- Comment #3 from Katrin Fischer --- Created attachment 20665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20665&action=edit [PASSED QA] Bug 9247 - Add two more usage examples to the manpage for koha-mysql It might not be immediately obvious that it is possible to send SQL queries "directly" to the koha-mysql command, or that files from mysqldump can be loaded with it. This patch adds these as "example usage" to the man page for koha-mysql. To test: Run these commands and look at the formatted man page: $?xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-mysql.xml $?man -l koha-mysql.8 Make sure this test passes: $?prove -v xt/verify-debian-docbook.t This patch also corrects a couple places where "Koha" was written as "koha". Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer Test plan, all tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:27:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:27:33 +0000 Subject: [Koha-bugs] [Bug 9247] Add two more usage examples to the manpage for koha-mysql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9247 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:27:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:27:34 +0000 Subject: [Koha-bugs] [Bug 9247] Add two more usage examples to the manpage for koha-mysql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9247 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:27:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:27:53 +0000 Subject: [Koha-bugs] [Bug 9247] Add two more usage examples to the manpage for koha-mysql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9247 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:30:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:30:23 +0000 Subject: [Koha-bugs] [Bug 10587] HTML errors on authority detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:41:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:41:41 +0000 Subject: [Koha-bugs] [Bug 10587] HTML errors on authority detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:41:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:41:44 +0000 Subject: [Koha-bugs] [Bug 10587] HTML errors on authority detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20336|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20666&action=edit [PASSED QA] Bug 10587: fix HTML errors on authority detail page in OPAC A validator check of the OPAC's authority detail returns a few minor errors. This patch corrects the errors. To test, apply the patch and run an OPAC authority detail page through an HTML validator. There should be no errors which are specific to the authorities detail template (as opposed to header and footer includes). Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer All tests and QA script pass. Also checked using the W3C validator and testing the authority detail page in the OPAC is still correctly displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:46:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:46:59 +0000 Subject: [Koha-bugs] [Bug 10791] New: cart image in prog & IE10 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10791 Bug ID: 10791 Summary: cart image in prog & IE10 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 20667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20667&action=edit cart1 It looks like in IE10, with compatibility mode off, the a cart image is superimposed behind the word cart. With the compatibility mode on, the image is gone, but the footer of the results page shows up half way up the results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:47:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:47:17 +0000 Subject: [Koha-bugs] [Bug 10791] cart image in prog & IE10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10791 --- Comment #1 from Nicole C. Engard --- Created attachment 20668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20668&action=edit cart2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:47:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:47:38 +0000 Subject: [Koha-bugs] [Bug 10791] cart image in prog & IE10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10791 --- Comment #2 from Nicole C. Engard --- Created attachment 20669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20669&action=edit footer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:50:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:50:30 +0000 Subject: [Koha-bugs] [Bug 10693] CreateBranchTransferLimit's return values in C4::Circulation.pm should be more explicit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10693 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:50:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:50:32 +0000 Subject: [Koha-bugs] [Bug 10693] CreateBranchTransferLimit's return values in C4::Circulation.pm should be more explicit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10693 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20159|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20670&action=edit [PASSED QA] Bug 10693: CreateBranchTransferLimit's return value in C4::Circulation.pm should be more explicit This patch test if the parameters $toBranch and $fromBranch are given. If not, CreateBranchTransferLimit now returns undef. This patch also fixes and adds some regression tests in t/db_dependent/Circulation_transfers.t NOTE: Currently, we can add a transferlimit to nonexistent branches because in the database branch_transfer_limits.toBranch and branch_transfer_limits.fromBranch aren't foreign keys. To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=15, 18 wallclock secs ( 0.02 usr 0.01 sys + 0.42 cusr 0.00 csys = 0.45 CPU) Result: PASS Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:51:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:51:27 +0000 Subject: [Koha-bugs] [Bug 10693] CreateBranchTransferLimit's return values in C4::Circulation.pm should be more explicit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10693 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Tested with patch for 10692 applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:55:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:55:43 +0000 Subject: [Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 22:55:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 20:55:47 +0000 Subject: [Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20070|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 20671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20671&action=edit Bug 10593 - AuthoritiesLog should default to yes This trivial patch set the default to 'yes' for this system preference. To test, On a clean install - Navigate Home > Administration > Global System preferences > Logs - AuthoritiesLog is set to "Don't log" Apply the patch, install koha on a new DB. - Navigate Home > Administration > Global System preferences > Logs - AuthoritiesLog should be set to "Log" Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 23:14:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 21:14:38 +0000 Subject: [Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 23:14:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 21:14:43 +0000 Subject: [Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20627|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 20672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20672&action=edit [PASSED QA] Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE Currently, the layout for the Edit/Add Layout screen of the Patron Card Creator is in complete disarray, when viewed in Internet Explorer (of any version). The nav bar is pushed to the bottom of the page, every fieldset is empty (as their contents have been pushed out into different parts of the page), and the checkboxes don't work. The cause appears to be some extraneous mark-up (a few extra fieldset and li elements)and some missing mark-up (ol elements to wrap the list elements, especially when nesting lists within each other and within div elements). Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer I didn't test this in IE, but changes are fixing general problems with HTML validity. Checking the page with the W3C validator: Before: 27 Errors, 7 warning(s) After: 6 Errors, 7 warning(s) All tests and QA script pass, page looks alright. Would be nice to see the remaining problems fixed in a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 23:18:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 21:18:36 +0000 Subject: [Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 23:18:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 21:18:39 +0000 Subject: [Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20671|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 20673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20673&action=edit [PASSED QA] Bug 10593 - AuthoritiesLog should default to yes This trivial patch set the default to 'yes' for this system preference. To test, On a clean install - Navigate Home > Administration > Global System preferences > Logs - AuthoritiesLog is set to "Don't log" Apply the patch, install koha on a new DB. - Navigate Home > Administration > Global System preferences > Logs - AuthoritiesLog should be set to "Log" Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer One line patch, changing the default for new installations only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 23:24:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 21:24:52 +0000 Subject: [Koha-bugs] [Bug 10792] New: Amounts in funds table on acquisitions home page not sorting correctly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792 Bug ID: 10792 Summary: Amounts in funds table on acquisitions home page not sorting correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Created attachment 20674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20674&action=edit funds table, showing wrong sorting The amounts in the fund table on the acquisitions home page are not sorting correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 23:36:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 21:36:06 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18481|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 20675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20675&action=edit Bug 10331 - Little errors in unimarc_field_4XX.pl (punctuation) Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 23:36:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 21:36:53 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20675|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 20676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20676&action=edit [SIGNED-OFF] Bug 10331 - Little errors in unimarc_field_4XX.pl (punctuation) Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 23:37:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 21:37:10 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 27 23:57:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 21:57:52 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 00:58:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 22:58:46 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' - UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz Summary|In OPAC XSLT search |In OPAC XSLT search |results, add class to |results, add class to |'online access' |'online access' - UNIMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 00:59:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Aug 2013 22:59:09 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' - UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #15 from Liz Rea --- Title changed as MARC support has been pushed, and UNIMARC patches are waiting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 02:40:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 00:40:21 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #22 from Liz Rea --- Question, for fields like "Library" - Under what condition would you ever want to delete that field entirely? Is it possibly dangerous to allow? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 02:42:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 00:42:42 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #23 from Liz Rea --- Also, after a batch modification it would probably be best to show all of the fields in the result table, and if not that, then at least show the columns that were modified. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 02:43:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 00:43:32 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #24 from Liz Rea --- er just realised that the last two comments really have nothing to do with this. Sorry about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 03:10:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 01:10:55 +0000 Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC 7XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17165|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel --- Created attachment 20677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20677&action=edit [SIGNED-OFF] Bug 9352 : More specific indexing of UNIMARC 7XX fields (GRS1) 1st patch : for GRS1 indexing Problem : Zebra indexes all subfields of UNIMARC 7XX fields in author index, including $9, $3, $4 (function code), $f (dates of authors), $c (additions other than dates), $p (address). It causes Koha to give too much results. For example, if an author is born in 1984 and is a teacher, searching "1984" or "teacher" in simple search will return all work by this author if these pieces of informations are in 7XX field. This is not how most ILS work, and it should be corrected. Solution : This patch makes indexing of unimarc 7XX fields more specific. For each field, useless subfields are not indexed. 70X : Do not index $f (dates),$c (additions other than dates),$p (affiliation/address),$3,$4. Index $9 only in Koha-Auth-Number. 710-712 : Do not index $p (affiliation/address),$3,$4. Index $9 only in Koha-Auth-Number. (I kept all other subfields : even if some may be useless I am not sure of it) 716 : Do not index $f (dates),$c (additions other than dates),$3,$4. Index $9 only in Koha-Auth-Number. 72X : Do not index $f (dates),$3,$4. Index $9 only in Koha-Auth-Number. 730 : Do not index $4. Index $9 only in Koha-Auth-Number. Additionnaly, this patch indexes 205$f/$g in Author index (author of the edition of the work) Testing : a/ Create a record with : 700$a Doe $b John $f1950 $cteacher $4070 710$a Corporate $b Meeting $p Address 716$a Trademark $f1960 $cgreat $4340 720$a Family $f1980 $4651 205$a 1st edition $fBy some guy $gAnd other guys b/ Before applying patch, make several searches : Search in author index : "teacher", "great", "Address", "1950", "1960", "070", "340", "651" => you will see the record among the results Search in author index : "Doe", "John Doe", "Trademark", "Family","corporate", "meeting" => you will see the record among the results Search in author index : "guy", "guys" => you will see the record among the results with simple search (because 205 is indexed in title) => you will not see the record among the results with author search c/ Apply patch d/ Rebuild Zebra with ./misc/migration_tools/rebuild_zebra.pl -b -x -v -reset e/ Try the same searches as before : Search in author index : "teacher", "great", "Address", "1950", "1960", "070", "340", "651" => you will not see the record among the results Search in author index : "Doe", "John Doe", "Trademark", "Family","corporate", "meeting" => you will see the record among the results Search in author index : "guy", "guys" => you will see the record among the results in both simple search and author search Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described with GRS1. No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 03:11:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 01:11:57 +0000 Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC 7XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #15 from Bernardo Gonzalez Kriegel --- Half signed, works well with GRS1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 03:40:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 01:40:22 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' - UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18948|0 |1 is obsolete| | --- Comment #16 from Bernardo Gonzalez Kriegel --- Created attachment 20678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20678&action=edit Bug 10218 : Followup for UNIMARC Follow-up for UNIMARC XSLT Display This patch adds class to span markup in list and detail display. XSLT are not build in the same way in MARC21 and UNIMARC, so I had to add a parameter "spanclass" to 3 templates called in UNIMARC : tag_title, tag_7xx, tag_comma To test, apply the patch on a Koha instance with UNIMARC records, and - activate sysprefs OPACXSLTDetailsDisplay and OPACXSLTDetailsDisplay - make a search on the OPAC. In the results, check the spans with "results_summary" class have also more a precise class. Ex : span class="results_summary publication" - view some records in detailed view. If possible, a record with a series, a record with some subjects, a record with different authors, a record with a link in 856. Check the spans with "results_summary" have also a more precise class. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works exactly as described on results and detail. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 03:41:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 01:41:04 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' - UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20678|0 |1 is obsolete| | --- Comment #17 from Bernardo Gonzalez Kriegel --- Created attachment 20679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20679&action=edit [SIGNED-OFF] Bug 10218 : Followup for UNIMARC Follow-up for UNIMARC XSLT Display This patch adds class to span markup in list and detail display. XSLT are not build in the same way in MARC21 and UNIMARC, so I had to add a parameter "spanclass" to 3 templates called in UNIMARC : tag_title, tag_7xx, tag_comma To test, apply the patch on a Koha instance with UNIMARC records, and - activate sysprefs OPACXSLTDetailsDisplay and OPACXSLTDetailsDisplay - make a search on the OPAC. In the results, check the spans with "results_summary" class have also more a precise class. Ex : span class="results_summary publication" - view some records in detailed view. If possible, a record with a series, a record with some subjects, a record with different authors, a record with a link in 856. Check the spans with "results_summary" have also a more precise class. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works exactly as described on results and detail. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 03:41:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 01:41:23 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' - UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 03:54:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 01:54:20 +0000 Subject: [Koha-bugs] [Bug 10793] New: XSLT change 780/785 search queries to use ti, phr indexes like other linking entries Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Bug ID: 10793 Summary: XSLT change 780/785 search queries to use ti,phr indexes like other linking entries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, the 780 (preceding entry)/785 (continuing entry) fields in the XSLT are using a plain "q=" search, while other linking entries like 773 (host item) and 775 (other edition) use the ti,phr indexes like so "q=ti,phr:". This bug seeks to change it so that the 780 and 785 fields use the ti,phr indexes for searching as well, since the search queries are populated using the "title" or "main entry heading" subfields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 04:03:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 02:03:27 +0000 Subject: [Koha-bugs] [Bug 10793] XSLT change 780/785 search queries to use ti, phr indexes like other linking entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 04:03:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 02:03:30 +0000 Subject: [Koha-bugs] [Bug 10793] XSLT change 780/785 search queries to use ti, phr indexes like other linking entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 --- Comment #1 from David Cook --- Created attachment 20680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20680&action=edit Bug 10793 - XSLT change 780/785 search queries to use ti,phr indexes like other linking entries This patch adds the ti,phr index to the search queries for the 780 and 785 MARC fields in the XSLT templates. Test Plan: 1) Use a record with 780 and 785 MARC fields with data in the "a" or "t" subfields. (You might need to add these fields to an existing record, or create a new record. You might also need to change your MARC Bibliographic Framework settings to not "hide" these fields in your framework(s)). N.B. The data in the "a" or "t" subfields should be a title that exists in your database. Otherwise, this test might seem misleading. 2) Set the system preferences "XSLTDetailsDisplay" and "OPACXSLTDetailsDisplay" to "default". 3) Go to your record (which contains the 780/785 fields), and look for links with linktext derived from the "a" or "t" fields in the record. These may or may not be prefaced with labels such as "Continued by" or "Continues". 4) Note that the links are formatted "q=TITLE". Click this link and note the possibly high number of results. 5) APPLY THE PATCH 6) Shift+Refresh your record page, and observe that the link should now say "q=ti,phr:TITLE". Click this link and note that you are either taken directly to the referenced article or that your search results are considerably fewer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 04:03:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 02:03:59 +0000 Subject: [Koha-bugs] [Bug 10793] XSLT change 780/785 search queries to use ti, phr indexes like other linking entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 04:27:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 02:27:13 +0000 Subject: [Koha-bugs] [Bug 10130] Input fields for branch configuration are too short In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20486|0 |1 is obsolete| | CC| |campbellreidtait at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 04:28:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 02:28:21 +0000 Subject: [Koha-bugs] [Bug 10130] Input fields for branch configuration are too short In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Assignee|oleonard at myacpl.org |campbellreidtait at gmail.com --- Comment #2 from Campbell Reid-Tait --- Created attachment 20681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20681&action=edit Signed off patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 05:10:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 03:10:38 +0000 Subject: [Koha-bugs] [Bug 8004] Items on hold lose transfer after being scanned twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20583|0 |1 is obsolete| | CC| |campbellreidtait at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 05:12:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 03:12:05 +0000 Subject: [Koha-bugs] [Bug 8004] Items on hold lose transfer after being scanned twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Assignee|kyle.m.hall at gmail.com |campbellreidtait at gmail.com --- Comment #13 from Campbell Reid-Tait --- Created attachment 20682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20682&action=edit Signed off patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 05:37:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 03:37:58 +0000 Subject: [Koha-bugs] [Bug 10769] Simplify clearing of input fields when duplicating a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10769 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20503|0 |1 is obsolete| | Status|Needs Signoff |Signed Off CC| |campbellreidtait at gmail.com Assignee|koha-bugs at lists.koha-commun |campbellreidtait at gmail.com |ity.org | --- Comment #2 from Campbell Reid-Tait --- Created attachment 20683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20683&action=edit Signed Off: Bug 10769 - Simplify clearing of input fields when duplicating a patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 06:12:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 04:12:11 +0000 Subject: [Koha-bugs] [Bug 9294] Move JavaScript out of circulation template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9294 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20382|0 |1 is obsolete| | Status|Needs Signoff |Signed Off CC| |campbellreidtait at gmail.com Assignee|oleonard at myacpl.org |campbellreidtait at gmail.com --- Comment #17 from Campbell Reid-Tait --- Created attachment 20684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20684&action=edit SIGNED OFF: Bug-9294-Move-JavaScript-out-of-circulation-template.patch Bug 9294 - Move JavaScript out of circulation template (14.29 KB, patch) 2013-01-04 14:11 UTC, Owen Leonard and Bug 9294 [Follow-up] Move JavaScript out of circulation template (3.16 KB, patch) 2013-03-18 18:26 UTC, Owen Leonard were unable to be applied error fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9294 - Move JavaScript out of circulation template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 06:13:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 04:13:11 +0000 Subject: [Koha-bugs] [Bug 9294] Move JavaScript out of circulation template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9294 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|campbellreidtait at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 06:31:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 04:31:58 +0000 Subject: [Koha-bugs] [Bug 9618] Add support for intranetuserjs to labels/spinelabel-print.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16306|0 |1 is obsolete| | CC| |campbellreidtait at gmail.com --- Comment #10 from Campbell Reid-Tait --- Created attachment 20685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20685&action=edit Signed Off: 16306: Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 06:32:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 04:32:50 +0000 Subject: [Koha-bugs] [Bug 9618] Add support for intranetuserjs to labels/spinelabel-print.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18416|0 |1 is obsolete| | --- Comment #11 from Campbell Reid-Tait --- Created attachment 20686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20686&action=edit Signed Off: 18416: Bug 9618: Followup Add support for intranetuserjs to labels/spinelabel-print.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 06:33:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 04:33:39 +0000 Subject: [Koha-bugs] [Bug 9618] Add support for intranetuserjs to labels/spinelabel-print.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 07:04:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 05:04:36 +0000 Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20634|0 |1 is obsolete| | CC| |campbellreidtait at gmail.com --- Comment #6 from Campbell Reid-Tait --- Created attachment 20687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20687&action=edit Signed Off: 20634: Bug 10737 [Revised] Add "Add to basket" link on vendor search results page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 07:05:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 05:05:02 +0000 Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 08:14:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 06:14:10 +0000 Subject: [Koha-bugs] [Bug 10130] Input fields for branch configuration are too short In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 08:14:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 06:14:13 +0000 Subject: [Koha-bugs] [Bug 10130] Input fields for branch configuration are too short In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20681|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20688&action=edit [PASSED QA] Bug 10130 - Input fields for branch configuration are too short Most input fields in the library entry form (admin/branches.pl) have no explicit with, so they display with a browser-default width. This patch gives explicit widths to those fields, giving more room for entry. Other fields have been given an explicit width and/or maxwidth according to the database table structure. To test, add or edit a library in Administration -> Libraries and Groups. Form fields should be more comfortable for entry, and add/edit actions should complete correctly. Signed-off-by: Campbell Reid-Tait Signed-off-by: Katrin Fischer Template changes only, works nicely. Tested editing and adding libraries in administration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 08:15:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 06:15:08 +0000 Subject: [Koha-bugs] [Bug 10130] Input fields for branch configuration are too short In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 --- Comment #4 from Katrin Fischer --- Maybe we could move the opac info editor field a bit to the right, to match where the other fields begin. But this works nicely and long library names and addresses shouldn't be a problem now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 08:23:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 06:23:50 +0000 Subject: [Koha-bugs] [Bug 10794] New: Sorting on billing date column in invoices table doesn't work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Bug ID: 10794 Summary: Sorting on billing date column in invoices table doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/invoices.pl?supplierid=2&op=do_sea rch OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Sorting by billing date in the invoices table in acquisitions doesn't work. In my case there was only one date and the other fields were empty. Sorting the column didn't result in any change. Other columns sort nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 08:30:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 06:30:31 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 --- Comment #9 from Katrin Fischer --- Currently working on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 08:36:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 06:36:22 +0000 Subject: [Koha-bugs] [Bug 10078] show location facet for all In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078 --- Comment #9 from David Cook --- (In reply to Katrin Fischer from comment #8) > Hm maybe for others reading this we should clarify: > > > 1) If you limit on Branch A and location D, you should get no results in > > your scenario. > > That would be how we want it, but it's not going to happen as for the facets > always everything that appears in the record is taken into account. So all > item information is mixed together - if you have a branch and a location > appearing in your record, the facets will show up, even if the information > belongs to different items. > > > 2) In what scenario would you be able to use both those facets? (Using the > > Advanced Search, you could, but that's unrelated to the facets.) > > Yes, advanced search can give confusing results too - but I think it's a lot > less obvious and users are not so likely to try. > > > If you choose Branch A from the Libraries facet, you would only be presented > > with location C as a Locations facet. If you choose location D, you would > > only be presented with Branch B as a Libraries facet. > > Unfortunately that's not the case - see explanation above. > > > I don't think it's an indexing issue though. From what I've seen so far, it > > seems to me that DOM and GRS-1 fill the same indexes, they just do it in > > different ways. > > With DOM indexing, I think, the issue could be solved, but not with GRS - > and it's currently not implemented. > > Just trying to explain why I think this change is likely to cause some > confusion. Mmm, I think I understand what you're saying now. Basically, 1 bibliographic record can contain multiple items from multiple different branches, multiple different locations, etc. As a result, the facets always include information from ALL the items attached to a bib record. So even if you "narrow" your search results using one facet, you'll still have facets and facet values showing up for other branches, locations, etc...if a bib record in the results ALSO contains items that have other branches, locations, etc. That certainly is a problem. It seems to be a problem with every item-level facet though. Branches and itemtypes being perhaps the most obvious, although location would certainly fall into that as well. -- As for a solution... I still don't think that DOM indexing would fix this. Admittedly, I am not very experienced with it, but from what I can tell, DOM indexing seems to use XPATH to select particular MARCXML nodes and then puts them into defined indexes (probably defined in bib1.att). The end result is the same as GRS-1, but I think it's much simpler and perhaps more robust than GRS-1. I think a solution would need to take into account item-level limits after the MARC search results are returned from Zebra. As far as I know, Zebra thinks only in terms of bibs and whether a bib is tied to a certain index. I imagine that we would have to do a certain amount of post-processing to weed out any inapplicable items...and then suppress that bib record, if there are no items that match our item-level limits. I imagine that would get fairly messy though, and run into the same problems that we're already encountering with post-processed suppressed bib records :/ (such as the number of results not equalling the number at the top of the page and the number of records appearing per page being unequal). I'm not sure that there's a way to query Zebra and check that all the 952s have a certain item-level limit. Again, I'm no indexing expert, but with indexing...I assume that each index is filled with words or phrases and each of these words or phrases is then linked to an entire record. I might be wrong (and am almost certainly missing some of the finer points and technical details), but that's how I understand the Zebra indexing to work whether DOM or GRS-1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 09:18:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 07:18:21 +0000 Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC 7XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #16 from mathieu saby --- Thank you for testing. And do you agree that the corrected behavior is better for users? M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 09:18:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 07:18:54 +0000 Subject: [Koha-bugs] [Bug 10783] LDAP integration in koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10783 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |magnus at enger.priv.no Resolution|--- |INVALID --- Comment #1 from Magnus Enger --- Hi! I think the best source for information about LDAP and Koha is this: http://perldoc.koha-community.org/C4/Auth_with_ldap.html Please note that Bugzilla is meant for bugs and enhancement suggestions. General support questions like this are better directed to the mail list(s): http://koha-community.org/support/koha-mailing-lists/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 09:21:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 07:21:26 +0000 Subject: [Koha-bugs] [Bug 10078] show location facet for all In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078 --- Comment #10 from Katrin Fischer --- I am not totally sure here, so maybe someone can confirm, but from what I unnderstand you can build more flexible indexes over multiple subfields with DOM. So you could index various item subfields into one index and that could make the limiting more precise - actually looking for your search term in the same index. I think you could also index depending on indictors or checking for existence of other subfields first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 10:26:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 08:26:45 +0000 Subject: [Koha-bugs] [Bug 10683] CRUD routines in C4::Circulation need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 10:26:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 08:26:48 +0000 Subject: [Koha-bugs] [Bug 10683] CRUD routines in C4::Circulation need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683 --- Comment #1 from kenza --- Created attachment 20689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20689&action=edit Bug 10683: CRUD routines in C4::Circulation need unit tests This patch adds some unit tests wrap in a transaction for C4::Circulation.pm. Circulation_Branch.t adds tests for routines which deal with branch_item_rules,branch_borrower_circ_rules, default_branch_circ_rules, default_circ_rules, default_branch_item_rules in the database. Circulation_issue.t adds tests for routines which deal with accountline and issues in the database. NOTE: Some commented tests have to be fixed, and some tests can be added.More, other routines of Circulation.pm are tested in the patches: 10692 UT: Routines about transfers in Circulation.pm need unit tests 10710 UT : OfflineOperation's routines in C4/Circulation.t need unit tests 10767 UT: Routines which interact with the table issuingrules in C4/Circulation need unit test Test plan: prove t/db_dependent/Circulation_issue.t t/db_dependent/Circulation_issue.t .. ok All tests successful. Files=1, Tests=16, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.40 cusr 0.02 csys = 0.44 CPU) Result: PASS prove t/db_dependent/Circulation_Branch.t t/db_dependent/Circulation_Branch.t .. ok All tests successful. Files=1, Tests=10, 2 wallclock secs ( 0.06 usr 0.00 sys + 1.02 cusr 0.06 csys = 1.14 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 10:31:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 08:31:45 +0000 Subject: [Koha-bugs] [Bug 10795] New: Improvements for GetOpenIssue in C4::Circulation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795 Bug ID: 10795 Summary: Improvements for GetOpenIssue in C4::Circulation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 10:32:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 08:32:02 +0000 Subject: [Koha-bugs] [Bug 10795] Improvements for GetOpenIssue in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenza.zaki at biblibre.com Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 10:34:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 08:34:32 +0000 Subject: [Koha-bugs] [Bug 10795] Improvements for GetOpenIssue in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10683 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 10:34:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 08:34:32 +0000 Subject: [Koha-bugs] [Bug 10683] CRUD routines in C4::Circulation need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10795 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 10:48:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 08:48:07 +0000 Subject: [Koha-bugs] [Bug 10796] New: Allow OpacPasswordChange to be set by category type Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Bug ID: 10796 Summary: Allow OpacPasswordChange to be set by category type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When using LDAP or another central authentication you don't want patrons to change passwords in the OPAC, but at the same time you might have local users that should be allowed to change their password. I think it would be nice if we could move OpacPasswordChange from a global system preference to the patron category confguration page. This is similar to bug 3032 - but would not be per patron, but only per patron category. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 10:48:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 08:48:41 +0000 Subject: [Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3032 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 10:48:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 08:48:41 +0000 Subject: [Koha-bugs] [Bug 3032] Enhancement: ability to deny some patrons password resets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3032 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10796 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 10:50:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 08:50:11 +0000 Subject: [Koha-bugs] [Bug 10795] Improvements for GetOpenIssue in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795 --- Comment #1 from kenza --- Created attachment 20690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20690&action=edit Bug 10795 - Improvements for GetOpenIssue in C4::Circulation This patch adds some improvements for the routine GetOpenIssue. Now, it verifies if the parameter is given (if not it returns undef) and it returns $sth->fetchrow_hashref() instead of a $issue. To test: prove t/db_dependent/Circulation_issue.t t/db_dependent/Circulation_issue.t .. ok All tests successful. Files=1, Tests=16, 2 wallclock secs ( 0.06 usr 0.01 sys + 1.09 cusr 0.07 csys = 1.23 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 10:50:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 08:50:09 +0000 Subject: [Koha-bugs] [Bug 10795] Improvements for GetOpenIssue in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 11:51:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 09:51:59 +0000 Subject: [Koha-bugs] [Bug 10130] Input fields for branch configuration are too short In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it --- Comment #5 from Paola Rossi --- I also tested the patch on Windows 7 professional, browsers: Mozilla FF 23, Google Chrome 29 and Explorer 9. For me it's OK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 12:08:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 10:08:52 +0000 Subject: [Koha-bugs] [Bug 10797] New: Move styling from element to CSS file for search input field in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10797 Bug ID: 10797 Summary: Move styling from element to CSS file for search input field in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To make it easier to style the simple search box in the OPAC the CSS should be moved from the style attribute to the CSS files: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 12:56:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 10:56:34 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 12:56:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 10:56:40 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20476|0 |1 is obsolete| | --- Comment #89 from Chris Cormack --- Created attachment 20691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20691&action=edit Bug 5349: Order line transfers On basket.pl and parcel.pl there is a 'Transfer' link which allow you to transfer order lines from a basket to another. The link lead to a new page which allow you to search for a bookseller, then display this bookseller's baskets. Then you can pickup a basket and the transfer will be done. This add a message in new column aqorders.internalnotes which is displayed in basket.pl Signed-off-by: Marc Veron Signed-off-by: Mathieu Saby Signed-off-by: sonia Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 12:56:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 10:56:55 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20477|0 |1 is obsolete| | --- Comment #90 from Chris Cormack --- Created attachment 20692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20692&action=edit Bug 5349 follow-up: run transferorder.pl in a popup Signed-off-by: Marc Veron Signed-off-by: Mathieu Saby Signed-off-by: sonia Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 12:57:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 10:57:09 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20478|0 |1 is obsolete| | --- Comment #91 from Chris Cormack --- Created attachment 20693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20693&action=edit Bug 5349: Fix a logical test in TransferOrder Signed-off-by: Mathieu Saby Signed-off-by: sonia Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 12:57:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 10:57:22 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20479|0 |1 is obsolete| | --- Comment #92 from Chris Cormack --- Created attachment 20694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20694&action=edit Bug 5349: Add unit tests for TransferOrder Signed-off-by: sonia Signed-off-by: Chris Cormack Signing off on this because a following patch fixes the test to use transactions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 12:58:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 10:58:09 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20480|0 |1 is obsolete| | --- Comment #93 from Chris Cormack --- Created attachment 20695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20695&action=edit Bug 5349: Use DB transaction/rollback in unit tests Signed-off-by: sonia Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 12:58:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 10:58:24 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20481|0 |1 is obsolete| | --- Comment #94 from Chris Cormack --- Created attachment 20696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20696&action=edit Bug 5349: Create a table for order line transfers This allow to keep transfers informations without having untranslatable strings in database. Signed-off-by: sonia Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 13:00:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 11:00:48 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #95 from Chris Cormack --- It is important to note, do not run the database update until all patches are applied, or you will end up with the db in a messy state -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 13:07:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 11:07:19 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 13:07:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 11:07:23 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20566|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 20697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20697&action=edit Bug 6594: Schema.org structured data for OPAC display To support schema.org processors, such as Google, Bing, and Yandex, structure our data so that it has machine-readable attributes. This pass declares the CreativeWork sub-types as well as Product for the main bibliographic record details, and uses the Offer type for holdings information per the W3C Schema Bib Extend community group discussions. Signed-off-by: Dan Scott Signed-off-by: Jared Camins-Esakov Comments on final patch. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 13:07:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 11:07:33 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20567|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 20698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20698&action=edit Bug 6594: Move subject keywords schema.org markup into element Google's rich snippets tool gets confused by the
    approach, so stuff another span inside the element to remove confusion with the href attribute. Signed-off-by: Dan Scott Signed-off-by: Jared Camins-Esakov Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 13:07:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 11:07:42 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20568|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 20699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20699&action=edit Bug 6594: Correct schema.org context for item status We were inserting the element inside an open element, which HTML parsers, even the most forgiving, do not like very much. Signed-off-by: Dan Scott Signed-off-by: Jared Camins-Esakov Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 13:08:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 11:08:00 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20569|0 |1 is obsolete| | --- Comment #9 from Chris Cormack --- Created attachment 20700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20700&action=edit Bug 6594: Schema.org span nesting improvements So, it turns out that the was causing a new "chain" to be invoked, thus nesting the elements for properties within the actually caused the properties to be attached to that new chain rather than the containing object. Therefore, wrap the elements around the elements where applicable. Thanks to Manu Sporny in #rdfa for helping me to sort this out. Signed-off-by: Dan Scott Signed-off-by: Jared Camins-Esakov I tested by validating against the Google rich snippet tool, validator.nu, and linter.structured-data.org. All were satisfied with the microdata markup, and the properties that are set make sense. These patches are only for MARC21 XSLT view, but I think it is worth pushing them even without the NORMARC and UNIMARC markup, so that people can start to test out schema.org microdata in Koha, and refine the implementation. Signed-off-by: Chris Cormack FWIW I agree with Jared, it is essentially a no-op in terms of what the user sees, so is safe. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 13:24:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 11:24:14 +0000 Subject: [Koha-bugs] [Bug 7478] Template/translation problem in catalogue_out.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 13:24:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 11:24:17 +0000 Subject: [Koha-bugs] [Bug 7478] Template/translation problem in catalogue_out.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20601|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 20701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20701&action=edit Bug 7478 - Template/translation problem in catalogue_out.tt The items with no checkouts template has a sections that uses DEFAULT to set some strings: [% DEFAULT loopro.itemcallnumber="No Call Number" %] This appears to be untranslatable with our current translation tool. This patch changes the template so that it uses a simple [% IF %] block to display the default text if no value is set. Added is use of the Branches template plugin to show library name instead of code. This patch also fixes an error introduced in my fix for Bug 8124 causing the page to default to CSV download instead of output to screen. To test, apply the patch and confirm that the default text appears onscreen in reports which include results that have a missing barcode, title, or call number. Results should be displayed on screen correctly. Run "perl translate update" for any language and confirm that the newly generated po file includes "No call number," "No barcode," and "NO TITLE" for catalogue_out.tt Signed-off-by: Katrin Fischer Works nicely, thx Owen! Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 14:29:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 12:29:54 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #33 from Kyle M Hall --- I was just replicating what other parts of the xslt was already doing. If you think the if is better ( which I imagine it is ) that's fine by me. Would you like to add a qa followup, or shall I? (In reply to Katrin Fischer from comment #31) > This works, but I am a bit torn on the constructs: > > + > + > + > + > + > > This could be: > > > > -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:18:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:18:22 +0000 Subject: [Koha-bugs] [Bug 9294] Move JavaScript out of circulation template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9294 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16303|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:18:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:18:38 +0000 Subject: [Koha-bugs] [Bug 9294] Move JavaScript out of circulation template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9294 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14417|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:18:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:18:45 +0000 Subject: [Koha-bugs] [Bug 10726] Default Unimarc framework in accordance with new edition of the Unimarc manual In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:29:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:29:00 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 --- Comment #5 from Kyle M Hall --- The unlabeled one is for master, the other applies to 3.10.x and 3.12.x (In reply to Owen Leonard from comment #4) > One patch is labeled "[v3.10/v3.12]" and the other is unlabeled. What's the > difference? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:36:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:36:48 +0000 Subject: [Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17619|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 20702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20702&action=edit Bug 8484 - Add ability to choose of lost items are removed from a borrowers record. Adds the system preference ReturnLostItems to control whether setting an item as lost will remove the item from the borrower's record. Note, this system preference does not affect misc/cronjobs/longoverdue.pl which has its own command line switch to choose this behavior. Test plan: Apply the patch and let the database update run. Test the process of marking something lost with the ReturnLostItems preference in the default "on" state: - Find an item which is checked out and mark it lost from moredetail.pl - Find an item which is checked out and mark it lost using the batch item modification tool In both cases the item should be removed from the patron's account (checked in) and a fine applied. Next test with the ReturnLostItems preference turned off. The same procedure should result in the item being checked in but the fine applied. Signed-off-by: Owen Leonard Passes the test plan which I made up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:36:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:36:58 +0000 Subject: [Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:37:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:37:01 +0000 Subject: [Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17620|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 20703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20703&action=edit Bug 8484 - Add ability to choose if lost items are removed from a borrowers record. - Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:39:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:39:37 +0000 Subject: [Koha-bugs] [Bug 10430] status filter not working in serial claims when translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #13 from Fridolyn SOMERS --- Created attachment 20704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20704&action=edit Bug 10430 - arrived and stopped status are not possible in serial claim Follow up to remove arrived and stopped status, as asked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:40:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:40:08 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:40:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:40:10 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20351|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 20705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20705&action=edit [SIGNED-OFF] Bug 10731 - IntranetSlipPrinterJS is not working for hold slips Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:41:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:41:56 +0000 Subject: [Koha-bugs] [Bug 10430] status filter not working in serial claims when translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #14 from Fridolyn SOMERS --- (In reply to Katrin Fischer from comment #11) > I think this can be fixed in a follow up. I added follow-up but did not change the bug status. I let you manage it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:43:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:43:26 +0000 Subject: [Koha-bugs] [Bug 9247] Add two more usage examples to the manpage for koha-mysql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9247 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Magnus! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:44:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:44:12 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 --- Comment #7 from Owen Leonard --- Created attachment 20706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20706&action=edit [SIGNED-OFF] Bug 10731 - IntranetSlipPrinterJS is not working for hold slips [v3.10/v3.12] Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically Signed-off-by: Owen Leonard Tested successfully in 3.10.x and 3.12.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:44:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:44:31 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20353|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:46:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:46:22 +0000 Subject: [Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:47:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:47:29 +0000 Subject: [Koha-bugs] [Bug 10587] HTML errors on authority detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:49:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:49:03 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 --- Comment #4 from Kyle M Hall --- Good catches! I'll get a followup written asap. (In reply to Owen Leonard from comment #3) > This looks good and is a nice improvement. I do see one issue: I'm pretty > sure you shouldn't be able to suspend a hold on an item which is in transit. > You can't cancel a hold while it is in transit, and the staff client blocks > you from suspending. > > If that sounds correct and you'll submit a revision, there is also an orphan >

    which needs to be removed, right after the "clear date" link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 15:54:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 13:54:27 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Martin Renvoize --- I don't think this actually got to QA.. so resetting to Needs Signoff, as I think the 'Failed QA' status is holding it back from any further comment or testing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:01:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:01:07 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Dan! And congratulations on your first patch series to Koha! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:08:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:08:39 +0000 Subject: [Koha-bugs] [Bug 10130] Input fields for branch configuration are too short In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:15:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:15:33 +0000 Subject: [Koha-bugs] [Bug 10690] Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10690 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Magnus! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:19:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:19:04 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #34 from Katrin Fischer --- Hi Kyle, please change the patch yourself, so I can test it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:26:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:26:54 +0000 Subject: [Koha-bugs] [Bug 10629] Inappropriate uses of $sth->finish() in C4::Branch.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:27:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:27:15 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #43 from Galen Charlton --- Pushed to master. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:36:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:36:41 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 --- Comment #5 from Tom?s Cohen Arazi --- If this fix is needed in 3.12.x a new patch is needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:47:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:47:20 +0000 Subject: [Koha-bugs] [Bug 10767] UT: Routines which interact with the table issuingrules in C4/Circulation need unit test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10767 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Kenza! I did, however, also push a follow-up removing the FIXME comments -- GetIssuingRules() is not a traditional accessor, and should not be returning multiple rules in any event. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:48:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:48:58 +0000 Subject: [Koha-bugs] [Bug 10798] New: OPAC_SEARCH_LIMIT behaves badly with search groups Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Bug ID: 10798 Summary: OPAC_SEARCH_LIMIT behaves badly with search groups Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The code implementing multiple PAC's by URL support as in the RFC here at http://wiki.koha-community.org/wiki/Support_for_multiple_PAC_interfaces_by_URL_RFC has been implimented for some time. However, when the 'search by groups' feature was implemented, the above code was not taken into account, and as such if you wish to limit a search by a group as a posed to just a branch, you met with strange behaviour should you also enable the SearchMyLibraryFirst system preference. Testplan to show Failure 1. Add a second PAC by adding an Alias to your Apache vhosts file (See below example) 2. Add a Search group to Koha using the staff client 3. Enable URL specific search limit (branch:search_group_code) to that same Apache vhosts file using a SetEnvIf (See below example) 4. Enable 'SearchMyLibraryFirst' system preference. 5. Create a user, and set that users branch. 6. Go to the 'normal' koha opac url and the search will not be limited 7. Go to the 'second' koha opac url and the search will be limited to your search group 8. Login on the 'normal' url and your search will be limited by your users branch 9. Login on the 'second' url and your search will be limited by your users branch Step 9 is the error, if OPAC_LIMIT_OVERRIDE is set to 1 in the SetEnvIf then this should NOT be your local library branch, but actually the limit set in the Apache conf VirtualHosts example additions ServerName opac.your-domain.com ServerAlias opac2.your-domain.com SetEnvIf Host "opac2.your-domain.com" OPAC_SEARCH_LIMIT=branch:search_group_code OPAC_LIMIT_OVERRIDE=1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:51:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:51:42 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:51:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:51:47 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20023|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 20707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20707&action=edit Bug 10609: Use branch name rather than branch code in serials-collection.pl (3.12.x) This is the 3.12.x compatible version of the patch for 10609. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:52:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:52:14 +0000 Subject: [Koha-bugs] [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Patch complexity|--- |Trivial patch Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:52:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:52:20 +0000 Subject: [Koha-bugs] [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:53:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:53:17 +0000 Subject: [Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:56:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:56:41 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED Version|master |3.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 16:56:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 14:56:50 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 17:05:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 15:05:37 +0000 Subject: [Koha-bugs] [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 --- Comment #1 from Martin Renvoize --- Created attachment 20708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20708&action=edit Bug 10798 - OPAC_SEARCH_LIMIT behaves badly with search groups -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 17:07:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 15:07:40 +0000 Subject: [Koha-bugs] [Bug 10726] Default Unimarc framework in accordance with new edition of the Unimarc manual In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726 --- Comment #1 from Sonia Lemaire --- Created attachment 20709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20709&action=edit Bug 10726: UNIMARC charts corresponding to 6th french edition of the bibliographic manual and 3rd english edition of authorities manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 17:08:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 15:08:08 +0000 Subject: [Koha-bugs] [Bug 10726] Default Unimarc framework in accordance with new edition of the Unimarc manual In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726 Sonia Lemaire changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 17:08:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 15:08:23 +0000 Subject: [Koha-bugs] [Bug 10566] Improve OPAC course reserves pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master, along with a follow-up to fix a couple stray HTML validation issues. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 17:08:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 15:08:31 +0000 Subject: [Koha-bugs] [Bug 10566] Improve OPAC course reserves pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 17:13:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 15:13:23 +0000 Subject: [Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 17:19:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 15:19:07 +0000 Subject: [Koha-bugs] [Bug 10693] CreateBranchTransferLimit's return values in C4::Circulation.pm should be more explicit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10693 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master, along with a follow-up that corrects the parameter tests to check for definedness, not Perl truth. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 17:20:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 15:20:29 +0000 Subject: [Koha-bugs] [Bug 10726] Default Unimarc framework in accordance with new edition of the Unimarc manual In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726 --- Comment #2 from Sonia Lemaire --- According to the norm, the changes involved by this patch are: for Unimarc/ Biblio: - 4XX$t is repeatable - 503: new subfield $o - 545: new subfields $e $h $i $j $n $z - 930: new subfields $w and $z for Unimarc/ Authorities - 033: new field New subfield $n in 510, 512, 513, 514, 515, 516, 517, 518, 520, 540 is not in the norm. Subfields $m and $r for 501 where already in the frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 17:30:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 15:30:30 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 17:30:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 15:30:33 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20535|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 20710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20710&action=edit Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold 6) Disable AutoResumeSuspendedHolds, ensure the suspend until date field is no longer visible. 7) Disable SuspendHoldsOpac, ensure all suspension related fields are no longer visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 17:35:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 15:35:47 +0000 Subject: [Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in C4/Circulation.pm needs return value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master, along with a follow-up that improves the function's POD and fixes the parameter checking. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 17:44:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 15:44:47 +0000 Subject: [Koha-bugs] [Bug 9782] Cancel button doesn't work when importing MARC bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 18:00:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 16:00:47 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #11 from mathieu saby --- Could you tell me if a followup for UNIMARC is needed ? M. Saby -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 18:01:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 16:01:14 +0000 Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 18:05:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 16:05:58 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #11 from Fridolyn SOMERS --- (In reply to Katrin Fischer from comment #10) Oh, indeed. What should I do ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 18:28:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 16:28:38 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #102 from Galen Charlton --- Created attachment 20711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20711&action=edit Bug 7143: history.txt updates - two new developers - releases Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 18:31:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 16:31:53 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 18:31:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 16:31:58 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20711|0 |1 is obsolete| | --- Comment #103 from Galen Charlton --- Created attachment 20712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20712&action=edit Bug 7143: history.txt and about page updates - two new developers - releases Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 19:02:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 17:02:45 +0000 Subject: [Koha-bugs] [Bug 7257] Add a link to remove an individual title from a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 19:03:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 17:03:32 +0000 Subject: [Koha-bugs] [Bug 5652] Patron checkout and holds summary should show subtitles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5652 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Marc! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 19:06:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 17:06:22 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #21 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 19:10:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 17:10:34 +0000 Subject: [Koha-bugs] [Bug 10799] New: Able to change logged in user Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10799 Bug ID: 10799 Summary: Able to change logged in user Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org While testing for oleonard at responsive.mykoha.co.nz, I found these steps duplicated a weird glitch. 1) go to responsive.mykoha.co.nz 2) log in The user is member, member 3) click the self checkout link 4) log in 5) click the browser back button twice 6) refresh page The user is now staff Similarly, 1) go to responsive.mykoha.co.nz 2) click the self checkout link 3) log in 4) click the finish button 5) change the address back to the http://responsive.mykoha.co.nz/ 6) refresh page The user is now staff The log in used was the member, member one, and not staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 19:18:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 17:18:23 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #39 from David Burke --- I updated and at some point ldap, even with my previous and functional hacks, does not function anymore. At this point I've given up on it. Could you send me this modified Auth_with_ldap.pm to test though? I'm also trying on a Zentyal 3.0 server that has both samba ldap and openldap. I can't get it to work but that could be for many reasons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 19:28:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 17:28:45 +0000 Subject: [Koha-bugs] [Bug 10800] New: Unable to print hold page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10800 Bug ID: 10800 Summary: Unable to print hold page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: yvcruz at uiwtx.edu QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Once a hold has been triggered, KOHA doesn't print the hold page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 19:32:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 17:32:05 +0000 Subject: [Koha-bugs] [Bug 10799] Able to change logged in user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10799 --- Comment #1 from M. Tompsett --- To trigger the problem in firefox for method one: 1) go to responsive.mykoha.co.nz 2) log in The user is member, member 3) copy the self checkout link 4) search for a book 5) view the details 6) paste the self checkout link 7) log in 8) click the browser back button twice 9) refresh page. Without actually being on a page past the log in, Firefox would resend the data and avoid this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 20:12:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 18:12:33 +0000 Subject: [Koha-bugs] [Bug 10799] Able to change logged in user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10799 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #2 from Owen Leonard --- Note that this problem isn't a problem just with the demo system linked above, but with any system running master (or before, probably). In order to reproduce the problem you have to have the AutoSelfCheckAllowed preference set to "allow the web-based self checkout system to automatically login with this staff login..." and have staff login credentials saved. So it's not exactly the case that one is able to change the logged in user--the staff user must be logged in for the self checkout to work. It's more a question of whether there should be a built-in way to prevent the self checkout user from accessing a regular OPAC session. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 20:14:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 18:14:27 +0000 Subject: [Koha-bugs] [Bug 10800] Unable to print hold page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10800 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from Owen Leonard --- Please be more specific about the steps required to reproduce this problem, and please specify the version of Koha you are using. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 20:36:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 18:36:03 +0000 Subject: [Koha-bugs] [Bug 10799] Able to change logged in user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10799 --- Comment #3 from M. Tompsett --- Unless you lock your browser down, someone is likely to click back or paste things into the address bar. The self-checkout isn't really self-checkout, it is use this staff user for checkout. Sort of like a seteuid system implemented as a setuid instead of actually implementing a seteuid system. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 20:37:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 18:37:12 +0000 Subject: [Koha-bugs] [Bug 10799] Able to become self-checkout staff user in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10799 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Able to change logged in |Able to become |user |self-checkout staff user in | |OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 22:51:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 20:51:26 +0000 Subject: [Koha-bugs] [Bug 10786] Javascript error on the parcel page: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I am still having some problems after this patch is applied - I ran into the problem testing the patch for 10649 - also leaving a note there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 22:55:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 20:55:48 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 --- Comment #10 from Katrin Fischer --- I am almost done with testing, but the last one gives me a lot of trouble, even with the patch for 10786 applied: - Acquisitions -> Vendor -> Receive shipments -> Receipt summary (click invoice number) /cgi-bin/koha/acqui/parcel.pl?invoiceid=2 Having almost 6.000 orders in that table might factor into that. Owen, could you take a look at 10786 and that page again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 23:17:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 21:17:15 +0000 Subject: [Koha-bugs] [Bug 10786] Javascript error on the parcel page: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 23:17:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 21:17:18 +0000 Subject: [Koha-bugs] [Bug 10786] Javascript error on the parcel page: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20652|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20713&action=edit [SIGNED-OFF] Bug 10786: Javascript error on the parcel page: YAHOO is not defined The include of the yui json file generates a js error: YAHOO is not defined. This file seems not to be in use (patches for bug 8382 remove the use). To test: - go on acqui/parcel.pl?invoiceid=XXX - verify the error occurs (with firebug) - apply this patch - refresh the page - verify this error does not appear anymore - Verify there is no regression on this page Signed-off-by: Katrin Fischer Patch fixes the javascript error pointed out by Firebug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 23:20:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 21:20:11 +0000 Subject: [Koha-bugs] [Bug 10786] Javascript error on the parcel page: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10786 --- Comment #4 from Katrin Fischer --- The invoicenumber I used led to a table with over 5.000 entries - using one with less lines this tested nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 23:28:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 21:28:42 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #25 from Liz Rea --- A few legitimate questions - What happens if the borrower you are looking for to add to a list has a name that is fewer than 3 characters? It seems one cannot submit a search manually without the autocomplete. I'm not sure I'd fail it for this, but maybe worth thinking about. It seems also that you cannot add borrowers to a list that do not have a cardnumber. Feature, or bug? Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 23:33:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 21:33:16 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #26 from Liz Rea --- I also see that you *can* add borrowers with no cardnumber to a borrower list if you tick the box next to their name in a result list and -> add to list. patron_lists/list.pl?patron_list_id=2 < from here you cannot add borrowers with no cardnumber, so I think I've come to think this is a bug and not a feature. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 23:37:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 21:37:52 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 23:37:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 21:37:59 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20631|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 20714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20714&action=edit [PASSED QA] Bug 10649 - Upgrade DataTables and move scripts out of theme directory This patch adds an upgraded copy of the DataTables plugin to the jQuery plugin directory outside the theme directories. Copies of the old DataTables plugin scripts have been left in the old location while templates are incrementally updated. To test, visit each affected page in Acquisitions and confirm that table sorting still words correctly: - Acquisitions home - Acquisitions -> Late orders - Acquisitions -> Order search - Acquisitions -> Ordered (from table of available funds) - Acquisitions -> Spent (from table of available funds) - Acquisitions -> Vendor search - Acquisitions -> Vendor detail - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Basket -> Add order from existing record -> Add order from suggestion -> Add order from subscription -> Add order from external source -> Add order from staged file - Acquisitions -> Vendor -> Basket groups - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Vendor -> Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Acquisitions -> Vendor -> Receive shipments - Acquisitions -> Vendor -> Receive shipments -> Receipt summary (click invoice number) Also test one or more pages which have not been modified to confirm that old DataTables assets are still in place and working (ex: Circulation, Quotes editor, Saved reports, etc.) Signed-off-by: Srdjan Edit: Rebased on current master Signed-off-by: Katrin Fischer All tests und QA script pass. I found some smaller bugs, that also appeared on master without the patch applied. For some datatables I struggled with a result set of over 5.000 lines - there is room for improvement where a lot of data can be shown. testing notes: - Acquisitions home - Amounts don't sort correctly before and after the patch, see bug 10792. - Acquisitions -> Late orders - OK. - Acquisitions -> Order search - OK. - Acquisitions -> Ordered (from table of available funds) - OK. - Acquisitions -> Spent (from table of available funds) - OK. - Acquisitions -> Vendor detail - OK. - Acquisitions -> Vendor -> Basket - OK. - Acquisitions -> Vendor -> Basket -> Add order from existing record - Datatables seems not to be in use here? -> Add order from suggestion - OK. -> Add order from subscription - OK. -> Add order from external source - OK. -> Add order from staged file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 28 23:39:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Aug 2013 21:39:17 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 --- Comment #12 from Katrin Fischer --- (In reply to Katrin Fischer from comment #10) > I am almost done with testing, but the last one gives me a lot of trouble, > even with the patch for 10786 applied: > > - Acquisitions -> Vendor -> Receive shipments -> Receipt summary (click > invoice number) > > /cgi-bin/koha/acqui/parcel.pl?invoiceid=2 > > Having almost 6.000 orders in that table might factor into that. Owen, could > you take a look at 10786 and that page again? Using smaller result set and the patch from 10786 the page tested was ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 03:40:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 01:40:16 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #15 from Campbell Reid-Tait --- Created attachment 20715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20715&action=edit Bug 6149 - Stopwords for Result Highlighting This patch adds a system preference to control stopwords used to prevent operators and other 'minor' words from being highlighted in search results when the OpacHighlightWords syspref is enabled Signed-off-by: Campbell Reid-Tait -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 03:43:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 01:43:53 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20543|0 |1 is obsolete| | CC| |campbellreidtait at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 03:46:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 01:46:36 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #16 from Campbell Reid-Tait --- Works on OPAC. Followup patch to add same stopwords to Staff Client Search Results page, still needed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 04:15:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 02:15:50 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |campbellreidtait at gmail.com --- Comment #25 from Campbell Reid-Tait --- [ALT 2/3] Bug 9043: Changes to the advanced search page (6.67 KB, patch) 2013-08-13 14:59 UTC, Jonathan Druart Failed to apply. Applying: Bug 9043: Changes to the advanced search page Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 05:38:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 03:38:33 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |campbellreidtait at gmail.com --- Comment #30 from Campbell Reid-Tait --- Some Problems i have found. 1) After paying a fine when offline the fine amount becomes NaN. 2) For previous checkouts for a pratron the title and barcode fields have the wrong infomation in them (ie they have been swapped.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 05:48:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 03:48:25 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 05:57:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 03:57:59 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |campbellreidtait at gmail.com --- Comment #51 from Campbell Reid-Tait --- Patch does not apply. Bug 8236 Block renewing for overdue items (25.44 KB, patch) 2013-06-07 10:19 UTC, Koha Team Lyon 3 Applying: Bug 8236 Block renewing for overdue items Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging reserve/renewscript.pl Auto-merging opac/opac-user.pl Auto-merging members/moremember.pl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging circ/circulation.pl Auto-merging C4/ILSDI/Services.pm Auto-merging C4/Circulation.pm Failed to merge in the changes. Patch failed at 0001 Bug 8236 Block renewing for overdue items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 05:58:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 03:58:43 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 07:01:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 05:01:41 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Campbell Reid-Tait changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |campbellreidtait at gmail.com --- Comment #36 from Campbell Reid-Tait --- Did not apply at first. Needed to solve some conflicts. Could not seem to add any new archtypes. But that might just be me doing somthing wrong. Also on the Modify Professional patron page, on the sidebar for the Clubs and services label there is an extra "> at the start. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 08:11:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 06:11:22 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #51 from Katrin Fischer --- >From Melia's description this would be quite useful, but Kyle stated later that some of it was not implemented as described. Can you clarify? I think for a global system preference it would not be useful without using the enumchrom field. If it does not depend on it, it would be better in the circulation matrix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 08:29:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 06:29:35 +0000 Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #6 from David Cook --- (In reply to Galen Charlton from comment #2) > Curious about the use case for this -- are there folks who are not actually > deleting bibs, but instead setting the Leader/05 to 'd'? If so, why? Or is > this somehow arising from record imports? I've wondered about this before as well. I've known cataloguers to switch the Leader/05 to 'd' before, but I've never been 100% certain what is done with the records after that. I think the first step was to suppress them in the OPAC, and that after that...I'm not sure. I wonder if a cronjob is the best idea. After all, if the record has been set to Leader/05 'd' rather than straight up deleting it...perhaps there is a reason why they still want it around? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 09:45:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 07:45:41 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 09:45:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 07:45:46 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18729|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart --- Created attachment 20716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20716&action=edit Bug 8236 Block renewing for overdue items If any of patron's document is late, renewal can be allowed, blocked on every checked out items or only on overdue ones. The renewal remains nevertheless possible for the librarian checking the Override renewal limit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 09:49:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 07:49:50 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 09:49:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 07:49:54 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20317|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 20717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20717&action=edit [ALT 2/3] Bug 9043: Changes to the advanced search page New syspref: OpacAdvSearch. This syspref is multivalued and you can add or remove some elements on the adv search page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 09:50:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 07:50:07 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20318|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 20718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20718&action=edit [ALT 3/3] Bug 9043: Add the dropdown check list jquery plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 10:19:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 08:19:13 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|paul.poulain at biblibre.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 10:51:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 08:51:24 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #53 from Fridolyn SOMERS --- This patch removes the variable $issue from C4/ILSDI/Services.pm : --- a/C4/ILSDI/Services.pm +++ b/C4/ILSDI/Services.pm @@ -561,11 +561,10 @@ sub RenewLoan { return { code => 'RecordNotFound' } unless $$item{itemnumber}; # Add renewal if possible - my @renewal = CanBookBeRenewed( $borrowernumber, $itemnumber ); + my ($blockallitems,$reasonwhy,$overduesblockrenew) = HasAnyRenewalToBeBlocked($borrowernumber,undef); + my @renewal = $blockallitems ? (0, $reasonwhy) : CanBookBeRenewed( $borrowernumber, $itemnumber, undef, $overduesblockrenew ); if ( $renewal[0] ) { AddRenewal( $borrowernumber, $itemnumber ); } - my $issue = GetItemIssue($itemnumber); - # Hashref building my $out; $out->{'renewals'} = $issue->{'renewals'}; Is this normal? This variable is still used in the script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 11:00:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 09:00:56 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #54 from Jonathan Druart --- Fridolyn, Yes you are right. I just rebased the patch against master, this deletion existed in the precedent patch. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 11:53:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 09:53:59 +0000 Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- I could imagine that happens in a union catalog setting or for electronic ressources where you get new records while others are removed from the licensed package. I have recently been working on documentation on when a record can be deleted safely, there are a lot of things you want to take into account there to make sure you don't accidentally lose important data: - Does the record have items? - Are the items checked out? - Are the items on hold? (holds can be cancelled) - Is there an open order in acquisitions for this record? - Are there subscriptions for this record? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 12:03:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 10:03:09 +0000 Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421 --- Comment #8 from Magnus Enger --- (In reply to Katrin Fischer from comment #7) > I have recently been working on documentation on when a > record can be deleted safely, there are a lot of things you want to take > into account there to make sure you don't accidentally lose important data: Once upon a time I tried to collect all bugs related to deleting records below Bug 8149 - Deleting Records/Biblios Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 12:27:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 10:27:39 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #17 from Martin Renvoize --- Hi Campbell, It should all be in the one patch, including the staff client piece... I can see it's still in the patch you signed off from the diffs.. Could you give any errors you see if it's really not working? Martin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 14:01:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 12:01:38 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20716|0 |1 is obsolete| | Status|Failed QA |Needs Signoff Assignee|koha at univ-lyon3.fr |fridolyn.somers at biblibre.co | |m --- Comment #55 from Fridolyn SOMERS --- Created attachment 20719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20719&action=edit Bug 8236 - Prevent renewing if overdue or restriction I revised the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 14:35:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 12:35:29 +0000 Subject: [Koha-bugs] [Bug 10401] Add ability to merge invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10401 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20558|0 |1 is obsolete| | CC| |paola.rossi at cineca.it --- Comment #4 from Paola Rossi --- Created attachment 20720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20720&action=edit signed off patch The shipment cost of the resulting invoice is the shipment cost of the invoice I kept. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 14:39:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 12:39:28 +0000 Subject: [Koha-bugs] [Bug 10401] Add ability to merge invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10401 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 16:07:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 14:07:50 +0000 Subject: [Koha-bugs] [Bug 10801] New: ERROR: Barcode must be unique Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10801 Bug ID: 10801 Summary: ERROR: Barcode must be unique Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: yvcruz at uiwtx.edu QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Good Morning, I've added an item to an existing record, but am encountering issues when adding the barcode. I keep getting an error that states "barcode must be unique". I've tried several barcodes and I keep getting the same error. I'm at Incarnate Word High School and the record # is 15787. Please help, Yanira V. Cruz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 16:45:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 14:45:08 +0000 Subject: [Koha-bugs] [Bug 10801] ERROR: Barcode must be unique In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10801 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |nengard at gmail.com Resolution|--- |INVALID --- Comment #1 from Nicole C. Engard --- Yanira, I think this was meant to be a support ticket for ByWater so I'm going to move it there, you'll get an email about that. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 16:49:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 14:49:38 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 --- Comment #5 from Jonathan Druart --- Benchmarks with misc/load_testing/benchmark_staff.pl == With a remote DB == = Without the patch = Benchmarking with 20 occurences of each operation and 30 concurrent sessions Step 1: staff client main page 11512ms 1.737 pages/sec Step 2: catalog detail page 15142ms 1.32 biblios/sec Step 3: catalogue search 26549ms 0.753 biblios/sec Step 4: patron detail page 12248ms 1.632 borrowers/sec Step 5: patron search page 26901ms 1.486 borrowers/sec Step 6a circulation (checkouts) 8697ms 2.299 checkouts/sec Step 6b circulation (checkins) 8779ms 2.278 checkins/sec = With the patch = Benchmarking with 20 occurences of each operation and 30 concurrent sessions Step 1: staff client main page 11404ms 1.753 pages/sec Step 2: catalog detail page 13286ms 1.505 biblios/sec Step 3: catalogue search 19946ms 1.002 biblios/sec Step 4: patron detail page 10962ms 1.824 borrowers/sec Step 5: patron search page 24669ms 1.621 borrowers/sec Step 6a circulation (checkouts) 8856ms 2.258 checkouts/sec Step 6b circulation (checkins) 8623ms 2.319 checkins/sec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 16:59:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 14:59:43 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 16:59:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 14:59:46 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #27 from Kyle M Hall --- Created attachment 20721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20721&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons - Followup 3 * Borrower search works for names with < 3 characters * Borrowers without cardnumbers can now be added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 17:01:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 15:01:22 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #28 from Kyle M Hall --- Liz, all your comments and concerns are valid. Thanks! I believe this latest followup should address all those issues. Kyle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 18:44:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 16:44:44 +0000 Subject: [Koha-bugs] [Bug 9551] OPACMobileUserCSS being overriden by OPACUserCSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9551 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 18:49:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 16:49:23 +0000 Subject: [Koha-bugs] [Bug 8542] <> token produces a funny looking time on Reserves Slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8542 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Nicole C. Engard --- This is still an issue. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 18:49:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 16:49:53 +0000 Subject: [Koha-bugs] [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 19:39:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 17:39:29 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 19:39:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 17:39:32 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 --- Comment #1 from Kyle M Hall --- Created attachment 20722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20722&action=edit Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable patronimages 4) Verify patron images are still displaying correctly 5) Test deleting a patron image 6) Test adding a patron image from moremember.pl 7) Test adding a patron image from tools/picture-upload.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 19:39:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 17:39:39 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 19:50:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 17:50:17 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20722|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 20723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20723&action=edit Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable patronimages 4) Verify patron images are still displaying correctly 5) Test deleting a patron image 6) Test adding a patron image from moremember.pl 7) Test adding a patron image from tools/picture-upload.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 19:52:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 17:52:30 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20723|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20724&action=edit Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable patronimages 4) Verify patron images are still displaying correctly 5) Test deleting a patron image 6) Test adding a patron image from moremember.pl 7) Test adding a patron image from tools/picture-upload.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 19:55:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 17:55:22 +0000 Subject: [Koha-bugs] [Bug 10802] New: history.txt missing in packages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10802 Bug ID: 10802 Summary: history.txt missing in packages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz While bug 8911 fixed a problem regarding history.txt, a proper fix for packages is missing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 20:09:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 18:09:32 +0000 Subject: [Koha-bugs] [Bug 10802] history.txt missing in packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10802 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 20:09:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 18:09:40 +0000 Subject: [Koha-bugs] [Bug 10802] history.txt missing in packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10802 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 20725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20725&action=edit Bug 10802: Packages should install history.txt While bug 8911 fixed a problem regarding history.txt, a proper fix for packages was missing. This patch does three things: - Adds docs/history.txt to debian/koha-common.docs so it gets installed. - Moves the line installing the release notes from debian/koha-common.install to debian/koha-common.docs. - Adds an override_dh_compress entry in debian/rules that excludes history.txt from the dh_compress routine [1] To test: - Take a picture of how /usr/share/doc/koha-common looks. - Apply the patch and build a package [2]. - Upgrade and/or install using your package. - Look for the contents of the /usr/share/doc/koha-common, it should look the same, but history.txt must be there. - More > About Koha > Koha Timeline should show the history lines. Regards To+ [1] As 'man dh_compress' says, it is needed as every file considered for the doc dir that is plain text and is more than 4k size will be gzipped unless stated otherwise. We need it uncompressed for about.pl. [2] I did it for you, it can be grabbed here: http://ubuntu.unc.edu.ar/koha/koha-common_3.13-1~git+20130829144510.18a6876b_all.deb Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 20:18:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 18:18:14 +0000 Subject: [Koha-bugs] [Bug 10802] history.txt missing in packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10802 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 20:52:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 18:52:21 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #7 from Owen Leonard --- I believe this is ready for serious testing and, I hope, signoff. Check out the "bootstrap-opac" branch on Gitorious: http://gitorious.org/koha-dev/koha-dev -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 22:04:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 20:04:28 +0000 Subject: [Koha-bugs] [Bug 10803] New: "Make payment" in circ is not easily translatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803 Bug ID: 10803 Summary: "Make payment" in circ is not easily translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To test: - Choose a patron account - Add a fine to it - Switch to the checkout tab of the patron account - Check for the "Make payment" link. Make is not a link, but payment is. In translation this string is divided into: . %s Make payment Because of this it's difficult to translate it grammatically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 22:29:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 20:29:32 +0000 Subject: [Koha-bugs] [Bug 10803] "Make payment" in circ is not easily translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 22:29:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 20:29:35 +0000 Subject: [Koha-bugs] [Bug 10803] "Make payment" in circ is not easily translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803 --- Comment #1 from Katrin Fischer --- Created attachment 20726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20726&action=edit Bug 10803: "Make payment" in circ is hard to translate in circulation To test: - Choose a patron account - Add a fine to it - Switch to the checkout tab of the patron account - Check for the "Make payment" link. Make is not a link, but payment is. - Apply patch - Check again, now both words are linked. In translation this string is divided into: . %s Make payment Because of this it's difficult to translate it grammatically. The patch moves 'Make' into the link text, so that both words will show up together in translation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 29 22:29:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 20:29:43 +0000 Subject: [Koha-bugs] [Bug 10803] "Make payment" in circ is not easily translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 00:04:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 22:04:00 +0000 Subject: [Koha-bugs] [Bug 10804] New: SQL in categorie.pl should be moved into its own module and tested Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10804 Bug ID: 10804 Summary: SQL in categorie.pl should be moved into its own module and tested Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Adding, modifying and deleting patron categories is done in categorie.pl and untested. We should add a new module and unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 01:54:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Aug 2013 23:54:43 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #29 from Liz Rea --- One weirdness: http://img716.imageshack.us/img716/7357/rgya.png The add patron button looks a bit strange here. I wonder if you could just go with the word "Add" ? Nice to have, but not required to have (future maybe?) - add a borrower to a list from their detail or circulation screen (in the more menu perhaps?) Add a link or button to the list interface from the borrower result screen? Add a link or button to delete a list from a displayed list - (patron_lists/list.pl?patron_list_id=10 for example) The ability to export the contents of a patron list as CSV. Even cooler if you could choose which fields to export - I'm thinking of a method by which librarians could, without using saved reports, get a list of borrowers to email, for example. (I know! I know. Scope creep. Just writing it down so the idea doesn't get lost. :)) Functionally this works great - I'm still having trouble with the tests though: devlibrary-koha at wingardium-leviosa:/home/liz/koha-src/koha$ prove t/db_dependent/PatronLists.t t/db_dependent/PatronLists.t .. 1/9 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_devlibrary`.`patron_lists`, CONSTRAINT `patron_lists_ibfk_1` FOREIGN KEY (`owner`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO patron_lists ( name, owner) VALUES ( ?, ? )" with ParamValues: 0='Test List 1', 1=1] at Koha/List/Patron.pm line 121 # Looks like you planned 9 tests but ran 2. # Looks like your test exited with 255 just after 2. t/db_dependent/PatronLists.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 7/9 subtests Test Summary Report ------------------- t/db_dependent/PatronLists.t (Wstat: 65280 Tests: 2 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 9 tests but ran 2. Files=1, Tests=2, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.52 cusr 0.02 csys = 0.57 CPU) Result: FAIL Of note, and possibly extremely relevant, is that my failure results came from an *upgraded* database, and not a fresh one. All tests pass on a fresh database with only the sample data. I'm putting this in failed qa only because I'd like an answer about the upgraded DB tests - assuming that is all ok, I'm happy to sign off on this as-is. Thanks for your continued work, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 03:34:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 01:34:00 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #37 from David Cook --- I created a "weekly mailing list" type feature as well recently. I haven't uploaded it yet (due to time constraints and possible intersection with this patch), but it seems to be a bit different. I'm wondering...why would the mailing list be for new "items" rather than new "bibliographic records"? In my case, I opted for the latter, as I thought it made more sense to email people when a new record has been catalogued as it represented a completely new material that they might find interesting. If you send mailing lists based on items, couldn't you be receiving emails about items that already exist in the system? Or do you only send out emails for new items for a bib where there haven't been items before? I could see that being quite useful. The downside of my feature is that you might add a record but not have any items attached, so while people would know about the new record, they wouldn't be able to really "use" it. Could you explain a bit more about how the mailing lists work, Kyle? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 08:56:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 06:56:53 +0000 Subject: [Koha-bugs] [Bug 10805] New: Notice- Item check out /check in notice Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10805 Bug ID: 10805 Summary: Notice- Item check out /check in notice Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: prajeeshb77 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 20727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20727&action=edit Koha-Notice in PDF format Problem in item checkout and check in notice. If two items issue / retrun continousely the details of the first item is displayed in the notice but the second items details are not displaying. Please find the attachment for details anyone please help me to correct this problem -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 09:26:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 07:26:28 +0000 Subject: [Koha-bugs] [Bug 10805] Notice- Item check out /check in notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10805 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Prajeesh, I think your problem is caused by removing some markers that are responsible for creating the list: ---- <>... ---- Try puttig back in those ---- and see if it fixes your problem? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 09:30:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 07:30:57 +0000 Subject: [Koha-bugs] [Bug 10806] New: The staff benchmark script does not check authentication failure Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10806 Bug ID: 10806 Summary: The staff benchmark script does not check authentication failure Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 09:31:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 07:31:04 +0000 Subject: [Koha-bugs] [Bug 10806] The staff benchmark script does not check authentication failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 09:31:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 07:31:31 +0000 Subject: [Koha-bugs] [Bug 10806] The staff benchmark script does not check authentication failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 09:31:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 07:31:34 +0000 Subject: [Koha-bugs] [Bug 10806] The staff benchmark script does not check authentication failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10806 --- Comment #1 from Jonathan Druart --- Created attachment 20728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20728&action=edit Bug 10806: The staff benchmark script does not check authentication failure. Currently, if you launch the script misc/load_testing/benchmark_staff.pl, it always displays "Authentication successful" or continue to execute the script even if nothing is done. This patch checks if the url is right and if the authentication is correctly done. Test plan: Suppose that a correct login/pwd is koha/koha 1/ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://admin.koha.local/cgi-bin/koha/ --password="koha" --user="koha" should produce: Authentication successful ... Step 1 ... 2/ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://admin.koha.local/cgi-bin/koha/ --password="KOHA" --user="KOHA" should produce: Authentication failure: bad login/password 3/ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://admin.kobe.local/cgi-bin/koha/ --password="koha" --user="koha" should produce: Authentication failure: 500 Can't connect to admin.kobe.local:80 (Bad hostname) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 09:42:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 07:42:09 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #12 from Jonathan Druart --- (In reply to Katrin Fischer from comment #9) > Hm, as there is some progress on DBIX integration now, I think it might be > worth to put some more thought into this. Putting this "In Discussion" to > get some more opinions. It appears that no opinion comes, so must this patch be lost in the hole of the discussion status? I would prefer to change the status in order to others developers see it on the bugs list. I worked some hours on this refactoring and, as I already said, even if someone wants to write a package using DBIx for authorised values this patch will help him/her! I added unit tests to the new package, I clarified a lot of dirty code: I don't understand the goal to block this patch in discussion for a long time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 09:47:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 07:47:57 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #13 from Jonathan Druart --- Created attachment 20729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20729&action=edit Bug 10363: UT: execute tests into a transaction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 09:48:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 07:48:43 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #14 from Katrin Fischer --- Hi Jonathan, I didn't intend to block it for a long time - just seeking out opinions. Maybe 'adding new modules' could be discussed next Tuesday? I have filed a bug for categorie.pl yesterday - which also needs a new module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 09:52:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 07:52:53 +0000 Subject: [Koha-bugs] [Bug 10807] New: OPAC: There is no authority search history Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Bug ID: 10807 Summary: OPAC: There is no authority search history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 09:56:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 07:56:58 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 10:53:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 08:53:16 +0000 Subject: [Koha-bugs] [Bug 10808] New: Thesaurus search form does not correspond to current search query Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10808 Bug ID: 10808 Summary: Thesaurus search form does not correspond to current search query Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When cataloging a field defined with a thesaurus, an authority search popup is displayed with a search from. Once operators, values and sort selected in this form the search can be performed. The bug is that the values entered are kept but not the selected operators and sort. The same bug was existing in authorities module, solved by Bug 8692. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 10:53:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 08:53:25 +0000 Subject: [Koha-bugs] [Bug 10808] Thesaurus search form does not correspond to current search query In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10808 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8692 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 10:53:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 08:53:25 +0000 Subject: [Koha-bugs] [Bug 8692] Authorities search form does not correspond to current search query In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8692 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10808 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 11:44:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 09:44:17 +0000 Subject: [Koha-bugs] [Bug 10808] Thesaurus search form does not correspond to current search query In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10808 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 20730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20730&action=edit Bug 10808 - Thesaurus search form does not correspond to current search query See commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 11:46:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 09:46:08 +0000 Subject: [Koha-bugs] [Bug 10808] Thesaurus search form does not correspond to current search query In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10808 --- Comment #2 from Fridolyn SOMERS --- Created attachment 20731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20731&action=edit Bug 10808 - Formatting auth_finder.pl Follow up for perltidy and other format changes. Note that there is an important change : call to get_template_and_user moved at begining of script because it checks authentication. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 11:46:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 09:46:22 +0000 Subject: [Koha-bugs] [Bug 10808] Thesaurus search form does not correspond to current search query In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10808 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 13:09:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 11:09:07 +0000 Subject: [Koha-bugs] [Bug 9578] Error when search and sort by Title/Dates/Call number/Author/Popularity In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9578 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 13:56:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 11:56:44 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19174|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 20732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20732&action=edit Bug 10500 - Improve isbn matching when importing records Test Plan: 1) Catalog a record with the ISBN "0394502884 (Random House)" 2) Export the record, edit it so the ISBN is now "0394502884 (UnRandomHouse)" 3) Using the record import tool, import this record with matching on ISBN. 4) You should not find a match 5) Apply this patch 6) Run updatedatabase.pl 7) Enable the new system preference AggressiveMatchOnISBN 8) Repeat step 3 9) The tool should now find a match -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 14:21:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 12:21:36 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20058|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 20733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20733&action=edit Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 14:25:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 12:25:26 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #1 from Jonathan Druart --- Created attachment 20734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20734&action=edit Bug 10807: Add an authority search history for the OPAC Like biblio, this feature provides an authority search history. This history is available for connected and disconnected user. If the user is not logged in Koha, the history is stored in a cookie named 'KohaOpacRecentSearches'. The search history feature is now factorized in a new module. This patch adds: - 1 new db field search_history.type. It permits to distinguish the search type (biblio or authority). - 1 new module C4::Search::History. It deals with 2 different storages: db or cookie - 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t - 1 new behavior: the 'Search history' link (on the top-right corner of the screen) is always displayed. Test plan: 1/ Switch on the 'EnableOpacSearchHistory' syspref. 2/ Go on the opac and log out. 3/ Launch some biblio and authority searches. 4/ Go on your search history page. 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Delete all your history (cross on the top-right corner) 11/ Check that all your history search is empty. 12/ Launch some biblio and authority searches. 13/ Login to your account. 14/ Check that all previous searches are displayed. 15/ Launch some biblio and authority searches. 16/ Check that these previous searches are displayed under "Current session". 17/ Play with the 4 delete links (current / previous and biblio / authority). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 14:25:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 12:25:23 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 14:27:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 12:27:44 +0000 Subject: [Koha-bugs] [Bug 10769] Simplify clearing of input fields when duplicating a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10769 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20683|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20735&action=edit Bug 10769 - Simplify clearing of input fields when duplicating a patron When duplicating a patron record an onclick event is added to many fields in order to make then clear when focused. This patch updates the template so that the logic for this can be simplified. A template variable is set based on the 'opduplicate' variable, and a class added to the relevant fields. All fields with that class are cleared on focus. Also changed are several markup issues which were causing validation errors. To test, find or create a patron record which has all standard text fields filled with data. Use the "duplicate" button on the detail view of that patron to initiate the duplication process. Focus on each field in the patron entry form in succession. Fields which contain data should be cleared in the same way they were before the patch. Also test a regular edit operation to confirm that fields are not cleared. Signed-off-by: Campbell Reid-Tait Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 14:27:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 12:27:41 +0000 Subject: [Koha-bugs] [Bug 10769] Simplify clearing of input fields when duplicating a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10769 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 14:35:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 12:35:59 +0000 Subject: [Koha-bugs] [Bug 10426] Remove unused sub GetCcodes from C4::Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 14:36:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 12:36:03 +0000 Subject: [Koha-bugs] [Bug 10426] Remove unused sub GetCcodes from C4::Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20518|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 20736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20736&action=edit Everything checks out. Still needs dependencies to pass qa before it could be pushed though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 14:55:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 12:55:30 +0000 Subject: [Koha-bugs] [Bug 9578] Error when search and sort by Title/Dates/Call number/Author/Popularity In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9578 --- Comment #1 from Dobrica Pavlinusic --- I can't reproduce this problem on current master. I'm not sure, but my suspicion is that it was fixed by Bug 4393: Scan Indexes results cannot be sorted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:07:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:07:10 +0000 Subject: [Koha-bugs] [Bug 10755] Add "Keyword as Phrase" to staff client advanced search indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20552|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20737&action=edit Bug 10755 - Add "Keyword as Phrase" to staff client advanced search indexes This patch adds a "Keyword as Phrase" index to the search options in the staff client. Test Plan: 1) Go to the Advanced Search in the staff client and click on the "Keyword" drop-down list. 2) Note that there is only a "Keyword" not a "Keyword as Phrase" option 3) Apply the patch 4) Reload the Advanced Search 5) Note that there is now a "Keyword as Phrase" option as well If you want to test the functionality...it will depend on your catalogue data. Basically, a phrase search will allow you to find "Keyword Adjacent To Keyword" rather than a more scattershot search that finds the keywords regardless of their position to each other. Signed-off-by: Owen Leonard Template change is correct, and in my tests the searching behavior was correctly modified: Using "keyword as phrase" returned only results where the terms were adjacent. Signed-off-by: Kyle M Hall Passes koha-qa.pl, trivial patch with no possible side effects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:07:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:07:07 +0000 Subject: [Koha-bugs] [Bug 10755] Add "Keyword as Phrase" to staff client advanced search indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:13:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:13:00 +0000 Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #12 from Kyle M Hall --- (In reply to Srdjan Jankovic from comment #11) > I've signed this off, but not sure how much sense it makes. It is just for > auto-complete, so used only for the checkouts. If you search eg patrons on > /members/member.pl it is not used. I agree. Independent branches already hides patrons from other branches, so having a separate system preference for this doesn't make much sense to me. Jonathan, can you think of any compelling reason we should have a separate system preference for this? I would consider the original functionality to be a bug, and this to be a bug fix. If you agree, a followup to remove the new system preference should be sufficient for this to pass qa. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:15:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:15:51 +0000 Subject: [Koha-bugs] [Bug 7709] Cover Images Template plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7709 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #2 from Fridolyn SOMERS --- Using a filter is odd I think. Maybe something more like : [% Cover.getImage( biblionumber ) %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:18:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:18:35 +0000 Subject: [Koha-bugs] [Bug 10809] New: use template branches plugin in serials search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809 Bug ID: 10809 Summary: use template branches plugin in serials search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com In serials-search.pl, branch name is computed using branch code and then passed to template. There is a new template plugin now for this : Koha::Template::Plugin::Branches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:21:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:21:20 +0000 Subject: [Koha-bugs] [Bug 10786] Javascript error on the parcel page: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20713|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 20738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20738&action=edit Bug 10786: Javascript error on the parcel page: YAHOO is not defined The include of the yui json file generates a js error: YAHOO is not defined. This file seems not to be in use (patches for bug 8382 remove the use). To test: - go on acqui/parcel.pl?invoiceid=XXX - verify the error occurs (with firebug) - apply this patch - refresh the page - verify this error does not appear anymore - Verify there is no regression on this page Signed-off-by: Katrin Fischer Patch fixes the javascript error pointed out by Firebug. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:21:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:21:30 +0000 Subject: [Koha-bugs] [Bug 10786] Javascript error on the parcel page: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:22:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:22:15 +0000 Subject: [Koha-bugs] [Bug 10809] use template branches plugin in serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 20739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20739&action=edit Bug 10809 - use template branches plugin in serials search See commit message. Very trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:22:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:22:20 +0000 Subject: [Koha-bugs] [Bug 10809] use template branches plugin in serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:22:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:22:29 +0000 Subject: [Koha-bugs] [Bug 10809] use template branches plugin in serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:27:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:27:47 +0000 Subject: [Koha-bugs] [Bug 10809] use template branches plugin in serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:31:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:31:07 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20068|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 20740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20740&action=edit Bug 10361: Add option to cleanup_database.pl to purge OPAC search history Add an option to cleanup_database.pl to purge the search_history entries older than X days. Test plan: - Apply patch - Check that your test DB has some entries a little older than 30 days and a few ones even older than that in search_history: SELECT * FROM search_history WHERE time < DATE_SUB( NOW(), INTERVAL 30 DAY ); If not, modify some existing entries. - Run cleanup_database with a fixed number of days (replace XX with something higher than 30) /misc/cronjobs/cleanup_database.pl --searchhistory XX - Check that entries older than XX days got deleted from search_history - Run without the day parameter /misc/cronjobs/cleanup_database.pl --searchhistory - Check that entries older than 30 days got deleted from search_history Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:31:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:31:21 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20258|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 20741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20741&action=edit Bug 10361: (follow-up) add tests for search history functions This adds tests for the new PurgeSearchHistory function and AddSearchHistory. GetSearchHistory is not tested due to its current broken state (see bug 10667). To test: [1] Run prove -v t/db_dependent/Search_SearchHistory.t [2] Verify that all tests pass. Signed-off-by: Galen Charlton Signed-off-by: Mirko Tietgen Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:31:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:31:18 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:42:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:42:20 +0000 Subject: [Koha-bugs] [Bug 10795] Improvements for GetOpenIssue in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:42:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:42:23 +0000 Subject: [Koha-bugs] [Bug 10683] CRUD routines in C4::Circulation need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 15:44:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 13:44:24 +0000 Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 16:17:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 14:17:49 +0000 Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 --- Comment #13 from Jonathan Druart --- (In reply to Kyle M Hall from comment #12) > (In reply to Srdjan Jankovic from comment #11) > > I've signed this off, but not sure how much sense it makes. It is just for > > auto-complete, so used only for the checkouts. If you search eg patrons on > > /members/member.pl it is not used. > > I agree. Independent branches already hides patrons from other branches, so > having a separate system preference for this doesn't make much sense to me. > > Jonathan, can you think of any compelling reason we should have a separate > system preference for this? I would consider the original functionality to > be a bug, and this to be a bug fix. Kyle, Yes you are right, I stupidly rebased this patch but it does not make sense for me neither. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 16:18:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 14:18:04 +0000 Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 16:18:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 14:18:07 +0000 Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20122|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 20742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20742&action=edit Bug 5904: ysearch.pl members improvements (Independent branches behaviour) Test plan: - Add a staff user foo in a library A - Add a staff user bar in a library B - log in as foo and try to search 'bar' - Switch on (Prevent) the new pref IndependentBranches - the search returns no result - log in as a superlibrarian - Check that you are allow to search all patrons. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 16:18:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 14:18:17 +0000 Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 16:35:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 14:35:47 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Tom McMurdo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thomas.mcmurdo at state.vt.us --- Comment #6 from Tom McMurdo --- This has been tested and appears to work. I sign off on it. Tom McMurdo Collections & Digital Initiatives Librarian Vermont Department of Libraries thomas.mcmurdo at state.vt.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 16:36:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 14:36:51 +0000 Subject: [Koha-bugs] [Bug 7382] normalization on isbn matching rule In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7382 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #5 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 10500 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 16:36:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 14:36:51 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 --- Comment #7 from Kyle M Hall --- *** Bug 7382 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 16:43:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 14:43:45 +0000 Subject: [Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide tab-completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 16:43:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 14:43:54 +0000 Subject: [Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide tab-completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 20743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20743&action=edit Bug 10003: bash-completion for koha-list and some other script This is an initial commit submitted for peer review. It implements bash-completion for the following commands: - koha-list - koha-enable - koha-disable - koha-email-enable - koha-email-disable - koha-enable-sip - koha-start-sip - koha-restart-sip - koha-stop-sip - koha-start-zebra - koha-stop-zebra - koha-restart-zebra It is implemented in a way that it removes already used or mutually exclusive parameters (instance names, option switches). I already have written completion for other (more complex) commands, But I belive a simpler patch is better to start with. IMPORTANT: this patch relies on having the koha-list command available in the path. Also 10622 is needed for the SIP-related option switches. To test: - Make sure you have bash-completion installed and enabled (IRC might help us if you encounter problems). - Apply the patch. Option 1: - Pick the debian/koha-common.bash-completion file and do $ cp debian/koha-common.bash-completion /etc/bash_completion.d/koha-common - Open a new bash shell (I do it opening a new terminal on my Ubuntu box). - Type one of the listed commands... And repeatedly press . - Enjoy, and signoff if you belive it is usable. Otherwise report back. Option 2: - run: $ . debian/koha-common.bash-completion - Type one of the listed commands... And repeatedly press . - Enjoy, and signoff if you belive it is usable. Otherwise report back. Tests: - Some koha-list option switches are mutually exclusive, -h should be available in any context - koha-enable should only autocomplete disabled instances - koha-disable should only autocomplete enabled instances - koha-email-enable should only autocomplete email-disabled instances - koha-email-disable should only autocomplete email-enabled instances - koha-*-zebra scripts should only autocomplete enabled instances. - koha-*-sip scripts should only autocomplete sip-enabled instances. Regards To+ Note: writing bash-completion routines is a bit hacky, I tried to make it the simplest way I could. Your comments are welcome. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 16:44:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 14:44:52 +0000 Subject: [Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide tab-completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10622 Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 16:44:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 14:44:52 +0000 Subject: [Koha-bugs] [Bug 10622] Add --sip and --nosip switches to koha-list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10003 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 16:53:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 14:53:28 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Melissa Lefebvre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20732|0 |1 is obsolete| | --- Comment #8 from Melissa Lefebvre --- Created attachment 20744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20744&action=edit Bug 10500 - Improve isbn matching when importing records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 16:54:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 14:54:04 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Melissa Lefebvre changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melissa at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 16:56:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 14:56:06 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Melissa Lefebvre changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melissa at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 16:56:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 14:56:27 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Melissa Lefebvre changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 17:04:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 15:04:51 +0000 Subject: [Koha-bugs] [Bug 10094] koha-list should have an --disabled option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10094 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 17:04:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 15:04:51 +0000 Subject: [Koha-bugs] [Bug 4876] Rewrite koha-* scripts in Perl, with error checking - omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4876 Bug 4876 depends on bug 10094, which changed state. Bug 10094 Summary: koha-list should have an --disabled option http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10094 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 17:04:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 15:04:51 +0000 Subject: [Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide tab-completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003 Bug 10003 depends on bug 10094, which changed state. Bug 10094 Summary: koha-list should have an --disabled option http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10094 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 17:25:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 15:25:37 +0000 Subject: [Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide tab-completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003 --- Comment #4 from Tom?s Cohen Arazi --- I have built a package for testing purposes. It's bug 10622 patches + this patch on top of master. It can be found here: http://es.koha-community.org/kc_files/koha-common_3.13-1~git+20130830120021.1417289e_all.deb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 17:38:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 15:38:59 +0000 Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |koha at univ-lyon3.fr Assignee|koha-bugs at lists.koha-commun |koha at univ-lyon3.fr |ity.org | --- Comment #1 from Koha Team Lyon 3 --- Created attachment 20745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20745&action=edit patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 18:13:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 16:13:53 +0000 Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461 --- Comment #2 from Koha Team Lyon 3 --- Test plan : 1. Create a new fund 2. Define different tax rate in "gist" in system preferences 3. Edit a vendor and add a tax rate and put List prices "Include tax" 4. Add a new basket and a new order at this vendor and on the new fund 5. Check the budget summary in acqui-home.pl, the total price of the order is add in the amount "ordered" of the new fund 6. Edit the vendor and changed List Prices "Don't include tax" 6. Check the budget summary in acqui-home.pl, the total price more the tax is add in the amount "ordered" of the new fund 7. Go back to the vendor and put Invoice prices: "Include tax" 8. Go to the receive shipments, receive your order 9. Check the budget summary in acqui-home.pl, the actual cost of the order is add in the amount "spent" of the new fund 10. Go back to the vendor and put Invoice prices: "Don't include tax" 11. 9. Check the budget summary in acqui-home.pl, the actual cost more the tax of the order is add in the amount "spent" of the new fund -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 18:20:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 16:20:18 +0000 Subject: [Koha-bugs] [Bug 10221] hold expiration doesn't show on patron's list of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10221 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #7 from Sophie MEYNIEUX --- Would it be possible to have it in 3.10 too ? One of our customer would be delighted :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 18:25:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 16:25:37 +0000 Subject: [Koha-bugs] [Bug 10624] koha-common.init should implement the 'status' option switch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10624 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 18:25:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 16:25:42 +0000 Subject: [Koha-bugs] [Bug 10624] koha-common.init should implement the 'status' option switch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10624 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 20746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20746&action=edit Bug 10624: 'status' option switch for the packages init script This patch makes the init script return the status of the relevant processes. It relies on the koha-list switches added by 10622, and is written on top of the patch from 10617 that cleaned the init script. To test: - Apply the patch (+ 10622 so the SIP part works), build package and install - Run $ service koha-common status Note: it can be tested just copying the debian/koha-common.init script to a server running koha-common instances and calling it $ ./koha-common.init status If you don't have a patched koha-list command it will fail to report SIP servers status. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 18:26:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 16:26:56 +0000 Subject: [Koha-bugs] [Bug 10624] koha-common.init should implement the 'status' option switch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10624 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 18:33:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 16:33:44 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 --- Comment #7 from Tom?s Cohen Arazi --- The followup for this is really simple -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 20:28:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 18:28:00 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #8 from Owen Leonard --- There is a problem with the OPAC non-XSLT detail page. Setting back to ASSIGNED while I work it out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 20:40:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 18:40:14 +0000 Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 20:45:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 18:45:10 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 30 21:38:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 19:38:50 +0000 Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored Assignee|jcamins at cpbibliography.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 31 01:13:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Aug 2013 23:13:53 +0000 Subject: [Koha-bugs] [Bug 10726] Default Unimarc framework in accordance with new edition of the Unimarc manual In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel --- Hi Sonia, is there a complete online reference for UNIMARC formats? I'm looking at your patch, for example you add 033 for authority framework. Now, according to http://www.ifla.org/node/7950/ 122, 127, 128, 333, 501, 502, 511, 512, 521, 522 and perhaps others are still missing. Sorry but I'm new to UNIMARC :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 31 04:13:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2013 02:13:37 +0000 Subject: [Koha-bugs] [Bug 10683] CRUD routines in C4::Circulation need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20689|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 20747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20747&action=edit [SIGNED-OFF] Bug 10683: CRUD routines in C4::Circulation need unit tests This patch adds some unit tests wrap in a transaction for C4::Circulation.pm. Circulation_Branch.t adds tests for routines which deal with branch_item_rules,branch_borrower_circ_rules, default_branch_circ_rules, default_circ_rules, default_branch_item_rules in the database. Circulation_issue.t adds tests for routines which deal with accountline and issues in the database. NOTE: Some commented tests have to be fixed, and some tests can be added.More, other routines of Circulation.pm are tested in the patches: 10692 UT: Routines about transfers in Circulation.pm need unit tests 10710 UT : OfflineOperation's routines in C4/Circulation.t need unit tests 10767 UT: Routines which interact with the table issuingrules in C4/Circulation need unit test Test plan: prove t/db_dependent/Circulation_issue.t t/db_dependent/Circulation_issue.t .. ok All tests successful. Files=1, Tests=16, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.40 cusr 0.02 csys = 0.44 CPU) Result: PASS prove t/db_dependent/Circulation_Branch.t t/db_dependent/Circulation_Branch.t .. ok All tests successful. Files=1, Tests=10, 2 wallclock secs ( 0.06 usr 0.00 sys + 1.02 cusr 0.06 csys = 1.14 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Comment: Well, I don't know exactly what to do with this, so I left it to QA a) prove t/db_dependent/Circulation_Branch.t works well and without erros b) prove t/db_dependent/Circulation_issue.t works without errors for me ONLY if I have a issuingrule for All, All with 1 as renewals allowed, in other cases it fails. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 31 04:14:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2013 02:14:09 +0000 Subject: [Koha-bugs] [Bug 10683] CRUD routines in C4::Circulation need unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 31 04:21:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2013 02:21:43 +0000 Subject: [Koha-bugs] [Bug 10795] Improvements for GetOpenIssue in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20690|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 20748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20748&action=edit [SIGNED-OFF] Bug 10795 - Improvements for GetOpenIssue in C4::Circulation This patch adds some improvements for the routine GetOpenIssue. Now, it verifies if the parameter is given (if not it returns undef) and it returns $sth->fetchrow_hashref() instead of a $issue. To test: prove t/db_dependent/Circulation_issue.t t/db_dependent/Circulation_issue.t .. ok All tests successful. Files=1, Tests=16, 2 wallclock secs ( 0.06 usr 0.01 sys + 1.09 cusr 0.07 csys = 1.23 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Comment: Same situation as the one noted in comment of Bug 10683, test fails unless there is an issuingrule All, All with 1 as renewals allowed. With that condition, it succeeds No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 31 04:22:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2013 02:22:05 +0000 Subject: [Koha-bugs] [Bug 10795] Improvements for GetOpenIssue in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 31 14:42:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2013 12:42:09 +0000 Subject: [Koha-bugs] [Bug 3008] Increase 64k text limit for overdue notice file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3008 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #1 from Magnus Enger --- Is this still a problem? Sounds like a major problem for large libraries... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 31 15:24:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2013 13:24:11 +0000 Subject: [Koha-bugs] [Bug 10810] New: Fix synopsis for -html option to overdue_notices.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10810 Bug ID: 10810 Summary: Fix synopsis for -html option to overdue_notices.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Command-line Utilities Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org See http://perldoc.koha-community.org/misc/cronjobs/overdue_notices.html The synopsis says: -html Output html to file But the description of the -html option says: -html Produces html data. if patron does not have a mail address or -n (no mail) flag is set, an html file is generated in the specified directory. This can be downloaded or futher processed by library staff. If the -html option is given a filename as its argument it will fail without warning. Confusingly enough, the variable associated with the -html option is called $htmlfilename: 'html:s' => \$htmlfilename, But it is actually used as a path, and the filename is added to it: open $html_fh, ">",File::Spec->catdir ($htmlfilename,"notices-".$today->ymd().".html"); I'll do a patch that fixes the synopsis and makes the full description clearer, but leave the variable name alone, as changing it will not gain us much. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 31 15:37:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2013 13:37:46 +0000 Subject: [Koha-bugs] [Bug 10810] Fix synopsis for -html option to overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10810 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 31 15:37:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2013 13:37:49 +0000 Subject: [Koha-bugs] [Bug 10810] Fix synopsis for -html option to overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10810 --- Comment #1 from Magnus Enger --- Created attachment 20749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20749&action=edit Bug 10810 - Fix synopsis for -html option to overdue_notices.pl The synopsis for the -html option used to be: -html Output html to file but the argument to this option should actually be a directory, not a filename. This patch fixes the synopsis. To test: - Run perldoc misc/cronjobs/overdue_notices.pl - Check that the synopsis is as shown above - Apply this patch - Run perldoc misc/cronjobs/overdue_notices.pl - Check that - the synopsis asks for a directory, not a filename - that the description of the -html option further down in the perldoc now mentions the filename that the HTML file will be created with. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 31 16:09:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2013 14:09:38 +0000 Subject: [Koha-bugs] [Bug 10797] Move styling from element to CSS file for search input field in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10797 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 31 19:17:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2013 17:17:22 +0000 Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from mathieu saby --- Hello I made some tests on sandbox 2. I have a problem with the calculation of received prices. Ex : Vendor with - list price does not include tax - invoiced price includes tax - discount 10% - vat 5,5% - order created wuith list price : 10 eur - in my basket summary, I see a included ecost price of 9.49. That is correct :(10-1)-5.5(10-1)/100 = 9.495 - in acquisition home page, in "ordered" colum for this fund, I see 9.49 The problem appears when I receive the item : in reception page, Koha tells me the unit cost is 9.49. That is correct. but after the reception is done, in the acquisition home page shows "9" and not "9.49" an other page to check is pro.test2.biblibre.com/cgi-bin/koha/acqui/spent.pl page with the details of the orders received for a fund. I also see "9" instead of 9.49. M. Saby -- You are receiving this mail because: You are watching all bug changes.