) and the form
for making modifications.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 14:47:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 12:47:11 +0000
Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over
1000 lines long
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163
Owen Leonard
changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #5 from Owen Leonard ---
Also, please provide a proper test plan with any new patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:10:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 14:10:08 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nengard at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:14:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 14:14:07 +0000
Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|minor |normal
--- Comment #2 from Nicole C. Engard ---
upping severity on this because it causes a lot of confusion in the trainings
i'm doing lately
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:15:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 14:15:28 +0000
Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive
collection in OPAC search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nengard at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:17:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 14:17:19 +0000
Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nengard at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:19:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 14:19:31 +0000
Subject: [Koha-bugs] [Bug 10339] make the content of some help files
templates marflavor dependent
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10339
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nengard at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:20:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 14:20:57 +0000
Subject: [Koha-bugs] [Bug 10344] add RDA support to Koha
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nengard at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:22:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 14:22:03 +0000
Subject: [Koha-bugs] [Bug 10345] Copy number should be incremented when
adding multiple items at once
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10345
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nengard at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:30:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 14:30:51 +0000
Subject: [Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in
C4::ClassSource.pm
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gmcharlt at gmail.com
--- Comment #3 from Galen Charlton ---
(In reply to Srdjan Jankovic from comment #2)
> I propose something even better then - get rid of prepare() all together.
> For example:
>
> * GetClassSources():
> return $dbh->selectall_hashref("SELECT...", undef, 'cn_source');
>
> * AddClassSource()
> return $dbh->do("INSERT...", undef, @params)
>
> etc. How often are those used to get advantage of prepare_cached()?
> Good databases (tm) cache queries anyway, however not sure that MySQL does.
Getting rid of $sth->finish() and replacing prepare_cached() with prepare()
suffices as a minimal change, but doesn't preclude going further and using
selectall_hashref.
As far as the current patch is concerned, I do think it would be useful to at
least get rid of prepare_cached().
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:31:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 14:31:12 +0000
Subject: [Koha-bugs] [Bug 10349] Don't show empty Descriptions/Title notes
tabs in OPAC and staff
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nengard at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:51:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 14:51:20 +0000
Subject: [Koha-bugs] [Bug 6293] Add a button to the intranet for registering
with the Koha community
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6293
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nengard at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:02:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 15:02:24 +0000
Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19643|0 |1
is obsolete| |
--- Comment #11 from Kyle M Hall ---
Created attachment 20057
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20057&action=edit
Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now()
AS date).
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:02:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 15:02:47 +0000
Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:02:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 15:02:56 +0000
Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19644|0 |1
is obsolete| |
--- Comment #12 from Kyle M Hall ---
Created attachment 20058
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20058&action=edit
Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by
CAST(now() AS date).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:10:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 15:10:40 +0000
Subject: [Koha-bugs] [Bug 10498] Place Hold on Order
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:27:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 15:27:53 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:28:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 15:28:09 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #18894|0 |1
is obsolete| |
--- Comment #103 from Kyle M Hall ---
Created attachment 20059
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20059&action=edit
Bug 6874: Move uploadPath syspref to koha-conf.xml
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:44:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 15:44:33 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:44:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 15:44:46 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
--- Comment #104 from Kyle M Hall ---
Created attachment 20060
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20060&action=edit
Bug 6874 - File upload in MARC - QA Followup
* Renames uploadPath to upload_path to follow the standard naming
conventions in koha-conf which use underscores rather than camel case
* Remove reference to intranet-tmpl and replace with [% interface %]
required to pass qa
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 17:46:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 15:46:24 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20059|Bug 6874: Move uploadPath |[SIGNED-OFF] Bug 6874: Move
description|syspref to koha-conf.xml |uploadPath syspref to
| |koha-conf.xml
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:02:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:02:45 +0000
Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in
the Staff client to budget information.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #18598|0 |1
is obsolete| |
--- Comment #19 from Kyle M Hall ---
Created attachment 20061
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20061&action=edit
Bug 10013 - Ability to link directly from an item in the Staff client to budget
information.
To Test:
1) Create budget and fund under budget administration.
2) Create Vendor in acquisitons module.
3) Create basket under vendor.
4) Create order and choose budget while creating order.
5) Receive shipment.
6) Check in catalog details, in holding tab budget information column is
displayed
, on click it should display the budget information.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:03:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:03:17 +0000
Subject: [Koha-bugs] [Bug 9372] Automatic carriage return in message_queue
where content_type is html
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372
--- Comment #11 from Sophie MEYNIEUX ---
Created attachment 20062
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20062&action=edit
Bug 9372 : Replaces carriage return with
in printed html files for
overdues.
For pdf generation, html files need explicit
html tags. With this patch,
carriage return are replaced by
when letters are written into html
files.
Test plan :
- Ensure you've got at least one reader with overdue triggering notice
- Ensure that your notice template got html checked
- Run misc/cronjobs/overdue_notices.pl -v -n -html
and misc/cronjobs/printoverdues.sh
Without patch, the content of the letter is all on one line in pdf file
With the patch, pdf file is correctly formated
- remove your reader email
- Run misc/cronjobs/overdue_notices.pl -v -html
and misc/cronjobs/printoverdues.sh
Without patch, the content of pdf file is all on one line
with the patch, pdf file is correctly formated.
- restore reader email
- run misc/cronjobs/overdue_notice.pl -v -html
Verify that the a message has been generated in message_queue table
With or without patch, the message is the same
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:03:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:03:31 +0000
Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in
the Staff client to budget information.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #18600|0 |1
is obsolete| |
--- Comment #20 from Kyle M Hall ---
Created attachment 20063
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20063&action=edit
Bug-10013-New unit tests for routine: GetBudgetInfoFromItemnumber
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:05:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:05:01 +0000
Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in
the Staff client to budget information.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:05:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:05:51 +0000
Subject: [Koha-bugs] [Bug 9372] Automatic carriage return in message_queue
where content_type is html
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372
Sophie MEYNIEUX changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
CC| |sophie.meynieux at biblibre.co
| |m
Assignee|stephane.delaune at biblibre.c |sophie.meynieux at biblibre.co
|om |m
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:06:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:06:20 +0000
Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in
the Staff client to budget information.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #18600|1 |0
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:06:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:06:26 +0000
Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in
the Staff client to budget information.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20063|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:06:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:06:31 +0000
Subject: [Koha-bugs] [Bug 9372] Automatic carriage return in message_queue
where content_type is html
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372
Sophie MEYNIEUX changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14547|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:07:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:07:23 +0000
Subject: [Koha-bugs] [Bug 9372] Automatic carriage return in message_queue
where content_type is html
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372
Sophie MEYNIEUX changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14548|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:07:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:07:27 +0000
Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in
the Staff client to budget information.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #18600|0 |1
is obsolete| |
--- Comment #21 from Kyle M Hall ---
Created attachment 20064
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20064&action=edit
Bug-10013-New unit tests for routine: GetBudgetInfoFromItemnumber
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:09:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:09:56 +0000
Subject: [Koha-bugs] [Bug 9372] Automatic carriage return in message_queue
where content_type is html
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372
--- Comment #12 from Sophie MEYNIEUX ---
To take Kratin's comment into account, I propose this new patch that changes
carriage returns with
only in printed files if paramter file format is
html.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:10:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:10:09 +0000
Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in
the Staff client to budget information.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #22 from Kyle M Hall ---
The feature patch works as advertised, but I'm a bit confused by the unit test.
There is language in it that says it's a stub, it it's not. Additionally, it
doesn't mock any data, and fails for me. It makes invalid assumptions.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:17:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:17:09 +0000
Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to
pay fines screen if borrower has outstanding fines
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:19:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:19:27 +0000
Subject: [Koha-bugs] [Bug 10677] New: C4::Search::GetSearchHistory is broken
and unused
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10677
Bug ID: 10677
Summary: C4::Search::GetSearchHistory is broken and unused
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: gmcharlt at gmail.com
QA Contact: testopia at bugs.koha-community.org
C4::Search::GetSearchHistory does not work, as it contains a SQL syntax error:
SELECT FROM search_history WHERE...
Its broken state is not visible to users, however, because that routine is not
used -- opac-search-history.pl is doing a direct SQL query, which is not ideal.
GetSearchHistory should be fixed, then put in use.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:20:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:20:04 +0000
Subject: [Koha-bugs] [Bug 10365] Using published date on routing slips
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10365
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:20:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:20:16 +0000
Subject: [Koha-bugs] [Bug 10365] Using published date on routing slips
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10365
--- Comment #2 from Kyle M Hall ---
Created attachment 20065
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20065&action=edit
bug 10365 change routing slips to use date published rather than planned date
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:20:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:20:41 +0000
Subject: [Koha-bugs] [Bug 10472] Receipt by line or invoice
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10472
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:25:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:25:15 +0000
Subject: [Koha-bugs] [Bug 10645] Missing zebra languages in koha-create
manpage
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:25:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:25:26 +0000
Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge
search_history entries
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:25:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:25:24 +0000
Subject: [Koha-bugs] [Bug 10645] Missing zebra languages in koha-create
manpage
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19950|0 |1
is obsolete| |
--- Comment #2 from Kyle M Hall ---
Created attachment 20066
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20066&action=edit
Bug 10645: Missing zebra languages in koha-create manpage
There where some missing zebra language options in the man page for
koha-create.
Trivial string change.
To+
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:25:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:25:36 +0000
Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge
search_history entries
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #18839|0 |1
is obsolete| |
--- Comment #8 from Galen Charlton ---
Created attachment 20067
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20067&action=edit
Bug 10361: (follow-up) add tests for search history functions
This adds tests for the new PurgeSearchHistory function and
AddSearchHistory. GetSearchHistory is not tested due to its
current broken state (see bug 10667).
To test:
[1] Run prove -v t/db_dependent/Search_SearchHistory.t
[2] Verify that all tests pass.
Signed-off-by: Galen Charlton
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:26:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:26:47 +0000
Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge
search_history entries
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20067|0 |1
is obsolete| |
--- Comment #9 from Galen Charlton ---
Created attachment 20068
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20068&action=edit
Bug 10361: Add option to cleanup_database.pl to purge OPAC search history
Add an option to cleanup_database.pl to purge the search_history
entries older than X days.
Test plan:
- Apply patch
- Check that your test DB has some entries a little older than 30 days
and a few ones even older than that in search_history:
SELECT * FROM search_history WHERE time < DATE_SUB( NOW(), INTERVAL 30 DAY );
If not, modify some existing entries.
- Run cleanup_database with a fixed number of days (replace XX with
something higher than 30)
/misc/cronjobs/cleanup_database.pl --searchhistory XX
- Check that entries older than XX days got deleted from search_history
- Run without the day parameter
/misc/cronjobs/cleanup_database.pl --searchhistory
- Check that entries older than 30 days got deleted from search_history
Signed-off-by: Galen Charlton
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:27:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:27:16 +0000
Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge
search_history entries
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361
--- Comment #10 from Galen Charlton ---
Created attachment 20069
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20069&action=edit
Bug 10361: (follow-up) add tests for search history functions
This adds tests for the new PurgeSearchHistory function and
AddSearchHistory. GetSearchHistory is not tested due to its
current broken state (see bug 10667).
To test:
[1] Run prove -v t/db_dependent/Search_SearchHistory.t
[2] Verify that all tests pass.
Signed-off-by: Galen Charlton
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:27:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:27:59 +0000
Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge
search_history entries
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361
--- Comment #11 from Galen Charlton ---
I've signed off on the patch and added a follow-up that adds some tests.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:31:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:31:02 +0000
Subject: [Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:31:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:31:16 +0000
Subject: [Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19673|0 |1
is obsolete| |
--- Comment #2 from Kyle M Hall ---
Created attachment 20070
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20070&action=edit
Bug 10593 - AuthoritiesLog should default to yes
This trivial patch set the default to 'yes' for this system preference.
To test,
On a clean install
- Navigate Home > Administration > Global System preferences > Logs
- AuthoritiesLog is set to "Don't log"
Apply the patch, install koha on a new DB.
- Navigate Home > Administration > Global System preferences > Logs
- AuthoritiesLog should be set to "Log"
Regards
To+
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:39:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:39:08 +0000
Subject: [Koha-bugs] [Bug 9372] Automatic carriage return in message_queue
where content_type is html
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:39:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:39:18 +0000
Subject: [Koha-bugs] [Bug 9372] Automatic carriage return in message_queue
where content_type is html
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20062|0 |1
is obsolete| |
--- Comment #13 from Kyle M Hall ---
Created attachment 20071
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20071&action=edit
Bug 9372 : Replaces carriage return with
in printed html files for
overdues.
For pdf generation, html files need explicit
html tags. With this patch,
carriage return are replaced by
when letters are written into html
files.
Test plan :
- Ensure you've got at least one reader with overdue triggering notice
- Ensure that your notice template got html checked
- Run misc/cronjobs/overdue_notices.pl -v -n -html
and misc/cronjobs/printoverdues.sh
Without patch, the content of the letter is all on one line in pdf file
With the patch, pdf file is correctly formated
- remove your reader email
- Run misc/cronjobs/overdue_notices.pl -v -html
and misc/cronjobs/printoverdues.sh
Without patch, the content of pdf file is all on one line
with the patch, pdf file is correctly formated.
- restore reader email
- run misc/cronjobs/overdue_notice.pl -v -html
Verify that the a message has been generated in message_queue table
With or without patch, the message is the same
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:48:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:48:32 +0000
Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and
clamissues
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:50:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:50:59 +0000
Subject: [Koha-bugs] [Bug 10668] Improve suggestion detail page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:51:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:51:11 +0000
Subject: [Koha-bugs] [Bug 10668] Improve suggestion detail page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20018|0 |1
is obsolete| |
--- Comment #3 from Kyle M Hall ---
Created attachment 20072
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20072&action=edit
Bug 10668 - Improve suggestion detail page
This patch makes several improvements to the suggestions template:
- Improved breadcrumbs and page title.
- Fixed a JavaScript error which appeared when viewing or editing a
suggestion.
- Added an 'Edit' and a 'Delete' button to the suggestion detail page.
- Corrected capitalization.
To test:
- Perform various operations with suggestions management and
confirm that page titles and breadcrumbs are correct.
- View the detail page for an individual suggestion and confirm that
the edit and delete buttons work correctly.
- Confirm that there are no JavaScript errors when viewing or editing a
suggestion, in particular when changing Acquisition information
(quantity, currency, price).
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:52:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:52:05 +0000
Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive
collection in OPAC search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320
--- Comment #28 from Jesse Weaver ---
Confirmed with Brendan. Yes, this code is all licensed under GPLv3+ and
copyright 2013 ByWater.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 18:52:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 16:52:53 +0000
Subject: [Koha-bugs] [Bug 10668] Improve suggestion detail page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668
--- Comment #4 from Kyle M Hall ---
Created attachment 20073
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20073&action=edit
Bug 10668 - Improve suggestion detail page - QA Followup
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:13:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 17:13:30 +0000
Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the
visibility of the content on the Advanced Search page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |kyle at bywatersolutions.com
--- Comment #20 from Kyle M Hall ---
Jonathan, your patches work quite well, but there is no way to disable all the
options at once. When I deslect them all, and hit the save button, I get the
"Nothing to save" message.
Not required, but it might be nice to implement something like
https://code.google.com/p/dropdown-check-list/ as a fair number of people may
not know about ctrl-click to select/deselect individual items.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:14:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 17:14:31 +0000
Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive
funds like new order form does
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #12507|0 |1
is obsolete| |
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:35:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 17:35:16 +0000
Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive
funds like new order form does
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:35:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 17:35:30 +0000
Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive
funds like new order form does
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19793|0 |1
is obsolete| |
--- Comment #6 from Kyle M Hall ---
Created attachment 20074
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20074&action=edit
Bug 8821 - Receive shipment page should hide inactive funds like new order form
This patch adapts the fund-handling code from neworderempty.pl
in order to limit the display of funds by default to active ones,
with the option to check a box to display all funds.
This patch also adds "(inactive)" to the display of funds on this and
the neworderempty.tt template because it seemed like that was useful
information.
To test, make sure you have both active and inactive funds.
Start the process of receiving a shipment. The "fund" option
in the receive shipment form should show only active funds.
Checking the "show all" checkbox should allow you to choose
from both active and inactive funds.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:43:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 17:43:04 +0000
Subject: [Koha-bugs] [Bug 10572] Add phone to message_transport_types table
for new installs
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:43:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 17:43:20 +0000
Subject: [Koha-bugs] [Bug 10572] Add phone to message_transport_types table
for new installs
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19548|0 |1
is obsolete| |
--- Comment #2 from Kyle M Hall ---
Created attachment 20075
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20075&action=edit
Bug 10572: Add phone to message_transport_types table for new installs
In connection to bug 4246 commit 591bae324d77d285b27dfa6e10dc7001671f53cc added
phone to the message_transport_types table in updatedatabase.pl
This should be done also for new installs via the .sql files of the web
installer.
I am adding it only to English now, basing this change upon the work in reports
10509 and 10520. (I discovered this tiny omission there too.)
Test plan:
Apply patches 10509/10520.
Run new install or run this particular sql file from command line.
Note: If you only run this particular file, you do not need patch 10509.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:56:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 17:56:55 +0000
Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in
webinstaller mysql files
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19310|0 |1
is obsolete| |
--- Comment #16 from Kyle M Hall ---
Created attachment 20076
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20076&action=edit
Bug 10509: Using i18n function for translation of MySQL web installer files
This patch makes the changes needed to progressively use a i18n function to
translate strings in the web installer's MySQL files. The English scripts may
contain fields like i18n(columnvalue); for English i18n(a) is a, but for the
other languages i18n(a) is the translation of a.
The corresponding script in the language folder contains the i18n definition.
The work is done in such a way that current installations are not affected.
Subsequent patches will make the changes in the .sql files themselves. This can
be done per folder, per language. Using the extension .i18n in the last
subfolder name triggers the new translation mechanism. (See also test plan.)
In Installer.pm the all_languages parameter is removed from load_sql_in_order.
This code was not used. This change also affects the call in install.pl.
The most important change is the use of a new subroutine _run_mysql_file in
load_sql. This new routine contains the above logic.
Although I also tested changing marc_framework_sql_list and
sample_data_sql_list, it proved imo to be easier (and more maintainable) to do
this via load_sql.
Test plan:
Since no .sql files are changed in this patch, please test if you can install
English and e.g. German (or another one) in the web installer without any
changes.
Bonus points for the following additional tests :)
They serve to illustrate the i18n concept more clearly.
1) Place in en/mandatory/userflags.sql around a few strings i18n('...').
Run English install again and check the userflags table. No changes expected.
2) Place in de-DE/mandatory/userflags.sql i18n around a few strings too. Also
precede the insert statements with this definition:
DROP FUNCTION IF EXISTS i18n;
CREATE FUNCTION i18n (d text) RETURNS text DETERMINISTIC RETURN concat(d,'xx');
Now run German install again; some of the userflag strings (with i18n) should
now end with xx.
3) Before retesting German install, make some changes:
Edit en/optional/sample_holidays.sql. Add i18n calls around strings.
Create an additional folder optional.i18n in de-DE.
Copy sample_holidays.sql and sample_holidays.txt from de-DE/optional.
Edit de-DE/optional.i18n/sample_holidays.sql. Remove all text! Add:
DROP FUNCTION IF EXISTS i18n;
CREATE FUNCTION i18n (d text) RETURNS text DETERMINISTIC
RETURN CASE d
WHEN 'Sundays' THEN 'Sonntag'
ELSE d END;
Now run German install again; in the optional part of the install mark
sample holidays (in the last section standing separately; do not confuse with
the other one). Check the repeatable_holidays table afterwards. The string
above should have been translated only, the others are still English.
Undo the changes in .sql files; remove optional.i18n folder.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:57:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 17:57:23 +0000
Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in
webinstaller mysql files
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:57:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 17:57:33 +0000
Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in
webinstaller mysql files
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19311|0 |1
is obsolete| |
--- Comment #17 from Kyle M Hall ---
Created attachment 20077
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20077&action=edit
Bug 10509: Followup for load_sql_in_order in unit tests
Although I assume that the unit tests in t/db_dependent/lib are actually
obsolete and should probably be removed, the two calls of load_sql_in_order
are updated to reflect the current parameter list. (The all_languages
parameter has been dropped.)
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:57:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 17:57:45 +0000
Subject: [Koha-bugs] [Bug 7257] Add a link to remove an individual title
from a list
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:58:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 17:58:16 +0000
Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files
for webinstaller
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19439|0 |1
is obsolete| |
--- Comment #9 from Kyle M Hall ---
Created attachment 20078
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20078&action=edit
Bug 10520: Add i18n function to en/mandatory mysql files
Main goal: Adds i18n calls around translatable columns.
Additionally: Removes backtics.
Adds column names in inserts (where missing).
Uses consistent style (based on my interpretation of coding guidelines).
Test plan:
Make sure that you apply this patch on top of the 10509 patches!
Run English mysql install.
Verify that you include all mandatory files.
Check if webinstaller does not report errors.
Inspect table contents via interface or mysql.
Search for a column not using i18n where you would expect translation.
Note: If you prefer to run the mysql files from command line, please make sure
now that you define a 'fake' i18n, doing nothing (see Installer.pm code).
Signed-off-by: Marcel de Rooy
Tested both ways myself.
Noticed that I missed one message_transport_type (phone) and one language
description (180 vs. 181). If needed, will handle these on a separate report.
They do not directly relate to this patch.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:58:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 17:58:43 +0000
Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files
for webinstaller
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 19:58:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Aug 2013 17:58:55 +0000
Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files
for webinstaller
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19440|0 |1
is obsolete| |
--- Comment #10 from Kyle M Hall ---
Created attachment 20079
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20079&action=edit
Bug 10520: Add i18n function to en/optional mysql files
Main goal: Adds i18n calls around translatable columns.
Additionally: Removes backtics.
Adds column names in inserts (where missing).
Uses consistent style (based on my interpretation of coding guidelines).
Removed some locking statements in sample_creator_data.
NOTE: Some scripts insert numbers in auto-increment columns. Although this
works, I would not prefer to do so.
This patch however is not meant to change that, so leaves them for now.
Test plan:
Make sure that you apply this patch on top of the 10509 patches!
Run English mysql install.
Verify that you include all OPTIONAL files (in the OTHER DATA section).
Check if webinstaller does not report errors.
Inspect table contents via interface or mysql.
Search for a column not using i18n where you would expect translation.
Note: If you prefer to run the mysql files from command line, please make sure
now that you define a 'fake' i18n, doing nothing (see Installer.pm code).
Signed-off-by: Marcel de Rooy
Tested all optional data via webinstaller.
Signed-off-by: Kyle M Hall