[Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
I'm still getting
fatal: sha1 information is lacking or useless (C4/SIP/Sip.pm)

Could you upload a new copy of the patch?

Also, a minor stylistic suggestions:
What do you think about changing

$encoding ||= q{};

my $cksum;

if ($encoding ne '') {
    $msg = encode($encoding, $msg);
}

to

$msg = encode($encoding, $msg) if ( $encoding );

my $cksum;

as it groups the code a bit more logically and tersely ( and maybe a picosecond
faster ). With this, the possible undef doesn't need to be converted to an
empty string, as there is no need for a string comparison.

-- 
You are receiving this mail because:
You are watching all bug changes.