[Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19439|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 20078
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20078&action=edit
Bug 10520: Add i18n function to en/mandatory mysql files

Main goal: Adds i18n calls around translatable columns.
Additionally: Removes backtics.
Adds column names in inserts (where missing).
Uses consistent style (based on my interpretation of coding guidelines).

Test plan:
Make sure that you apply this patch on top of the 10509 patches!
Run English mysql install.
Verify that you include all mandatory files.
Check if webinstaller does not report errors.
Inspect table contents via interface or mysql.
Search for a column not using i18n where you would expect translation.

Note: If you prefer to run the mysql files from command line, please make sure
now that you define a 'fake' i18n, doing nothing (see Installer.pm code).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested both ways myself.
Noticed that I missed one message_transport_type (phone) and one language
description (180 vs. 181). If needed, will handle these on a separate report.
They do not directly relate to this patch.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.