[Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588

--- Comment #10 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 20103
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20103&action=edit
[SIGNED-OFF] Bug 10588 - opac-topissues first branch always selected in filters

In OPAC most popular items page:
With user is logged-in his branch should be selected.
When a branch is manually selected and form is submitted, this branch should be
selected in results page.
When looking at HTML, you see that all options are selected in combobox.

This patch corrects by using the hidden input 'do_it' to distinguish form
display and no branch filter selected.

Test plan :
- Make sure there are issues on records created in the past 3 month
- Go to OPAC not logged-in
- Click on "Most popular"
=> You get to page with results, "All libraries" is selected
- Select a branch and submit
=> You get to page with results, the branch is selected [testing
opac-topissues.inc from]
- Select a branch and perform a search that does not have results (for example
an item type never issued)
=> You get to page without results, the branch is selected [testing
opac-topissues.tt form]
- Log-in with a user
- Click on "Most popular"
=> You get to page with results, user's branch is selected
- Select "All libraries" and submit
=> You get to page with results, "All libraries" is selected [testing
opac-topissues.inc from]
- Select "All libraries" and perform a search that does not have results (for
example an item type never issued)
=> You get to page without results, "All libraries" is selected [testing
opac-topissues.tt form]

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.