[Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643

--- Comment #6 from kenza <kenza.zaki at biblibre.com> ---
(In reply to Owen Leonard from comment #5)
> None of these "$sth->finish()" patches have a test plan. I assume there's no
> way to detect an improvement, but how can we confirm that this change hasn't
> broken anything?

For this patch , the t/db_dependent/ClassSource.t exists. So we can be sure
that nothing is broken by doing 'prove t/db_dependent/ClassSource.t' after
applying this patch:

t/db_dependent/ClassSource.t .. 1/24 attempting to use non-existent class
sorting routine routine1
t/db_dependent/ClassSource.t .. ok     
All tests successful.
Files=1, Tests=24,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.06 cusr  0.01
csys =  0.09 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.