[Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Yes, it's on bug 10663. Current state of things is that GetReserveStatus does:

- not return Filled (Finished) correctly, because it checks the wrong table.
- not return Reserved correctly because it leaves out lots of the logic
  that CheckReserves has to determine if an item can actually fill a hold and   
  totally ignores title level holds when only called with itemnumber.
- not return Waiting correctly, because the condition is wrong (see obsoleted
  partial fix patch on bug 10663)

I have spent hours on this as have others and a revert is IMO the best option
to fix the regression introduced by bug 9367. It was too late to revert it from
git, so doing it in smaller steps accompanied by unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.