[Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Aug 9 17:58:38 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |gmcharlt at gmail.com

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Comparing the acq.js with the new basketgroup.js reveals a bunch of diffs like
this:

-    var answer = confirm(MSG_CONFIRM_CLOSE_BASKETGROUP);
+    var answer=confirm(_("Are you sure you want to close this basketgroup?"));

-        alert(MSG_CLOSE_EMPTY_BASKET);
+        alert(_("Why close an empty basket?"));

-    cantprint.innerHTML = MSG_SAVE_BEFORE_PRINTING;
+    cantprint.innerHTML=_("You need to save the page before printing");

In other words, this patch effectively causes a partial regression on bug 7598.

Please try again; it may be better to start from scratch rather than to edit
the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list