[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 19767
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19767
Bug 10612 - Add ability to delete patrons with batch patron modification tool

Review of attachment 19767:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10612&attachment=19767)
-----------------------------------------------------------------

::: tools/modborrowers.pl
@@ +259,5 @@
> +                    { error => "fees_owed", borrower => $borrower } );
> +            }
> +            else {
> +                MoveMemberToDeleted($borrowernumber);
> +                DelMember($borrowernumber);

This is missing a call to C4::VirtualShelves::HandleDelBorrower.

Also, with the proposed patron purging cronjob (bug 10419) also in play, I am
getting concerned about the number of different places in the code that (a)
check whether a patron record is allowed to be deleted and (b) do the deletion,
particularly since the original patch series for bug 10419 had also missed
HandleDelBorrower.

-- 
You are receiving this mail because:
You are watching all bug changes.