[Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Aug 13 12:19:26 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Galen Charlton from comment #4)
> Comparing the acq.js with the new basketgroup.js reveals a bunch of diffs
> like this:
> 
> -    var answer = confirm(MSG_CONFIRM_CLOSE_BASKETGROUP);
> +    var answer=confirm(_("Are you sure you want to close this
> basketgroup?"));
> 
> -        alert(MSG_CLOSE_EMPTY_BASKET);
> +        alert(_("Why close an empty basket?"));
> 
> -    cantprint.innerHTML = MSG_SAVE_BEFORE_PRINTING;
> +    cantprint.innerHTML=_("You need to save the page before printing");
> 
> In other words, this patch effectively causes a partial regression on bug
> 7598.
> 
> Please try again; it may be better to start from scratch rather than to edit
> the patch.

It seems to be a merge error on the signed off patch. I will resubmit a new
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list