[Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #23 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment: 
Fine addition! I added a small (trivial) QA followup.
Code looks good to me. No complaints from koha-qa. 
Before passing QA on this one, I have still two (simple) requests in connection
with case insensitive pref names in koha-httpd.conf (easier use):

1) Would it be possible to make the check in Context.pm:
defined $ENV{"OVERRIDE_SYSPREF_$var"} 
case insensitive somehow?
Replace it perhaps by something like:
    my @k= grep {/OVERRIDE_SYSPREF_$var/i} keys %ENV;
    if ( @k ) {
        $value = $ENV{$k[0]};

2) Check in preferences.pl with any: Could this be case insensitive too?
 any { lc $name eq lc $_ } @override_syspref_names  ?

If you could add a followup for this, I will be happy to sign it off too :)

-- 
You are receiving this mail because:
You are watching all bug changes.