[Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325

--- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> ---
Marcel,

I've been talking to Galen about the case insensitivity for system preferences.
We are both of the opinion that it's not good and it should go away. It's
extremely odd in that the preference value is looked up in a case sensitive
fashion, but cached in all lowercase.

This situation where the first call to C4::Context->preference() *must* be
correctly cased, but any further calls do not have to be.

I had thought that it was possible that somewhere in the code base this
situation might occur, so I wrote a script to extract the preference strings
from all the calls to C4::Context->preference() anywhere in the code base. The
script proved to me that there are no incorrectly cased calls to preference().
I will attach it for your perusal.

So, in summary:
1) Galen and I both agree your followup to add case insensitivity for this
particular feature, as per your request, is not necessary. 
2) Galen and I both agree we should not cache the preferences in a case
sensitive fashion.
3) I have written a script that proves no system preferences are called in an
incorrectly cased manner.
3) My patch on it's own removes the case insensitivity from caching, while your
qa followup re-adds it. Do to points 2 and 3, I think it's best that we do not
use your followup ( except for the typo correction ), Though I do thank your
for thinking of it and providing a followup!

If that was the only issue of note, I believe it's now safe to pass QA on this!

-- 
You are receiving this mail because:
You are watching all bug changes.