[Koha-bugs] [Bug 10663] Holds never block renewals

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663

--- Comment #32 from Chris Cormack <chris at bigballofwax.co.nz> ---
(In reply to M. de Rooy from comment #31)
> QA Comment:
> I skipped the unit tests for now. They are not that critical. And see also
> my earlier comment on hardcoded assumptions.
> Attachment 20362 [details] is fine for me. But it leaves the problem in
> GetReserveStatus.
> So I do not mind pushing this patch, because it resolves the reported issue.
> But I think it would be better to repair the problem in GetReserveStatus.

I think undoing the regression created should be first priority, ie pushing
these patches because they undo the bad refactoring that created this problem

> For that reason I submitted attachment 20363 [details] [review]. I tested
> it, but I leave it to Galen if he wants another signoff on that one.

I think this should go on it's own bug, and go through the proper signoff and
qa process, separate to this. 

I am going to make a tshirt, REVERT REGRESSIONS !!! That should be our first
policy, get it back to the behaviour that used to work. 
Then try the refactor again, this time with unit tests, so that we dont just
bust things trying to be clever again.

However it is of course Galens call. 


> The last attachment just resolves a minor typo that I stumbled about when
> testing this..
> 
> Setting to Passed QA to attract the attention of RM.

-- 
You are receiving this mail because:
You are watching all bug changes.