[Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Aug 16 16:11:31 CEST 2013
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610
Galen Charlton <gmcharlt at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gmcharlt at gmail.com
--- Comment #12 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to Jonathan Druart from comment #11)
> (In reply to Kyle M Hall from comment #10)
> > Excellent idea! I wonder if there is any way to add a check for out of order
> > sysprefs in koha-qa.pl, after this patch has been pushed.
>
> Yep, it should certainly be possible to do something.
I like the idea of this patch, and will push it shortly unless I find something
wrong, but I'm opposed to putting a sorting requirement into koha-qa.pl.
Sorting the script provides a small convenience by reducing the chance of merge
conflicts, but doesn't per se provide a functional benefit. I'd really hate to
see a patch fail QA on account of a new syspref getting inserted in the "wrong"
place.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list