[Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610

--- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Galen Charlton from comment #12)
> (In reply to Jonathan Druart from comment #11)
> > (In reply to Kyle M Hall from comment #10)
> > > Excellent idea! I wonder if there is any way to add a check for out of order
> > > sysprefs in koha-qa.pl, after this patch has been pushed.
> > 
> > Yep, it should certainly be possible to do something.
> 
> I like the idea of this patch, and will push it shortly unless I find
> something wrong, but I'm opposed  to putting a sorting requirement into
> koha-qa.pl.  Sorting the script provides a small convenience by reducing the
> chance of merge conflicts, but doesn't per se provide a functional benefit. 
> I'd really hate to see a patch fail QA on account of a new syspref getting
> inserted in the "wrong" place.

I rather imagined that as a warning than a blocker stuff. The change could be
made by the QAer with a small followup if the pref is not inserted in the good
place.

-- 
You are receiving this mail because:
You are watching all bug changes.