[Koha-bugs] [Bug 10078] show location facet for all

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #4)
> I am not sure every library will be happy about this change. If I am not
> mistaken combining the branches and the location facet will give you 'wrong'
> results as always all items are taken into account for the search result. So
> if you your items look like this:
> 
> Item 1: Branch A, location C
> Item 2: Branch B, location D
> 
> And you limit on Branch A and location D, the record will still be found.
> This will always happen when you combine item related facets.
> 
> Maybe we need a way to hide this facet for libraries who don't want to offer
> it. It could be as simple as having ids for CSS or a pref that lets you
> specify which facets you want to show. 
> 
> I think the search could probably be improved using DOM, but I am not sure
> this has been done yet and it would also still not work for libraries using
> GRS-1.

I'm not sure that I understand your example, Katrin. 

1) If you limit on Branch A and location D, you should get no results in your
scenario. 

2) In what scenario would you be able to use both those facets? (Using the
Advanced Search, you could, but that's unrelated to the facets.) 

If you choose Branch A from the Libraries facet, you would only be presented
with location C as a Locations facet. If you choose location D, you would only
be presented with Branch B as a Libraries facet.

The only time where that would be different is if you had:

Item 1 (Bib #1): Branch A, location C
Item 2 (Bib #2): Branch B, location D
Item 3 (Bib #1): Branch A, location D

In that case, you could limit on Branch A and location D, and you would get a
search result for Bib #1 showing item availability for Item 1 and Item 3. 

In that sense, I suppose that could be a type of wrong result, because you
would only want to show availability for Item 3. 

I don't think it's an indexing issue though. From what I've seen so far, it
seems to me that DOM and GRS-1 fill the same indexes, they just do it in
different ways. 

In this case, I think the issue would be with how we're displaying items. If we
want to limit what item availability shows up in the search results, we would
need to start checking our limits when building item displays in the
"searchResults" sub.

I don't think that's really a blocker for this bug though, as I mentioned, that
same incorrect item availability would still occur by doing a Branch + Location
query in the Advanced Search. I think that would be a separate issue.

That said, I'm certainly in favour of including facet IDs for CSS and/or using
a system preference so that libraries can choose which facets to show.

-- 
You are receiving this mail because:
You are watching all bug changes.