[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #26 from Jonathan Druart <jonathan.druart at biblibre.com> ---
QA comment:

The code:
- Perltidies the new file please.
- Use the CPLv3 license:
  FAIL    opac/opac-shareshelf.pl
   FAIL      forbidden patterns
     forbidden pattern: Koha is now under the GPLv3 license (line 9)
- The new letter should be added to others languages.
- The new pl file contains a lot of routines. Some of them use global variables
which are not defined as global.
- Maybe SHARE_INVITATION_EXPIRY_DAYS should be a new syspref? Hum... or not.
- Note that ADDDATE is a mysqlism, but Koha doesn't offer a better way to do.

The ergonomic:
- The page opac-shelves.pl?display=privateshelves displays a link for editing
and deleting, but a button for sharing. Is it intentional?
- There is no back button if I enter a bad email address.

The feature:
The invitation is sent to the message queue. The doc suggests
process_message_queue.pl runs every 1 to 4 hours. We can imagine that a user
tells to his friend: "I just share a list with you. You will receive an
email!". The friend refresh, refresh, refresh his inbox and nothing append. The
guy will resent the invitation again and again :)
I have 2 suggestions:
* directly use the sendmail command.
* Add a check: if an invitation for this list and this email address has been
sent some time ago, an alert is raised and no new invitation is sent.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.