[Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625

--- Comment #8 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to Jonathan Druart from comment #6)
> Galen, yes you are right, \r\n is under windows and it worked before this
> patch.
> But \r (Mac OS) did not worked before.

Ancient versions of Mac OS, not recent ones.  Are there folks actually using
MacOS 9 or earlier with Koha?

> The sample file contains \r.
> I tested the \r\n too : I added a newline character after \r in order to
> have a \r\n and it still works with the patch.

DOS/Windows line endings also worked without the patch -- see commit
890f673d64e2.

Since the use of File::Slurp means loading the entire input barcode file into
memory, this patch also changes the performance characters of the inventory
tool when processing very large files.  Admittedly, this may not be a big deal
in practice, but I would appreciate confirmation as to whether there are
barcode scanners or other utilities that are *actually* producing files that
use \r as a delimiter.

-- 
You are receiving this mail because:
You are watching all bug changes.