[Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Aug 21 03:06:36 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
(In reply to M. de Rooy from comment #3)
> (In reply to comment #2)
> > I don't like all the whitespace changes in this patch. Making whitespace
> > changes as well as code/markup changes is generally speaking a violation
> > of coding guidelines. However, this is not a frequently-modified
> > template and a diff which ignores whitespace changes shows that the real
> > changes are minor and effective.
> > 
> > I'm signing off and correcting the commit message to include a
> > description of the fix and the test plan.
> 
> Do not like these whitespace changes too. Could the author resolve this
> please and make life easier for QA? Thanks!

If you use the -w flag to not show whitespace changes, you should be all right. 

However, I'm working on this patch again locally today, so I'll look at
uploading a new version with code changes in one patch and whitespace changes
in the other.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list