[Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15305|0                           |1
        is obsolete|                            |

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
Created attachment 20519
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20519&action=edit
Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE

Currently, the layout for the Edit/Add Layout screen of the Patron
Card Creator is in complete disarray, when viewed in Internet Explorer
(of any version).

The nav bar is pushed to the bottom of the page, every fieldset is
empty (as their contents have been pushed out into different parts
of the page), and the checkboxes don't work.

The cause appears to be some extraneous mark-up (a few extra fieldset
and li elements)and some missing mark-up (ol elements to wrap the list
elements, especially when nesting lists within each other and within
div elements).

---

This patch removes empty and extraneous fieldset and li elements. It
also adds ol elements to all of the nested li elements, which were
creating layout problems in IE, especially when they were interwoven
with div elements. IE had problems opening and closing tags,
which created some major chaos.

---

Test Plan:

Before applying the patch:

1) Open Koha using any version of Internet Explorer
2) Go to the Patron Card Creator in the Tools module
3) Go to Manage Layouts
4) Add or Edit a layout
5) Note that all the elements on the page are presented in haphazard
 fashion with the navbar pushed to the bottom of the page.

Apply the patch.

6) Refresh the page
7) Note that the elements are now laid out on the page in the same way
 that they would appear in a modern browser like Firefox or Chrome
 (look at the same page in one of those browsers to confirm).

(N.B. The exception is IE7. While the layout has been improved, it is
now displayed linearly (i.e. without the YUI grid system). I've opened
up Bug 10772 to start discussing this problem.)

-- 
You are receiving this mail because:
You are watching all bug changes.