[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--- Comment #26 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to Jonathan Druart from comment #25)
> Galen, I change the status to Passed QA. Like that, you will show this
> report in your list.
> 
> I can provide unit tests for changed routines but before, I would like to
> get your opinion on comment 18-22 and on this change in general. Thanks!

My general opinion of the change as a whole: I would hate to lose the foreign
key constraints, the change doesn't seem to have any user-visible benefit, and
I don't see that the goal of reducing the number of tables involved is worth
the risk of regressions.

I'm not fond of the use of '*' in issuing rules, either -- I'd rather that NULL
be usable to signal "don't care/matches any" and that brancode, itemtype, and
categorycode be FKs -- but composite UKs don't enforce uniqueness if one of the
values is NULL.  We could dispense with the composite PK on issuingrules,
perhaps, but then would have to write more code to ensure that duplicate rows
couldn't slip in.

-- 
You are receiving this mail because:
You are watching all bug changes.