[Koha-bugs] [Bug 8562] RandomizeHoldsQueueWeight ignored if StaticHoldsQueueWeight is empty.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8562

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #15 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Kyle M Hall from comment #14)
> > I do not think that this is correct. The branches are shuffled regardless of
> > the value of RandomizeHoldsQueueWeight. Perhaps better would be:
> > @branches_to_use ||= keys %{GetBranches()}; # (or the correct version of
> > that statement, since I didn't test my suggestion)
> > right after the definition of @branches_to_use?
> 
> The justification for this is that it is extremely unlikely that a library
> would want to fill holds from libraries in alphabetical order in the case
> that the library has not populated StaticHoldsQueueWeight. Do you believe
> this is an unreasonable assumption?

I tend to agree with Jared here. If the Randomize pref is not set, you should
not shuffle. Otherwise this pref is really useless. 
You have a point however. I think that what you say, more pertains to the
default values set for these prefs in Koha. Randomize should be 1 by default.
The description on the pref form could be improved/extended.

I also think you should take into account the '0' default value. Just interpret
it as all branches here (empty string as advertised). If we definitely want to
get rid of this zero, it could be removed completely on a new report.

-- 
You are receiving this mail because:
You are watching all bug changes.