[Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20157|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 20637
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20637&action=edit
[SIGNED OFF] Bug 10681: Inappropriate uses of finish() in C4::Circulation.pm

This patch gets rid of finish().

>From the man page

finish()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.