[Koha-bugs] [Bug 10789] New: Excessive and often incorrect use of finish in C4::Acquisitions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10789

            Bug ID: 10789
           Summary: Excessive and often incorrect use of finish in
                    C4::Acquisitions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

C4/Acquisitions.pm contains a lot of calls to finish. These seem to be copied
as magic by someone who is unaware of the usage (please read the DBI doc for
full details) In brief finish is only required to be called after a select
statement where you have not read back the full result set. It should never be
called after a non-select statement. In fact there are a couple of places in
C4::Acquisitions.pm where its not called where it should be. In practice a call
to finish in top level code is almost always always a bad sign.

Lets clean these up

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.