[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720

--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
> 2/ Step 8: The message concats 2 messages:
> 
>     Restricted: Patron's account is restricted until 04/08/2013 with the
> comment "im restricted im restricted2" View restrictions
> 
> message 1 is "im restricted" and message 2 is "im restricted2"

Hmm, I think I should add a newline between the messages, and use the TT filter
that will convert them to <br> tags. That should solve that.

> 4/ There is no comment for suspension in the borrower_debarments table.

The original functionality of suspensions did not have comments, so I did not
add one to the suspension. Do you have a suggestion for the message?

> 5/ Why don't you remove the debarred and debarredcomment field in the
> borrowers table?

The first few comments on this bug explain it. TL;DR: By keeping them, we have
to modify less code ( so fewer chances for bugs ) and it also makes everything
faster as we don't have to recalculate everything each time we check for
debarments, only when we modify debarments.

> I will provide a followup for unit tests

Thanks for the followup!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.