[Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20629|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 20662
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20662&action=edit
[PASSED QA] Bug 10641 - GetBooksellerWithLateOrders in C4::Bookseller.pm has
some incoherences

This patch fixes some incoherences of the routine GetBooksellerWithOrders.
Now it considers the field $estimateddeliverydateto and it replaces it by now()
only if it is undef.
More it doesn't test if $aqbookseller.deliverytime is not Null anymore but if
$deliverytime = null or undef, it replaces it by 0.
It also verifies if $delay is >= 0 and return undef if it is a negative value.

To Test:
Before, this routine sorts out the BookSellerWithLateOrders. If a Bookseller
did not specify a deliverytime, he would never appears in the list of
LateOrders.More if the field "Estimated delivery date to" was specified, it
didn't take care of the value and it returns the late order up to today's date.
Now, the returned list considers all the fields give and if the deliverytime of
the Bookseller is not specified, it calculates the late orders as if the
deliverytime is 0.By default , all booksellers which have orders in late until
today are listed unless "estimated delivery date to" is specified.

prove t/db_dependent/Bookseller.t
t/db_dependent/Bookseller.t ..
[Some warnings about uninitialized values]
WARNING: GetBooksellerWithLateOrders is called with a negative value at
C4/Bookseller.pm line 135.
t/db_dependent/Bookseller.t .. ok
All tests successful.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
All tests and QA script pass.

-- 
You are receiving this mail because:
You are watching all bug changes.