[Koha-bugs] [Bug 10810] New: Fix synopsis for -html option to overdue_notices.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10810

            Bug ID: 10810
           Summary: Fix synopsis for -html option to overdue_notices.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: magnus at enger.priv.no
          Reporter: magnus at enger.priv.no
        QA Contact: testopia at bugs.koha-community.org

See http://perldoc.koha-community.org/misc/cronjobs/overdue_notices.html

The synopsis says:

  -html         <filename>       Output html to file

But the description of the -html option says:

  -html

    Produces html data. if patron does not have a mail address or 
    -n (no mail) flag is set, an html file is generated in the specified 
    directory. This can be downloaded or futher processed by library staff.

If the -html option is given a filename as its argument it will fail without
warning. 

Confusingly enough, the variable associated with the -html option is called
$htmlfilename:

  'html:s' => \$htmlfilename,

But it is actually used as a path, and the filename is added to it:

  open $html_fh, ">",File::Spec->catdir
($htmlfilename,"notices-".$today->ymd().".html");

I'll do a patch that fixes the synopsis and makes the full description clearer,
but leave the variable name alone, as changing it will not gain us much.

-- 
You are receiving this mail because:
You are watching all bug changes.