From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 00:08:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Nov 2013 23:08:49 +0000 Subject: [Koha-bugs] [Bug 11325] New: Focus not on "Add Item" in Lists Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325 Bug ID: 11325 Summary: Focus not on "Add Item" in Lists Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: library at stas.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When viewing a list, the focus/cursor is no longer on the "add items" field below the list. Previously a user could simply scan or enter barcode numbers to add multiple items. Now a user must manually focus on this field for each added item, slowing list creation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 13:16:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 12:16:58 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #24 from mathieu saby --- Oups, I tested with french translation. I suppose that's why it did not work... Back to need sign off. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 13:31:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 12:31:35 +0000 Subject: [Koha-bugs] [Bug 11249] Add db indexes on borrowers names In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 13:57:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 12:57:27 +0000 Subject: [Koha-bugs] [Bug 9368] specific behavior of yr and acqdate indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9368 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #10 from mathieu saby --- Hello I discovered the problem recently and signaled it to Biblibre, who pointed to this bug... Not a big issue, but it must be fixed, for QP and non-QP instances... Maybe an alternative could be to suppress the ability to select a date with the dropdown list (I'm not sure that's very intuitive), and just use the special input field made for filtering by dates. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 14:02:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 13:02:23 +0000 Subject: [Koha-bugs] [Bug 11326] New: show more facets should not reload search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11326 Bug ID: 11326 Summary: show more facets should not reload search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org in opac and staff interface, "show more" facets relaaunch search. It's useless, as all facets were computed before. Facets should simply be hidden with css, and un-hidden when a user click on "show more" M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 14:02:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 13:02:39 +0000 Subject: [Koha-bugs] [Bug 11326] show more facets should not reload search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11326 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 14:30:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 13:30:54 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #25 from mathieu saby --- I set some overdue books for a patron. I ran overdue_notices.pl -n I applied the patch ran overdue_notices.pl -n again I had the same results as before the patch. => OK In the list of notices, I was able to define a new template for ODUE notices sent by SMS. => OK In Overdue rules, I was able to check one or serveral boxes (email/feed/phone/print/sms) for each patron category, and for letters 1,2,3 I submit the changes, and checked it was saved => OK But... I checked only the box "sms" for all my patron categories, and for the 3 letters. I ran overdue_notices.pl -n The results were the same as before : the original notice (made for email) was used, not the new notice I had defined for SMS. I ran overdue_notices.pl and check message_queue table The results were the same as before : the original notice (made for email) was used, not the new notice I had defined for SMS. => KO Maybe I'm doing something wrong? And, additional questions: Are "sms" and "phone" are supposed to be 2 different message carrier? And what about "feed" type ? I don't see how overdue messages can be sent by "feeds". So, if feed and phone type should be suppressed, could you provide an other patch for doing so ? (I don't consider it's part of this bug...). Failing QA for the "sms" notice template not being used in overdue_notices.pl. Could you take a look at that? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 14:31:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 13:31:03 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 14:33:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 13:33:23 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #26 from mathieu saby --- Note : my SMS template was just the text "SMS" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 20:06:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 19:06:58 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Hi there, I haven't tested it yet, but there I think it won't work for MARC21. While UNIMARC uses publicationyear, MARC21 uses copyrightyear by default to store the publication year from 260$c. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 20:14:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 19:14:57 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #7 from mathieu saby --- (In reply to Katrin Fischer from comment #6) > Hi there, I haven't tested it yet, but there I think it won't work for > MARC21. While UNIMARC uses publicationyear, MARC21 uses copyrightyear by > default to store the publication year from 260$c. The structure of the 2 marcflavor is the same (date in plain text in 260/210 + date in coded form). They should be indexed the same way. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 20:36:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 19:36:41 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #8 from Katrin Fischer --- I thnk this is a display problem here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 20:41:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 19:41:07 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #9 from Katrin Fischer --- What I meant to say is that we save the data into 2 different fields in the database, so one field is always empty depending on the marcflavour. Hope that explains it better :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 20:43:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 19:43:32 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #10 from mathieu saby --- I did not look the patch, I thought of Zebra and not of the db... I don't know well MARC21, but at a first glance, the date in 260/210 is not meant to be searchable, but displayed (as the dates in coded fields are supposed to be the same, but machine-readable). Am I wrong? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 20:49:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 19:49:52 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #11 from Katrin Fischer --- I think we are misunderstanding each other - the publication year data will be in a different field in a MARC21 database, so I think the SQL query changed here needs to take biblio.copyrightdate into account too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 22:40:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 21:40:15 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 22:51:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 21:51:59 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 --- Comment #9 from Chris Cormack --- I had a go at resolving this conflict, but can't, Katrin can you take a look please -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 23:07:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Dec 2013 22:07:51 +0000 Subject: [Koha-bugs] [Bug 11327] New: Course Reserves not hidden from More menu when disabled Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11327 Bug ID: 11327 Summary: Course Reserves not hidden from More menu when disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Course reserves show up in the global more menu in the staff client, even when course reserves is disabled. It should not show there if it's disabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 04:36:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 03:36:04 +0000 Subject: [Koha-bugs] [Bug 11328] New: local cover images in staff Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Bug ID: 11328 Summary: local cover images in staff Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org The local cover images don't show on the staff results. This is what was reported to me: It looks like the staff client search results is using the same localcovers.js that the OPAC search results does however it doesn't work because the two pages are formatted differently. Here is a jquery that solves it for now: $("#searchresults").ready(function(){ $("#searchresults table td").each(function(i){ td = $(this); var tdv = td.find("input[class^='selection']"); var linkv = tdv.attr("value"); var a = $("").attr('href', '/cgi-bin/koha/catalogue/imageviewer.pl?biblionumber=' + $(tdv).attr("value")); var img = $("").attr('src', '/cgi-bin/koha/catalogue/image.pl?thumbnail=1&biblionumber=' + $(tdv).attr("value")) if(linkv){ $(td).append(a); $(a).append(img); } }); }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 09:37:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 08:37:33 +0000 Subject: [Koha-bugs] [Bug 11329] New: Check for marc record in opac-showmarc Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 Bug ID: 11329 Summary: Check for marc record in opac-showmarc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: m.de.rooy at rijksmuseum.nl Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Instead of just running as_formatted, check if GetMarcBiblio returned a reference. If you e.g. did not pass an id, return 404 instead of 500. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 09:37:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 08:37:49 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 09:40:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 08:40:13 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 --- Comment #1 from M. de Rooy --- Created attachment 23231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23231&action=edit Bug 11329: Check for marc record in opac-showmarc Instead of just running as_formatted, check if GetMarcBiblio returned a reference. If you e.g. did not pass an id, return 404 instead of 500. Consistent with opac-export.pl Test plan: [1] Run opac-showmarc.pl with valid biblionumber in id parameter. [2] Remove id parameter from URL. You should get a 404 now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 09:40:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 08:40:29 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 09:47:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 08:47:17 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 --- Comment #2 from M. de Rooy --- Created attachment 23232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23232&action=edit Bug 11329: Check for marc record in catalogue/showmarc Intranet counterpart patch. Same check as in opac/opac-showmarc. Test plan: [1] Run showmarc.pl with valid biblionumber in id parameter. [2] Remove id parameter from URL. You should get a 404 now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:08:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 10:08:50 +0000 Subject: [Koha-bugs] [Bug 11069] increase title ranking in relevance when using QueryWeightFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069 --- Comment #5 from Fridolin SOMERS --- (In reply to mathieu saby from comment #4) You are looking at 225 and 410 fields. In default config those fields are indexed has "Title-series". This patch manages only "Title" index. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:49:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 10:49:41 +0000 Subject: [Koha-bugs] [Bug 11302] Template::output should deal with object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #6 from Jonathan Druart --- I was just a try. If it does not work, I reopen the initial report and close this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:50:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 10:50:26 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:50:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 10:50:27 +0000 Subject: [Koha-bugs] [Bug 9951] Resolve encoding problems where script parameters are not decoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9951 Bug 9951 depends on bug 6554, which changed state. Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:50:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 10:50:27 +0000 Subject: [Koha-bugs] [Bug 10070] History of anonymous searches is not kept In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Bug 10070 depends on bug 6554, which changed state. Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:50:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 10:50:27 +0000 Subject: [Koha-bugs] [Bug 10074] Encoding problems for login and installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10074 Bug 10074 depends on bug 6554, which changed state. Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:50:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 10:50:27 +0000 Subject: [Koha-bugs] [Bug 10019] Encoding problem with utf8 chars in userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10019 Bug 10019 depends on bug 6554, which changed state. Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:50:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 10:50:43 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:50:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 10:50:58 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23140|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:52:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 10:52:59 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #16 from Jonathan Druart --- (In reply to mathieu saby from comment #15) > error: The following untracked working tree files would be overwritten by > merge: > misc/cronjobs/bulk_transferts.pl This file does not exist in master. Remove it before applying the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:08:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 12:08:26 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Jonathan Druart --- Did you check the dependency? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:09:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 12:09:33 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22827|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 23233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23233&action=edit Bug 9807, followup: Reindent basketgroup.tt Basketgroup.tt is very hard to read. This patch simply reindents it. No visiable changes expected Regression test : - check the list of opened and closed basketgroups for a vendor is displayed properly - check an individual basketgroup (closed and opened) is displayed properly - check you can edit a basketgroup and save changes - check you can print and export a basketgroup - check you can close and reopen a basketgroup http://bugs.koha-community.org/show_bug.cgi?id=9807 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:11:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 12:11:17 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #24 from Martin Renvoize --- Works as expected.. the final patch really is just a indenting clean up. Patch still works, patches all still pass qa script and code looks much nicer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:21:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 12:21:44 +0000 Subject: [Koha-bugs] [Bug 11069] increase title ranking in relevance when using QueryWeightFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069 --- Comment #6 from mathieu saby --- (In reply to Fridolin SOMERS from comment #5) > (In reply to mathieu saby from comment #4) > You are looking at 225 and 410 fields. In default config those fields are > indexed has "Title-series". > This patch manages only "Title" index. Yes, that's what I understood, but in your 1st message you wrote "so that records with all searched terms in title, even not well ordered, are more relevant." So I imagined that if there are 3 records, with the 200 field of one them matching the searched terms, and only 225/410 fields matching in the 2 others, the record with the 200 matching the search terms would be the 1st in the results. But I suppose the algorithm is more complex than that (and the core of it is hardcoded in Zebra, isn't it?) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:22:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 12:22:40 +0000 Subject: [Koha-bugs] [Bug 11069] increase title ranking in relevance when using QueryWeightFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069 --- Comment #7 from mathieu saby --- By the way, does your patch works with QueryParser? Or does QP calculate relevance differently? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:27:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 12:27:04 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #27 from Jonathan Druart --- In fact the test plan is wrong. The 4th step is not for this patch. The changes for overdue_notices is made by bug 10832. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:28:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 12:28:04 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #5 from mathieu saby --- (In reply to Jonathan Druart from comment #4) > Did you check the dependency? Oh no, I did not see it! Sorry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:28:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 12:28:53 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #28 from Jonathan Druart --- (In reply to Jonathan Druart from comment #27) Test plan is right. Please see the test plan from the active patches, not obsolete ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:32:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 12:32:10 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #29 from mathieu saby --- I'll give a look later, but if the behavior of overdue_notices.pl is changed by an other patch, I suppose I will be able to sign off this one. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:32:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 12:32:43 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #17 from mathieu saby --- (In reply to Jonathan Druart from comment #16) > (In reply to mathieu saby from comment #15) > > error: The following untracked working tree files would be overwritten by > > merge: > > misc/cronjobs/bulk_transferts.pl > > This file does not exist in master. Remove it before applying the patch. Oups. OK, sorry for that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:58:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 12:58:08 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #25 from Martin Renvoize --- Passing QA for that final followup. It's a template tidy up which doesn't affect operation. It'll affect blame as it change whitespace (which can be ignored by -w) but also breaks lines. I'm not sure that discussion ever came to an end, but I don't see why the initial two patches can't get pushed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 14:10:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 13:10:17 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #26 from mathieu saby --- (In reply to Martin Renvoize from comment #25) > Passing QA for that final followup. It's a template tidy up which doesn't > affect operation. > > It'll affect blame as it change whitespace (which can be ignored by -w) but > also breaks lines. > > I'm not sure that discussion ever came to an end, but I don't see why the > initial two patches can't get pushed? Hello Discussion with whom? In fact, if someone really does not want this followup, of course I can suppress the patch. But I think the reindenting on this file was really needed and will make further changes easier ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 14:17:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 13:17:14 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #27 from Martin Renvoize --- Hi Mathieu, There were a few IRC converstaions and a thread on the mailing list about tidying the whole koha codebase at some point.. I think the final decision was to just do it as we go along instead of a massive change.. which is exactly what you've done here so is good.. I'de leave the patch in, now it's marked passed QA it'll pass by Galen attention and I'm sure he'll make a sensible decision either way. Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 14:20:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 13:20:09 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #28 from mathieu saby --- (In reply to Martin Renvoize from comment #27) > Hi Mathieu, > > There were a few IRC converstaions and a thread on the mailing list about > tidying the whole koha codebase at some point.. I think the final decision > was to just do it as we go along instead of a massive change.. which is > exactly what you've done here so is good.. > > I'de leave the patch in, now it's marked passed QA it'll pass by Galen > attention and I'm sure he'll make a sensible decision either way. > > Martin OK I remember having read - not to mix reindenting and new code in the same commit - not to do a patch only for reindenting So, as this bug changes some behavior in a template file, I think it is legitimate to add a followup for reindenting the file. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 15:14:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 14:14:16 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 15:14:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 14:14:20 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23030|0 |1 is obsolete| | Attachment #23033|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 23234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23234&action=edit [PASSED QA] Bug 11096: force XML syntax for Zconn and remove MARC::File::USMARC everywhere. This patch makes Koha <-> Zebra exchange speak XML instead of the current 'USMARC'. For that, it changes some bits in - C4::Context->Zconn - C4::Context-_new_Zconn Zebra's 'element' variable is set to "marcxml" to match our zebra config files. References to MARC::File::USMARC::decode are substituted for calls to the correct one [1] (i.e. MARC::Record::new_from_xml using an explicit 'UTF-8' encoding for the task. This patch also removes calls to the unsafe ZOOM::Record->render()[2] method. Due to this last change the code for building facets was rewritten. And for performance on the facets creation I pushed higher version dependencies for MARC::File::XML and MARC::Record (we rely on MARC::Field->as_string). - The FindDuplicates function was MARCXML-ized too. - Unit tests have been moved to expect MARCXML from Zebra as well. TODO: relevance still uses USMARC. Need advise on that. References to MARC::File::USMARC where replaced for the corresponding MARC::File::XML counterpart from AuthoritiesMarc.pm. - Authorities search should work as usual. - Set dontmerge to see AuthoritiesMarc::merge still works. Regards To+ [1] As a side effect some encoding problems got fixed in facets and record details. http://search.cpan.org/~gmcharlt/MARC-XML-1.0.1/lib/MARC/File/XML.pm#decode() [2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#render() Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Katrin Fischer Testing notes on second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 15:14:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 14:14:42 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #16 from Katrin Fischer --- Created attachment 23235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23235&action=edit [PASSED QA] Bug 11096: wrap MARC::Record->new_from_xml call with eval Catch situations where MARC::Record would croak for bad-formed records. To test: - Run prove t/db_dependent/Search.t - It will fail at test 65 [1] - Apply the patch, it will warn for some failing records, but the tests will run smoothly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba [1] a record that cannot be parsed by MARC::Record is simply skipped (bug 10684) Signed-off-by: Katrin Fischer - All tests and QA script pass after applying the patch. - Verfied that sample record is not searchable before applying patch, but can be searched without problems after applying it. - Tested authority searching still workds as expected. - Tested bilbiographic searching still works as expected. - Simple search, also truncated search terms - Facetting - Advanced search, also itemtype and pubyear limits - Tested dontmerge preference, editing a linked authority and confirming the change is made to the linked records as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 15:16:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 14:16:49 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #18 from Katrin Fischer --- Created attachment 23237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23237&action=edit [SIGNED OFF] Bug 11096: wrap MARC::Record->new_from_xml call with eval Catch situations where MARC::Record would croak for bad-formed records. To test: - Run prove t/db_dependent/Search.t - It will fail at test 65 [1] - Apply the patch, it will warn for some failing records, but the tests will run smoothly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba [1] a record that cannot be parsed by MARC::Record is simply skipped (bug 10684) Signed-off-by: Katrin Fischer - All tests and QA script pass after applying the patch. - Verfied that sample record is not searchable before applying patch, but can be searched without problems after applying it. - Tested authority searching still workds as expected. - Tested bilbiographic searching still works as expected. - Simple search, also truncated search terms - Facetting - Advanced search, also itemtype and pubyear limits - Tested dontmerge preference, editing a linked authority and confirming the change is made to the linked records as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 15:16:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 14:16:37 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23234|0 |1 is obsolete| | Attachment #23235|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 23236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23236&action=edit [SIGNED OFF] Bug 11096: force XML syntax for Zconn and remove MARC::File::USMARC everywhere. This patch makes Koha <-> Zebra exchange speak XML instead of the current 'USMARC'. For that, it changes some bits in - C4::Context->Zconn - C4::Context-_new_Zconn Zebra's 'element' variable is set to "marcxml" to match our zebra config files. References to MARC::File::USMARC::decode are substituted for calls to the correct one [1] (i.e. MARC::Record::new_from_xml using an explicit 'UTF-8' encoding for the task. This patch also removes calls to the unsafe ZOOM::Record->render()[2] method. Due to this last change the code for building facets was rewritten. And for performance on the facets creation I pushed higher version dependencies for MARC::File::XML and MARC::Record (we rely on MARC::Field->as_string). - The FindDuplicates function was MARCXML-ized too. - Unit tests have been moved to expect MARCXML from Zebra as well. TODO: relevance still uses USMARC. Need advise on that. References to MARC::File::USMARC where replaced for the corresponding MARC::File::XML counterpart from AuthoritiesMarc.pm. - Authorities search should work as usual. - Set dontmerge to see AuthoritiesMarc::merge still works. Regards To+ [1] As a side effect some encoding problems got fixed in facets and record details. http://search.cpan.org/~gmcharlt/MARC-XML-1.0.1/lib/MARC/File/XML.pm#decode() [2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#render() Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Katrin Fischer Testing notes on second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 15:28:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 14:28:32 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #38 from Paola Rossi --- Hello, Mathieu. I apply the patch against master 3.15.00.002. Rebuilding zebra indexes, an error appears: Rebuilding zebra indexes against master without patching, the error doesn't appear. The two notices, coming from opac.sbn.it:2100, DB nopac, are: Nilo, antico Nilo / Folco Quilici Il Nilo / Pier Domenico Boccardi So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:13:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 15:13:27 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23108|0 |1 is obsolete| | --- Comment #39 from mathieu saby --- Created attachment 23238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23238&action=edit Bug 11202 - Improve UNIMARC biblio indexing Sorry :( It's fixed. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:13:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 15:13:35 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:49:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 15:49:05 +0000 Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #18 from Galen Charlton --- Pushed to master. Thanks, Oliver! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:59:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 15:59:41 +0000 Subject: [Koha-bugs] [Bug 2693] Tagging: Add filter by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:06:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 16:06:29 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion --- Comment #6 from Jonathan Druart --- Galen, I suspect you had a mistake on updating the status :) It is not pushed to master but in discussion. Maybe should we never display the hour/minutes if it's 23:59? So we remove the dateonly flag and we don't need a new routine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:20:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 16:20:54 +0000 Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #40 from Galen Charlton --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:22:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 16:22:43 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 --- Comment #7 from Jonathan Druart --- Created attachment 23239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23239&action=edit Bug 11148: Followup only display the hours unless "23:59" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:23:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 16:23:03 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 --- Comment #8 from Jonathan Druart --- Something like that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 18:08:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 17:08:07 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 --- Comment #9 from Galen Charlton --- (In reply to Jonathan Druart from comment #8) > Something like that? Not as a default behavior -- I'd prefer that the caller explicitly ask for (say) date_only or as_due_date, not have the behavior of stripping off "23:59" be hardcoded. (Also, stripping off "23:59" doesn't work if the timeformat is 12hr). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 19:14:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 18:14:42 +0000 Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Janusz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 19:16:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 18:16:38 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Philippe and congratulations! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 19:17:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 18:17:14 +0000 Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Ketan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 20:19:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 19:19:47 +0000 Subject: [Koha-bugs] [Bug 4533] Add "duplicate item" link when editing items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4533 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov --- Comment #3 from Peggy Thrasher --- We would like this too! Peggy -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 22:15:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 21:15:44 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 22:15:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 21:15:47 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23219|0 |1 is obsolete| | --- Comment #46 from Srdjan Jankovic --- Created attachment 23240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23240&action=edit Bug 11077 - Correct silent warnings in C4/Auth.pm This gets rid of some more warnings. It also corrects a noisy ne condition. $userid = $retuserid if ( $retuserid ne ''); became $userid = $retuserid if ( $retuserid ); It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's patch, while correcting the problems found. This includes: my $q_userid = $query->param('userid') // ''; along with: my $s_userid = ''; and: my $s_userid = $session->param('id') // ''; Indentation does not reflect actual scoping. A missing system preference would have triggered a ubiquitous undef compare check failure message. This makes the flooding message more useful, so as to help correct it. The change to accomplish this was: my $pki_field = C4::Context->preference('AllowPKIAuth'); if (!defined($pki_field)) { print STDERR "Error: Missing AllowPKIAuth System Preference!\n"; $pki_field = 'None'; } Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 22:29:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 21:29:04 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #1 from Galen Charlton --- Not just notes -- most of the fields in the suggestion form (except for title) aren't using the Template Toolkit HTML filter. A combination of using C4::Scrubber and the HTML TT filter should provide belts and suspenders. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:15:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 22:15:00 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |chris at bigballofwax.co.nz Severity|major |critical --- Comment #2 from Chris Cormack --- Working on some patches for this now -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:36:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 22:36:59 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 --- Comment #3 from Chris Cormack --- Created attachment 23241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23241&action=edit Bug 11322 : XSS in suggestions To test 1/ Switch on purchase suggestions 2/ On the public interface (OPAC) add a suggestion, put html in every field 3/ In the staff interface go to the suggestions page /cgi-bin/koha/suggestion/suggestion.pl 4/ Notice the html is rendered 5/ Click on a suggestion, notice the html is rendered on the show page also 6/ Apply the patch, check these two pages again, html should now be escaped -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:48:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 22:48:30 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 --- Comment #4 from Chris Cormack --- Created attachment 23242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23242&action=edit Bug 11322 : XSS in suggestions - OPAC 1/ Add a suggestion in the opac, with lots of html 2/ View that suggestion in the OPAC, note the html is rendering 3/ Apply the patch 4/ Test again, in prog and bootstrap, no more rendered html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:53:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 22:53:12 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23241|0 |1 is obsolete| | --- Comment #5 from David Cook --- Created attachment 23243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23243&action=edit Bug 11322 : XSS in suggestions To test 1/ Switch on purchase suggestions 2/ On the public interface (OPAC) add a suggestion, put html in every field 3/ In the staff interface go to the suggestions page /cgi-bin/koha/suggestion/suggestion.pl 4/ Notice the html is rendered 5/ Click on a suggestion, notice the html is rendered on the show page also 6/ Apply the patch, check these two pages again, html should now be escaped Signed-off-by: David Cook Works as described. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:04:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:04:23 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:04:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:04:26 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 --- Comment #6 from Chris Cormack --- Created attachment 23244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23244&action=edit Bug 11322 : XSS - Scrub bad data before storing suggestions in the db 1/ In the public interface, add a suggestion containing html 2/ Save, notice the html is rendered (or if you have the other patches is displayed) 3/ Apply this paget 4/ Add another suggestion 5/ Notice the html is stripped -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:08:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:08:46 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23242|0 |1 is obsolete| | --- Comment #7 from David Cook --- Created attachment 23245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23245&action=edit Bug 11322 : XSS in suggestions - OPAC 1/ Add a suggestion in the opac, with lots of html 2/ View that suggestion in the OPAC, note the html is rendering 3/ Apply the patch 4/ Test again, in prog and bootstrap, no more rendered html Signed-off-by: David Cook Works as described. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:12:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:12:14 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23244|0 |1 is obsolete| | --- Comment #8 from David Cook --- Created attachment 23246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23246&action=edit Bug 11322 : XSS - Scrub bad data before storing suggestions in the db 1/ In the public interface, add a suggestion containing html 2/ Save, notice the html is rendered (or if you have the other patches is displayed) 3/ Apply this paget 4/ Add another suggestion 5/ Notice the html is stripped Signed-off-by: David Cook Works as described. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:12:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:12:35 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:16:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:16:11 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #4 from David Cook --- (In reply to mathieu saby from comment #3) > Note that there is currently a big issue for UNIMARC facets: > the facet build on type of document (equivalent of 942 in MARC21) is not > visible. > > That's because some libraries use 099$t for that, and others use other > fields like 210$b that are not made for that. > That was the main goal of my not-yet-written-patch for make facets > customisable... > > But maybe it could be fixed by telling UNIMARC ppl that from 3.16 version > onwards the type of document is stored in 099t, and provide a script for > copying types of documents from other fields to this one for non standard > configuration. > > Mathieu With zebra facets, it uses the index. So if both those marc tags are filling the same index, it should be fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:28:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:28:09 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 --- Comment #9 from Katrin Fischer --- I have followed the instructions and set up https, but I am confused by the results: OPAC Still running on localhost:8080, but the Amazon cover URL appears as https:// on the results page and on the details page. Intranet Now working with localhost and 442, but the Amazon cover URL is still http:// on the results and the details page. Liz, can you please check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:47:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:47:51 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #5 from mathieu saby --- (In reply to David Cook from comment #4) > (In reply to mathieu saby from comment #3) > > Note that there is currently a big issue for UNIMARC facets: > > the facet build on type of document (equivalent of 942 in MARC21) is not > > visible. > > > > That's because some libraries use 099$t for that, and others use other > > fields like 210$b that are not made for that. > > That was the main goal of my not-yet-written-patch for make facets > > customisable... > > > > But maybe it could be fixed by telling UNIMARC ppl that from 3.16 version > > onwards the type of document is stored in 099t, and provide a script for > > copying types of documents from other fields to this one for non standard > > configuration. > > > > Mathieu > > With zebra facets, it uses the index. So if both those marc tags are filling > the same index, it should be fine. I did not think of it... Of course ;-) So, it will really be a nice improvement for 3.16 if Zebra facets could be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:49:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:49:42 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #6 from David Cook --- I'm outlining below a rough guide to how to enable Zebra facetting. Note that this has nothing to do with Koha per se. This is just about setting up Zebra. The actual Koha code to make use of Zebra's facets will have to come after initial setup, and at the moment it's just not at the top of my list of priorities. First, take stock of which version of Koha you're running and note which type of indexing you're using (DOM or GRS1). Look for these two files in your /etc/zebradb/ folder: "retrieval-info-bib-dom.xml" "retrieval-info-bib-grs1.xml" If you can't find them, you're probably running an older version of Koha and you'll want to modify your "koha-conf.xml". If you do find them, the config in "koha-conf.xml" is only a fallback, so not necessary for testing. Step One: a) Edit the file that suits your version of Koha and method of indexing. (i.e. if you're running the latest Koha with dom, edit "retrieval-info-bib-dom.xml". If you're running the latest Koha with grs1, edit "retrieval-info-bib-grs1.xml". If you're running an older version of Koha, you're only using grs1 and you'll need to edit "koha-conf.xml" Step Two: a) Add lines like the following as children to the "" node (N.B. do not add them to the top as they will displace the default retrieval syntax setting. Add them at the bottom.): (N.B. Paul Poulain mentioned that the "0" register is a "raw"(?) register and that this should be used if you have issues with diacritics or non-Latin characters. I imagine that this needs to be set up in your records.abs or DOM XSLT.) (N.B. You can substitute any index in for "any" or "title". You can also use any register instead of "w" or "0", such as "p".) Step Three: a) Restart your Zebra server Step Four: a) Connect to Zebra using yaz-client (e.g. yaz-client open "unix:/zebra/test/var/run/zebradb/bibliosocket")(You can find your specific path by looking at the top of koha-conf.xml for a "listen" node with an ID of "biblioserver") b) Tell Zebra to use facets (e.g. elements zebra::facet::any:w,title:w,title:0) c) Do a search (e.g. find test) d) Show your results (e.g. show 1+1) e) You should now see a list of facets for your search results -- If you have any issues with these instructions, comment here, find me in the IRC channel or visit the sites that I'm linking below. -- For more information, visit the following links: http://www.indexdata.com/zebra/doc/zebra.pdf (Search in the document for "facet") http://lists.indexdata.dk/pipermail/zebralist/2007-July/001682.html (This is a discussion of setting up Zebra facets) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:51:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:51:03 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 --- Comment #9 from Katrin Fischer --- Created attachment 23247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23247&action=edit [PASSED QA] Bug 11322 : XSS in suggestions To test 1/ Switch on purchase suggestions 2/ On the public interface (OPAC) add a suggestion, put html in every field 3/ In the staff interface go to the suggestions page /cgi-bin/koha/suggestion/suggestion.pl 4/ Notice the html is rendered 5/ Click on a suggestion, notice the html is rendered on the show page also 6/ Apply the patch, check these two pages again, html should now be escaped Signed-off-by: David Cook Works as described. Signed-off-by: Katrin Fischer Passes all tests, thx Chris! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:51:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:51:07 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 --- Comment #10 from Katrin Fischer --- Created attachment 23248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23248&action=edit [PASSED QA] Bug 11322 : XSS in suggestions - OPAC 1/ Add a suggestion in the opac, with lots of html 2/ View that suggestion in the OPAC, note the html is rendering 3/ Apply the patch 4/ Test again, in prog and bootstrap, no more rendered html Signed-off-by: David Cook Works as described. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:51:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:51:10 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 --- Comment #11 from Katrin Fischer --- Created attachment 23249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23249&action=edit [PASSED QA] Bug 11322 : XSS - Scrub bad data before storing suggestions in the db 1/ In the public interface, add a suggestion containing html 2/ Save, notice the html is rendered (or if you have the other patches is displayed) 3/ Apply this paget 4/ Add another suggestion 5/ Notice the html is stripped Signed-off-by: David Cook Works as described. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:51:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:51:52 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:51:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:51:54 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23243|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:51:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:51:57 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23245|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:51:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:51:59 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23246|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:58:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2013 23:58:07 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #7 from David Cook --- Also note that you will have to individually set up each index that you want to use for facet queries. As per this email from an IndexData person: http://lists.indexdata.dk/pipermail/zebralist/2007-July/001694.html In general, this shouldn't case a problem, since we only use a short list of facets. However, it would create a barrier to allowing users to customize their results. In theory, we could list all or most of the available indexes in the Zebra config files. Then, we could use a system preference or a DB table to choose which indexes we want to use for facets. This would generate the "elements" string that we pass to Zebra everytime we want our facets. Actually, now that I think about it...that might not be a bad idea. We already have that Search.pm sub where we're manually keeping track of indexes, so we could keep that or use something similar to fill an HTML list and have that create our Zebra facet string. So long as we generate the string once and then use it multiple times...that should be all right. We could also have a hardcoded fallback string in case someone deletes the facet config in Koha or if their facet config is bad. Hmm. Ideas. Ideas. Ideas... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 01:09:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 00:09:52 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #8 from Jared Camins-Esakov --- (In reply to David Cook from comment #7) > Also note that you will have to individually set up each index that you want > to use for facet queries. > > As per this email from an IndexData person: > http://lists.indexdata.dk/pipermail/zebralist/2007-July/001694.html > > In general, this shouldn't case a problem, since we only use a short list of > facets. However, it would create a barrier to allowing users to customize > their results. This has to be changed in two places. In the server elements configuration, as described at that link, *and* an additional index has to be configured for each facet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 01:12:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 00:12:45 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #9 from M. Tompsett --- Could not this bug just get the zebra facets working, and then whatever needs to be done to filter be worked on in bug 10891? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 01:16:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 00:16:05 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #25 from M. Tompsett --- (In reply to mathieu saby from comment #2) > Hi Frederic > I was thinking of a syspref first. It would be easier for me to do (2 > sysprefs in fact, one for unimarc, the other for marc21/normarc) A Koha system can't be both unimarc and marc21/normarc at the same time. Why would you need two? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 01:23:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 00:23:03 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton --- Pushed to master. Thanks, Chris! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 02:55:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 01:55:50 +0000 Subject: [Koha-bugs] [Bug 11330] New: Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Bug ID: 11330 Summary: Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org There are many inconsistencies on field/subfield descriptions on MARC21 bibliographic frameworks. That fact makes very hard to translate frameworks accurately using an automated procedure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 02:56:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 01:56:09 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 04:32:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 03:32:19 +0000 Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23038|0 |1 is obsolete| | --- Comment #21 from M. Tompsett --- Created attachment 23250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23250&action=edit Bug 9055: Mandumah.com's multiple branch search, multiple branch security mod This mod creates the ability to search multiple branches using a jquery dropdown, instead of just one or all branches. This mod also replaces SearchMyLibraryFirst preference, giving three options: All = no change from standard koha setup. Preferhome = Prefers patron's home library (others may be searched), koha's current functionality of SearchMyLibraryFirst. Securehome = Only patrons' home library and other assigned libraries (if any) can be searched. With multiple instances of branchcode inside Borrower extended attributes, a patron can be given multiple branches to search within. The Securehome concept also includes the branch given in the apache enviroment of the host/virtualhost contacted, from OPAC_SEARCH_LIMIT = "branch: blah" This patch not only filters the GetBranches results, filtering the patrons ability to see other branches other than the ones given, it also filters the branches given in the limit branch: search options, so that even if a user manually inputted a branch, they are still only getting what they are ment to get. This enhancement would be useful for big libraries, in which its members would be restricted to searching and borrowing from a subset of its books. Overall, the multiple branch search dropdown should prove useful, even with unsecure installations. What is not included yet, is a method to decide what branches to show to a guest, not-logged-in, user. To use this patch, you need to create a branchcode Patron Extended Attribute, and have the patron your working with, have one or more branchcode extended attributes. So, total branches that patron will get: OPAC_SEARCH_LIMIT branch + Patron record home branch + whatever branchcodes you put into Borrower_attributes. You also need to set the preferences. The three new preferences to set are: - OPAC: SearchableBranches - Patrons: multibranch - Searching: MultiBranchSelect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 04:34:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 03:34:24 +0000 Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23250|0 |1 is obsolete| | --- Comment #22 from M. Tompsett --- Created attachment 23251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23251&action=edit Bug 9055: Mandumah.com's multiple branch search, multiple branch security mod This mod creates the ability to search multiple branches using a jquery dropdown, instead of just one or all branches. This mod also replaces SearchMyLibraryFirst preference, giving three options: All = no change from standard koha setup. Preferhome = Prefers patron's home library (others may be searched), koha's current functionality of SearchMyLibraryFirst. Securehome = Only patrons' home library and other assigned libraries (if any) can be searched. With multiple instances of branchcode inside Borrower extended attributes, a patron can be given multiple branches to search within. The Securehome concept also includes the branch given in the apache enviroment of the host/virtualhost contacted, from OPAC_SEARCH_LIMIT = "branch: blah" This patch not only filters the GetBranches results, filtering the patrons ability to see other branches other than the ones given, it also filters the branches given in the limit branch: search options, so that even if a user manually inputted a branch, they are still only getting what they are ment to get. This enhancement would be useful for big libraries, in which its members would be restricted to searching and borrowing from a subset of its books. Overall, the multiple branch search dropdown should prove useful, even with unsecure installations. What is not included yet, is a method to decide what branches to show to a guest, not-logged-in, user. To use this patch, you need to create a branchcode Patron Extended Attribute, and have the patron your working with, have one or more branchcode extended attributes. So, total branches that patron will get: OPAC_SEARCH_LIMIT branch + Patron record home branch + whatever branchcodes you put into Borrower_attributes. You also need to set the preferences. The three new preferences to set are: - OPAC: SearchableBranches - Patrons: multibranch - Searching: MultiBranchSelect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 04:35:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 03:35:27 +0000 Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23251|0 |1 is obsolete| | --- Comment #23 from M. Tompsett --- Created attachment 23252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23252&action=edit Bug 9055: Mandumah.com's multiple branch search, multiple branch security mod This mod creates the ability to search multiple branches using a jquery dropdown, instead of just one or all branches. This mod also replaces SearchMyLibraryFirst preference, giving three options: All = no change from standard koha setup. Preferhome = Prefers patron's home library (others may be searched), koha's current functionality of SearchMyLibraryFirst. Securehome = Only patrons' home library and other assigned libraries (if any) can be searched. With multiple instances of branchcode inside Borrower extended attributes, a patron can be given multiple branches to search within. The Securehome concept also includes the branch given in the apache enviroment of the host/virtualhost contacted, from OPAC_SEARCH_LIMIT = "branch: blah" This patch not only filters the GetBranches results, filtering the patrons ability to see other branches other than the ones given, it also filters the branches given in the limit branch: search options, so that even if a user manually inputted a branch, they are still only getting what they are ment to get. This enhancement would be useful for big libraries, in which its members would be restricted to searching and borrowing from a subset of its books. Overall, the multiple branch search dropdown should prove useful, even with unsecure installations. What is not included yet, is a method to decide what branches to show to a guest, not-logged-in, user. To use this patch, you need to create a branchcode Patron Extended Attribute, and have the patron your working with, have one or more branchcode extended attributes. So, total branches that patron will get: OPAC_SEARCH_LIMIT branch + Patron record home branch + whatever branchcodes you put into Borrower_attributes. You also need to set the preferences. The three new preferences to set are: - OPAC: SearchableBranches - Patrons: multibranch - Searching: MultiBranchSelect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 05:31:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 04:31:53 +0000 Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23252|0 |1 is obsolete| | --- Comment #24 from M. Tompsett --- Comment on attachment 23252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23252 Bug 9055: Mandumah.com's multiple branch search, multiple branch security mod I think my description is a little cleaner, but I've left the patch which I think is the one to rebase, and debug. Sadly, it failed to give me results: opac search happy - all libraries result count: (note the number) advanced search keyword = happy go to the library dropdown and select all then click search. BUSTED! All and Securehome settings busted. Preferhome works with my current system preference settings. Have fun debugging. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 05:32:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 04:32:18 +0000 Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 09:13:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 08:13:31 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 --- Comment #26 from mathieu saby --- (In reply to M. Tompsett from comment #25) > (In reply to mathieu saby from comment #2) > > Hi Frederic > > I was thinking of a syspref first. It would be easier for me to do (2 > > sysprefs in fact, one for unimarc, the other for marc21/normarc) > > A Koha system can't be both unimarc and marc21/normarc at the same time. Why > would you need two? Some facets can have sense in a unimarc system, other in a marc21 system (some coded fields only exists in unimarc, some new rda fields only exists in marc21 etc...) But you are right, I suppose we could have unique syspref with different content, depending on marcflavor choosen when you install Koha. Anyway, with the global rewriting of facets, I don't know if the idea of storing facets in a syspref will still be interesting. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 09:16:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 08:16:00 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #10 from mathieu saby --- > Actually, now that I think about it...that might not be a bad idea. We > already have that Search.pm sub where we're manually keeping track of > indexes, so we could keep that or use something similar to fill an HTML list > and have that create our Zebra facet string. > I thought this list of index in search.pm was going to be deprecated with the adoption of QueryParser ? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 09:18:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 08:18:23 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #11 from mathieu saby --- (In reply to David Cook from comment #6) > I'm outlining below a rough guide to how to enable Zebra facetting. Note > that this has nothing to do with Koha per se. This is just about setting up > Zebra. The actual Koha code to make use of Zebra's facets will have to come > after initial setup, and at the moment it's just not at the top of my list > of priorities. > > First, take stock of which version of Koha you're running and note which > type of indexing you're using (DOM or GRS1). > > Look for these two files in your /etc/zebradb/ folder: > "retrieval-info-bib-dom.xml" > "retrieval-info-bib-grs1.xml" > > If you can't find them, you're probably running an older version of Koha and > you'll want to modify your "koha-conf.xml". If you do find them, the config > in "koha-conf.xml" is only a fallback, so not necessary for testing. > > > Step One: > a) Edit the file that suits your version of Koha and method of indexing. > (i.e. if you're running the latest Koha with dom, edit > "retrieval-info-bib-dom.xml". If you're running the latest Koha with grs1, > edit "retrieval-info-bib-grs1.xml". If you're running an older version of > Koha, you're only using grs1 and you'll need to edit "koha-conf.xml" > > Step Two: > a) Add lines like the following as children to the "" node > (N.B. do not add them to the top as they will displace the default retrieval > syntax setting. Add them at the bottom.): > > > > > > (N.B. Paul Poulain mentioned that the "0" register is a "raw"(?) register > and that this should be used if you have issues with diacritics or non-Latin > characters. I imagine that this needs to be set up in your records.abs or > DOM XSLT.) > > (N.B. You can substitute any index in for "any" or "title". You can also use > any register instead of "w" or "0", such as "p".) > > Step Three: > a) Restart your Zebra server > > Step Four: > a) Connect to Zebra using yaz-client (e.g. yaz-client open > "unix:/zebra/test/var/run/zebradb/bibliosocket")(You can find your specific > path by looking at the top of koha-conf.xml for a "listen" node with an ID > of "biblioserver") > > b) Tell Zebra to use facets (e.g. elements > zebra::facet::any:w,title:w,title:0) > c) Do a search (e.g. find test) > d) Show your results (e.g. show 1+1) > e) You should now see a list of facets for your search results > > -- > > If you have any issues with these instructions, comment here, find me in the > IRC channel or visit the sites that I'm linking below. > > -- > > For more information, visit the following links: > > http://www.indexdata.com/zebra/doc/zebra.pdf (Search in the document for > "facet") > > http://lists.indexdata.dk/pipermail/zebralist/2007-July/001682.html (This is > a discussion of setting up Zebra facets) As DOM is now the new standard way of indexing, and GRS1 is going to be deprecated, maybe the work could be made only for DOM files? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:19:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 10:19:42 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:19:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 10:19:46 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23239|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 23253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23253&action=edit Bug 11148: Add a as_due_date parameter to the output_pref routine This parameter is a boolean, if true, the hours won't be displayed if the time is 23:59 (24hr format) or 11:59 PM (12hr format). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:59:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 10:59:42 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #34 from Jonathan Druart --- (In reply to mathieu saby from comment #33) > All these operations were possible with the permission (and with some > choices in sysprefs), and not possible without, except one operation : > checking out a document marked "PEGI 12" to a 4 year child > (I mapped biblioitems.agerestricted with 301a field, set the preference > AgeRestrictionMarker with "PEGI", and AgeRestrictionOverride to "Don't > allow") Thanks for testing Mathieu! The AgeRestrictionOverride pref has to be set to "Allow" if you want to override the age restriction, even if the new permission is set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:12:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:12:40 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22717|0 |1 is obsolete| | --- Comment #35 from mathieu saby --- Created attachment 23254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23254&action=edit [PATCH][SIGNED OFF] Bug 10863: Add 2 circulation permissions: force_checkout and lift_restriction Ok, so I sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:12:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:12:49 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:26:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:26:21 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think for consistency it also makes sense to have the descriptions the same on each framework. But also it will be really nice to have the marc frameworks nicely translatable with po files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:26:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:26:58 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #6 from Jonathan Druart --- Created attachment 23255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23255&action=edit Bug 11209: Check if a notice has been already sent today The previous patch checks if a notice has already been sent when the current notices has been sent in queue. Which is wrong! We have to check if a similar notice has been sent today. This patch has been created after an observation on a production server: If a user place on holds several items, he will receive 1 SMS per hold. Here we only want 1 SMS for all holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:32:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:32:15 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #12 from Katrin Fischer --- I think it would be possible to agree that this is only done for DOM, as we are trying to phase out/deprecate GRS-1. There are some bugs in QueryParser that I would like to see addressed before we make it the standard (for example bug 10542). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:32:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:32:45 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #7 from mathieu saby --- And it still depends on 11208? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:35:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:35:52 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #35 from Katrin Fischer --- Doug, is this ready for sign off/QA with your follow ups? You can switch the status :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:38:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:38:42 +0000 Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 --- Comment #11 from Katrin Fischer --- I am moving this to failed QA - see questions and notes in comment 10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:38:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:38:49 +0000 Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:44:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:44:23 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #5 from Colin Campbell --- Created attachment 23256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23256&action=edit Supplementary patch The main patch removes the field but DelItem still attempts to populate it supplementary patch to remove that -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:45:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:45:04 +0000 Subject: [Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate that profile marcfields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:45:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:45:08 +0000 Subject: [Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate that profile marcfields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21303|0 |1 is obsolete| | Attachment #21304|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 23257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23257&action=edit [PASSED QA] Bug 5031: CSV profiles: content fields are required Some fields are required on editing/adding csv profiles. Test plan: - add a new csv profile (tools/csv-profiles.pl) without any value. - save => error on empty fields. - fill the "marc" content, select type="sql", fill the csv name input. - save => error on sql content field. - fill the sql content - save => the csv profile is saved. - retry for the edit form. Signed-off-by: Bernardo Gonzalez Kriegel Comment: On top of both patches for Bug 10853 Works very well, now we get an alert with empty field Saves correctly MARC and SQL profiles Solved minor conflict introduced by tab followup on Bug 10853 Again small tab errors corrected in followup Signed-off-by: Katrin Fischer Works as described, looks a bit 'non standard' for Koha, but improves usability of the form. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:45:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:45:29 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:46:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:46:02 +0000 Subject: [Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate that profile marcfields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031 --- Comment #14 from Katrin Fischer --- Created attachment 23258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23258&action=edit [PASSED QA] Bug 5031 - followup to correct tabs Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Tiny QA follow-up corrcting whitespace to match coding guidelines. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:48:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:48:06 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #8 from Jonathan Druart --- yes, it is just a followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:49:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:49:34 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- This patch needs a followup to remove any references in code to the marc column in deleteditems. I spotted one in C4/Items.pm at least. I'm also wondering if this affects the output of tools/export.pl (or rather assume it affects) so that will need correcting to. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:50:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:50:04 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #9 from Jonathan Druart --- In fact, it is not a code dependency, more a functionality dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:51:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:51:18 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 --- Comment #7 from Martin Renvoize --- Looks like Colin did the first followup I wanted whilst I was failing.. can someone take care of the second one? I'll then nudge Katrin to do QA as with Colin's input I no longer can.. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:59:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:59:01 +0000 Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:59:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:59:05 +0000 Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22415|0 |1 is obsolete| | Attachment #22416|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 23259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23259&action=edit [PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js To old plugin prevents the upgrade to the latest jquery. By replacing with openjs' shortcut.js, we have now one less hurdle in upgrading Koha to latest. Changes: - removed jquery.hotkeys.min.js - added shortcut.js - modified the related includes (doc-head-close.inc and help-top.inc) - modified the calls in staff-global.js Regression test: 1) apply the patch 2) in the intranet, test the shortcuts alt-q, alt-r, alt-u. These are the only affected functionalities. There is no new functionnality. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests and QA script. Tested existing shortcuts for the search bar tabs on various circulation related pages. This uses a Javascript under BSD license, I wonder if it should be listed in the About>licenses section that we are using it. As Yui is also BSD I assume the license is compatible. +/** + * http://www.openjs.com/scripts/events/keyboard_shortcuts/ + * Version : 2.01.B + * By Binny V A + * License : BSD + */ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:59:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 11:59:18 +0000 Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23259|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 23260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23260&action=edit [PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced it but I couldn't find ANY usage of it to fix. Rebased and fixed. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:00:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 12:00:44 +0000 Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23259|1 |0 is obsolete| | CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Comment on attachment 23259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23259 [PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js Please have different subjects on various patches - or git bz automatically obsoletes the first when attaching the second :) Also, Galen - please can you take a look at my note on the first patch before pushing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:06:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 12:06:21 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Martin Renvoize --- Setting back to Needs Signoff, I've gone through the code and don't think the third followup is required.. I believe the marc column is grabbed from biblioitems in the join so this isn't a regression. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:09:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 12:09:04 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #72 from Jonathan Druart --- (In reply to mathieu saby from comment #70) > Hi Jonathan > > 3 remarks: > > - there is a little conflict (I solved it on my VM) I will submit a rebased patch. > - when I click on A to see all the patrons with name begining with A, I am > automatically redirected to the card of the only patron whose name begins > with A. > Is it a wanted behavior? When the table has only 1 result, the patron detail page is displayed. > - when I try to sort the table according to names or cardnumber, the sorting > is quite slow. It's surprizing, because I only have 10 patrons in my test > base. So I fear the results will be worse with a real base. Maybe it's an > issue of my computer, but do you think there is some part of code to > optimize? With 3.7k patrons, I get a response in 600ms. > - Is there a way to cancel a filter when it is too restrictive? or to cancel > all filters? I don't understand. The filters on the left can be canceled on choosing the first entry 'all/any'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:09:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 12:09:39 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22265|0 |1 is obsolete| | --- Comment #73 from Jonathan Druart --- Created attachment 23261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23261&action=edit Bug 9811: Patron search improvement Rebased patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:41:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 12:41:32 +0000 Subject: [Koha-bugs] [Bug 11249] Add db indexes on borrowers names In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:41:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 12:41:35 +0000 Subject: [Koha-bugs] [Bug 11249] Add db indexes on borrowers names In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23223|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 23262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23262&action=edit [PASSED QA] Bug 11249 - Add db indexes on borrowers names The borrowers search is by default on columns surname, firstname, othernames and cardnumber. (See C4::Members::_express_member_find). Addind db indexes will really increase the query speed. This patch adds bd indexes on surname, firstname, othernames (cardnumber has already an index). Those indexes must be defined with a size because columns are mediumtext. Test plan : Test with mysql client : mysql> explain select * from borrowers where surname like 'A%'; +----+-------------+-----------+-------+---------------+-------------+---------+------+------+-------------+ | id | select_type | table | type | possible_keys | key | key_len | ref | rows | Extra | +----+-------------+-----------+-------+---------------+-------------+---------+------+------+-------------+ | 1 | SIMPLE | borrowers | range | surname_idx | surname_idx | 767 | NULL | 395 | Using where | +----+-------------+-----------+-------+---------------+-------------+---------+------+------+-------------+ => key show the index is used Signed-off-by: Mathieu Saby Signed-off-by: Katrin Fischer Works as described, changes from updatedatabase and in kohastructure match. I think deletedborrowers can be left out, as it's not queried when doing patron searches. Patron deletes still work as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:50:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 12:50:09 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #47 from M. de Rooy --- Thanks, Srdjan. Mark, could you please add your signoff too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:50:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 12:50:50 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:53:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 12:53:50 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize --- I think I've got to the bottom of why I couldn't get this to work.. It's not implemented in the bootstrap theme. Could someone do a follow-up with bootstrap support please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 14:22:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 13:22:01 +0000 Subject: [Koha-bugs] [Bug 8125] SIP should send Zipcode with address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8125 --- Comment #15 from Kyle M Hall --- Created attachment 23263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23263&action=edit Bug 8215 - Course Reserves - Omnibus - v3.12.07 Bug 8215 - Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Test Plan: 1) Create new authorised value categories DEPARTMENT and TERM 2) Create a new course, add instructors to that course. 3) Reserve items for that course, verify item attributes have changed. 4) Disable course, verify item attributes have reverted. 5) Enable course again, verify item attributes again. 6) Delete course, verify item attributes again. 7) Create two new courses, add the same item(s) to both courses. 8) Disable one course, verify item attributes have not reverted. 9) Disable both courses, verify item attributes have reverted. 10) Enable one course, verify item attributes are again set to the new values. 11) Edit reserve item attributes, verify. 12) Disable all courses, edit reserve item attributes, verify the item itself still has its original attributes, verify the reserve item attributes have been updated. 13) Verify the ability to remove instructors from a course. 14) Verify new permissions, top level coursereserves, with subpermissions add_reserves and delete_reserves. Signed-off-by: Kyle M Hall Signed-off-by: Corinne Bulac Signed-off-by: Jonathan Druart http://bugs.koha-community.org/show_bug.cgi?id=8125 Bug 8215 follow-up encoding for branches & itemtypes Signed-off-by: Kyle M Hall Signed-off-by: Corinne Bulac Signed-off-by: Jonathan Druart Bug 8215: Followup FIX QA issues Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Bug 8215 - Add Course Reserves - QA Followup Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Bug 8215: Followup Fix confirmation links for delete course and item Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Bug 8215: FIX ergonomic issue : 'Unchanged()' bug 8215: (followup) run new files through perltidy Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall bug 8215: (followup) make sure C4::CourseReserves doesn't export anything New modules should not export any symbols by default without a very good reason. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall bug 8215: (followup) don't allow deleting course reserves from OPAC Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall bug 8215: (followup) avoid SQL syntax error in logs ModItem currently will attempt to update an item even if no field updates are specified. This patch avoids (harmless) error messages in the Apache logs if an item is not actually being changed when it is placed or taken off reserve. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall bug 8215: (followup) rename GetItemReservesInfo Renamed that routine to GetItemCourseReservesInfo in order to avoid any potential confusion with reserves qua hold requests. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall bug 8215: (followup) remove extraneous underscore in template Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 14:22:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 13:22:44 +0000 Subject: [Koha-bugs] [Bug 8125] SIP should send Zipcode with address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8125 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23263|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 14:22:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 13:22:55 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #149 from Kyle M Hall --- Created attachment 23264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23264&action=edit Bug 8215 - Course Reserves - Omnibus - v3.12.07 Bug 8215 - Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Test Plan: 1) Create new authorised value categories DEPARTMENT and TERM 2) Create a new course, add instructors to that course. 3) Reserve items for that course, verify item attributes have changed. 4) Disable course, verify item attributes have reverted. 5) Enable course again, verify item attributes again. 6) Delete course, verify item attributes again. 7) Create two new courses, add the same item(s) to both courses. 8) Disable one course, verify item attributes have not reverted. 9) Disable both courses, verify item attributes have reverted. 10) Enable one course, verify item attributes are again set to the new values. 11) Edit reserve item attributes, verify. 12) Disable all courses, edit reserve item attributes, verify the item itself still has its original attributes, verify the reserve item attributes have been updated. 13) Verify the ability to remove instructors from a course. 14) Verify new permissions, top level coursereserves, with subpermissions add_reserves and delete_reserves. Signed-off-by: Kyle M Hall Signed-off-by: Corinne Bulac Signed-off-by: Jonathan Druart http://bugs.koha-community.org/show_bug.cgi?id=8125 Bug 8215 follow-up encoding for branches & itemtypes Signed-off-by: Kyle M Hall Signed-off-by: Corinne Bulac Signed-off-by: Jonathan Druart Bug 8215: Followup FIX QA issues Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Bug 8215 - Add Course Reserves - QA Followup Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Bug 8215: Followup Fix confirmation links for delete course and item Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Bug 8215: FIX ergonomic issue : 'Unchanged()' bug 8215: (followup) run new files through perltidy Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall bug 8215: (followup) make sure C4::CourseReserves doesn't export anything New modules should not export any symbols by default without a very good reason. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall bug 8215: (followup) don't allow deleting course reserves from OPAC Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall bug 8215: (followup) avoid SQL syntax error in logs ModItem currently will attempt to update an item even if no field updates are specified. This patch avoids (harmless) error messages in the Apache logs if an item is not actually being changed when it is placed or taken off reserve. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall bug 8215: (followup) rename GetItemReservesInfo Renamed that routine to GetItemCourseReservesInfo in order to avoid any potential confusion with reserves qua hold requests. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall bug 8215: (followup) remove extraneous underscore in template Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:00:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 14:00:04 +0000 Subject: [Koha-bugs] [Bug 11331] New: CSV export for viewlog.pl is missing newlines Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 Bug ID: 11331 Summary: CSV export for viewlog.pl is missing newlines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: sophie.meynieux at biblibre.com QA Contact: testopia at bugs.koha-community.org When you try to export the result of tools/viewlog.pl in csv, file cannot be correctly loaded : - Newline is missing after each record, - strings should be enclosed in "" - columns are not the same as for screen output This patch corrects this 3 points -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:01:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 14:01:00 +0000 Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |sophie.meynieux at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:05:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 14:05:39 +0000 Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 --- Comment #1 from Sophie MEYNIEUX --- Created attachment 23265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23265&action=edit Bug 11331 : corrects csv export for viewlog.pl (add newlines, string separator and same column as screen output) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:05:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 14:05:58 +0000 Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:10:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 14:10:40 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:10:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 14:10:45 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16368|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 23266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23266&action=edit Bug 7673 : New patron permissions This patch adds the following permissions: - editcatalogue.limited_item_edition: Limit item modification to barcode, status and note - editcatalogue.delete_all_items: Delete all items at once - tools.items_limited_batchmod: Limit batch item modification to item status The SubfieldsToAllowForLimitedEdition syspref is used to define which subfields can be edited when the editcatalogue.limited_item_edition permission is enabled. In the same way, the SubfieldsToAllowForLimitedBatchmod is used to define which subfields can be edited when the tools.items_limited_batchmod permission is enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:10:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 14:10:55 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #28 from Jonathan Druart --- Created attachment 23267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23267&action=edit Bug 7673: QA Followup: trailing whitespace and perlcritic issues This patch fixes the following qa issues: FAIL cataloguing/additem.pl FAIL forbidden patterns forbidden pattern: trailing space char (line 833) FAIL critic # Variables::ProhibitConditionalDeclarations: Got 2 violation(s). FAIL tools/batchMod.pl FAIL critic # Variables::ProhibitConditionalDeclarations: Got 2 violation(s). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:17:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 14:17:33 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #48 from M. Tompsett --- Created attachment 23268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23268&action=edit [SIGNED OFF] Bug 11077 - Correct silent warnings in C4/Auth.pm This gets rid of some more warnings. It also corrects a noisy ne condition. $userid = $retuserid if ( $retuserid ne ''); became $userid = $retuserid if ( $retuserid ); It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's patch, while correcting the problems found. This includes: my $q_userid = $query->param('userid') // ''; along with: my $s_userid = ''; and: my $s_userid = $session->param('id') // ''; Indentation does not reflect actual scoping. A missing system preference would have triggered a ubiquitous undef compare check failure message. This makes the flooding message more useful, so as to help correct it. The change to accomplish this was: my $pki_field = C4::Context->preference('AllowPKIAuth'); if (!defined($pki_field)) { print STDERR "Error: Missing AllowPKIAuth System Preference!\n"; $pki_field = 'None'; } Signed-off-by: Srdjan Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:17:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 14:17:51 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23240|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:20:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 14:20:53 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #49 from M. Tompsett --- Re-tested. - staff client: click login with nothing entered - click login with just a valid username entered - click login with proper credentials entered - log out - deleted system preference - click login with proper credentials - ran qa tool Looks good to me. Signed off, as you requested Marcel. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:24:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 14:24:34 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #31 from Kyle M Hall --- Sorry I missed this comment until now! > 1/ Don't you think we should avoid calls to Koha::Database in pl files ? Using DBIx::Class is, afaik, allowed in pl files. Requiring it to be called from modules only just requires yet another layer of abstraction. The only time this is necessary is when business logic needs to be applied. That is, we should definitely keep code DRY by moving repeated chunks of code into a module subroutine, but for a single line call that is not affected by system preferences, this is both unnecessary and unwanted. It would merely slow the system down. For repeated pieces of code that utilize system preferences, I think they *should* be in modules. Better yet, they should be part of the DBIx::Class files, but we haven't gotten to that stage yet. If I am violating my own person views written above, it's simply because I am attempting to implement this new accounting system while making as few modifications to existing code as possible. I think any violations will need to be taken care of eventually. This is of course, assuming everyone else agrees with my views. In any case, those violations can and should be taken care of post-push once we have formalized our policies regarding usage of DBIC. > 2/ Don't you think new module in the Koha namespace should be OOP (for ex. > using Class::Accessor)? Modules in the Koha namespace are not required to be OOP, and I can see no advantage to making Koha::Accounts OOP. The data objects themselves are OO, and Koha::Accounts is just a layer around these objects to manage them. > > Outside the DBIx scope, I am wondering why do you have 2 scripts > account_payment.pl and members/account_payment_do.pl. I suppose it is in > order to remove the $op variable. I think it would be better to head towards > a REST architecture. For example, here, we could imagine executing the > AddCredit routine on a POST method and using the "show/list" view on a GET That is certainly an interesting proposition. What advantages do you see to this? I'd take it much further and say we should make *all* fetching, creating, and updating of data be via REST methods, and make our scripts use those methods via ajax. I think this will make Koha much more responsive, and allow far more flexible integration with other software. What do you think? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:29:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 14:29:42 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #32 from Kyle M Hall --- One example of moving business logic into DBIC. Items should be smart enough to know that when item-level_itypes is set to biblio record, the call to $item->itype() should return $item->biblio->itemtype() instead. I imagine there is a way to override the existing itype() method, or we could just add a new method itemtype_by_preference() or similar. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:06:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 15:06:00 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:06:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 15:06:06 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23186|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall --- Created attachment 23269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23269&action=edit Bug 6427 - Rewrite of the accounts system This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:19:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 15:19:03 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 --- Comment #13 from Jacek Ablewicz --- Works as described for me too, thanks! On related subject, I think we may have some similiar problems with patron-submitted data in other places as well, e.g.: as a test I just submitted "personal data" update request from OPAC via opac/opac-memberentry.pl, with JS code in 'Address 2' field, and injected script seems to work in members/members-update.pl. But I guess it would be better to assign separate bug numbers for such further issues (if any)? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:45:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 15:45:04 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #30 from Olli-Antti Kivilahti --- Testing using the latest master --------------------- + updatedatabase.pl + --------------------- Having a problem updating these changes to my DB from updatedatabase.pl +$DBversion = "3.13.00.XXX"; +if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { Disabling this if-clause enables the DB modifications which work ok. ------------------- + perl Overdues.t + ------------------- ok 1 - use C4::Overdues; ok 2 - C4::Overdues->can('GetOverdueMessageTransportTypes') DBD::mysql::db do failed: Duplicate entry 'CPL-PT' for key 'PRIMARY' at Overdues.t line 23. DBD::mysql::db do failed: Duplicate entry 'CPL-PT' for key 'PRIMARY' at Overdues.t line 23. # Tests were run but no plan was declared and done_testing() was not seen. # Looks like your test exited with 255 just after 2. Caused by me having the records in my db already, problematic since test plan encourages to have existing data in db. A check should be in place to make sure no duplicate entries are INSERTed or maybe use a internal function to update the db? Otherwise tests run ok. Sorry for taking so long to get back at this. So close Joubu! Lemme sign this off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:57:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 15:57:59 +0000 Subject: [Koha-bugs] [Bug 11332] New: add overdues to the notices tab Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11332 Bug ID: 11332 Summary: add overdues to the notices tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be great if the notices tab on the patron record also showed the overdue notices that were sent to the patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:59:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 15:59:35 +0000 Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- Pushed to master, along with followups to move it out of jquery/plugins (as shortcuts.js is not actually a jQuery plugin) and to update the About | Licenses page. Thanks, Philippe! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:03:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 16:03:31 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #29 from Koha Team AMU --- Impossible to test because the permissions are missing. We need : # limited_item_edition Limit item modification to barcode, status and note (please note that edit_item is still required) # manage_shelves Allows to manage shelves # delete_all_items Delete all items # merge_from_shelves Allows to merge records from shelves # items_limited_batchmod -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:56:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 16:56:26 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23266|0 |1 is obsolete| | Attachment #23267|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 23270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23270&action=edit Bug 7673 : New patron permissions This patch adds the following permissions: - editcatalogue.limited_item_edition: Limit item modification to barcode, status and note - editcatalogue.delete_all_items: Delete all items at once - tools.items_limited_batchmod: Limit batch item modification to item status The SubfieldsToAllowForLimitedEdition syspref is used to define which subfields can be edited when the editcatalogue.limited_item_edition permission is enabled. In the same way, the SubfieldsToAllowForLimitedBatchmod is used to define which subfields can be edited when the tools.items_limited_batchmod permission is enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:56:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 16:56:33 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #31 from Jonathan Druart --- Created attachment 23271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23271&action=edit Bug 7673: QA Followup: trailing whitespace and perlcritic issues This patch fixes the following qa issues: FAIL cataloguing/additem.pl FAIL forbidden patterns forbidden pattern: trailing space char (line 833) FAIL critic # Variables::ProhibitConditionalDeclarations: Got 2 violation(s). FAIL tools/batchMod.pl FAIL critic # Variables::ProhibitConditionalDeclarations: Got 2 violation(s). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:57:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 16:57:05 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #32 from Jonathan Druart --- (In reply to Koha Team AMU from comment #29) > Impossible to test because the permissions are missing. Sorry, it was caused by the updatedb version. It should be fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 18:03:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 17:03:14 +0000 Subject: [Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate that profile marcfields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #15 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 18:03:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 17:03:16 +0000 Subject: [Koha-bugs] [Bug 11332] add overdues to the notices tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11332 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Nicole C. Engard --- Okay, I found an example after talking to Katrin ... apparently it's there. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 18:05:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 17:05:04 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21636|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart --- Created attachment 23272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23272&action=edit Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 18:05:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 17:05:26 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 18:05:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 17:05:32 +0000 Subject: [Koha-bugs] [Bug 11333] New: use jQuery validator plugin for CSV profile forms Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11333 Bug ID: 11333 Summary: use jQuery validator plugin for CSV profile forms Change sponsored?: --- Product: Koha Version: master Hardware: All URL: tools/csv-profiles.pl OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 5031 The patch for bug 5031 added use of the HTML5 required attributes. The jQuery validator plugin introduced in bug 6209 should also be used, as that will add validation support for non-HTML5 browsers and will standardize the look of messages for validation errors. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 18:05:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 17:05:32 +0000 Subject: [Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate that profile marcfields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11333 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 18:05:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 17:05:34 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22814|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart --- Created attachment 23273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23273&action=edit Bug 9016: Fix unit tests The unit tests should insert overdue rules. + Fix the doc for GetOverdueMessageTransportTypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 18:07:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 17:07:28 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #33 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #30) > --------------------- > + updatedatabase.pl + > --------------------- Yes, since 3.14 is out, new update db should be marked 3.15.00.XXX > ------------------- > + perl Overdues.t + > ------------------- > ok 1 - use C4::Overdues; > ok 2 - C4::Overdues->can('GetOverdueMessageTransportTypes') > DBD::mysql::db do failed: Duplicate entry 'CPL-PT' for key 'PRIMARY' at > Overdues.t line 23. > DBD::mysql::db do failed: Duplicate entry 'CPL-PT' for key 'PRIMARY' at > Overdues.t line 23. > # Tests were run but no plan was declared and done_testing() was not seen. > # Looks like your test exited with 255 just after 2. Last patch removes data in the overduerules table too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 18:12:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 17:12:44 +0000 Subject: [Koha-bugs] [Bug 11333] use jQuery validator plugin for CSV profile forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11333 --- Comment #1 from Galen Charlton --- Created attachment 23274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23274&action=edit Bug 11333: use jQuery validator plugin for CSV profiles forms This patch adds the use of the jQuery validator plugin for the two forms (new and edit) on the CSV profiles page. Doing this standardizes messages that gets displayed on validation errors. This patch, in the process, fixes a bug where if a page has more than one validated form, only the first such form would get the validator plugin applied to it -- it looks like $.validate() does not do implicit iteration. To test: [1] Apply the patch, then go to Tools | CSV profiles. [2] Create a new profile, but leave the name and the MARC/SQL fields blank. When you click the submit button, the form should not be submitted; instead, text will be displayed to the right of each input that lacks required input. [3] As above, but change the profile type and verify that the form is not submitted unless all of the required fields are filled in. [4] Edit an existing form, then empty the MARC/SQL field. Try submitting the form; it should refuse to submit the form and display text saying that the field is required. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 18:12:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 17:12:41 +0000 Subject: [Koha-bugs] [Bug 11333] use jQuery validator plugin for CSV profile forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11333 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 18:14:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 17:14:54 +0000 Subject: [Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate that profile marcfields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031 --- Comment #16 from Galen Charlton --- (In reply to Jonathan Druart from comment #11) > (In reply to Katrin Fischer from comment #10) > > It looks really nice, but not like in other places of Koha :) But maybe Owen > > could take a look later? > > I used the "required" attribute and the "required" class. The attribute is a > new one (html5) and the required class is the way to do, I think. > I switch back to Signoff: since bug 10853 is pushed to master, I think this > one should be in 3.14 > I will quickly submit another patch if Owen considers something is wrong. I've opened bug 11333 and attached a patch that makes the two forms on this page use the jQuery validation plugin, which should address some of Katrin's concerns. The way that this form handles editing existing profiles is decidedly not consistent with the rest of Koha, but that would be the topic of another bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 18:28:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 17:28:44 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23269|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall --- Created attachment 23275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23275&action=edit Bug 6427 - Rewrite of the accounts system This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 18:58:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 17:58:31 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23275|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 23276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23276&action=edit Bug 6427 - Rewrite of the accounts system This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:06:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 18:06:58 +0000 Subject: [Koha-bugs] [Bug 9294] Move JavaScript out of circulation template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9294 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #24 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. It is needed for 10884. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:08:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 18:08:38 +0000 Subject: [Koha-bugs] [Bug 10884] Circulation table: odd behavior on checkboxes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10884 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:09:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 18:09:19 +0000 Subject: [Koha-bugs] [Bug 10935] CSV for basket and basketgroup are broken when translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:10:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 18:10:35 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #15 from Tom?s Cohen Arazi --- Follow-up pushed to 3.12.x, will be in 3.12.8. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 18:11:43 +0000 Subject: [Koha-bugs] [Bug 10038] Doubled 'default' entry when creating a new authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10038 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:12:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 18:12:16 +0000 Subject: [Koha-bugs] [Bug 10850] Give Quick spine label template page its own id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10850 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:13:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 18:13:13 +0000 Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |10298 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:13:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 18:13:13 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10843 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:24:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 18:24:47 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 23277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23277&action=edit check-diff.sh script to check frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:31:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 18:31:23 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 23278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23278&action=edit Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks This patch tries to make MARC21 bibliographic frameworks internally consistent. It modifies field/subfield descriptions of simple_bib and fastadd frameworks to match corresponding ones of default framework. To test: 1) Download and edit the attached script, check-diff.sh Put on it user, pass and database name of your dev install Copy the script on your git home 2) Run the script (bash check-diff.sh). WARNING: the script removes bibliographic frameworks, and load default, simple_bib and fastadd ones. It will show on screen, and write on file differences.txt, any difference on field/subfield description (liblibrarian) between any framework and default On master it will show a lot of lines 3) Apply the patch 4) Run the script again. Frameworks files must load without problem. There will be no differences NOTE: On fastadd file there are many "space" changes. The reason to that is to format that file to ease the translation process. Not related with this bug, but it reformat the file to match the other ones (default and simple_bib) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:34:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 18:34:50 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:12:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 19:12:39 +0000 Subject: [Koha-bugs] [Bug 11334] New: Add facet for home library Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Bug ID: 11334 Summary: Add facet for home library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The current "Library" facet is somewhat ambiguous for Koha installations with multiple libraries. It refers to the holdingbranch, but does not explicitly state this. It would be beneficial to allow the administrator to choose to show facets for the holding library, home library, or both. In addition, the facets should be more explicitly labeled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:12:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 19:12:45 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:12:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 19:12:51 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:16:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 19:16:58 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 --- Comment #1 from Kyle M Hall --- Created attachment 23279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23279&action=edit Bug 11334 - Add facet for home library The current "Library" facet is somewhat ambiguous for Koha installations with multiple libraries. It refers to the holdingbranch, but does not explicitly state this. It would be beneficial to allow the administrator to choose to show facets for the holding library, home library, or both. In addition, the facets should be more explicitly labeled. Test plan: 1) Apply this patch 2) Check that the facets label "Libraries" now reads "Holding libraries" 3) Update the system preference DisplayLibraryFacets to "home library" 4) Check that the facet now reads "Home libraries" 5) Update the preference again to "both home and holding library" 6) Check that both the facets for home and holding library are now displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:16:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 19:16:55 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:52:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 19:52:57 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 21:10:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 20:10:05 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 --- Comment #14 from Chris Cormack --- (In reply to Jacek Ablewicz from comment #13) > Works as described for me too, thanks! > > On related subject, I think we may have some similiar problems with > patron-submitted data in other places as well, e.g.: as a test I just > submitted "personal data" update request from OPAC via > opac/opac-memberentry.pl, with JS code in 'Address 2' field, and injected > script seems to work in members/members-update.pl. But I guess it would be > better to assign separate bug numbers for such further issues (if any)? Yep new bug on any others you find, i checked reviews/comments and tags, they are ok. But im prepared to believe member update isn't. At least with that you have to be logged in, so not quite as bad as the suggestions (which could be done without login if the syspref was set that way) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 21:16:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 20:16:03 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #36 from Chris Cormack --- Comment on attachment 23276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23276 Bug 6427 - Rewrite of the accounts system Review of attachment 23276: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6427&attachment=23276) ----------------------------------------------------------------- ::: C4/Koha.pm @@ +1029,4 @@ > > sub GetAuthorisedValues { > my ( $category, $selected, $opac ) = @_; > + warn "GetAuthorisedValues( $category, $selected, $opac )"; This needs a debug switch, or to be removed @@ +1076,4 @@ > push @results, $data; > } > $sth->finish; > + warn "RET: " . Data::Dumper::Dumper( \@results ); And this too, or the logs get loud very very fast ::: misc/release_notes/release_notes_3_10_0.txt @@ +1762,4 @@ > 8996 normal In result page items with negative notforloan are available > 9017 normal Quote of the day: Table footer not translated > 5312 minor XHTML correction in authority summary > + 8009 minor Item descriptive data not populated on account_payment.pl Shouldnt be in the patch, this looks like a search and replace gone wrong ::: misc/release_notes/release_notes_3_12_0.txt @@ +579,4 @@ > 8429 minor Unnecessary use of Exporter in SIP/ILS objects > 9292 minor Remove dead code related to 'publictype' > 9401 minor Javascript used for tags handling wants access to CGISESSID cookie > + 9582 minor Unused code in members/account_payment.pl Hmm not sure why this is in the patch? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 21:54:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 20:54:23 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 --- Comment #11 from Liz Rea --- Created attachment 23280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23280&action=edit Bug 10944 - Followup for Bootstrap Amazon images on https OPAC see test plan for previous patch, only bootstrap theme instead of prog. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 22:38:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 21:38:03 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 --- Comment #12 from Liz Rea --- Hi Cait, I wasn't able to replicate your issue - the image url changed correctly for me based on whether or not the site was running in SSL in the OPAC. You would need both patches to cover both OPAC and intranet. The intranet patch doesn't even have a non-ssl mode for fetching the images - you will always get the ssl version of the image no matter the mode. The thinking is - we should not ever be running (yes, of course we *do* but we *shouldn't*!) the intranet in non-SSL. It doesn't hurt anything to fetch the https image over the http version, so Robin simply made that choice to do it without the ability to switch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 22:42:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 21:42:35 +0000 Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 --- Comment #25 from M. Tompsett --- Bug 11334 may also affect this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 22:56:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 21:56:46 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #4 from Bernardo Gonzalez Kriegel --- Found some changes that need to be done. Switch to In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 23:00:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 22:00:33 +0000 Subject: [Koha-bugs] [Bug 10957] 710$a with 710$b (subordinate unit) present shows wrong (XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10957 --- Comment #7 from Tom?s Cohen Arazi --- (In reply to Katrin Fischer from comment #4) > Hi Tomas, > > what i did was using an authority with $a $b $b (as $b is noted as > repeatable). The generated string looked like this: > > Staff detail: > a. b, -- c. > > Staff result: > a. b > > I wonder about the different generation of the display in result and detail. > I think that the punctuation should be cataloged with the record, so maybe > -- would not be needed. But, I am not really sure how this should look like. > > Note: a separeate patch will be needed for the bootstrap OPAC. > > Leaving as 'signed off', but please comment. Jared told me on IRC it was customary to use -- for $c. In any case, I just left it as it was before (if i recall). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 00:23:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 23:23:56 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23278|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 23281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23281&action=edit Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks This patch tries to make MARC21 bibliographic frameworks internally consistent. It modifies field/subfield descriptions of simple_bib and fastadd frameworks to match corresponding ones of default framework. To test: 1) Download and edit the attached script, check-diff.sh Put on it user, pass and database name of your dev install Copy the script on your git home 2) Run the script (bash check-diff.sh). WARNING: the script removes bibliographic frameworks, and load default, simple_bib and fastadd ones. It will show on screen, and write on file differences.txt, any difference on field/subfield description (liblibrarian) between any framework and default On master it will show a lot of lines 3) Apply the patch 4) Run the script again. Frameworks files must load without problem. There will be no differences NOTE: There are many "space" changes. The reason to that is to format files to ease the translation process. Not related with this bug, but necessary. Also a few changes on default framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 00:37:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 23:37:18 +0000 Subject: [Koha-bugs] [Bug 11335] New: show thumbnails of patrons on patron search results Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11335 Bug ID: 11335 Summary: show thumbnails of patrons on patron search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be cool if the patron search results could show thumnails of the patron images if the library wanted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 00:51:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2013 23:51:58 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #6 from Bernardo Gonzalez Kriegel --- Now it's ready -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 06:29:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 05:29:05 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #13 from David Cook --- (In reply to Jared Camins-Esakov from comment #8) > (In reply to David Cook from comment #7) > > Also note that you will have to individually set up each index that you want > > to use for facet queries. > > > > As per this email from an IndexData person: > > http://lists.indexdata.dk/pipermail/zebralist/2007-July/001694.html > > > > In general, this shouldn't case a problem, since we only use a short list of > > facets. However, it would create a barrier to allowing users to customize > > their results. > > This has to be changed in two places. In the server elements configuration, > as described at that link, *and* an additional index has to be configured > for each facet. Jared, I'm not sure I understand what you mean by "an additional index has to be configured for each facet". Could you elaborate? Once the server element is set up for a facet, it should be all good to go. -- That said, I was thinking about this a bit last night, and I can't recall exactly what is retrieved with a facet query. I have yet to set up a VM for Koha on my new desktop so I'll have to wait a bit before testing it out again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 08:53:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 07:53:03 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #12 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #11) > the publication year data will > be in a different field in a MARC21 database, so I think the SQL query > changed here needs to take biblio.copyrightdate into account too. Ok, but actually the copyrightdate is missing in templates. This is could be a new bug no ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 08:59:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 07:59:52 +0000 Subject: [Koha-bugs] [Bug 11069] increase title ranking in relevance when using QueryWeightFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069 --- Comment #8 from Fridolin SOMERS --- (In reply to mathieu saby from comment #6) The "Title" index is by default set on many fields, not only 200. Maybe your 1st result matches "grands moderne" in other fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 10:22:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 09:22:31 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 --- Comment #13 from Martin Renvoize --- Hi Liz, That's all looking pretty good to me now, though there is one minor discrepancy that's crept in on the bootstrap theme. in http the class=item-thumbnail whereas in https class=thunmbnail which make the image display slightly differently depending upon http or https. Though it's no biggy (I actually prefer the styling on the https version myself with a minor border). I'm currently testing to see if it affects the results turned up for .com vs other local amazon's, and testing that the other amazon preferences aren't affected. I think cait's issues were to do with her ssl setup so she's asked me to do qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 10:44:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 09:44:16 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 10:44:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 09:44:19 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22407|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 23282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23282&action=edit [PASSED QA] Bug 10944 - Mixed content warnings in opac results and detail with Amazon images on https It's probably going to become more popular to run Koha in SSL environments. Currently on ssl, with Amazon images enabled, a SSL enabled site will either not show Amazon images (IE, some versions of Firefox?), or show a warning to users about mixed secure and insecure content (Firefox, Chrome). Since we now have the using_https template variable, it makes sense to use it. To test: In each browser you have access to, and preferably with SSL set up (you can set up a self signed cert for your dev install by following, more or less, the instructions here: https://wiki.debian.org/Self-Signed_Certificate) For the apache config, just copy the one for the OPAC, but set it to use 443 instead of 80 for the port, and point it to your keys per the instructions above. ** note that using a self signed cert on your dev install will prompt you when you connect the first time that OMG I CAN'T VERIFY THIS IS COOL. You did it yourself, if you can't trust yourself... then who can you trust? * Enable Amazon images in the system preferences * Do a search that you know will have images for, verify that without SSL 1. the images show 2. the image source is from an Amazon url that uses http:// 3. the images are the right size, and look ok * Do the same using https, verify that with SSL 1. the images show 2. the image source is from an Amazon url that uses https:// 3. the images are the right size, and look ok Clicking on the image should link to the item on Amazon. This patch also corrects a problem with the Amazon url used on the images - it was pointing to a feature that is currently unavailable. That's fixed here. All you need to check is that it goes to a valid Amazon endpoint that doesn't show an error. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 10:44:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 09:44:29 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22409|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 23283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23283&action=edit [PASSED QA] Bug 10944 - Mixed content warnings for covers on staff client This switches the URLs used to access Amazon's cover images to the SSL image server, preventing warnings when using this on a secure site. To test: * Enable Amazon images in the sysprefs, all other cover images off. * Do a search in the staff client. Using firebug or similar, inspect the images that indicate both "no image found" and the covers. * Are they all https, and showing correctly? Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 10:44:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 09:44:38 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23280|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 23284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23284&action=edit [PASSED QA] Bug 10944 - Followup for Bootstrap Amazon images on https OPAC see test plan for previous patch, only bootstrap theme instead of prog. :) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 10:47:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 09:47:31 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 --- Comment #17 from Martin Renvoize --- I'm happy that this all works as advertised and doesn't introduce any regressions anywhere. It passes the QA script and even tidies up the templates a little. I corrected the minor discrepancy in class upon thumbnails in opac-results for bootstrap as it was a very minor change to make. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 10:50:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 09:50:40 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23284|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 23285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23285&action=edit [PASSED QA] Bug 10944 - Followup for Bootstrap Amazon images on https OPAC see test plan for previous patch, only bootstrap theme instead of prog. :) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 11:13:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 10:13:03 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #40 from Paola Rossi --- Thanks, Mathieu. Now rebuilding zebra indexes is OK. I turn "UseQueryParser" preference to the second option "Try". As required at step 5, I submit: Dissertation-information: XXXX in homepage, selecting tab "Search the catalog". Koha answers: Home ? Catalogo ? Ricerca di 'pqf=@and @and @or @or @attr 1=1016 @attr 5=1 @attr 4=6 "Dissertation-information:" @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6 "Dissertation-information:" @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "Dissertation-information:" @or @or @attr 1=1016 @attr 5=1 @attr 5=1 @attr 4=6 "XXXX" @attr 9=20 @attr 2=102 @attr 5=1 @attr 5=1 @attr 4=6 "XXXX" @attr 9=34 @attr 2=102 @attr 5=1 @attr 5=1 @attr 4=6 "XXXX" @or @or @attr 1=1016 @attr 5=1 @attr 5=1 @attr 5=1 @attr 4=6 "#relevance_asc" @attr 9=20 @attr 2=102 @attr 5=1 @attr 5=1 @attr 5=1 @attr 4=6 "#relevance_asc" @attr 9=34 @attr 2=102 @attr 5=1 @attr 5=1 @attr 5=1 @attr 4=6 "#relevance_asc"' Nessun risultato trovato Nessun risultato rispondente alla tua ricerca per 'pqf=@and @and @or @or @attr 1=1016 @attr 5=1 @attr 4=6 "Dissertation-information:" @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6 "Dissertation-information:" @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "Dissertation-information:" @or @or @attr 1=1016 @attr 5=1 @attr 5=1 @attr 4=6 "XXXX" @attr 9=20 @attr 2=102 @attr 5=1 @attr 5=1 @attr 4=6 "XXXX" @attr 9=34 @attr 2=102 @attr 5=1 @attr 5=1 @attr 4=6 "XXXX" @or @or @attr 1=1016 @attr 5=1 @attr 5=1 @attr 5=1 @attr 4=6 "#relevance_asc" @attr 9=20 @attr 2=102 @attr 5=1 @attr 5=1 @attr 5=1 @attr 4=6 "#relevance_asc" @attr 9=34 @attr 2=102 @attr 5=1 @attr 5=1 @attr 5=1 @attr 4=6 "#relevance_asc"'. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:32:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 11:32:27 +0000 Subject: [Koha-bugs] [Bug 11336] New: Priority is not updated on deleting holds Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 Bug ID: 11336 Summary: Priority is not updated on deleting holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There are a lot of places where a hold deletion is possible. But I just found 1 place where it works! To reproduce: - select or create 2 users U1 and U2 - select or create an holdable item - place on hold for both U1 and U2. U1 has priority 1 and U2 has priority 2. - delete the hold for U1 - go on circ/circulation.pl?borrowernumber=XXXX for U2 (or in the DB directly) and verify the priority has not been set to 1 The issue is repeatable (at least) on these 2 pages: * circ/circulation.pl?borrowernumber=XXXX (tab 'Holds', select "yes" in the dropdown list and submit the form) * reserve/request.pl?biblionumber=XXXX (clic on the red cross) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:32:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 11:32:37 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:35:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 11:35:33 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:35:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 11:35:36 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #1 from Jonathan Druart --- Created attachment 23286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23286&action=edit Bug 11336: Priority is not updated on deleting holds There are a lot of places where a hold deletion is possible. But I just found 1 place where it works! To reproduce: - select or create 2 users U1 and U2 - select or create an holdable item - place on hold for both U1 and U2. U1 has priority 1 and U2 has priority 2. - delete the hold for U1 - go on circ/circulation.pl?borrowernumber=XXXX for U2 (or in the DB directly) and verify the priority has not been set to 1 The issue is repeatable (at least) on these 2 pages: * circ/circulation.pl?borrowernumber=XXXX (tab 'Holds', select "yes" in the dropdown list and submit the form) * reserve/request.pl?biblionumber=XXXX (clic on the red cross) The CancelReserve calls _FixPriority with a reserveid. _FixPriority try to retrieve the reserve with this reserveid but it does not exist anymore... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:40:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 11:40:59 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #2 from Jonathan Druart --- The fix I propose is quite dirty but I did not find another fix without rewriting a big part of code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:45:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 11:45:31 +0000 Subject: [Koha-bugs] [Bug 11333] use jQuery validator plugin for CSV profile forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11333 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:45:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 11:45:35 +0000 Subject: [Koha-bugs] [Bug 11333] use jQuery validator plugin for CSV profile forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11333 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23274|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 23287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23287&action=edit Bug 11333: use jQuery validator plugin for CSV profiles forms This patch adds the use of the jQuery validator plugin for the two forms (new and edit) on the CSV profiles page. Doing this standardizes messages that gets displayed on validation errors. This patch, in the process, fixes a bug where if a page has more than one validated form, only the first such form would get the validator plugin applied to it -- it looks like $.validate() does not do implicit iteration. To test: [1] Apply the patch, then go to Tools | CSV profiles. [2] Create a new profile, but leave the name and the MARC/SQL fields blank. When you click the submit button, the form should not be submitted; instead, text will be displayed to the right of each input that lacks required input. [3] As above, but change the profile type and verify that the form is not submitted unless all of the required fields are filled in. [4] Edit an existing form, then empty the MARC/SQL field. Try submitting the form; it should refuse to submit the form and display text saying that the field is required. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 13:16:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 12:16:12 +0000 Subject: [Koha-bugs] [Bug 2546] Description of charges: string hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546 --- Comment #13 from Kyle M Hall --- Agreed. Perhaps I'm being too optimistic ; ) (In reply to Galen Charlton from comment #12) > (In reply to Kyle M Hall from comment #11) > > Bug 6427 will also obviate this issue. I believe it will be pushed to master > > before the 3.16 release, and would recommend *not* pushing this patch to > > master. However, it should definitely be pushed for 3.14.x and earlier. > > The accounts rewrite is still very much a work in progress and will require > more discussion and testing, so it is premature to consider it a blocker for > patches that implement current fixes -- particularly as it is preferable > that patches destined for backporting to a maintenance branch show up in > master first. > > I don't see anything in Jonathan's patch that blocks anything proposed by > the accounts rewrite. If there is something, Kyle, this is your opportunity > to speak up about it (although since you have already indicated that you > believe it suitable for maintenance branches, I would assume that you don't > know of any such blocker). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 13:43:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 12:43:44 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23268|0 |1 is obsolete| | --- Comment #50 from M. de Rooy --- Created attachment 23288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23288&action=edit [PASSED_QA] Bug 11077 - Correct silent warnings in C4/Auth.pm This gets rid of some more warnings. It also corrects a noisy ne condition. $userid = $retuserid if ( $retuserid ne ''); became $userid = $retuserid if ( $retuserid ); It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's patch, while correcting the problems found. This includes: my $q_userid = $query->param('userid') // ''; along with: my $s_userid = ''; and: my $s_userid = $session->param('id') // ''; Indentation does not reflect actual scoping. A missing system preference would have triggered a ubiquitous undef compare check failure message. This makes the flooding message more useful, so as to help correct it. The change to accomplish this was: my $pki_field = C4::Context->preference('AllowPKIAuth'); if (!defined($pki_field)) { print STDERR "Error: Missing AllowPKIAuth System Preference!\n"; $pki_field = 'None'; } Signed-off-by: Srdjan Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 13:44:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 12:44:23 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #14 from Jared Camins-Esakov --- (In reply to David Cook from comment #13) > Jared, I'm not sure I understand what you mean by "an additional index has > to be configured for each facet". > > Could you elaborate? You have to add a element:0 index for each facet you want to use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 13:45:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 12:45:07 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #51 from M. de Rooy --- Passed QA now (see earlier comments and adjustments). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:13:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:13:54 +0000 Subject: [Koha-bugs] [Bug 7934] Separate po file for help pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:15:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:15:41 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:26:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:26:59 +0000 Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985 --- Comment #5 from Jonathan Druart --- (In reply to mathieu saby from comment #4) > But I have a question for the last case. It is a record with two 200 fields, > in chinese and in french. Is it normal to only have the chinese name on the > first line (the line defined by "[200a][, 200b][ 200d][-- 152b --][ ; 200c][ > (200f)] [001*] [ppn: 009*]") ? Yes, this patch only processes the first field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:39:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:39:13 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #34 from Olli-Antti Kivilahti --- Created attachment 23289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23289&action=edit [SIGNED-OFF] Bug 9016: Create a message for each transport type. This patch adds: - a new jquery plugin : insertatcaret. - the ability to define a notice template for each transport type. - a new routine C4::Letters::GetMessageTransportTypes. Test plan: - Go on tools/letter.pl and check that all existing notices are still there. - Modify one. A new empty message is present for sms, print, etc. The email message is filled with the existant value. - Add a message for sms for example (don't forget the subject) and save. - edit again and verify the sms message has been saved. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:39:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:39:22 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #35 from Olli-Antti Kivilahti --- Created attachment 23290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23290&action=edit [SIGNED-OFF] Bug 9016: Define different transport types for overdues This patch adds: - a new routine C4::Overdues::GetOverdueMessageTransportTypes. - the ability to define one or more transport types for an overdue level. Test plan: - go on tools/overduerules.pl. - verify that previous rules still exist and that the 'email' checkboxes is checked if a rule is defined. - redefined rules at different levels and check the transport type needed. Currently, only email, sms and print are relevant - Save the changes. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:39:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:39:28 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #36 from Olli-Antti Kivilahti --- Created attachment 23291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23291&action=edit [SIGNED-OFF] Bug 9016: FIX GetMessageTransportTypes returns an arrayref, not hashref Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:39:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:39:34 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #37 from Olli-Antti Kivilahti --- Created attachment 23292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23292&action=edit [SIGNED-OFF] Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:39:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:39:38 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #38 from Olli-Antti Kivilahti --- Created attachment 23293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23293&action=edit [SIGNED-OFF] Bug 9016: Fix unit tests The unit tests should insert overdue rules. + Fix the doc for GetOverdueMessageTransportTypes Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:40:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:40:23 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #39 from Olli-Antti Kivilahti --- Changes ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:40:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:40:41 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #41 from mathieu saby --- Oh! I did not found documentation on how to update Queryparser conf, so maybe I did the things wrongly. I should maybe ask Jared... Did you try to use this new index without the QueryParser? And can you say me if searches on other indexes with the Queryparser activated are working well on your instance without my patch? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:42:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:42:16 +0000 Subject: [Koha-bugs] [Bug 10852] Add 3 filters to the serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 --- Comment #5 from Jonathan Druart --- (In reply to mathieu saby from comment #4) > So, could you rephrase the name of the filter, so that it be obvious for users? I will submit a followup. > I had a callnumber "XC BLA", and get the subscription with a search on > callnumber "LA" or "X" > I think callnumber filter should search for complete words, but I'm not sure > it is the case elsewhere in Koha. I think it is an acceptable behavior, it is like it works in GetSubscriptions too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:42:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:42:54 +0000 Subject: [Koha-bugs] [Bug 10852] Add 3 filters to the serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 --- Comment #6 from Jonathan Druart --- Created attachment 23294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23294&action=edit Bug 10852: Rename the "expiration date" filter name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:45:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:45:28 +0000 Subject: [Koha-bugs] [Bug 10852] Add 3 filters to the serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 --- Comment #7 from mathieu saby --- > > I had a callnumber "XC BLA", and get the subscription with a search on > > callnumber "LA" or "X" > > I think callnumber filter should search for complete words, but I'm not sure > > it is the case elsewhere in Koha. > > I think it is an acceptable behavior, it is like it works in > GetSubscriptions too. OK. anyway it should not be a blocker for this enh. If someone wants to improve this behavior, he can do it later... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:49:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:49:53 +0000 Subject: [Koha-bugs] [Bug 10852] Add 3 filters to the serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20945|0 |1 is obsolete| | --- Comment #8 from mathieu saby --- Created attachment 23295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23295&action=edit [PATCH][SIGNED OFF] Bug 10852: serials search improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:50:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:50:15 +0000 Subject: [Koha-bugs] [Bug 10852] Add 3 filters to the serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23294|0 |1 is obsolete| | --- Comment #9 from mathieu saby --- Created attachment 23296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23296&action=edit [PATCH][SIGNED OFF] Bug 10852: Rename the "expiration date" filter name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:50:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 13:50:27 +0000 Subject: [Koha-bugs] [Bug 10852] Add 3 filters to the serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from mathieu saby --- I sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:23:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 14:23:44 +0000 Subject: [Koha-bugs] [Bug 11337] New: calls to GetSubscriptions can be replaced by Searchsubscriptions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 Bug ID: 11337 Summary: calls to GetSubscriptions can be replaced by Searchsubscriptions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org These 2 routines do the same think. They can be merged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:30:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 14:30:15 +0000 Subject: [Koha-bugs] [Bug 11337] calls to GetSubscriptions can be replaced by Searchsubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:30:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 14:30:20 +0000 Subject: [Koha-bugs] [Bug 11337] calls to GetSubscriptions can be replaced by Searchsubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 --- Comment #1 from Jonathan Druart --- Created attachment 23297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23297&action=edit Bug 11337: Remove the C4::Serials::GetSubscriptions routine Since SearchSubscriptions is the way to search subscriptions, each call to GetSubscriptions could be replaced by a call to SearchSubscriptions. Test plan: Verify following pages display the same thing as before this patch: - catalogue/detail.pl - opac/opac-ISBDdetail.pl - opac/opac-detail.pl Verify the following page returns correct results: - serials/checkexpiration.pl Verify the Serials UT file still passes: - prove t/db_dependent/Serials.t Note: The title filter on checkexpiration now only searches on the title DB field. I don't think it is a regression, it should be the way to use this field. Maybe should we add new search fields on this form. Bug 5337 reintroduces a bug fixed by bug 5864, this patch restore the right way to search subscription (based on biblionumber). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:30:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 14:30:38 +0000 Subject: [Koha-bugs] [Bug 11337] calls to GetSubscriptions can be replaced by Searchsubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:43:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 14:43:47 +0000 Subject: [Koha-bugs] [Bug 10797] Move styling from element to CSS file for search input field in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10797 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:43:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 14:43:50 +0000 Subject: [Koha-bugs] [Bug 10797] Move styling from element to CSS file for search input field in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10797 --- Comment #1 from Katrin Fischer --- Created attachment 23298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23298&action=edit Bug 10797: Move styling of simple search from element to CSS file To test: - Switch to prog theme, problem doesn't exist in Bootstrap theme - Take a look at the simple search input field - Apply patch - Refresh page - Make sure field has the same length and size You can also use Firebug to make sure the same styles are applied to the element before and after the change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:45:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 14:45:37 +0000 Subject: [Koha-bugs] [Bug 10964] Update MARC21 de-DE default framework to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10964 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|bgkriegel at gmail.com |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Worked this out in the po files with lots of help from Bernardo - obsoleting the patches for now. Updated files coming soon :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:45:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 14:45:50 +0000 Subject: [Koha-bugs] [Bug 10964] Update MARC21 de-DE default framework to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10964 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21548|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:46:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 14:46:20 +0000 Subject: [Koha-bugs] [Bug 10964] Update MARC21 de-DE default framework to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10964 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21824|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:59:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 14:59:04 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:59:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 14:59:09 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22908|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 23299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23299&action=edit Bug 5338: Serials Report -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:59:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 14:59:59 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #11 from Jonathan Druart --- Mathieu, the table order was wrong. The results look better now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:01:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 15:01:00 +0000 Subject: [Koha-bugs] [Bug 11144] Switch order of overdues and fines cronjob for packages and in crontab.example In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #1 from Katrin Fischer --- Created attachment 23300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23300&action=edit Bug 11144: Run fines cronjob before overdues cronjob Fines in overdues can only be printed correctly, when they have been already generated when the overdue_notices job is been run. This patch just changes the sequence of both cronjobs putting fines.pl before overdue_notices. Patch changes crontab.example and koha-common.cron.daily for package installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:00:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 15:00:57 +0000 Subject: [Koha-bugs] [Bug 11144] Switch order of overdues and fines cronjob for packages and in crontab.example In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:09:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 15:09:21 +0000 Subject: [Koha-bugs] [Bug 11144] Switch order of overdues and fines cronjob for packages and in crontab.example In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #2 from Katrin Fischer --- This is a simple patch, but not trivial to test if you want to make sure it works as before. What you could do: Add fines and notices configuration to your installation - Add circulation condition: fine inverval 1, fine 1.50, grace period 0, fines cap 3.00 - Checkout an item with due date yesterday - Add an overdue notice letter that includes <> - Add notice triggers with a delay matching your overdue item - 1 - Make sure finesmode is set to calculate - Make sure patron has right patron category and email address Edit crontab example to make it run not shortly after 1, but more suitable to your testing time. [This is cheating a bit, but not sure how to do this in a better way] Wait until it has run. - Check the fine is there - Check the overdue letter for the fine Before the patch, the fine is not printed. - Update your crontab using the new example - [Change time for it to be run] - Repeat test. Fine should be printed now. For installations using the packages a similar test can be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:09:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 15:09:39 +0000 Subject: [Koha-bugs] [Bug 11144] Switch order of overdues and fines cronjob for packages and in crontab.example In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:29:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 15:29:18 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22701|0 |1 is obsolete| | Attachment #22702|0 |1 is obsolete| | Attachment #22722|0 |1 is obsolete| | Attachment #22768|0 |1 is obsolete| | Attachment #22769|0 |1 is obsolete| | Attachment #22869|0 |1 is obsolete| | Attachment #23052|0 |1 is obsolete| | Attachment #23053|0 |1 is obsolete| | Attachment #23142|0 |1 is obsolete| | Attachment #23143|0 |1 is obsolete| | --- Comment #80 from Jonathan Druart --- Created attachment 23301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23301&action=edit Bug 10855: Squash several fixes Bug 10855: FIX: Add additional fields for closed subscriptions Bug 10855: Fix instance vs static method This patch fixes the error message. The 3 modified routines *are* static methods. Bug 10855: FIX conflicts with bug 7688 Bug 10855: Fix typo addition_fields -> additional_fields Bug 10855: A partial search should return the subscriptions If a search on an additional fields is done using a partial string ("foo" and the defined value is "foobar"), the subscription should appear in the result list. Test plan: Try to search a part of the string for an additional field. Bug 10855: Filtering on additional fields don't work if value is equal to 0 If you tried to filter on an additional field linked to an authorised value, that did not work if the value was 0. Bug 10855: Remove the advanced serial search box on the serial home page Bug 10855: FIX an add field should not be created if the marc field does not exist. This patch fixes the following: Create an add fields linked to a nonexistent marc field (does not exist in serials). Edit a subscription and save. Without this patch, an error occured: Software error: DBD::mysql::db do failed: Column 'value' cannot be null at /var/root-koha/bug-10855/Koha/AdditionalField.pm line 107. Bug 10855: Fix Type table vs tablename Koha::AdditionalField->all method take "tablename" not "table" in parameter". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:29:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 15:29:28 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #81 from Jonathan Druart --- Created attachment 23302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23302&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:33:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 15:33:18 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #82 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #78) Hello Jacek, I squashed all fixes into one. > 79c79,80 > < if ( defined ( my $filter_value = $query->param('additional_field_' . > $field->{id} . '_filter') ) ) { > --- > > my $filter_value = $query->param('additional_field_' . $field->{id} . '_filter'); > > if ( defined( $filter_value ) && $filter_value ne '' ) { > > searching works again like it should. I'm not sure if that may be a proper > fix, but it corrected this particular problem. Yep, it is fine. It is included in the squashed patch. (In reply to Jacek Ablewicz from comment #79) > It was enough, no need to extend additional_fields table.. Also, in case > extra fields are really needed, one can always add additional fields to > additional_fields using Koha::AdditionalFields ;). It would be fun but I discourage you to do that :) > Yet subscription-add.* script & template are (?) still using field name for > etc. isntead of field id - that's where I encountered > aftermentioned problems. Another possibility is that while applying patches > I simply may have missed one (or two).. Yes, good catch. Fixed in the last patch too. Thank you very much for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:44:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 15:44:58 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #12 from mathieu saby --- (In reply to Jonathan Druart from comment #11) > Mathieu, the table order was wrong. The results look better now. Thank you. You see, it was not so trivial to test ;-) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 17:03:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 16:03:55 +0000 Subject: [Koha-bugs] [Bug 11338] New: wrong SQL in DelItemCheck Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11338 Bug ID: 11338 Summary: wrong SQL in DelItemCheck Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In C4::Items::DelItemCheck, there are two SQL queries : one to check if item is on loan, the other if item is reserved. Those two queries use "SELECT * FROM table", fetch the datas with "$var = $sth->fetchrow", and use "$var" as a boolean condition. This is not correct, SQL query should be "SELECT COUNT(*) FROM table". Code actually works, but is dangerous. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 17:12:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 16:12:49 +0000 Subject: [Koha-bugs] [Bug 11338] wrong SQL in DelItemCheck In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11338 --- Comment #1 from Fridolin SOMERS --- Created attachment 23303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23303&action=edit Bug 11338 - wrong SQL in DelItemCheck In C4::Items::DelItemCheck, there are two SQL queries : one to check if item is on loan, the other if item is reserved. Those two queries use "SELECT * FROM table", fetch the datas with "$var = $sth->fetchrow", and use "$var" as a boolean condition. This is not correct, SQL query should be "SELECT COUNT(*) FROM table". Code actually works, but is dangerous. This patch corrects the SQL queries and sets my ($var) to show that fetchrow returns an array. Test plan : - Set an item A onloan - Set an item B reserved and the reserve waiting - Go to items cataloguing : cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXX - Try to delete item A => You get an alert and item is not deleted - Try to delete item B => You get an alert and item is not deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 17:13:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 16:13:43 +0000 Subject: [Koha-bugs] [Bug 11338] wrong SQL in DelItemCheck In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11338 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Fridolin SOMERS --- (first time I use git bz, whouuu) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 17:13:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 16:13:53 +0000 Subject: [Koha-bugs] [Bug 11338] wrong SQL in DelItemCheck In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11338 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 18:24:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 17:24:57 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #35 from Kyle M Hall --- Created attachment 23304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23304&action=edit Bug 6886 - Single branch mode should disable showing the branch name in front of all callnumbers - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 18:26:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 17:26:30 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #36 from Kyle M Hall --- Here's is the QA followup! (In reply to Katrin Fischer from comment #34) > Hi Kyle, please change the patch yourself, so I can test it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 18:28:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 17:28:54 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 18:28:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 17:28:58 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18643|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall --- Created attachment 23305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23305&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price This patch adds the ability to set the maximum fine for a given item to its replacement price ( assuming the replacement price is set ). If overduefinescap is also set, the fine will be the lesser of the two, if both apply to the given overdue checkout. To enable this new limit, create or edit your circulation rules and check the checkbox for "Cap fines at replacement price" Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Pick an item, and set it's replacement price to 3.99 4) Edit the circulation rule that would apply to this item and the patron you will check it out to. 5) Check out the item to the patron, and backdate the due date such that the fine generated would be more than 3.99 6) Enable CalculateFinesOnReturn 7) Return the item, and view the fine generated, it should be 3.99 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 18:33:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 17:33:52 +0000 Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Patch complexity|--- |Trivial patch Version|3.8 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 18:35:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 17:35:20 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20808|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 23306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23306&action=edit Bug 7595 - Add branchcode to accountlines Adds a branchcode column to the accountlines table. For payments, this inserts the branchcode of the library where the payment was recorded. For manual invoices, it insert the branchcode of the library where the manual invoice was created. Signed-off-by: Nicole C. Engard I tested with creating manual invoices, and paying partial fines, entire fine lines, and writing off fines. All actions record the branch where the action took place properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 18:36:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 17:36:33 +0000 Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 18:36:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 17:36:37 +0000 Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921 --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 23307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23307&action=edit Bug 8921: koha-common*.deb should depend on cron Trivial patch to add 'cron' as dependency for the koha-common package. 'cron' is usually pulled in any minimal Ubuntu/Debian install, but in some circumstances (using debootstrap) it might be absent. As Robin said, this doesn't seem to have any side effects. Regards To+ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 18:46:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 17:46:28 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 18:46:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 17:46:31 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20809|0 |1 is obsolete| | Attachment #23306|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 23308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23308&action=edit Bug 7595 - Add branchcode to accountlines Adds a branchcode column to the accountlines table. For payments, this inserts the branchcode of the library where the payment was recorded. For manual invoices, it insert the branchcode of the library where the manual invoice was created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 18:55:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 17:55:44 +0000 Subject: [Koha-bugs] [Bug 11339] New: time due doesn't show on patron details page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11339 Bug ID: 11339 Summary: time due doesn't show on patron details page Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On the patron details page: /cgi-bin/koha/members/moremember.pl?borrowernumber=68248 the time due doesn't show at the bottom, but on the check out tab it does /cgi-bin/koha/circ/circulation.pl?borrowernumber=68248 - it should show in both places. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 19:11:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 18:11:09 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19631|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 23309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23309&action=edit [PASSED QA] Bug 6254 - can't set patron privacy by default There is currently no way to set the privacy setting for newly created patrons. This patch adds the system preference NewPatronPrivacySetting to define what privacy setting new patrons should have. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a new patron 4) Verify the patron's privacy is set to 1 5) Set NewPatronPrivacySetting to "never" 6) Create a new patron 7) Verify the patron's privacy is set to 2 8) Set NewPatronPrivacySetting to "forever" 9) Create a new patron 10) Verify the patron's privacy is set to 0 Signed-off-by: Liz Rea Tested per plan, all looks ok. Signed-off-by: Katrin Fischer Passes all tests and QA script. Additional tests done: - Verified syspref.sql insert works alright - Checked editing patrons left privacy untouched. - Checked importing patrons with overlay leaves privacy alone if not provided. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 19:13:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 18:13:21 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 --- Comment #14 from Kyle M Hall --- Created attachment 23310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23310&action=edit Bug 6254 - can't set patron privacy by default - QA Followup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 21:44:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 20:44:52 +0000 Subject: [Koha-bugs] [Bug 11340] New: make the 'print summary' a custom slip/notice Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 Bug ID: 11340 Summary: make the 'print summary' a custom slip/notice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Right now on the patron record the print slip and print quick slip are both customizable, but the print summary is not. I say this should also be a customizable via the notices & slips feature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 22:12:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 21:12:58 +0000 Subject: [Koha-bugs] [Bug 11341] New: XSS attack vendor in facets in OPAC - prog theme Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11341 Bug ID: 11341 Summary: XSS attack vendor in facets in OPAC - prog theme Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: chris at bigballofwax.co.nz QA Contact: testopia at bugs.koha-community.org If you craft some html in the offset variable, you can create an xss attack in the show more link in the facets. Patch to follow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 22:24:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 21:24:26 +0000 Subject: [Koha-bugs] [Bug 11341] XSS attack vendor in facets in OPAC - prog theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11341 --- Comment #1 from Chris Cormack --- Created attachment 23311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23311&action=edit Bug 11341 : XSS in opac-search.pl (facets) prog theme, bootstrap theme is safe To test 1/ Craft a url like cgi-bin/koha/opac-search.pl?idx=kw&q=fish&offset=20" onmouseover%3dprompt(994000) bad%3d" (the search must return enough results to have a show more link in the facets) 2/ Check the source, or mouseover the Show more links in the facets Notice the code is executable 3/ Apply patch - notice it is no longer executable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 22:24:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 21:24:23 +0000 Subject: [Koha-bugs] [Bug 11341] XSS attack vendor in facets in OPAC - prog theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11341 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 22:30:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 21:30:33 +0000 Subject: [Koha-bugs] [Bug 11341] XSS attack vendor in facets in OPAC - prog theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11341 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23311|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 23312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23312&action=edit Bug 11341 : XSS in opac-search.pl (facets) prog theme, bootstrap theme is safe To test 1/ Craft a url like cgi-bin/koha/opac-search.pl?idx=kw&q=fish&offset=20" onmouseover%3dprompt(994000) bad%3d" (the search must return enough results to have a show more link in the facets) 2/ Check the source, or mouseover the Show more links in the facets Notice the code is executable 3/ Apply patch - notice it is no longer executable Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 22:30:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 21:30:30 +0000 Subject: [Koha-bugs] [Bug 11341] XSS attack vendor in facets in OPAC - prog theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11341 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 22:57:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 21:57:10 +0000 Subject: [Koha-bugs] [Bug 11341] XSS attack vendor in facets in OPAC - prog theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11341 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 22:57:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 21:57:12 +0000 Subject: [Koha-bugs] [Bug 11341] XSS attack vendor in facets in OPAC - prog theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11341 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23312|0 |1 is obsolete| | --- Comment #3 from Brendan Gallagher --- Created attachment 23313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23313&action=edit [PASSED-QA] Bug 11341 : XSS in opac-search.pl (facets) prog theme, bootstrap theme is safe To test 1/ Craft a url like cgi-bin/koha/opac-search.pl?idx=kw&q=fish&offset=20" onmouseover%3dprompt(994000) bad%3d" (the search must return enough results to have a show more link in the facets) 2/ Check the source, or mouseover the Show more links in the facets Notice the code is executable 3/ Apply patch - notice it is no longer executable Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 23:02:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 22:02:12 +0000 Subject: [Koha-bugs] [Bug 11341] XSS attack vendor in facets in OPAC - prog theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11341 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 00:59:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2013 23:59:59 +0000 Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921 --- Comment #7 from M. Tompsett --- What if some administrator chose some other cron other than cron? For example, anacron? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 01:04:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 00:04:50 +0000 Subject: [Koha-bugs] [Bug 7934] Separate po file for help pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 23314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23314&action=edit Bug 7934 - Separate po file for help pages This patch modifies LangInstaller.pm to enable separation of translation for Staff UI and Staff Help files. It's a move that make sense, Help strings accounts for 44% of total word count for Staff, and as stated on Comment #1, it could enable a different workflow on translation work. It's more a hack than an elegant solution, but it works. Feel free to suggest another approach. To test: We need to test complete functionality, i.e. create and update translation files and install translation, and verify that no string is missing. 1) Before applying the patch, we need some data from staff file. Pick your language, say de_DE, and cd misc/translator/ perl translate update de-DE msginit -i po/de-DE-i-staff-t-prog-v-3006000.po -o de-old.po --no-translator --no-wrap --locale=de_DE egrep ^msgid de-old.po | sort | tee s-old | wc -l > number-old We have the file s-old with all strings, and the number of strings on number-old 2) Apply the patch 3) New help file is called de-DE-staff-help.po, so create one cp'ing old staff on new help cp po/de-DE-i-staff-t-prog-v-3006000.po po/de-DE-staff-help.po 4) Make a new update, and analize perl translate update de-DE msginit -i po/de-DE-i-staff-t-prog-v-3006000.po -o de-new.po --no-translator --no-wrap --locale=de_DE msginit -i po/de-DE-staff-help.po -o de-help.po --no-translator --no-wrap --locale=de_DE egrep ^msgid de-new.po | sort | tee s-new | wc -l > number-new egrep ^msgid de-help.po | sort | tee s-help | wc -l > number-help cat s-new s-help | sort | uniq | tee s-all | wc -l > number-all cat s-new s-help | sort | uniq -d | tee s-dup | wc -l > number-dup Ideally what we need to found is: diff s-old s-all = zero lines (old strings vs new strings) In my test I got one line, but it's a false positive (the string "? " is present on new staff) On numbers, number-old - number-new - nummber-help + number-dup = 0 or number-old - number-all = 0 (in my test again I have 1 as result, same string. Also there are 137 repeated lines between new staff and help) All this tells me that all string to translate are preserved 5) Install translation perl translate install de-DE Enable language on staff, and check that help files are translated 6) Finally, create translation files rm po/de-DE-* perl translate create de-DE verify that all files are created. Tests of 4) can be repeated. 7) Verify that no strings from help are present on staff UI file egrep help po/de-DE-i-staff-t-prog-v-3006000.po Only results came from help-top and bottom, and a few "help" on staff strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 01:05:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 00:05:16 +0000 Subject: [Koha-bugs] [Bug 7934] Separate po file for help pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 01:07:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 00:07:08 +0000 Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921 --- Comment #8 from Robin Sheat --- (In reply to M. Tompsett from comment #7) > What if some administrator chose some other cron other than cron? For > example, anacron? Anacron is a different thing that relies on cron to work. However, this is a fair point. We should depend on cron-daemon, which is a virtual package. 'cron' is the only thing that provides this, but in the future, this may change. $ apt-cache showpkg cron-daemon Package: cron-daemon Versions: Reverse Depends: request-tracker4,cron-daemon lyskom-server,cron-daemon logrotate,cron-daemon Dependencies: Provides: Reverse Provides: cron 3.0pl1-124ubuntu2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 01:09:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 00:09:28 +0000 Subject: [Koha-bugs] [Bug 11145] creating a guided report in non-english language fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11145 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- Hi Michel, I have tested this with German and it works for me, I can create Guided reports without problems. I think it might be a problem with the French translation files in 3.10.11 as they won't install correctly for me. To check if the bug is fixed in later versions I also tried 3.10.12. French templates install without errors in this version and crating guided reports worked nice. I am closing this bug, please reopen if I missed something. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 01:18:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 00:18:29 +0000 Subject: [Koha-bugs] [Bug 7255] Information on Holds Transfer Slips is Inconsistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7255 --- Comment #11 from Katrin Fischer --- Kyle, could you take a look at the patch on bug 10770? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 01:39:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 00:39:22 +0000 Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23307|0 |1 is obsolete| | --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 23315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23315&action=edit Bug 8921: koha-common*.deb should depend on cron Trivial patch to add 'cron-daemon' as dependency for the koha-common package. 'cron' is usually pulled in any minimal Ubuntu/Debian install, but in some circumstances (using debootstrap) it might be absent. As Robin said, this doesn't seem to have any side effects. Regards To+ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 01:45:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 00:45:35 +0000 Subject: [Koha-bugs] [Bug 11186] <> does not work as it appears in default notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11186 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- Hi Nicole, I think it works as expected: I tested <> outside of the tag for PREDUEDGST and DUEDGST which are the sample notices it appears in. It correctly prints the number of items predue or due. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 01:51:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 00:51:52 +0000 Subject: [Koha-bugs] [Bug 11341] XSS attack vector in facets in OPAC - prog theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11341 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|XSS attack vendor in facets |XSS attack vector in facets |in OPAC - prog theme |in OPAC - prog theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 02:17:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 01:17:19 +0000 Subject: [Koha-bugs] [Bug 11228] Explanation on 'patron notification' is not quite right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11228 --- Comment #1 from Katrin Fischer --- I have done some more digging to make sure, that routing lists and patron notification are unrelated. From reading the code this is the case, I have looked at getalert, SendAlerts and addalert - there is no reference to routing lists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 07:43:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 06:43:54 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Sarwar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ghulam.sarwar at techlogix.com --- Comment #43 from Sarwar --- Dear Sophie, I have made changes in the koha files according to the patch you had attached in this thread. But emails are still not generating and recipient does not receive any emails. I have also checked the at.allow and at.deny file. my at.deny file is empty that , according to my understanding , means all the users have the permissions to run task scheduler. Kindly help me with the solution ,as i am stuck on this from last few days. When i schedule a task using task scheduler. It showed me the following command under the action tab. export KOHA_CONF="/etc/koha/koha-conf.xml"; /usr/share/koha/intranet/cgi-bin/misc/cronjobs/runreport.pl --format csv --to ghulam.sarwar at techlogix.com 6 Looking forward to your reply. (In reply to Sophie MEYNIEUX from comment #11) > Test plan (as illustrated by Chris screenshots) > - Tools > Task scheduler > or > Reports > Use saved > Schedule (on the line of the report you want tu run) > - Select time, date, report to run (if not already chosen), output format, > mail to send the result. > - Click on Save > > Scheduled report is added to the table of existing scheduled reports under > the form. > > Without the patch, after planned time, if you refresh the page, scheduled > report is not displaied anymore, but report is not run and no mail is sent. > > With the patch, after planned time, recipient receive a mail containing the > result of the report in plain text or attached as csv file d?pending of > choosen option. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 07:52:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 06:52:06 +0000 Subject: [Koha-bugs] [Bug 9057] Add support for authorities to NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9057 --- Comment #1 from Magnus Enger --- Yay, looks like this will be easier than I thought, just need to: - Copy the autorities frameworks from MARC21 to NORMARC - Add $9 to relevant fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 08:02:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 07:02:56 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 Doug Kingston changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #36 from Doug Kingston --- These two patches should do the trick. Ready for re-review and QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 09:33:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 08:33:29 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9852 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 09:33:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 08:33:29 +0000 Subject: [Koha-bugs] [Bug 9852] Add interlibrary loan request form to the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9852 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7317 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:51:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 12:51:54 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 14:00:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 13:00:41 +0000 Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 14:01:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 13:01:40 +0000 Subject: [Koha-bugs] [Bug 8368] List email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 14:02:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 13:02:24 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 14:02:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 13:02:27 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23256|0 |1 is obsolete| | --- Comment #9 from Fridolin SOMERS --- Created attachment 23316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23316&action=edit Bug 6331 Do not populate marc in deleted items This is supplementary to the main patch for bug 6331. Having removed the attribute marc from items DelItem should not populate it Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 14:04:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 13:04:10 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23316|Bug 6331 Do not populate |[SIGNED-OFF]Bug 6331 Do not description|marc in deleted items |populate marc in deleted | |items --- Comment #10 from Fridolin SOMERS --- Comment on attachment 23316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23316 [SIGNED-OFF]Bug 6331 Do not populate marc in deleted items Tested by applying the 2 patches, deleting an item and check that item is moved from table items to table deleteditems. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 14:12:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 13:12:04 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 --- Comment #11 from mathieu saby --- hello I suspect this line for copying marc column was only here to update the timestamp of deleteditems table. With your patch, is the timestamp still updated? Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 14:23:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 13:23:10 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 14:23:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 13:23:13 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23309|0 |1 is obsolete| | Attachment #23310|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 23317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23317&action=edit Bug 6254 - can't set patron privacy by default There is currently no way to set the privacy setting for newly created patrons. This patch adds a new field "default privacy" to the patron categories such that each patron category may have a different default privacy setting. Test Plan: 1) Apply this patch 2) Edit a patron category, change the default privacy to "forever" 3) Create a new patron of that category 4) Log into the catalog as that patron, verify the privacy setting is set to "forever" 5) Repeat steps 2-4 with the settings "never" and "default" -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 14:57:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 13:57:45 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #12 from M. de Rooy --- (In reply to mathieu saby from comment #11) > hello > I suspect this line for copying marc column was only here to update the > timestamp of deleteditems table. > With your patch, is the timestamp still updated? > > Mathieu Just jumping in this discussion: But I would not like to loose the timestamp in deleteditems or deletedbiblio.. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:13:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:13:36 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 --- Comment #13 from Fridolin SOMERS --- (In reply to mathieu saby from comment #11) In my test, timestamp value is copied from table items. It does not get the current timestamp. @M. de Rooy : If timestamp is not updated, how do we know the date/time of deletion ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:15:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:15:05 +0000 Subject: [Koha-bugs] [Bug 11342] New: Error with opac self registration if BorrowersTitles is empty Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11342 Bug ID: 11342 Summary: Error with opac self registration if BorrowersTitles is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If BorrowersTitles is empty, it causes the library pulldown on the self registration page to be empty, and to have the "Saluation" field have the option "branches". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:15:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:15:11 +0000 Subject: [Koha-bugs] [Bug 11342] Error with opac self registration if BorrowersTitles is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11342 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:15:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:15:52 +0000 Subject: [Koha-bugs] [Bug 11343] New: The max number of items to process in a batch is hardcoded Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 Bug ID: 11343 Summary: The max number of items to process in a batch is hardcoded Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org The maximum number of item records to process in a batch is 1000. This value is hardcoded in the code. It should be store in a syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:18:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:18:42 +0000 Subject: [Koha-bugs] [Bug 11342] Error with opac self registration if BorrowersTitles is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11342 --- Comment #1 from Kyle M Hall --- Created attachment 23318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23318&action=edit Bug 11342 - Error with opac self registration if BorrowersTitles is empty If BorrowersTitles is empty, it causes the library pulldown on the self registration page to be empty, and to have the "Saluation" field have the option "branches". This patch also fixes a minor string capitalization issue. Test Plan: 1) Enable OPAC self registration 2) Set the system preference BorrowersTitles to be empty 3) View the self registration page 4) Note the lack of branches in the home library pulldown 5) Apply this patch 6) Note the branches now display in the pulldown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:18:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:18:39 +0000 Subject: [Koha-bugs] [Bug 11342] Error with opac self registration if BorrowersTitles is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11342 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:19:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:19:53 +0000 Subject: [Koha-bugs] [Bug 11070] typo in UNIMARC 115a plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11070 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:21:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:21:04 +0000 Subject: [Koha-bugs] [Bug 11058] Compile time warning issued by C4/Record.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11058 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:22:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:22:56 +0000 Subject: [Koha-bugs] [Bug 11015] Copyright headers are missing in some packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11015 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:23:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:23:49 +0000 Subject: [Koha-bugs] [Bug 11100] Label in staff client - Topics on facets not easily css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11100 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Raewyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:24:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:24:23 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 --- Comment #14 from mathieu saby --- (In reply to Fridolin SOMERS from comment #13) > (In reply to mathieu saby from comment #11) > In my test, timestamp value is copied from table items. It does not get the > current timestamp. > > @M. de Rooy : > If timestamp is not updated, how do we know the date/time of deletion ? I made some reports recently on my Koha (v 3.11). Timestamp of deleteditems were updated when we delete them. So this behavior must be keep in 3.14 :-) Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:27:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:27:07 +0000 Subject: [Koha-bugs] [Bug 11107] Label in staff client - authors on facets not easily accessible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11107 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Sue! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:28:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:28:08 +0000 Subject: [Koha-bugs] [Bug 11106] Label item type facet in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11106 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Katherine! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:29:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:29:02 +0000 Subject: [Koha-bugs] [Bug 11102] Label in Staff Client - places on facets not easily css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11102 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jennifer and Gab! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:32:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:32:21 +0000 Subject: [Koha-bugs] [Bug 11098] Label in Opac - topics on facets not easily css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11098 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Andrew! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:36:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:36:35 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:36:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:36:38 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 --- Comment #1 from Jonathan Druart --- Created attachment 23319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23319&action=edit Bug 11343: The max number of items to process in a batch is hardcoded Until now, the maximum number of item records to process in a batch was hardcoded to 1000. This patch adds a syspref MaxItemsForBatch in order to allow to adapt this value. Test plan: - set the pref to 2 - try to delete a batch of 3 items: they are not displayed - try to modify a batch of 3 items: you are not allowed to do that - set the pref to 1000 and try again. Now items are displayed and you are allow to modify them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:36:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:36:46 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:40:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:40:19 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 --- Comment #15 from Fridolin SOMERS --- Created attachment 23320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23320&action=edit Bug 6331 - Update timestamp when deleting items When item is transfered from items table to deleted items, all fields must be copies but "timestamp". This value must be updated to know when item has been deleted. Test plan: - Look a an item timestamp : mysql> select timestamp from items where itemnumber = 2690; +---------------------+ | timestamp | +---------------------+ | 2011-09-09 15:30:21 | +---------------------+ 1 row in set (0.00 sec) - Delete this item in cataloguing module - Check it is not in items table anymore : mysql> select timestamp from items where itemnumber = 2690; Empty set (0.00 sec) - Look in deleteditems table : mysql> select timestamp from deleteditems where itemnumber = 2690; +---------------------+ | timestamp | +---------------------+ | 2013-12-05 15:33:20 | +---------------------+ 1 row in set (0.00 sec) => timestamp as been set to actual date/time -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:40:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 14:40:48 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #16 from Fridolin SOMERS --- Set as need signoff for 3rd patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:16:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 15:16:16 +0000 Subject: [Koha-bugs] [Bug 10829] Browse across pages breaks for authority searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:17:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 15:17:04 +0000 Subject: [Koha-bugs] [Bug 9192] UNIMARC_sync_date_created_with_marc_biblio.pl field creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #21 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:18:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 15:18:04 +0000 Subject: [Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:19:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 15:19:04 +0000 Subject: [Koha-bugs] [Bug 10889] wrong description for a column of biblio table in kohastructure.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:19:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 15:19:43 +0000 Subject: [Koha-bugs] [Bug 11097] Hide duplicate patron button if logged in user lacks CAN_user_borrowers permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:20:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 15:20:07 +0000 Subject: [Koha-bugs] [Bug 10954] Payment receipt does not display the payment made In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:22:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 15:22:58 +0000 Subject: [Koha-bugs] [Bug 10785] dropbox should be book drop In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10785 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Ketan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:25:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 15:25:58 +0000 Subject: [Koha-bugs] [Bug 10982] Link to IFLA UNIMARC documentation in Cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Fr?d?ric! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:26:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 15:26:29 +0000 Subject: [Koha-bugs] [Bug 11099] Label in Staff Client - series on facets not easily css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11099 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonet! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:27:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 15:27:48 +0000 Subject: [Koha-bugs] [Bug 11002] Mandatory fields are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11002 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:28:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 15:28:05 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #52 from Galen Charlton --- Pushed to master. Thanks, Tom?s and Srdjan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:28:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 15:28:27 +0000 Subject: [Koha-bugs] [Bug 11003] JS error on the cart page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:55:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 15:55:40 +0000 Subject: [Koha-bugs] [Bug 11111] The basket group is not displayed on the parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master, along with a follow-up correcting column sorting. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:58:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 15:58:39 +0000 Subject: [Koha-bugs] [Bug 11104] Label in opac topics in facets not easily css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11104 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Tim! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 17:17:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 16:17:16 +0000 Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #16 from Galen Charlton --- I agree with Katrin's statements that the way that this patch implements limits assumes things that are simply not true for default MARC21 installations of Koha, where the item type and collection code simply are not biblio-level attributes. However, this is an improvement over the status quo, so I've pushed this to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 17:23:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 16:23:18 +0000 Subject: [Koha-bugs] [Bug 11101] Item Type label in OPAC not easily css selectable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11101 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Claire! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 17:39:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 16:39:19 +0000 Subject: [Koha-bugs] [Bug 2310] Delete grayed out w/out explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 17:40:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 16:40:33 +0000 Subject: [Koha-bugs] [Bug 2310] Delete grayed out w/out explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22456|0 |1 is obsolete| | --- Comment #9 from Galen Charlton --- Comment on attachment 22456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22456 [PASSED QA] Bug 2310 - Delete grayed out w/out explanation Looks like this bug is an omnibus, so obsoleting the patch that was pushed and setting back to assigned. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 17:40:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 16:40:45 +0000 Subject: [Koha-bugs] [Bug 2310] Delete grayed out w/out explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 17:46:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 16:46:15 +0000 Subject: [Koha-bugs] [Bug 10607] JavaScript indexOf function not supported by IE 7 and 8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10607 --- Comment #4 from Galen Charlton --- I've found one template in the Bootstrap theme that is affected: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 17:52:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 16:52:55 +0000 Subject: [Koha-bugs] [Bug 9977] OMNIBUS, remove accidental 'merge marker' strings from Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9977 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Galen Charlton --- '<<<<' or '>>>>' isn't the pattern to look for. What you want is '^<<<<<' and '^>>>>>'. Fortunately, there is already a test for this: t/00-merge-conflict-markers.t. In principle, one could also look for '^=====', but there are a bunch of files that do that legitimately (e.g., the release notes). Since this issue is already handled, in other words, I'm marking this resolved/invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 18:16:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 17:16:53 +0000 Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21882|0 |1 is obsolete| | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 18:47:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 17:47:00 +0000 Subject: [Koha-bugs] [Bug 11344] New: Perldoc issues in misc/cronjobs/advance_notices.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11344 Bug ID: 11344 Summary: Perldoc issues in misc/cronjobs/advance_notices.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: bartonski at gmail.com QA Contact: testopia at bugs.koha-community.org perldoc misc/cronjobs/advance_notices.pl shows the following: NAME advance_notices.pl - cron script to put item due reminders into message queue SYNOPSIS ./advance_notices.pl -c or, in crontab: 0 1 * * * advance_notices.pl -c DESCRIPTION This script prepares pre-due and item due reminders to be sent to patrons. It queues them in the message queue, which is processed by the process_message_queue.pl cronjob. The type and timing of the messages can be configured by the patrons in their "My Alerts" tab in the OPAC. NAME advance_notices.pl - prepare messages to be sent to patrons for nearly due, or due, items SYNOPSIS advance_notices.pl [ -n ][ -m ][ --itemscontent ][ -c ] OPTIONS --help Print a brief help message and exits. --man Prints the manual page and exits. -v Verbose. Without this flag set, only fatal errors are reported. -n Do not send any email. Advanced or due notices that would have been sent to the patrons are printed to standard out. -m Defines the maximum number of days in advance to send advance notices. --itemscontent comma separated list of fields that get substituted into templates in places of the <> placeholder. This defaults to due date,title,author,barcode Other possible values come from fields in the biblios, items and issues tables. DESCRIPTION This script is designed to alert patrons when items are due, or coming due ... =============================================== Issues: NAME SYNOPSIS DESCRIPTION Occur twice. The sections are not duplicates. One version should be chosen for each section. -c (Confirm that the user has read and configured this script.) is not documented in OPTIONS. Here are the comments where $confirm is defined, as well as the call to GetOptions: 161 # These are defaults for command line options. 162 my $confirm; # -c: Confirm that the user has read and configured this script. 163 # my $confirm = 1; # -c: Confirm that the user has read and configured this script. 164 my $nomail; # -n: No mail. Will not send any emails. 165 my $mindays = 0; # -m: Maximum number of days in advance to send notices 166 my $maxdays = 30; # -e: the End of the time period 167 my $verbose = 0; # -v: verbose 168 my $itemscontent = join(',',qw( date_due title author barcode )); 169 170 my $help = 0; 171 my $man = 0; 172 173 GetOptions( 174 'help|?' => \$help, 175 'man' => \$man, 176 'c' => \$confirm, 177 'n' => \$nomail, 178 'm:i' => \$maxdays, 179 'v' => \$verbose, 180 'itemscontent=s' => \$itemscontent, 181 )or pod2usage(2); 182 pod2usage(1) if $help; 183 pod2usage( -verbose => 2 ) if $man;; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:06:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:06:44 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #184 from Jacek Ablewicz --- Looks like there is (somehow) similar bug also in circ/view_holdsqueue.tt . It only manifests itself if there are non-latin characters in collection code (authorised value CCODE) descriptions. Possible fixes: 1) Like in bug 11290 - inserting ' |html_entity' in line 80, after "KohaAuthorisedValues.GetByCode( 'CCODE', itemsloo.ccode )" 2) Replacing KohaAuthorisedValues template plugin with AuthorisedValues plugin. But why are there two different TT plugin versions in the first place; shouldn't AuthorisedValues be used (everywhere) instead of KohaAuthorisedValues ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:21:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:21:43 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #37 from Galen Charlton --- In addition to the specific points that Chris has made -- which, to be frank, do not inspire confidence that the rewrite patch has been sufficiently tested by the patch submitter -- this patch is simply too large to evaluate as is. I *strongly* encourage you to break it up into a series of patches that, in effect, tell a story that can be evaluated, or at least read, a patch at a time. A possible sequence might look like this: * test cases: this is an opportunity for the test cases to describe the new API and provide some confidence that all aspect of the existing behavior have been covered. * DB schema updates * schema upgrade -- as this will require particularly close attention * introduction of the new API in the Koha namespace * elimination of the old C4 API and staff-side script changes * public catalog-side changes Other ways of organizing it are of course possible, but the main point is to break it up into smaller units that can be read one at a time, even if the entire series has to be applied for it to work at all. It would be even better, although not necessarily possible, to structure the patch series in such a way that parts of it can be independently applied. Also, to reiterate the point in my first paragraph: the more that you take care to eliminate debug code and trivial violations of the QA guidelines, the easier it will be for patch reviewers to focus on the substance. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:27:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:27:16 +0000 Subject: [Koha-bugs] [Bug 10974] OAI-PMH Resumption Tokens Do Not Handle Time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10974 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:27:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:27:43 +0000 Subject: [Koha-bugs] [Bug 10445] SIP Server doesn't respect maxoutstanding system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:28:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:28:46 +0000 Subject: [Koha-bugs] [Bug 10283] Hide "many items" on second tab when using OpacSeparateHoldings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:29:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:29:23 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |2456 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:29:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:29:23 +0000 Subject: [Koha-bugs] [Bug 2456] Moving some C4::VirtualShelves subs from EXPORT to EXPORT_OK In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2456 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6427 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:29:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:29:42 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|2456 |2546 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:29:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:29:42 +0000 Subject: [Koha-bugs] [Bug 2456] Moving some C4::VirtualShelves subs from EXPORT to EXPORT_OK In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2456 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|6427 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:29:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:29:42 +0000 Subject: [Koha-bugs] [Bug 2546] Description of charges: string hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6427 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:29:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:29:55 +0000 Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #9 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Owen! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:30:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:30:27 +0000 Subject: [Koha-bugs] [Bug 11108] undoing receiving does not appear to work (but actually does) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11108 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Galen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:31:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:31:27 +0000 Subject: [Koha-bugs] [Bug 10750] Correct capitalization on suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:32:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:32:35 +0000 Subject: [Koha-bugs] [Bug 10271] An index containing ns or nb does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:33:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:33:28 +0000 Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text description change In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:34:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:34:26 +0000 Subject: [Koha-bugs] [Bug 10243] Holds queue is making transfer requests that contradict the branch holds policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10243 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Kyle! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:47:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:47:03 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:47:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:47:09 +0000 Subject: [Koha-bugs] [Bug 2546] Description of charges: string hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:47:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:47:18 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23281|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 23321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23321&action=edit [SIGNED OFF] Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks This patch tries to make MARC21 bibliographic frameworks internally consistent. It modifies field/subfield descriptions of simple_bib and fastadd frameworks to match corresponding ones of default framework. To test: 1) Download and edit the attached script, check-diff.sh Put on it user, pass and database name of your dev install Copy the script on your git home 2) Run the script (bash check-diff.sh). WARNING: the script removes bibliographic frameworks, and load default, simple_bib and fastadd ones. It will show on screen, and write on file differences.txt, any difference on field/subfield description (liblibrarian) between any framework and default On master it will show a lot of lines 3) Apply the patch 4) Run the script again. Frameworks files must load without problem. There will be no differences NOTE: There are many "space" changes. The reason to that is to format files to ease the translation process. Not related with this bug, but necessary. Also a few changes on default framework. Signed-off-by: Katrin Fischer I ran some tests and found one more case where the liblibrarian and libopac columns had slightly different descriptions, adding a follow-up for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:47:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 18:47:37 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 --- Comment #8 from Katrin Fischer --- Created attachment 23322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23322&action=edit Bug 11330: Follow-up - Inconsistent field/subfield descriptions on MARC21 bibiographic frameworks Fixes one missing for 951 field description in the Default framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:00:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 19:00:24 +0000 Subject: [Koha-bugs] [Bug 10776] Subscription notification screen has awkward wording In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:00:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 19:00:49 +0000 Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:02:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 19:02:08 +0000 Subject: [Koha-bugs] [Bug 9374] In baskets, prices between 0 and 1 are displayed in red In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9374 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:02:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 19:02:28 +0000 Subject: [Koha-bugs] [Bug 11265] Problems with locale saving/editing on serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:09:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 19:09:31 +0000 Subject: [Koha-bugs] [Bug 11263] New 'locale' setting in subscriptions is not user friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- (In reply to Katrin Fischer from comment #7) > Apart from that I still think this could be a good candidate for an > authorized value or a small table. Installing languages takes time, updates > are often forgotten when you don't actually use them etc. And it would allow > for entering "custom" seasons, like abbreviated versions, fall instead of > autumn etc. > If we had a pref/tool wherepeople can change it, this could also allow to > have other custom patterns. Agreed -- I'm not a big fan of relying on system locales for getting month and day names (with the exception of considering their use for command-line utilities, since one would be logged into the server anyway), for several reasons: - it creates an extra point of breakage for the naive user - they can't be customized - since they don't cover seasons, currently only English and French are supported for season names. A mechanism that would allow the user to set season names would be trivial to extend to month and day names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:46:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 19:46:43 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |MOVED --- Comment #185 from Chris Cormack --- Please can we open new bugs for each instance, with new valid patches, this bug is impossible to maintain any more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:46:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 19:46:45 +0000 Subject: [Koha-bugs] [Bug 10070] History of anonymous searches is not kept In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Bug 10070 depends on bug 6554, which changed state. Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:46:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 19:46:45 +0000 Subject: [Koha-bugs] [Bug 10019] Encoding problem with utf8 chars in userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10019 Bug 10019 depends on bug 6554, which changed state. Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:46:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 19:46:45 +0000 Subject: [Koha-bugs] [Bug 9951] Resolve encoding problems where script parameters are not decoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9951 Bug 9951 depends on bug 6554, which changed state. Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:46:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 19:46:45 +0000 Subject: [Koha-bugs] [Bug 10074] Encoding problems for login and installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10074 Bug 10074 depends on bug 6554, which changed state. Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:50:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 19:50:12 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Jen DeMuth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:50:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 19:50:24 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23279|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:50:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 19:50:31 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 23323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23323&action=edit Bug 11334 - Add facet for home library The current "Library" facet is somewhat ambiguous for Koha installations with multiple libraries. It refers to the holdingbranch, but does not explicitly state this. It would be beneficial to allow the administrator to choose to show facets for the holding library, home library, or both. In addition, the facets should be more explicitly labeled. Test plan: 1) Apply this patch 2) Check that the facets label "Libraries" now reads "Holding libraries" 3) Update the system preference DisplayLibraryFacets to "home library" 4) Check that the facet now reads "Home libraries" 5) Update the preference again to "both home and holding library" 6) Check that both the facets for home and holding library are now displayed. Signed-off-by: Jen DeMuth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 21:58:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 20:58:18 +0000 Subject: [Koha-bugs] [Bug 2546] Description of charges: string hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:10:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 21:10:34 +0000 Subject: [Koha-bugs] [Bug 11228] Explanation on 'patron notification' is not quite right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11228 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:10:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 21:10:37 +0000 Subject: [Koha-bugs] [Bug 11228] Explanation on 'patron notification' is not quite right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11228 --- Comment #2 from Katrin Fischer --- Created attachment 23324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23324&action=edit Bug 11228: Improve hint on patron notification when adding/editing subscriptions The hint was not quite correct, as it said patrons on the routing list would be informed, but it's the patrons that have subscribed to email notifications in the OPAC, that will receive the email when a new serial issue is received. To test: - Add a new subscription, find the hint about patron notification on the form - Apply patch - Refresh page - Verify the new hint text makes sense and is correct -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:12:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 21:12:09 +0000 Subject: [Koha-bugs] [Bug 11228] Explanation on 'patron notification' is not quite right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11228 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |--- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:23:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 21:23:52 +0000 Subject: [Koha-bugs] [Bug 11261] Sample frequencies and numbering patterns should better be mandatory on install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11261 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23036|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 23325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23325&action=edit [SIGNED OFF] Bug 11261: Sample frequencies and numbering patterns should better be mandatory on install Test plan: Verify all sample_numberpatterns.* files have been moved from optional to mandatory directories. Signed-off-by: Katrin Fischer All sample files for numbering patterns are moved from optional to mandatory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:25:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 21:25:19 +0000 Subject: [Koha-bugs] [Bug 11261] Sample frequencies and numbering patterns should better be mandatory on install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11261 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from Katrin Fischer --- Hi Jonathan, the first patch is ok, but you are only moving the numbering patterns - what do you think about also moving the frequencies? (sample_frequencies.txt/.sql) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:28:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 21:28:40 +0000 Subject: [Koha-bugs] [Bug 11266] Z39.50 search results: DATE blank - add PUBLISHER In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11266 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Andrea, this looks quite good - do you think you could provide a git formatted patch? There is only one small thing about this change: $row_data{date} = $oldbiblio->{copyrightdate}; in $row_data{date} = $oldbiblio->{publicationyear}; The problem here is that for MARC21 copyrightdate has the right date, but for UNIMARC installations it's publicationyear. So it would need to check both fields in the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:46:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 21:46:13 +0000 Subject: [Koha-bugs] [Bug 11346] New: Deprecate the PROG and CCSR themes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11346 Bug ID: 11346 Summary: Deprecate the PROG and CCSR themes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org This is a master bug for keeping track of all of the known issues related to the upcoming deprecation of the PROG and CCSR themes for the OPAC. Bugs for things that need to be removed should be blockers for this one. As of 3.14, bootstrap is the new default theme for the OPAC, and libraries are highly encouraged to switch their theming prior to deprecation in 3.18 because of its enhanced feature set (it is responsive) and modern styling. The proposal regarding theme deprecation as accepted on 2013-11-01 is as follows: [1] We ship Bootstrap as the default theme for 3.14 for new installations. (DONE) [2] We announce deprecation of prog and CCSR when 3.14 is released and issue a recommendation that libraries start switching to Bootstrap. (DONE) [3] At the same time, we announce that prog and CCSR will be removed in 3.18. If some organization wishes to maintain either theme after then, they can do so, but as a separate contrib. However, if you are inclined to support either theme after they've been removed ... please think carefully about the amount of work that would entail. [4] The RM will assist in getting OPAC template patches in the pipeline that were written for prog updated to support Bootstrap as well. [5] Starting with the 3.16, new OPAC patches should be targeted for Bootstrap first. During the 3.16 cycle, contributors are requested to make an effort to update the prog theme as well, particularly for new features, but this is a request, not a requirement. In other words, this means that for 3.16, libraries may need to switch to Bootstrap to take full advantage of new OPAC functionality, but the prog theme will continue to be functional. [6] During the 3.18 cycle, no patches will be pushed for prog except insofar as they may be needed to fix security issues in the maintenance releases. Before 3.18 is released, prog and CCSR will be taken out entirely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:49:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 21:49:24 +0000 Subject: [Koha-bugs] [Bug 11346] Deprecate the PROG and CCSR themes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11346 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11347 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:49:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 21:49:24 +0000 Subject: [Koha-bugs] [Bug 11347] New: PROG/CCSR deprecation: Remove opacsmallimage system-preference Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Bug ID: 11347 Summary: PROG/CCSR deprecation: Remove opacsmallimage system-preference Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Blocks: 11346 the opacsmallimage system preference is unused in the bootstrap theme, it should be removed when the themes are removed. To replace the functionality of customizing the logo in the top corner, one would use CSS to change the background of #logo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 23:11:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 22:11:30 +0000 Subject: [Koha-bugs] [Bug 3246] Looking for a way to customize the patron slips (receipts) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 23:11:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 22:11:48 +0000 Subject: [Koha-bugs] [Bug 7001] User Configurable Slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 23:15:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 22:15:23 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #21 from Katrin Fischer --- Hm, looking at David's and Bernardo's conversation I think this needs a bit more work. I think we'd need to copy the standard framework, but keep the hidden values of the current simple frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 23:25:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 22:25:56 +0000 Subject: [Koha-bugs] [Bug 11333] use jQuery validator plugin for CSV profile forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 23:26:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 22:26:00 +0000 Subject: [Koha-bugs] [Bug 11333] use jQuery validator plugin for CSV profile forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23287|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 23326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23326&action=edit [PASSED QA] Bug 11333: use jQuery validator plugin for CSV profiles forms This patch adds the use of the jQuery validator plugin for the two forms (new and edit) on the CSV profiles page. Doing this standardizes messages that gets displayed on validation errors. This patch, in the process, fixes a bug where if a page has more than one validated form, only the first such form would get the validator plugin applied to it -- it looks like $.validate() does not do implicit iteration. To test: [1] Apply the patch, then go to Tools | CSV profiles. [2] Create a new profile, but leave the name and the MARC/SQL fields blank. When you click the submit button, the form should not be submitted; instead, text will be displayed to the right of each input that lacks required input. [3] As above, but change the profile type and verify that the form is not submitted unless all of the required fields are filled in. [4] Edit an existing form, then empty the MARC/SQL field. Try submitting the form; it should refuse to submit the form and display text saying that the field is required. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Fixed some tabs, works nicely and as described. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 23:36:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 22:36:40 +0000 Subject: [Koha-bugs] [Bug 1153] opac-userupdate.pl update to allow moderation, and templatize In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1153 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 23:36:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 22:36:47 +0000 Subject: [Koha-bugs] [Bug 1153] opac-userupdate.pl update to allow moderation, and templatize In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1153 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 23:41:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 22:41:48 +0000 Subject: [Koha-bugs] [Bug 1047] Punctuation in site names breaks Edit/Delete z39.50 server administration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1047 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #3 from Katrin Fischer --- I tested this with the example "UNIVERSITY OF BC, LAW LIB" in current master (3.15) and it works nicely. Deleting and editing is no problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 23:56:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 22:56:51 +0000 Subject: [Koha-bugs] [Bug 2465] availability of a reserved book In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- Tested with the current master branch: Detail in OPAC: On hold Results in OPAC: On hold (x) Detail in staff: Waiting for Koha Admin at Midway since 12/05/2013 Results in staff: 2 items, None available 2 unavailable: Midway [320] (On hold) (1) Books Midway (On hold) (1) Books And this is, where something goes wrong as only 1 of the 2 items is on hold. But this is different to this bugs description, so I am going to investigate and file a new bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 00:03:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 23:03:17 +0000 Subject: [Koha-bugs] [Bug 11348] New: Wrong unavailability information for 'on hold' items in staff client result list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11348 Bug ID: 11348 Summary: Wrong unavailability information for 'on hold' items in staff client result list Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 23327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23327&action=edit Wrong display in staff results To reproduce: - Create a record with 2 items - Create a hold on one of the items (you might have to check it out first, depending on your configuration) - Check the item in, confirm the hold. The hold is now available for pickup. - Check the staff client result list - both items show up as unavailable, while only one is. Make sure you Zebra index is up to date, when testing this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 00:07:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 23:07:25 +0000 Subject: [Koha-bugs] [Bug 11348] Wrong unavailability information for 'on hold' items in staff client result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11348 --- Comment #1 from Katrin Fischer --- Created attachment 23328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23328&action=edit Correct availability display on the details page And a screenshot of the detail page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 00:07:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 23:07:32 +0000 Subject: [Koha-bugs] [Bug 11348] Wrong unavailability information for 'on hold' items in staff client result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 00:11:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 23:11:30 +0000 Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6427 Assignee|koha.sekjal at gmail.com |koha-bugs at lists.koha-commun | |ity.org --- Comment #5 from Katrin Fischer --- Something to look out for when testing the accounts rewrite :) -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 00:11:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 23:11:30 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2696 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 00:16:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 23:16:56 +0000 Subject: [Koha-bugs] [Bug 2735] authority search stops at 15 pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- This bug is still valid: When a search returns more than 15 pages of results, the correct number of results is shown, but the pages you can access are limited to 15. << 1 2 3 4 5 6 7 8 9 10 11 12 13 14 _15_ >> Ergebnisse 281 bis 300 von 1876 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 00:19:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 23:19:38 +0000 Subject: [Koha-bugs] [Bug 2778] Search Also missing from subfied framework edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10012 Resolution|--- |WONTFIX --- Comment #3 from Katrin Fischer --- There is already a bug for removing this reference to the NoZebra feature - closing this WONTFIX with a 'See also' link to bug 10012. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 00:19:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 23:19:38 +0000 Subject: [Koha-bugs] [Bug 10012] Remove all traces of NoZebraIndexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2778 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 00:23:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 23:23:02 +0000 Subject: [Koha-bugs] [Bug 2889] templates should use loop_context_vars __odd__ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #8 from Katrin Fischer --- Owen, could you take a look and check if this bug is still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 00:29:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 23:29:20 +0000 Subject: [Koha-bugs] [Bug 3060] Add information to identify item level holds to holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3060 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|item number not on holds to |Add information to identify |pull report |item level holds to holds | |to pull report --- Comment #2 from Katrin Fischer --- This is still valid for current master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 00:37:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 23:37:16 +0000 Subject: [Koha-bugs] [Bug 3896] Notices: Cant specify if a notice is available as a digest or in advance in the web interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3896 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- I am not sure if I understand this bug report correctly - but I think this is working alright. Which notices can be sent out as digests or in advance is hardcoded, as it needs to be implemented in the code. When you install Koha with all mandatory information, this is set up correctly. Due and Predue notices have options for a digest version and only advance notices can be sent in advance. You can define a standard setting by patron category and then change it for each patron during editing or updating. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 00:40:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 23:40:22 +0000 Subject: [Koha-bugs] [Bug 3904] Serial add item screen contains extra fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3904 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- I can't reproduce this with the standard Default framework on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 00:47:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2013 23:47:54 +0000 Subject: [Koha-bugs] [Bug 3953] Patrons w/ no checkouts report does nothing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3953 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #4 from Katrin Fischer --- I think there is some confusion in this bug report. The title and URL refer to the report 'Patrons with no checkouts' (catalog_out.pl). This has seen some work lately and works nicely in my tests. But some of the screenshots are from 'Patrons with the most checkouts'. It's a bit hard to tell what's wrong there in the example given without seeing the SQL of the SQL report. Also testing this report on master the results look ok to me and seem to inclue issues and old_issues. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 01:04:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 00:04:32 +0000 Subject: [Koha-bugs] [Bug 5597] holds to pull showing wrong item for item specific holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5597 --- Comment #5 from Katrin Fischer --- *** Bug 3060 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 01:04:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 00:04:32 +0000 Subject: [Koha-bugs] [Bug 3060] Add information to identify item level holds to holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3060 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 5597 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 01:05:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 00:05:32 +0000 Subject: [Koha-bugs] [Bug 4528] Holds to Pull Report not showing right item numbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 5597 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 01:05:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 00:05:32 +0000 Subject: [Koha-bugs] [Bug 5597] holds to pull showing wrong item for item specific holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5597 --- Comment #6 from Katrin Fischer --- *** Bug 4528 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 01:10:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 00:10:09 +0000 Subject: [Koha-bugs] [Bug 5319] frequency seasonal generate a season called "nothing" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5319 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- This has been fixed with the serials 'rewrite' in 3.14. There are still some bugs about the implementation of seasonal, but there is no 5th empty season, so closing this fixed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 01:11:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 00:11:01 +0000 Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|cannot reopen a basket |It should be more clear how | |to reopen a basket in a | |basket group -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 01:16:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 00:16:55 +0000 Subject: [Koha-bugs] [Bug 6172] Non-French UNIMARC frameworks need to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6172 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Zebra not indexed |Non-French UNIMARC |Unimarc-records |frameworks need to be | |updated -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 01:23:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 00:23:11 +0000 Subject: [Koha-bugs] [Bug 6644] inventory tool doesn't work with shelving location In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6644 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- This is working nicely for me on current master/3.14. There has been a bigger patch to the inventory tool in 3.14, I think this could have fixed it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 01:38:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 00:38:00 +0000 Subject: [Koha-bugs] [Bug 6951] item field changes not saving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6951 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- Both fields save nicely on current master: - $3 = Materials specified (bound volume or other part) - $f = Coded location qualifier -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 01:39:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 00:39:57 +0000 Subject: [Koha-bugs] [Bug 5002] No error message if category code already exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 --- Comment #2 from Katrin Fischer --- Still valid - Paul, this bug is assigned to you? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 01:46:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 00:46:31 +0000 Subject: [Koha-bugs] [Bug 7214] Changing framework with 'edit as duplicate' can cause data loss In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7214 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|can't change framework when |Changing framework with |editing record as duplicate |'edit as duplicate' can | |cause data loss -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 01:47:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 00:47:56 +0000 Subject: [Koha-bugs] [Bug 7237] duplicating patron not using patron's branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7237 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Still behaves as described on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 01:52:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 00:52:56 +0000 Subject: [Koha-bugs] [Bug 7315] Remove deprecated notifyMailsOp.pl cronjob In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7315 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- File has been removed: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=00894ac49544625b83fab7cb242bc3160429b938 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 01:58:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 00:58:19 +0000 Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha.sekjal at gmail.com |koha-bugs at lists.koha-commun | |ity.org Summary|edit hold from patron |Change pickup location of a |record |hold from patron record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 02:16:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 01:16:26 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #12 from Katrin Fischer --- Currently the oldest open bug... you know you want to fix it! ;) -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 02:31:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 01:31:51 +0000 Subject: [Koha-bugs] [Bug 3597] "Delete all items" doesn't check issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3597 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #6 from Katrin Fischer --- I believe this is fixed - you have to cancel all holds now before you can delete all items. My test record had a waiting and a reserved (not yet pulled) item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 02:34:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 01:34:42 +0000 Subject: [Koha-bugs] [Bug 3637] item status display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3637 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Katrin Fischer --- Laurence, could you verify if this is still a problem in UNIMARC installations? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 03:25:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 02:25:41 +0000 Subject: [Koha-bugs] [Bug 11349] New: PROG/CCSR deprecation: Remove .tmpl -> .tt translation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Bug ID: 11349 Summary: PROG/CCSR deprecation: Remove .tmpl -> .tt translation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Blocks: 11346 bootstrap should not have any .tmpl files, so no need to keep the code that does that translation anymore. We should get rid of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 03:25:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 02:25:41 +0000 Subject: [Koha-bugs] [Bug 11346] Deprecate the PROG and CCSR themes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11346 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11349 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 04:04:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 03:04:06 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #22 from Bernardo Gonzalez Kriegel --- Created attachment 23329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23329&action=edit hidden-differences.txt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 04:05:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 03:05:07 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #23 from Bernardo Gonzalez Kriegel --- Created attachment 23330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23330&action=edit hidden-differences-no-new.txt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 04:05:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 03:05:45 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #24 from Bernardo Gonzalez Kriegel --- Created attachment 23331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23331&action=edit hidden-real.txt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 04:11:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 03:11:16 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #25 from Bernardo Gonzalez Kriegel --- Thank's Katrin, In Discussion is the rigth state! I was working on this, now I will share what I found 1) Following David on comment #14 I did this query (only default and simple fw loaded) select tagfield, tagsubfield, hidden, group_concat(frameworkcode order by frameworkcode) as fws from marc_subfield_structure group by concat(tagfield,tagsubfield,hidden) having fws <> ',AR,BKS,CF,IR,KT,SER,SR,VR'; The result show where fw differs on hidden value between them. 2) The rearranged results, can be seen on attached file hidden-differences.txt (N for NULL value) There are 635 lines on that file, most are from subfields present on default but not in simple fw 3) As we are looking for customizations, I'll discard all new subfields, they will be copied anyway. Results on attached file hidden-differences-no-new.txt Now they are "only" 296 lines. But they are still a lot of updates to do on a copied fw, not practical 4) What I saw is that many subfields on simple fw have identical value on hidden field, but not on default fw. PROPOSAL: when all simple fw agrees on a hidden value, we set default with that value That will leave us with "real" customizations 5) With that proposal, results on attached file hidden-real.txt There are only 39 lines now. And only hidden values are -6, -1 and 0 Just to remember: -6 => OPAC Intranet !Editor !Collapsed -1 => OPAC Intranet Editor Collapsed 0 => OPAC Intranet Editor !Collapsed If we change -1 for 0 (if it's on editor, why collapsed?), we can take out a few more lines, but that's enough 6) Well, if there is a clear customization plan on hidden-real.txt, it's difficult for me to see it (except a few subfields) For me is more like a pseudo-random distribution of 3 values on 39 subfields out of 3959 on 9 fw :-) If we are going to provide simple fw with a meaning. I expect directives like: On serials and ..., hide 020 and ... On books and ..., hide 022 and ... etc. In that way, if we have a default fw with some sort of visibility on all fields/subs, we can hide at field level on simple fw. Writing all update lines needed to implement hidden-real "as is" is doable, and I already did it (without my proposal, around ~300 lines), so if I have no more comments on how to do this right, I will upload it and switch to need signoff. Regards, B -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 06:34:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 05:34:56 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #15 from David Cook --- (In reply to Jared Camins-Esakov from comment #14) > (In reply to David Cook from comment #13) > > Jared, I'm not sure I understand what you mean by "an additional index has > > to be configured for each facet". > > > > Could you elaborate? > > You have to add a element:0 index for each facet you want to use. Hmm, I'm not sure I understand. I didn't do that and it seemed to work all right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 08:48:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 07:48:46 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #16 from Paul Poulain --- (In reply to David Cook from comment #15) > (In reply to Jared Camins-Esakov from comment #14) > > (In reply to David Cook from comment #13) > > > Jared, I'm not sure I understand what you mean by "an additional index has > > > to be configured for each facet". > > > > > > Could you elaborate? > > > > You have to add a element:0 index for each facet you want to use. > > Hmm, I'm not sure I understand. I didn't do that and it seemed to work all > right. Do you have tested a facet with diacritics or non latin characters. iirc, the :0 means "raw storing", and fixes diacritics/non-latin display problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 08:50:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 07:50:03 +0000 Subject: [Koha-bugs] [Bug 5002] No error message if category code already exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 --- Comment #3 from Paul Poulain --- (In reply to Katrin Fischer from comment #2) > Still valid - Paul, this bug is assigned to you? Yes, but I can't deal with it, sorry. If someone want it, feel free to take it -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 09:35:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 08:35:52 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #17 from M. de Rooy --- (In reply to Fridolin SOMERS from comment #16) > Please re-sign. Changing status to reflect that need. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 09:44:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 08:44:07 +0000 Subject: [Koha-bugs] [Bug 5002] No error message if category code already exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|paul.poulain at biblibre.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 09:50:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 08:50:44 +0000 Subject: [Koha-bugs] [Bug 10970] Update MARC21 frameworks to Update Nr. 17 - DB update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10970 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 09:50:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 08:50:48 +0000 Subject: [Koha-bugs] [Bug 10970] Update MARC21 frameworks to Update Nr. 17 - DB update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10970 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22134|0 |1 is obsolete| | --- Comment #4 from M. de Rooy --- Created attachment 23332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23332&action=edit Bug 10970 - Update MARC21 frameworks to Update Nr. 17 - DB update Database counterpart of Bug 10962. Updates existing MARC21 default frameworks to Update Nr. 17 (September 2013) To test 1) Apply patch 2) run updatedatabase.pl 3) Verify new subtags biblio 015_q 020_q 024_q 027_q 800_7 810_7 811_7 830_7 authorities 020_q 024_q Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 09:57:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 08:57:35 +0000 Subject: [Koha-bugs] [Bug 10970] Update MARC21 frameworks to Update Nr. 17 - DB update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10970 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |bgkriegel at gmail.com QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 09:58:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 08:58:00 +0000 Subject: [Koha-bugs] [Bug 10970] Update MARC21 frameworks to Update Nr. 17 - DB update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10970 --- Comment #5 from M. de Rooy --- Code looks good to me. No complaints from qa tools. Tested the dbrev. Verified the changes with LOC site. Passed QA Just wondering about two points: How should we get the changes propagated to other frameworks? (Probably most users would like to update them, but indeed some might not.) The Control subfield $7 on 8XX looks like we need a clone of the Leader plugin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:39:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 09:39:03 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #186 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #184) > 2) Replacing KohaAuthorisedValues template plugin with AuthorisedValues > plugin. But why are there two different TT plugin versions in the first > place; shouldn't AuthorisedValues be used (everywhere) instead of > KohaAuthorisedValues ? Will be fixed by bug 10626. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:57:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 09:57:45 +0000 Subject: [Koha-bugs] [Bug 11124] The staff benchmark script does not work with sql administrator account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11124 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:57:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 09:57:47 +0000 Subject: [Koha-bugs] [Bug 11124] The staff benchmark script does not work with sql administrator account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11124 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22316|0 |1 is obsolete| | --- Comment #3 from M. de Rooy --- Created attachment 23333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23333&action=edit Bug 11124: The staff benchmark script does not work with sql administrator account On step 6 (at least), the circulation and return page redirect to the select branch page and nothing is done. The script should die if the user used is the sql administrator account. Test plan: Suppose that the sql admin account is root/root and koha/koha a superlibrarian account. 1/ perl misc/load_testing/benchmark_staff.pl --steps=6 --url=http://admin.koha.local/cgi-bin/koha/ --password="koha" --user="koha" should produce: ... Step 6 ... 2/ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://admin.koha.local/cgi-bin/koha/ --password="root" --user="root" should produce: Authentication successful You cannot use the database administrator account to launch this script Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 11:15:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 10:15:47 +0000 Subject: [Koha-bugs] [Bug 10941] MARC21 documentation links while adding an authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10941 Stefano Bargioni changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bargioni at pusc.it --- Comment #1 from Stefano Bargioni --- A temporary solution through JQuery can be: var tags = $('div[id^=div_indicator_tag_]'); for (var i=0; i < tags.length; i++) { var t = $(tags[i]); var tag_name = t.attr('id').replace(/div_indicator_tag_/,'').substr(0,3); t.find('span:first').after(' ?'); } $('.marcdocs').css({'color':'blue','font-weight':'bold'}); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 11:17:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 10:17:51 +0000 Subject: [Koha-bugs] [Bug 10941] MARC21 documentation links while adding an authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10941 --- Comment #2 from Stefano Bargioni --- (In reply to Stefano Bargioni from comment #1) > A temporary solution through JQuery can be: > > var tags = $('div[id^=div_indicator_tag_]'); > for (var i=0; i < tags.length; i++) { > var t = $(tags[i]); > var tag_name = t.attr('id').replace(/div_indicator_tag_/,'').substr(0,3); > t.find('span:first').after(' ?'); > } > $('.marcdocs').css({'color':'blue','font-weight':'bold'}); function MARC21FieldAuth(tag_name) { if (tag_name == '000') { window.open("http://www.loc.gov/marc/authority/adleader.html"); } else if (tag_name.search('09') == 0) { window.open("http://www.loc.gov/marc/authority/ad09x.html"); } else { window.open("http://www.loc.gov/marc/authority/ad"+("000"+tag_name).slice(-3) + ".html"); } } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 11:17:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 10:17:55 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 11:24:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 10:24:35 +0000 Subject: [Koha-bugs] [Bug 11124] The staff benchmark script does not work with sql administrator account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11124 --- Comment #4 from M. de Rooy --- Created attachment 23334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23334&action=edit Bug 11124: QA Follow-up resolving a warning and three typos Resolves warning on uninitialized author in split on line 128. Just adds the same behavior for title on line 129 for completeness. Fixes typo on occurrences and two other minor typos. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 11:25:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 10:25:03 +0000 Subject: [Koha-bugs] [Bug 11124] The staff benchmark script does not work with sql administrator account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11124 --- Comment #5 from M. de Rooy --- Created attachment 23335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23335&action=edit Bug 11124: QA Follow-up adding optional dependency HTTPD::Bench::ApacheBench This dependency is used in load testing (misc/load_testing/*) Test plan: Check if you see the dependency listed on About/Perl modules. Verify if the version information is correct. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 13:25:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 12:25:43 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #19 from Kyle M Hall --- Created attachment 23336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23336&action=edit Bug 11096: force XML syntax for Zconn and remove MARC::File::USMARC everywhere. This patch makes Koha <-> Zebra exchange speak XML instead of the current 'USMARC'. For that, it changes some bits in - C4::Context->Zconn - C4::Context-_new_Zconn Zebra's 'element' variable is set to "marcxml" to match our zebra config files. References to MARC::File::USMARC::decode are substituted for calls to the correct one [1] (i.e. MARC::Record::new_from_xml using an explicit 'UTF-8' encoding for the task. This patch also removes calls to the unsafe ZOOM::Record->render()[2] method. Due to this last change the code for building facets was rewritten. And for performance on the facets creation I pushed higher version dependencies for MARC::File::XML and MARC::Record (we rely on MARC::Field->as_string). - The FindDuplicates function was MARCXML-ized too. - Unit tests have been moved to expect MARCXML from Zebra as well. TODO: relevance still uses USMARC. Need advise on that. References to MARC::File::USMARC where replaced for the corresponding MARC::File::XML counterpart from AuthoritiesMarc.pm. - Authorities search should work as usual. - Set dontmerge to see AuthoritiesMarc::merge still works. Regards To+ [1] As a side effect some encoding problems got fixed in facets and record details. http://search.cpan.org/~gmcharlt/MARC-XML-1.0.1/lib/MARC/File/XML.pm#decode() [2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#render() Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Katrin Fischer Testing notes on second patch. Signed-off-by: Kyle M Hall Works as advertised. Passes koha-qa.pl, t, and xt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 13:26:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 12:26:06 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23236|0 |1 is obsolete| | Attachment #23237|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 23337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23337&action=edit Bug 11096: wrap MARC::Record->new_from_xml call with eval Catch situations where MARC::Record would croak for bad-formed records. To test: - Run prove t/db_dependent/Search.t - It will fail at test 65 [1] - Apply the patch, it will warn for some failing records, but the tests will run smoothly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba [1] a record that cannot be parsed by MARC::Record is simply skipped (bug 10684) Signed-off-by: Katrin Fischer - All tests and QA script pass after applying the patch. - Verfied that sample record is not searchable before applying patch, but can be searched without problems after applying it. - Tested authority searching still workds as expected. - Tested bilbiographic searching still works as expected. - Simple search, also truncated search terms - Facetting - Advanced search, also itemtype and pubyear limits - Tested dontmerge preference, editing a linked authority and confirming the change is made to the linked records as well. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 13:26:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 12:26:03 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 13:30:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 12:30:25 +0000 Subject: [Koha-bugs] [Bug 11262] Don't require hardcoded translations for seasonal numbering pattern to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11262 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Summary|Don't require hardcoded |Don't require hardcoded |translations for saisonal |translations for seasonal |numbering pattern to work |numbering pattern to work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 13:56:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 12:56:42 +0000 Subject: [Koha-bugs] [Bug 11262] Don't require hardcoded translations for seasonal numbering pattern to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11262 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23135|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 23338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23338&action=edit Bug 11262 - Don't require hardcoded translations for seasonal numbering pattern to work This patch removes the use of POSIX::strftime which is based on the locales of the system. The DateTime module translates month and day name with success, without any locale installed. For the saesons, I use the way used in Koha: write the word in templates. On this way the translate script will match them and allow translators to translate them. This patch adds a regression: the season names are not translated following the locale selected. This could be done when bug 8044 will be pushed. Test plan: 0/ Update your po files and translate the season name. 1/ Create a numbering pattern using season. example: Name: Seasonal Numbering formula: {X} X: Season, Add=1, Every=1, Set back to 0 when more than 3, formatting "name of season" And test the prediction pattern with: frequency: 1/3 month First issue : 2013-09-21 length: 12 months X begins with 2 (21th Septembre is Fall) 2/ Click on the test pattern button, you should get: Fall 21/09/2013 Winter 21/12/2013 Spring 21/03/2014 Summer 21/06/2014 Change the locale and verify the season names are *not* translated. Change the Koha language and verify the season names are translated. 3/ Create a numbering pattern using day or month name. example: Name: day Numbering formula: {X} X: day, Add=1, Every=1, Set back to 0 when more than 6, formatting "name of day" Frequency: 1/day First issue: 2013-11-18 length: 1 month X begins with 0 You should get: Monday 18/11/2013 Tuesday 19/11/2013 Wednesday 20/11/2013 [...] Sunday 15/12/2013 Monday 16/12/2013 Tuesday 17/12/2013 change the locale and verify the day names are translated. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors Tested on top of Bug 11265 and Bug 11263, and solved merge conflict Updating PO file gives seasons to translate. Tested using seasons, day and month Only note is different behavior 1) To use seasons you need to use staff in desired language 2) To use day and month only need to select locale Signed-off-by: Kyle M Hall No regressions found. Passes koha-qa.pl, t and xt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 13:56:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 12:56:39 +0000 Subject: [Koha-bugs] [Bug 11262] Don't require hardcoded translations for seasonal numbering pattern to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11262 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 14:04:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 13:04:23 +0000 Subject: [Koha-bugs] [Bug 11225] \n in translation strings should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11225 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 14:04:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 13:04:26 +0000 Subject: [Koha-bugs] [Bug 11225] \n in translation strings should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11225 --- Comment #8 from Kyle M Hall --- Created attachment 23339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23339&action=edit Bug 11225: \n in translation strings should be removed Some strings in the serials module contain linebreaks \n that cause problems in translation. Test plan: - Update your po file - Verify that strings in serials/subscription-add.tt and serials/subscription-numberpatterns.tt are present and don't contain "\n" character. Signed-off-by: Katrin Fischer Template only change, passes all tests and QA script. Updated po files now contain only the strings and no line breaks. Signed-off-by: Kyle M Hall No regressions found. Passes koha-qa.pl and xt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 14:25:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 13:25:11 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 --- Comment #18 from Fridolin SOMERS --- (In reply to M. de Rooy from comment #17) > Changing status to reflect that need. Can you signoff 3rd patch ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 15:00:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 14:00:05 +0000 Subject: [Koha-bugs] [Bug 5597] holds to pull showing wrong item for item specific holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5597 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 15:39:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 14:39:46 +0000 Subject: [Koha-bugs] [Bug 3637] item status display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3637 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #4 from Jonathan Druart --- No, this is no valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 15:48:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 14:48:15 +0000 Subject: [Koha-bugs] [Bug 11261] Sample frequencies and numbering patterns should better be mandatory on install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 15:48:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 14:48:19 +0000 Subject: [Koha-bugs] [Bug 11261] Sample frequencies and numbering patterns should better be mandatory on install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23325|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 23340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23340&action=edit Bug 11261: Sample numbering patterns should better be mandatory on install Test plan: Verify all sample_numberpatterns.* files have been moved from optional to mandatory directories. Signed-off-by: Katrin Fischer All sample files for numbering patterns are moved from optional to mandatory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 15:48:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 14:48:29 +0000 Subject: [Koha-bugs] [Bug 11261] Sample frequencies and numbering patterns should better be mandatory on install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11261 --- Comment #5 from Jonathan Druart --- Created attachment 23341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23341&action=edit Bug 11261: Sample frequencies should better be mandatory on install Test plan: Verify all sample_frequencies.* files have been moved from optional to mandatory directories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 15:48:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 14:48:55 +0000 Subject: [Koha-bugs] [Bug 11261] Sample frequencies and numbering patterns should better be mandatory on install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11261 --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #3) > Hi Jonathan, > the first patch is ok, but you are only moving the numbering patterns - what > do you think about also moving the frequencies? (sample_frequencies.txt/.sql) Yes of course, second patch does that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 15:56:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 14:56:03 +0000 Subject: [Koha-bugs] [Bug 11350] New: Holds offered to patrons who are not allowed to put the item on hold Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11350 Bug ID: 11350 Summary: Holds offered to patrons who are not allowed to put the item on hold Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: p.thrasher at dover.nh.gov QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Occurs in 3.10 and current master If there are two items on a bib record with different item types, then a copy that cannot be put on hold by a particular patron will be offered to that patron when the copy is checked in. There are two scenarios: First, if some items can only be put on hold by the home library (set in the Holds policy by item type at the bottom of the circ rules), then if a patron from a different branch puts on a bib level hold it and the restricted copy is checked in, it is offered through the popup to the patron from the different branch. Second, if some patron types are allowed to put holds on an item type and others are not, then when the restricted copy is checked in it is offered to the patron who is not allowed to put a hold on it. It's a little clearer in the test plan... Scenario One Create branches East West Create item types Book Restricted Set Circ rules (Holds policy by item type at the bottom) Add All-All-All rule for all libraries (Set AllowOnShelfHolds in System Preferences/Circulation/Holds to Allow) For East branch for Restricted item type: From home library for West branch for Restricted item type: From home library Create patrons East Patron (branch: East, patron type: Normal) West Patron (Branch: West, patron type: Normal) AnotherEast Patron (branch: East, patron type: Normal) Add a bib record (Koha Item Type Book) with two items item1 (homebranch: East, item type: Book) item2 (homebranch: East, item type: Restricted) Verify that item2 can be put on item specific hold (but don't actually put it on hold) for East Patron Verify that item2 cannot be put on item specific hold for West Patron Log into Staff client at EastBranch Check out item1 to East Patron Check out item2 to AnotherEast Patron Put a bib level hold on the title for West Patron Check in item2 Incorrect behavior: a popup offering the hold to West patron Correct behavior: No popup, item2 can go back on the shelf Scenario Two Create one branch East Create item types Book Restricted Create patron types Normal Special Set Circ rules for East branch Add All-All-All rule for all libraries (Set AllowOnShelfHolds in System Preferences/Circulation/Holds to Allow) Book: All patron types can put 5 holds Restricted: Normal patron type can put 0 holds Special Patron Type can put 5 holds Create patrons East Patron (branch: East, patron type: Special) AnotherEast Patron (branch: East, patron type: Normal) ThirdEast Patron (branch: East, patron type: Normal) Add a bib record with two items item1 (homebranch: East, item type: Book) item2 (homebranch: East, item type: Restricted) Verify that item2 can be put on item specific hold (but don't actually put it on hold) for East Patron Verify that item2 cannot be put on item specific hold for AnotherEast Patron Log into Staff client at East branch Check out item1 to East Patron Check out item2 to AnotherEast Patron Put a bib level hold on the title for ThirdEast Patron Check in item2 Incorrect behavior: a popup offering the hold to ThirdEast patron Correct behavior: No popup, item2 can go back on the shelf Koha figures out properly if an item can be put on hold, we need to use that same logic during checkin when determining who to offer the hold to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 15:56:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 14:56:24 +0000 Subject: [Koha-bugs] [Bug 11350] Holds offered to patrons who are not allowed to put the item on hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11350 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:12:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:12:45 +0000 Subject: [Koha-bugs] [Bug 11333] use jQuery validator plugin for CSV profile forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11333 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:14:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:14:43 +0000 Subject: [Koha-bugs] [Bug 11225] \n in translation strings should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11225 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23120|0 |1 is obsolete| | CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:16:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:16:13 +0000 Subject: [Koha-bugs] [Bug 11225] \n in translation strings should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11225 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:21:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:21:49 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent records child records (aka. component parts) in the detailed views. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Hi, starting with a code review: - Small thing: Please break your commit messages into shorter lines so they are easier to read in a terminal window. - Please provide a follow-up for the Bootstrap theme. As prog and CCSR are going to be deprecated this is mandatory now. - Database update adding the new system preference is missing. - The way this is coded it's a MARC21 specific feature. The rcn index and 001 > $w linking are not MARC agnostic. Please check for the marcflavor in your code and include a note about the limitation to MARC21 in the syspref description. - Some of the comments look like TODOs - maybe something you want to take another look at? - Creating our 'own' XML in a MARCXML record doesn't look right to me. I would much prefer if that could be expressed in normal MARC21 fields and subfields. - With the heading "Child records" you assume that it will be always a component part, but that's not true. 001 > $w linkings are used to express a lot of different relationships between records. I think putting a bit more thought into the various relationships could be good here. Also the QA script points out some issues: FAIL C4/XSLT.pm FAIL pod *** ERROR: Unknown command 'head' in file C4/XSLT.pm *** ERROR: Spurious text after =cut in file C4/XSLT.pm OK forbidden patterns OK valid FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:32:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:32:15 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Katrin Fischer --- Failing QA to get Kyle's attention. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:36:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:36:53 +0000 Subject: [Koha-bugs] [Bug 10970] Update MARC21 frameworks to Update Nr. 17 - DB update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10970 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- (In reply to M. de Rooy from comment #5) > How should we get the changes propagated to other frameworks? (Probably most > users would like to update them, but indeed some might not.) The work Bernardo started in bug 10963 suggests a way that this might become easier in the future -- once a format-specific stock framework is recast as being a subset of the default framework (+ difference in subfield visibility), it would be easier to let users say, for example, please refresh my SER framework based on the current state of the default framework. > The Control subfield $7 on 8XX looks like we need a clone of the Leader > plugin? That's a good idea, though it would be a smaller version since 8XX$7 has only two positions defined. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:44:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:44:04 +0000 Subject: [Koha-bugs] [Bug 10973] Make the use of basketgroup an option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10973 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:46:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:46:21 +0000 Subject: [Koha-bugs] [Bug 10977] Connexion Gateway: biblios not importing as a batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10977 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:48:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:48:00 +0000 Subject: [Koha-bugs] [Bug 2172] Cart attaches an iso2709 file, which confuses 99% of patrons. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2172 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:48:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:48:13 +0000 Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:49:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:49:17 +0000 Subject: [Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:49:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:49:36 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:55:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:55:52 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:56:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:56:02 +0000 Subject: [Koha-bugs] [Bug 10970] Update MARC21 frameworks to Update Nr. 17 - DB update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10970 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:56:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:56:24 +0000 Subject: [Koha-bugs] [Bug 10970] Update MARC21 frameworks to Update Nr. 17 - DB update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10970 --- Comment #8 from Galen Charlton --- I also pushed to a follow-up to ensure that the update is run only for MARC21 installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:57:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 15:57:16 +0000 Subject: [Koha-bugs] [Bug 11029] Marc Language Code in a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11029 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Nicole C. Engard --- This is good for beginners, but I'd hate for it to be there all the time. I know the language codes I have to use and don't want to have to scroll through a pull down to pick it - I want to be able to type it. So this should have some way to keep it the way it is while adding a new option. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 17:02:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 16:02:07 +0000 Subject: [Koha-bugs] [Bug 11038] Enable use of IntranetUserCSS and intranetcolorstylesheet on staff client login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 17:33:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 16:33:25 +0000 Subject: [Koha-bugs] [Bug 11063] Add circulation message's patron when checkin items (returns.pl) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11063 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Nicole C. Engard --- I would say that this should be an option, the patron isn't always there at check in so showing extra pop ups with messages can be distracting. Unless we show it in the check in table summary at the bottom. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 17:39:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 16:39:57 +0000 Subject: [Koha-bugs] [Bug 11088] Patron entry page should use floating toolbar like cataloging interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11088 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 17:39:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 16:39:43 +0000 Subject: [Koha-bugs] [Bug 11087] Have the fines tab default to pay fines rather than account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11087 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 17:42:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 16:42:21 +0000 Subject: [Koha-bugs] [Bug 11092] Need a processing fee and billing fee on late notices. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11092 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 17:56:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 16:56:29 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 17:56:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 16:56:34 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 18:39:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 17:39:26 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 18:44:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 17:44:05 +0000 Subject: [Koha-bugs] [Bug 11160] Better message when placing hold at OPAC is blocked In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11160 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 18:45:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 17:45:32 +0000 Subject: [Koha-bugs] [Bug 9084] Dates in notices should be formatted according to dateformat system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 18:49:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 17:49:47 +0000 Subject: [Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised Values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 18:50:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 17:50:24 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 18:51:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 17:51:21 +0000 Subject: [Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 19:08:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 18:08:41 +0000 Subject: [Koha-bugs] [Bug 11172] Reports need a clear filter button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11172 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Nicole C. Engard --- This is in reference to the search filters on the reports page and I agree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 19:10:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 18:10:19 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 19:13:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 18:13:01 +0000 Subject: [Koha-bugs] [Bug 11176] Purchase suggestions should respect the 'active' switch on budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 19:35:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 18:35:25 +0000 Subject: [Koha-bugs] [Bug 11351] New: Add support for SIP2 media types Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351 Bug ID: 11351 Summary: Add support for SIP2 media types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Koha's SIP2 server implementation does not currently support the SIP2 protocol field "media type" ( CK ). It should. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 19:35:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 18:35:35 +0000 Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 19:38:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 18:38:36 +0000 Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351 --- Comment #1 from Kyle M Hall --- Created attachment 23342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23342&action=edit Bug 11351 - Add support for SIP2 media types Koha's SIP2 server implementation does not currently support the SIP2 protocol field "media type" ( CK ). This patch implements the SIP2 media type by allowing an arbitrary mapping of itemtypes to SIP2 media types. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Edit an itemtype, select a SIP media type, and save the changes 4) Make a SIP2 Item Information Request 5) Verify that the CK field of the Item Information Response contains the correct media type code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 19:38:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 18:38:33 +0000 Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 19:41:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 18:41:10 +0000 Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23342|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 23343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23343&action=edit Bug 11351 - Add support for SIP2 media types Koha's SIP2 server implementation does not currently support the SIP2 protocol field "media type" ( CK ). This patch implements the SIP2 media type by allowing an arbitrary mapping of itemtypes to SIP2 media types. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Edit an itemtype, select a SIP media type, and save the changes 4) Make a SIP2 Item Information Request 5) Verify that the CK field of the Item Information Response contains the correct media type code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 20:25:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 19:25:50 +0000 Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23343|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 23344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23344&action=edit Bug 11351 - Add support for SIP2 media types Koha's SIP2 server implementation does not currently support the SIP2 protocol field "media type" ( CK ). This patch implements the SIP2 media type by allowing an arbitrary mapping of itemtypes to SIP2 media types. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Edit an itemtype, select a SIP media type, and save the changes 4) Make a SIP2 Item Information Request 5) Verify that the CK field of the Item Information Response contains the correct media type code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 22:32:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 21:32:29 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 22:38:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 21:38:56 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 22:46:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 21:46:37 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 22:49:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 21:49:38 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 22:56:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 21:56:18 +0000 Subject: [Koha-bugs] [Bug 11259] Add a search for hidden records in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11259 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 23:09:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 22:09:15 +0000 Subject: [Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 23:14:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 22:14:22 +0000 Subject: [Koha-bugs] [Bug 11285] Vocabulary disambiguation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Nicole C. Engard --- * Card View could be ISBD view since that's what it is. * Course Term I can't think of another way to say that ... but if I saw some sentences I might have a way to replace Term as in terminology * Items for holdings could be changes to 'Holdings' but that might be a HUGE deal * And as for Subject I'm at a loss .. They are subject headings in cataloging and it's the email subject so I can't think of any other way to do that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 23:26:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 22:26:38 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 23:27:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 22:27:21 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 23:45:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 22:45:18 +0000 Subject: [Koha-bugs] [Bug 11228] Explanation on 'patron notification' is not quite right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11228 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 23:53:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 22:53:41 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 00:34:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 23:34:37 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #26 from Bernardo Gonzalez Kriegel --- Created attachment 23345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23345&action=edit Bug 10963 - [10] Simplified creation of MARC21 sample frameworks This patch revert original hidden values to the situation before rewriting simple and fast SQL files. Also adds missing 082 fields and subfields to fastadd fw! To test the complete package: (before applying the patch) 1) Delete biblio fw delete from marc_subfield_structure; delete from marc_tag_structure; delete from biblio_framework; 2) Load default and simple fw 3) Search for different hidden values executing this query and save the result on a file (ej. simple-old) "update marc_subfield_structure set frameworkcode = 'AAA' where frameworkcode = ''; select * from (select tagfield,tagsubfield,hidden,group_concat(frameworkcode order by frameworkcode) as fws from marc_subfield_structure group by concat(tagfield,tagsubfield,hidden) having fws <> 'AAA,AR,BKS,CF,IR,KT,SER,SR,VR') as a where fws not like 'AAA%';" 4) Delete biblio fw as in 1) 5) Load default and fastadd 6) Search for different hidden values executing this query and save the result on a file (ej. fast-old) "update marc_subfield_structure set frameworkcode = 'AAA' where frameworkcode = ''; select * from (select tagfield,tagsubfield,hidden,group_concat(frameworkcode order by frameworkcode) as fws from marc_subfield_structure group by concat(tagfield,tagsubfield,hidden) having fws <> 'AAA,FA') as a where fws not like 'AAA%';" 7) Apply the patch (it takes some time, it's large) 8) Repeat 1-2-3) but save on a new file (ej. simple-new) 9) Repeat 4-5-6) but save on a new file (ej. fast-new) 10) Check that que we get the same results diff simple-old simple-new => no lines diff fast-old fast-new => no lines That's all -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 00:54:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2013 23:54:44 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #27 from Bernardo Gonzalez Kriegel --- Ready to be signed! It makes all simple and fastadd fw as copies of default and preserves previous hidden values, so no change except new fields. But.. I think that we will have a big conflict with Bug 11330, first patch needs to be discarded except for changes on default, and Katrin's followup can stay. Or.. this can be rewritten. It's one or the other. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 01:27:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2013 00:27:58 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 02:03:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2013 01:03:58 +0000 Subject: [Koha-bugs] [Bug 11352] New: Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Bug ID: 11352 Summary: Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: major Priority: P3 Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: danielle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 23346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23346&action=edit Warning 1 Tested in versions 3.12.6, 3.14 and 3.15 (Bywater demo) When deleting by dateexpiry in batch deletion tool. The warning states a low number, and then when it comes back with a total of deletion, it deletes thousands more than it give a warning for. For instance it warned it would delete 102, the deleted 3661 in one system. We can't get the accurate count it is deleting patron's on either way. When queried with the same parameters (dateexpiry) the number is different. To recreate. Go to Batch Patron/Anonymzation Tool Select a dateexpiry date Warning should come up with count to delete Select to Permanently delete (not put in trash) Count of deleted items will show differently than warning-by thousands. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 05:35:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2013 04:35:21 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #10 from M. Tompsett --- I found another section affected by the GetNewsToDisplay change. This affects the slips, like Liz was asking about. Doing further testing first, and new patch up by next week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 14:16:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2013 13:16:15 +0000 Subject: [Koha-bugs] [Bug 11224] C4::Acquisition need more UT, and more robust ones. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11224 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23106|0 |1 is obsolete| | --- Comment #6 from mathieu saby --- Created attachment 23347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23347&action=edit Bug 11224 : Add UT to subs of C4::Acquisition returning order(s) Patch rebased after the integration of BZ 11111 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 14:19:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2013 13:19:40 +0000 Subject: [Koha-bugs] [Bug 11224] C4::Acquisition need more UT, and more robust ones. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11224 --- Comment #7 from mathieu saby --- Note that with my patch, there will be no more need to add specific tests to check if a specific key is returned by a function. What you must do if a new key is added to the hash returned by a sub is to add the new keys in the array listing all expected keys for a sub. So I suppressed the 2 new tests added by Jonathan for bz 11111 and I added the 2 new keys in the array of expected keys for SearchOrders sub. I ran prove t/db_dependant/Acquisition.t with the rebased patch. All is correct. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 14:57:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2013 13:57:50 +0000 Subject: [Koha-bugs] [Bug 11353] New: Searches with QueryParser activated are broken if an Uppercase is used in the index name Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11353 Bug ID: 11353 Summary: Searches with QueryParser activated are broken if an Uppercase is used in the index name Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org I tried to search "Title:xxxx" with Queryparser activated Result on screen of staff interface: No results match your search for 'pqf=@attr 2=102 @or @or @attr 1=1016 @attr 5=1 @attr 4=6 "Title:xxxx" @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6 "Title:xxxx" @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "Title:xxxx"' in Ma biblioth?que Catalog. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 15:00:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2013 14:00:09 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #42 from mathieu saby --- Hello Paola It's a bug of the queryparser. I've created a new bug: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11353 So, you must use only lowercases in indexes : "dissertation-information" and NOT "Dissertation-information". I update test plan. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 15:04:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2013 14:04:10 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23238|0 |1 is obsolete| | --- Comment #43 from mathieu saby --- Created attachment 23348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23348&action=edit Bug 11202 - Improve UNIMARC biblio indexing Fixing test plan Back to need sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 15:07:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2013 14:07:19 +0000 Subject: [Koha-bugs] [Bug 6172] Non-French UNIMARC frameworks need to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6172 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #4 from mathieu saby --- Non french UNIMARC frameworks should be aligned on "IFLA UNIMARC" Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 15:34:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2013 14:34:08 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #25 from mathieu saby --- Hi This enh is very very needed, especially for libraries that create items only when receiving an order. I update a bit it's importance... It is signed off, but I tried it anyway - There is a little conflict in installer/data/mysql/sysprefs.sql - in updatedatabase, the "13.00.XXX" needs to be updated to "15.00.XXX" I made these changes when I installed it. In the template, I am not sure that "Receive date" is a good column name in english. Maybe "Receipt date"? It's working well, except that the "status" column is always blank. Paola, Was it ok in your last test? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 17:18:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2013 16:18:31 +0000 Subject: [Koha-bugs] [Bug 11354] New: NewItemsDefaultLocation Override in Cataloging Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11354 Bug ID: 11354 Summary: NewItemsDefaultLocation Override in Cataloging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: library at stas.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The value of NewItemsDefaultLocation indiscriminately sets the location of a new item to this value. That is, when adding a new item, no matter what the cataloger sets for 952$c, the record defaults to the preference value, even if 952$c is not null. The matter is trivial, because one can easily just edit the item after the addition, and the edit sticks. It would be nice, however, for the NewItemsDefaultLocation value to only be applied to a new record when 952$c is null. If non-null, the default should not be applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 02:54:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2013 01:54:36 +0000 Subject: [Koha-bugs] [Bug 8258] Branch specific DUEDGST notice is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8258 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov Assignee|koha-bugs at lists.koha-commun |p.thrasher at dover.nh.gov |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 02:59:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2013 01:59:41 +0000 Subject: [Koha-bugs] [Bug 11350] Holds offered to patrons who are not allowed to put the item on hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11350 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |unspecified -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 16:06:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2013 15:06:14 +0000 Subject: [Koha-bugs] [Bug 10670] /etc/init.d/koha-common fails to start zebra due to log permission problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10670 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Dobrica! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 16:06:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2013 15:06:42 +0000 Subject: [Koha-bugs] [Bug 11163] Wrong itemtype usage count when deleting an itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11163 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 16:07:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2013 15:07:20 +0000 Subject: [Koha-bugs] [Bug 11185] check-url-quick.pl fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Fr?d?ric! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 16:08:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2013 15:08:21 +0000 Subject: [Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean search after the first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 16:09:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2013 15:09:05 +0000 Subject: [Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 16:09:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2013 15:09:31 +0000 Subject: [Koha-bugs] [Bug 11159] Small typo in catalogue/results.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11159 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 16:10:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2013 15:10:04 +0000 Subject: [Koha-bugs] [Bug 11132] The results list is reset on adding a biblio to a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 16:10:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2013 15:10:35 +0000 Subject: [Koha-bugs] [Bug 11133] Markup errors in OPAC place hold form HTML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 22:18:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2013 21:18:04 +0000 Subject: [Koha-bugs] [Bug 6148] Strange Language in opac-authorities-home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6148 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Colin Campbell --- Resolved Fixed in master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 23:32:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2013 22:32:47 +0000 Subject: [Koha-bugs] [Bug 10789] Excessive and often incorrect use of finish in C4::Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10789 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20654|0 |1 is obsolete| | --- Comment #4 from Colin Campbell --- Created attachment 23349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23349&action=edit Revised Patch Patch rebased against current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 23:33:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2013 22:33:47 +0000 Subject: [Koha-bugs] [Bug 10789] Excessive and often incorrect use of finish in C4::Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10789 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #5 from Colin Campbell --- Patch revised to accomodate changes in C4::Acquisitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 01:50:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 00:50:51 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #17 from David Cook --- (In reply to Paul Poulain from comment #16) > (In reply to David Cook from comment #15) > > (In reply to Jared Camins-Esakov from comment #14) > > > (In reply to David Cook from comment #13) > > > > Jared, I'm not sure I understand what you mean by "an additional index has > > > > to be configured for each facet". > > > > > > > > Could you elaborate? > > > > > > You have to add a element:0 index for each facet you want to use. > > > > Hmm, I'm not sure I understand. I didn't do that and it seemed to work all > > right. > > Do you have tested a facet with diacritics or non latin characters. iirc, > the :0 means "raw storing", and fixes diacritics/non-latin display problems I haven't tried with non-latin characters, but I remember at Kohacon when you used the :0 to fix the issue you were having with Arabic characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 03:43:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 02:43:56 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22920|0 |1 is obsolete| | --- Comment #11 from M. Tompsett --- Created attachment 23350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23350&action=edit Bug 7567 - News by Branch By selecting a particular branch, news specific to a branch can be showed once the user logs into the opac (or the staff) client. This includes adding a non-NULL default '' branchcode field to the opac_news table. When a user is logged in they receive both '' and their branch news. When no user is logged in, they only receive '' news. '' means all branches. TEST PLAN --------- 1) Do a fresh install, to ensure that branchcode is created as a field in the opac_news table. 2) Do an upgrade to confirm that the branchcode field is added to the opac_news table. 3) prove -v t/db_dependent/NewsChannels.t This should test all the changes in C4::NewsChannels functions. 4) Log into the staff client - Does the News display on the main page bust? 5) Go to Tools->News - Are the locations properly display? 6) Add a News item, for 'All' interfaces for 'All Branches'. 7) Add a News item, for 'Slip' interfaces at your user branch. 8) Add a News item, for 'OPAC' interface at your user branch. 9) Change the Location and Branch filters. - Do they show what you select after you click the Filter button? (Unpatched the Location does not!) - Are the items displayed matching what is selected? - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) 10) Click 'Edit' for one of the news items added. - Does what comes up match what was displayed? ( Unpatched the Location may be 'All' ) - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) - Does the submitted values match the changes made? 11) Find a patron to print a slip for. Print Slip. - Does both the 'All' and 'Slip' news show up on the print slip? 12) In a new tab, go to OPAC - Does the News display on the main page bust? - Does it display the news item for a specific branch? (It shouldn't when patched, but unpatched it would) (Only one of the new things added should be displayed) 13) Log in as a user with the branch you added the news item for. - Does that piece of News display now too? (Both things added should be displayed) 14) Check the news items added and click the delete button in the staff client. - Did it delete them appropriately? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 03:57:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 02:57:10 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23350|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 23351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23351&action=edit Bug 7567 - News by Branch By selecting a particular branch, news specific to a branch can be showed once the user logs into the opac (or the staff) client. This includes adding a non-NULL default '' branchcode field to the opac_news table. When a user is logged in they receive both '' and their branch news. When no user is logged in, they only receive '' news. '' means all branches. TEST PLAN --------- 1) Do a fresh install, to ensure that branchcode is created as a field in the opac_news table. 2) Do an upgrade to confirm that the branchcode field is added to the opac_news table. 3) prove -v t/db_dependent/NewsChannels.t This should test all the changes in C4::NewsChannels functions. 4) Log into the staff client - Does the News display on the main page bust? 5) Go to Tools->News - Are the locations properly display? 6) Add a News item, for 'All' interfaces for 'All Branches'. 7) Add a News item, for 'Slip' interfaces at your user branch. 8) Add a News item, for 'OPAC' interface at your user branch. 9) Change the Location and Branch filters. - Do they show what you select after you click the Filter button? (Unpatched the Location does not!) - Are the items displayed matching what is selected? - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) 10) Click 'Edit' for one of the news items added. - Does what comes up match what was displayed? ( Unpatched the Location may be 'All' ) - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) - Does the submitted values match the changes made? 11) Find a patron to print a slip for. Print Slip. - Does both the 'All' and 'Slip' news show up on the print slip? 12) In a new tab, go to OPAC - Does the News display on the main page bust? - Does it display the news item for a specific branch? (It shouldn't when patched, but unpatched it would) (Only one of the new things added should be displayed) 13) Log in as a user with the branch you added the news item for. - Does that piece of News display now too? (Both things added should be displayed) 14) Check the news items added and click the delete button in the staff client. - Did it delete them appropriately? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 06:53:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 05:53:23 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23351|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 23352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23352&action=edit Bug 7567 - News by Branch By selecting a particular branch, news specific to a branch can be showed once the user logs into the opac (or the staff) client. This includes adding a non-NULL default '' branchcode field to the opac_news table. When a user is logged in they receive both '' and their branch news. When no user is logged in, they only receive '' news. '' means all branches. TEST PLAN --------- 1) Do a fresh install, to ensure that branchcode is created as a field in the opac_news table. 2) Do an upgrade to confirm that the branchcode field is added to the opac_news table. 3) prove -v t/db_dependent/NewsChannels.t This should test all the changes in C4::NewsChannels functions. 4) Log into the staff client - Does the News display on the main page bust? 5) Go to Tools->News - Are the locations properly display? 6) Add a News item, for 'All' interfaces for 'All Branches'. 7) Add a News item, for 'Slip' interfaces at your user branch. 8) Add a News item, for 'OPAC' interface at your user branch. 9) Change the Location and Branch filters. - Do they show what you select after you click the Filter button? (Unpatched the Location does not!) - Are the items displayed matching what is selected? - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) 10) Click 'Edit' for one of the news items added. - Does what comes up match what was displayed? ( Unpatched the Location may be 'All' ) - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) - Does the submitted values match the changes made? 11) Find a patron to print a slip for. Print Slip. - Does both the 'All' and 'Slip' news show up on the print slip? 12) In a new tab, go to OPAC - Does the News display on the main page bust? - Does it display the news item for a specific branch? (It shouldn't when patched, but unpatched it would) (Only one of the new things added should be displayed) 13) Log in as a user with the branch you added the news item for. - Does that piece of News display now too? (Both things added should be displayed) 14) Check the news items added and click the delete button in the staff client. - Did it delete them appropriately? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 06:54:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 05:54:41 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #14 from M. Tompsett --- This is the latest, but I haven't fully tested it yet, hence the status is not changed. Feel free to test it and then anxiously await my toggling the status if there are no problems. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 08:53:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 07:53:50 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 08:53:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 07:53:55 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #118 from M. de Rooy --- Created attachment 23353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23353&action=edit Bug 7143: Adding RMaint for 3.8 to release team As a follow-up after December 4 meeting. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 11:19:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 10:19:04 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 --- Comment #26 from Jonathan Druart --- (In reply to mathieu saby from comment #25) > It's working well, except that the "status" column is always blank. It works for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 12:55:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 11:55:09 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 --- Comment #27 from mathieu saby --- OK. Maybe my VM was not clean. Anyway, it is signed off, so let's wait for QA... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 14:02:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 13:02:49 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #31 from Kyle M Hall --- That's odd. I'm not getting that fail! 08:01 ~/kohaclone (bug9288-qa $% u+4)$ koha-qa.pl -v 2 -c 1 testing 1 commit(s) (applied to 4d3558a 'Bug 9288 - Add a script to test SIP f') OK misc/sip_cli_emulator.pl OK pod OK forbidden patterns OK valid 0 OK critic (In reply to Katrin Fischer from comment #30) > Sorry Kyle, I missed this from the QA script: > > FAIL misc/sip_cli_emulator.pl > OK pod > OK forbidden patterns > OK valid > FAIL critic > Subroutine prototypes used at line 115, column 1. See page 194 of PBP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 14:23:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 13:23:46 +0000 Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23344|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 23354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23354&action=edit Bug 11351 - Add support for SIP2 media types Koha's SIP2 server implementation does not currently support the SIP2 protocol field "media type" ( CK ). This patch implements the SIP2 media type by allowing an arbitrary mapping of itemtypes to SIP2 media types. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Edit an itemtype, select a SIP media type, and save the changes 4) Make a SIP2 Item Information Request 5) Verify that the CK field of the Item Information Response contains the correct media type code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 14:42:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 13:42:00 +0000 Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351 --- Comment #5 from Kyle M Hall --- Created attachment 23355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23355&action=edit Bug 11351 - Add support for SIP2 media types [v3.12.06] Koha's SIP2 server implementation does not currently support the SIP2 protocol field "media type" ( CK ). This patch implements the SIP2 media type by allowing an arbitrary mapping of itemtypes to SIP2 media types. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Edit an itemtype, select a SIP media type, and save the changes 4) Make a SIP2 Item Information Request 5) Verify that the CK field of the Item Information Response contains the correct media type code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 14:49:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 13:49:42 +0000 Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23355|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:31:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 14:31:36 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:34:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 14:34:52 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:34:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 14:34:55 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23320|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 23356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23356&action=edit [SIGNED-OFF] Bug 6331 - Update timestamp when deleting items When item is transfered from items table to deleted items, all fields must be copies but "timestamp". This value must be updated to know when item has been deleted. Test plan: - Look a an item timestamp : mysql> select timestamp from items where itemnumber = 2690; +---------------------+ | timestamp | +---------------------+ | 2011-09-09 15:30:21 | +---------------------+ 1 row in set (0.00 sec) - Delete this item in cataloguing module - Check it is not in items table anymore : mysql> select timestamp from items where itemnumber = 2690; Empty set (0.00 sec) - Look in deleteditems table : mysql> select timestamp from deleteditems where itemnumber = 2690; +---------------------+ | timestamp | +---------------------+ | 2013-12-05 15:33:20 | +---------------------+ 1 row in set (0.00 sec) => timestamp as been set to actual date/time Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:35:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 14:35:29 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 --- Comment #18 from Martin Renvoize --- Everything now works as advertised for me.. signing off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:45:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 14:45:36 +0000 Subject: [Koha-bugs] [Bug 11355] New: PERL5OPTS="-mDevel::Cover" makes t/db_dependent/Search.t fail Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11355 Bug ID: 11355 Summary: PERL5OPTS="-mDevel::Cover" makes t/db_dependent/Search.t fail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: - Run $ prove t/db_dependent/Search.t --harness=TAP::Harness::JUnit > SUCCESS - Run $ HARNESS_PERL_SWITCHES="-MDevel::Cover" prove t/db_dependent/Search.t --harness=TAP::Harness::JUnit > FAILURE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 16:02:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 15:02:59 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent records child records (aka. component parts) in the detailed views. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #8 from Olli-Antti Kivilahti --- Thanks for the QA everyone, thanks for the uncovered bugs! I'll try to get back at this sometime next year :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 16:11:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 15:11:48 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 16:11:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 15:11:53 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23353|0 |1 is obsolete| | --- Comment #119 from Katrin Fischer --- Created attachment 23357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23357&action=edit [SIGNED OFF] Bug 7143: Adding RMaint for 3.8 to release team As a follow-up after December 4 meeting. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Correct addition, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:31:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 16:31:10 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #3 from Kyle M Hall --- As a POC, it looks pretty good to me! The only suggestion I would have would be not keep the export for read_field, and modify that sub to check for a value in the subfield value. That is, instead of having read, read_field, and read_subfield, keep all the code in read_field and just do an if/then/else. That way the exported name is still read_field, and thus doesn't change the API. It's entirely possible for SimpleMARC to be used in custom scripts, so adding to the API is fine, but removing/renaming api subs should be avoided. I know that such an occurence is unlikely at this point, but even in the future it will confuse users to have update_field, copy_field, move_field, read, and delete. It just breaks the naming convention. The other option would be to remove "_field" from all the subroutines. I have no problem with either choice. Let's just keep the convention standardized! Other than that, it looks good to me! Kyle (In reply to Jonathan Druart from comment #2) > Kyle and Galen, I really would like to have your opinion on this patch > please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:32:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 16:32:32 +0000 Subject: [Koha-bugs] [Bug 7934] Separate po file for help pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23314|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS --- Created attachment 23358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23358&action=edit Bug 7934 - Separate po file for help pages This patch modifies LangInstaller.pm to enable separation of translation for Staff UI and Staff Help files. It's a move that make sense, Help strings accounts for 44% of total word count for Staff, and as stated on Comment #1, it could enable a different workflow on translation work. It's more a hack than an elegant solution, but it works. Feel free to suggest another approach. To test: We need to test complete functionality, i.e. create and update translation files and install translation, and verify that no string is missing. 1) Before applying the patch, we need some data from staff file. Pick your language, say de_DE, and cd misc/translator/ perl translate update de-DE msginit -i po/de-DE-i-staff-t-prog-v-3006000.po -o de-old.po --no-translator --no-wrap --locale=de_DE egrep ^msgid de-old.po | sort | tee s-old | wc -l > number-old We have the file s-old with all strings, and the number of strings on number-old 2) Apply the patch 3) New help file is called de-DE-staff-help.po, so create one cp'ing old staff on new help cp po/de-DE-i-staff-t-prog-v-3006000.po po/de-DE-staff-help.po 4) Make a new update, and analize perl translate update de-DE msginit -i po/de-DE-i-staff-t-prog-v-3006000.po -o de-new.po --no-translator --no-wrap --locale=de_DE msginit -i po/de-DE-staff-help.po -o de-help.po --no-translator --no-wrap --locale=de_DE egrep ^msgid de-new.po | sort | tee s-new | wc -l > number-new egrep ^msgid de-help.po | sort | tee s-help | wc -l > number-help cat s-new s-help | sort | uniq | tee s-all | wc -l > number-all cat s-new s-help | sort | uniq -d | tee s-dup | wc -l > number-dup Ideally what we need to found is: diff s-old s-all = zero lines (old strings vs new strings) In my test I got one line, but it's a false positive (the string "? " is present on new staff) On numbers, number-old - number-new - nummber-help + number-dup = 0 or number-old - number-all = 0 (in my test again I have 1 as result, same string. Also there are 137 repeated lines between new staff and help) All this tells me that all string to translate are preserved 5) Install translation perl translate install de-DE Enable language on staff, and check that help files are translated 6) Finally, create translation files rm po/de-DE-* perl translate create de-DE verify that all files are created. Tests of 4) can be repeated. 7) Verify that no strings from help are present on staff UI file egrep help po/de-DE-i-staff-t-prog-v-3006000.po Only results came from help-top and bottom, and a few "help" on staff strings Signed-off-by: Fridolyn SOMERS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:32:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 16:32:48 +0000 Subject: [Koha-bugs] [Bug 7934] Separate po file for help pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:34:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 16:34:12 +0000 Subject: [Koha-bugs] [Bug 7934] Separate po file for help pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 --- Comment #5 from Fridolin SOMERS --- Tested with fr-FR, works fine. I had same false alert with string "? ". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:34:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 16:34:38 +0000 Subject: [Koha-bugs] [Bug 7934] Separate po file for help pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23358|Bug 7934 - Separate po file |[SIGNED-OFF]Bug 7934 - description|for help pages |Separate po file for help | |pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:34:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 16:34:51 +0000 Subject: [Koha-bugs] [Bug 7934] Separate po file for help pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 18:13:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 17:13:51 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #4 from Jonathan Druart --- (In reply to Kyle M Hall from comment #3) Kyle, Thank you for your feedback. > As a POC, it looks pretty good to me! The only suggestion I would have would > be not keep the export for read_field, and modify that sub to check for a > value in the subfield value. That is, instead of having read, read_field, > and read_subfield, keep all the code in read_field and just do an > if/then/else. That way the exported name is still read_field, and thus > doesn't change the API. This way, I am afraid that routines like copy_field and update_field will be really big. It's why I think it would be better to split them. > It's entirely possible for SimpleMARC to be used in custom scripts, so > adding to the API is fine, but removing/renaming api subs should be avoided. > I know that such an occurence is unlikely at this point, but even in the > future it will confuse users to have update_field, copy_field, move_field, > read, and delete. It just breaks the naming convention. Yes of course, but as I said, this patch only implements the read and delete routines. The goal is to do the same work for all other subroutines in the SimpleMarc module (update_field, copy_field, move_field). > The other option would be to remove "_field" from all the subroutines. I > have no problem with either choice. Let's just keep the convention > standardized! Maybe should we only keep a call to delete_field which will call either the private _delete_field or _delete_subfield routines depending on the subfield value. Like that, we would not have to change the API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 18:45:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 17:45:05 +0000 Subject: [Koha-bugs] [Bug 10907] Showing the staff members name who managed a suggestion should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 18:45:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 17:45:08 +0000 Subject: [Koha-bugs] [Bug 10907] Showing the staff members name who managed a suggestion should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 --- Comment #1 from Katrin Fischer --- Created attachment 23359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23359&action=edit Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC The name of a staff member who managed a suggestion is shown in the the OPAC if the new system preference OpacSuggestionManagedBy is set to 'Show'. This is also the default. If the preference is set to 'Don't show' the staff members name is not displayed and the column 'Managed by' in the table of suggestions in the patron account is not displayed. To test: - Create a one or more suggestions - 'Manage' them by accecpting or rejecting - Go to your patron account and check that the staff member name is shown for your suggestions - Apply patch, run database update - Check the name is still shown - Switch the preference to 'Don't show' - Check the name is no longer shown and the table still displays correctly, but without the 'Managed by' column - Repeat those tests for both bootstrap and prog theme! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 18:45:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 17:45:27 +0000 Subject: [Koha-bugs] [Bug 10907] Showing the staff members name who managed a suggestion should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:23:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:23:05 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #13 from Katrin Fischer --- I think I found the difference that is causing the problems with the URL, but I will fix those on a separate bug. I will remove both changes Jonathan thought were suspicious (and he was right of course :) from my follow-up). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:27:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:27:59 +0000 Subject: [Koha-bugs] [Bug 7115] Suggestion form has wrong label if AdvancedSearchTypes = collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7115 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9223 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:27:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:27:59 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7115 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:30:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:30:51 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22984|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 23360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23360&action=edit Bug 11248: Follow up - Fix template for translated list emails in staff - Fixes some capitalization problems - Adds an URL filter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:31:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:31:32 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5010 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:31:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:31:32 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11248 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:32:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:32:04 +0000 Subject: [Koha-bugs] [Bug 11356] New: can't order from suggestions not at my branch Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11356 Bug ID: 11356 Summary: can't order from suggestions not at my branch Change sponsored?: --- Product: Koha Version: master Hardware: All URL: cgi-bin/koha/acqui/newordersuggestion.pl?booksellerid= 6&basketno=77 OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org When ordering from a suggestion I can't order unless the suggestion is at my library. Many library systems have a central ordering library/system and need to see all the data - at the very least the super librarians should see all suggestions on this page: cgi-bin/koha/acqui/newordersuggestion.pl?booksellerid=6&basketno=77 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:35:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:35:06 +0000 Subject: [Koha-bugs] [Bug 11357] New: biblio.size value not correctly displayed in list emails sent from OPAC and intranet Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11357 Bug ID: 11357 Summary: biblio.size value not correctly displayed in list emails sent from OPAC and intranet Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The size column in biblio is a bit problematic when used in TT, because instead of the size value from the biblio column it will give you the size of the variable. It's currently used in the templates for sending shelves from OPAC and intranet and maybe also in other places: [% END %] [% IF BIBLIO_RESULT.size %] , [% BIBLIO_RESULT.size %] [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:35:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:35:16 +0000 Subject: [Koha-bugs] [Bug 11357] biblio.size value not correctly displayed in list emails sent from OPAC and intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11357 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11248 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:35:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:35:16 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11357 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:36:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:36:53 +0000 Subject: [Koha-bugs] [Bug 11358] New: Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 Bug ID: 11358 Summary: Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fcapovilla at live.ca QA Contact: testopia at bugs.koha-community.org Created attachment 23361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23361&action=edit Use HTTPS Amazon images when Koha is using HTTPS. This patch checks if the Koha instance is using HTTPS and uses Amazon's HTTPS urls when adding Amazon cover images to the pages. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:37:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:37:28 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23352|0 |1 is obsolete| | --- Comment #15 from M. Tompsett --- Created attachment 23362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23362&action=edit Bug 7567 - News by Branch By selecting a particular branch, news specific to a branch can be showed once the user logs into the opac (or the staff) client. This includes adding a non-NULL default '' branchcode field to the opac_news table. When a user is logged in they receive both '' and their branch news. When no user is logged in, they only receive '' news. '' means all branches. REVISED TEST PLAN ----------------- 1) Do a fresh install, to ensure that branchcode is created as a field in the opac_news table. 2) Do an upgrade to confirm that the branchcode field is added to the opac_news table. 3) prove -v t/db_dependent/NewsChannels.t This should test all the changes in C4::NewsChannels functions. 4) Log into the staff client - Does the News display on the main page bust? 5) Add a new dummy branch (so it has no items or borrowers) 6) Go to Tools->News - Are the locations properly display? 7) Add a News item, for 'All' interfaces for 'All Branches'. 8) Add a News item, for 'Librarian interface' interfaces for the dummy branch. 9) Add a News item, for 'Slip' interfaces at your user branch. 10) Add a News item, for 'OPAC' interface at your user branch. 11) Change the Location and Branch filters. - Do they show what you select after you click the Filter button? (Unpatched the Location does not!) - Are the items displayed matching what is selected? - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) 12) Click 'Edit' for one of the news items added. - Does what comes up match what was displayed? ( Unpatched the Location may be 'All' ) - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) - Does the submitted values match the changes made? 13) Find a patron to print a slip for. Print Slip. - Does both the 'All' and 'Slip' news show up on the print slip? 14) In a new tab, go to OPAC - Does the News display on the main page bust? - Does it display the news item for a specific branch? (It shouldn't when patched, but unpatched it would) (Only one of the new things added should be displayed) 15) Log in as yourself on OPAC. - Does that piece of News display now too? (Both things added should be displayed) 16) In the staff client, delete the dummy branch. - Does the 'Librarian interface' news item exist any more? It shouldn't. 17) Check the news items added and click the delete button in the staff client. - Did it delete them appropriately? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:37:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:37:47 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Katrin Fischer --- I messed up a bit here, hope the redone follow-up makes more sense. Could you take a look Jonathan and switch to Signed off if it's ok? If the follow-up gives problems just obsolete it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:37:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:37:53 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:38:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:38:10 +0000 Subject: [Koha-bugs] [Bug 11356] can't order from suggestions not at my branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11356 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:38:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:38:49 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:39:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:39:57 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #6 from Katrin Fischer --- I have looked into this a bit, it seems that for the OPAC cart the problem does not exist and I think I found the reason in Auth.pm: OPACBaseURL => ($in->{'query'}->https() ? "https://" : "http://") . $ENV{'SERVER_NAME'} . ($ENV{'SERVER_PORT'} eq ($in->{'query'}->https() ? "443" : "80") ? '' : ":$ENV{'SERVER_PORT'}"), I will try to provide an alternative patch trying to fix it using that logic, so we don't need to hardcode http:// or https:// into the templates. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:40:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:40:24 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|6957 |11248 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:40:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:40:24 +0000 Subject: [Koha-bugs] [Bug 6957] Authors disappearing when emailing lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|5010 | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:40:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:40:24 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5010 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:40:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:40:53 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11248 | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:40:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:40:53 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|5010 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:52:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:52:00 +0000 Subject: [Koha-bugs] [Bug 11359] New: Add cardnumber and phonenumber columns to the branch overdues circulation report. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11359 Bug ID: 11359 Summary: Add cardnumber and phonenumber columns to the branch overdues circulation report. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: fcapovilla at live.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 23363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23363&action=edit Add the borrower's cardnumber and phonenumber to the branch overdues. This patch adds two new columns to the branch overdues circulation report : * the borrower's cardnumber * the borrower's phone number Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:52:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:52:27 +0000 Subject: [Koha-bugs] [Bug 11359] Add cardnumber and phonenumber columns to the branch overdues circulation report. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11359 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:56:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 18:56:26 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Frederick, I think this might be a duplicate - bug 10944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 20:02:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 19:02:17 +0000 Subject: [Koha-bugs] [Bug 11359] Add cardnumber and phonenumber columns to the branch overdues circulation report. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11359 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 20:03:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 19:03:10 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 20:19:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 19:19:17 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 21:04:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 20:04:26 +0000 Subject: [Koha-bugs] [Bug 11360] New: Disable barcode field and submit button when a hold is found Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Bug ID: 11360 Summary: Disable barcode field and submit button when a hold is found Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com At the moment when scanning in returns, it can be easy to miss a hold trap due to the fact that the barcode and submit are still active and the barcode field is focused on. A librarian who is focused on scanning can easily scan another item and pass over the form, which is equivalent to clicking the "ignore" button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 21:04:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 20:04:40 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 21:30:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 20:30:47 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #1 from Kyle M Hall --- Created attachment 23364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23364&action=edit Bug 11360 - Disable barcode field and submit button when a hold is found At the moment when scanning in returns, it can be easy to miss a hold trap due to the fact that the barcode and submit are still active and the barcode field is focused on. A librarian who is focused on scanning can easily scan another item and pass over the form, which is equivalent to clicking the "ignore" button. Test Plan: 1) Place a hold on an item 2) Scan that item's barcode though returns.pl 3) Note the hold trap 4) Scan another barcode 5) Note you were able to bypass interacting with the trapped hold form 6) Apply this patch 7) Repeat steps 2-4 8) Note you must now click one of the buttons. Clicking ignore will allow you to continue scanning items as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 21:38:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 20:38:28 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 21:43:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 20:43:54 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 23:00:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 22:00:08 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #7 from Katrin Fischer --- Hm ok, as discussed on IRC: The solution in Auth.pm is not quite right either because it totally ignores the syspref setting. I think a combination of the http/https bit + checking the syspref could do it. For multiple OPACs you can now overwrite the OpacBaseURL in your apache configuration. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 23:43:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 22:43:03 +0000 Subject: [Koha-bugs] [Bug 11361] New: Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Bug ID: 11361 Summary: Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fcapovilla at live.ca QA Contact: testopia at bugs.koha-community.org Created attachment 23365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23365&action=edit Add a Z39.50 search page to the OPAC to let users search for records on a remote Koha instance. This patch adds the OPACZ3950 preference which activates a "Z39.50 Search" page in the OPAC. This page can be used to let members search for biblio records on remote Koha instances. If the "Show" link is clicked in the results page, the user is then redirected to the remote Koha's OPAC to see the record's details. This feature can be useful if you have multiple libraries with their own Koha instance and you want your users to be able to search for books in your other libraries. Please note that this will only work with Koha instances. The links in the results page won't work with other normal Z39.50 servers. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 23:43:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 22:43:17 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 23:55:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 22:55:22 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11361 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 23:55:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2013 22:55:22 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10486 --- Comment #1 from Katrin Fischer --- Hm not sure, but this might overlap with bug 10486. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 01:23:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 00:23:11 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #21 from Galen Charlton --- This has run into a snag. While reviewing this, I decided to write a direct regression test, which can be found here: http://git.librarypolice.com/?p=koha-galen.git;a=commit;h=cffafe30284f65ef21fc315117b5d7abb39483dc This patch applies on both the current master as well as master with the patches for bug 11096 applied. On current master, the new tests *work* for MARC21 if the indexing mode is GRS-1, but, as expected, fail if the indexing mode is DOM. On top of the patches for this bug, the new tests work if the indexing mode is DOM. Yay! Here's the catch: they fail, and fail with a crash, if the indexing mode is GRS-1. This is because Zebra itself returns a Z39.50 error 14 (failure while presenting record) in line 493 of Search.pm: $record = $results[ $i - 1 ]->record($j)->raw(); Because Zebra refuses to render an invalid ISO2709 blob MARC XML, ->record($j) returns undef, and the crash occurs when it tries to run undef->raw(). Unfortunately, it's not a matter of just wrapping an eval() around it and carrying on. Here's the situation today: Over-large record in Zebra with GRS-1: can retrieve it ... with DOM: can't retrieve it Note that it works for GRS-1 mostly because (a) Zebra doesn't try to do any conversions; it think it's storing iso2709, and if you want iso2709 back, it just sends it and (b) MARC::Record is pretty forgiving. Here's the situation with the current proposed patches: ... with GRS-1: can't retrieve, and it crashes the search ... with DOM: it works To sum up: this patch would cause a regression for GRS-1 users that happen to have over-large records in their database. I see couple ways to solve this. One would be to simply immediately desupport GRS-1 -- but I don't think our UNIAMRC users are quite there yet. The other way would be to make the code adjust how it retrieves records, and whether to use the USMARC or the XML decoder, based on the values of the zebra_bib_index_mode and zebra_auth_index_mode settings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 01:24:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 00:24:44 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #22 from Galen Charlton --- Created attachment 23366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23366&action=edit Bug 11096: (follow-up) add direct regression tests This adds direct tests of indexing and retrieving bib records that are larger than the ISO2709 limit of 99,999 octets. To test: verify that prove -v t/db_dependent/Search.t passes. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 01:25:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 00:25:33 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #23 from Galen Charlton --- (In reply to Galen Charlton from comment #21) > This has run into a snag. While reviewing this, I decided to write a direct > regression test, which can be found here: > > http://git.librarypolice.com/?p=koha-galen.git;a=commit; > h=cffafe30284f65ef21fc315117b5d7abb39483dc > > This patch applies on both the current master as well as master with the > patches for bug 11096 applied. I've also attached the regression test patch to this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 02:05:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 01:05:13 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 02:05:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 01:05:27 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23364|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 02:05:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 01:05:35 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 23367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23367&action=edit Bug 11360 - Disable barcode field and submit button when a hold is found At the moment when scanning in returns, it can be easy to miss a hold trap due to the fact that the barcode and submit are still active and the barcode field is focused on. A librarian who is focused on scanning can easily scan another item and pass over the form, which is equivalent to clicking the "ignore" button. Test Plan: 1) Place a hold on an item 2) Scan that item's barcode though returns.pl 3) Note the hold trap 4) Scan another barcode 5) Note you were able to bypass interacting with the trapped hold form 6) Apply this patch 7) Repeat steps 2-4 8) Note you must now click one of the buttons. Clicking ignore will allow you to continue scanning items as before. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 02:10:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 01:10:07 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #4 from Christopher Brannon --- Looks good. I tested in a sandbox and it did what was expected. Hold trap failed before the patch applied, and then the hold trap worked after. I like that the barcode field is completely deactivated, rather than the hold trap just taking the focus off. This forces you to push a button. Our current jquery that addresses this just takes the focus off. We tossed around the idea of deactivating the barcode field altogether, but didn't have the nerve to do that much. I think the behavior is acceptable and expected. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 02:25:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 01:25:03 +0000 Subject: [Koha-bugs] [Bug 11290] members-home.pl displays badly if using non english templates and have a utf8 char in categorycode description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11290 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- As a stop-gap, I've pushed this to master. Thanks, Chris! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 02:29:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 01:29:31 +0000 Subject: [Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Srdjan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 02:36:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 01:36:10 +0000 Subject: [Koha-bugs] [Bug 10688] QueryParser doesn't recognize QP queries when used in a fielded search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Jared! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 03:13:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 02:13:46 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 03:13:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 02:13:37 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 03:42:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 02:42:16 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea --- it's not entirely duplicate - he covers some things we didn't cover in the other patch - such as shelves and lists and such. Reconcile this one with that and we should have complete coverage of ssl for amazon on the opac. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 04:38:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 03:38:50 +0000 Subject: [Koha-bugs] [Bug 8683] Acq: Clear button doesn't clear all item fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8683 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 05:09:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 04:09:30 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #49 from Galen Charlton --- I like the general intent of this, but this patch causes an unnecessary regression of bug 10170. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 05:09:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 04:09:42 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 05:09:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 04:09:58 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 05:10:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 04:10:08 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 05:19:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 04:19:01 +0000 Subject: [Koha-bugs] [Bug 10661] Mandatory item fields should be formatted the same on all forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10661 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 05:34:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 04:34:28 +0000 Subject: [Koha-bugs] [Bug 10808] Thesaurus search form does not correspond to current search query In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10808 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 05:41:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 04:41:57 +0000 Subject: [Koha-bugs] [Bug 10605] Problems with translated cart email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #30 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 05:47:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 04:47:37 +0000 Subject: [Koha-bugs] [Bug 11362] New: increase AUTH register sizes, from 4G to 20G (like biblios has) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11362 Bug ID: 11362 Summary: increase AUTH register sizes, from 4G to 20G (like biblios has) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz increase AUTH register sizes, from 4G to 20G (like biblios has) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 05:58:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 04:58:49 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23362|0 |1 is obsolete| | --- Comment #16 from M. Tompsett --- Created attachment 23368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23368&action=edit Bug 7567 - News by Branch By selecting a particular branch, news specific to a branch can be showed once the user logs into the opac (or the staff) client. This includes adding a non-NULL default '' branchcode field to the opac_news table. When a user is logged in they receive both '' and their branch news. When no user is logged in, they only receive '' news. '' means all branches. REVISED TEST PLAN ----------------- 1) Do a fresh install, to ensure that branchcode is created as a field in the opac_news table. 2) Do an upgrade to confirm that the branchcode field is added to the opac_news table. 3) prove -v t/db_dependent/NewsChannels.t This should test all the changes in C4::NewsChannels functions. 4) Log into the staff client - Does the News display on the main page bust? 5) Add a new dummy branch (so it has no items or borrowers) 6) Go to Tools->News - Are the locations properly display? 7) Add a News item, for 'All' interfaces for 'All Branches'. 8) Add a News item, for 'Librarian interface' interfaces for the dummy branch. 9) Add a News item, for 'Slip' interfaces at your user branch. 10) Add a News item, for 'OPAC' interface at your user branch. 11) Change the Location and Branch filters. - Do they show what you select after you click the Filter button? (Unpatched the Location does not!) - Are the items displayed matching what is selected? - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) 12) Click 'Edit' for one of the news items added. - Does what comes up match what was displayed? ( Unpatched the Location may be 'All' ) - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) - Does the submitted values match the changes made? 13) Find a patron to print a slip for. Print Slip. - Does both the 'All' and 'Slip' news show up on the print slip? 14) In a new tab, go to OPAC - Does the News display on the main page bust? - Does it display the news item for a specific branch? (It shouldn't when patched, but unpatched it would) (Only one of the new things added should be displayed) 15) Log in as yourself on OPAC. - Does that piece of News display now too? (Both things added should be displayed) 16) In the staff client, delete the dummy branch. - Does the 'Librarian interface' news item exist any more? It shouldn't. 17) Check the news items added and click the delete button in the staff client. - Did it delete them appropriately? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 06:04:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 05:04:47 +0000 Subject: [Koha-bugs] [Bug 11032] Validate passed records in Biblio.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11032 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 08:16:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 07:16:30 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 --- Comment #17 from M. Tompsett --- Okay, average as compared to low. And, I just cleaned up the sample news issues for a fresh install. Now to actually test with a rolled system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 10:20:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 09:20:13 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #18 from Katrin Fischer --- Hm, from the subject of this it looks a bit like it should better be several patches ('?tell the RM a story' ;) ) than one big patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 10:46:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 09:46:14 +0000 Subject: [Koha-bugs] [Bug 11363] New: Label printer profile units are not translatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11363 Bug ID: 11363 Summary: Label printer profile units are not translatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Tools > Labels > Printer profiles > Edit printer profile has a pull-down for printing units. The pull-down has entries such as "Postscript Points", "Adobe Agates", etc. The values in the pull-down cannot be translated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:00:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 10:00:51 +0000 Subject: [Koha-bugs] [Bug 11364] New: Label layout types and text justification types are not translatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 Bug ID: 11364 Summary: Label layout types and text justification types are not translatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Tools > Labels home > Manage label layouts > Create Label layout has two untranslatable pull-downs, a layout type one, and text justification one. The texts for those pull-downs comes from C4/Creators/Lib.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:05:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 10:05:57 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:06:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 10:06:01 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23360|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 23369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23369&action=edit [SIGNED OFF] Bug 11248: Follow up - Fix template for translated list emails in staff - Fixes some capitalization problems - Adds an URL filter Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:06:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 10:06:38 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #17 from Jonathan Druart --- Katrin, Thank you the followup. It looks good now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:06:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 10:06:54 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #18 from Jonathan Druart --- for* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:08:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 10:08:57 +0000 Subject: [Koha-bugs] [Bug 11365] New: Label card element title texts cannot be translated Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11365 Bug ID: 11365 Summary: Label card element title texts cannot be translated Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Tools > Labels home > Manage label Layouts lists the currently available layouts. The word "Layouts" eg. in the "Currently Available Layouts" -text cannot be translated. This also applies to "Templates", "Profiles" and "Batches" - these texts come from patroncards/manage.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:14:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 10:14:13 +0000 Subject: [Koha-bugs] [Bug 11365] Label card element title texts cannot be translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11365 --- Comment #1 from paxed --- This also applies to the table that lists the available Layouts - the table column headers cannot be translated, and those texts come from the same place. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:27:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 10:27:37 +0000 Subject: [Koha-bugs] [Bug 11366] New: Acq basket group "No group" untranslatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11366 Bug ID: 11366 Summary: Acq basket group "No group" untranslatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr in Acq baskets, there's a pull-down for basket groups. One of the entries in that pull-down is "No group", which is untranslatable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:39:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 12:39:44 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21019|0 |1 is obsolete| | --- Comment #41 from Jared Camins-Esakov --- Created attachment 23370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23370&action=edit Bug 10402: Use an object for contacts In preparation for adding the ability to handle multiple contacts, this patch moves booksellers' contacts into their own class, C4::Bookseller::Contact. To test: 1) Apply patch. 2) Run database update. 3) Edit a bookseller, making sure to add a contact. 4) View the bookseller's information, making sure the contact information is there. 5) Run the unit test: > prove t/db_dependent/Bookseller.t Signed-off-by: Owen Leonard Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:39:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 12:39:56 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21020|0 |1 is obsolete| | --- Comment #42 from Jared Camins-Esakov --- Created attachment 23371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23371&action=edit Bug 10402: Move contacts to separate table This patch normalizes the data structures used for bookseller contacts. To test: 1) Repeat tests described on previous patch. Signed-off-by: Owen Leonard Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:40:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 12:40:10 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21021|0 |1 is obsolete| | --- Comment #43 from Jared Camins-Esakov --- Created attachment 23372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23372&action=edit Bug 10402: Add ability to enter multiple contacts Some vendors may have more than one contact. For example, a technical contact and a billing contact, or a contact for journals and a contact for monographs. Rather than require that each contact be either made into a separate vendor or recorded somewhere outside of Koha, it would be really useful of Koha had the ability to add multiple additional contacts to vendors in the Acquisitions module. To test: 1) Apply patch. 2) Edit a bookseller, making sure to add a contact. 3) View the bookseller's information, making sure the contact information is there. 4) Run the unit test: > prove t/db_dependent/Bookseller.t 5) Add multiple contacts to a vendor, see that they show up. 6) Delete one contact from a vendor with multiple contacts, see that the result is correct. 7) Sign off. Note: This test plan can supersede that on the previous two patches, as all functionality of the previous two patches is required by this one. Signed-off-by: Owen Leonard Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:40:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 12:40:21 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21022|0 |1 is obsolete| | --- Comment #44 from Jared Camins-Esakov --- Created attachment 23373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23373&action=edit Bug 10402 [Template follow-up] Add multiple contacts for vendors This template-only follow-up tweaks the button labels and restructures the vendor view layout a little bit to make it more amenable to multiple contacts: - Add spaces after button icons - Change "Add contact" to "Add another contact" in hopes of making it less ambiguous whether clicking it will submit the whole form. - Eliminate duplicate headers on the vendor view page by making the contact name the subheading for each individual contact. To test, view details for vendors with one or more contacts, and try editing to add additional contacts. Everything should look good and work correctly. Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:40:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 12:40:30 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21023|0 |1 is obsolete| | --- Comment #45 from Jared Camins-Esakov --- Created attachment 23374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23374&action=edit Bug 10402 follow-up: rebase onto latest master Because of the complexity of the rebase, I have chosen to correct a couple merge errors in a separate patch rather than squashing the corrections into the last patch in the patchset. This rebase patch does one thing that may not be completely obvious: in order to keep the existing tests matching their stated aims, it centralizes contact-related unit testing at the end of the Bookseller.t unit test, and removes contacts from earlier tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:40:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 12:40:41 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21056|0 |1 is obsolete| | --- Comment #46 from Jared Camins-Esakov --- Created attachment 23375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23375&action=edit Bug 10402 follow-up: fix perlcritic exception Perlcritic doesn't like the syntax keys $variable, and requires that you explicitly dereference a hashref to a hash before using keys. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:40:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 12:40:51 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21804|0 |1 is obsolete| | --- Comment #47 from Jared Camins-Esakov --- Created attachment 23376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23376&action=edit Bug 10402 follow-up: choose contacts for serials and acq claims This patch makes it possible to choose a particular contact for acquisitions and serials claims. To test: 1) Select a contact to use for claiming late orders and a contact to use for claiming late issues. 2) Send a claim for a late order and a claim for a late issue. 3) Note that the claims went out to the proper people. 4) Run the unit test with: > prove t/db_dependent/Letters.t 5) Sign off. Note: the claim messages are recorded in the logs in the *Acquisitions* module, not the Letters module as you might expect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:41:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 12:41:07 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:41:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 12:41:10 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 --- Comment #48 from Jared Camins-Esakov --- Created attachment 23377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23377&action=edit Bug 10402: correct number of tests When merging t/db_dependent/Bookseller.t, the number of tests listed was not changed, causing the test to fail with too many tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:39:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 14:39:49 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #19 from M. Tompsett --- I would, except everything is so interdependent, I don't see where to break it up right now. I suppose I could try to break the "change from (parameter, parameter, parameter,etc.) into hash ref" portion out, but I didn't think to do that early on. I'll see if I can generate some sensible break lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:45:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 14:45:54 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23368|0 |1 is obsolete| | --- Comment #20 from M. Tompsett --- Created attachment 23378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23378&action=edit Bug 7567 - News by Branch By selecting a particular branch, news specific to a branch can be showed once the user logs into the opac (or the staff) client. This includes adding a non-NULL default '' branchcode field to the opac_news table. When a user is logged in they receive both '' and their branch news. When no user is logged in, they only receive '' news. '' means all branches. REVISED TEST PLAN ----------------- 1) Do a fresh install, to ensure that branchcode is created as a field in the opac_news table. 2) Do an upgrade to confirm that the branchcode field is added to the opac_news table. 3) prove -v t/db_dependent/NewsChannels.t This should test all the changes in C4::NewsChannels functions. 4) Log into the staff client - Does the News display on the main page bust? 5) Add a new dummy branch (so it has no items or borrowers) 6) Go to Tools->News - Are the locations properly display? 7) Add a News item, for 'All' interfaces for 'All Branches'. 8) Add a News item, for 'Librarian interface' interfaces for the dummy branch. 9) Add a News item, for 'Slip' interfaces at your user branch. 10) Add a News item, for 'OPAC' interface at your user branch. 11) Change the Location and Branch filters. - Do they show what you select after you click the Filter button? (Unpatched the Location does not!) - Are the items displayed matching what is selected? - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) 12) Click 'Edit' for one of the news items added. - Does what comes up match what was displayed? ( Unpatched the Location may be 'All' ) - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) - Does the submitted values match the changes made? 13) Find a patron to print a slip for. Print Slip. - Does both the 'All' and 'Slip' news show up on the print slip? 14) In a new tab, go to OPAC - Does the News display on the main page bust? - Does it display the news item for a specific branch? (It shouldn't when patched, but unpatched it would) (Only one of the new things added should be displayed) 15) Log in as yourself on OPAC. - Does that piece of News display now too? (Both things added should be displayed) 16) In the staff client, delete the dummy branch. - Does the 'Librarian interface' news item exist any more? It shouldn't. 17) Check the news items added and click the delete button in the staff client. - Did it delete them appropriately? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 16:20:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 15:20:07 +0000 Subject: [Koha-bugs] [Bug 11367] New: Clicking letter links on paid support (alphabetical) returns you to the home page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11367 Bug ID: 11367 Summary: Clicking letter links on paid support (alphabetical) returns you to the home page Change sponsored?: --- Product: Koha Version: master Hardware: All URL: http://koha-community.org/support/paid-support/alpha/ OS: All Status: NEW Severity: normal Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzyrea at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org If you sort support companies alphabetically the letter links don't take you to that place on the page, they return you to the home page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 16:26:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 15:26:52 +0000 Subject: [Koha-bugs] [Bug 11368] New: Add script to import Lexile scores Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 Bug ID: 11368 Summary: Add script to import Lexile scores Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Koha needs a script to automate the importing of Lexile score data for titles that have available scores but are not currently in the title's record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 16:26:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 15:26:59 +0000 Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 16:29:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 15:29:03 +0000 Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 --- Comment #1 from Kyle M Hall --- Created attachment 23379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23379&action=edit Very small example Lexile CSV file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 16:31:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 15:31:48 +0000 Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23379|Very small example Lexile |LexileTitlesTruncated.txt description|CSV file | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 16:35:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 15:35:41 +0000 Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 16:35:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 15:35:44 +0000 Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 --- Comment #2 from Kyle M Hall --- Created attachment 23380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23380&action=edit Bug 11368 - Add script to import Lexile scores Koha needs a script to automate the importing of Lexile score data for titles that have available scores but are not currently in the title's record. This script will take a CSV file of Lexile scores, and locate any matching records in the Koha database ( by ISBN ). If the record already has a score, it will be updated. If not, the Lexile score field will be created. Test Plan: 1) Apply this patch 2) Catalog a record for each of the following ISBNs: 0789170191 9780673779410 3) Download the file LexileTitlesTruncated.txt attached to this bug report 4) Run the script from the command line: ./misc/migraction_tools/import_lexile.pl -v --file /path/to/LexileTitlesTruncated.txt 5) View those records in Koha 6) Note those records now have valid Lexile scores 7) Edit the Lexile score ( 521$a ) and change the value to something else 8) Repeat step 4 9) Note the original Lexile score has been restored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 16:36:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 15:36:06 +0000 Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10500 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 16:36:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 15:36:06 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11368 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 16:41:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 15:41:54 +0000 Subject: [Koha-bugs] [Bug 1047] Punctuation in site names breaks Edit/Delete z39.50 server administration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1047 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- --- Comment #4 from Owen Leonard --- It doesn't work if you use an & -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:03:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 16:03:26 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #5 from Owen Leonard --- Sorry to come late to this patch, but I want to jump in: Is there any reason to show the input field at all if it's disabled? We are inconsistent on the checkout page. Sometimes the input is displayed as disabled, sometimes it is hidden. I think we should stick with hiding the input (and the "options" checkboxes too in this case) if the user cannot interact with them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:00:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 17:00:24 +0000 Subject: [Koha-bugs] [Bug 11369] New: Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Bug ID: 11369 Summary: Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When making a new search or navigating the search result pages, catalogue/search.pl->browser.js generates a search cursor cookie for every page change or search. When 30+ search/page change -actions are done, browser has collected 30+ search cursor cookies. This causes the HTTP-header to bloat and get rejected by apache2. User needs to reset cookies to get rid of this issue and be able to continue using Koha. ------------ - SOLUTION - ------------ Name searchCookies (search cursor cookies) as "scs_" and remove the 3 oldest cookies if more than 15 searchCookies are present. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:01:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 17:01:20 +0000 Subject: [Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:02:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 17:02:01 +0000 Subject: [Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Olli-Antti Kivilahti --- Sponsored by the Joensuu Regional Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 19:30:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 18:30:06 +0000 Subject: [Koha-bugs] [Bug 11112] Koha::Calendar->new loads all holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11112 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Jonathan! Note that I've pushed two follow-ups. One just repairs breakage of the add_holidays() method; the other adds a FIXME. The FIXME is important: using of package-level variables for caching is not compatible with persistence engines. However, I'm allowing this regression on the basis that I'll be resurrecting the patches for bug 8089. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 19:31:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 18:31:24 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 --- Comment #45 from Galen Charlton --- The patch for bug 11112 that I pushed just now adds another instance of caching-via-package-variables that will need to be converted to using Koha::Cache as part of resurrecting the patch for this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:23:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 20:23:50 +0000 Subject: [Koha-bugs] [Bug 11009] Do not allow reading records of anonymous patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton --- This reminds me of the old joke: "Doctor, it hurts when I do this!" "Well, stop doing it then!" Anyway, pushed to master -- though I would not be entirely surprised if somebody will end up wanting to be able to display a list of anonymized loans. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:34:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 20:34:25 +0000 Subject: [Koha-bugs] [Bug 11370] New: make news branch specific Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11370 Bug ID: 11370 Summary: make news branch specific Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be great if the news could be branch specific and show on branch specific OPACs and branch specific slips. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:34:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 20:34:31 +0000 Subject: [Koha-bugs] [Bug 11371] New: Add a new report : Orders by budget Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bug ID: 11371 Summary: Add a new report : Orders by budget Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: fcapovilla at live.ca QA Contact: testopia at bugs.koha-community.org Created attachment 23381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23381&action=edit Add the "Orders by budget" report. This patch adds the "Orders by budget" report to the reports page. This report can generate the list of all orders on a specific budget. The "All budgets" and "All active budgets" options are also available to have different views of all your orders. A "[i]" is also added before the names of inactive budgets in the budget selection box. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:35:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 20:35:06 +0000 Subject: [Koha-bugs] [Bug 11370] make news branch specific In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11370 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:35:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 20:35:40 +0000 Subject: [Koha-bugs] [Bug 11370] make news branch specific In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11370 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11372 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:35:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 20:35:40 +0000 Subject: [Koha-bugs] [Bug 11372] New: show only branch specific news on slips Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11372 Bug ID: 11372 Summary: show only branch specific news on slips Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 11370 It would be nice if the news that shows on the slips was specific to the branch without having to do specific slips for each branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:36:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 20:36:04 +0000 Subject: [Koha-bugs] [Bug 11372] show only branch specific news on slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11372 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:39:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 20:39:40 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:45:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 20:45:52 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:48:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 20:48:01 +0000 Subject: [Koha-bugs] [Bug 11370] make news branch specific In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11370 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 7567 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:48:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 20:48:01 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #21 from Owen Leonard --- *** Bug 11370 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:48:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 20:48:02 +0000 Subject: [Koha-bugs] [Bug 11372] show only branch specific news on slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11372 Bug 11372 depends on bug 11370, which changed state. Bug 11370 Summary: make news branch specific http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11370 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 22:26:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 21:26:03 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 22:26:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 21:26:42 +0000 Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 22:27:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 21:27:19 +0000 Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #1 from Chris Cormack --- Ouch sounds nasty, So the deleted count is actually correct? IE if you look in the db, it did actually delete that many? And just the warning count is incorrect? Is it deleting ones it shouldn't? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 22:30:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 21:30:36 +0000 Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 22:33:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 21:33:07 +0000 Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 --- Comment #2 from Danielle Elder --- Yes, it is deleting ones it shouldn't and we couldn't get any of the numbers to show up: warning, count, or on the database. We even queried with the deletion parameters before deletion and could not get numbers to match up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 22:41:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 21:41:32 +0000 Subject: [Koha-bugs] [Bug 10904] would like to limit patron update request management by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 --- Comment #12 from Christopher Brannon --- Kyle, Did more testing. A few issues: First, this may be an issue with the sandbox. Not sure. I'll need to do a fresh install with the patch. I tested on master first, then I applied the patch, and I received this e-mail: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 10904:

Something went wrong !

Applying: Bug 10904 - would like to limit patron update request management by branch Applying: Bug 10904 [QA Followup] - would like to limit patron update request management by branch Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Failed to merge in the changes. Patch failed at 0001 Bug 10904 [QA Followup] - would like to limit patron update request management by branch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 10904 - would like to limit patron update request management by branch 22494 - Bug 10904 - would like to limit patron update request management by branch 23104 - Bug 10904 [QA Followup] - would like to limit patron update request management by branch Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-10904-QA-Followup---would-like-to-limit-patron-3o7VHx.patch . Second issue, it looks like from your input on this ticket there should be two preference settings: IndependentBranches and IndependentBranchesPatronModifications. I only see the first. Third issue, I turned on IndependentBranches, and it works in letting the staff see only their patron requests, but we've lost some of the other features you had at first. Parts 6 and 7 of your test plan fail. This modification does not exist. They should be there with or without the IndependentBranches set, and they are not there at all. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 22:45:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 21:45:51 +0000 Subject: [Koha-bugs] [Bug 10904] would like to limit patron update request management by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Christopher Brannon --- Kyle, It appears that the patch gives the same error message on the sandbox setup that I posted previously, even if I do a new database on setup. Didn't have anything to do with a previous master install and using "No change" on the database. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 22:54:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 21:54:51 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #6 from Christopher Brannon --- Owen, Can you provide any examples of when the field is hidden? I was unaware it did this. Maybe I have not been in a circumstance that it has. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:09:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 22:09:11 +0000 Subject: [Koha-bugs] [Bug 11373] New: Add a "cash register" feature to the fine payment form. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Bug ID: 11373 Summary: Add a "cash register" feature to the fine payment form. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: fcapovilla at live.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 23382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23382&action=edit Add a "cash register" feature to the fine payment form. This patch improves the fines payment form to allow automatic calculation of the amount to give back to the patron once a fine payment is received. For example, if a patron wants to pay a 3$ fine with a 5$ bill, you can set "Amount paid" to 3 and "Collect from patron" to 5. A message will then tell you to give back 2$ to the patron. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:09:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 22:09:25 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:17:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 22:17:00 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23378|0 |1 is obsolete| | --- Comment #22 from M. Tompsett --- Created attachment 23383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23383&action=edit Bug 7567 - News by Branch By selecting a particular branch, news specific to a branch can be showed once the user logs into the opac (or the staff) client. This includes adding a non-NULL default '' branchcode field to the opac_news table. When a user is logged in they receive both '' and their branch news. When no user is logged in, they only receive '' news. '' means all branches. REVISED TEST PLAN ----------------- 1) Do a fresh install, to ensure that branchcode is created as a field in the opac_news table. 2) Do an upgrade to confirm that the branchcode field is added to the opac_news table. 3) prove -v t/db_dependent/NewsChannels.t This should test all the changes in C4::NewsChannels functions. 4) Log into the staff client - Does the News display on the main page bust? 5) Add a new dummy branch (so it has no items or borrowers) 6) Go to Tools->News - Are the locations properly display? 7) Add a News item, for 'All' interfaces for 'All Branches'. 8) Add a News item, for 'Librarian interface' interfaces for the dummy branch. 9) Add a News item, for 'Slip' interfaces at your user branch. 10) Add a News item, for 'OPAC' interface at your user branch. 11) Change the Location and Branch filters. - Do they show what you select after you click the Filter button? (Unpatched the Location does not!) - Are the items displayed matching what is selected? - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) 12) Click 'Edit' for one of the news items added. - Does what comes up match what was displayed? ( Unpatched the Location may be 'All' ) - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) - Does the submitted values match the changes made? 13) Find a patron to print a slip for. Print Slip. - Does both the 'All' and 'Slip' news show up on the print slip? 14) In a new tab, go to OPAC - Does the News display on the main page bust? - Does it display the news item for a specific branch? (It shouldn't when patched, but unpatched it would) (Only one of the new things added should be displayed) 15) Log in as yourself on OPAC. - Does that piece of News display now too? (Both things added should be displayed) 16) In the staff client, delete the dummy branch. - Does the 'Librarian interface' news item exist any more? It shouldn't. 17) Check the news items added and click the delete button in the staff client. - Did it delete them appropriately? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:06:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 23:06:47 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #3 from Christopher Brannon --- Looks like it does what is expected. Thanks for addressing this issue. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:07:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 23:07:05 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #4 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:07:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 23:07:17 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23286|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:07:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 23:07:23 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #5 from sandboxes at biblibre.com --- Created attachment 23384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23384&action=edit Bug 11336: Priority is not updated on deleting holds There are a lot of places where a hold deletion is possible. But I just found 1 place where it works! To reproduce: - select or create 2 users U1 and U2 - select or create an holdable item - place on hold for both U1 and U2. U1 has priority 1 and U2 has priority 2. - delete the hold for U1 - go on circ/circulation.pl?borrowernumber=XXXX for U2 (or in the DB directly) and verify the priority has not been set to 1 The issue is repeatable (at least) on these 2 pages: * circ/circulation.pl?borrowernumber=XXXX (tab 'Holds', select "yes" in the dropdown list and submit the form) * reserve/request.pl?biblionumber=XXXX (clic on the red cross) The CancelReserve calls _FixPriority with a reserveid. _FixPriority try to retrieve the reserve with this reserveid but it does not exist anymore... Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:19:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 23:19:17 +0000 Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon --- Can you please provide a test plan? Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:38:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 23:38:03 +0000 Subject: [Koha-bugs] [Bug 11255] sort by relevance asc generates a wrong query In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #9 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:38:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 23:38:15 +0000 Subject: [Koha-bugs] [Bug 11255] sort by relevance asc generates a wrong query In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22957|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:38:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 23:38:20 +0000 Subject: [Koha-bugs] [Bug 11255] sort by relevance asc generates a wrong query In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 --- Comment #10 from sandboxes at biblibre.com --- Created attachment 23385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23385&action=edit Bug 11255: allow sorting by relevance asc The query parser config does not declare relevance asc as possible "modifier". Test plan: 0/ create some biblio with "history" in the title 1/ define prefs defaultSortField = relevance and defaultSortOrder = asc 2/ search "history" on the staff interface 3/ note that no result is returned. 4/ apply the patch 5/ verify the queryparser config file in use takes the modification into account (see the queryparser_config value in your $KOHA_CONF file). 6/ relaunch the search and verify results are returned Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:39:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2013 23:39:52 +0000 Subject: [Koha-bugs] [Bug 11255] sort by relevance asc generates a wrong query In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #11 from Christopher Brannon --- The patch works as expected, according to the test plan. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 01:05:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 00:05:45 +0000 Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #20 from Christopher Brannon --- Kyle, This patch seems to fix more than just the ability to place a hold on an On Order item. It appears that prior to the patch, one could not place a hold any any available item if at least the first item was setup as On Order and theAllowOnShelfHolds is set to Don't Allow. So, it seems you fixed more than you stated. Good work. Christopher -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 04:16:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 03:16:50 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #27 from Jared Camins-Esakov --- Unfortunately this breaks the authority results display when 5xx$w is set: http://screencast.com/t/J40kB4bJ8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 06:14:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 05:14:38 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23383|0 |1 is obsolete| | --- Comment #23 from M. Tompsett --- Created attachment 23386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23386&action=edit Bug 7567 - News by Branch By selecting a particular branch, news specific to a branch can be showed once the user logs into the opac (or the staff) client. This includes adding a non-NULL default '' branchcode field to the opac_news table. When a user is logged in they receive both '' and their branch news. When no user is logged in, they only receive '' news. '' means all branches. REVISED TEST PLAN ----------------- 1) Do a fresh install, to ensure that branchcode is created as a field in the opac_news table. 2) Do an upgrade to confirm that the branchcode field is added to the opac_news table. 3) prove -v t/db_dependent/NewsChannels.t This should test all the changes in C4::NewsChannels functions. 4) Log into the staff client - Does the News display on the main page bust? 5) Add a new dummy branch (so it has no items or borrowers) 6) Go to Tools->News - Are the locations properly display? 7) Add a News item, for 'All' interfaces for 'All Branches'. 8) Add a News item, for 'Librarian interface' interfaces for the dummy branch. 9) Add a News item, for 'Slip' interfaces at your user branch. 10) Add a News item, for 'OPAC' interface at your user branch. 11) Change the Location and Branch filters. - Do they show what you select after you click the Filter button? (Unpatched the Location does not!) - Are the items displayed matching what is selected? - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) 12) Click 'Edit' for one of the news items added. - Does what comes up match what was displayed? ( Unpatched the Location may be 'All' ) - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) - Does the submitted values match the changes made? 13) Find a patron to print a slip for. Print Slip. - Does both the 'All' and 'Slip' news show up on the print slip? 14) In a new tab, go to OPAC - Does the News display on the main page bust? - Does it display the news item for a specific branch? (It shouldn't when patched, but unpatched it would) (Only one of the new things added should be displayed) 15) Log in as yourself on OPAC. - Does that piece of News display now too? (Both things added should be displayed) 16) In the staff client, delete the dummy branch. - Does the 'Librarian interface' news item exist any more? It shouldn't. 17) Check the news items added and click the delete button in the staff client. - Did it delete them appropriately? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 06:43:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 05:43:38 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch --- Comment #24 from M. Tompsett --- I know it's big, and I didn't split it up, but I finally got through my test plan and it all works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 11:40:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 10:40:42 +0000 Subject: [Koha-bugs] [Bug 11374] New: Need provision to give batch name in Tools > Label creator > Manage batches Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11374 Bug ID: 11374 Summary: Need provision to give batch name in Tools > Label creator > Manage batches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label printing Assignee: cnighswonger at foundations.edu Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org In present situation users can't assign a name for a newly created lable batch. Users need to identify batch by Batch ID. It's nice users can assign a meaningful name (e.g. Label-11/12/2013) for each batch. This is very helpful to identify each batch while reprinting labels. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:33:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 12:33:39 +0000 Subject: [Koha-bugs] [Bug 11375] New: Patron permission names are untranslatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Bug ID: 11375 Summary: Patron permission names are untranslatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Patron permimssions (eg. "superlibrarian", "reserveforothers", etc) and their explanations are not translatable. These strings come from installer/data/mysql/en/mandatory/subtag_registry.sql and installer/data/mysql/en/mandatory/userpermissions.sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:36:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 12:36:15 +0000 Subject: [Koha-bugs] [Bug 11375] Patron permission names are untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- The way to translate those is creating a Finnish installer currently. I have translated those and other files into German as have others (French, Spanish, etc.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:47:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 12:47:57 +0000 Subject: [Koha-bugs] [Bug 11375] Patron permission names are untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #2 from paxed --- (In reply to Katrin Fischer from comment #1) > The way to translate those is creating a Finnish installer currently. I have > translated those and other files into German as have others (French, > Spanish, etc.) Ah, OK. I don't think it's possible to translate the permission names themselves though? (That is, "superlibrarian") -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:48:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 12:48:02 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21586|0 |1 is obsolete| | --- Comment #7 from M. de Rooy --- Created attachment 23387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23387&action=edit Bug 10861: Add a check on cardnumber length Some libraries would like to add a check on the cardnumber length. This patch adds the ability to restrict the cardnumber to a specific length (strictly equal to XX, or length > XX or min < length < max). This restriction is checked on inserting/updating a patron or on importing patrons. This patch adds: - 1 new syspref CardnumberLength. 2 formats: a number or a range (xx,yy). - 1 new unit test file t/Members/checkcardnumber.t for the C4::Members::checkcardnumber routine. Test plan: 1/ Fill the pref CardnumberLength with '5,8' 2/ Create a new patron with an invalid cardnumber (123456789) 3/ Check that you cannot save 4/ With Firebug, replace the pattern attribute value (for the cardnumber input) with ".{5,10}" 5/ You are allowed to save but an error occurred. 6/ Try the same steps for update. 7/ Go to the import borrowers tool. 8/ Play with the import borrowers tool. We must test add/update patrons and the "record matching" field (cardnumber or a uniq patron attribute) Signed-off-by: Marcel de Rooy Tested adding, updating; importing and ran unit test. Preliminary QA comments on Bugzilla -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:48:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 12:48:58 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:49:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 12:49:06 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 --- Comment #8 from M. de Rooy --- Created attachment 23388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23388&action=edit Bug 10861: Follow-up for typo in patrons.pref I'd rather have a comma than a coma :) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:53:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 12:53:47 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #9 from M. de Rooy --- Just some preliminary QA comments while signing off (for the QAer on duty): Cardnumber already in use or not in a good format: I would personally like to differentiate between the two messages. Is it in use? Or is just the length incorrect? The min and maxlength logic in memberentry.pl should be in a module? Isn't there a way to check field length earlier with javascript than waiting for Save? I am not a fan of my $qr = qr|^\d{$length}$|; and just pasting the pref inside the regex. You just assume that it is of the form m,n but you do not really know. Why not just pull them out of the pref with a regex like (\d+),(\d+) or similar? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:18:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 13:18:19 +0000 Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- (In reply to Katrin Fischer from comment #5) > Something to look out for when testing the accounts rewrite :) I can tell you that the new accounting system tracks and stores every fee paid for by every payment. If a payment is made that paid 3 fines, it creates three account_offset rows that link the payment to each of those fines, along with the amount paid on each! When you look at patrons fines, you can even "drill down" to see the entire history for each fee, and for each payment. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:21:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 13:21:59 +0000 Subject: [Koha-bugs] [Bug 8018] New subfields have a default max length of zero In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8018 Pablo AB changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi at gmail.com Depends on| |7855 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:21:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 13:21:59 +0000 Subject: [Koha-bugs] [Bug 7855] Bug 7263 does not include maxlength field sets into a fresh install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7855 Pablo AB changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8018 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:22:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 13:22:07 +0000 Subject: [Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 23389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23389&action=edit Bug 11369 - Updating the jquery.cookie.js-plugin The current jquery.cookie-plugin crashes when trying to fetch all cookies using $.cookie(); Downloaded the newest plugin version and minified it. Now works as intended. Encountered an issue with the plugin now returning null when no cookies are found, and applied a fix in browser.js. ------------- - Test plan - ------------- Plugin is used in browser.js and batchMod.js so testing both --- browser.js --- In catalogue/search.pl look for any record. You should get a search cookie stored in your browsers cache with the following format: 4Xea40qp : {"offset":1,"query":"idx=kw&q=read","limit":"","sort":"","pagelen":20,"results":[1430,2253,2255,2256,2257,2258,2307,2326,2344,2595,2961,3588,3974,3995,4026,4405,4410,4412,4414,4435]} Select any record for detailed view. You should get a navigation panel on your left part of screen. You should be able to move to the previous and next record and return to results. --- batchMod.js --- Select a handful of barcodes to batch modify, then continue. The cookie affected stores the columns you want displayed. Try showing/hiding columns. When you make another batch modification attempt, your column selection persists via the showColumns-cookie. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:22:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 13:22:38 +0000 Subject: [Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 23390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23390&action=edit Bug 11369 - Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. To replicate this issue, make multiple searches in catalogue/search.pl. 50+ Should be enough to cause the HTTP-request header to overgrow. One can verify this issue by observing the searchCookie growth in browser's stored cookies. ------------- - TEST PLAN - ------------- Keep making searches. One should never have more than 10 searchCookies. Browser might display only 9, because for some reason the newest js-generated cookie is not included in Firefox's cookies listing. ------------ - DRAWBACK - ------------ Removing these cookies disables the search cursor for traversing search results (next/previous) for the removed cookie. This maybe be problematic in some cases, (for ex when multiple search tabs need to be open and they need to be traversed) One easy solution is to grow the amount of stored searchCookies from 10 to 20, but 10 is chosen so there will be plenty of room for other cookies as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:25:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 13:25:51 +0000 Subject: [Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Olli-Antti Kivilahti --- Sponsored by Joensuu Regional Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:45:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 13:45:29 +0000 Subject: [Koha-bugs] [Bug 11375] Patron permission names are untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #3 from Katrin Fischer --- Those are codes and it's not possible to translate them as they are used in the code. But you can have translated descriptions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:05:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 14:05:34 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23276|0 |1 is obsolete| | --- Comment #38 from Kyle M Hall --- Created attachment 23391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23391&action=edit Bug 6427 - Rewrite of the accounts system This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:15:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 14:15:57 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23391|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall --- Created attachment 23392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23392&action=edit Bug 6427 - Rewrite of the accounts system This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:22:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 14:22:50 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:23:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 14:23:00 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 --- Comment #28 from Tom?s Cohen Arazi --- Created attachment 23393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23393&action=edit Bug 10691: (follow-up) restore behaviour for control field ($w) As noted by Jared, on hte presence of 4XX$w or 5XX$w the display got broken by this refactoring. This patch restores de previous behaviour in that front. Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:33:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 14:33:06 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:35:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 14:35:37 +0000 Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:36:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 14:36:42 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:41:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 14:41:58 +0000 Subject: [Koha-bugs] [Bug 11376] New: Add a framework for maps in NORMARC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11376 Bug ID: 11376 Summary: Add a framework for maps in NORMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:41:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 14:41:59 +0000 Subject: [Koha-bugs] [Bug 11377] New: Add a framework for files in NORMARC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11377 Bug ID: 11377 Summary: Add a framework for files in NORMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: krisbyatt at gmail.com Reporter: krisbyatt at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:42:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 14:42:06 +0000 Subject: [Koha-bugs] [Bug 11378] New: Add framework for movies in NORMARC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11378 Bug ID: 11378 Summary: Add framework for movies in NORMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: boutrosboutrosboutros at gmail.com Reporter: boutrosboutrosboutros at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:42:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 14:42:10 +0000 Subject: [Koha-bugs] [Bug 11379] New: Add framework for music recordings and printed music in NORMARC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11379 Bug ID: 11379 Summary: Add framework for music recordings and printed music in NORMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: arekkavik at gmail.com Reporter: arekkavik at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:43:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 14:43:02 +0000 Subject: [Koha-bugs] [Bug 11380] New: Add a framework for Periodics in the NORMARC framework Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11380 Bug ID: 11380 Summary: Add a framework for Periodics in the NORMARC framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: benjamin.rokseth at kul.oslo.kommune.no Reporter: benjamin.rokseth at kul.oslo.kommune.no QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:50:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 14:50:14 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23393|0 |1 is obsolete| | --- Comment #29 from Tom?s Cohen Arazi --- Created attachment 23394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23394&action=edit Bug 10691: (follow-up) restore behaviour for control field ($w) As noted by Jared, on the presence of 4XX$w or 5XX$w the display got broken by this refactoring. This patch restores de previous behaviour in that front. The OPAC themes get fixed too, and the Bootstrap one gets this enhancement too. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 16:00:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 15:00:27 +0000 Subject: [Koha-bugs] [Bug 11378] Add framework for movies in NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11378 --- Comment #1 from Petter Goks?yr ?sen --- Created attachment 23395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23395&action=edit Bug 11378 - Add a framework for movies in NORMARC This patch only adds description! More to come:) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 16:05:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 15:05:27 +0000 Subject: [Koha-bugs] [Bug 11381] New: IDreamBooks too close to title on bootstrap Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11381 Bug ID: 11381 Summary: IDreamBooks too close to title on bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 23396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23396&action=edit readometer on the title On the Bootstrap theme the IDreamBooks readometer is smack up against the title. In other themes it was aligned to the right so that the title was readable. We don't need it aligned right, if that won't work, but I don't think it should be smack up against the title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 16:22:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 15:22:17 +0000 Subject: [Koha-bugs] [Bug 11382] New: patron left menu on purchase suggestions tab not showing all info Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11382 Bug ID: 11382 Summary: patron left menu on purchase suggestions tab not showing all info Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 23397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23397&action=edit normal view on a patron tab If you see in the attached image on cgi-bin/koha/members/purchase-suggestions.pl?borrowernumber=51 the patron image and attributes don't show on the menu on the left like they do on other pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 16:22:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 15:22:42 +0000 Subject: [Koha-bugs] [Bug 11382] patron left menu on purchase suggestions tab not showing all info In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11382 --- Comment #1 from Nicole C. Engard --- Created attachment 23398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23398&action=edit wrong purchase suggestion tab view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 16:48:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 15:48:06 +0000 Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 16:48:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 15:48:19 +0000 Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22788|0 |1 is obsolete| | --- Comment #8 from Tom?s Cohen Arazi --- Created attachment 23399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23399&action=edit Bug 10987: Too many 'see also' and 'see from' labels occurences (rebased+bootstrap) If an authority record has more than one 4xx$a (or 5xx$a) entries the corresponding labels 'see also' and 'used for/see from' are repeated. To test: - Have authority records with more than one entry on the 4xx (or 5xx) fields. - Do a search, check "see also:" (or 'used for/see from') appear more than once. - Apply the patch - Reload and check it looks nicer :-D - Repeat for: staff auth search, opac using ccsr, opac using prog - Signoff Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Work as decribed. No koha-qa errors Nice view on staff and both opac Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:09:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:09:23 +0000 Subject: [Koha-bugs] [Bug 11383] New: There is no help page for the marc modification templates tool Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11383 Bug ID: 11383 Summary: There is no help page for the marc modification templates tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org An help page should be exist for this page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:10:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:10:08 +0000 Subject: [Koha-bugs] [Bug 11383] There is no help page for the marc modification templates tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11383 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8015 Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:10:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:10:08 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11383 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:17:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:17:41 +0000 Subject: [Koha-bugs] [Bug 7365] Koha should support PostgreSQL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha uses MySQL |Koha should support | |PostgreSQL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:18:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:18:10 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23392|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall --- Created attachment 23400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23400&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:18:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:18:22 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #41 from Kyle M Hall --- Created attachment 23401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23401&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:18:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:18:32 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #42 from Kyle M Hall --- Created attachment 23402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23402&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:18:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:18:41 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #43 from Kyle M Hall --- Created attachment 23403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23403&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:18:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:18:51 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #44 from Kyle M Hall --- Created attachment 23404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23404&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:19:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:19:01 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #45 from Kyle M Hall --- Created attachment 23405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23405&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:19:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:19:12 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #46 from Kyle M Hall --- Created attachment 23406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23406&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:19:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:19:13 +0000 Subject: [Koha-bugs] [Bug 7365] Koha should support PostgreSQL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #22 from Galen Charlton --- Given the new use of DBIx::Class in Koha, I'm taking this opportunity to change the title of the bug to a positive sentence: Koha should support PostgreSQL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:19:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:19:22 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #47 from Kyle M Hall --- Created attachment 23407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23407&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:19:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:19:26 +0000 Subject: [Koha-bugs] [Bug 7365] Koha should support PostgreSQL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|marc at msys.ch |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:20:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:20:19 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #48 from Kyle M Hall --- Created attachment 23408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23408&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:20:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:20:30 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #49 from Kyle M Hall --- Created attachment 23409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23409&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:20:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:20:40 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #50 from Kyle M Hall --- Created attachment 23410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23410&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:20:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:20:59 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #51 from Kyle M Hall --- Created attachment 23411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23411&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:21:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:21:10 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #52 from Kyle M Hall --- Created attachment 23412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23412&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:22:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:22:12 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #53 from Kyle M Hall --- Created attachment 23413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23413&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:28:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:28:23 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #54 from Kyle M Hall --- Good calls. I had expected koha-qa.pl to pick those warns up ( it usually does ). Spot on! Thanks for catching those! Kyle (In reply to Chris Cormack from comment #36) > Comment on attachment 23276 [details] [review] > Bug 6427 - Rewrite of the accounts system > > Review of attachment 23276 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Koha.pm > @@ +1029,4 @@ > > > > sub GetAuthorisedValues { > > my ( $category, $selected, $opac ) = @_; > > + warn "GetAuthorisedValues( $category, $selected, $opac )"; > > This needs a debug switch, or to be removed > > @@ +1076,4 @@ > > push @results, $data; > > } > > $sth->finish; > > + warn "RET: " . Data::Dumper::Dumper( \@results ); > > And this too, or the logs get loud very very fast > > ::: misc/release_notes/release_notes_3_10_0.txt > @@ +1762,4 @@ > > 8996 normal In result page items with negative notforloan are available > > 9017 normal Quote of the day: Table footer not translated > > 5312 minor XHTML correction in authority summary > > + 8009 minor Item descriptive data not populated on account_payment.pl > > Shouldnt be in the patch, this looks like a search and replace gone wrong > > ::: misc/release_notes/release_notes_3_12_0.txt > @@ +579,4 @@ > > 8429 minor Unnecessary use of Exporter in SIP/ILS objects > > 9292 minor Remove dead code related to 'publictype' > > 9401 minor Javascript used for tags handling wants access to CGISESSID cookie > > + 9582 minor Unused code in members/account_payment.pl > > Hmm not sure why this is in the patch? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:29:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:29:54 +0000 Subject: [Koha-bugs] [Bug 11384] New: Koha should not use "ctid" as a column name Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11384 Bug ID: 11384 Summary: Koha should not use "ctid" as a column name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 7365 PostgreSQL defines several system columns for each table. These include oid, tableoid, xmin, cmin, xmax, cmax, and ctid. These column names cannot be used in a create table statement. There happens to be one table, collection_tracker, that uses 'ctId' as a column name; this should be renamed, as otherwise DBIC won't be able to add that table to a Pg database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:29:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:29:54 +0000 Subject: [Koha-bugs] [Bug 7365] Koha should support PostgreSQL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11384 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:39:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:39:12 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #55 from Kyle M Hall --- (In reply to Galen Charlton from comment #37) > In addition to the specific points that Chris has made -- which, to be > frank, do not inspire confidence that the rewrite patch has been > sufficiently tested by the patch submitter -- this patch is simply too large > to evaluate as is. I assure you that I have tested it quite a bit, but I also agree with you. I plan to continue testing to with as many add edge cases as I can imagine. So far everything has been quite solid. My largest and foremost concern at that point is to ensure that updatedatabase.pl ports all existing accounting data to the new accounting system properly. > > I *strongly* encourage you to break it up into a series of patches that, in > effect, tell a story that can be evaluated, or at least read, a patch at a > time. A possible sequence might look like this: > > Other ways of organizing it are of course possible, but the main point is to > break it up into smaller units that can be read one at a time, even if the > entire series has to be applied for it to work at all. > Done! I hope I haven't swung too far the other way with this patch series. I've tried to break it up into functional components as you can see ( schema, modules, intranet, opac, etc... ). > It would be even better, although not necessarily possible, to structure the > patch series in such a way that parts of it can be independently applied. Each of these patches should be independently apply-able. However, I'm afraid some parts will not function without the patches after it ( I'm looking at you part 11 ). Splitting this patch was quite a task, and I'm afraid I did not keep it fully chronological such that each patch only requires the preceding patches to to be functional. If you have any suggestions on re-ordering the patches I will be happy to do so! > Also, to reiterate the point in my first paragraph: the more that you take > care to eliminate debug code and trivial violations of the QA guidelines, > the easier it will be for patch reviewers to focus on the substance. I agree. This patch series currently passes koha-qa.pl, so I have a fair confidence that I have taken care of all violations at this point! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:41:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:41:39 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:41:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:41:48 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23206|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 23414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23414&action=edit Bug 11319: Template modifications This patch add template modifications for the restrictions: - the source field is always mandatory - on move and copy, the source and destination subfield should be both filled or blank. - on move and copy, the destination subfield should be filled. - on update, the subfield value should be filled. Test plan: Verify you are not able to create/modify template actions according to these restrictions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:42:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:42:45 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23414|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 23415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23415&action=edit Bug 11319: Koha::SimpleMARC should take a hashref for parameters In order to avoid a long list of parameters, it should be better to pass all of them into a hashref. This patch does not add or modify a behavior. Test plan: Verify the unit tests still pass - prove t/SimpleMARC.t - prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:42:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:42:57 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #7 from Jonathan Druart --- Created attachment 23416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23416&action=edit Bug 11319: Add UT for the fields management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:43:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:43:11 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #8 from Jonathan Druart --- Created attachment 23417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23417&action=edit Bug 11319: Add the field management for Koha::SimpleMARC Currently the Koha::SimpleMARC module call a "field" a "subfield". And the way to manage field is not implemented for all routines. This patch does not modify the API. The routine's names are kept. It just creates 2 privates routines for each action (e.g. delete_field will call _delete_field if the action affects field and _delete_subfield if the action affects subfields). Before this patch the move action was authorised by the interface but caused an error if executed. Note: I don't see the meaning for the add/update action if no subfield is given. So the call without subfield raises an error. Test plan: - apply all patches - create or modify an existent template - try at least the correct behavior for the following actions: * delete subfield and field * add new subfield to an existing field * add new subfield to an nonexisting field * move a subfield * move an entire field * copy a subfield * copy an entire field - import a biblio and use this template - verify the imported biblio matches actions defined. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:43:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:43:23 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #9 from Jonathan Druart --- Created attachment 23418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23418&action=edit Bug 11319: Add specific UT for nonexistent field/subfield This patch only adds unit tests for the copy and move actions. They test if the action does not create a field/subfield if the source did not exist. Also it adds a unit tests for the existing behavior (in order not to lost it): we can use the '^' and the '$' character in regex for substituing. For example: Copy 245$a to 245$a with the regex s/^/BEGIN / This will add the string "BEGIN " at the beginning of the 245$a fields. To test: prove t/SimpleMARC.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:43:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:43:39 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #10 from Jonathan Druart --- Created attachment 23419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23419&action=edit Bug 11319: Template modifications This patch add template modifications for the restrictions: - the source field is always mandatory - on move and copy, the source and destination subfield should be both filled or blank. - on move and copy, the destination subfield should be filled. - on update, the subfield value should be filled. Test plan: Verify you are not able to create/modify template actions according to these restrictions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:54:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:54:53 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23400|0 |1 is obsolete| | Attachment #23401|0 |1 is obsolete| | Attachment #23402|0 |1 is obsolete| | Attachment #23403|0 |1 is obsolete| | Attachment #23404|0 |1 is obsolete| | Attachment #23405|0 |1 is obsolete| | Attachment #23406|0 |1 is obsolete| | Attachment #23407|0 |1 is obsolete| | Attachment #23408|0 |1 is obsolete| | Attachment #23409|0 |1 is obsolete| | Attachment #23410|0 |1 is obsolete| | Attachment #23411|0 |1 is obsolete| | Attachment #23412|0 |1 is obsolete| | Attachment #23413|0 |1 is obsolete| | --- Comment #56 from Kyle M Hall --- Created attachment 23420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23420&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:55:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:55:29 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #57 from Kyle M Hall --- Created attachment 23421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23421&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:55:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:55:42 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #58 from Kyle M Hall --- Created attachment 23422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23422&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:55:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:55:58 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #59 from Kyle M Hall --- Created attachment 23423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23423&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:56:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:56:15 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #60 from Kyle M Hall --- Created attachment 23424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23424&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:56:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:56:32 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #61 from Kyle M Hall --- Created attachment 23425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23425&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:56:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:56:47 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #62 from Kyle M Hall --- Created attachment 23426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23426&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:57:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:57:00 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #63 from Kyle M Hall --- Created attachment 23427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23427&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:57:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:57:20 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #64 from Kyle M Hall --- Created attachment 23428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23428&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:57:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:57:32 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #65 from Kyle M Hall --- Created attachment 23429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23429&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:57:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:57:44 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #66 from Kyle M Hall --- Created attachment 23430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23430&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:57:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:57:55 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #67 from Kyle M Hall --- Created attachment 23431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23431&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:58:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:58:08 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #68 from Kyle M Hall --- Created attachment 23432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23432&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:58:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 16:58:17 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #69 from Kyle M Hall --- Created attachment 23433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23433&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 18:03:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 17:03:53 +0000 Subject: [Koha-bugs] [Bug 11384] Koha should not use "ctid" as a column name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11384 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 18:04:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 17:04:04 +0000 Subject: [Koha-bugs] [Bug 11384] Koha should not use "ctid" as a column name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11384 --- Comment #1 from Galen Charlton --- Created attachment 23434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23434&action=edit Bug 11384: rename the collections_tracking.ctId column 'ctId' as a column name conflicts with one of the system columns that PostgreSQL uses for each table, and consequently needs to be renamed to enable deploying the schema to a Pg database. This patch makes this change. To test: [1] Apply the patch and run the SQL specified in the database updated. [2] Verify that the collections_tracking table no longer has a ctId column, but now has collections_tracking_id. [3] Verify that prove -v t/db_dependent/RotatingCollections.t passes. [4] Verify that installer/data/mysql/kohastructure.sql runs cleanly in an empty database. This patch does not affect user-visible behavior given the fact that the rotating collections feature is currently disabled. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 18:04:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 17:04:15 +0000 Subject: [Koha-bugs] [Bug 11384] Koha should not use "ctid" as a column name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11384 --- Comment #2 from Galen Charlton --- Created attachment 23435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23435&action=edit Bug 11384: (follow-up) update DBIC schema classes This patch updates the DBIC schema class for CollectionTracking to reflect the new name of its primary key column. To test: The CollectionTracking class is not currently used, but if you *really* want to test this, take a look at the following branch: http://git.librarypolice.com/?p=koha-galen.git;a=shortlog;h=refs/heads/pg Then, set up a PostgreSQL database, update koha-conf.xml to point to it, then run pg/deploy and verify that the collections_tracking table is created in the Pg database. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 18:04:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 17:04:39 +0000 Subject: [Koha-bugs] [Bug 11384] Koha should not use "ctid" as a column name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11384 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 18:22:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 17:22:45 +0000 Subject: [Koha-bugs] [Bug 11385] New: C4::SQLHelper should be removed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Bug ID: 11385 Summary: C4::SQLHelper should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org Now that DBIx::Class is integrated into Koha, C4::SQLHelper should be removed and replaced with use of DBIC. Why? Now that we have a real ORM, there is no need for a bespoke, imperfect DBMS abstraction module. The following files reference C4::SQLHelper: C4/Acquisition.pm C4/Budgets.pm C4/Contract.pm C4/Members.pm C4/SQLHelper.pm C4/Suggestions.pm Koha/Borrower/Modifications.pm admin/aqbudgetperiods.pl t/db_dependent/SQLHelper.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 18:44:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 17:44:50 +0000 Subject: [Koha-bugs] [Bug 8018] New subfields have a default max length of zero In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8018 --- Comment #1 from Pablo AB --- I think I solved this problem, just adding something like $row_data{maxlength} = "4"; near line 365 on marc_subfields_structure.pl: @ -360,6 +360,9 @@ -multiple => 0, ); + # This (I think) fix Bug #8018 + $row_data{maxlength} = "4"; + $row_data{link} = CGI::escapeHTML( $data->{'link'} ); $row_data{row} = $i; push( @loop_data, \%row_data ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 18:52:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 17:52:37 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 18:52:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 17:52:46 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #8 from Katrin Fischer --- Created attachment 23436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23436&action=edit Bug 5010: Send list emails with complete links back into the catalog This patch adapts the way the links in the cart email in OPAC are generated for the list emails. The OpacBaseURL variable is generated from code in Auth.pm. To test: - Create a list - Email yourself the list Note: Email is sent directly and not via messagequeue table - Verify the links back into the catalog are missing http(s):// - Apply the patch - Email yourself the list again - Verify the links are now ok and working Note: The way Auth.pm generates the OpacBaseURL is not correct, as it does not take into account the OpacBaseURL system preference. This patch makes both emails sent from OPAC rely on the same code and is an improvement over the current behaviour. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 18:57:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 17:57:59 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #9 from Katrin Fischer --- The first patch makes sure the URL in the list email is generated like everywhere else in the OPAC. The same method won't work for the intranet and the OPACBaseURL is not taken into account at all. This is what creates the OpacBaseURL in OPAC from Auth.pm: (($in->{'query'}->https() ? "https://" : "http://") . $ENV{'SERVER_NAME'} . ($ENV{'SERVER_PORT'} eq ($in->{'query'}->https() ? "443" : "80") ? '' : ":$ENV{'SERVER_PORT'}"))), Feedback and ideas welcome... the attached patch could still be a small improvement as it adds consistency and makes the link work. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 18:59:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 17:59:01 +0000 Subject: [Koha-bugs] [Bug 11261] Sample frequencies and numbering patterns should better be mandatory on install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11261 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 18:59:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 17:59:16 +0000 Subject: [Koha-bugs] [Bug 11261] Sample frequencies and numbering patterns should better be mandatory on install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11261 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23340|0 |1 is obsolete| | Attachment #23341|0 |1 is obsolete| | --- Comment #7 from Galen Charlton --- Created attachment 23437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23437&action=edit Bug 11261: make sample serial numbering patterns mandatory during installation Test plan: Verify all sample_numberpatterns.* files have been moved from optional to mandatory directories. Signed-off-by: Katrin Fischer All sample files for numbering patterns are moved from optional to mandatory. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 18:59:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 17:59:30 +0000 Subject: [Koha-bugs] [Bug 11261] Sample frequencies and numbering patterns should better be mandatory on install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11261 --- Comment #8 from Galen Charlton --- Created attachment 23438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23438&action=edit Bug 11261: make sample serial frequencies mandatory during installation Test plan: Verify all sample_frequencies.* files have been moved from optional to mandatory directories. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:10:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:10:48 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 --- Comment #10 from Jonathan Druart --- (In reply to M. de Rooy from comment #9) > Just some preliminary QA comments while signing off (for the QAer on duty): Thanks Marcel, yours remarks allowed me to improve the code. > Cardnumber already in use or not in a good format: I would personally like > to differentiate between the two messages. Is it in use? Or is just the > length incorrect? Will be fixed > The min and maxlength logic in memberentry.pl should be in a module? New routine and UT will be provided. > Isn't there a way to check field length earlier with javascript than waiting > for Save? It is already done. I use the pattern attribute on the input html tag. > I am not a fan of my $qr = qr|^\d{$length}$|; and just pasting the pref > inside the regex. > You just assume that it is of the form m,n but you do not really know. > Why not just pull them out of the pref with a regex like (\d+),(\d+) or > similar? I use the code which was in the pl file from the pm. It avoids that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:13:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:13:51 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 --- Comment #11 from Jonathan Druart --- Created attachment 23439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23439&action=edit Bug 10861: Followup Add a check on cardnumber length This patch refactors the previous code and moves the logic from the pl to a new routine. Same test plan as previous patch. /!\ new unit test filename. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:15:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:15:05 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |gmcharlt at gmail.com --- Comment #2 from Galen Charlton --- This patch appears to be missing the creation of koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:16:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:16:53 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23420|0 |1 is obsolete| | Attachment #23421|0 |1 is obsolete| | Attachment #23422|0 |1 is obsolete| | Attachment #23423|0 |1 is obsolete| | Attachment #23424|0 |1 is obsolete| | Attachment #23425|0 |1 is obsolete| | Attachment #23426|0 |1 is obsolete| | Attachment #23427|0 |1 is obsolete| | Attachment #23428|0 |1 is obsolete| | Attachment #23429|0 |1 is obsolete| | Attachment #23430|0 |1 is obsolete| | Attachment #23431|0 |1 is obsolete| | Attachment #23432|0 |1 is obsolete| | Attachment #23433|0 |1 is obsolete| | --- Comment #70 from Kyle M Hall --- Created attachment 23440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23440&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:17:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:17:25 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23440|0 |1 is obsolete| | --- Comment #71 from Kyle M Hall --- Created attachment 23441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23441&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:17:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:17:34 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #72 from Kyle M Hall --- Created attachment 23442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23442&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:17:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:17:42 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #73 from Kyle M Hall --- Created attachment 23443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23443&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:17:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:17:51 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #74 from Kyle M Hall --- Created attachment 23444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23444&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:18:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:18:01 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #75 from Kyle M Hall --- Created attachment 23445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23445&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:18:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:18:11 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #76 from Kyle M Hall --- Created attachment 23446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23446&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:18:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:18:23 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #77 from Kyle M Hall --- Created attachment 23447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23447&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:18:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:18:32 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #78 from Kyle M Hall --- Created attachment 23448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23448&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:18:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:18:43 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #79 from Kyle M Hall --- Created attachment 23449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23449&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:18:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:18:53 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #80 from Kyle M Hall --- Created attachment 23450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23450&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:19:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:19:05 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #81 from Kyle M Hall --- Created attachment 23451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23451&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:19:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:19:15 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #82 from Kyle M Hall --- Created attachment 23452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23452&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:19:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:19:26 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #83 from Kyle M Hall --- Created attachment 23453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23453&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:19:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:19:36 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #84 from Kyle M Hall --- Created attachment 23454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23454&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:21:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:21:18 +0000 Subject: [Koha-bugs] [Bug 10983] Unused subroutines in C4:Budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10983 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:21:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:21:25 +0000 Subject: [Koha-bugs] [Bug 10983] Unused subroutines in C4:Budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10983 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21711|0 |1 is obsolete| | --- Comment #4 from Galen Charlton --- Created attachment 23455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23455&action=edit Bug 10983: Remove unused private subroutines from C4::Budgets The subroutine _filter_fields is not used by the module and the sub _columns is only used by it This patch removes the dead code. To test: [1] Verify that the following tests pass t/Budgets.t t/Budgets/CanUserModifyBudget.t t/Budgets/CanUserUseBudget.t t/db_dependent/Acquisition.t t/db_dependent/Acquisition/GetOrdersByBiblionumber.t t/db_dependent/Acquisition/Invoices.t t/db_dependent/Acquisition/OrderFromSubscription.t t/db_dependent/Acquisition/TransferOrder.t t/db_dependent/Acquisition/close_reopen_basket.t t/db_dependent/Bookseller.t t/db_dependent/Budgets.t t/db_dependent/Serials.t t/db_dependent/Serials_2.t Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:25:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:25:01 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 --- Comment #3 from Jonathan Druart --- Arg, thank for the catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:25:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:25:53 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:25:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:25:59 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23319|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 23456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23456&action=edit Bug 11343: The max number of items to process in a batch is hardcoded Until now, the maximum number of item records to process in a batch was hardcoded to 1000. This patch adds a syspref MaxItemsForBatch in order to allow to adapt this value. Test plan: - set the pref to 2 - try to delete a batch of 3 items: they are not displayed - try to modify a batch of 3 items: you are not allowed to do that - set the pref to 1000 and try again. Now items are displayed and you are allow to modify them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:42:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:42:01 +0000 Subject: [Koha-bugs] [Bug 8018] New subfields have a default max length of zero In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8018 --- Comment #2 from Pablo AB --- 9999 as default value is much more reasonable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:42:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:42:51 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #10 from Katrin Fischer --- Created attachment 23457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23457&action=edit Bug 5010: Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new system preference: PublicCatalogUsesSSL. To test: - Create a list - Send yourself the list from the staff interface - Verify that the links are http:// - Put some records into your cart - Send yourself the cart from the staff interface - Verify that the links are missing http(s):// in front of them - Apply patch - Run database update - Verify that the default setting for PublicCatalogUsesSSL is 'doesn't use' - Resent both emails - Verfiy the catalog links are now both http:// links - Change system preference setting to 'uses' - Resent both emails - Verify the catalog links are now https:// links -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:47:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 18:47:12 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #11 from Katrin Fischer --- NOTE: 2 last patches here are alternatives to the first patch, trying to avoid hardcoding the http:// into the templates. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:33:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 19:33:45 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23441|0 |1 is obsolete| | Attachment #23442|0 |1 is obsolete| | Attachment #23443|0 |1 is obsolete| | Attachment #23444|0 |1 is obsolete| | Attachment #23445|0 |1 is obsolete| | Attachment #23446|0 |1 is obsolete| | Attachment #23447|0 |1 is obsolete| | Attachment #23448|0 |1 is obsolete| | Attachment #23449|0 |1 is obsolete| | Attachment #23450|0 |1 is obsolete| | Attachment #23451|0 |1 is obsolete| | Attachment #23452|0 |1 is obsolete| | Attachment #23453|0 |1 is obsolete| | Attachment #23454|0 |1 is obsolete| | --- Comment #85 from Kyle M Hall --- Created attachment 23458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23458&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:34:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 19:34:12 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #86 from Kyle M Hall --- Created attachment 23459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23459&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:34:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 19:34:20 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #87 from Kyle M Hall --- Created attachment 23460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23460&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:34:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 19:34:27 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #88 from Kyle M Hall --- Created attachment 23461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23461&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:34:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 19:34:36 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #89 from Kyle M Hall --- Created attachment 23462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23462&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:34:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 19:34:44 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #90 from Kyle M Hall --- Created attachment 23463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23463&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:34:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 19:34:53 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #91 from Kyle M Hall --- Created attachment 23464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23464&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:35:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 19:35:02 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #92 from Kyle M Hall --- Created attachment 23465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23465&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:35:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 19:35:13 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #93 from Kyle M Hall --- Created attachment 23466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23466&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:35:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 19:35:25 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #94 from Kyle M Hall --- Created attachment 23467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23467&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:35:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 19:35:36 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #95 from Kyle M Hall --- Created attachment 23468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23468&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:35:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 19:35:48 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #96 from Kyle M Hall --- Created attachment 23469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23469&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:36:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 19:36:00 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #97 from Kyle M Hall --- Created attachment 23470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23470&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:36:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 19:36:15 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #98 from Kyle M Hall --- Created attachment 23471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23471&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:25:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 20:25:59 +0000 Subject: [Koha-bugs] [Bug 11386] New: Mandatory fields in subscription add form should use standard formatting Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11386 Bug ID: 11386 Summary: Mandatory fields in subscription add form should use standard formatting Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The mandatory fields on the subscription add form are not highlighting when you miss to enter data in one. Also, they are using (*) instead of the standard formatting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:26:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 20:26:14 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11386 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:26:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 20:26:14 +0000 Subject: [Koha-bugs] [Bug 11386] Mandatory fields in subscription add form should use standard formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11386 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7688 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 22:42:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 21:42:05 +0000 Subject: [Koha-bugs] [Bug 11263] New 'locale' setting in subscriptions is not user friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 22:42:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 21:42:16 +0000 Subject: [Koha-bugs] [Bug 11263] New 'locale' setting in subscriptions is not user friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23131|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 23472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23472&action=edit [PASSED QA] Bug 11263: locale setting is not user friendly The locales list for subscriptions should not be retrieve from the locales of the system. This patch retrieves the locales list from the Koha DB (in the same way as pref language and opaclanguages). Test plan: Edit a subscription (or a numbering pattern) and verify the list of languages is the same as languages available in Koha. Note: with this patch we loose the saeson translation, it is normal. See report linked. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors. New locale is retrieved from installed languages. I wonder if that list can be restricted to 'enabled' ones (parsing syspref language value). Signed-off-by: Katrin Fischer Passes QA script and all tests. Works according to description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 22:43:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 21:43:45 +0000 Subject: [Koha-bugs] [Bug 11263] New 'locale' setting in subscriptions is not user friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 --- Comment #10 from Katrin Fischer --- I am a bit worried about the consequences of this change, requiring to install templates, that won't be used apart from creating the list. How could we improve this? Using code similar to how we generate the list of searchable languages in advanced search maybe? Using a system preference? Still going to pass this as this looks like an improvement to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 22:47:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 21:47:59 +0000 Subject: [Koha-bugs] [Bug 11262] Don't require hardcoded translations for seasonal numbering pattern to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 22:48:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 21:48:06 +0000 Subject: [Koha-bugs] [Bug 11262] Don't require hardcoded translations for seasonal numbering pattern to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23338|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 23473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23473&action=edit [PASSED QA] Bug 11262 - Don't require hardcoded translations for seasonal numbering pattern to work This patch removes the use of POSIX::strftime which is based on the locales of the system. The DateTime module translates month and day name with success, without any locale installed. For the saesons, I use the way used in Koha: write the word in templates. On this way the translate script will match them and allow translators to translate them. This patch adds a regression: the season names are not translated following the locale selected. This could be done when bug 8044 will be pushed. Test plan: 0/ Update your po files and translate the season name. 1/ Create a numbering pattern using season. example: Name: Seasonal Numbering formula: {X} X: Season, Add=1, Every=1, Set back to 0 when more than 3, formatting "name of season" And test the prediction pattern with: frequency: 1/3 month First issue : 2013-09-21 length: 12 months X begins with 2 (21th Septembre is Fall) 2/ Click on the test pattern button, you should get: Fall 21/09/2013 Winter 21/12/2013 Spring 21/03/2014 Summer 21/06/2014 Change the locale and verify the season names are *not* translated. Change the Koha language and verify the season names are translated. 3/ Create a numbering pattern using day or month name. example: Name: day Numbering formula: {X} X: day, Add=1, Every=1, Set back to 0 when more than 6, formatting "name of day" Frequency: 1/day First issue: 2013-11-18 length: 1 month X begins with 0 You should get: Monday 18/11/2013 Tuesday 19/11/2013 Wednesday 20/11/2013 [...] Sunday 15/12/2013 Monday 16/12/2013 Tuesday 17/12/2013 change the locale and verify the day names are translated. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors Tested on top of Bug 11265 and Bug 11263, and solved merge conflict Updating PO file gives seasons to translate. Tested using seasons, day and month Only note is different behavior 1) To use seasons you need to use staff in desired language 2) To use day and month only need to select locale Signed-off-by: Kyle M Hall No regressions found. Passes koha-qa.pl, t and xt Signed-off-by: Katrin Fischer Tested this again on top of 11263 and it works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 22:49:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 21:49:50 +0000 Subject: [Koha-bugs] [Bug 11262] Don't require hardcoded translations for seasonal numbering pattern to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11262 --- Comment #12 from Katrin Fischer --- I'd like this a bit better if selecting 'seasonal' would deactivate the 'locale' option so there is no confusion. Or a bit more simple: add a hint to the locale that it won't work with seasonal currently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 23:12:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 22:12:30 +0000 Subject: [Koha-bugs] [Bug 9448] Add separate permission for writing off fees In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448 Joel Sasse changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse at plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 23:14:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 22:14:42 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Joel Sasse changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse at plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 23:28:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 22:28:58 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #25 from Katrin Fischer --- Comment on attachment 23386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23386 Bug 7567 - News by Branch Review of attachment 23386: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7567&attachment=23386) ----------------------------------------------------------------- Hi Mark, I did a quick code review - noted some things using splinter review below. Could you please take a look? ::: C4/NewsChannels.pm @@ +124,5 @@ > $data->{$data->{'lang'}} = 1 if defined $data->{lang}; > $data->{expirationdate} = format_date($data->{expirationdate}); > $data->{timestamp} = format_date($data->{timestamp}); > + if (!defined($data->{branchcode}) || $data->{branchcode} eq '') { > + $data->{branchname} = "All Branches"; Suspecting a translation problem here. @@ +166,5 @@ > while (my $row = $sth->fetchrow_hashref) { > if ((($limit) && ($count < $limit)) || (!$limit)) { > $row->{'newdate'} = format_date($row->{'newdate'}); > $row->{'expirationdate'} = format_date($row->{'expirationdate'}); > + $row->{'branchname'} = "All Branches" if !$row->{'branchcode'}; And here. ::: installer/data/mysql/en/optional/sample_news.sql @@ +1,1 @@ > +INSERT INTO `opac_news` ( title, new, Please also correct translated installers to avoid problems when installing Koha in other languages. ::: installer/data/mysql/updatedatabase.pl @@ +7826,5 @@ > > +$DBversion = "3.15.00.XXX"; > +if ( CheckVersion($DBversion) ) { > + $dbh->do(q{ > + ALTER TABLE opac_news ADD branchcode varchar(10) NULL DEFAULT NULL, Please make sure that the new column is added at the same position than it is in kohastructure.sql (using AFTER should work). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 23:30:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 22:30:05 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 23:45:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2013 22:45:12 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Joel Sasse changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse at plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 03:40:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 02:40:04 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23386|0 |1 is obsolete| | --- Comment #26 from M. Tompsett --- Created attachment 23474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23474&action=edit Bug 7567 - News by Branch By selecting a particular branch, news specific to a branch can be showed once the user logs into the opac (or the staff) client. This includes adding a non-NULL default '' branchcode field to the opac_news table. When a user is logged in they receive both '' and their branch news. When no user is logged in, they only receive '' news. '' means all branches. REVISED TEST PLAN ----------------- 1) Do a fresh install, to ensure that branchcode is created as a field in the opac_news table. - Did you try for something non-English? 2) Do an upgrade to confirm that the branchcode field is added to the opac_news table. 3) prove -v t/db_dependent/NewsChannels.t This should test all the changes in C4::NewsChannels functions. 4) Log into the staff client - Does the News display on the main page bust? 5) Add a new dummy branch (so it has no items or borrowers) 6) Go to Tools->News - Are the locations properly display? 7) Add a News item, for 'All' interfaces for 'All Branches'. 8) Add a News item, for 'Librarian interface' interfaces for the dummy branch. 9) Add a News item, for 'Slip' interfaces at your user branch. 10) Add a News item, for 'OPAC' interface at your user branch. 11) Change the Location and Branch filters. - Do they show what you select after you click the Filter button? (Unpatched the Location does not!) - Are the items displayed matching what is selected? - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) 12) Click 'Edit' for one of the news items added. - Does what comes up match what was displayed? ( Unpatched the Location may be 'All' ) - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) - Does the submitted values match the changes made? 13) Find a patron to print a slip for. Print Slip. - Does both the 'All' and 'Slip' news show up on the print slip? 14) In a new tab, go to OPAC - Does the News display on the main page bust? - Does it display the news item for a specific branch? (It shouldn't when patched, but unpatched it would) (Only one of the new things added should be displayed) 15) Log in as yourself on OPAC. - Does that piece of News display now too? (Both things added should be displayed) 16) In the staff client, delete the dummy branch. - Does the 'Librarian interface' news item exist any more? It shouldn't. 17) Check the news items added and click the delete button in the staff client. - Did it delete them appropriately? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 07:07:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 06:07:23 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23474|0 |1 is obsolete| | --- Comment #27 from M. Tompsett --- Created attachment 23475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23475&action=edit Bug 7567 - News by Branch By selecting a particular branch, news specific to a branch can be showed once the user logs into the opac (or the staff) client. This includes adding a NULL default branchcode field to the opac_news table. When a user is logged in they receive both NULL and their branch news. When no user is logged in, they only receive NULL news. NULL means all branches. C4::NewsChannels problems that were raised by Katrin Fischer have been corrected by modifying the template file, and removing the hardcoded strings. I have revised all the sample_news.sql files, including adding setting utf8, disabling and reenabling the foreign keys, and removing explicit references to the idnew field. The idnew field is autogenerated. This allowed me to source all the sql files and get all of them added into my MySQL DB. And as per Katrin Fischer's suggestion, I added AFTER into the ALTER command, so that the fresh install and update install should generate identical field orders. REVISED TEST PLAN ----------------- 1) Do a fresh install, to ensure that branchcode is created as a field in the opac_news table. - Did you try for something non-English? 2) Do an upgrade to confirm that the branchcode field is added to the opac_news table. 3) prove -v t/db_dependent/NewsChannels.t This should test all the changes in C4::NewsChannels functions. 4) Log into the staff client - Does the News display on the main page bust? 5) Add a new dummy branch (so it has no items or borrowers) 6) Go to Tools->News - Are the locations properly display? 7) Add a News item, for 'All' interfaces for 'All Branches'. 8) Add a News item, for 'Librarian interface' interfaces for the dummy branch. 9) Add a News item, for 'Slip' interfaces at your user branch. 10) Add a News item, for 'OPAC' interface at your user branch. 11) Change the Location and Branch filters. - Do they show what you select after you click the Filter button? (Unpatched the Location does not!) - Are the items displayed matching what is selected? - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) 12) Click 'Edit' for one of the news items added. - Does what comes up match what was displayed? ( Unpatched the Location may be 'All' ) - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) - Does the submitted values match the changes made? 13) Find a patron to print a slip for. Print Slip. - Does both the 'All' and 'Slip' news show up on the print slip? 14) In a new tab, go to OPAC - Does the News display on the main page bust? - Does it display the news item for a specific branch? (It shouldn't when patched, but unpatched it would) (Only one of the new things added should be displayed) 15) Log in as yourself on OPAC. - Does that piece of News display now too? (Both things added should be displayed) 16) In the staff client, delete the dummy branch. - Does the 'Librarian interface' news item exist any more? It shouldn't. 17) Check the news items added and click the delete button in the staff client. - Did it delete them appropriately? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 07:09:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 06:09:44 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #28 from M. Tompsett --- As per Katrin Fischer's comments in comment #18, I am going to attempt to split this into smaller pieces. This is why the status is still Failed QA. I just wanted to make sure my patch was here for eyeball review, if someone wanted to peek. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 07:48:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 06:48:13 +0000 Subject: [Koha-bugs] [Bug 11387] New: "Hold waiting too long" is untranslatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11387 Bug ID: 11387 Summary: "Hold waiting too long" is untranslatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr In the patron's account, the Fines-tab has a table that lists all charges. In the description of charges -column, a text "Hold waiting too long" can appear. This text cannot be translated - the description is hard-coded in C4/Reserves.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 08:55:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 07:55:05 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #29 from Katrin Fischer --- Hm out of interest, why are those 2 lines needed? +SET NAMES utf8; +SET FOREIGN_KEY_CHECKS=0; ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 09:04:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 08:04:27 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 09:04:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 08:04:33 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23439|0 |1 is obsolete| | --- Comment #12 from M. de Rooy --- Created attachment 23476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23476&action=edit Bug 10861: Followup Add a check on cardnumber length This patch refactors the previous code and moves the logic from the pl to a new routine. Same test plan as previous patch. /!\ new unit test filename. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 09:08:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 08:08:23 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from M. de Rooy --- >> Isn't there a way to check field length earlier with javascript than waiting >> for Save? > It is already done. I use the pattern attribute on the input html tag. Note that you removed the pattern attribute now. But it is no problem. It seems that this attribute does not work like it should. (I tested adding it again with a new Firefox 26 version, but it did not work..) Signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:22:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 09:22:25 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 --- Comment #14 from Jonathan Druart --- (In reply to M. de Rooy from comment #13) > Note that you removed the pattern attribute now. But it is no problem. > It seems that this attribute does not work like it should. (I tested adding > it again with a new Firefox 26 version, but it did not work..) Arf, it is not needed! I removed it for testing the server side error. I will provide a followup to reintroduce the test in the client side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:45:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 09:45:52 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 --- Comment #15 from Jonathan Druart --- Created attachment 23477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23477&action=edit Bug 10861: Reintroduced the cardnumber length check (client side) Previous patches has removed the pattern attribute of the input, it was not needed. This patch reintroduces it. It will only work for new browser version. Moreover, it manages with the ',XX' format (see UT). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:45:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 09:45:46 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:47:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 09:47:01 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 --- Comment #16 from Jonathan Druart --- Sorry Marcel but could you please have a look at this last (I hope!) followup please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 11:06:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 10:06:04 +0000 Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461 --- Comment #28 from mathieu saby --- Please Lyon 3 and Christophe, could you confirm that this bug has been sign off, and restore the Signed-off line in the commit msg? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 11:06:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 10:06:50 +0000 Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461 --- Comment #29 from mathieu saby --- Oups, sorry, the message was for an other bug ! Too many tabs open... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 11:13:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 10:13:56 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #52 from mathieu saby --- Hello Olivier I think it's the idea... But the idea of UT is also to test different configuraton. So, you should not only test my $PRICE_STRING='25.5 EUR, $32, $LD35'; my $expectedout='32'; but also made 3 or 4 other cases like '25,00 EUR' or '25 EUR' or '25 ?' for example Also, could you confirm that the original patch was signed off by C. Croullebois, and restore its sign-off line? So that it will be clear that we are at "QA" stage, and not at "Need sign off" ? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 11:28:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 10:28:21 +0000 Subject: [Koha-bugs] [Bug 11263] New 'locale' setting in subscriptions is not user friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 --- Comment #11 from Jonathan Druart --- (In reply to Katrin Fischer from comment #10) > I am a bit worried about the consequences of this change, requiring > to install templates, that won't be used apart from creating the list. > How could we improve this? Using code similar to how we generate > the list of searchable languages in advanced search maybe? Using a system > preference? > Still going to pass this as this looks like an improvement to me. Katrin, I used translated languages in order to avoid the long list. But maybe you are right. I am submitting a new followup for getting all languages (as the adv search). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 11:31:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 10:31:00 +0000 Subject: [Koha-bugs] [Bug 11263] New 'locale' setting in subscriptions is not user friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 --- Comment #12 from Jonathan Druart --- Created attachment 23478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23478&action=edit Bug 11263: Use all languages instead of translated only. This patch produces the same dropdown list as the one in the adv search. With this way, it won't be necessary to install additional templates to fill the locale list. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 11:44:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 10:44:23 +0000 Subject: [Koha-bugs] [Bug 11386] Mandatory fields in subscription add form should use standard formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11386 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 12:11:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 11:11:05 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 --- Comment #17 from M. de Rooy --- (In reply to Jonathan Druart from comment #16) > Sorry Marcel but could you please have a look at this last (I hope!) > followup please? Well I did. But it does not work (see earlier comment) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 12:12:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 11:12:28 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 --- Comment #18 from M. de Rooy --- (In reply to M. de Rooy from comment #17) > Well I did. But it does not work (see earlier comment) If I clear the field, the title flashes about what I should enter. But it does not force anything. Moreover, if I do not clear the field, I can type whatever I want without any warning or so.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 12:32:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 11:32:26 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 --- Comment #19 from Jonathan Druart --- Using Iceweasel 19.0, I set the pref to '5', add a new patron, fill the cardnumber field with "1234", click on "save" and the field is highlighted with a message "Please fill this field: Exactly 5 characters" (something like that). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 13:05:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 12:05:40 +0000 Subject: [Koha-bugs] [Bug 11279] Quote of the day feature won't pick a quote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11279 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 13:05:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 12:05:57 +0000 Subject: [Koha-bugs] [Bug 11279] Quote of the day feature won't pick a quote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11279 --- Comment #2 from Katrin Fischer --- I think I have a working patch, now trying to figure out some unit tests :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 13:10:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 12:10:20 +0000 Subject: [Koha-bugs] [Bug 5725] Batch modifications for Biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |MOVED --- Comment #77 from Jonathan Druart --- I am working on a new version of this, based on bug 8015. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 13:10:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 12:10:24 +0000 Subject: [Koha-bugs] [Bug 5574] 3.4 cataloguing improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5574 Bug 5574 depends on bug 5725, which changed state. Bug 5725 Summary: Batch modifications for Biblios http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 13:10:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 12:10:25 +0000 Subject: [Koha-bugs] [Bug 5724] Sometimes deletes aren't processed correctly by rebuild zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5724 Bug 5724 depends on bug 5725, which changed state. Bug 5725 Summary: Batch modifications for Biblios http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 13:10:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 12:10:26 +0000 Subject: [Koha-bugs] [Bug 5887] Add a link to batch modification of biblios from the Staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5887 Bug 5887 depends on bug 5725, which changed state. Bug 5725 Summary: Batch modifications for Biblios http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 13:40:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 12:40:36 +0000 Subject: [Koha-bugs] [Bug 11279] Quote of the day feature won't pick a quote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11279 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Chris Nighswonger --- Yay Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:03:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 13:03:45 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:03:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 13:03:51 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21144|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 23479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23479&action=edit Bug 10277 - Add C4::Context->IsSuperLibrarian() The method of checking the logged in user for superlibrarian privileges is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least. The codebase is littered with these lines, with no explanation given. It would be much better if we had one subroutine that returned a boolean value to tell us if the logged in user is a superlibrarian or not. Test Plan: 1) Apply this patch 2) Verify superlibrarian behavior remains unchanged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:20:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 13:20:52 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23479|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 23480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23480&action=edit Bug 10277 - Add C4::Context->IsSuperLibrarian() The method of checking the logged in user for superlibrarian privileges is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least. The codebase is littered with these lines, with no explanation given. It would be much better if we had one subroutine that returned a boolean value to tell us if the logged in user is a superlibrarian or not. Test Plan: 1) Apply this patch 2) Verify superlibrarian behavior remains unchanged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:21:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 13:21:00 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 --- Comment #22 from Kyle M Hall --- Created attachment 23481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23481&action=edit Bug 10277 [Followup] - Replace all remaining userenv checks with IsSuperLibrarian() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:31:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 13:31:03 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23481|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 23482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23482&action=edit Bug 10277 [Followup] - Replace all remaining userenv checks with IsSuperLibrarian() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:35:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 13:35:40 +0000 Subject: [Koha-bugs] [Bug 8018] New subfields have a default max length of zero In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8018 Pablo AB changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |pablo.bianchi at gmail.com --- Comment #3 from Pablo AB --- Created attachment 23483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23483&action=edit Set new subfields maxlenght by default to 9999. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:47:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 13:47:39 +0000 Subject: [Koha-bugs] [Bug 10190] notices based on item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:53:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 13:53:21 +0000 Subject: [Koha-bugs] [Bug 6670] Link patron name on returns screen to circulation page instead of patron detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6670 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:12:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:12:38 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23037|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 23484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23484&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Jerry Brock -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:16:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:16:03 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:20:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:20:28 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:21:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:21:06 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Bot Control|--- |Ignore this bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:21:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:21:33 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10502 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:21:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:21:33 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10502 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:21:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:21:33 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10277, 10278, 10263 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:21:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:21:33 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10502 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:22:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:22:53 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10263 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:22:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:22:53 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Blocks|10502 | Depends on|10206 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:22:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:22:53 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10263 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:23:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:23:22 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Bot Control|--- |Ignore this bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:24:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:24:52 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10278 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:24:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:24:52 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10277 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:25:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:25:19 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10276, 10277 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:25:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:25:19 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10263 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:25:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:25:19 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10263 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:25:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:25:38 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Bot Control|Ignore this bug |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:26:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:26:06 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10502 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:26:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:26:06 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10276, 10277, 10278 |10263 Bot Control|Ignore this bug |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:26:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:26:06 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10502 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:26:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:26:06 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10502 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:26:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:26:06 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10502 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:49:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 14:49:36 +0000 Subject: [Koha-bugs] [Bug 11388] New: Error exporting records to non-Unicode/MARC-8 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11388 Bug ID: 11388 Summary: Error exporting records to non-Unicode/MARC-8 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org If you have a record with line endings and in OPAC want to "Save record" to "MARC (non-Unicode/MARC-8)" (opac-export.pl?format=marc8&op=export&bib=2778&save=Go) you'll get something like: An error occurred Creation of MARCXML Record failed: Field 964 must have at least one subfield at /usr/share/perl5/MARC/File/SAX.pm line 113 But the field have a subfield, the problem is with line endings (LF, \n). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 16:39:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 15:39:21 +0000 Subject: [Koha-bugs] [Bug 8018] New subfields have a default max length of zero In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8018 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 16:39:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 15:39:36 +0000 Subject: [Koha-bugs] [Bug 8018] New subfields have a default max length of zero In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8018 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23483|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 23485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23485&action=edit Bug 8018: maxlenght should default to 9999 for subfields The default value for the marc_subfield_structure.maxlenght is 9999 in the DB. Currently the template passes an empty value which is casted to 0 by the CGI. This simple patch validates the input and converts to the default (9999) if not defined or 0. Another approach could be changing the 9999 default and/or treating 0 as 'no-limit'. PabloAB Signed-off-by: Tomas Cohen Arazi Works by defaulting 0 or "" to 9999. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 16:40:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 15:40:14 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21148|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 23486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23486&action=edit Bug 10502 - Add independent branches option for sql reports This patch adds the ability to hide reports created by other libraries based on the new IndependentBranchesReports system preference. This is accomplished by adding a branchcode field to the sql reports, which is set on report creation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranchesReports 4) Log in with a non-superlibrarian staff account 5) View existing sql reports, you should see no difference. Existing reports are 'grandfathered' in, assuming that existing reports may be used by multiple libraries or library groups. 6) Ensure you have selected a library to act as via the "set library" link. 7) Create a new sql report. 8) Verify it was created and you can view and edit it. 9) Change the logged in library to a difference branch. 10) Observe that the report is no longer visible in the reports list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 16:40:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 15:40:47 +0000 Subject: [Koha-bugs] [Bug 8018] New subfields have a default max length of zero In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8018 --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 23487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23487&action=edit Bug 8018: (followup) make the default more explicit This patch: - Makes the new subfield tab show maxlength=9999 as default (instead of empty-then-zero). - Updates the help to make exlpicit that 0 or empty defaults to 9999. - Assumes all the subfields created with maxlength=0 inadvertedly are meant to mean "no limit" and hence update the database to reflect that. To test (this patch and Pablo's): - Edit a MARC framework, edit some field's subfields. - Use the 'New' tab to create a new subfield (choose an unused letter). - See in "More constrains" that the "Max length" field is empty. Leave it as-is. - Save the changes (the new subfield). - Edit the field again, verify that "Max length" is 0. - Try tu use the framework and the the field/subfield just created > FAIL - Apply the patches, upgrade - Try to use the framework/field/subfield > SUCCESS (0 was converted to 9999) - Repeat from the beggining, "Max length" should show 9999 on the new subfield tab. - Leave it empty, it is saved as 9999. Regards To+ Sponsored-by: Universidad Nacionald de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 16:44:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 15:44:42 +0000 Subject: [Koha-bugs] [Bug 8018] New subfields have a default max length of zero In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8018 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23487|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 23488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23488&action=edit Bug 8018: (followup) make the default more explicit Edit: small typo Sponsored-by: Universidad Nacionald de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 17:33:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 16:33:06 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23484|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 23489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23489&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Jerry Brock -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 17:33:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 16:33:23 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21146|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 23490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23490&action=edit Bug 10278 - Add ability to hide items and records from search results for Independent Branches For the staff intranet, enabling IndependentBranchesRecordsAndItems will automatically add a branch limit filter to the search results thus hiding all records without one or more items owned by the logged in library. In add addition, all items whose homebranch is not that libraries will be filtered and hidden from the search results and record details. This system preference will not affect the OPAC, unless the environment variable BRANCHCODE is defined in the koha-httpd.conf file. If it is defined, the same filters are applied to the OPAC, but based on the branchcode value of the environment variable BRANCHCODE, rather than the logged in branch. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Perform a search that will give results for both records which have items owned by the logged in library, and records which have no items owned by the logged in library. 4) Enable the new system preference IndependentBranchesRecordesAndItems 5) Perform the same search again, any records without items owned by the currently logged in library should not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 17:33:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 16:33:37 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21147|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 23491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23491&action=edit Bug 10263 - Add ability to limit which branch can edit a bibliographic record ( IndependentBranchesMarcEditing ) Right now, it's possible to limit who can edit items by using IndependantBranches. However, Koha has no method of limiting who can edit bibliographic records, as they have no defined owner. This patch adds a new system preference IndependentBranchesMarcEditing. If this new syspref is enabled, a librarian can only edit or delete a bib record if his or her logged in branch code matches the branchcode in biblio.branchcode. This feature does not affect the ability to edit or delete items, as that functionality is determined by IndependantBranches. This patch adds the 'branches_optional' field to the authorised values pulldown for MARC fields and subfields in the MARC frameworks editor. 'branches_optional' behaves exactly like 'branches' except it includes an "empty" choice so the branch does not have to be set. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Map a nonrepeatable field/subfield to biblio.branchcode ( e.g. 951$o ) Pro-tip: Use the authorised value 'branches_optional' to get a pulldown of libraries instead of entering the branchcode manually. 4) Edit a record, and add a branchcode. 5) Log in as a non-superlibrarian with cataloging priveleges 6) Change the logged in branch to a branch other than the one you entered in the record. 7) You should note the 'edit' pulldown for the record is missing the "Edit record" and "Delete record" options. 8) Switch the logged in branch to match the branchcode of the record. 9) You should now see the edit and delete options for that record. 10) Attempt to edit a record with no branchcode defined, you should be able to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 17:33:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 16:33:56 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23486|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 23492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23492&action=edit Bug 10502 - Add independent branches option for sql reports This patch adds the ability to hide reports created by other libraries based on the new IndependentBranchesReports system preference. This is accomplished by adding a branchcode field to the sql reports, which is set on report creation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranchesReports 4) Log in with a non-superlibrarian staff account 5) View existing sql reports, you should see no difference. Existing reports are 'grandfathered' in, assuming that existing reports may be used by multiple libraries or library groups. 6) Ensure you have selected a library to act as via the "set library" link. 7) Create a new sql report. 8) Verify it was created and you can view and edit it. 9) Change the logged in library to a difference branch. 10) Observe that the report is no longer visible in the reports list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 21:02:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 20:02:05 +0000 Subject: [Koha-bugs] [Bug 11279] Quote of the day feature won't pick a quote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11279 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 21:02:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 20:02:13 +0000 Subject: [Koha-bugs] [Bug 11279] Quote of the day feature won't pick a quote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11279 --- Comment #4 from Katrin Fischer --- Created attachment 23493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23493&action=edit Bug 11279: Regression test This patch adds new tests based on the db_dependent tests in t/db_dependent/Koha.t for GetDailyQuote(). Tests run on an empty database and don't require Test::Deep. Tests will fail before applying the patch for 11297, but will pass after applying the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 21:02:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 20:02:38 +0000 Subject: [Koha-bugs] [Bug 11279] Quote of the day feature won't pick a quote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11279 --- Comment #5 from Katrin Fischer --- Created attachment 23494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23494&action=edit Bug 11279: Improve how a new quote of the day is selected When a lot of quotes were deleted, it's possible that no new quote will be selected. This will happen when a lot of the older quotes with low ids have been deleted. This patch improves the selection of a new quote. To test: - Load sample quotes - Delete the first half of the quotes. Note: With 34 quotes, delete the quotes with ids from 1-17 - Activate the QuoteOfTheDay system preference - Check if a quote is displayed in OPAC - Reload the page a few times, no quote should be displayed Note: make sure you don't have a quote with the current date in your quotes table before running those tests - Run 'perl t/db_dependent/Koha.t' Note: requires sample quotes! - Apply patch - Reload the OPAC start page - Verify a quote was now picked - Run 'perl t/db/dependent/Koha.t' again - all tests should still pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 21:03:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 20:03:00 +0000 Subject: [Koha-bugs] [Bug 11279] Quote of the day feature won't pick a quote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11279 --- Comment #6 from Katrin Fischer --- Feedback welcome :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 23:00:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 22:00:07 +0000 Subject: [Koha-bugs] [Bug 11277] Bootstrap theme: error in link for showing all facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- I can confirm the bug and the patch seems to fix it nicely for me - testd on a MARC21 database on current master with German data. I made sure to try some facets with umlauts as well. Owen, I am adding my sign-off here, but would feel better if you could take another look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 23:32:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 22:32:05 +0000 Subject: [Koha-bugs] [Bug 11277] Bootstrap theme: error in link for showing all facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 23:32:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 22:32:14 +0000 Subject: [Koha-bugs] [Bug 11277] Bootstrap theme: error in link for showing all facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23155|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 23495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23495&action=edit [SIGNED OFF] Bug 11277 Bootstrap theme facets doesn't work properly Two errors: 1. When selecting 'show more' above a facet, the advanced search page is displayed. 2. When restricting search on a library facet, all the biblio records of this library are returned. The patch fixes the way URL are encoded with TT filter. See that: http://search.cpan.org/~abw/Template-Toolkit-2.25/lib/Template/Manual/Filters.pod#url Signed-off-by: Katrin Fischer Patch works nicely. Tests done: - 'More' link on facets redirects to advanced search before applying the patch. After appyling the link works correctly. - In my tests, the facet links themselves worked nicely, limiting the search as expected. - Availability search works ok for me with patch applied. - Also made sure to click on some links containing diacricits (German umlauts). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 00:34:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 23:34:24 +0000 Subject: [Koha-bugs] [Bug 11277] Bootstrap theme: error in link for showing all facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23495|0 |1 is obsolete| | --- Comment #7 from Liz Rea --- Created attachment 23496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23496&action=edit Bug 11277 Bootstrap theme facets doesn't work properly Two errors: 1. When selecting 'show more' above a facet, the advanced search page is displayed. 2. When restricting search on a library facet, all the biblio records of this library are returned. The patch fixes the way URL are encoded with TT filter. See that: http://search.cpan.org/~abw/Template-Toolkit-2.25/lib/Template/Manual/Filters.pod#url Signed-off-by: Liz Rea Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 00:49:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 23:49:33 +0000 Subject: [Koha-bugs] [Bug 11389] New: re-enable PostgreSQL as a database scheme that Koha can connect to Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11389 Bug ID: 11389 Summary: re-enable PostgreSQL as a database scheme that Koha can connect to Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 7365 Bug 7188 (rightly) simplified C4::Context::db_scheme2dbi so that it always returns "mysql". Now that PostgreSQL is starting to become a realistic option, Pg should be added back as a valid choice for the DBD driver. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 00:49:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2013 23:49:33 +0000 Subject: [Koha-bugs] [Bug 7365] Koha should support PostgreSQL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11389 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 01:07:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 00:07:46 +0000 Subject: [Koha-bugs] [Bug 11389] re-enable PostgreSQL as a database scheme that Koha can connect to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11389 --- Comment #1 from Galen Charlton --- Created attachment 23497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23497&action=edit Bug 11389: reenable Pg as a DB scheme that Koha can connect to This patch restores the ability to request a DBI database handle or a DBIx::Class schema object connected to a PostgreSQL database. To address the concerns raised in bug 7188, only "mysql" and "Pg" are recognized as valid DB schemes. If anything else is passed to C4::Context::db_scheme2dbi or set as the db_scheme in the Koha configuration file, the DBD driver to load is assumed to be "mysql". Note that this patch drops any pretense of Oracle support. To test: [1] Apply patch, and verify that the database-dependent tests pass when run against a MySQL Koha database. [2] To test against PostgreSQL, create a Pg database and edit koha-conf.xml to set db_scheme to Pg (and adjust the other DB connection parameters appropriately). The following tests should pass, at minimum: t/Context.t t/db_dependent/Koha_Database.t Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 01:07:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 00:07:38 +0000 Subject: [Koha-bugs] [Bug 11389] re-enable PostgreSQL as a database scheme that Koha can connect to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11389 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 01:15:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 00:15:08 +0000 Subject: [Koha-bugs] [Bug 11390] New: DBIx::Class schema deployment script Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11390 Bug ID: 11390 Summary: DBIx::Class schema deployment script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 7365 DBIx::Class has the ability to load a scheme defined by a set of DBIC schema classes into an empty database. We can use this to gain the ability to use a single script to deploy to either MySQL or PostgreSQL and set the stage for using DBIx::Class::Schema::Versioned to manage updates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 01:15:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 00:15:08 +0000 Subject: [Koha-bugs] [Bug 7365] Koha should support PostgreSQL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11390 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 01:45:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 00:45:58 +0000 Subject: [Koha-bugs] [Bug 11390] DBIx::Class schema deployment script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11390 --- Comment #1 from Galen Charlton --- WIP can be found on the following Git branch: http://git.librarypolice.com/?p=koha-galen.git;a=shortlog;h=refs/heads/pg/bug11390_db_deploy_script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 01:54:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 00:54:21 +0000 Subject: [Koha-bugs] [Bug 11391] New: suggestions.suggesteddate has a problematic default value Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11391 Bug ID: 11391 Summary: suggestions.suggesteddate has a problematic default value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 7365 The column suggesteddate in the suggestions table is currently defined as "date NOT NULL default 0". When DBIx::Class translates that PostgreSQLese, it ends up as "date DEFAULT '0000-00-00' NOT NULL". Since 0000-00-00 is not a valid date, DBIC will fail to deploy the suggestions table to a Pg database. Since suggesteddate is supposed to be the date that the suggestion was submitted, CURRENT_DATE is a better default value regardless. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 01:54:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 00:54:21 +0000 Subject: [Koha-bugs] [Bug 7365] Koha should support PostgreSQL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11391 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 02:01:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 01:01:15 +0000 Subject: [Koha-bugs] [Bug 11391] suggestions.suggesteddate has a problematic default value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11391 --- Comment #1 from Galen Charlton --- Sadly, CURRENT_DATE itself cannot be used, as MySQL a non-constant default value only for timestamp columns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 02:16:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 01:16:26 +0000 Subject: [Koha-bugs] [Bug 11391] suggestions.suggesteddate has a problematic default value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11391 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 02:16:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 01:16:31 +0000 Subject: [Koha-bugs] [Bug 11391] suggestions.suggesteddate has a problematic default value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11391 --- Comment #2 from Galen Charlton --- Created attachment 23498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23498&action=edit Bug 11391: drop default value on suggestions.suggesteddate column The 'default 0' clause got translated as an invalid constant default of '0000-00-00' when DBIx::Schema is used to deploy the suggestions table into a Pg database. This patch drops the default. To test: [1] Apply the patch and run the SQL specified in the database updated. [2] Verify that the suggestions table no longer has an explicit default value for the suggesteddate column. [3] Verify that prove -v t/db_dependent/Suggestions.t passes. [4] Verify that installer/data/mysql/kohastructure.sql runs cleanly in an empty database. [5] Verify that there are no visible regressions of the purchase suggestions functionality. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 02:16:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 01:16:39 +0000 Subject: [Koha-bugs] [Bug 11391] suggestions.suggesteddate has a problematic default value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11391 --- Comment #3 from Galen Charlton --- Created attachment 23499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23499&action=edit Bug 11391: (follow-up) update DBIC schema classes This patch updates the DBIC schema class for Suggestion to reflect the dropped default value for the suggesteddate column. To test: [1] Create an empty Pg database and use the deployment script being worked in in bug 11390. The deployment shoudl succeed without reporting any errors regarding the suggestions table. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 02:35:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 01:35:09 +0000 Subject: [Koha-bugs] [Bug 11155] PostgreSQL schema contains syntax errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 02:40:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 01:40:18 +0000 Subject: [Koha-bugs] [Bug 11155] PostgreSQL schema contains syntax errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 --- Comment #4 from Galen Charlton --- Created attachment 23500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23500&action=edit Bug 11155: remove old PostgreSQL schema and MARC framework scripts This patch removes the legacy Pg schema and MARC framework scripts as they're out of date. They will be replaced by use of DBIx::Class to deploy the schema. Loading the sample data and settings will be accomplished either by making the current scripts in installer/data/mysql DBMS-independent (or, at least, able to be processed by both MySQL and Pg), converting them to flat text files and writing code to load them, or a combination of the two approaches. To test: [1] Verify that installer/data/Pg is removed. There is some code in C4::Installer that refers to that directory, but it cannot be reached through normal means. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 02:41:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 01:41:16 +0000 Subject: [Koha-bugs] [Bug 11155] PostgreSQL schema contains syntax errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7365 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 02:41:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 01:41:16 +0000 Subject: [Koha-bugs] [Bug 7365] Koha should support PostgreSQL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11155 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 02:54:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 01:54:20 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #30 from Liz Rea --- *** Bug 11372 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 02:54:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 01:54:20 +0000 Subject: [Koha-bugs] [Bug 11372] show only branch specific news on slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11372 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |liz at catalyst.net.nz Resolution|--- |DUPLICATE --- Comment #1 from Liz Rea --- *** This bug has been marked as a duplicate of bug 7567 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 02:57:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 01:57:17 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #7 from Liz Rea --- putting the hold notification in a modal window might be nice here as well - something that greys the screen and puts the hold notice on top (with a non-js fallback, of course) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 05:23:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 04:23:48 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #31 from M. Tompsett --- Created attachment 23501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23501&action=edit Bug 7567 - Testing for C4/NewsChannel.pm Testing was lacking, this tests every function call. As a side effect, this moved the stub of a test file from t/NewsChannels.t to t/db_dependent/NewsChannels.t, since the table opac_news must exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 05:29:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 04:29:46 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #32 from M. Tompsett --- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23501&action=diff is the beginning of the breaking the first patch into smaller pieces. It applies against master, and basically creates the basis for the tests that must continue to succeed at each step. TEST PLAN --------- 1) git checkout -b bug_7567 origin/master 2) cat t/NewsChannels.t 3) cry that only a use was checked. 4) prove -v t/NewsChannels.t 5) git bz apply 7567 6) prove -v t/db_dependent/NewsChannels.t 7) cat t/NewsChannels.t 8) cheer that all the functions in C4/NewsChannels.pm are called at least once. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 07:39:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 06:39:47 +0000 Subject: [Koha-bugs] [Bug 11392] New: logaction() modulename and action are untranslatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11392 Bug ID: 11392 Summary: logaction() modulename and action are untranslatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When viewing the logs, the user can see module and action, such as "SYSTEMPREFERENCE", "MEMBERS" or "CREATE", "MODIFY", etc. These texts are not translatable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 08:31:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 07:31:02 +0000 Subject: [Koha-bugs] [Bug 11207] Impossibility to remove a sms number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 08:41:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 07:41:06 +0000 Subject: [Koha-bugs] [Bug 10809] use template branches plugin in serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Fridolin SOMERS --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 08:46:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 07:46:12 +0000 Subject: [Koha-bugs] [Bug 11393] New: Language menu not show up as name for Thai (th-THA was shown) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 Bug ID: 11393 Summary: Language menu not show up as name for Thai (th-THA was shown) Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pongtawat.c at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When Thai translation is installed and enabled. The language menu at the bottom of OPAC screen shown up as language code "th-THA". Also, the preference "language" and "opaclanguage" also show up as "(th-THA)". However, if I change the Thai template folder from "opac-tmpl/prog/th-THA" to "opac-tmpl/prog/th", the language menu, as well as the preferences, will display entry for Thai as "???????" which is correct. So, I don't know if there is some value missing (or incorrect) in database for "th-THA" or that the translation template should be "th". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 08:46:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 07:46:27 +0000 Subject: [Koha-bugs] [Bug 10376] Printing cart does not work under IE9 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #10 from David Cook --- Fun fact: Microsoft have changed the navigator.appName property to "Netscape" in IE11, so this latest fix won't work for newer versions of IE. http://msdn.microsoft.com/en-us/library/ie/bg182625(v=vs.85).aspx Conditional comments were also removed in IE 10 which makes "simpler" separation of browser dependent code impossible. http://msdn.microsoft.com/en-us/library/ie/hh801214(v=vs.85).aspx -- I've looked at this a million different ways...and there's always a problem. window.onfocus (works great for IE but doesn't work for Chrome or Firefox.) window.setTimeout (this has different syntax in different browsers. While you can get it to work with Chrome + IE or Chrome + FF, you can't seem to get it to work with all 3.) -- I was able to trigger location.href only after the "afterprint" event fired but it didn't make a difference. It still redirected before printing in IE. I tried using this as a guide: http://msdn.microsoft.com/en-us/library/ie/hh273397(v=vs.85).aspx But I can't think of any way to really identify IE as separate from FF or Chrome without more browser detection of some kind. The thing is that "window.onfocus" does work, but you have to remove focus from a FF or Chrome window by switching windows and coming back to it. -- I don't know if there really is a solution to this problem. It probably wouldn't help to open a new window, print, and close, because I think the same thing happens. -- I tried "", which works in IE and Firefox, but not Chrome... I don't know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 08:50:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 07:50:37 +0000 Subject: [Koha-bugs] [Bug 11245] typo in modborrowers.tt javascript string In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11245 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 08:51:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 07:51:12 +0000 Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:02:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 08:02:38 +0000 Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Fridolin SOMERS --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:14:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 08:14:34 +0000 Subject: [Koha-bugs] [Bug 11061] Koha::Calendar::_mock_init is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11061 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:24:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 08:24:10 +0000 Subject: [Koha-bugs] [Bug 11238] The version of the manual online link should be dynamically updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11238 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:28:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 08:28:08 +0000 Subject: [Koha-bugs] [Bug 11040] Add option to print regular slip to CircAutoPrintQuickSlip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11040 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:44:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 08:44:52 +0000 Subject: [Koha-bugs] [Bug 11146] Show a go back link on no permission page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11146 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:51:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 08:51:04 +0000 Subject: [Koha-bugs] [Bug 7491] Description for item-level_itypes is misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7491 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:51:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 08:51:43 +0000 Subject: [Koha-bugs] [Bug 11222] A regression on label-item-search.pl done by Bug 9239 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:55:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 08:55:43 +0000 Subject: [Koha-bugs] [Bug 11222] A regression on label-item-search.pl done by Bug 9239 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #15 from Fridolin SOMERS --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:57:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 08:57:00 +0000 Subject: [Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron Messaging Preferences Form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:02:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 09:02:35 +0000 Subject: [Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron Messaging Preferences Form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Fridolin SOMERS --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:23:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 09:23:39 +0000 Subject: [Koha-bugs] [Bug 11394] New: "Routing lists" -tab vanishes from patron info bar Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11394 Bug ID: 11394 Summary: "Routing lists" -tab vanishes from patron info bar Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When you've looked up a patron, and you have the info on the left side of the screen, with the tabs "Check Out", "Details", "Fines", etc, the "Routing Lists" -tab vanishes, if you go to the "Purchase suggestions" -tab. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:45:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 09:45:10 +0000 Subject: [Koha-bugs] [Bug 11395] New: Batch modifications for records Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Bug ID: 11395 Summary: Batch modifications for records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org This report revives bug 5725. Since bug 8015 is pushed, it is easy to provide a new batch record modification using the existing API. Here, we just have to create a new script without any logic on the record modifications. By "records", I include both biblios and authorities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:46:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 09:46:57 +0000 Subject: [Koha-bugs] [Bug 5725] Batch modifications for Biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11395 --- Comment #78 from Jonathan Druart --- see bug 11395 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:46:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 09:46:57 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5725 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:47:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 09:47:25 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:29:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 10:29:39 +0000 Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:36:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 10:36:43 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:36:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 10:36:49 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #1 from Jonathan Druart --- Created attachment 23502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23502&action=edit Bug 11395: Add a batch record modification This patch offers a new tool to modify records in a batch. This feature adds: - a new pl/tt files tools/batch_record_modification - a new permission: tools > records_batchmod Test plan for biblios: 0/ Create a new marc modification template with some actions. 1/ Generate a list of biblionumbers you want to modify. There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Modify" - generating a list from a report 2/ On the "Batch record modification" tool verify: - information is correct. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Test plan for authority: 0/ Create a new marc modification template with some actions. 1/ Generate a list of authid using a report: 2/ On the "Batch record modification" tool verify: - authorities are display with the summary. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Catch of errors: if an error occurs during the modification process, the tool displays an error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:36:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 10:36:55 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #2 from Jonathan Druart --- Created attachment 23503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23503&action=edit Bug 11395: Add links to the new tool page This patch adds links in the tool module to the new batch tool and in the basket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:37:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 10:37:03 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #3 from Jonathan Druart --- Created attachment 23504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23504&action=edit Bug 11395: Fix return for ModifyRecordWithTemplate Make sure the ModifyRecordWithTemplate routine returns undef. This patch also removes a warning if GetModificationTemplates is called without parameter. Verify prove t/db_dependent/MarcModificationTemplates.t returns green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:37:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 10:37:12 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #4 from Jonathan Druart --- Created attachment 23505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23505&action=edit Bug 11395: DB: Add permission tools_records_batchmod -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:37:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 10:37:20 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #5 from Jonathan Druart --- Created attachment 23506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23506&action=edit Bug 11395: New service to preview a record. The main patch adds the ability to preview a record. This is done using an AJAX way. The preview record is processed on the server side. Note: I don't think an authentification check is necessary here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:42:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 10:42:31 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #6 from Jonathan Druart --- Created attachment 23507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23507&action=edit form screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:42:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 10:42:48 +0000 Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #55 from Fridolin SOMERS --- This patch has been pushed to 3.14.x, will be in 3.14.1 Contains 3 patches : 08c8bea Bug 6435: (follow-up) make -daemon really imply -a and -b ae9e02a Bug 6435: (follow-up) rebuild_zebra -daemon option now smarter e7482ec Bug 6435: Add daemon mode to rebuild_zebra.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:43:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 10:43:07 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #7 from Jonathan Druart --- Created attachment 23508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23508&action=edit list screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:44:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 10:44:15 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8015 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:44:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 10:44:15 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11395 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:47:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 10:47:11 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #8 from Jonathan Druart --- Note that bug 11319 improves and fixes some inconsistencies of the marc modification templates feature. I tested this feature on top of the improvement but it applies well against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:56:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 10:56:47 +0000 Subject: [Koha-bugs] [Bug 10983] Unused subroutines in C4:Budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10983 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:56:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 10:56:53 +0000 Subject: [Koha-bugs] [Bug 10983] Unused subroutines in C4:Budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10983 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23455|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 23509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23509&action=edit Bug 10983: Remove unused private subroutines from C4::Budgets The subroutine _filter_fields is not used by the module and the sub _columns is only used by it This patch removes the dead code. To test: [1] Verify that the following tests pass t/Budgets.t t/Budgets/CanUserModifyBudget.t t/Budgets/CanUserUseBudget.t t/db_dependent/Acquisition.t t/db_dependent/Acquisition/GetOrdersByBiblionumber.t t/db_dependent/Acquisition/Invoices.t t/db_dependent/Acquisition/OrderFromSubscription.t t/db_dependent/Acquisition/TransferOrder.t t/db_dependent/Acquisition/close_reopen_basket.t t/db_dependent/Bookseller.t t/db_dependent/Budgets.t t/db_dependent/Serials.t t/db_dependent/Serials_2.t Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart Looks good to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 12:21:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 11:21:42 +0000 Subject: [Koha-bugs] [Bug 11040] Add option to print regular slip to CircAutoPrintQuickSlip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11040 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS --- This patch has been pushed to 3.14.x, will be in 3.14.1. (creates DBRev 3.14.00.001) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 12:37:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 11:37:58 +0000 Subject: [Koha-bugs] [Bug 11174] Wrong parameter 'valuec' in opac-authoritiessearchresultlist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11174 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 12:38:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 11:38:05 +0000 Subject: [Koha-bugs] [Bug 11174] Wrong parameter 'valuec' in opac-authoritiessearchresultlist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11174 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23136|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 23510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23510&action=edit BUG 11174 wrong paramter 'valuec' In the templates opac-authoritiessearchresultlist of prog and bootstrap the wrong value 'valuec' is changed with 'value' Signed-off-by: Marcel de Rooy Tested with bootstrap. Signed-off-by: Jonathan Druart Following commit remove the use to valuec: commit 31f41e2c1db9d8dca82e0249050acb8f906c8164 Bug 8206: Specify index in OPAC authority search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:00:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 12:00:25 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #8 from Jonathan Druart --- (In reply to Owen Leonard from comment #5) > Is there any reason to show the input field at all if it's disabled? We are > inconsistent on the checkout page. Sometimes the input is displayed as > disabled, sometimes it is hidden. I think we should stick with hiding the > input (and the "options" checkboxes too in this case) if the user cannot > interact with them. Owen, could you explain this point please? This patch impacts the check-in page and I don't know where there is hidden fields. To me it is consistent to disable the input and the submit button here. (In reply to Liz Rea from comment #7) > putting the hold notification in a modal window might be nice here as well - > something that greys the screen and puts the hold notice on top (with a > non-js fallback, of course) It is out-of-the-scope of this bug. Maybe could you open a new report for that? Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:00:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 12:00:47 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23367|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 23511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23511&action=edit Bug 11360 - Disable barcode field and submit button when a hold is found At the moment when scanning in returns, it can be easy to miss a hold trap due to the fact that the barcode and submit are still active and the barcode field is focused on. A librarian who is focused on scanning can easily scan another item and pass over the form, which is equivalent to clicking the "ignore" button. Test Plan: 1) Place a hold on an item 2) Scan that item's barcode though returns.pl 3) Note the hold trap 4) Scan another barcode 5) Note you were able to bypass interacting with the trapped hold form 6) Apply this patch 7) Repeat steps 2-4 8) Note you must now click one of the buttons. Clicking ignore will allow you to continue scanning items as before. Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:04:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 12:04:36 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:04:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 12:04:52 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23357|0 |1 is obsolete| | --- Comment #120 from Jonathan Druart --- Created attachment 23512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23512&action=edit Bug 7143: Adding RMaint for 3.8 to release team As a follow-up after December 4 meeting. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Correct addition, no problems found. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:11:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 12:11:56 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #15 from Jonathan Druart --- Kyle, Why did you submit new patches when the patch is signed off? Why don't you submit followups? What is the diff between the SO patch and the last one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:13:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 12:13:04 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #16 from Jonathan Druart --- Maybe it is just a rebase... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:15:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 12:15:05 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #24 from Jonathan Druart --- unit tests should be provided for the new IsSuperLibrarian routine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:16:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 12:16:50 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #16 from Jonathan Druart --- ping Kyle, park to in discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:22:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 12:22:35 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #6 from Jonathan Druart --- Kyle, what is your opinion on my patch? Maybe it is stupid, what do you think about it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:55:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 12:55:11 +0000 Subject: [Koha-bugs] [Bug 11374] Need provision to give batch name in Tools > Label creator > Manage batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11374 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:56:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 12:56:29 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6427 --- Comment #1 from Kyle M Hall --- Excellent! I would like to note that the accounts rewrite ( Bug 6427 ) also has this feature. Kyle -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:56:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 12:56:29 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11373 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:57:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 12:57:05 +0000 Subject: [Koha-bugs] [Bug 11383] There is no help page for the marc modification templates tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11383 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Component|Tools |Documentation Assignee|kyle at bywatersolutions.com |nengard at gmail.com --- Comment #1 from Nicole C. Engard --- Can you tell me the URL of the page you're referring to? Are we talking about staff help document or Perl help document? Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:58:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 12:58:05 +0000 Subject: [Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #10 from Fridolin SOMERS --- Patches will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 14:01:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 13:01:13 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 14:05:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2013 13:05:24 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #17 from Kyle M Hall --- (In reply to Jonathan Druart from comment #15) > Kyle, > Why don't you use the Batch patron deletion? Maybe we could have a new entry > "Delete patrons in the list Renew[% END %] ([% ISSUE.renewsleft %] of [% ISSUE.renewsallowed %] renewals remaining) > [% ELSE %] > + [% IF ( ISSUE.norenew_overdue ) %] > + Renewal not allowed (overdue on a document) I think instead of using 'document' better use 'item' to be consistent with the language in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 15:45:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 14:45:27 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #68 from Katrin Fischer --- Hm, it looks like the patch is from "Koha Team Lyon 3", but the bug is assigned to Fridolin - got a bit confused here :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 15:45:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 14:45:42 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 15:50:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 14:50:40 +0000 Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #29 from Katrin Fischer --- Ok, it looks like Jonathan and me can't do QA here - could someone else take this on please? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 16:25:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 15:25:14 +0000 Subject: [Koha-bugs] [Bug 11449] New: Syntax error in moredetail.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11449 Bug ID: 11449 Summary: Syntax error in moredetail.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: jason at esilibrary.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com line 326: var countorders = ; It's an uncaught exception that you can get from these tabs for a bib record: Items, MARC, Labeled MARC, and ISBD. At least in the case of the Items tab, it can prevent subsequent actions in the interface from working, such as Edit -> Delete all items This happens in master and 3.14.0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 16:25:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 15:25:17 +0000 Subject: [Koha-bugs] [Bug 11252] rebuild_zebra.pl should not have --munge-config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11252 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 16:31:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 15:31:37 +0000 Subject: [Koha-bugs] [Bug 10453] updating child to adult loses password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 16:41:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 15:41:36 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #36 from Katrin Fischer --- Hm not sure if this should go in stable versions as it is a new feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 16:42:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 15:42:54 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 --- Comment #37 from Katrin Fischer --- Hm, it also seems to need more work, as the depending bugs suggest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 16:46:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 15:46:22 +0000 Subject: [Koha-bugs] [Bug 11282] Not possible to create multiple restrictions from patron details/new restriction overwrites existing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11282 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 16:50:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 15:50:29 +0000 Subject: [Koha-bugs] [Bug 11287] Import borrowers doesn't take into account the new restriction system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- This probably won't affect my decision to push the patch, but one thing that occurs to me: even with the patch, there is overall a regression from 3.12. Specifically, prior to the new restriction system, a patron file could be used both to set and remove debarments. One example where one might want to remove debarments via patron import: imagine an academic library that receives patron updates frequently. If the patron owes money to the university, the bursar's office might want to be able to set a debarment to suspend the patron's library privileges. Once they settle their account with the bursar, the next patron import could lift the restriction. General question: are there Koha users out there who actually do this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 16:54:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 15:54:15 +0000 Subject: [Koha-bugs] [Bug 11412] Bulkmarcimport can crash when searching for duplicates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Matthias! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 17:02:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 16:02:57 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED --- Comment #38 from Galen Charlton --- (In reply to Fridolin SOMERS from comment #33) > Patches pushed to 3.14.x, will be in 3.14.2 > (creates version 3.14.01.002) I request that you revert this from the 3.14.x branch immediately. By long tradition, the maintenance releases are not supposed to receive enhancements except for the most trivial ones. In this case, the enhancement is not so trivial, and as comments 30 and 32 indicate, there is agreement between me and the patch submitter that some more work is needed prior to the release of 3.16. To put it one way: if the feature is not quite ready for 3.16, it's definitely not ready for 3.14.2. Marking as in discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 17:03:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 16:03:06 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 17:05:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 16:05:06 +0000 Subject: [Koha-bugs] [Bug 11287] Import borrowers doesn't take into account the new restriction system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- If you can't unset/delete a restriction on import with the new system we will be hurt by this. We have one library where we receive a complete file of all students for importing. Prior to the import we set a restriction for all students, that is then lifted for all students in the file. Students that have left/not paid for the next semester will stay restricted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 17:17:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 16:17:56 +0000 Subject: [Koha-bugs] [Bug 11287] Import borrowers doesn't take into account the new restriction system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 --- Comment #7 from Galen Charlton --- Thinking aloud, I wonder of adding a borrower_debarments.type value of "PATRON_IMPORT" that could be set and removed by the patron importer is the way to go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 17:19:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 16:19:26 +0000 Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |matted-34813 at mypacks.net |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 17:19:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 16:19:46 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #39 from Tom?s Cohen Arazi --- (In reply to Galen Charlton from comment #38) > (In reply to Fridolin SOMERS from comment #33) > > Patches pushed to 3.14.x, will be in 3.14.2 > > (creates version 3.14.01.002) > > I request that you revert this from the 3.14.x branch immediately. By long > tradition, the maintenance releases are not supposed to receive enhancements > except for the most trivial ones. > > In this case, the enhancement is not so trivial, and as comments 30 and 32 > indicate, there is agreement between me and the patch submitter that some > more work is needed prior to the release of 3.16. To put it one way: if the > feature is not quite ready for 3.16, it's definitely not ready for 3.14.2. > > Marking as in discussion. I agree that even when it is the Release Maintainer call whether to cherry-pick and enhancement or not, in this case it can be harmfull as more work is needed for this to be production-ready. At least, a consecquence might be holding the next maintainance release until the missing patches are actually commited. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 17:27:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 16:27:26 +0000 Subject: [Koha-bugs] [Bug 11287] Import borrowers doesn't take into account the new restriction system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 --- Comment #8 from Katrin Fischer --- I think this could work. Another idea: could we use the description in combination with the debarment date? Set restriction: 'some description' '2014-02-28' Unset restriction: 'some description' '' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 17:31:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 16:31:53 +0000 Subject: [Koha-bugs] [Bug 11287] Import borrowers doesn't take into account the new restriction system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 --- Comment #9 from Katrin Fischer --- Hm I think the advantage of Galen's idea would be that the existing format would not have to be changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 18:57:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 17:57:18 +0000 Subject: [Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Katrin Fischer --- Some comments on this: 1) Why not make the option "sticky" and saving the choice in a cookie? As it is currently it seems that you will have to recheck the checkbox for every new title that you catalog. It would be nice if it behaved the same as the "Show MARC tag documentation links" feature. 2) There seems to be a weird problem when switching frameworks: - Go to cataloguing - Create a new record based on the default framework - Switch the framework to "Audio..." - Switch back to default What I had happen was that after switching the framework, I would be redirectd to the item form and an empty record was saved. I couldn't reproduce this behaviour on master without the patch applied. 3) Why not place the "Hide tags" next to "Show MARC tag documentation links"? 4) As we have a separate option to hide documentation links, I think hiding the tags should only hide the tags, but not the documentation links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 18:59:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 17:59:19 +0000 Subject: [Koha-bugs] [Bug 11419] z39.50 searches not displaying errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11419 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |minor --- Comment #4 from Katrin Fischer --- I think the empty dialog box indicates some kind of bug, so changing this to 'minor' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 19:07:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 18:07:10 +0000 Subject: [Koha-bugs] [Bug 11419] z39.50 searches not displaying errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11419 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 19:07:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 18:07:17 +0000 Subject: [Koha-bugs] [Bug 11419] z39.50 searches not displaying errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11419 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23719|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 23821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23821&action=edit [PASSED QA] Bug 11419 - z39.50 searches not displaying errors When a z39.50 server isn't able to be searched successfully, the yellow error box comes up empty. Test Plan: 1) Go to Administration/z39.50 servers 2) Create a fake z39.50 server with a made up address 3) Go to cataloging, search only that server 4) Note the empty yellow alert box 5) Apply this patch 6) Re-run the search, not the alert box has a message in it now Signed-off-by: Nora Blake Signed-off-by: Katrin Fischer Passes all tests and QA script. Works according to test plan. When one of the selected servers gives result no dialog box is shown before and after applying the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 19:08:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 18:08:21 +0000 Subject: [Koha-bugs] [Bug 11419] z39.50 searches not displaying errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11419 --- Comment #6 from Katrin Fischer --- Thank you for your sign-off Nora! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 26 19:46:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 18:46:00 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 --- Comment #40 from Chris Cormack --- (In reply to Galen Charlton from comment #38) > (In reply to Fridolin SOMERS from comment #33) > > Patches pushed to 3.14.x, will be in 3.14.2 > > (creates version 3.14.01.002) > > I request that you revert this from the 3.14.x branch immediately. By long > tradition, the maintenance releases are not supposed to receive enhancements > except for the most trivial ones. > +1 > In this case, the enhancement is not so trivial, and as comments 30 and 32 > indicate, there is agreement between me and the patch submitter that some > more work is needed prior to the release of 3.16. To put it one way: if the > feature is not quite ready for 3.16, it's definitely not ready for 3.14.2. > I agree, and probably would hold this for 3.16 even if it was ready. > Marking as in discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 00:44:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 23:44:21 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 00:44:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 23:44:28 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23801|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 23822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23822&action=edit Bug 11439: UT: XISBN.t returns failure A unit test fails in t/db_dependent/XISBN.t, the get_xisbn routine, if ThingISBN is enabled, returns the 3rd biblionumber, not the second one. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 00:44:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 23:44:43 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23802|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 23823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23823&action=edit Bug 11439: UT: Improve XISBN.t The tests should be executed into a transaction and the SimpleSearch routine correctly mocked. Test plan: Verify that prove t/db_dependent/XISBN.t returns green. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 00:49:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 23:49:52 +0000 Subject: [Koha-bugs] [Bug 11450] New: Hold Request Confirm Deletion Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 Bug ID: 11450 Summary: Hold Request Confirm Deletion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Would like to see a confirmation screen before deleting hold requests (request.pl). As it is now, if you purposely or accidently click on the delete button, the hold request is deleted instantly. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 00:55:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Dec 2013 23:55:39 +0000 Subject: [Koha-bugs] [Bug 11451] New: Hold Delete method needs standardization Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11451 Bug ID: 11451 Summary: Hold Delete method needs standardization Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently in circulation.pl or moremember.pl, to delete a hold, you must select yes from dropdown fields, and then click the button. I don't recall Koha using this behavior anywhere else. If it does, then my mistake. What would be preferred, in order to be more consistent with the rest of Koha, is that you have check boxes, like most other places, and the button would delete what is checked. However, it should also include a confirmation screen or dialog. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 01:17:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 00:17:27 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- I'm making an exception from normal QA policy and pushing this directly to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 01:17:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 00:17:39 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 01:27:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 00:27:45 +0000 Subject: [Koha-bugs] [Bug 11419] z39.50 searches not displaying errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11419 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 01:39:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 00:39:41 +0000 Subject: [Koha-bugs] [Bug 8018] New subfields have a default max length of zero In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8018 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- Pushed to master. Thanks Pablo and Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 01:46:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 00:46:20 +0000 Subject: [Koha-bugs] [Bug 10140] add UNIMARC tests to t/db_dependent/Record/Record.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10140 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #1 from Chris Cormack --- Hmm did you forget to attach the patch mason? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 01:54:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 00:54:15 +0000 Subject: [Koha-bugs] [Bug 11100] Label in staff client - Topics on facets not easily css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11100 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz, | |gmcharlt at gmail.com Component|Test Suite |Staff Client Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 01:55:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 00:55:30 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #25 from Chris Cormack --- (In reply to M. de Rooy from comment #24) > (In reply to M. de Rooy from comment #23) > > 1) No unit tests. Adding these makes the chance of a push considerably > > larger :) > > Reading back, I happen to notice that there seem to be tests under another > report. Sorry for that.. Bug 10895 to be exact -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 02:04:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 01:04:07 +0000 Subject: [Koha-bugs] [Bug 10806] The staff benchmark script does not check authentication failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10806 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris at bigballofwax.co.nz Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 02:05:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 01:05:05 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |chris at bigballofwax.co.nz Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 02:05:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 01:05:07 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Bug 8304 depends on bug 10298, which changed state. Bug 10298 Summary: t::lib::Mocks tries to deal with syspref but doesn not manage to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 02:05:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 01:05:09 +0000 Subject: [Koha-bugs] [Bug 10337] UT: The unit tests cannot be launched by everyone In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337 Bug 10337 depends on bug 10298, which changed state. Bug 10298 Summary: t::lib::Mocks tries to deal with syspref but doesn not manage to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 02:05:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 01:05:09 +0000 Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843 Bug 10843 depends on bug 10298, which changed state. Bug 10298 Summary: t::lib::Mocks tries to deal with syspref but doesn not manage to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 02:09:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 01:09:00 +0000 Subject: [Koha-bugs] [Bug 10547] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10547 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED CC| |chris at bigballofwax.co.nz Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 02:09:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 01:09:03 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Bug 10545 depends on bug 10547, which changed state. Bug 10547 Summary: additional test for git bz http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10547 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 02:09:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 01:09:20 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED CC| |chris at bigballofwax.co.nz Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 02:09:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 01:09:54 +0000 Subject: [Koha-bugs] [Bug 10546] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10546 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED CC| |chris at bigballofwax.co.nz Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 02:09:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 01:09:55 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Bug 10545 depends on bug 10546, which changed state. Bug 10546 Summary: additional test for git bz http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10546 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 02:12:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 01:12:25 +0000 Subject: [Koha-bugs] [Bug 10337] UT: The unit tests cannot be launched by everyone In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- I like this idea, it might be nicer to rework it to use the new schema rather than kohastructure.sql now though. That way we could test deploying the schema also. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 03:39:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 02:39:24 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t ./xt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #3 from Chris Cormack --- Mark, you need to do a make clean, or get rid of the blib dir at least. Then try running the tests again. prove xt/ runs quietly for me. t/ is a bit louder but nowhere near as loud as it will be when you have BLIB lying around -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 04:06:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 03:06:24 +0000 Subject: [Koha-bugs] [Bug 11452] New: Add some tests for Koha::Template::Plugin::Cache Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11452 Bug ID: 11452 Summary: Add some tests for Koha::Template::Plugin::Cache Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: chris at bigballofwax.co.nz QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 04:09:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 03:09:25 +0000 Subject: [Koha-bugs] [Bug 11452] Add some tests for Koha::Template::Plugin::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11452 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 04:09:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 03:09:32 +0000 Subject: [Koha-bugs] [Bug 11452] Add some tests for Koha::Template::Plugin::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11452 --- Comment #1 from Chris Cormack --- Created attachment 23824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23824&action=edit Bug 11452 Add unit tests for Koha::Template::Plugin::Cache To test run prove t/Koha_Template_Plugin_Cache.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 04:43:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 03:43:09 +0000 Subject: [Koha-bugs] [Bug 11453] New: Update EN default UNIMARC bibliographic framework Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 Bug ID: 11453 Summary: Update EN default UNIMARC bibliographic framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org English default UNIMARC bibliographic framework need to be updated. UNIMARC manual (2008) http://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf Updates (2012) http://www.ifla.org/node/7974 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 04:44:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 03:44:44 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 05:00:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 04:00:28 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 23825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23825&action=edit Bug 11453 - Update EN default UNIMARC bibliographic framework This patch updates default EN UNIMARC bibliographic framework I used the 2008 version of the UNIMARC bibliographic manual, and added updates listed on official site. There are new fields/subfields, those added are hidden by default. There are some description changes, and also a lot of changes to repeatable and mandatory values. To test: a) Functional 1) Remove all bibliographic frameworks 2) Load new file unimarc_framework_DEFAULT.sql 3) Check that it load without errors b) Correctness 1) Take a time and verify that all new fields/subfileds are correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 05:12:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 04:12:31 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 07:21:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 06:21:18 +0000 Subject: [Koha-bugs] [Bug 7965] Silence warns in staff error log (koha-error_log) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7965 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 07:21:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 06:21:28 +0000 Subject: [Koha-bugs] [Bug 7965] Silence warns in staff error log (koha-error_log) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7965 --- Comment #1 from Chris Cormack --- Created attachment 23826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23826&action=edit Bug 7965 : Silence warns in staff log Silence warns in C4::Bookseller to test 1/ run prove t/db_dependent/Bookseller.t Notice lots of Use of uninitialized value $delay in numeric lt (<) at /var/lib/jenkins/jobs/Koha_master/workspace/C4/Bookseller.pm line 134 type lines 2/ apply patch 3/ run prove t/db_dependent/Bookseller.t Notice warns are gone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 07:37:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 06:37:22 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #1 from Chris Cormack --- Jared, do you mean you can't use the value on modify item/add item screen? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 07:52:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 06:52:20 +0000 Subject: [Koha-bugs] [Bug 7050] Error in French web installer - sample_labels.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7050 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #2 from Katrin Fischer --- Tested this again this morning on master, problem still exists: sample_labels.sql ERROR 1146 (42S02) at line 3: Table 'kohaU.labels_templates' doesn't exist -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 07:57:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 06:57:01 +0000 Subject: [Koha-bugs] [Bug 10138] Add some authorized values in french installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 --- Comment #8 from Katrin Fischer --- Created attachment 23827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23827&action=edit [PASSED QA] Bug 10138: Add some authorized values in french installer ; small fixes in frameworks This patch adds some categories of values in french installer : - SUGGEST - OPAC_SUG - REPORT_GROUP - LOST - DAMAGED SUGGEST and OPAC_SUG are used by Suggestions module. REPORT_GROUP is used by Reports module. It also adds a new status for "ETAT" (en commande) It creates a 995$2 subfield in french frameworks when it did not exist. It links existing 995$2 subfield with LOST category. It cleans up the list of authorised values installed with "Lecture publique" framework : - some codes are moved in general 1-Obligatoire/authorised_values.sql (SUGGEST, REPORT_GROUP) - some are suppressed, because they are also defined in 1-Obligatoire/authorised_values.sql (langue, COUNTRY, statut) - the code for interting the left ones is changed (I suppress the `id` column) To test : 1. Take a fresh new Koha 2. Install Koha choosing French installer and UNIMARC Lecture publique 3. Check the authorised values are imported 4. Check the cataloguing frameworks are usable : especially 995 $2 field, which must be mapped with LOST values : Perdu, Long retard, Perdu et rembours?, Introuvable you can also check 101$a (language codes), 102$a (country codes) 5. In OPAC, make a suggestion. See if you can select a cause for your suggestion ("Bestseller" or "'L'exemplaire en rayon est endommag?") 6. In staff interface, manage some suggestions. See if you can select a cause for rejection or acceptation ("Bestseller", "Budget insuffisant" etc) 7. In reports, see if you can sort reports according to values of REPORT_GROUP ("Circulation", "Catalogue", "Adh?rents" etc) Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Comments on second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 07:57:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 06:57:33 +0000 Subject: [Koha-bugs] [Bug 10138] Add some authorized values in french installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 --- Comment #9 from Katrin Fischer --- Created attachment 23828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23828&action=edit [PASSED QA] Bug 10138: FIX sql errors There were 2 INSERT in error. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer I have gone ahead and fixed the typo pointed out by Mathieu: Endommadg?-> Endommag? Sample files install without problems, tests look good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 07:58:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 06:58:10 +0000 Subject: [Koha-bugs] [Bug 10138] Add some authorized values in french installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 07:58:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 06:58:17 +0000 Subject: [Koha-bugs] [Bug 10138] Add some authorized values in french installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23800|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 07:58:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 06:58:24 +0000 Subject: [Koha-bugs] [Bug 10138] Add some authorized values in french installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23799|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 08:35:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 07:35:36 +0000 Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in french unimarc_complet default Framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Id like to sign off on this, but know nothing about UNIMARC, can a UNIMARC user please look at this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 08:37:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 07:37:55 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hi Kyle, found a small bug: + 'DisplayLibraryFacets', 'holdingbranch', 'home|holding|both', 'Defines which library facets to display.', 'Choice' You are setting the default to an invalid value in sysprefs.sql and updatedatabaes. Can you please provide a follow up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 08:41:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 07:41:42 +0000 Subject: [Koha-bugs] [Bug 11192] Fix two definitions in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11192 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 08:41:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 07:41:51 +0000 Subject: [Koha-bugs] [Bug 11192] Fix two definitions in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11192 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22674|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 23829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23829&action=edit Bug 11192 : Fix lf and ff07-02 definition in ccl.properties ff7-02 1=87020 (position 2 of field 007 in MARC21) should be ff7-02 1=8702 lf 1=8833 lf fiction fic fiction should be lf 1=8833 fiction lf fic lf To test : 1. apply the patch 2. copy the modified ccl.properties into your active Zebra config directory 3. reindex zebra (rebuild_zebra.pl -b -x -r -v) 4. make some searches using the fixed indexes Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 09:24:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 08:24:40 +0000 Subject: [Koha-bugs] [Bug 10954] Payment receipt does not display the payment made In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- *** Bug 11408 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 09:24:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 08:24:40 +0000 Subject: [Koha-bugs] [Bug 11408] Payment slip misses information about amount paid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11408 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10954 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 14:46:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 13:46:06 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 --- Comment #2 from Jared Camins-Esakov --- I tested authorized values on the item editing screen. I just did a bit more testing, and it looks like the problem might actually be with caching on the item editing screen and not the administration screen as I had thought. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 15:49:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 14:49:38 +0000 Subject: [Koha-bugs] [Bug 10138] Add some authorized values in french installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 15:58:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 14:58:51 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23579|0 |1 is obsolete| | --- Comment #46 from mathieu saby --- Created attachment 23830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23830&action=edit [PATCH] Bug 11202 - Improve UNIMARC biblio indexing Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 16:31:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 15:31:57 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #23 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 16:32:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 15:32:32 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23787|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 16:32:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 15:32:42 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #24 from sandboxes at biblibre.com --- Created attachment 23831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23831&action=edit Bug 11336: Priority is not updated on deleting holds There are a lot of places where a hold deletion is possible. But I just found 1 place where it works! To reproduce: - select or create 2 users U1 and U2 - select or create an holdable item - place on hold for both U1 and U2. U1 has priority 1 and U2 has priority 2. - delete the hold for U1 - go on circ/circulation.pl?borrowernumber=XXXX for U2 (or in the DB directly) and verify the priority has not been set to 1 The issue is repeatable (at least) on these 2 pages: * circ/circulation.pl?borrowernumber=XXXX (tab 'Holds', select "yes" in the dropdown list and submit the form) * reserve/request.pl?biblionumber=XXXX (clic on the red cross) Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 16:33:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 15:33:32 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #25 from Christopher Brannon --- Works as defined. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 17:30:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 16:30:50 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #6 from Christopher Brannon --- Forgive me, I am not sure what the protocol is here. Not sure if I should change the status to discussion. I've tested the patch, and it does what is described, however, this condition does exist in other places throughout Koha. request.pl opac-reserve.pl opac-memberentry.pl And I am sure there are other places I didn't think of. It seems to me we should comb through Koha and address all the date fields, and not just one. Am I incorrect on this matter? Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 17:34:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 16:34:13 +0000 Subject: [Koha-bugs] [Bug 11454] New: Cannot indicate time on Circulation Rules Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11454 Bug ID: 11454 Summary: Cannot indicate time on Circulation Rules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It seems that one should be able to also include a time on the hard due date in smart-rules.pl. Currently you can only enter a date. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 17:37:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 16:37:07 +0000 Subject: [Koha-bugs] [Bug 11455] New: Rule Replacement Confirmation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11455 Bug ID: 11455 Summary: Rule Replacement Confirmation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When creating a rule in smart-rules.pl, there should be a confirmation screen or dialog box confirming that you want a rule replace if the new rule is replacing an existing one. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 17:40:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 16:40:04 +0000 Subject: [Koha-bugs] [Bug 11456] New: Invalid information warnings on rules Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11456 Bug ID: 11456 Summary: Invalid information warnings on rules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There is no mechanism in the smart-rules.pl to indicate that information entered was invalid. The rule is simply created omitting invalid information. For example, if you create a rule and put an invalid date in the hard due date, the rule is created, but the date is omitted. There is no warning that it changed what was entered, or what was changed. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 18:13:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 17:13:28 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |cbrannon at cdalibrary.org --- Comment #5 from Christopher Brannon --- Jonathan, This patch is inconsistent with results. - Set the pref to 2 - try to delete a batch of 3 items This will not show the items, but you can still delete the items. Can anyone confirm if this issue exists with the limit hard coded? I don't have 1001 items to test if going past the hard coded limit would produce the same result. This could be revealing a pre-existing issue. Also, should there be a maximum limit to how much can be processed? It seems to me if you are batch loading 1000 items, and it is displaying all those items, it might cause the entire system to drag. But I am just guessing. And if someone were to set a limit higher than 1000, would that potentially be worse? In theory, it might be a performance issue, but in reality, would there ever be a case where someone would batch process thousands of records and cripple Koha in the process? Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 19:05:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 18:05:54 +0000 Subject: [Koha-bugs] [Bug 11104] Label in opac topics in facets not easily css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11104 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Tim! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 19:47:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 18:47:55 +0000 Subject: [Koha-bugs] [Bug 11101] Item Type label in OPAC not easily css selectable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11101 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Claire! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 19:49:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 18:49:22 +0000 Subject: [Koha-bugs] [Bug 2310] Delete grayed out w/out explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- This patch (display tooltips explaining why patron menu items are disabled) has been pushed to 3.12.x, will be in 3.12.9. Thanks Owen! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 21:06:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 20:06:07 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz --- Comment #29 from Chris Cormack --- Bug 10869 - can't delete order line if title deleted 22300 - [PATCH] Bug 10869: Allow the deletion of order line if the record is deleted 22676 - [PATCH 2/2] Bug 10869 Followup : change DelOrder and adds UT Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10869: Allow the deletion of order line if the record is deleted Applying: Bug 10869 Followup : change DelOrder and adds UT fatal: sha1 information is lacking or useless (C4/Acquisition.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10869 Followup : change DelOrder and adds UT The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/PATCH-22-Bug-10869-Followup--change-DelOrder-and-a-dbVEZx.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 21:08:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 20:08:12 +0000 Subject: [Koha-bugs] [Bug 11192] Fix two definitions in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11192 --- Comment #3 from Chris Cormack --- Created attachment 23832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23832&action=edit Bug 11192: Follow up, fixing a little typo Test plan the same as the original patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 21:10:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 20:10:13 +0000 Subject: [Koha-bugs] [Bug 11452] Add some tests for Koha::Template::Plugin::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 21:10:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 20:10:23 +0000 Subject: [Koha-bugs] [Bug 11452] Add some tests for Koha::Template::Plugin::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23824|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 23833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23833&action=edit [SIGNED OFF] Bug 11452 Add unit tests for Koha::Template::Plugin::Cache To test run prove t/Koha_Template_Plugin_Cache.t Signed-off-by: Katrin Fischer Works nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 21:13:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 20:13:18 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Chris Cormack --- This patch set adds a new syspref, which disables session restrict by IP, by default. Which is dangerous, this should be a conscious decision made by someone knowing that they are reducing security. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 21:45:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 20:45:50 +0000 Subject: [Koha-bugs] [Bug 11192] Fix two definitions in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11192 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 21:45:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 20:45:55 +0000 Subject: [Koha-bugs] [Bug 11192] Fix two definitions in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11192 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23829|0 |1 is obsolete| | Attachment #23832|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 23834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23834&action=edit [PASSED QA] Bug 11192 : Fix lf and ff07-02 definition in ccl.properties ff7-02 1=87020 (position 2 of field 007 in MARC21) should be ff7-02 1=8702 lf 1=8833 lf fiction fic fiction should be lf 1=8833 fiction lf fic lf To test : 1. apply the patch 2. copy the modified ccl.properties into your active Zebra config directory 3. reindex zebra (rebuild_zebra.pl -b -x -r -v) 4. make some searches using the fixed indexes Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 21:46:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 20:46:29 +0000 Subject: [Koha-bugs] [Bug 11192] Fix two definitions in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11192 --- Comment #5 from Katrin Fischer --- Created attachment 23835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23835&action=edit [PASSED QA] Bug 11192: Follow up, fixing a little typo Test plan the same as the original patch Signed-off-by: Katrin Fischer Tested according to test plan. Searches tested were: fic=e fiction=e -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 21:52:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 20:52:11 +0000 Subject: [Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 21:52:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 20:52:17 +0000 Subject: [Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22751|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 23836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23836&action=edit Bug 11208: If no smsalertnumber is defined, the message is marked as failed For DUE message (and PREDUE, etc.) there are no check before sending the message to the message_queue table. This check avoids to try to send again and again the same message. Now it is marked as "failed". Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 22:27:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 21:27:45 +0000 Subject: [Koha-bugs] [Bug 11066] Export Citations not RDA compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11066 --- Comment #3 from Katrin Fischer --- Created attachment 23837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23837&action=edit [SIGNED OFF] Bug 11066: RIS and Bibtex Exports RDA compatible RIS and Bibtex exports from staff side and OPAC edited to allow for additional publisher RDA tag (264). Script will look first for 264 then fallback to 260 when pulling publisher data from marc21 record. Test Plan: 1. Create RDA and non RDA record 2. In OPAC, export both as RIS and Bibtex - verify publisher information is exported 3. On staff side, export records as RIS and Bibtex, verify publisher information is exported. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Fixed some tabs pointed out by the QA script. Works nicely in my tests, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 22:28:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 21:28:33 +0000 Subject: [Koha-bugs] [Bug 11066] Export Citations not RDA compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11066 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 22:28:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 21:28:42 +0000 Subject: [Koha-bugs] [Bug 11066] Export Citations not RDA compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11066 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23795|0 |1 is obsolete| | Attachment #23837|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 23838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23838&action=edit [PASSED QA] Bug 11066: RIS and Bibtex Exports RDA compatible RIS and Bibtex exports from staff side and OPAC edited to allow for additional publisher RDA tag (264). Script will look first for 264 then fallback to 260 when pulling publisher data from marc21 record. Test Plan: 1. Create RDA and non RDA record 2. In OPAC, export both as RIS and Bibtex - verify publisher information is exported 3. On staff side, export records as RIS and Bibtex, verify publisher information is exported. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Fixed some tabs pointed out by the QA script. Works nicely in my tests, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 27 23:10:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 22:10:39 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- I like this idea, but I think we want to display the time in some cases - like for the due date in case of a hourly loan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 28 00:22:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 23:22:31 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #2 from mathieu saby --- Hello Not sure of that, but I see that you added a 852 field. We don't use it in France, but I suppose it is made for storing information about items, which are stored in 995 in UNIMARC Koha. I unterstand it is part of the IFLA standard, but don't you think this could be source of mistakes ? I'm not sure of the best way of dealing with that: maybe not creating 852 field in a fist time? or adding a comment in the fied name to prevent mistakes? And maybe on a long run, we could envision to move items from 995 to 852 ?? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 28 00:27:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Dec 2013 23:27:21 +0000 Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 --- Comment #5 from mathieu saby --- What about renaming "gist" preference? For a french speaking person, it means nothing at all. "AcceptedTaxRates" would be easier to understand Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 28 01:07:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Dec 2013 00:07:43 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 --- Comment #3 from Bernardo Gonzalez Kriegel --- (In reply to mathieu saby from comment #2) > Hello Hi Mathieu and thanks for taking a look > Not sure of that, but I see that you added a 852 field. We don't use it in > France, but I suppose it is made for storing information about items, which > are stored in 995 in UNIMARC Koha. For what I can see UNIMARC 852 is very similar to MARC21 852 (http://www.loc.gov/marc/bibliographic/concise/bd852.html) That is not used on MARC21 Koha, we use 952 instead. > I unterstand it is part of the IFLA standard, but don't you think this could > be source of mistakes ? I'm not sure of the best way of dealing with that: > maybe not creating 852 field in a fist time? or adding a comment in the fied > name to prevent mistakes? > And maybe on a long run, we could envision to move items from 995 to 852 ?? > On MARC21 framework it's hidden so is not a problem, may be the same could be done on UNIMARC. And all new fields are hidden by default. If you load the framework the only visible field is 856 Bernardo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 28 01:11:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Dec 2013 00:11:21 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22676|0 |1 is obsolete| | --- Comment #30 from mathieu saby --- Created attachment 23839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23839&action=edit [PATCH 2/2] Bug 10869 Followup : change DelOrder and adds UT rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 28 01:11:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Dec 2013 00:11:33 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 28 05:37:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Dec 2013 04:37:45 +0000 Subject: [Koha-bugs] [Bug 11131] Authority search does not display summary while searching by all auth types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 28 05:37:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Dec 2013 04:37:52 +0000 Subject: [Koha-bugs] [Bug 11131] Authority search does not display summary while searching by all auth types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22358|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 23840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23840&action=edit Bug 11131: Authority search does not display summary while searching by all auth types The summary is built using the authtypecode selected from the interface. So when a search is launch on all auth types, the summary is not correctly built by the BuildSummary routine. It should get the authtypecode from the authority (call to GetAuthTypeCode). To test: 1/ go to authorities/authorities-home.pl 2/ search by authtype personal name 3/ results are displayed with summary 4/ now select the default entry and search again the results display but without the summary 5/ apply the patch 6/ search default again, now summary shows Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 28 05:42:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Dec 2013 04:42:03 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables in acqusitions do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #3 from Chris Cormack --- How does this work for other languages, die der das etc? Or is it english only? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 28 08:55:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Dec 2013 07:55:12 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables in acqusitions do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hm, there is http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc;h=703d1e3e9637aad3923e2ab2fbe557c2b55869db;hb=e81513199cba41a254820347442719a6fd50ec0b which includes a line with the articles that is translatable. I am not sure if that is what gets used with 'anti-the', but it might. Even better than a translatable line would be making this a system preference, so you can change it anytime without having to update the po files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 28 09:54:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Dec 2013 08:54:16 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #22 from Katrin Fischer --- I am stumbling over this bug report again and again, wondering what it is about as the subject is not really telling much. After reading the comments I think this would have been a bit better as 2 separate bug reports, one for the CSV and one for the HTML output change. I agree with Jonathan about the change to the itemscontent default as this would be an unexpected change for a lot of libraries. Also itemnumber and branchname are not useful for a lot of libraries. -my $itemscontent = join( ',', qw( date_due title barcode author itemnumber ) ); +my $itemscontent = join( ',', qw( itemnumber issuedate date_due title barcode author itemcallnumber branchname ) ); It looks like this is hiding a 3rd feature even: +SELECT biblio.*, items.*, issues.*, biblioitems.itemtype, TO_DAYS($date)-TO_DAYS(date_due) AS days_overdue, branchname + FROM issues,items,biblio, biblioitems, branches b Making ist possible to put the branchname instead of the branchcode into the output of items? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 28 15:51:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Dec 2013 14:51:42 +0000 Subject: [Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 28 15:51:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Dec 2013 14:51:47 +0000 Subject: [Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23836|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 23841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23841&action=edit [PASSED QA] Bug 11208: If no smsalertnumber is defined, the message is marked as failed For DUE message (and PREDUE, etc.) there are no check before sending the message to the message_queue table. This check avoids to try to send again and again the same message. Now it is marked as "failed". Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Without the patch a sms notice will remain as 'pending' forever. With the patch applied, the status is set to 'failed'. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 03:36:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 02:36:07 +0000 Subject: [Koha-bugs] [Bug 11404] add out-of-the-box support for Apache 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 03:40:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 02:40:20 +0000 Subject: [Koha-bugs] [Bug 11445] it is possible for duplicate hold notifications to be sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11445 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 03:40:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 02:40:26 +0000 Subject: [Koha-bugs] [Bug 11445] it is possible for duplicate hold notifications to be sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11445 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23811|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 23842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23842&action=edit Bug 11445: regression test for duplicate hold notifications This patch implements a regression test for verifying that duplicate hold notifications aren't sent if ModReserveAffect() is called repeatedly (as might happen if a circ operator accidentally checks in an item and confirms its hold more than once). Note that the test depends on the fact that _koha_notify_reserve() defaults to sending a HOLD_PRINT letter if the borrower has not specified an email or SMS hold notification. To test: [1] Run prove -v t/db_dependent/Reserves.t [2] The 'patron not notified a second time (bug 11445)' test should fail. [3] Apply the main patch and run prove -v t/db_dependent/Reserves.t again. This time all tests should pass. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 03:40:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 02:40:41 +0000 Subject: [Koha-bugs] [Bug 11445] it is possible for duplicate hold notifications to be sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11445 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23812|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 23843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23843&action=edit Bug 11445: avoid sending duplicate hold waiting notifications This patch fixes a problem where a patron could receive duplicate hold waiting notifications. For example, this could happen if a circ operator checked in an item more than once and confirmed the same hold each time. To test: [1] Set up a test patron that received hold waiting notifications. [2] Put an item on hold for the patron, then check the item in and confirm the hold. Verify that a hold notification is sent (or inspect the message_queue table). [3] Check the item in again and confirm the hold again. A duplicate hold notification will be generated. [4] Apply the patch. [5] Repeat steps 2 and 3. This time, only one notification should be generated. [6] Verify that prove -v t/db_dependent/Reserves.t passes. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 04:08:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 03:08:21 +0000 Subject: [Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22946|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 23844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23844&action=edit Bug 11243: Supplier list should distinct canceled items On the supplier result list, the "Item count" columns contain the sum of all items ordered for a basket. But if an order is canceled, the item count is not really meaningful. This patch just adds, in parenthesis, the number of items canceled. Test plan: - create a basket and 3 orders with different number of items - cancel 1 order - verify on the supplier list that the number of items is correct and the number of canceled items is correct too. Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 04:08:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 03:08:41 +0000 Subject: [Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23050|0 |1 is obsolete| | --- Comment #9 from Chris Cormack --- Created attachment 23845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23845&action=edit Bug 11243: Display count of items and biblios cancelled Same as previous patch but for the biblios count. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 04:09:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 03:09:00 +0000 Subject: [Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23051|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 23846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23846&action=edit Bug 11243: UT: unit tests for GetBasketsInfosByBookseller Verify prove t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t returns green. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 04:10:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 03:10:38 +0000 Subject: [Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 06:08:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 05:08:57 +0000 Subject: [Koha-bugs] [Bug 11403] renew page missing help file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11403 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 06:09:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 05:09:07 +0000 Subject: [Koha-bugs] [Bug 11403] renew page missing help file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11403 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23578|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 23847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23847&action=edit Bug 11403: Add missing help file to new Renew page This patch adds a help file to the Renew page found under Circulation. To test: * Go to Circulation > Renew * Click the help link * Confirm text and manual link are correct. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 06:10:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 05:10:57 +0000 Subject: [Koha-bugs] [Bug 11402] Labels::_guide_box should return undef if undefned data is passed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 06:11:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 05:11:04 +0000 Subject: [Koha-bugs] [Bug 11402] Labels::_guide_box should return undef if undefned data is passed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23577|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 23848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23848&action=edit Bug 11402: Labels::_guide_box should return undef if undefned data is passed That's it. A guide box cannot be created if invalid data is passed. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 07:01:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 06:01:46 +0000 Subject: [Koha-bugs] [Bug 11188] Make gather_print_notices.pl die on failed open() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11188 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 07:01:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 06:01:52 +0000 Subject: [Koha-bugs] [Bug 11188] Make gather_print_notices.pl die on failed open() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11188 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23181|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 23849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23849&action=edit Bug 11188 - Make gather_print_notices.pl die on failed open() Problem: If you tell gather_print_notices.pl to write output to a location you do not have write access to, it will silently fail to write the data, but still mark unsent messages as sent. Solution: This patch adds two lines of defense: 1. Check that the location given for the output is writable 2. use "open() or die" instead of just "open()" when writing the output The first measure should catch most of the potential errors, but I guess a directory can be writable, but the open() still can fail because the disk is full or something similar. To test: - Make sure you have some unsent messages in the message_queue table, that do not have an email adress - Apply the patch - Run the script, pointing at a location you do not have access to write to. Check that the script exits with an appropriate error message, and that the unsent messages are still unsent. Do this both with and without the -s option. - To fake passing the first line of defence, comment out line 62 and put this in instead: if ( !$output_directory || !-d $output_directory ) { - Run the script again as above, check you get an appropriate error and that the message queue is not touched - Reset line 62 to how it was - Run the script against a directory you do have access to write to and check that output is produced as expected and that messages are marked as sent - Sign off Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 08:41:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 07:41:55 +0000 Subject: [Koha-bugs] [Bug 11075] Clicking 'select all' link in export tab in checkout page clears renew checkboxes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11075 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 08:42:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 07:42:04 +0000 Subject: [Koha-bugs] [Bug 11075] Clicking 'select all' link in export tab in checkout page clears renew checkboxes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11075 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23070|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 23850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23850&action=edit Bug 11075 - 'select all' export clears renew checkboxes If circulation exports are enabled (by turning on ExportWithCsvProfile), the table on the checkout page includes three columns of checkboxes -- 'renew', 'checkin', and 'export'. For each loan, the renew and checkout links should behave like radio buttons, but the state of the export checkbox is meant to be independent of the renew and checkin checkboxes. However, if the 'select all' link in the export column is clicked, active renew checkboxes are toggled off. The desired behavior is that clicking the select all link in the export column should only affect checkboxes in that column. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 08:50:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 07:50:08 +0000 Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 08:50:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 07:50:17 +0000 Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23315|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 23851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23851&action=edit Bug 8921: koha-common*.deb should depend on cron Trivial patch to add 'cron-daemon' as dependency for the koha-common package. 'cron' is usually pulled in any minimal Ubuntu/Debian install, but in some circumstances (using debootstrap) it might be absent. As Robin said, this doesn't seem to have any side effects. Regards To+ Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 08:58:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 07:58:16 +0000 Subject: [Koha-bugs] [Bug 11445] it is possible for duplicate hold notifications to be sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11445 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 08:58:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 07:58:22 +0000 Subject: [Koha-bugs] [Bug 11445] it is possible for duplicate hold notifications to be sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11445 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23842|0 |1 is obsolete| | Attachment #23843|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 23852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23852&action=edit [PASSED QA] Bug 11445: regression test for duplicate hold notifications This patch implements a regression test for verifying that duplicate hold notifications aren't sent if ModReserveAffect() is called repeatedly (as might happen if a circ operator accidentally checks in an item and confirms its hold more than once). Note that the test depends on the fact that _koha_notify_reserve() defaults to sending a HOLD_PRINT letter if the borrower has not specified an email or SMS hold notification. To test: [1] Run prove -v t/db_dependent/Reserves.t [2] The 'patron not notified a second time (bug 11445)' test should fail. [3] Apply the main patch and run prove -v t/db_dependent/Reserves.t again. This time all tests should pass. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 08:58:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 07:58:39 +0000 Subject: [Koha-bugs] [Bug 11445] it is possible for duplicate hold notifications to be sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11445 --- Comment #6 from Katrin Fischer --- Created attachment 23853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23853&action=edit [PASSED QA] Bug 11445: avoid sending duplicate hold waiting notifications This patch fixes a problem where a patron could receive duplicate hold waiting notifications. For example, this could happen if a circ operator checked in an item more than once and confirmed the same hold each time. To test: [1] Set up a test patron that received hold waiting notifications. [2] Put an item on hold for the patron, then check the item in and confirm the hold. Verify that a hold notification is sent (or inspect the message_queue table). [3] Check the item in again and confirm the hold again. A duplicate hold notification will be generated. [4] Apply the patch. [5] Repeat steps 2 and 3. This time, only one notification should be generated. [6] Verify that prove -v t/db_dependent/Reserves.t passes. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes all tests and QA script. Works as described. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 09:02:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 08:02:13 +0000 Subject: [Koha-bugs] [Bug 11403] renew page missing help file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11403 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 09:02:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 08:02:19 +0000 Subject: [Koha-bugs] [Bug 11403] renew page missing help file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11403 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23847|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 23854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23854&action=edit [PASSED QA] Bug 11403: Add missing help file to new Renew page This patch adds a help file to the Renew page found under Circulation. To test: * Go to Circulation > Renew * Click the help link * Confirm text and manual link are correct. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 09:15:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 08:15:16 +0000 Subject: [Koha-bugs] [Bug 11188] Make gather_print_notices.pl die on failed open() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11188 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 09:15:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 08:15:22 +0000 Subject: [Koha-bugs] [Bug 11188] Make gather_print_notices.pl die on failed open() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11188 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23849|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 23855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23855&action=edit [PASSED QA] Bug 11188 - Make gather_print_notices.pl die on failed open() Problem: If you tell gather_print_notices.pl to write output to a location you do not have write access to, it will silently fail to write the data, but still mark unsent messages as sent. Solution: This patch adds two lines of defense: 1. Check that the location given for the output is writable 2. use "open() or die" instead of just "open()" when writing the output The first measure should catch most of the potential errors, but I guess a directory can be writable, but the open() still can fail because the disk is full or something similar. To test: - Make sure you have some unsent messages in the message_queue table, that do not have an email adress - Apply the patch - Run the script, pointing at a location you do not have access to write to. Check that the script exits with an appropriate error message, and that the unsent messages are still unsent. Do this both with and without the -s option. - To fake passing the first line of defence, comment out line 62 and put this in instead: if ( !$output_directory || !-d $output_directory ) { - Run the script again as above, check you get an appropriate error and that the message queue is not touched - Reset line 62 to how it was - Run the script against a directory you do have access to write to and check that output is produced as expected and that messages are marked as sent - Sign off Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes all tests and QA script. Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 09:21:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 08:21:54 +0000 Subject: [Koha-bugs] [Bug 11075] Clicking 'select all' link in export tab in checkout page clears renew checkboxes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11075 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 09:22:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 08:22:00 +0000 Subject: [Koha-bugs] [Bug 11075] Clicking 'select all' link in export tab in checkout page clears renew checkboxes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11075 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23850|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 23856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23856&action=edit [PASSED QA] Bug 11075 - 'select all' export clears renew checkboxes If circulation exports are enabled (by turning on ExportWithCsvProfile), the table on the checkout page includes three columns of checkboxes -- 'renew', 'checkin', and 'export'. For each loan, the renew and checkout links should behave like radio buttons, but the state of the export checkbox is meant to be independent of the renew and checkin checkboxes. However, if the 'select all' link in the export column is clicked, active renew checkboxes are toggled off. The desired behavior is that clicking the select all link in the export column should only affect checkboxes in that column. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes all tests and QA script - one line JavaScript change. Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 09:26:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 08:26:18 +0000 Subject: [Koha-bugs] [Bug 11402] Labels::_guide_box should return undef if undefned data is passed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 09:26:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 08:26:23 +0000 Subject: [Koha-bugs] [Bug 11402] Labels::_guide_box should return undef if undefned data is passed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23848|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 23857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23857&action=edit [PASSED QA] Bug 11402: Labels::_guide_box should return undef if undefned data is passed That's it. A guide box cannot be created if invalid data is passed. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes all tests and QA script, includes new unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 09:54:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 08:54:41 +0000 Subject: [Koha-bugs] [Bug 11131] Authority search does not display summary while searching by all auth types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 09:54:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 08:54:47 +0000 Subject: [Koha-bugs] [Bug 11131] Authority search does not display summary while searching by all auth types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23840|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 23858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23858&action=edit [PASSED QA] Bug 11131: Authority search does not display summary while searching by all auth types The summary is built using the authtypecode selected from the interface. So when a search is launch on all auth types, the summary is not correctly built by the BuildSummary routine. It should get the authtypecode from the authority (call to GetAuthTypeCode). To test: 1/ go to authorities/authorities-home.pl 2/ search by authtype personal name 3/ results are displayed with summary 4/ now select the default entry and search again the results display but without the summary 5/ apply the patch 6/ search default again, now summary shows Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Tested with a UNIMARC database, works as described. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 10:09:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 09:09:38 +0000 Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 10:09:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 09:09:44 +0000 Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23851|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 23859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23859&action=edit [PASSED QA] Bug 8921: koha-common*.deb should depend on cron Trivial patch to add 'cron-daemon' as dependency for the koha-common package. 'cron' is usually pulled in any minimal Ubuntu/Debian install, but in some circumstances (using debootstrap) it might be absent. As Robin said, this doesn't seem to have any side effects. Regards To+ Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer No entry in debian/control yet, but according to comments in the file this file is generated from control.in - so this should be ok. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 11:13:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 10:13:24 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 11:13:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 10:13:32 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23523|0 |1 is obsolete| | Attachment #23635|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer --- Created attachment 23860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23860&action=edit [PASSED QA] Bug 10277 - Add C4::Context->IsSuperLibrarian() The method of checking the logged in user for superlibrarian privileges is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least. The codebase is littered with these lines, with no explanation given. It would be much better if we had one subroutine that returned a boolean value to tell us if the logged in user is a superlibrarian or not. Test Plan: 1) Apply this patch 2) Verify superlibrarian behavior remains unchanged Signed-off-by: Joel Sasse Signed-off-by: Katrin Fischer Comments on second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 11:14:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 10:14:03 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 --- Comment #34 from Katrin Fischer --- Created attachment 23861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23861&action=edit [PASSED QA] Bug 10277: Add UT for C4::Context::IsSuperLibrarian Note that I modify the return value. Before this patch, it returned an empty string or 1. Now it returns 0 or 1. Test plan: - same as the original patch - verify that unit tests pass: prove t/Context.t Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests and QA script, including new tests. Checked the code and tested superlibrarian behaviour in some places: moremember.pl: With IndyBranches only superlibrarian can delete borrowers from other branches. Accessing the borrower with a direct link. OK C4/Members.pm With IndyBranches only superlibrarian can search for borrowres from other branches. OK tools/holidays.pl With IndyBranches only superlibrarian can edit holidays for other branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 11:29:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 10:29:11 +0000 Subject: [Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- Hi Jonathan, I retested this and think I spotted a problem: Order: 2 orders Cancel one order, delete bibliographic record Item cound is correct, but biblio count doesn't show the cancelled biblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 11:51:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 10:51:53 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #36 from Katrin Fischer --- Comment on attachment 23526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23526 Bug 9303 [1/2] - relative's checkouts in the opac - Schema Updates Review of attachment 23526: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9303&attachment=23526) ----------------------------------------------------------------- Hi Kyle, starting with a code review: ::: Koha/Schema/Result/Borrower.pm @@ -191,4 @@ > =head2 dateofbirth > > data_type: 'date' > - datetime_undef_if_invalid: 1 Can you explain why those lines have been removed by your patch? I know that those files are generated automatically, but I have difficulty to see how those changes are related to the canges done in kohastructure.sql. @@ +1020,2 @@ > > +# Created by DBIx::Class::Schema::Loader v0.07000 @ 2013-11-07 08:15:21 I notice, that your version is a bit older than the one used before, could that explain some of the differences? ::: installer/data/mysql/updatedatabase.pl @@ +7826,5 @@ > > +$DBversion = "3.15.00.XXX"; > +if(CheckVersion($DBversion)) { > + $dbh->do(q{ > + ALTER TABLE borrowers ADD privacy_relative_checkouts BOOLEAN NOT NULL DEFAULT '0' I'd feel a bit better about this line and the next, if there was an AFTER/BEFORE making sure that the sequence of rows is the same for old and new installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 12:08:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 11:08:55 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #37 from Katrin Fischer --- Comment on attachment 23527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23527 Bug 9303 [2/2] - relative's checkouts in the opac Review of attachment 23527: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9303&attachment=23527) ----------------------------------------------------------------- No major findings - mostly noting a few things: I think maybe it would be better to separate the Schema and kohastructure/updatedatabase changes into 2 separate patches. Also adding a new PK to issues and old_issues could have been a separate bug/patch. ::: C4/Reserves.pm @@ +270,5 @@ > + $sth->execute($reserve_id); > + $res = $sth->fetchrow_hashref(); > + } > + > + carp("No hold for for reserve_id $reserve_id") unless $res; Hm, this change seems unrelated to the bug description? ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ +1168,5 @@ > + > + [% END %] > + > +
Allow linked patron accounts to view this patron's checkouts from the OPAC
> + This is different to how we handle the other privacy seetings in that we don't allow staff to change those for a patron. I see why staff will want to change that setting for a parent requesting it, but at the same time it bothers me a bit. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt @@ +1,3 @@ > [% USE Koha %] > [% USE KohaDates %] > +[% USE EncodeUTF8 %] The only script using this so far is renew.pl - can you explain a bit? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 12:18:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 11:18:25 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Katrin Fischer --- Ok, found a major problem: New PK for issues and old_issues: - Sequential numbering done by updatedatabase worked correctly in my test database. - Returning checked out items moves them correctly to old_issues, issue_id is kept. - Checking out a new item after the updates generates an issue_id that was already used in old_issues! In my database, afer update: old_issues - 1-18 issues - 19-20 - returned 19, 20 old_issues 1-20 issues empty - checked out 2 items old_issues 1-20 issues 3,4 Please consider splitting the introduction of a new PK into a separate bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 13:06:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 12:06:50 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #26 from Katrin Fischer --- Working on this now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 13:10:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 12:10:28 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #27 from Katrin Fischer --- Comment on attachment 23831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23831 Bug 11336: Priority is not updated on deleting holds Review of attachment 23831: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11336&attachment=23831) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +252,4 @@ > > $res = GetReserve( $reserve_id ); > > + Return the current reserve or the old reserve. This POD change no longer applies - please fix in a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 14:01:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 13:01:17 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 14:01:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 13:01:25 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23831|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer --- Created attachment 23862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23862&action=edit [PASSED QA] Bug 11336: Priority is not updated on deleting holds There are a lot of places where a hold deletion is possible. But I just found 1 place where it works! To reproduce: - select or create 2 users U1 and U2 - select or create an holdable item - place on hold for both U1 and U2. U1 has priority 1 and U2 has priority 2. - delete the hold for U1 - go on circ/circulation.pl?borrowernumber=XXXX for U2 (or in the DB directly) and verify the priority has not been set to 1 The issue is repeatable (at least) on these 2 pages: * circ/circulation.pl?borrowernumber=XXXX (tab 'Holds', select "yes" in the dropdown list and submit the form) * reserve/request.pl?biblionumber=XXXX (click on the red cross) Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Reran my tests: Preparations: - Create holds for different patrons on a record: * 1st - title level hold * 2nd - item level hold * 3rd - title level hold * 4th - title level hold - AllowOnShelfHolds = On/Allow (items were not checked out) Tests: Deleted holds from various pages, confirming bugs first, then testing with applied patches. Reloading database after each test. 1) Cancel holds from OPAC patron account /cgi-bin/koha/opac-user.pl#opac-user-holds - Cancel 4th - ok, before and after applying the patch - Cancel 2nd - ok, after applying the patch 2) Cancel hold from holds tab on staff detail page /cgi-bin/koha/reserve/request.pl?biblionumber=7 a) Setting priority to 'del', submitting with 'Update holds' - Cancel first (1st) - ok, before and after - Cancel hold in the middle (was 3rd) - ok, before and after - Cancel last (was 4th) -ok, before and after b) Using red X - Repeating tests from a) - before the patch is applied holds get totally 'out of order' - after applying the patch, it works correctly Additional tests done on this page: - Change priority using up, down, to top, to bottom icons - Change priority with 'toggle to lowest' 3) Cancel hold from the patron's account a) Check out tab - Delete? Yes, 'Cancel marked holds' /cgi-bin/koha/circ/circulation.pl?borrowernumber=X - Cancel first (1st) - ok, after applying the patch - Cancel hold in the middle (was 3rd) - ok, after applying the patch - Cancel last (was 4th) - ok, after applying the patch b) Details tab - Delete? yes, 'Cancel marked holds' /cgi-bin/koha/members/moremember.pl?borrowernumber=X - Cancel first (1st) - ok, after applying the patch - Cancel hold in the middle (was 3rd) - ok, after applying the patch - Cancel last (was 4th) - ok, after applying the patch Without the patch, holds priorities get out of order. Additional tests done: - Check in one item to trigger first hold - Check in one item to trigger second hold - Check out first item Priorities are kept while the item is waiting, when it's checked out, priorities of remaining holds get reset correctly. Conclusion: Big improvement, no regressions found. Passes all tests in t, xt and QA script. Also: t/db_dependent/Holds.t t/db_dependent/HoldsQueue.t t/db_dependent/Reserves.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 14:02:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 13:02:14 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #29 from Katrin Fischer --- Created attachment 23863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23863&action=edit Bug 11336: Follow-up - fixing capitalization in templates Fixes capitalization on the holds and check in page. Changes are easy to spot using: git diff HEAD^ --color-words=. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 14:12:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 13:12:38 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 --- Comment #15 from Katrin Fischer --- Ok, giving this another go... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 14:22:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 13:22:20 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Katrin Fischer --- Tested again in Chromium and Bootstrap theme: - Logged out. - Closed browser. - Reopened browser. - Did 2 simple searches. - Logged in using the link on top. - Doubled up entries in search history. - Logged out. - Did another serach. - Logged back in. - Doubled up entries in search history. I can't pass this :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 14:56:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 13:56:11 +0000 Subject: [Koha-bugs] [Bug 10429] branch filter not working in serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 14:56:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 13:56:17 +0000 Subject: [Koha-bugs] [Bug 10429] branch filter not working in serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19748|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 23864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23864&action=edit [PASSED QA] Bug 10429 - branch filter not working in serial claims In serial claims page, the branch code is displayed in table instead of branch name and branch filter does not work. This patch adds the display of branch name by using branches template plugin. It changes javascript branch filter to make it work. Also sets "all" filter in template (like status filter) to allow translation and sets "all" as selected by default. Librairian branch was selected by default, but the table was not filtered with it. Test plan : - Go to serials claim of a vendor with serials of multiple branches => You see branch filter with "(All)" and table shows libraries names - Check that branch filter does its work Signed-off-by: David Cook Works as described. Signed-off-by: Katrin Fischer Table now shows the branch name instead of the branchcode. First option was named (All), matching the status pull down. When opening the claims page, (All) is preselected and the result list matches with the selection. Before the patch the library was preselected, but the result list did show late issues from all branches. This patch is an improvement, but there is still more work to do. - Filters are not cumulative, but when another filter is selected the first filter is not reset. - It's not possible to combine 2 or more filters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 14:59:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 13:59:59 +0000 Subject: [Koha-bugs] [Bug 5441] SSO CAS improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5441 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC|katrin.fischer at bsz-bw.de | Assignee|gmcharlt at gmail.com |paul.poulain at biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 15:29:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 14:29:25 +0000 Subject: [Koha-bugs] [Bug 11048] Fix logout redirection for CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11048 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 15:29:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 14:29:31 +0000 Subject: [Koha-bugs] [Bug 11048] Fix logout redirection for CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11048 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23768|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 23865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23865&action=edit [PASSED QA] Bug 11048: Fix logout redirection for CAS authentication The logout redirection function after a CAS authentication was misused. This patch fixes it, and allows the CAS server to redirect the user back to the opac after logout. Signed-off-by: Chris Cormack >From the Authen::Cas::Client documentation logout_url [%args] "logout_url()" returns the CAS server's logout URL which can be used to redirect users to end authenticated sessions. %args may contain the following optional parameter: * url => $url If present, the CAS server will present the user with a link to the given URL once the user has logged out. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Change only affects CAS authentication and is correct according to the module documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 15:43:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 14:43:54 +0000 Subject: [Koha-bugs] [Bug 7002] Inaccurate checks for borrower flags == 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10277 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 15:43:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 14:43:54 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7002 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 15:46:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 14:46:37 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #21 from Katrin Fischer --- Patch currently doesn't apply. I tried applying it directly on master and on top of bug 10277: Signed-off-by: Joel Sasse -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 10276 - Extend IndependentBranches to support groups of libraries fatal: sha1 information is lacking or useless (C4/Items.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10276 - Extend IndependentBranches to support groups of libraries The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem, run "git am --resolved". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 16:29:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 15:29:56 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #22 from Katrin Fischer --- Comment on attachment 23641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23641 Bug 10276 - Extend IndependentBranches to support groups of libraries Review of attachment 23641: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10276&attachment=23641) ----------------------------------------------------------------- Patch doesn't apply, but doing a quick code review: 1) Commit message could be updated, dependencies noted are resolved and example is slightly wrong (should be group 1 and 3). 2) Patch touches a lot of routines in different modules, but none of this is backed up by unit tests. This is a big feature with a lot of possible consequences if we break something, I think unit tests are a requirement, at least for the new routine. (UT) 3) Patch has bug 10277 notes as dependency, but is not using the new function consequently (C4::Context->IsSuperLibrarian()) 4) Patch seems to remove 'properties' from the interface. Currently libraries can add properties library groups. I think we need to discuss this before removing the feature. Also we need to think about databases with property groups defined and how to migrate them. Or keep the option. (properties) ::: C4/Branch.pm @@ +43,4 @@ > &GetBranchCategories > &GetBranchesInCategory > &ModBranchCategoryInfo > + &GetIndependentGroupModificationRights UT @@ +376,4 @@ > > #TODO manage category types. rename possibly to 'agency domains' ? as borrowergroups are called categories. > sub GetCategoryTypes { > + return ( 'searchdomain','independent_groups'); properties @@ +446,5 @@ > + > + If 'branch' is not provided, it will be looked up via > + C4::Context->userenv->{branch}. > + > + If 'for' is provided, the lookup is limited to that branch. Could you explain the behaviour/use of 'for' a bit more? @@ +452,5 @@ > + If called in a list context, returns a list of > + branchcodes ( including $this_branch ). > + > + If called in a scalar context, it returns > + a count of matching branchcodes. Returns 1 if ...? :) ::: C4/Serials.pm @@ +238,5 @@ > + subscription.subscriptionid as subsid > + |; > + if ( C4::Context->preference('IndependentBranches') > + && C4::Context->userenv > + && C4::Context->userenv->{'flags'} % 2 != 1 C4::Context->IsSuperLibrarian() @@ +355,5 @@ > + |; > + > + if ( C4::Context->preference('IndependentBranches') > + && C4::Context->userenv > + && C4::Context->userenv->{'flags'} % 2 != 1 C4::Context->IsSuperLibrarian() @@ +413,5 @@ > + |; > + > + if ( C4::Context->preference('IndependentBranches') > + && C4::Context->userenv > + && C4::Context->userenv->{'flags'} % 2 != 1 C4::Context->IsSuperLibrarian() @@ +594,5 @@ > + |; > + > + if ( C4::Context->preference('IndependentBranches') > + && C4::Context->userenv > + && C4::Context->userenv->{'flags'} != 1 C4::Context->IsSuperLibrarian() ::: catalogue/moredetail.pl @@ +177,3 @@ > my $userenv = C4::Context->userenv(); > + unless ( > + $userenv->{'flags'} % 2 != 1 C4::Context->IsSuperLibrarian() ::: cataloguing/additem.pl @@ +702,4 @@ > #verifying rights > my $userenv = C4::Context->userenv(); > + unless ( > + $userenv->{'flags'} % 2 == 1 C4::Context->IsSuperLibrarian()f ::: circ/circulation-home.pl @@ +39,5 @@ > $template->param( fast_cataloging => 1 ) if (defined $fa); > > # Checking if the transfer page needs to be displayed > +$template->param( display_transfer => 1 ) > + if ( $flags->{'superlibrarian'} == 1 C4::Context->IsSuperLibrarian() ::: installer/data/mysql/kohastructure.sql @@ +365,4 @@ > `categorycode` varchar(10) NOT NULL default '', -- unique identifier for the library/branch group > `categoryname` varchar(32), -- name of the library/branch group > `codedescription` mediumtext, -- longer description of the library/branch group > + `categorytype` ENUM( 'searchdomain', 'independent_group' ) NULL DEFAULT NULL, -- says whether this is a search group or an independent group properties -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 16:39:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 15:39:13 +0000 Subject: [Koha-bugs] [Bug 9686] Sorting with independent branches returns results from all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9686 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com --- Comment #1 from Katrin Fischer --- Kyle, could you check this bug report? I am not sure I understand the problem described. We don't filter bibliographic searches yet I think, but you can't search for patrons in the OPAC... so I am confused. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 16:41:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 15:41:41 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 --- Comment #35 from Katrin Fischer --- Hi Kyle, I found bug 7002 - it looks like there could be some more occurences to fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 16:42:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 15:42:14 +0000 Subject: [Koha-bugs] [Bug 7002] Inaccurate checks for borrower flags == 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hm, I did a quick search and found some occurences of the problematic syntax in the current code: catalogue/moredetail.pl 178 unless (($userenv->{'flags'} == 1) or ($userenv->{'branch'} eq $item->{'homebranch'})) { cataloguing/additem.pl 695 unless (($userenv->{'flags'} == 1) or (($userenv->{'branch'} eq $subfieldvalue))){ tools/batchMod.pl 498 unless (($userenv->{'flags'} == 1) or (($userenv->{'branch'} eq $itembranchcode))){ -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 17:28:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 16:28:47 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 --- Comment #11 from Katrin Fischer --- Comment on attachment 23638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23638 Bug 10278 - Add ability to hide items and records from search results for Independent Branches Review of attachment 23638: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10278&attachment=23638) ----------------------------------------------------------------- Can't apply this patch, as the dependency doesn't apply, but starting with a code review: 1) We need some unit tests for the new routine GetCategoriesForBranch (UT). Also regression tests, additional tests, any tests for some of the other routines would be nice. Failed QA for the missing unit tests. ::: C4/Branch.pm @@ +42,4 @@ > &GetCategoryTypes > &GetBranchCategories > &GetBranchesInCategory > + &GetCategoriesForBranch UT ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref @@ +75,5 @@ > + default: 0 > + choices: > + yes: Prevent > + no: "Don't prevent" > + - staff from seeing items owned by other libraries, and records without any items the library. I think there is a word missing in the last bit. I wonder a bit about the consequences - it will be required to always add at least one 'fake' item to every record, that you want to show up in the OPAC. Thinking about serials and electronic resources, but also set and traced serial record as used in Germany. ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt @@ +32,2 @@ > strQuery += "&" + "[% z3950_search_param.name %]" + "=" + "[% z3950_search_param.encvalue %]"; > +*/ Why are you commenting this bit out? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 17:29:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 16:29:28 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 17:58:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 16:58:04 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 --- Comment #14 from Katrin Fischer --- Comment on attachment 23639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23639 Bug 10263 - Add ability to limit which branch can edit a bibliographic record (IndependentBranchesMarcEditing) Review of attachment 23639: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10263&attachment=23639) ----------------------------------------------------------------- Doing some code review here too... 1) I think instead of using a new separate authorised value entry to have an empty option, this could work like the item form. If you mark the subfield mandatory, it will not offer an empty option. If it's not mandatory, it will. But it looks like the rule does not apply to the cataloguing form yet, as 942$c (itemtype) offers an empty option and is mandatory. Hm. 2) HasIndependentGroupModificationRightsFor needs some unit tests and documentation. Why is $self ignored? Why not use GetIndependentGroupModificationRights( { for => $branchcode } );? 3) Spotted another 'old' superlibrarian permission check. Failing for 2), 3) might be resolved by one of the other dependent patches. ::: C4/Auth.pm @@ +197,3 @@ > # to create the template's parameters that will indicate > # which menus the user can access. > if ( $flags && $flags->{superlibrarian}==1 ) { Old check for superlibrarian permission. ::: Koha/Template/Plugin/Koha.pm @@ +44,4 @@ > return C4::Context->preference( $pref ); > } > > +sub HasIndependentGroupModificationRightsFor { POD, UT ::: admin/marc_subfields_structure.pl @@ +133,4 @@ > push @authorised_values, $category; > } > push( @authorised_values, "branches" ); > + push( @authorised_values, "branches_optional" ); See 1) for an idea to handle this a bit differently. ::: installer/data/mysql/kohastructure.sql @@ +127,4 @@ > `timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- date and time this record was last touched > `datecreated` DATE NOT NULL, -- the date this record was added to Koha > `abstract` mediumtext, -- summary from the MARC record (520$a in MARC21) > + `branchcode` VARCHAR( 10 ) NULL DEFAULT NULL, -- branchcode for the opationl 'owner' of this record. Small documentation typo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 17:58:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 16:58:20 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 18:05:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 17:05:10 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer --- Couldn't spot any problems reviewing the code :) I am marking this BLOCKED, because of the dependencies. As soon as those have moved forward, this can go back to signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 21:02:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 20:02:59 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Hi Robin, I am a bit worried about the dependency on bug 10611 as we were planning on adding some kind of Postgres support to 3.16. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 21:39:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 20:39:56 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #11 from Robin Sheat --- (In reply to Katrin Fischer from comment #10) > Hi Robin, I am a bit worried about the dependency on bug 10611 as we were > planning on adding some kind of Postgres support to 3.16. It's not a hard depends, it's just that bug 10611 solves a problem that I identified that (significantly) improves performance. I think that we should apply that, and then work out how to make it work with pgsql, but that's a discussion for that bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 21:42:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 20:42:23 +0000 Subject: [Koha-bugs] [Bug 3445] action_logs table needs some thought In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3445 --- Comment #6 from Katrin Fischer --- Not sure if that's too many indexes, but it works as expected :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 21:42:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 20:42:47 +0000 Subject: [Koha-bugs] [Bug 3445] action_logs table needs some thought In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3445 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 21:42:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 20:42:54 +0000 Subject: [Koha-bugs] [Bug 3445] action_logs table needs some thought In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3445 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23222|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 23866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23866&action=edit [PASSED QA] Bug 3445 - action_logs table needs indexes This patch adds database indexes for action_logs table to speed up "log viewer" page. Removes the existing index on timestamp+user to add an indexe on each column since earch colums is separately defined in log viewer form. Test plan: - Update database - Play with log viewer : /cgi-bin/koha/tools/viewlog.pl - Perform searches with only one filter defined - Also check you see indexes with SQL query : SHOW CREATE TABLE action_logs Signed-off-by: Mathieu Saby Signed-off-by: Katrin Fischer Rephrased the updatedatabase message a bit: Add indexes to action_logs table Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 21:53:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 20:53:29 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #12 from Katrin Fischer --- So these patches can be tested without 10611 as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 21:54:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 20:54:57 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 22:09:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 21:09:03 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #13 from Robin Sheat --- (In reply to Katrin Fischer from comment #12) > So these patches can be tested without 10611 as well? Yep. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 22:11:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 21:11:15 +0000 Subject: [Koha-bugs] [Bug 11457] New: t/db_dependent/Bookseller.t can fail when subscription table is not empty Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Bug ID: 11457 Summary: t/db_dependent/Bookseller.t can fail when subscription table is not empty Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: katrin.fischer at bsz-bw.de QA Contact: gmcharlt at gmail.com Tests 22 and 23 failed on my database because I had a few subscriptions in my database. After setting the subscription.enddate far into the future the tests passed again. ok 22 - search for subscriptions by expiration date ok 23 - search for subscriptions by expiration date Maybe cleaning the subscription table within the transaction before running the test would fix this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 22:15:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 21:15:43 +0000 Subject: [Koha-bugs] [Bug 7965] Silence warns in staff error log (koha-error_log) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7965 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 22:15:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 21:15:49 +0000 Subject: [Koha-bugs] [Bug 7965] Silence warns in staff error log (koha-error_log) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7965 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23826|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 23867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23867&action=edit [SIGNED OFF] Bug 7965 : Silence warns in staff log Silence warns in C4::Bookseller to test 1/ run prove t/db_dependent/Bookseller.t Notice lots of Use of uninitialized value $delay in numeric lt (<) at /var/lib/jenkins/jobs/Koha_master/workspace/C4/Bookseller.pm line 134 type lines 2/ apply patch 3/ run prove t/db_dependent/Bookseller.t Notice warns are gone Signed-off-by: Katrin Fischer Tiny change, positive consequences. Passes QA script and all tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 22:21:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 21:21:18 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 22:29:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 21:29:12 +0000 Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 22:33:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 21:33:28 +0000 Subject: [Koha-bugs] [Bug 2546] Description of charges: string hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11387 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 22:33:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 21:33:28 +0000 Subject: [Koha-bugs] [Bug 11387] "Hold waiting too long" is untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2546 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 22:38:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 21:38:45 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #32 from Katrin Fischer --- Hi Kyle, I reran the test, the result is the same: testing 4 commit(s) (applied to e815131 'Bug 10138: (follow-up) FIX sql errors') FAIL misc/sip_cli_emulator.pl OK pod OK forbidden patterns OK valid FAIL critic Subroutine prototypes used at line 115, column 1. See page 194 of PBP. Maybe someone else can test - did you check line 115? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 22:44:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 21:44:32 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #8 from Katrin Fischer --- Patches apply for me, for the second patch I think the subject should be a sponsor line :) (http://wiki.koha-community.org/wiki/Commit_messages#Sponsor_line) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 22:48:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 21:48:04 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Katrin Fischer --- Blou, could you take a look and provide a follow-up for the bootstrap theme? It's the default theme now and we shouldn't add a new feature that doesn't work with it. Also, both patches seem almost identical - I am obsoleting the older patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 22:48:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 21:48:23 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22007|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 23:01:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 22:01:36 +0000 Subject: [Koha-bugs] [Bug 11366] Acq basket group "No group" untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11366 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master --- Comment #1 from Katrin Fischer --- I can confirm this bug, the string is hardcoded into basket.pl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 23:08:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 22:08:47 +0000 Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #21 from Katrin Fischer --- Hi Kyle, could you take a look at Srdjan's comment? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 23:10:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 22:10:46 +0000 Subject: [Koha-bugs] [Bug 11309] Duplicated patterns when subscription table is updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11309 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Depends on| |11261 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 23:10:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 22:10:46 +0000 Subject: [Koha-bugs] [Bug 11261] Sample frequencies and numbering patterns should better be mandatory on install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11261 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11309 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 23:29:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 22:29:05 +0000 Subject: [Koha-bugs] [Bug 11320] Ambiguous message when a duplicate record is detected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11320 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I have problems triggering the duplicate message on master right now. I tried matching title, biblio level itemtype and ISBN, but no success so far. Probably missing something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 23:37:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 22:37:50 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from Katrin Fischer --- Failing QA to get attention for comment 26 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 29 23:56:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 22:56:50 +0000 Subject: [Koha-bugs] [Bug 11458] New: Confusing description for syspref gist Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11458 Bug ID: 11458 Summary: Confusing description for syspref gist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org The description of "gist" is: "Default tax rates are .............. (enter in numeric form, 0.12 for 12%. First is the default. If you want more than 1 value, please separate with |) " The use of "default" is confusing here. It should be "Authorized (Possible ?) tax rates are...." M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 00:01:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 23:01:29 +0000 Subject: [Koha-bugs] [Bug 11459] New: OrderPdfFormat pref description could be more verbose Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Bug ID: 11459 Summary: OrderPdfFormat pref description could be more verbose Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org The description is: " Use when printing basket groups. " The list of possible templates should be precised. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 00:18:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Dec 2013 23:18:30 +0000 Subject: [Koha-bugs] [Bug 11284] Package related updates for the new release In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11284 --- Comment #7 from Robin Sheat --- Thanks Fridolin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 02:47:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 01:47:04 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 Samuel Crosby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |scrosby000 at gmail.com --- Comment #1 from Samuel Crosby --- Created attachment 23868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23868&action=edit Proposed bug fix for 9654 Here we go, my first bug fix :D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 02:51:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 01:51:10 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 02:56:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 01:56:18 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23868|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 23869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23869&action=edit Bug 9654: Missing space between amount and currency symbol in basket group Formatting fix. To test 1) Create some orders, don't automatically add them to a basket group 2) Open a new basket group from the basket group page of the vendor 3) Check display of currencies for the orders shown 4/ Apply patch 5/ Recheck display -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 03:26:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 02:26:52 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- Working on "I've never used basket groups before" test plan, but this works as advertised. It even passes the qa test tool. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 04:25:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 03:25:07 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from M. Tompsett --- However, I did further thinking, and there's a problem. :( --- BEGIN SAMPLE CODE --- #!/usr/bin/perl -Tw my $val = undef; my $total = 'q'; $total .= " " . ($val // 0); print "$total\n"; $total = 'q'; $total .= " " . $val // 0; print "$total\n"; --- END SAMPLE CODE --- Before the space was added, a precedent issue wasn't as big an issue. I think the patch should be: $total .= " " . ($bookseller->{invoiceprice} // 0); This will avoid an noisy warning, and better reflect the intent of the original code, since I don't think (" " . $val) // 0; is the thing being aimed for. Here is my revised test plan: 1) Log into staff client 2) Acquisitions 3) Click 'Search' in the 'Manage orders' box. 4) Click '+ New basket' beside a vendor name. 5) Type 'Bug 9654 Test 1' into basket name. 6) Click 'Save' 7) Click 'Add to basket' 8) Click 'From an external source' 9) Type 'Green Eggs and Ham' into the Title text box. 10) Click 'Search' 11) Click 'Order' on any one of the results. 12) Click 'Add Item' in the 'Item' box. 13) Select a Fund from the dropdown in the 'Accounting details' box. 14) Click 'Save' 15) Click 'Close this basket' 16) Click 'Yes, close (Y)' without checking the attach to a basket group. 17) Click the 'Basket groups' tab. 18) Click '+ New basket group' 19) Notice the listing in 'Ungrouped baskets' lacks a space between the number and the currency. (e.g. Total: 0USD) 20) Apply patch (git bz apply 9654) 21) Refresh the page 22) Notice there is now a space. (e.g. Total: 0 USD) 23) Run the Koha QA Tool: (~/qa-test-tools/koha-qa.pl -v 2 -c 1) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 05:01:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 04:01:31 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 --- Comment #5 from Samuel Crosby --- Created attachment 23870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23870&action=edit Fixed again Here we go -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 05:09:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 04:09:53 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 Samuel Crosby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 05:15:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 04:15:55 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23869|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 05:21:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 04:21:28 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 --- Comment #6 from M. Tompsett --- Created attachment 23871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23871&action=edit [SIGNED OFF] Bug 9654: Missing space between amount and currency symbol in basket group Changed: $total .= $bookseller->{invoiceprice} // 0; Into: $total .= " " . ($bookseller->{invoiceprice} // 0); in order to add a space between the total and currency in the basket group. Revised test plan: 1) Log into staff client 2) Acquisitions 3) Click 'Search' in the 'Manage orders' box. 4) Click '+ New basket' beside a vendor name. 5) Type 'Bug 9654 Test 1' into basket name. 6) Click 'Save' 7) Click 'Add to basket' 8) Click 'From an external source' 9) Type 'Green Eggs and Ham' into the Title text box. 10) Click 'Search' 11) Click 'Order' on any one of the results. 12) Click 'Add Item' in the 'Item' box. 13) Select a Fund from the dropdown in the 'Accounting details' box. 14) Click 'Save' 15) Click 'Close this basket' 16) Click 'Yes, close (Y)' without checking the attach to a basket group. 17) Click the 'Basket groups' tab. 18) Click '+ New basket group' 19) Notice the listing in 'Ungrouped baskets' lacks a space between the number and the currency. (e.g. Total: 0USD) 20) Apply patch (git bz apply 9654) 21) Refresh the page 22) Notice there is now a space. (e.g. Total: 0 USD) 23) Run the Koha QA Tool: (~/qa-test-tools/koha-qa.pl -v 2 -c 1) Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 05:21:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 04:21:54 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23870|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 05:23:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 04:23:22 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from M. Tompsett --- Congratulations on your first signed off bug fix. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 09:31:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 08:31:40 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #7 from Katrin Fischer --- Hi Christopher, yes, I think we should fix all of those to be more accessible, especially in the OPAC. I have started pointing out the problem when testing new patches and I filed some bugs (you shoudl be able to find most of them with 'accessibility'). Until the library we support pointed it out, I was not aware of the problem, but now that we know it is a problem, it would be nice to find a more accessible best practice for the date fields. But I think it shouldn't stop this patch from going in, because if it works well it will already be a small improvement and help a library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 09:42:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 08:42:53 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 --- Comment #41 from Fridolin SOMERS --- (In reply to Galen Charlton from comment #38) > (In reply to Fridolin SOMERS from comment #33) > > Patches pushed to 3.14.x, will be in 3.14.2 > > (creates version 3.14.01.002) > > I request that you revert this from the 3.14.x branch immediately. By long > tradition, the maintenance releases are not supposed to receive enhancements > except for the most trivial ones. Ok, I'll revert. I'm sorry, this bug looked trivial for me. In my opinion, it should then be a "new feature". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 09:55:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 08:55:07 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 --- Comment #42 from Fridolin SOMERS --- Reverted from 3.14.x. Since those patches where not yet released, I simply reverted version patch. Version is back to 3.14.01.001. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 09:56:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 08:56:11 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 --- Comment #43 from Katrin Fischer --- Thx Fridolin, I think it's safer that way. We have used "new feature" mostly for really big things in the past, this might be in a bit of a grey zone. It is an enhancement for the acq module, but at the same time a feature that didn't exist before - I would be fine with changing the importance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 09:57:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 08:57:17 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 09:57:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 08:57:24 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23576|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 23872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23872&action=edit Bug 11400: Show "Login as a different user" instead of "Logout" if not enough premissions Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive this string change is worth. Simple and disputable string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 10:35:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 09:35:21 +0000 Subject: [Koha-bugs] [Bug 10852] Add 3 filters to the serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #16 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 10:51:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 09:51:26 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #36 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 10:54:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 09:54:07 +0000 Subject: [Koha-bugs] [Bug 11166] branch filter in budgets admin uses pattern match instead of equals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 10:56:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 09:56:04 +0000 Subject: [Koha-bugs] [Bug 11383] There is no help page for the marc modification templates tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11383 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 10:58:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 09:58:19 +0000 Subject: [Koha-bugs] [Bug 11410] Cataloging search finds no results for searches with ampersands In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23722|0 |1 is obsolete| | CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 10:59:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 09:59:41 +0000 Subject: [Koha-bugs] [Bug 11410] Cataloging search finds no results for searches with ampersands In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 11:05:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 10:05:23 +0000 Subject: [Koha-bugs] [Bug 10797] Move styling from element to CSS file for search input field in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10797 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2. (this patch is not needed for bootstrap theme). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 11:09:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 10:09:58 +0000 Subject: [Koha-bugs] [Bug 10905] Author tracings incorrect when UseAuthoritiesForTracings is turned on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10905 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2. (this patch is not needed for bootstrap theme) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 11:14:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 10:14:07 +0000 Subject: [Koha-bugs] [Bug 10735] koha-dump not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10735 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 11:18:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 10:18:51 +0000 Subject: [Koha-bugs] [Bug 9948] acq data going on first item even if not received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9948 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #13 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 11:28:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 10:28:00 +0000 Subject: [Koha-bugs] [Bug 11155] PostgreSQL schema contains syntax errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 11:30:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 10:30:48 +0000 Subject: [Koha-bugs] [Bug 11155] PostgreSQL schema contains syntax errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 11:38:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 10:38:54 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature --- Comment #44 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #43) > Thx Fridolin, I think it's safer that way. We have used "new feature" mostly > for really big things in the past, this might be in a bit of a grey zone. It > is an enhancement for the acq module, but at the same time a feature that > didn't exist before - I would be fine with changing the importance. I change to "new feature". It will reflect it is a complex change and need lot of work before integration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 11:47:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 10:47:00 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fridolyn.somers at biblibre.co |koha at univ-lyon3.fr |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 14:23:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 13:23:24 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 14:23:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 13:23:30 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #33 from Kyle M Hall --- Created attachment 23873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23873&action=edit Bug 9288 - Add a script to test SIP from the command line - QA Followup 4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 14:24:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 13:24:21 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #34 from Kyle M Hall --- Setting to passed qa on the assumption that this was the only remaining issue. If I am wrong please update the status! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 15:13:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 14:13:41 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 field in french unimarc_complete framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add 359, 347 and 369 field |Add 359, 947 and 969 field |in french unimarc_complete |in french unimarc_complete |framework |framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 15:54:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 14:54:49 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add 359, 947 and 969 field |Add 359, 947 and 969 fields |in french unimarc_complete |in french unimarc_complete |framework |framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 16:06:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 15:06:29 +0000 Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 16:09:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 15:09:08 +0000 Subject: [Koha-bugs] [Bug 11403] renew page missing help file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11403 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Nicole! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 16:11:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 15:11:13 +0000 Subject: [Koha-bugs] [Bug 11445] it is possible for duplicate hold notifications to be sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11445 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 16:14:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 15:14:23 +0000 Subject: [Koha-bugs] [Bug 11188] Make gather_print_notices.pl die on failed open() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11188 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Magnus! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 16:18:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 15:18:08 +0000 Subject: [Koha-bugs] [Bug 11075] Clicking 'select all' link in export tab in checkout page clears renew checkboxes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11075 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 16:51:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 15:51:53 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #36 from Galen Charlton --- Pushed to master. Thanks, Kyle and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 16:52:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 15:52:06 +0000 Subject: [Koha-bugs] [Bug 11448] Accessibility: Make it possible to enter date for restriction without using the datepicker widget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11448 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #1 from Christopher Brannon --- Here are at least 3 places I've found that do not allow manual entry: request.pl opac-reserve.pl opac-memberentry.pl Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 16:52:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 15:52:18 +0000 Subject: [Koha-bugs] [Bug 7002] Inaccurate checks for borrower flags == 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10277 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 16:52:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 15:52:18 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7002 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 16:53:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 15:53:21 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Christopher Brannon --- (In reply to Katrin Fischer from comment #7) > Hi Christopher, > > yes, I think we should fix all of those to be more accessible, especially in > the OPAC. I have started pointing out the problem when testing new patches > and I filed some bugs (you shoudl be able to find most of them with > 'accessibility'). Until the library we support pointed it out, I was not > aware of the problem, but now that we know it is a problem, it would be nice > to find a more accessible best practice for the date fields. > > But I think it shouldn't stop this patch from going in, because if it works > well it will already be a small improvement and help a library. If that is the case, I will go ahead and sign off on this. As I stated earlier, this fixes the issue as described. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 17:12:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 16:12:44 +0000 Subject: [Koha-bugs] [Bug 7002] Inaccurate checks for borrower flags == 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 17:12:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 16:12:50 +0000 Subject: [Koha-bugs] [Bug 7002] Inaccurate checks for borrower flags == 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002 --- Comment #3 from Galen Charlton --- Created attachment 23874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23874&action=edit Bug 7002: fix some invalid superlibrarian permission checks This patch fixes a problem where if a staff user has superlibrarian permissions, but also has module-specific permissions, they are prevent from editing item records that they should be allowed to. To test: [1] Turn on IndependentBranches. [2] Register a superlibrarian staff user at branch A. [3] Give that new account at least one other module-level permission. This cannot be done through the user interface, however, but can be done via SQL: UPDATE borrowers SET flags = 3 WHERE userid = 'XXX'; [4] Log in as that new superlibrarian. [5] Bring up the item details (catalogue/moredetail.pl) page for an item at branch B. Note that there is no 'Edit Item' link. [6] Similarly, try editing that item (cataloging/additem.pl). Note that the edit form forbids you from touching the item. [7] Finally, try editing that item using the Tools | Batch item modification utility. Note that it doesn't allow you to do so. [8] Apply the patch. [9] Repeat steps 5 through 7. This time, the item actions should be allowed. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 17:24:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 16:24:18 +0000 Subject: [Koha-bugs] [Bug 11402] Labels::_guide_box should return undef if undefned data is passed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master, along with a follow-up that adds a unit test for the successful use of _guide_box(). Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 17:49:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 16:49:16 +0000 Subject: [Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master, along with a patch that adds a regression test. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 18:12:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 17:12:13 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 20:12:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 19:12:52 +0000 Subject: [Koha-bugs] [Bug 11131] Authority search does not display summary while searching by all auth types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 20:36:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 19:36:29 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Larry Baerveldt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larry at bywatersolutions.com --- Comment #115 from Larry Baerveldt --- Warning, this code seems to break SIP functionality. C4/ILS.pm is looking for C4/Accounts.pm, but this update removes it. Test: cd C4/SIP perl -c ILS.pm Can't locate C4/Accounts.pm in @INC (@INC contains: /home/koha/kohaclone /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .) at ILS/Transaction/FeePayment.pm line 23. Please do not signoff until SIP functionality has been restored. - Larry -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 20:40:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 19:40:46 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #4 from Peggy Thrasher --- I have just been asked to make only the "Not Checked Out" sound different from the other check in message sounds. Other libraries may want a different sound for "Item was lost, now found". Will your solution accommodate that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 22:56:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 21:56:50 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #4 from Manos PETRIDIS --- While this is still open to discussion, allow me to propose some added functionality/flexibility, i.e. complex expressions in the itemcallnumber system preference. For example, I would prefer having call numbers formatted as "999.99 Aut YYYY" where - 999.99 are the first five digits of DDC code (in MARC21 092ab entry if filled, otherwise 082ab), padded with trailing zeroes so that DDC 920 would become 920.00 - Aut are the first three characters of the SOUNDEX of Author name "LEFT(LTRIM(RTRIM(SOUNDEX(biblio.author))), 3)" and - YYYY is the copyright year "CONVERT(biblio.copyrightdate, CHAR(4))", -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 23:05:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 22:05:56 +0000 Subject: [Koha-bugs] [Bug 11460] New: Correction to default itemcallnumber system preference in UNIMARC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11460 Bug ID: 11460 Summary: Correction to default itemcallnumber system preference in UNIMARC Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: egpetridis at yahoo.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The pre-set (default) value for the itemcallnumber syspref is ?082ab?, and the relevant example text is ?Examples: Dewey: 082ab or 092ab; LOC: 050ab or 090ab; from the item record: 852hi?, even in UNIMARC installations. While this may be correct for MARC21/USMARC installations, I understand that the correct entry for a UNIMARC installation would be ?676a? for Dewey, or something similar. Both the default value and the example text could be amended to reflect this in UNIMARC installations. As it regards the example text, I wonder however if MARC flavor selection during set-up can go beyond framework selection and default values; The text may have to be expanded to cover more flavours or warn the user that the example only stands for USMARC/MARC21. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 30 23:15:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 22:15:09 +0000 Subject: [Koha-bugs] [Bug 11461] New: Added functionality for batch Z39.50 searches Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11461 Bug ID: 11461 Summary: Added functionality for batch Z39.50 searches Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: egpetridis at yahoo.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Z39.50 searches can take long when many different targets are consulted. The interactive process can be counter-productive in these circumstances. I wonder therefore if you too find batch Z39.50 searches an interesting idea: The user would be able to enter ISBNs (or other similar search terms) in a table, and koha would perform searches against Z39.50 targets in batch mode, either in the background, or semi-interactively, i.e. by taking-up a browser window. Search elements already processed, would be removed from the table, so that the user would be aware when the search is complete for each item. The user would also be able to add more search terms at the bottom of the list, even when the batch search is active. Search results would be stored in an appropriate container (the ?reservoir? perhaps) and koha cataloguing (cataloguing/addbooks.pl ?) would be amended to allow for searches against this container too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 00:04:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 23:04:51 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #9 from Chris Cormack --- > > If that is the case, I will go ahead and sign off on this. As I stated > earlier, this fixes the issue as described. > > Christopher Hi Christopher (from another Christopher) Do you want to do the sign off on the patch? Do you know how to do that, would you like me to add your sign off for you? Or if you plan to test more (please say yes) This is probably the easiest way http://wiki.koha-community.org/wiki/Git_bz_configuration Alternatively, you can just git commit --amend -s To add your signoff git format-patch origin/master To create the signed off patch, and then attach it in bugzilla, obsoleting the old patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 00:09:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 23:09:55 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #10 from Christopher Brannon --- Chris, No worries. I've got it. I didn't realize there was more to signing off than changing the status. I'll just do it from the sandbox. Thanks! Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 00:12:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 23:12:17 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #11 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 00:12:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 23:12:37 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23699|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 00:12:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 23:12:47 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #12 from sandboxes at biblibre.com --- Created attachment 23875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23875&action=edit Bug 10995 - Accessibility: Allow manual entry of renewal date and specific due date in circ >From Katrin Fischer: In 3.12 it's no longer possible to enter dates manually as specific due date and renewal date in the patron account in circulation. This is a big accessibility problem as not everyone can use the datepickers for filling those fields. We have a library where this is a blocker. Test Plan: 1) Apply this patch 2) Start checking out a patron 3) Note when you click the due date field, the calendar pops up, but you can now edit the field by hand as well Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 00:15:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 23:15:40 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #13 from Christopher Brannon --- (In reply to Chris Cormack from comment #9) > Hi Christopher (from another Christopher) > > Do you want to do the sign off on the patch? Do you know how to do that, > would you like me to add your sign off for you? Or if you plan to test more > (please say yes) Chris, I just realized you said "please say yes" to testing more. Did I miss something? Does something else need tested? I did find a bunch of other pages with the same issue, but for the sake of this bug, the patch works as expected. Should I have done more? Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 00:18:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 23:18:17 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #14 from Chris Cormack --- (In reply to Christopher Brannon from comment #13) > (In reply to Chris Cormack from comment #9) > > Hi Christopher (from another Christopher) > > > > Do you want to do the sign off on the patch? Do you know how to do that, > > would you like me to add your sign off for you? Or if you plan to test more > > (please say yes) > > Chris, > I just realized you said "please say yes" to testing more. Did I miss > something? Does something else need tested? I did find a bunch of other > pages with the same issue, but for the sake of this bug, the patch works as > expected. Should I have done more? > > Christopher Not in relation to this bug, but we always need more people signing off/testing. It's even more important than writing patches. Without sign offs, patches can go no where. If you ever have free time, check out http://dashboard.koha-community.org you should be able to find a ton of patches that need testing :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 00:21:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Dec 2013 23:21:35 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #15 from Christopher Brannon --- (In reply to Chris Cormack from comment #14) > Not in relation to this bug, but we always need more people signing > off/testing. It's even more important than writing patches. Without sign > offs, patches can go no where. > > If you ever have free time, check out http://dashboard.koha-community.org > you should be able to find a ton of patches that need testing :) Actually, I have been checking this as I can and chipping away at the items I can test in the sandbox. Always glad to do what I can. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 02:03:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 01:03:06 +0000 Subject: [Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23180|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 23876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23876&action=edit Bug 11253 - tools/inventory.pl output_pref ignores 'iso' parameter passed Took all the output_pref function calls and converted them to the newer hash format parameter. Added special case for dd-mm-yyyy calls, so dt_from_string works correctly. TEST PLAN --------- Create a small barcode file from books in a given branch. Set I18N/L10N system preference of dateformat to mm/dd/yyyy. Go to inventory/stocktaking tool. Browse for the barcode file. Select the branch (i.e. not All libraries) to match. Click submit Table displays dates in "Unseen since" column. Set I18N/L10N system preference of dateformat to yyyy-mm-dd. Go to inventory/stocktaking tool. Browse for the barcode file. Select the branch (i.e. not All libraries) to match. Click submit Table displays dates in "Unseen since" column. Set I18N/L10N system preference of dateformat to dd/mm/yyyy. Go to inventory/stocktaking tool. Browse for the barcode file. Select the branch (i.e. not All libraries) to match. Click submit KABOOM! Apply patch Go to inventory/stocktaking tool. Browse for the barcode file. Select the branch (i.e. not All libraries) to match. Click submit Table displays dates in "Unseen since" column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 02:03:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 01:03:49 +0000 Subject: [Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 02:11:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 01:11:38 +0000 Subject: [Koha-bugs] [Bug 11462] New: New series title authority includes volume number Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11462 Bug ID: 11462 Summary: New series title authority includes volume number Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When a new authority is created for a series title (Marc 8XX) as part of cataloguing, it also records Volume number/sequential designation (subfield $v). One has to manually remove volume detail from the authority, so identical series title headings can be grouped together. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 10:07:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 09:07:16 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #3 from Fridolin SOMERS --- This might be caused by URL-rewriting (in apache configuration). Because when Keyword is selected, the value of select is empty and it generates in URL "&idx=" which is removed by URL-rewriting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 10:55:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 09:55:20 +0000 Subject: [Koha-bugs] [Bug 7151] rebuild_zebra needs a lockfile In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7151 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |DUPLICATE --- Comment #1 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 11078 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 10:55:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 09:55:20 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #41 from Martin Renvoize --- *** Bug 7151 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 12:01:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 11:01:26 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21838|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 12:10:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 11:10:47 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22697|0 |1 is obsolete| | --- Comment #21 from Fridolin SOMERS --- Created attachment 23877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23877&action=edit Bug 10648 - In records merge greatest field can not be added When merging 2 records (/cgi-bin/koha/cataloguing/merge.pl), the destination record is build using the fields and subfields checked in source records. When a field is checked, the javascript code searches in destination record a field with a greater tag number to insert new field before. When the new field tag number is greater than all existing field tag numbers, the field is not added. This patch corrects this by adding at end if no greater field tag number exists. Also adds a sort of fields by tag number because all mergo code is based on this. Test plan : - Add to a framework a repeatable field with the greater non existing tag number. For example 998. - Edit 2 records with this framework and add them a value in this tag. - Put those records is a list - Go to this list and check the two records - Click on "Merge selected" - Click on next - Go to second source record - Click on the greatest tag number. for example 998. => The field is added at the end of destination record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 12:15:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 11:15:27 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #22 from Fridolin SOMERS --- Here is new patch. Please re-signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 12:24:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 11:24:39 +0000 Subject: [Koha-bugs] [Bug 11463] New: GetItem must use item-level_itypes syspref Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11463 Bug ID: 11463 Summary: GetItem must use item-level_itypes syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In GetItem, the key itype comes from items.itype and if not defined from biblioitems.itemtype. This code should be based on item-level_itypes syspref. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 12:33:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 11:33:27 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #14 from Fridolin SOMERS --- In fact, the problem of GetItem() is not the main concern of this bug and it seems to be a very complex problem. I've created Bug 11463 to focus on it. It may be set has dependency but in my option it is not. Actually, with item-level_itypes off, the code uses $item->{'itemtype'}. But this key is never defined. That is what the patch corrects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 12:33:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 11:33:43 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11463 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 12:33:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 11:33:44 +0000 Subject: [Koha-bugs] [Bug 11463] GetItem must use item-level_itypes syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11463 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9532 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 12:34:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 11:34:37 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19607|0 |1 is obsolete| | --- Comment #15 from Fridolin SOMERS --- Comment on attachment 19607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19607 Bug 9532: GetItem must use item-level_itypes syspref (moved to Bug 11463) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 12:36:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 11:36:09 +0000 Subject: [Koha-bugs] [Bug 11463] GetItem must use item-level_itypes syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11463 --- Comment #1 from Fridolin SOMERS --- See Bug 9532 comments : http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532#c13 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 12:39:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 11:39:24 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11463 Depends on|9532 |11463 --- Comment #21 from Fridolin SOMERS --- In fact, the problem of GetItem() is not the main concern of this bug and it seems to be a very complex problem. I've created Bug 11463 to focus on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 12:39:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 11:39:24 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9351 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 12:39:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 11:39:24 +0000 Subject: [Koha-bugs] [Bug 11463] GetItem must use item-level_itypes syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11463 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9351 See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9351 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 12:44:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 11:44:00 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #22 from Fridolin SOMERS --- I have set 11463 as dependency, but actually, other operations like checkout uses GetItem() and then $item->{itype} in UpdateStats(). So this patch simply sets return operation like other operations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 12:50:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 11:50:00 +0000 Subject: [Koha-bugs] [Bug 11463] GetItem must use item-level_itypes syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11463 --- Comment #2 from Fridolin SOMERS --- Created attachment 23878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23878&action=edit Bug 11463 - GetItem must use item-level_itypes syspref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 12:51:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 11:51:05 +0000 Subject: [Koha-bugs] [Bug 11463] GetItem must use item-level_itypes syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11463 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch --- Comment #3 from Fridolin SOMERS --- I've attached the patch but it surely needs a huge test plan. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 13:08:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 12:08:20 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #23 from mathieu saby --- I did not read all the comments, but for some libraries, what is needed in statistical table is BOTH items.itype and biblioitems.itemtype, and maybe a clear indication (a 3rd column "circulation_type" ?) of which type is was used for circulation rights. Ex: In Rennes 2 we use item level for defining circulation rules. items.itype are codes for "Short Loan", "Normal Loan", "Long loan". biblioitems.itemtype are "Book", "Serial", "DVD" etc. For our annual report, we need to know the number of Books, Serials, DVD checked out, even if the type used for defining circulation rules are "Short loan", and not "Book". But other libraries may have different settings, and may have need to make stats on item level, or maybe cross stats on both level. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 17:32:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 16:32:39 +0000 Subject: [Koha-bugs] [Bug 10904] would like to limit patron update request management by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 19:08:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 18:08:27 +0000 Subject: [Koha-bugs] [Bug 10849] z3950servers.pl multiple pages features/filter not working as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10849 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #1 from Manos PETRIDIS --- Same in v3.14. Changing the "Show n entries" value doesn't refresh the window, nor is there a specific refresh button. Pressing the previous/next page buttons does nothing, in IE at least. Selecting a different sort order only sorts the (20) lines displayed, so there is no way to quickly navigate through the table's entries (2405 rows in my case). It would make more sense to sort through all the rows and display the first n rows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 19:12:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 18:12:11 +0000 Subject: [Koha-bugs] [Bug 10849] z3950servers.pl multiple pages features/filter not working as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10849 --- Comment #2 from Manos PETRIDIS --- Bug is marked as enhancement, I believe though that this may be better described as a regression fix. Z39.50 targets' pagination used to work - more or less - in v3.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 19:29:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 18:29:59 +0000 Subject: [Koha-bugs] [Bug 7967] Z39.50 client should negotiate encoding with server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 22:30:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 21:30:27 +0000 Subject: [Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 22:30:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 21:30:59 +0000 Subject: [Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23738|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 22:31:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 21:31:12 +0000 Subject: [Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 23879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23879&action=edit Bug 11432 - 404.pl redirect for single, hidden result makes no sense. In bug 10584, when searching for something in OPAC and a single, hidden result is returned, the default automatic redirect to the details/MARCdetails/ISBDdetails page triggers a 404.pl error page. This makes no sense. The correct behaviour would be to give no results. TEST PLAN --------- 1) OPAC Search for something (I started with stupid) 2) Narrow it to one item (I tweaked it to stupid things) 3) Detail page comes up 4) Staff client -> home -> administration -> global system preferences -> OPAC 5) OpacHiddenItems add "homebranch: [MAL,DAV,PAP]", changing MAL, DAV, PAP to the branches for items for this single biblio. 6) Search for the one item again in OPAC -- 404.pl is triggered. 4) Apply patch 5) Search again for the one item search -- No results is triggered (as expected) Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 22:32:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 21:32:29 +0000 Subject: [Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #4 from Christopher Brannon --- Patch works according to test plan. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 22:56:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 21:56:17 +0000 Subject: [Koha-bugs] [Bug 11316] plugin icon missing tooltip in addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11316 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 22:56:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 21:56:42 +0000 Subject: [Koha-bugs] [Bug 11316] plugin icon missing tooltip in addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11316 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23202|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 22:56:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 21:56:55 +0000 Subject: [Koha-bugs] [Bug 11316] plugin icon missing tooltip in addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11316 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 23880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23880&action=edit Bug 11316 - plugin icon missing tooltip in addbiblio.pl By adding: title=\"Tag editor\" into the HTML generated in addbiblio, a tooltip displaying 'Tag editor' appears when the moust is hovered over the plugin icon. Test Plan: 1) Log into Staff client 2) Click the 'Search the catalog' tab 3) Type something which will generate results 4) Click the title of a result 5) Click the 'Edit' button 6) Scroll down and click the 'Edit Record' 7) Look through the various tabs and notice that all the plugin icons have no tooltip. 8) Apply the patch 9) Refresh the page 10) All the plugin icons should have the tooltip text of 'Tag editor'. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 22:58:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 21:58:26 +0000 Subject: [Koha-bugs] [Bug 11316] plugin icon missing tooltip in addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11316 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #4 from Christopher Brannon --- Patch works as defined by test plan. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 23:28:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 22:28:15 +0000 Subject: [Koha-bugs] [Bug 10928] Acq Note does not appear when receiving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10928 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #3 from Christopher Brannon --- Mathieu, It could just be that I am not familiar enough with Acquisitions, but I don't see the problem. When receiving an order, I can see the order note without the patch. Can you be more specific as to what version of Koha you are using, and what screen it is missing from? Thanks. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 23:46:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 22:46:16 +0000 Subject: [Koha-bugs] [Bug 11342] Error with opac self registration if BorrowersTitles is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11342 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 23:46:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 22:46:44 +0000 Subject: [Koha-bugs] [Bug 11342] Error with opac self registration if BorrowersTitles is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11342 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23318|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 23:46:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 22:46:58 +0000 Subject: [Koha-bugs] [Bug 11342] Error with opac self registration if BorrowersTitles is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11342 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 23881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23881&action=edit Bug 11342 - Error with opac self registration if BorrowersTitles is empty If BorrowersTitles is empty, it causes the library pulldown on the self registration page to be empty, and to have the "Saluation" field have the option "branches". This patch also fixes a minor string capitalization issue. Test Plan: 1) Enable OPAC self registration 2) Set the system preference BorrowersTitles to be empty 3) View the self registration page 4) Note the lack of branches in the home library pulldown 5) Apply this patch 6) Note the branches now display in the pulldown Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 31 23:49:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 22:49:13 +0000 Subject: [Koha-bugs] [Bug 11342] Error with opac self registration if BorrowersTitles is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11342 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #4 from Christopher Brannon --- Patch works as defined in test plan. Christopher -- You are receiving this mail because: You are watching all bug changes.