From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 00:08:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Nov 2013 23:08:49 +0000
Subject: [Koha-bugs] [Bug 11325] New: Focus not on "Add Item" in Lists
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325
Bug ID: 11325
Summary: Focus not on "Add Item" in Lists
Change sponsored?: ---
Product: Koha
Version: 3.14
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Lists
Assignee: gmcharlt at gmail.com
Reporter: library at stas.org
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
When viewing a list, the focus/cursor is no longer on the "add items" field
below the list.
Previously a user could simply scan or enter barcode numbers to add multiple
items. Now a user must manually focus on this field for each added item,
slowing list creation.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 13:16:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 12:16:58 +0000
Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #24 from mathieu saby ---
Oups, I tested with french translation. I suppose that's why it did not work...
Back to need sign off.
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 13:31:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 12:31:35 +0000
Subject: [Koha-bugs] [Bug 11249] Add db indexes on borrowers names
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 13:57:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 12:57:27 +0000
Subject: [Koha-bugs] [Bug 9368] specific behavior of yr and acqdate indexes
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9368
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mathieu.saby at univ-rennes2.f
| |r
--- Comment #10 from mathieu saby ---
Hello
I discovered the problem recently and signaled it to Biblibre, who pointed to
this bug...
Not a big issue, but it must be fixed, for QP and non-QP instances...
Maybe an alternative could be to suppress the ability to select a date with the
dropdown list (I'm not sure that's very intuitive), and just use the special
input field made for filtering by dates.
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 14:02:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 13:02:23 +0000
Subject: [Koha-bugs] [Bug 11326] New: show more facets should not reload
search
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11326
Bug ID: 11326
Summary: show more facets should not reload search
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: mathieu.saby at univ-rennes2.fr
QA Contact: testopia at bugs.koha-community.org
in opac and staff interface, "show more" facets relaaunch search.
It's useless, as all facets were computed before.
Facets should simply be hidden with css, and un-hidden when a user click on
"show more"
M. Saby
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 14:02:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 13:02:39 +0000
Subject: [Koha-bugs] [Bug 11326] show more facets should not reload search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11326
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 - low |P4
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 14:30:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 13:30:54 +0000
Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #25 from mathieu saby ---
I set some overdue books for a patron.
I ran overdue_notices.pl -n
I applied the patch
ran overdue_notices.pl -n again
I had the same results as before the patch.
=> OK
In the list of notices, I was able to define a new template for ODUE notices
sent by SMS.
=> OK
In Overdue rules, I was able to check one or serveral boxes
(email/feed/phone/print/sms) for each patron category, and for letters 1,2,3
I submit the changes, and checked it was saved
=> OK
But...
I checked only the box "sms" for all my patron categories, and for the 3
letters.
I ran overdue_notices.pl -n
The results were the same as before : the original notice (made for email) was
used, not the new notice I had defined for SMS.
I ran overdue_notices.pl and check message_queue table
The results were the same as before : the original notice (made for email) was
used, not the new notice I had defined for SMS.
=> KO
Maybe I'm doing something wrong?
And, additional questions:
Are "sms" and "phone" are supposed to be 2 different message carrier?
And what about "feed" type ? I don't see how overdue messages can be sent by
"feeds".
So, if feed and phone type should be suppressed, could you provide an other
patch for doing so ? (I don't consider it's part of this bug...).
Failing QA for the "sms" notice template not being used in overdue_notices.pl.
Could you take a look at that?
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 14:31:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 13:31:03 +0000
Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 14:33:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 13:33:23 +0000
Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
--- Comment #26 from mathieu saby ---
Note : my SMS template was just the text "SMS"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 20:06:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 19:06:58 +0000
Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not
fetched in acq orders
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #6 from Katrin Fischer ---
Hi there, I haven't tested it yet, but there I think it won't work for MARC21.
While UNIMARC uses publicationyear, MARC21 uses copyrightyear by default to
store the publication year from 260$c.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 20:14:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 19:14:57 +0000
Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not
fetched in acq orders
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122
--- Comment #7 from mathieu saby ---
(In reply to Katrin Fischer from comment #6)
> Hi there, I haven't tested it yet, but there I think it won't work for
> MARC21. While UNIMARC uses publicationyear, MARC21 uses copyrightyear by
> default to store the publication year from 260$c.
The structure of the 2 marcflavor is the same (date in plain text in 260/210 +
date in coded form). They should be indexed the same way.
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 20:36:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 19:36:41 +0000
Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not
fetched in acq orders
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122
--- Comment #8 from Katrin Fischer ---
I thnk this is a display problem here?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 20:41:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 19:41:07 +0000
Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not
fetched in acq orders
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122
--- Comment #9 from Katrin Fischer ---
What I meant to say is that we save the data into 2 different fields in the
database, so one field is always empty depending on the marcflavour. Hope that
explains it better :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 20:43:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 19:43:32 +0000
Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not
fetched in acq orders
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122
--- Comment #10 from mathieu saby ---
I did not look the patch, I thought of Zebra and not of the db...
I don't know well MARC21, but at a first glance, the date in 260/210 is not
meant to be searchable, but displayed (as the dates in coded fields are
supposed to be the same, but machine-readable). Am I wrong?
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 20:49:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 19:49:52 +0000
Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not
fetched in acq orders
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122
--- Comment #11 from Katrin Fischer ---
I think we are misunderstanding each other - the publication year data will be
in a different field in a MARC21 database, so I think the SQL query changed
here needs to take biblio.copyrightdate into account too.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 22:40:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 21:40:15 +0000
Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use
CheckReserves
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chris at bigballofwax.co.nz
Patch complexity|--- |Medium patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 22:51:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 21:51:59 +0000
Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use
CheckReserves
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697
--- Comment #9 from Chris Cormack ---
I had a go at resolving this conflict, but can't, Katrin can you take a look
please
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 1 23:07:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Dec 2013 22:07:51 +0000
Subject: [Koha-bugs] [Bug 11327] New: Course Reserves not hidden from More
menu when disabled
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11327
Bug ID: 11327
Summary: Course Reserves not hidden from More menu when
disabled
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Staff Client
Assignee: koha-bugs at lists.koha-community.org
Reporter: liz at catalyst.net.nz
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
Course reserves show up in the global more menu in the staff client, even when
course reserves is disabled. It should not show there if it's disabled.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 04:36:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 03:36:04 +0000
Subject: [Koha-bugs] [Bug 11328] New: local cover images in staff
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328
Bug ID: 11328
Summary: local cover images in staff
Change sponsored?: ---
Product: Koha
Version: 3.12
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: nengard at gmail.com
QA Contact: testopia at bugs.koha-community.org
The local cover images don't show on the staff results. This is what was
reported to me:
It looks like the staff client search results is using the same localcovers.js
that the OPAC search results does however it doesn't work because the two pages
are formatted differently.
Here is a jquery that solves it for now:
$("#searchresults").ready(function(){
$("#searchresults table td").each(function(i){
td = $(this);
var tdv = td.find("input[class^='selection']");
var linkv = tdv.attr("value");
var a = $("").attr('href',
'/cgi-bin/koha/catalogue/imageviewer.pl?biblionumber=' + $(tdv).attr("value"));
var img = $("").attr('src',
'/cgi-bin/koha/catalogue/image.pl?thumbnail=1&biblionumber=' +
$(tdv).attr("value"))
if(linkv){
$(td).append(a);
$(a).append(img);
}
});
});
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 09:37:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 08:37:33 +0000
Subject: [Koha-bugs] [Bug 11329] New: Check for marc record in opac-showmarc
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329
Bug ID: 11329
Summary: Check for marc record in opac-showmarc
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: m.de.rooy at rijksmuseum.nl
Reporter: m.de.rooy at rijksmuseum.nl
QA Contact: testopia at bugs.koha-community.org
Instead of just running as_formatted, check if GetMarcBiblio returned
a reference. If you e.g. did not pass an id, return 404 instead of 500.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 09:37:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 08:37:49 +0000
Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Severity|enhancement |trivial
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 09:40:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 08:40:13 +0000
Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329
--- Comment #1 from M. de Rooy ---
Created attachment 23231
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23231&action=edit
Bug 11329: Check for marc record in opac-showmarc
Instead of just running as_formatted, check if GetMarcBiblio returned
a reference. If you e.g. did not pass an id, return 404 instead of 500.
Consistent with opac-export.pl
Test plan:
[1] Run opac-showmarc.pl with valid biblionumber in id parameter.
[2] Remove id parameter from URL. You should get a 404 now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 09:40:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 08:40:29 +0000
Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 09:47:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 08:47:17 +0000
Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329
--- Comment #2 from M. de Rooy ---
Created attachment 23232
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23232&action=edit
Bug 11329: Check for marc record in catalogue/showmarc
Intranet counterpart patch. Same check as in opac/opac-showmarc.
Test plan:
[1] Run showmarc.pl with valid biblionumber in id parameter.
[2] Remove id parameter from URL. You should get a 404 now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:08:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 10:08:50 +0000
Subject: [Koha-bugs] [Bug 11069] increase title ranking in relevance when
using QueryWeightFields
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069
--- Comment #5 from Fridolin SOMERS ---
(In reply to mathieu saby from comment #4)
You are looking at 225 and 410 fields. In default config those fields are
indexed has "Title-series".
This patch manages only "Title" index.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:49:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 10:49:41 +0000
Subject: [Koha-bugs] [Bug 11302] Template::output should deal with object
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |RESOLVED
Resolution|--- |INVALID
--- Comment #6 from Jonathan Druart ---
I was just a try. If it does not work, I reopen the initial report and close
this one.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:50:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 10:50:26 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
UTF8 handling in templates
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|DUPLICATE |---
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:50:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 10:50:27 +0000
Subject: [Koha-bugs] [Bug 9951] Resolve encoding problems where script
parameters are not decoded
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9951
Bug 9951 depends on bug 6554, which changed state.
Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|DUPLICATE |---
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:50:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 10:50:27 +0000
Subject: [Koha-bugs] [Bug 10070] History of anonymous searches is not kept
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070
Bug 10070 depends on bug 6554, which changed state.
Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|DUPLICATE |---
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:50:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 10:50:27 +0000
Subject: [Koha-bugs] [Bug 10074] Encoding problems for login and installer
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10074
Bug 10074 depends on bug 6554, which changed state.
Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|DUPLICATE |---
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:50:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 10:50:27 +0000
Subject: [Koha-bugs] [Bug 10019] Encoding problem with utf8 chars in userid
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10019
Bug 10019 depends on bug 6554, which changed state.
Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|DUPLICATE |---
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:50:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 10:50:43 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
UTF8 handling in templates
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:50:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 10:50:58 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
UTF8 handling in templates
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23140|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:52:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 10:52:59 +0000
Subject: [Koha-bugs] [Bug 10860] In-House Use
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--- Comment #16 from Jonathan Druart ---
(In reply to mathieu saby from comment #15)
> error: The following untracked working tree files would be overwritten by
> merge:
> misc/cronjobs/bulk_transferts.pl
This file does not exist in master. Remove it before applying the patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:08:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 12:08:26 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--- Comment #4 from Jonathan Druart ---
Did you check the dependency?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:09:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 12:09:33 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
a basketgroup without reopening it
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #22827|0 |1
is obsolete| |
--- Comment #23 from Martin Renvoize ---
Created attachment 23233
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23233&action=edit
Bug 9807, followup: Reindent basketgroup.tt
Basketgroup.tt is very hard to read. This patch simply reindents it.
No visiable changes expected
Regression test :
- check the list of opened and closed basketgroups for a vendor is displayed
properly
- check an individual basketgroup (closed and opened) is displayed properly
- check you can edit a basketgroup and save changes
- check you can print and export a basketgroup
- check you can close and reopen a basketgroup
http://bugs.koha-community.org/show_bug.cgi?id=9807
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:11:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 12:11:17 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
a basketgroup without reopening it
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #24 from Martin Renvoize ---
Works as expected.. the final patch really is just a indenting clean up.
Patch still works, patches all still pass qa script and code looks much nicer.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:21:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 12:21:44 +0000
Subject: [Koha-bugs] [Bug 11069] increase title ranking in relevance when
using QueryWeightFields
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069
--- Comment #6 from mathieu saby ---
(In reply to Fridolin SOMERS from comment #5)
> (In reply to mathieu saby from comment #4)
> You are looking at 225 and 410 fields. In default config those fields are
> indexed has "Title-series".
> This patch manages only "Title" index.
Yes, that's what I understood, but in your 1st message you wrote
"so that records with all searched terms in title, even not well ordered, are
more relevant."
So I imagined that if there are 3 records, with the 200 field of one them
matching the searched terms, and only 225/410 fields matching in the 2 others,
the record with the 200 matching the search terms would be the 1st in the
results.
But I suppose the algorithm is more complex than that (and the core of it is
hardcoded in Zebra, isn't it?)
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:22:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 12:22:40 +0000
Subject: [Koha-bugs] [Bug 11069] increase title ranking in relevance when
using QueryWeightFields
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069
--- Comment #7 from mathieu saby ---
By the way, does your patch works with QueryParser? Or does QP calculate
relevance differently?
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:27:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 12:27:04 +0000
Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #27 from Jonathan Druart ---
In fact the test plan is wrong. The 4th step is not for this patch.
The changes for overdue_notices is made by bug 10832.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:28:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 12:28:04 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
--- Comment #5 from mathieu saby ---
(In reply to Jonathan Druart from comment #4)
> Did you check the dependency?
Oh no, I did not see it!
Sorry
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:28:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 12:28:53 +0000
Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
--- Comment #28 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #27)
Test plan is right. Please see the test plan from the active patches, not
obsolete ones.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:32:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 12:32:10 +0000
Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
--- Comment #29 from mathieu saby ---
I'll give a look later, but if the behavior of overdue_notices.pl is changed by
an other patch, I suppose I will be able to sign off this one.
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:32:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 12:32:43 +0000
Subject: [Koha-bugs] [Bug 10860] In-House Use
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860
--- Comment #17 from mathieu saby ---
(In reply to Jonathan Druart from comment #16)
> (In reply to mathieu saby from comment #15)
> > error: The following untracked working tree files would be overwritten by
> > merge:
> > misc/cronjobs/bulk_transferts.pl
>
> This file does not exist in master. Remove it before applying the patch.
Oups. OK, sorry for that
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:58:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 12:58:08 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
a basketgroup without reopening it
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #25 from Martin Renvoize ---
Passing QA for that final followup. It's a template tidy up which doesn't
affect operation.
It'll affect blame as it change whitespace (which can be ignored by -w) but
also breaks lines.
I'm not sure that discussion ever came to an end, but I don't see why the
initial two patches can't get pushed?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 14:10:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 13:10:17 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
a basketgroup without reopening it
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #26 from mathieu saby ---
(In reply to Martin Renvoize from comment #25)
> Passing QA for that final followup. It's a template tidy up which doesn't
> affect operation.
>
> It'll affect blame as it change whitespace (which can be ignored by -w) but
> also breaks lines.
>
> I'm not sure that discussion ever came to an end, but I don't see why the
> initial two patches can't get pushed?
Hello
Discussion with whom?
In fact, if someone really does not want this followup, of course I can
suppress the patch. But I think the reindenting on this file was really needed
and will make further changes easier ;-)
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 14:17:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 13:17:14 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
a basketgroup without reopening it
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #27 from Martin Renvoize ---
Hi Mathieu,
There were a few IRC converstaions and a thread on the mailing list about
tidying the whole koha codebase at some point.. I think the final decision was
to just do it as we go along instead of a massive change.. which is exactly
what you've done here so is good..
I'de leave the patch in, now it's marked passed QA it'll pass by Galen
attention and I'm sure he'll make a sensible decision either way.
Martin
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 14:20:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 13:20:09 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
a basketgroup without reopening it
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
--- Comment #28 from mathieu saby ---
(In reply to Martin Renvoize from comment #27)
> Hi Mathieu,
>
> There were a few IRC converstaions and a thread on the mailing list about
> tidying the whole koha codebase at some point.. I think the final decision
> was to just do it as we go along instead of a massive change.. which is
> exactly what you've done here so is good..
>
> I'de leave the patch in, now it's marked passed QA it'll pass by Galen
> attention and I'm sure he'll make a sensible decision either way.
>
> Martin
OK
I remember having read
- not to mix reindenting and new code in the same commit
- not to do a patch only for reindenting
So, as this bug changes some behavior in a template file, I think it is
legitimate to add a followup for reindenting the file.
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 15:14:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 14:14:16 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 15:14:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 14:14:20 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23030|0 |1
is obsolete| |
Attachment #23033|0 |1
is obsolete| |
--- Comment #15 from Katrin Fischer ---
Created attachment 23234
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23234&action=edit
[PASSED QA] Bug 11096: force XML syntax for Zconn and remove MARC::File::USMARC
everywhere.
This patch makes Koha <-> Zebra exchange speak XML instead of the
current 'USMARC'. For that, it changes some bits in
- C4::Context->Zconn
- C4::Context-_new_Zconn
Zebra's 'element' variable is set to "marcxml" to match our zebra config files.
References to MARC::File::USMARC::decode are substituted for calls to
the correct one [1] (i.e. MARC::Record::new_from_xml using an explicit
'UTF-8' encoding for the task.
This patch also removes calls to the unsafe ZOOM::Record->render()[2] method.
Due to this last change the code for building facets was rewritten. And for
performance on the facets creation I pushed higher version dependencies for
MARC::File::XML and MARC::Record (we rely on MARC::Field->as_string).
- The FindDuplicates function was MARCXML-ized too.
- Unit tests have been moved to expect MARCXML from Zebra as well.
TODO: relevance still uses USMARC. Need advise on that.
References to MARC::File::USMARC where replaced for the corresponding
MARC::File::XML
counterpart from AuthoritiesMarc.pm.
- Authorities search should work as usual.
- Set dontmerge to see AuthoritiesMarc::merge still works.
Regards
To+
[1] As a side effect some encoding problems got fixed in facets and record
details.
http://search.cpan.org/~gmcharlt/MARC-XML-1.0.1/lib/MARC/File/XML.pm#decode()
[2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#render()
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Katrin Fischer
Testing notes on second patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 15:14:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 14:14:42 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096
--- Comment #16 from Katrin Fischer ---
Created attachment 23235
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23235&action=edit
[PASSED QA] Bug 11096: wrap MARC::Record->new_from_xml call with eval
Catch situations where MARC::Record would croak for bad-formed records.
To test:
- Run prove t/db_dependent/Search.t
- It will fail at test 65 [1]
- Apply the patch, it will warn for some failing records,
but the tests will run smoothly.
Regards
To+
Sponsored-by: Universidad Nacional de Cordoba
[1] a record that cannot be parsed by MARC::Record is simply skipped (bug
10684)
Signed-off-by: Katrin Fischer
- All tests and QA script pass after applying the patch.
- Verfied that sample record is not searchable before applying
patch, but can be searched without problems after applying it.
- Tested authority searching still workds as expected.
- Tested bilbiographic searching still works as expected.
- Simple search, also truncated search terms
- Facetting
- Advanced search, also itemtype and pubyear limits
- Tested dontmerge preference, editing a linked authority and
confirming the change is made to the linked records as well.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 15:16:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 14:16:49 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096
--- Comment #18 from Katrin Fischer ---
Created attachment 23237
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23237&action=edit
[SIGNED OFF] Bug 11096: wrap MARC::Record->new_from_xml call with eval
Catch situations where MARC::Record would croak for bad-formed records.
To test:
- Run prove t/db_dependent/Search.t
- It will fail at test 65 [1]
- Apply the patch, it will warn for some failing records,
but the tests will run smoothly.
Regards
To+
Sponsored-by: Universidad Nacional de Cordoba
[1] a record that cannot be parsed by MARC::Record is simply skipped (bug
10684)
Signed-off-by: Katrin Fischer
- All tests and QA script pass after applying the patch.
- Verfied that sample record is not searchable before applying
patch, but can be searched without problems after applying it.
- Tested authority searching still workds as expected.
- Tested bilbiographic searching still works as expected.
- Simple search, also truncated search terms
- Facetting
- Advanced search, also itemtype and pubyear limits
- Tested dontmerge preference, editing a linked authority and
confirming the change is made to the linked records as well.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 15:16:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 14:16:37 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23234|0 |1
is obsolete| |
Attachment #23235|0 |1
is obsolete| |
--- Comment #17 from Katrin Fischer ---
Created attachment 23236
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23236&action=edit
[SIGNED OFF] Bug 11096: force XML syntax for Zconn and remove
MARC::File::USMARC everywhere.
This patch makes Koha <-> Zebra exchange speak XML instead of the
current 'USMARC'. For that, it changes some bits in
- C4::Context->Zconn
- C4::Context-_new_Zconn
Zebra's 'element' variable is set to "marcxml" to match our zebra config files.
References to MARC::File::USMARC::decode are substituted for calls to
the correct one [1] (i.e. MARC::Record::new_from_xml using an explicit
'UTF-8' encoding for the task.
This patch also removes calls to the unsafe ZOOM::Record->render()[2] method.
Due to this last change the code for building facets was rewritten. And for
performance on the facets creation I pushed higher version dependencies for
MARC::File::XML and MARC::Record (we rely on MARC::Field->as_string).
- The FindDuplicates function was MARCXML-ized too.
- Unit tests have been moved to expect MARCXML from Zebra as well.
TODO: relevance still uses USMARC. Need advise on that.
References to MARC::File::USMARC where replaced for the corresponding
MARC::File::XML
counterpart from AuthoritiesMarc.pm.
- Authorities search should work as usual.
- Set dontmerge to see AuthoritiesMarc::merge still works.
Regards
To+
[1] As a side effect some encoding problems got fixed in facets and record
details.
http://search.cpan.org/~gmcharlt/MARC-XML-1.0.1/lib/MARC/File/XML.pm#decode()
[2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#render()
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Katrin Fischer
Testing notes on second patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 15:28:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 14:28:32 +0000
Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #38 from Paola Rossi ---
Hello, Mathieu.
I apply the patch against master 3.15.00.002.
Rebuilding zebra indexes, an error appears:
Rebuilding zebra indexes against master without patching, the error doesn't
appear.
The two notices, coming from opac.sbn.it:2100, DB nopac, are:
Nilo, antico Nilo / Folco Quilici
Il Nilo / Pier Domenico Boccardi
So I pass the patch to "Failed QA" status.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:13:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 15:13:27 +0000
Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23108|0 |1
is obsolete| |
--- Comment #39 from mathieu saby ---
Created attachment 23238
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23238&action=edit
Bug 11202 - Improve UNIMARC biblio indexing
Sorry :(
It's fixed.
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:13:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 15:13:35 +0000
Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:49:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 15:49:05 +0000
Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric
format
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |gmcharlt at gmail.com
--- Comment #18 from Galen Charlton ---
Pushed to master. Thanks, Oliver!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:59:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 15:59:41 +0000
Subject: [Koha-bugs] [Bug 2693] Tagging: Add filter by name
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |gmcharlt at gmail.com
--- Comment #9 from Galen Charlton ---
Pushed to master. Thanks, Owen!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:06:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 16:06:29 +0000
Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |In Discussion
--- Comment #6 from Jonathan Druart ---
Galen, I suspect you had a mistake on updating the status :) It is not pushed
to master but in discussion.
Maybe should we never display the hour/minutes if it's 23:59?
So we remove the dateonly flag and we don't need a new routine.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:20:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 16:20:54 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
existing orders without warning
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |gmcharlt at gmail.com
--- Comment #40 from Galen Charlton ---
Pushed to master. Thanks, Mathieu!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:22:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 16:22:43 +0000
Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148
--- Comment #7 from Jonathan Druart ---
Created attachment 23239
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23239&action=edit
Bug 11148: Followup only display the hours unless "23:59"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:23:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 16:23:03 +0000
Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148
--- Comment #8 from Jonathan Druart ---
Something like that?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 18:08:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 17:08:07 +0000
Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148
--- Comment #9 from Galen Charlton ---
(In reply to Jonathan Druart from comment #8)
> Something like that?
Not as a default behavior -- I'd prefer that the caller explicitly ask for
(say) date_only or as_due_date, not have the behavior of stripping off "23:59"
be hardcoded. (Also, stripping off "23:59" doesn't work if the timeformat is
12hr).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 19:14:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 18:14:42 +0000
Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display
properly information on parallel form
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |tomascohen at gmail.com
--- Comment #12 from Tom?s Cohen Arazi ---
This patch has been pushed to 3.12.x, will be in 3.12.8.
Thanks Janusz!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 19:16:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 18:16:38 +0000
Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main
entry
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |tomascohen at gmail.com
--- Comment #16 from Tom?s Cohen Arazi ---
This patch has been pushed to 3.12.x, will be in 3.12.8.
Thanks Philippe and congratulations!
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 19:17:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 18:17:14 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |tomascohen at gmail.com
--- Comment #11 from Tom?s Cohen Arazi ---
This patch has been pushed to 3.12.x, will be in 3.12.8.
Thanks Ketan!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 20:19:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 19:19:47 +0000
Subject: [Koha-bugs] [Bug 4533] Add "duplicate item" link when editing items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4533
Peggy Thrasher changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |p.thrasher at dover.nh.gov
--- Comment #3 from Peggy Thrasher ---
We would like this too!
Peggy
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 22:15:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 21:15:44 +0000
Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 22:15:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 21:15:47 +0000
Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23219|0 |1
is obsolete| |
--- Comment #46 from Srdjan Jankovic ---
Created attachment 23240
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23240&action=edit
Bug 11077 - Correct silent warnings in C4/Auth.pm
This gets rid of some more warnings.
It also corrects a noisy ne condition.
$userid = $retuserid if ( $retuserid ne '');
became
$userid = $retuserid if ( $retuserid );
It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's
patch, while correcting the problems found.
This includes:
my $q_userid = $query->param('userid') // '';
along with:
my $s_userid = '';
and:
my $s_userid = $session->param('id') // '';
Indentation does not reflect actual scoping.
A missing system preference would have triggered a ubiquitous
undef compare check failure message. This makes the flooding
message more useful, so as to help correct it.
The change to accomplish this was:
my $pki_field = C4::Context->preference('AllowPKIAuth');
if (!defined($pki_field)) {
print STDERR "Error: Missing AllowPKIAuth System Preference!\n";
$pki_field = 'None';
}
Signed-off-by: Srdjan
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 22:29:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 21:29:04 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gmcharlt at gmail.com
--- Comment #1 from Galen Charlton ---
Not just notes -- most of the fields in the suggestion form (except for title)
aren't using the Template Toolkit HTML filter. A combination of using
C4::Scrubber and the HTML TT filter should provide belts and suspenders.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:15:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 22:15:00 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |chris at bigballofwax.co.nz
Severity|major |critical
--- Comment #2 from Chris Cormack ---
Working on some patches for this now
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:36:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 22:36:59 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
--- Comment #3 from Chris Cormack ---
Created attachment 23241
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23241&action=edit
Bug 11322 : XSS in suggestions
To test
1/ Switch on purchase suggestions
2/ On the public interface (OPAC) add a suggestion, put html in every
field
3/ In the staff interface go to the suggestions page
/cgi-bin/koha/suggestion/suggestion.pl
4/ Notice the html is rendered
5/ Click on a suggestion, notice the html is rendered on the show page
also
6/ Apply the patch, check these two pages again, html should now be
escaped
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:48:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 22:48:30 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
--- Comment #4 from Chris Cormack ---
Created attachment 23242
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23242&action=edit
Bug 11322 : XSS in suggestions - OPAC
1/ Add a suggestion in the opac, with lots of html
2/ View that suggestion in the OPAC, note the html is rendering
3/ Apply the patch
4/ Test again, in prog and bootstrap, no more rendered html
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:53:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 22:53:12 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23241|0 |1
is obsolete| |
--- Comment #5 from David Cook ---
Created attachment 23243
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23243&action=edit
Bug 11322 : XSS in suggestions
To test
1/ Switch on purchase suggestions
2/ On the public interface (OPAC) add a suggestion, put html in every
field
3/ In the staff interface go to the suggestions page
/cgi-bin/koha/suggestion/suggestion.pl
4/ Notice the html is rendered
5/ Click on a suggestion, notice the html is rendered on the show page
also
6/ Apply the patch, check these two pages again, html should now be
escaped
Signed-off-by: David Cook
Works as described.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:04:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:04:23 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:04:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:04:26 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
--- Comment #6 from Chris Cormack ---
Created attachment 23244
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23244&action=edit
Bug 11322 : XSS - Scrub bad data before storing suggestions in the db
1/ In the public interface, add a suggestion containing html
2/ Save, notice the html is rendered (or if you have the other patches
is displayed)
3/ Apply this paget
4/ Add another suggestion
5/ Notice the html is stripped
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:08:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:08:46 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23242|0 |1
is obsolete| |
--- Comment #7 from David Cook ---
Created attachment 23245
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23245&action=edit
Bug 11322 : XSS in suggestions - OPAC
1/ Add a suggestion in the opac, with lots of html
2/ View that suggestion in the OPAC, note the html is rendering
3/ Apply the patch
4/ Test again, in prog and bootstrap, no more rendered html
Signed-off-by: David Cook
Works as described.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:12:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:12:14 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23244|0 |1
is obsolete| |
--- Comment #8 from David Cook ---
Created attachment 23246
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23246&action=edit
Bug 11322 : XSS - Scrub bad data before storing suggestions in the db
1/ In the public interface, add a suggestion containing html
2/ Save, notice the html is rendered (or if you have the other patches
is displayed)
3/ Apply this paget
4/ Add another suggestion
5/ Notice the html is stripped
Signed-off-by: David Cook
Works as described.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:12:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:12:35 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:16:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:16:11 +0000
Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232
--- Comment #4 from David Cook ---
(In reply to mathieu saby from comment #3)
> Note that there is currently a big issue for UNIMARC facets:
> the facet build on type of document (equivalent of 942 in MARC21) is not
> visible.
>
> That's because some libraries use 099$t for that, and others use other
> fields like 210$b that are not made for that.
> That was the main goal of my not-yet-written-patch for make facets
> customisable...
>
> But maybe it could be fixed by telling UNIMARC ppl that from 3.16 version
> onwards the type of document is stored in 099t, and provide a script for
> copying types of documents from other fields to this one for non standard
> configuration.
>
> Mathieu
With zebra facets, it uses the index. So if both those marc tags are filling
the same index, it should be fine.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:28:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:28:09 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and
detail with Amazon images on https
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944
--- Comment #9 from Katrin Fischer ---
I have followed the instructions and set up https, but I am confused by the
results:
OPAC
Still running on localhost:8080, but the Amazon cover URL appears as https://
on the results page and on the details page.
Intranet
Now working with localhost and 442, but the Amazon cover URL is still http://
on the results and the details page.
Liz, can you please check?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:47:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:47:51 +0000
Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232
--- Comment #5 from mathieu saby ---
(In reply to David Cook from comment #4)
> (In reply to mathieu saby from comment #3)
> > Note that there is currently a big issue for UNIMARC facets:
> > the facet build on type of document (equivalent of 942 in MARC21) is not
> > visible.
> >
> > That's because some libraries use 099$t for that, and others use other
> > fields like 210$b that are not made for that.
> > That was the main goal of my not-yet-written-patch for make facets
> > customisable...
> >
> > But maybe it could be fixed by telling UNIMARC ppl that from 3.16 version
> > onwards the type of document is stored in 099t, and provide a script for
> > copying types of documents from other fields to this one for non standard
> > configuration.
> >
> > Mathieu
>
> With zebra facets, it uses the index. So if both those marc tags are filling
> the same index, it should be fine.
I did not think of it... Of course ;-)
So, it will really be a nice improvement for 3.16 if Zebra facets could be
used.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:49:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:49:42 +0000
Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232
--- Comment #6 from David Cook ---
I'm outlining below a rough guide to how to enable Zebra facetting. Note that
this has nothing to do with Koha per se. This is just about setting up Zebra.
The actual Koha code to make use of Zebra's facets will have to come after
initial setup, and at the moment it's just not at the top of my list of
priorities.
First, take stock of which version of Koha you're running and note which type
of indexing you're using (DOM or GRS1).
Look for these two files in your /etc/zebradb/ folder:
"retrieval-info-bib-dom.xml"
"retrieval-info-bib-grs1.xml"
If you can't find them, you're probably running an older version of Koha and
you'll want to modify your "koha-conf.xml". If you do find them, the config in
"koha-conf.xml" is only a fallback, so not necessary for testing.
Step One:
a) Edit the file that suits your version of Koha and method of indexing.
(i.e. if you're running the latest Koha with dom, edit
"retrieval-info-bib-dom.xml". If you're running the latest Koha with grs1, edit
"retrieval-info-bib-grs1.xml". If you're running an older version of Koha,
you're only using grs1 and you'll need to edit "koha-conf.xml"
Step Two:
a) Add lines like the following as children to the "" node (N.B.
do not add them to the top as they will displace the default retrieval syntax
setting. Add them at the bottom.):
(N.B. Paul Poulain mentioned that the "0" register is a "raw"(?) register and
that this should be used if you have issues with diacritics or non-Latin
characters. I imagine that this needs to be set up in your records.abs or DOM
XSLT.)
(N.B. You can substitute any index in for "any" or "title". You can also use
any register instead of "w" or "0", such as "p".)
Step Three:
a) Restart your Zebra server
Step Four:
a) Connect to Zebra using yaz-client (e.g. yaz-client open
"unix:/zebra/test/var/run/zebradb/bibliosocket")(You can find your specific
path by looking at the top of koha-conf.xml for a "listen" node with an ID of
"biblioserver")
b) Tell Zebra to use facets (e.g. elements zebra::facet::any:w,title:w,title:0)
c) Do a search (e.g. find test)
d) Show your results (e.g. show 1+1)
e) You should now see a list of facets for your search results
--
If you have any issues with these instructions, comment here, find me in the
IRC channel or visit the sites that I'm linking below.
--
For more information, visit the following links:
http://www.indexdata.com/zebra/doc/zebra.pdf (Search in the document for
"facet")
http://lists.indexdata.dk/pipermail/zebralist/2007-July/001682.html (This is a
discussion of setting up Zebra facets)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:51:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:51:03 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
--- Comment #9 from Katrin Fischer ---
Created attachment 23247
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23247&action=edit
[PASSED QA] Bug 11322 : XSS in suggestions
To test
1/ Switch on purchase suggestions
2/ On the public interface (OPAC) add a suggestion, put html in every
field
3/ In the staff interface go to the suggestions page
/cgi-bin/koha/suggestion/suggestion.pl
4/ Notice the html is rendered
5/ Click on a suggestion, notice the html is rendered on the show page
also
6/ Apply the patch, check these two pages again, html should now be
escaped
Signed-off-by: David Cook
Works as described.
Signed-off-by: Katrin Fischer
Passes all tests, thx Chris!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:51:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:51:07 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
--- Comment #10 from Katrin Fischer ---
Created attachment 23248
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23248&action=edit
[PASSED QA] Bug 11322 : XSS in suggestions - OPAC
1/ Add a suggestion in the opac, with lots of html
2/ View that suggestion in the OPAC, note the html is rendering
3/ Apply the patch
4/ Test again, in prog and bootstrap, no more rendered html
Signed-off-by: David Cook
Works as described.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:51:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:51:10 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
--- Comment #11 from Katrin Fischer ---
Created attachment 23249
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23249&action=edit
[PASSED QA] Bug 11322 : XSS - Scrub bad data before storing suggestions in the
db
1/ In the public interface, add a suggestion containing html
2/ Save, notice the html is rendered (or if you have the other patches
is displayed)
3/ Apply this paget
4/ Add another suggestion
5/ Notice the html is stripped
Signed-off-by: David Cook
Works as described.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:51:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:51:52 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |katrin.fischer at bsz-bw.de
Patch complexity|Trivial patch |Small patch
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:51:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:51:54 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23243|0 |1
is obsolete| |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:51:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:51:57 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23245|0 |1
is obsolete| |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:51:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:51:59 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23246|0 |1
is obsolete| |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 00:58:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Dec 2013 23:58:07 +0000
Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232
--- Comment #7 from David Cook ---
Also note that you will have to individually set up each index that you want to
use for facet queries.
As per this email from an IndexData person:
http://lists.indexdata.dk/pipermail/zebralist/2007-July/001694.html
In general, this shouldn't case a problem, since we only use a short list of
facets. However, it would create a barrier to allowing users to customize their
results.
In theory, we could list all or most of the available indexes in the Zebra
config files. Then, we could use a system preference or a DB table to choose
which indexes we want to use for facets. This would generate the "elements"
string that we pass to Zebra everytime we want our facets.
Actually, now that I think about it...that might not be a bad idea. We already
have that Search.pm sub where we're manually keeping track of indexes, so we
could keep that or use something similar to fill an HTML list and have that
create our Zebra facet string.
So long as we generate the string once and then use it multiple times...that
should be all right. We could also have a hardcoded fallback string in case
someone deletes the facet config in Koha or if their facet config is bad.
Hmm. Ideas. Ideas. Ideas...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 01:09:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 00:09:52 +0000
Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232
--- Comment #8 from Jared Camins-Esakov ---
(In reply to David Cook from comment #7)
> Also note that you will have to individually set up each index that you want
> to use for facet queries.
>
> As per this email from an IndexData person:
> http://lists.indexdata.dk/pipermail/zebralist/2007-July/001694.html
>
> In general, this shouldn't case a problem, since we only use a short list of
> facets. However, it would create a barrier to allowing users to customize
> their results.
This has to be changed in two places. In the server elements configuration, as
described at that link, *and* an additional index has to be configured for each
facet.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 01:12:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 00:12:45 +0000
Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
--- Comment #9 from M. Tompsett ---
Could not this bug just get the zebra facets working, and then whatever needs
to be done to filter be worked on in bug 10891?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 01:16:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 00:16:05 +0000
Subject: [Koha-bugs] [Bug 10891] Make facets customisable
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
--- Comment #25 from M. Tompsett ---
(In reply to mathieu saby from comment #2)
> Hi Frederic
> I was thinking of a syspref first. It would be easier for me to do (2
> sysprefs in fact, one for unimarc, the other for marc21/normarc)
A Koha system can't be both unimarc and marc21/normarc at the same time. Why
would you need two?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 01:23:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 00:23:03 +0000
Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be
sanitized or escaped
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #12 from Galen Charlton ---
Pushed to master. Thanks, Chris!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 02:55:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 01:55:50 +0000
Subject: [Koha-bugs] [Bug 11330] New: Inconsistent field/subfield
descriptions on MARC21 bibliographic frameworks
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330
Bug ID: 11330
Summary: Inconsistent field/subfield descriptions on MARC21
bibliographic frameworks
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: MARC Bibliographic data support
Assignee: gmcharlt at gmail.com
Reporter: bgkriegel at gmail.com
QA Contact: testopia at bugs.koha-community.org
There are many inconsistencies on field/subfield descriptions on MARC21
bibliographic frameworks.
That fact makes very hard to translate frameworks accurately using an automated
procedure
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 02:56:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 01:56:09 +0000
Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on
MARC21 bibliographic frameworks
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|gmcharlt at gmail.com |bgkriegel at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 04:32:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 03:32:19 +0000
Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search,
multiple branch security mod
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23038|0 |1
is obsolete| |
--- Comment #21 from M. Tompsett ---
Created attachment 23250
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23250&action=edit
Bug 9055: Mandumah.com's multiple branch search, multiple branch security mod
This mod creates the ability to search multiple branches using
a jquery dropdown, instead of just one or all branches.
This mod also replaces SearchMyLibraryFirst preference, giving
three options:
All = no change from standard koha setup.
Preferhome = Prefers patron's home library
(others may be searched), koha's current
functionality of SearchMyLibraryFirst.
Securehome = Only patrons' home library and other assigned
libraries (if any) can be searched.
With multiple instances of branchcode inside Borrower extended
attributes, a patron can be given multiple branches to search
within. The Securehome concept also includes the branch given
in the apache enviroment of the host/virtualhost contacted,
from OPAC_SEARCH_LIMIT = "branch: blah"
This patch not only filters the GetBranches results, filtering
the patrons ability to see other branches other than the ones
given, it also filters the branches given in the limit branch:
search options, so that even if a user manually inputted a
branch, they are still only getting what they are ment to get.
This enhancement would be useful for big libraries, in which
its members would be restricted to searching and borrowing
from a subset of its books.
Overall, the multiple branch search dropdown should prove
useful, even with unsecure installations. What is not included
yet, is a method to decide what branches to show to a guest,
not-logged-in, user.
To use this patch, you need to create a branchcode Patron
Extended Attribute, and have the patron your working with,
have one or more branchcode extended attributes.
So, total branches that patron will get:
OPAC_SEARCH_LIMIT branch + Patron record home branch
+ whatever branchcodes you put into Borrower_attributes.
You also need to set the preferences. The three new preferences
to set are:
- OPAC: SearchableBranches
- Patrons: multibranch
- Searching: MultiBranchSelect
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 04:34:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 03:34:24 +0000
Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search,
multiple branch security mod
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23250|0 |1
is obsolete| |
--- Comment #22 from M. Tompsett ---
Created attachment 23251
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23251&action=edit
Bug 9055: Mandumah.com's multiple branch search, multiple branch security mod
This mod creates the ability to search multiple branches using
a jquery dropdown, instead of just one or all branches.
This mod also replaces SearchMyLibraryFirst preference, giving
three options:
All = no change from standard koha setup.
Preferhome = Prefers patron's home library
(others may be searched), koha's current
functionality of SearchMyLibraryFirst.
Securehome = Only patrons' home library and other assigned
libraries (if any) can be searched.
With multiple instances of branchcode inside Borrower extended
attributes, a patron can be given multiple branches to search
within. The Securehome concept also includes the branch given
in the apache enviroment of the host/virtualhost contacted,
from OPAC_SEARCH_LIMIT = "branch: blah"
This patch not only filters the GetBranches results, filtering
the patrons ability to see other branches other than the ones
given, it also filters the branches given in the limit branch:
search options, so that even if a user manually inputted a
branch, they are still only getting what they are ment to get.
This enhancement would be useful for big libraries, in which
its members would be restricted to searching and borrowing
from a subset of its books.
Overall, the multiple branch search dropdown should prove
useful, even with unsecure installations. What is not included
yet, is a method to decide what branches to show to a guest,
not-logged-in, user.
To use this patch, you need to create a branchcode Patron
Extended Attribute, and have the patron your working with,
have one or more branchcode extended attributes.
So, total branches that patron will get:
OPAC_SEARCH_LIMIT branch + Patron record home branch
+ whatever branchcodes you put into Borrower_attributes.
You also need to set the preferences. The three new preferences
to set are:
- OPAC: SearchableBranches
- Patrons: multibranch
- Searching: MultiBranchSelect
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 04:35:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 03:35:27 +0000
Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search,
multiple branch security mod
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23251|0 |1
is obsolete| |
--- Comment #23 from M. Tompsett ---
Created attachment 23252
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23252&action=edit
Bug 9055: Mandumah.com's multiple branch search, multiple branch security mod
This mod creates the ability to search multiple branches using
a jquery dropdown, instead of just one or all branches.
This mod also replaces SearchMyLibraryFirst preference, giving
three options:
All = no change from standard koha setup.
Preferhome = Prefers patron's home library
(others may be searched), koha's current
functionality of SearchMyLibraryFirst.
Securehome = Only patrons' home library and other assigned
libraries (if any) can be searched.
With multiple instances of branchcode inside Borrower extended
attributes, a patron can be given multiple branches to search
within. The Securehome concept also includes the branch given
in the apache enviroment of the host/virtualhost contacted,
from OPAC_SEARCH_LIMIT = "branch: blah"
This patch not only filters the GetBranches results, filtering
the patrons ability to see other branches other than the ones
given, it also filters the branches given in the limit branch:
search options, so that even if a user manually inputted a
branch, they are still only getting what they are ment to get.
This enhancement would be useful for big libraries, in which
its members would be restricted to searching and borrowing
from a subset of its books.
Overall, the multiple branch search dropdown should prove
useful, even with unsecure installations. What is not included
yet, is a method to decide what branches to show to a guest,
not-logged-in, user.
To use this patch, you need to create a branchcode Patron
Extended Attribute, and have the patron your working with,
have one or more branchcode extended attributes.
So, total branches that patron will get:
OPAC_SEARCH_LIMIT branch + Patron record home branch
+ whatever branchcodes you put into Borrower_attributes.
You also need to set the preferences. The three new preferences
to set are:
- OPAC: SearchableBranches
- Patrons: multibranch
- Searching: MultiBranchSelect
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 05:31:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 04:31:53 +0000
Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search,
multiple branch security mod
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23252|0 |1
is obsolete| |
--- Comment #24 from M. Tompsett ---
Comment on attachment 23252
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23252
Bug 9055: Mandumah.com's multiple branch search, multiple branch security mod
I think my description is a little cleaner, but I've left the patch which I
think is the one to rebase, and debug. Sadly, it failed to give me results:
opac
search
happy - all libraries
result count: (note the number)
advanced search
keyword = happy
go to the library dropdown and select all then click search.
BUSTED!
All and Securehome settings busted. Preferhome works with my current system
preference settings. Have fun debugging.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 05:32:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 04:32:18 +0000
Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search,
multiple branch security mod
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 09:13:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 08:13:31 +0000
Subject: [Koha-bugs] [Bug 10891] Make facets customisable
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891
--- Comment #26 from mathieu saby ---
(In reply to M. Tompsett from comment #25)
> (In reply to mathieu saby from comment #2)
> > Hi Frederic
> > I was thinking of a syspref first. It would be easier for me to do (2
> > sysprefs in fact, one for unimarc, the other for marc21/normarc)
>
> A Koha system can't be both unimarc and marc21/normarc at the same time. Why
> would you need two?
Some facets can have sense in a unimarc system, other in a marc21 system (some
coded fields only exists in unimarc, some new rda fields only exists in marc21
etc...)
But you are right, I suppose we could have unique syspref with different
content, depending on marcflavor choosen when you install Koha.
Anyway, with the global rewriting of facets, I don't know if the idea of
storing facets in a syspref will still be interesting.
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 09:16:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 08:16:00 +0000
Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232
--- Comment #10 from mathieu saby ---
> Actually, now that I think about it...that might not be a bad idea. We
> already have that Search.pm sub where we're manually keeping track of
> indexes, so we could keep that or use something similar to fill an HTML list
> and have that create our Zebra facet string.
>
I thought this list of index in search.pm was going to be deprecated with the
adoption of QueryParser ?
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 09:18:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 08:18:23 +0000
Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232
--- Comment #11 from mathieu saby ---
(In reply to David Cook from comment #6)
> I'm outlining below a rough guide to how to enable Zebra facetting. Note
> that this has nothing to do with Koha per se. This is just about setting up
> Zebra. The actual Koha code to make use of Zebra's facets will have to come
> after initial setup, and at the moment it's just not at the top of my list
> of priorities.
>
> First, take stock of which version of Koha you're running and note which
> type of indexing you're using (DOM or GRS1).
>
> Look for these two files in your /etc/zebradb/ folder:
> "retrieval-info-bib-dom.xml"
> "retrieval-info-bib-grs1.xml"
>
> If you can't find them, you're probably running an older version of Koha and
> you'll want to modify your "koha-conf.xml". If you do find them, the config
> in "koha-conf.xml" is only a fallback, so not necessary for testing.
>
>
> Step One:
> a) Edit the file that suits your version of Koha and method of indexing.
> (i.e. if you're running the latest Koha with dom, edit
> "retrieval-info-bib-dom.xml". If you're running the latest Koha with grs1,
> edit "retrieval-info-bib-grs1.xml". If you're running an older version of
> Koha, you're only using grs1 and you'll need to edit "koha-conf.xml"
>
> Step Two:
> a) Add lines like the following as children to the "" node
> (N.B. do not add them to the top as they will displace the default retrieval
> syntax setting. Add them at the bottom.):
>
>
>
>
>
> (N.B. Paul Poulain mentioned that the "0" register is a "raw"(?) register
> and that this should be used if you have issues with diacritics or non-Latin
> characters. I imagine that this needs to be set up in your records.abs or
> DOM XSLT.)
>
> (N.B. You can substitute any index in for "any" or "title". You can also use
> any register instead of "w" or "0", such as "p".)
>
> Step Three:
> a) Restart your Zebra server
>
> Step Four:
> a) Connect to Zebra using yaz-client (e.g. yaz-client open
> "unix:/zebra/test/var/run/zebradb/bibliosocket")(You can find your specific
> path by looking at the top of koha-conf.xml for a "listen" node with an ID
> of "biblioserver")
>
> b) Tell Zebra to use facets (e.g. elements
> zebra::facet::any:w,title:w,title:0)
> c) Do a search (e.g. find test)
> d) Show your results (e.g. show 1+1)
> e) You should now see a list of facets for your search results
>
> --
>
> If you have any issues with these instructions, comment here, find me in the
> IRC channel or visit the sites that I'm linking below.
>
> --
>
> For more information, visit the following links:
>
> http://www.indexdata.com/zebra/doc/zebra.pdf (Search in the document for
> "facet")
>
> http://lists.indexdata.dk/pipermail/zebralist/2007-July/001682.html (This is
> a discussion of setting up Zebra facets)
As DOM is now the new standard way of indexing, and GRS1 is going to be
deprecated, maybe the work could be made only for DOM files?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:19:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 10:19:42 +0000
Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:19:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 10:19:46 +0000
Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23239|0 |1
is obsolete| |
--- Comment #10 from Jonathan Druart ---
Created attachment 23253
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23253&action=edit
Bug 11148: Add a as_due_date parameter to the output_pref routine
This parameter is a boolean, if true, the hours won't be displayed if
the time is 23:59 (24hr format) or 11:59 PM (12hr format).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:59:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 10:59:42 +0000
Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions:
force_checkout and lift_restriction
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #34 from Jonathan Druart ---
(In reply to mathieu saby from comment #33)
> All these operations were possible with the permission (and with some
> choices in sysprefs), and not possible without, except one operation :
> checking out a document marked "PEGI 12" to a 4 year child
> (I mapped biblioitems.agerestricted with 301a field, set the preference
> AgeRestrictionMarker with "PEGI", and AgeRestrictionOverride to "Don't
> allow")
Thanks for testing Mathieu!
The AgeRestrictionOverride pref has to be set to "Allow" if you want to
override the age restriction, even if the new permission is set.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:12:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:12:40 +0000
Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions:
force_checkout and lift_restriction
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #22717|0 |1
is obsolete| |
--- Comment #35 from mathieu saby ---
Created attachment 23254
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23254&action=edit
[PATCH][SIGNED OFF] Bug 10863: Add 2 circulation permissions: force_checkout
and lift_restriction
Ok, so I sign off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:12:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:12:49 +0000
Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions:
force_checkout and lift_restriction
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:26:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:26:21 +0000
Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on
MARC21 bibliographic frameworks
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #1 from Katrin Fischer ---
I think for consistency it also makes sense to have the descriptions the same
on each framework. But also it will be really nice to have the marc frameworks
nicely translatable with po files.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:26:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:26:58 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
--- Comment #6 from Jonathan Druart ---
Created attachment 23255
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23255&action=edit
Bug 11209: Check if a notice has been already sent today
The previous patch checks if a notice has already been sent when the
current notices has been sent in queue. Which is wrong!
We have to check if a similar notice has been sent today.
This patch has been created after an observation on a production server:
If a user place on holds several items, he will receive 1 SMS per hold.
Here we only want 1 SMS for all holds.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:32:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:32:15 +0000
Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232
--- Comment #12 from Katrin Fischer ---
I think it would be possible to agree that this is only done for DOM, as we are
trying to phase out/deprecate GRS-1.
There are some bugs in QueryParser that I would like to see addressed before we
make it the standard (for example bug 10542).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:32:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:32:45 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
--- Comment #7 from mathieu saby ---
And it still depends on 11208?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:35:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:35:52 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
race condition during full rebuilds
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078
--- Comment #35 from Katrin Fischer ---
Doug, is this ready for sign off/QA with your follow ups? You can switch the
status :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:38:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:38:42 +0000
Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538
--- Comment #11 from Katrin Fischer ---
I am moving this to failed QA - see questions and notes in comment 10.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:38:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:38:49 +0000
Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:44:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:44:23 +0000
Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331
Colin Campbell changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |colin.campbell at ptfs-europe.
| |com
--- Comment #5 from Colin Campbell ---
Created attachment 23256
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23256&action=edit
Supplementary patch
The main patch removes the field but DelItem still attempts to populate it
supplementary patch to remove that
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:45:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:45:04 +0000
Subject: [Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate
that profile marcfields are required
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:45:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:45:08 +0000
Subject: [Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate
that profile marcfields are required
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #21303|0 |1
is obsolete| |
Attachment #21304|0 |1
is obsolete| |
--- Comment #13 from Katrin Fischer ---
Created attachment 23257
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23257&action=edit
[PASSED QA] Bug 5031: CSV profiles: content fields are required
Some fields are required on editing/adding csv profiles.
Test plan:
- add a new csv profile (tools/csv-profiles.pl) without any value.
- save => error on empty fields.
- fill the "marc" content, select type="sql", fill the csv name input.
- save => error on sql content field.
- fill the sql content
- save => the csv profile is saved.
- retry for the edit form.
Signed-off-by: Bernardo Gonzalez Kriegel
Comment: On top of both patches for Bug 10853
Works very well, now we get an alert with empty field
Saves correctly MARC and SQL profiles
Solved minor conflict introduced by tab followup on Bug 10853
Again small tab errors corrected in followup
Signed-off-by: Katrin Fischer
Works as described, looks a bit 'non standard' for Koha,
but improves usability of the form.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:45:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:45:29 +0000
Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow
search in 'all libraries'
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mathieu.saby at univ-rennes2.f
| |r
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:46:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:46:02 +0000
Subject: [Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate
that profile marcfields are required
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031
--- Comment #14 from Katrin Fischer ---
Created attachment 23258
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23258&action=edit
[PASSED QA] Bug 5031 - followup to correct tabs
Signed-off-by: Bernardo Gonzalez Kriegel
Signed-off-by: Katrin Fischer
Tiny QA follow-up corrcting whitespace to match coding
guidelines.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:48:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:48:06 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
--- Comment #8 from Jonathan Druart ---
yes, it is just a followup
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:49:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:49:34 +0000
Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #6 from Martin Renvoize ---
This patch needs a followup to remove any references in code to the marc column
in deleteditems.
I spotted one in C4/Items.pm at least. I'm also wondering if this affects the
output of tools/export.pl (or rather assume it affects) so that will need
correcting to.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:50:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:50:04 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
--- Comment #9 from Jonathan Druart ---
In fact, it is not a code dependency, more a functionality dependency.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:51:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:51:18 +0000
Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331
--- Comment #7 from Martin Renvoize ---
Looks like Colin did the first followup I wanted whilst I was failing.. can
someone take care of the second one?
I'll then nudge Katrin to do QA as with Colin's input I no longer can..
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:59:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:59:01 +0000
Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin
jquery.hotkeys.min.js
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:59:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:59:05 +0000
Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin
jquery.hotkeys.min.js
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #22415|0 |1
is obsolete| |
Attachment #22416|0 |1
is obsolete| |
--- Comment #9 from Katrin Fischer ---
Created attachment 23259
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23259&action=edit
[PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js
To old plugin prevents the upgrade to the latest jquery. By replacing with
openjs' shortcut.js, we have now one less hurdle in upgrading Koha to latest.
Changes:
- removed jquery.hotkeys.min.js
- added shortcut.js
- modified the related includes (doc-head-close.inc and help-top.inc)
- modified the calls in staff-global.js
Regression test:
1) apply the patch
2) in the intranet, test the shortcuts alt-q, alt-r, alt-u.
These are the only affected functionalities. There is no new functionnality.
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
Passes all tests and QA script. Tested existing
shortcuts for the search bar tabs on various circulation
related pages.
This uses a Javascript under BSD license, I wonder if it
should be listed in the About>licenses section that we
are using it. As Yui is also BSD I assume the license is
compatible.
+/**
+ * http://www.openjs.com/scripts/events/keyboard_shortcuts/
+ * Version : 2.01.B
+ * By Binny V A
+ * License : BSD
+ */
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:59:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 11:59:18 +0000
Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin
jquery.hotkeys.min.js
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23259|0 |1
is obsolete| |
--- Comment #10 from Katrin Fischer ---
Created attachment 23260
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23260&action=edit
[PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js
Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced it
but I couldn't find ANY usage of it to fix.
Rebased and fixed.
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:00:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 12:00:44 +0000
Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin
jquery.hotkeys.min.js
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23259|1 |0
is obsolete| |
CC| |katrin.fischer at bsz-bw.de
--- Comment #11 from Katrin Fischer ---
Comment on attachment 23259
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23259
[PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js
Please have different subjects on various patches - or git bz automatically
obsoletes the first when attaching the second :)
Also, Galen - please can you take a look at my note on the first patch before
pushing?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:06:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 12:06:21 +0000
Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #8 from Martin Renvoize ---
Setting back to Needs Signoff, I've gone through the code and don't think the
third followup is required.. I believe the marc column is grabbed from
biblioitems in the join so this isn't a regression.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:09:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 12:09:04 +0000
Subject: [Koha-bugs] [Bug 9811] Patrons search improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811
--- Comment #72 from Jonathan Druart ---
(In reply to mathieu saby from comment #70)
> Hi Jonathan
>
> 3 remarks:
>
> - there is a little conflict (I solved it on my VM)
I will submit a rebased patch.
> - when I click on A to see all the patrons with name begining with A, I am
> automatically redirected to the card of the only patron whose name begins
> with A.
> Is it a wanted behavior?
When the table has only 1 result, the patron detail page is displayed.
> - when I try to sort the table according to names or cardnumber, the sorting
> is quite slow. It's surprizing, because I only have 10 patrons in my test
> base. So I fear the results will be worse with a real base. Maybe it's an
> issue of my computer, but do you think there is some part of code to
> optimize?
With 3.7k patrons, I get a response in 600ms.
> - Is there a way to cancel a filter when it is too restrictive? or to cancel
> all filters?
I don't understand. The filters on the left can be canceled on choosing the
first entry 'all/any'.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:09:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 12:09:39 +0000
Subject: [Koha-bugs] [Bug 9811] Patrons search improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #22265|0 |1
is obsolete| |
--- Comment #73 from Jonathan Druart ---
Created attachment 23261
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23261&action=edit
Bug 9811: Patron search improvement
Rebased patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:41:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 12:41:32 +0000
Subject: [Koha-bugs] [Bug 11249] Add db indexes on borrowers names
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:41:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 12:41:35 +0000
Subject: [Koha-bugs] [Bug 11249] Add db indexes on borrowers names
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23223|0 |1
is obsolete| |
--- Comment #4 from Katrin Fischer ---
Created attachment 23262
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23262&action=edit
[PASSED QA] Bug 11249 - Add db indexes on borrowers names
The borrowers search is by default on columns surname, firstname, othernames
and cardnumber.
(See C4::Members::_express_member_find).
Addind db indexes will really increase the query speed.
This patch adds bd indexes on surname, firstname, othernames (cardnumber has
already an index).
Those indexes must be defined with a size because columns are mediumtext.
Test plan :
Test with mysql client :
mysql> explain select * from borrowers where surname like 'A%';
+----+-------------+-----------+-------+---------------+-------------+---------+------+------+-------------+
| id | select_type | table | type | possible_keys | key | key_len
| ref | rows | Extra |
+----+-------------+-----------+-------+---------------+-------------+---------+------+------+-------------+
| 1 | SIMPLE | borrowers | range | surname_idx | surname_idx | 767
| NULL | 395 | Using where |
+----+-------------+-----------+-------+---------------+-------------+---------+------+------+-------------+
=> key show the index is used
Signed-off-by: Mathieu Saby
Signed-off-by: Katrin Fischer
Works as described, changes from updatedatabase and in kohastructure match.
I think deletedborrowers can be left out, as it's not queried when doing
patron searches. Patron deletes still work as expected.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:50:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 12:50:09 +0000
Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #47 from M. de Rooy ---
Thanks, Srdjan.
Mark, could you please add your signoff too?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:50:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 12:50:50 +0000
Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:53:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 12:53:50 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and
detail with Amazon images on https
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #10 from Martin Renvoize ---
I think I've got to the bottom of why I couldn't get this to work.. It's not
implemented in the bootstrap theme. Could someone do a follow-up with bootstrap
support please?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 14:22:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 13:22:01 +0000
Subject: [Koha-bugs] [Bug 8125] SIP should send Zipcode with address
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8125
--- Comment #15 from Kyle M Hall ---
Created attachment 23263
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23263&action=edit
Bug 8215 - Course Reserves - Omnibus - v3.12.07
Bug 8215 - Course Reserves
Adds a course reserves system for academic libraries.
The course reserves system allows libraries to create courses
and put items on reserves for those courses.
Each item with at least one reserve can have some of its attributes
modified while it is on reserve for at least one active course.
These attributes include item type, collection code, shelving location,
and holding library. If there are no active courses with this item
on reserve, it's attributes will revert to the original attributes
it had before going on reserve.
Test Plan:
1) Create new authorised value categories DEPARTMENT and TERM
2) Create a new course, add instructors to that course.
3) Reserve items for that course, verify item attributes have changed.
4) Disable course, verify item attributes have reverted.
5) Enable course again, verify item attributes again.
6) Delete course, verify item attributes again.
7) Create two new courses, add the same item(s) to both courses.
8) Disable one course, verify item attributes have not reverted.
9) Disable both courses, verify item attributes have reverted.
10) Enable one course, verify item attributes are again set to the
new values.
11) Edit reserve item attributes, verify.
12) Disable all courses, edit reserve item attributes, verify
the item itself still has its original attributes, verify
the reserve item attributes have been updated.
13) Verify the ability to remove instructors from a course.
14) Verify new permissions, top level coursereserves, with
subpermissions add_reserves and delete_reserves.
Signed-off-by: Kyle M Hall
Signed-off-by: Corinne Bulac
Signed-off-by: Jonathan Druart
http://bugs.koha-community.org/show_bug.cgi?id=8125
Bug 8215 follow-up encoding for branches & itemtypes
Signed-off-by: Kyle M Hall
Signed-off-by: Corinne Bulac
Signed-off-by: Jonathan Druart
Bug 8215: Followup FIX QA issues
Signed-off-by: Kyle M Hall
Signed-off-by: Jonathan Druart
Bug 8215 - Add Course Reserves - QA Followup
Signed-off-by: Kyle M Hall
Signed-off-by: Jonathan Druart
Bug 8215: Followup Fix confirmation links for delete course and item
Signed-off-by: Kyle M Hall
Signed-off-by: Jonathan Druart
Bug 8215: FIX ergonomic issue : 'Unchanged()'
bug 8215: (followup) run new files through perltidy
Signed-off-by: Galen Charlton
Signed-off-by: Kyle M Hall
bug 8215: (followup) make sure C4::CourseReserves doesn't export anything
New modules should not export any symbols by default
without a very good reason.
Signed-off-by: Galen Charlton
Signed-off-by: Kyle M Hall
bug 8215: (followup) don't allow deleting course reserves from OPAC
Signed-off-by: Galen Charlton
Signed-off-by: Kyle M Hall
bug 8215: (followup) avoid SQL syntax error in logs
ModItem currently will attempt to update an item
even if no field updates are specified. This patch
avoids (harmless) error messages in the Apache
logs if an item is not actually being changed when it
is placed or taken off reserve.
Signed-off-by: Galen Charlton
Signed-off-by: Kyle M Hall
bug 8215: (followup) rename GetItemReservesInfo
Renamed that routine to GetItemCourseReservesInfo in
order to avoid any potential confusion with reserves
qua hold requests.
Signed-off-by: Galen Charlton
Signed-off-by: Kyle M Hall
bug 8215: (followup) remove extraneous underscore in template
Signed-off-by: Galen Charlton
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 14:22:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 13:22:44 +0000
Subject: [Koha-bugs] [Bug 8125] SIP should send Zipcode with address
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8125
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23263|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 14:22:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Dec 2013 13:22:55 +0000
Subject: [Koha-bugs] [Bug 8215] Add Course Reserves
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215
--- Comment #149 from Kyle M Hall ---
Created attachment 23264
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23264&action=edit
Bug 8215 - Course Reserves - Omnibus - v3.12.07
Bug 8215 - Course Reserves
Adds a course reserves system for academic libraries.
The course reserves system allows libraries to create courses
and put items on reserves for those courses.
Each item with at least one reserve can have some of its attributes
modified while it is on reserve for at least one active course.
These attributes include item type, collection code, shelving location,
and holding library. If there are no active courses with this item
on reserve, it's attributes will revert to the original attributes
it had before going on reserve.
Test Plan:
1) Create new authorised value categories DEPARTMENT and TERM
2) Create a new course, add instructors to that course.
3) Reserve items for that course, verify item attributes have changed.
4) Disable course, verify item attributes have reverted.
5) Enable course again, verify item attributes again.
6) Delete course, verify item attributes again.
7) Create two new courses, add the same item(s) to both courses.
8) Disable one course, verify item attributes have not reverted.
9) Disable both courses, verify item attributes have reverted.
10) Enable one course, verify item attributes are again set to the
new values.
11) Edit reserve item attributes, verify.
12) Disable all courses, edit reserve item attributes, verify
the item itself still has its original attributes, verify
the reserve item attributes have been updated.
13) Verify the ability to remove instructors from a course.
14) Verify new permissions, top level coursereserves, with
subpermissions add_reserves and delete_reserves.
Signed-off-by: Kyle M Hall
Signed-off-by: Corinne Bulac
Signed-off-by: Jonathan Druart
http://bugs.koha-community.org/show_bug.cgi?id=8125
Bug 8215 follow-up encoding for branches & itemtypes
Signed-off-by: Kyle M Hall
Signed-off-by: Corinne Bulac
Signed-off-by: Jonathan Druart
Bug 8215: Followup FIX QA issues
Signed-off-by: Kyle M Hall
Signed-off-by: Jonathan Druart
Bug 8215 - Add Course Reserves - QA Followup
Signed-off-by: Kyle M Hall
Signed-off-by: Jonathan Druart
Bug 8215: Followup Fix confirmation links for delete course and item
Signed-off-by: Kyle M Hall
Signed-off-by: Jonathan Druart
Bug 8215: FIX ergonomic issue : 'Unchanged()'
bug 8215: (followup) run new files through perltidy
Signed-off-by: Galen Charlton
Signed-off-by: Kyle M Hall
bug 8215: (followup) make sure C4::CourseReserves doesn't export anything
New modules should not export any symbols by default
without a very good reason.
Signed-off-by: Galen Charlton
Signed-off-by: Kyle M Hall
bug 8215: (followup) don't allow deleting course reserves from OPAC
Signed-off-by: Galen Charlton
Signed-off-by: Kyle M Hall
bug 8215: (followup) avoid SQL syntax error in logs
ModItem currently will attempt to update an item
even if no field updates are specified. This patch
avoids (harmless) error messages in the Apache
logs if an item is not actually being changed when it
is placed or taken off reserve.
Signed-off-by: Galen Charlton
Signed-off-by: Kyle M Hall
bug 8215: (followup) rename GetItemReservesInfo
Renamed that routine to GetItemCourseReservesInfo in
order to avoid any potential confusion with reserves
qua hold requests.
Signed-off-by: Galen Charlton
Signed-off-by: Kyle M Hall