[Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Dec 3 12:59:05 CET 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22415|0                           |1
        is obsolete|                            |
  Attachment #22416|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 23259
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23259&action=edit
[PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js

To old plugin prevents the upgrade to the latest jquery.  By replacing with
openjs' shortcut.js, we have now one less hurdle in upgrading Koha to latest.

Changes:
- removed jquery.hotkeys.min.js
- added shortcut.js
- modified the related includes (doc-head-close.inc and help-top.inc)
- modified the calls in staff-global.js

Regression test:
1) apply the patch
2) in the intranet, test the shortcuts alt-q, alt-r, alt-u.

These are the only affected functionalities.  There is no new functionnality.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script. Tested existing
shortcuts for the search bar tabs on various circulation
related pages.

This uses a Javascript under BSD license, I wonder if it
should be listed in the About>licenses section that we
are using it. As Yui is also BSD I assume the license is
compatible.

+/**
+ * http://www.openjs.com/scripts/events/keyboard_shortcuts/
+ * Version : 2.01.B
+ * By Binny V A
+ * License : BSD
+ */

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list