[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #82 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Jacek Ablewicz from comment #78)
Hello Jacek,
I squashed all fixes into one.

> 79c79,80
> <     if ( defined ( my $filter_value = $query->param('additional_field_' .
> $field->{id} . '_filter') ) ) {
> ---
> >     my $filter_value = $query->param('additional_field_' . $field->{id} . '_filter');
> >     if ( defined( $filter_value ) && $filter_value ne '' ) {
> 
> searching works again like it should. I'm not sure if that may be a proper
> fix, but it corrected this particular problem.

Yep, it is fine. It is included in the squashed patch.

(In reply to Jacek Ablewicz from comment #79)
> It was enough, no need to extend additional_fields table.. Also, in case
> extra fields are really needed, one can always add additional fields to
> additional_fields using Koha::AdditionalFields ;).

It would be fun but I discourage you to do that :)

> Yet subscription-add.* script & template are (?) still using field name for
> <input name=""> etc. isntead of field id - that's where I encountered
> aftermentioned problems. Another possibility is that while applying patches
> I simply may have missed one (or two)..

Yes, good catch. Fixed in the last patch too.

Thank you very much for testing!

-- 
You are receiving this mail because:
You are watching all bug changes.