[Koha-bugs] [Bug 6427] Rewrite of the accounts system

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #37 from Galen Charlton <gmcharlt at gmail.com> ---
In addition to the specific points that Chris has made -- which, to be frank,
do not inspire confidence that the rewrite patch has been sufficiently tested
by the patch submitter -- this patch is simply too large to evaluate as is.

I *strongly* encourage you to break it up into a series of patches that, in
effect, tell a story that can be evaluated, or at least read, a patch at a
time.  A possible sequence might look like this:

* test cases: this is an opportunity for the test cases to describe the new API
and provide some confidence that all aspect of the existing behavior have been
covered.
* DB schema updates
* schema upgrade -- as this will require particularly close attention
* introduction of the new API in the Koha namespace
* elimination of the old C4 API and staff-side script changes
* public catalog-side changes

Other ways of organizing it are of course possible, but the main point is to
break it up into smaller units that can be read one at a time, even if the
entire series has to be applied for it to work at all.

It would be even better, although not necessarily possible, to structure the
patch series in such a way that parts of it can be independently applied.

Also, to reiterate the point in my first paragraph: the more that you take care
to eliminate debug code and trivial violations of the QA guidelines, the easier
it will be for patch reviewers to focus on the substance.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.