[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

--- Comment #12 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Kyle,
Did more testing.  A few issues:

First, this may be an issue with the sandbox.  Not sure.  I'll need to do a
fresh install with the patch.  I tested on master first, then I applied the
patch, and I received this e-mail:

The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 10904:
<h1>Something went wrong !</h1>Applying: Bug 10904 - would like to limit patron
update request management by branch
Applying: Bug 10904 [QA Followup] - would like to limit patron update request
management by branch Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/sysprefs.sql Auto-merging
installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 10904 [QA Followup] - would like to limit patron
update request management by branch When you have resolved this problem run git
bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 10904 - would like to limit patron update request management by branch

22494 - Bug 10904 - would like to limit patron update request management by
branch
23104 - Bug 10904 [QA Followup] - would like to limit patron update request
management by branch

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-10904-QA-Followup---would-like-to-limit-patron-3o7VHx.patch .


Second issue, it looks like from your input on this ticket there should be two
preference settings: IndependentBranches and
IndependentBranchesPatronModifications.  I only see the first.

Third issue, I turned on IndependentBranches, and it works in letting the staff
see only their patron requests, but we've lost some of the other features you
had at first.  Parts 6 and 7 of your test plan fail.  This modification does
not exist.  They should be there with or without the IndependentBranches set,
and they are not there at all.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.