[Koha-bugs] [Bug 6427] Rewrite of the accounts system

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #54 from Kyle M Hall <kyle at bywatersolutions.com> ---
Good calls. I had expected koha-qa.pl to pick those warns up ( it usually does
). 

Spot on! Thanks for catching those!

Kyle

(In reply to Chris Cormack from comment #36)
> Comment on attachment 23276 [details] [review]
> Bug 6427 - Rewrite of the accounts system
> 
> Review of attachment 23276 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/Koha.pm
> @@ +1029,4 @@
> >  
> >  sub GetAuthorisedValues {
> >      my ( $category, $selected, $opac ) = @_;
> > +    warn "GetAuthorisedValues( $category, $selected, $opac )";
> 
> This needs a debug switch, or to be removed
> 
> @@ +1076,4 @@
> >          push @results, $data;
> >      }
> >      $sth->finish;
> > +    warn "RET: " . Data::Dumper::Dumper( \@results );
> 
> And this too, or the logs get loud very very fast
> 
> ::: misc/release_notes/release_notes_3_10_0.txt
> @@ +1762,4 @@
> >  	8996	normal	In result page items with negative notforloan are available
> >  	9017	normal	Quote of the day: Table footer not translated
> >  	5312	minor	XHTML correction in authority summary
> > +  8009	minor	Item descriptive data not populated on account_payment.pl
> 
> Shouldnt be in the patch, this looks like a search and replace gone wrong
> 
> ::: misc/release_notes/release_notes_3_12_0.txt
> @@ +579,4 @@
> >  	8429	minor	Unnecessary use of Exporter in SIP/ILS objects
> >  	9292	minor	Remove dead code related to 'publictype'
> >  	9401	minor	Javascript used for tags handling wants access to CGISESSID cookie
> > + 9582	minor	Unused code in members/account_payment.pl
> 
> Hmm not sure why this is in the patch?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.