[Koha-bugs] [Bug 6427] Rewrite of the accounts system

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #55 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Galen Charlton from comment #37)
> In addition to the specific points that Chris has made -- which, to be
> frank, do not inspire confidence that the rewrite patch has been
> sufficiently tested by the patch submitter -- this patch is simply too large
> to evaluate as is.

I assure you that I have tested it quite a bit, but I also agree with you. I
plan to continue testing to with as many add edge cases as I can imagine. So
far everything has been quite solid. My largest and foremost concern at that
point is to ensure that updatedatabase.pl ports all existing accounting data to
the new accounting system properly.

> 
> I *strongly* encourage you to break it up into a series of patches that, in
> effect, tell a story that can be evaluated, or at least read, a patch at a
> time.  A possible sequence might look like this:
> 
> Other ways of organizing it are of course possible, but the main point is to
> break it up into smaller units that can be read one at a time, even if the
> entire series has to be applied for it to work at all.
>

Done! I hope I haven't swung too far the other way with this patch series. I've
tried to break it up into functional components as you can see ( schema,
modules, intranet, opac, etc... ).

> It would be even better, although not necessarily possible, to structure the
> patch series in such a way that parts of it can be independently applied.

Each of these patches should be independently apply-able. However, I'm afraid
some parts will not function without the patches after it ( I'm looking at you
part 11 ). Splitting this patch was quite a task, and I'm afraid I did not keep
it fully chronological such that each patch only requires the preceding patches
to to be functional. If you have any suggestions on re-ordering the patches I
will be happy to do so!

> Also, to reiterate the point in my first paragraph: the more that you take
> care to eliminate debug code and trivial violations of the QA guidelines,
> the easier it will be for patch reviewers to focus on the substance.

I agree. This patch series currently passes koha-qa.pl, so I have a fair
confidence that I have taken care of all violations at this point!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.