[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23474|0                           |1
        is obsolete|                            |

--- Comment #27 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 23475
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23475&action=edit
Bug 7567 - News by Branch

By selecting a particular branch, news specific to a branch
can be showed once the user logs into the opac (or the staff)
client.

This includes adding a NULL default branchcode field
to the opac_news table.

When a user is logged in they receive both NULL and their branch
news. When no user is logged in, they only receive NULL news.
NULL means all branches.

C4::NewsChannels problems that were raised by Katrin Fischer
have been corrected by modifying the template file, and
removing the hardcoded strings.

I have revised all the sample_news.sql files, including adding
setting utf8, disabling and reenabling the foreign keys, and
removing explicit references to the idnew field. The idnew field
is autogenerated. This allowed me to source all the sql files and
get all of them added into my MySQL DB.

And as per Katrin Fischer's suggestion, I added AFTER into the
ALTER command, so that the fresh install and update install should
generate identical field orders.

REVISED TEST PLAN
-----------------
 1) Do a fresh install, to ensure that branchcode is created as a field
     in the opac_news table.
    - Did you try for something non-English?
 2) Do an upgrade to confirm that the branchcode field is added
     to the opac_news table.
 3) prove -v t/db_dependent/NewsChannels.t
     This should test all the changes in C4::NewsChannels functions.
 4) Log into the staff client
    - Does the News display on the main page bust?
 5) Add a new dummy branch (so it has no items or borrowers)
 6) Go to Tools->News
    - Are the locations properly display?
 7) Add a News item, for 'All' interfaces for 'All Branches'.
 8) Add a News item, for 'Librarian interface' interfaces for
     the dummy branch.
 9) Add a News item, for 'Slip' interfaces at your user branch.
10) Add a News item, for 'OPAC' interface at your user branch.
11) Change the Location and Branch filters.
    - Do they show what you select after you click the Filter button?
          (Unpatched the Location does not!)
    - Are the items displayed matching what is selected?
    - Are the drop downs containing the expected values?
          (All, Librarian Interface, Slip,
            and OPAC (<lang> -- for each <lang> installed)
          (All Branches, and every branch listed)
12) Click 'Edit' for one of the news items added.
    - Does what comes up match what was displayed?
          ( Unpatched the Location may be 'All' )
    - Are the drop downs containing the expected values?
          (All, Librarian Interface, Slip,
            and OPAC (<lang> -- for each <lang> installed)
          (All Branches, and every branch listed)
    - Does the submitted values match the changes made?
13) Find a patron to print a slip for. Print Slip.
    - Does both the 'All' and 'Slip' news show up on the print slip?
14) In a new tab, go to OPAC
    - Does the News display on the main page bust?
    - Does it display the news item for a specific branch?
          (It shouldn't when patched, but unpatched it would)
          (Only one of the new things added should be displayed)
15) Log in as yourself on OPAC.
    - Does that piece of News display now too?
          (Both things added should be displayed)
16) In the staff client, delete the dummy branch.
    - Does the 'Librarian interface' news item exist any more?
      It shouldn't.
17) Check the news items added and click the delete button in the
     staff client.
    - Did it delete them appropriately?

-- 
You are receiving this mail because:
You are watching all bug changes.