[Koha-bugs] [Bug 6874] File upload in MARC

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #159 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Paul Poulain from comment #158)
> (In reply to M. Tompsett from comment #156)
> > I have some other related questions:
> > - should validate URLs, since not all 856$u urls will be uploaded file urls.
> Not sure I understand well the question, but isn't
> misc/cronjobs/check-url-quick.pl what you're asking ?

No.

if ( is this one of our uploaded files ) { continue processing as expected }
else { give big warning, and then go immediately to the upload, not the delete
page }


> > - is telling a user to check errors logs reasonable? They may not have shell
> > access to the system.
> No, it isn't

Then we need to fix that. However, I think that is in part of the signed off
patches.


> > - If a valid external url is detected, then a different response is needed
> > than if we discover a url to a deleted file.
> I think check-url-quick.pl achieve the goal, and it's better because it
> detects when an URL becomes invalid at any time.

This isn't about an invalid URL. Frankly, I don't care about the validity as
much as I care about the process flow. If I have a url in the 856$u field and
click the plugin icon, I do not expect to attempt to delete an external url
(not our hosted files that were uploaded).


> > - How will the user know to delete the text field before clicking the plugin
> > icon in order to continue onto the upload screen to put a different file in
> > place?
> I don't understand this one.

Test this.
Upload a file.
Clone the field.
Now there are two fields pointing to the same uploaded file.
Click the plug in icon, and delete the file, but then cancel.
Now there are two fields: one blanked (because you just deleted), and the other
with a dangling reference.

Now, click the plugin icon for the non-empty 856$u field.
It's going to prompt to delete. The user will click "Delete", because there is
no way to go to upload otherwise, and an error will be generated (because the
file was already deleted). And there is no meaningful feedback suggesting to
clear the field before clicking the plugin icon, so the user will be frustrated
because they can't seem to upload a file anymore, because they overlook the
obvious idea of clearing the field.


> Are my answer OK and is it back to go to signed-off ?
> (I have not tested the patches still applies cleanly)

If I have clarified what I mean, and you do test and see the process flow, then
you'll understand that with a couple more validations the process can be made
smoother.

-- 
You are receiving this mail because:
You are watching all bug changes.