[Koha-bugs] [Bug 10952] Store anonymous search history in session

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23618|0                           |1
        is obsolete|                            |

--- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 23755
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23755&action=edit
Bug 10952: Store anonymous search history in session

Storing search history into cookie can cause problems, due to the size
limitation of 4KB.
The solution here is to store search history into the CGI::Session
object, so there is no size limitation (but anonymous search history
still remember up to 15 requests max.)

Test plan:
- Go to OPAC in anonymous mode.
- Check that the "Search history" link is *not* shown in the top right
  corner of the page
- Make some searches on /cgi-bin/koha/opac-search.pl
- The "Search history" link must appear. Click.
- Your search history must be displayed.
- Try to log in with invalid username/password
- Go back to search history, it's still there
- Now log in with valid username/password
- Your anonymous search history must be saved into your own search
  history.

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Restoring original sign offs and comments below

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described. No koha-qa errors

Well, search history saving is similar before and after patch.
i.e. anonmymous search is saved when user logs in, but cookie
KohaOpacRecentSearches is empty.
Shows current an previous session searches

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
All tests and QA script pass, works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.