[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351

--- Comment #20 from Chris Cormack <chris at bigballofwax.co.nz> ---
(In reply to Fridolin SOMERS from comment #18)
> (In reply to Chris Cormack from comment #16)
> > Comment on attachment 23692 [details] [review] [review]
> > Bug 9351 - item type not recorded correctly in statistics for returns and
> > some local use
> > 
> > Review of attachment 23692 [details] [review] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: C4/Circulation.pm
> > @@ +1897,4 @@
> > >      UpdateStats(
> > >          $branch, $stat_type, '0', '',
> > >          $item->{'itemnumber'},
> > > +        $item->{'itype'},
> > 
> > Shouldn't this be checking the itemlevel itemtypes system preference? 
> > Otherwise this is going to break for any libraries using biblioitem level
> > itemtypes
> No, because $item comes from GetItem() and this method sets $item->{'itype'}
> with biblioitems.itemtype if bibliolevel itemtypes.

No, it uses the item level one if it exists and falls back to the biblio level
one if it doesn't. It doesn't respect the systempreference. And won't unless
bug 9532 is fixed to a point that it can be pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.