[Koha-bugs] [Bug 10735] koha-dump not working

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10735

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23700|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 23784
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23784&action=edit
Bug 10735 - prevent script aborting if backupdir undefined

Older versions of Koha didn't have <backupdir>...</backupdir> defined in
koha-conf.xml. The koha-dump script is aware of this, and checks to see
if it's there. However, if it's not, xmlstarlet returns a non-0 error
code which causes the script to abort due to running under set -e.

Test plan:
 * Remove backupdir from koha-conf.xml
 * Run koha-dump, notice that it doesn't do backups
 * Apply patch
 * Run koha-dump again, notice that it does do backups

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
The fallback method works as described. It might be made more robust
like checking for dir existence (thinking of older instances upgrades).
But it certaintly belongs to another bug report.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
As Tomas said, it would be better to alert the user if the backupdir tag
does not exist (or contains a nonexistent directory) in the config file.

-- 
You are receiving this mail because:
You are watching all bug changes.