[Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian()

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23523|0                           |1
        is obsolete|                            |
  Attachment #23635|0                           |1
        is obsolete|                            |

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 23860
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23860&action=edit
[PASSED QA] Bug 10277 - Add C4::Context->IsSuperLibrarian()

The method of checking the logged in user for superlibrarian privileges
is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least.
The codebase is littered with these lines, with no explanation given. It
would be much better if we had one subroutine that returned a boolean
value to tell us if the logged in user is a superlibrarian or not.

Test Plan:
1) Apply this patch
2) Verify superlibrarian behavior remains unchanged

Signed-off-by: Joel Sasse <jsasse at plumcreeklibrary.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Comments on second patch.

-- 
You are receiving this mail because:
You are watching all bug changes.