[Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian()

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Dec 29 11:14:03 CET 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277

--- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 23861
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23861&action=edit
[PASSED QA] Bug 10277: Add UT for C4::Context::IsSuperLibrarian

Note that I modify the return value. Before this patch, it returned an
empty string or 1. Now it returns 0 or 1.

Test plan:
- same as the original patch
- verify that unit tests pass:
    prove t/Context.t

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script, including new tests.
Checked the code and tested superlibrarian behaviour in some places:

moremember.pl:
With IndyBranches only superlibrarian can delete borrowers from
other branches. Accessing the borrower with a direct link.
OK

C4/Members.pm
With IndyBranches only superlibrarian can search for borrowres
from other branches.
OK

tools/holidays.pl
With IndyBranches only superlibrarian can edit holidays for other
branches.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list