[Koha-bugs] [Bug 9303] relative's checkouts in the opac

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Dec 29 11:51:53 CET 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 23526
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23526
Bug 9303 [1/2] - relative's checkouts in the opac - Schema Updates

Review of attachment 23526:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9303&attachment=23526)
-----------------------------------------------------------------

Hi Kyle, starting with a code review:

::: Koha/Schema/Result/Borrower.pm
@@ -191,4 @@
>  =head2 dateofbirth
>  
>    data_type: 'date'
> -  datetime_undef_if_invalid: 1

Can you explain why those lines have been removed by your patch? I know that
those files are generated automatically, but I have difficulty to see how those
changes are related to the canges done in kohastructure.sql.

@@ +1020,2 @@
>  
> +# Created by DBIx::Class::Schema::Loader v0.07000 @ 2013-11-07 08:15:21

I notice, that your version is a bit older than the one used before, could that
explain some of the differences?

::: installer/data/mysql/updatedatabase.pl
@@ +7826,5 @@
>  
> +$DBversion = "3.15.00.XXX";
> +if(CheckVersion($DBversion)) {
> +    $dbh->do(q{
> +        ALTER TABLE borrowers ADD privacy_relative_checkouts BOOLEAN NOT NULL DEFAULT '0'

I'd feel a bit better about this line and the next, if there was an
AFTER/BEFORE making sure that the sequence of rows is the same for old and new
installations.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list