[Koha-bugs] [Bug 10429] branch filter not working in serial claims

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Dec 29 14:56:17 CET 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19748|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 23864
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23864&action=edit
[PASSED QA] Bug 10429 - branch filter not working in serial claims

In serial claims page, the branch code is displayed in table instead of branch
name and branch filter does not work.

This patch adds the display of branch name by using branches template plugin.
It changes javascript branch filter to make it work.
Also sets "all" filter in template (like status filter) to allow translation
and sets "all" as selected by default. Librairian branch was selected by
default, but the table was not filtered with it.

Test plan :
- Go to serials claim of a vendor with serials of multiple branches
=> You see branch filter with "(All)" and table shows libraries names
- Check that branch filter does its work

Signed-off-by: David Cook <dcook at prosentient.com.au>
Works as described.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Table now shows the branch name instead of the branchcode.
First option was named (All), matching the status pull down.
When opening the claims page, (All) is preselected and the
result list matches with the selection. Before the patch
the library was preselected, but the result list did show
late issues from all branches.

This patch is an improvement, but there is still more work to do.

- Filters are not cumulative, but when another filter is selected
  the first filter is not reset.
- It's not possible to combine
  2 or more filters.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list