[Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 23638
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23638
Bug 10278 - Add ability to hide items and records from search results for
Independent Branches

Review of attachment 23638:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10278&attachment=23638)
-----------------------------------------------------------------

Can't apply this patch, as the dependency doesn't apply, but starting with a
code review:

1) We need some unit tests for the new routine GetCategoriesForBranch (UT). 
   Also regression tests, additional tests, any tests for some of the other
routines would be nice.

Failed QA for the missing unit tests.

::: C4/Branch.pm
@@ +42,4 @@
>  		&GetCategoryTypes
>  		&GetBranchCategories
>  		&GetBranchesInCategory
> +        &GetCategoriesForBranch

UT

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
@@ +75,5 @@
> +              default: 0
> +              choices:
> +                  yes: Prevent
> +                  no: "Don't prevent"
> +            - staff from seeing items owned by other libraries, and records without any items the library.

I think there is a word missing in the last bit. 

I wonder a bit about the consequences - it will be required to always add at
least one 'fake' item to every record, that you want to show up in the OPAC.
Thinking about serials and electronic resources, but also set and traced serial
record as used in Germany.

::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
@@ +32,2 @@
>              strQuery += "&" + "[% z3950_search_param.name %]" + "=" + "[% z3950_search_param.encvalue %]";
> +*/

Why are you commenting this bit out?

-- 
You are receiving this mail because:
You are watching all bug changes.