[Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
However, I did further thinking, and there's a problem. :(
--- BEGIN SAMPLE CODE ---
#!/usr/bin/perl -Tw

my $val = undef;

my $total = 'q';
$total .= " " . ($val // 0);
print "$total\n";

$total = 'q';
$total .= " " . $val // 0;
print "$total\n";
--- END SAMPLE CODE ---

Before the space was added, a precedent issue wasn't as big an issue. I think
the patch should be:
    $total .= " " . ($bookseller->{invoiceprice} // 0);
This will avoid an noisy warning, and better reflect the intent of the original
code, since I don't think (" " . $val) // 0; is the thing being aimed for.

Here is my revised test plan:
1) Log into staff client
2) Acquisitions
3) Click 'Search' in the 'Manage orders' box.
4) Click '+ New basket' beside a vendor name.
5) Type 'Bug 9654 Test 1' into basket name.
6) Click 'Save'
7) Click 'Add to basket'
8) Click 'From an external source'
9) Type 'Green Eggs and Ham' into the Title text box.
10) Click 'Search'
11) Click 'Order' on any one of the results.
12) Click 'Add Item' in the 'Item' box.
13) Select a Fund from the dropdown in the 'Accounting details' box.
14) Click 'Save'
15) Click 'Close this basket'
16) Click 'Yes, close (Y)' without checking the attach to a basket group.
17) Click the 'Basket groups' tab.
18) Click '+ New basket group'
19) Notice the listing in 'Ungrouped baskets' lacks a space between the number
and the currency. (e.g. Total: 0USD)
20) Apply patch (git bz apply 9654)
21) Refresh the page
22) Notice there is now a space. (e.g. Total: 0 USD)
23) Run the Koha QA Tool: (~/qa-test-tools/koha-qa.pl -v 2 -c 1)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.