From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 02:23:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 01:23:42 +0000
Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and
default_circ_rules tables useless
In-Reply-To: ---
Is there a reason we couldn't keep the foreign key constraint and use NULL to
mean all branches/all patron types/all item types? It seems a shame to lose the
database-enforced consistency.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 03:20:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 02:20:14 +0000
Subject: [Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Passed QA
CC| |liz at catalyst.net.nz
--- Comment #7 from Liz Rea (CatalystIT) ---
I sign off on this after thorough testing of this scenario:
Library A, B
Patrons 1a, 2b (letters denote which branch the patron is from)
Reserves 1, 2
Reserve 1 is placed for patron 2b
Reserve 2 is placed for patron 3c
Item is pulled from the shelf at library A (home library)
Checked in, for hold for patron 2b
Library clicks Confirm, sends item to B.
B checks in the item
Clicks "Ignore"
Prompt says "Return to A" <- Good! Without the patch, this doesn't happen.
However, and I think this is actually a different problem unrelated to this
patch, but needs to be documented -
Let's just say, that the staff member at B put it down on the desk (got
interrupted) and another staff member picks up the book and checks it in again
at library B.
This is what they will see:
http://i.imgur.com/AVGQTmK.png
and in the detail:
http://i.imgur.com/3z6K5iy.png
What should this new staff member do and what are those messages actually
trying to say?
My point is, this patch greatly increases the likelihood of seeing dual
prompts, and those prompts need to be made more understandable.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 03:33:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 02:33:02 +0000
Subject: [Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14841|0 |1
is obsolete| |
--- Comment #8 from Liz Rea (CatalystIT) ---
Created attachment 14990
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14990&action=edit
Bug 8292 - Clicking ignore on hold cancels transfer
Clicking 'ignore' in the hold confirmation box does nothing
but make the confirmation box disappear. No further actions are
taken. The code to do the transfer is never executed, and the item sits
at the holdingbranch library.
If you're ignoring the hold, you want the checkin to proceed as if the
hold had never popped up in the first place, and that means doing a
return home if appropriate.
To test, place a hold on an item for delivery to Library A. Check that
item in at Library B. Click "Ignore" in the hold confirmation message.
Before the patch, doing so would simply trigger JavaScript to hide the
dialog. After the patch the form will be sumitted and the item will be
transfered without fulfilling the hold.
Signed-off-by: Owen Leonard
Added description and test plan to the best of my understanding of what
this patch is trying to accomplish based on the bug report. The patch
works if I'm correct in my test plan.
Signed-off-by: Katrin Fischer
All tests and QA script pass.
Tests done:
1) Add an item hold on an item from library B for a patron from library A,
pickup location is library A
2) Check in item at library A
3) Click 'ignore'
a) AutomaticItemReturn is ON = Koha provides a link to print the transfer
slip.
b) AutomaticItemReturn is OFF = Koha provides 3 options: Confirm transfer
and print slip, confirm transfer, don't confirm transfer.
Without the patch the item was returned, but the transfer wasn't triggered.
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 03:36:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 02:36:59 +0000
Subject: [Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer
In-Reply-To: ---
I want to also note, that if the item is checked in at library A, the next hold
isn't triggered at check in. That behaviour probably has something to do with
bug 9322, and I believe it's longstanding behaviour.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 03:39:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 02:39:50 +0000
Subject: [Koha-bugs] [Bug 9322] If multiple transfers exist (from
circ/branchtransfers.pl), completing one completes them all
In-Reply-To: ---
bug 8292 introduces an automaticitemreturn transfer that will trigger this as
well.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 03:47:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 02:47:55 +0000
Subject: [Koha-bugs] [Bug 9527] New: add all-all-all circulation rule to
sample data
Message-ID: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14332|0 |1
is obsolete| |
--- Comment #3 from M. de Rooy ---
Created attachment 14991
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14991&action=edit
Bug 9330: title field empty when duplicating a patron
For a duplicated patron, the "Saluation" information
is now empty by default.
Signed-off-by: Owen Leonard
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 08:40:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 07:40:06 +0000
Subject: [Koha-bugs] [Bug 9330] Patron duplication : should duplicate with
empty title (salutation field)
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Needs Signoff
CC| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 08:40:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 07:40:16 +0000
Subject: [Koha-bugs] [Bug 9330] Patron duplication : should duplicate with
empty title (salutation field)
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 08:40:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 07:40:25 +0000
Subject: [Koha-bugs] [Bug 9330] Patron duplication : should duplicate with
empty title (salutation field)
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 08:43:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 07:43:32 +0000
Subject: [Koha-bugs] [Bug 9330] Patron duplication : should duplicate with
empty title (salutation field)
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact| |m.de.rooy at rijksmuseum.nl
--- Comment #4 from M. de Rooy ---
Works as advertised. The need why this salutation should be empty, is not
really made clear in the report description btw. But I do not see any harm in
it.
Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 08:59:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 07:59:41 +0000
Subject: [Koha-bugs] [Bug 9147] OPAC hidden fields are not hidden in ISBD
view
In-Reply-To: ---
Yes it can be, however it changed templates when we were in string freeze so
couldn't be pushed before 3.10.2 and 3.8.9 were released.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:01:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:01:46 +0000
Subject: [Koha-bugs] [Bug 9147] OPAC hidden fields are not hidden in ISBD
view
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
--- Comment #8 from Chris Cormack ---
Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:03:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:03:25 +0000
Subject: [Koha-bugs] [Bug 9102] [SECURITY] We should set httponly on our
session cookie
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
QA Contact| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:03:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:03:39 +0000
Subject: [Koha-bugs] [Bug 9310] Patron image upload template corrections
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |chris at bigballofwax.co.nz
--- Comment #6 from Chris Cormack ---
Pushed to 3.10.x and 3.8.x, will be in 3.10.3 and 3.8.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:06:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:06:45 +0000
Subject: [Koha-bugs] [Bug 9108] Add uk/euro date sort filter to pages which
require it
In-Reply-To: ---
Patches do not apply cleanly to 3.10.x or 3.8.x please rebase for those
branches if you want it in them.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:09:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:09:47 +0000
Subject: [Koha-bugs] [Bug 9276] Display of biblio-level authorized values on
OPAC search results broken
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
--- Comment #6 from Chris Cormack ---
Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:12:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:12:09 +0000
Subject: [Koha-bugs] [Bug 9348] Format dates in HOLD notices consistently
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |chris at bigballofwax.co.nz
--- Comment #7 from Chris Cormack ---
Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:14:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:14:32 +0000
Subject: [Koha-bugs] [Bug 9357] Missing 'c' option in LEADER_18 value builder
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |chris at bigballofwax.co.nz
--- Comment #7 from Chris Cormack ---
Pushed to 3.10.x and 3.8.x, will be in 3.10.3 and 3.8.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:16:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:16:40 +0000
Subject: [Koha-bugs] [Bug 9364] Wrong billing/delivery addresses when
creating a basket
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |chris at bigballofwax.co.nz
--- Comment #6 from Chris Cormack ---
Pushed to 3.10.x will be in 3.10.3
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:19:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:19:38 +0000
Subject: [Koha-bugs] [Bug 9236] deleting an order when receiving redirects
to closed basket
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |chris at bigballofwax.co.nz
--- Comment #19 from Chris Cormack ---
Pushed to 3.10.x will be in 3.10.3
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:22:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:22:03 +0000
Subject: [Koha-bugs] [Bug 9116] Code cleaning: Remove some useless temp
variables
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |chris at bigballofwax.co.nz
--- Comment #5 from Chris Cormack ---
Pushed to 3.10.x will be in 3.10.3
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:25:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:25:21 +0000
Subject: [Koha-bugs] [Bug 9147] OPAC hidden fields are not hidden in ISBD
view
In-Reply-To: ---
(In reply to comment #8)
> Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10
Perfect, thanks a lot.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:25:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:25:42 +0000
Subject: [Koha-bugs] [Bug 9407] patrons search should match substrings
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |chris at bigballofwax.co.nz
--- Comment #11 from Chris Cormack ---
Pushed to 3.10.x and 3.8.x will be in 3.10.3 ad 3.8.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:26:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:26:36 +0000
Subject: [Koha-bugs] [Bug 9503] Link from histsearch via invoicenumber
results in error
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #7 from Jonathan Druart ---
Thanks Colin.
Marked as Passed QA.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:26:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:26:50 +0000
Subject: [Koha-bugs] [Bug 9503] Link from histsearch via invoicenumber
results in error
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14920|0 |1
is obsolete| |
--- Comment #8 from Jonathan Druart ---
Created attachment 14992
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14992&action=edit
Bug 9503 Correct name of parameter passed to parcel.pl
invoiceid was being passed as invoice causing GetInvoiceDetails
to silently fail and a system error downstream when
accessing the 'orders' element of the undefined invoice
Added an error message if GetInvoiceDetails called on undef
Signed-off-by: Galen Charlton
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:26:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:26:58 +0000
Subject: [Koha-bugs] [Bug 9503] Link from histsearch via invoicenumber
results in error
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14981|0 |1
is obsolete| |
--- Comment #9 from Jonathan Druart ---
Created attachment 14993
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14993&action=edit
Bug 9503: Followup remove unused parameters passed to parcel.pl
The booksellerid and datereceive parameters are useless.
Signed-off-by: Colin Campbell
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:28:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:28:04 +0000
Subject: [Koha-bugs] [Bug 9343] SIP doesn't handle debarred date/status
correctly
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chris at bigballofwax.co.nz
--- Comment #5 from Chris Cormack ---
Does not apply to 3.10.x please rebase if you will it to be that branch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:31:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:31:15 +0000
Subject: [Koha-bugs] [Bug 9281] Impossible to create an order from a staged
file
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |chris at bigballofwax.co.nz
--- Comment #15 from Chris Cormack ---
Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:32:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:32:47 +0000
Subject: [Koha-bugs] [Bug 9384] With OPACPatronDetails set to 'don't allow'
a form shows
In-Reply-To: ---
(In reply to comment #7)
> This patch works as far as it goes, but it does not add any check to
> opac-memberentry.pl to redirect the user if they end up on that page with
> OPACPatronDetails set to "Don't allow," and it really needs to before I push
> it.
So I think the followup will delete some tests in the opac-memberentry.tt
template ([% IF OPACPatronDetails %]).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:32:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:32:53 +0000
Subject: [Koha-bugs] [Bug 9391] Issues on serial collection page no longer
show status
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chris at bigballofwax.co.nz
--- Comment #5 from Chris Cormack ---
Doesn't apply to 3.10.x please rebase if you wish it in that branch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:34:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:34:49 +0000
Subject: [Koha-bugs] [Bug 9280] Bad price calculation when filling a basket
with staged records
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |chris at bigballofwax.co.nz
--- Comment #17 from Chris Cormack ---
Pushed to 3.10.x will be in 3.10.3
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:39:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:39:02 +0000
Subject: [Koha-bugs] [Bug 9402] useless letter "v" between 2 tags
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |chris at bigballofwax.co.nz
--- Comment #5 from Chris Cormack ---
Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:44:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:44:05 +0000
Subject: [Koha-bugs] [Bug 9211] days_between wrong behaviour
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |chris at bigballofwax.co.nz
--- Comment #15 from Chris Cormack ---
Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:47:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:47:54 +0000
Subject: [Koha-bugs] [Bug 9486] t/Letters.t loads modules in wrong order
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
--- Comment #6 from Chris Cormack ---
Pushed to 3.10.x will be in 3.10.3
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:52:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:52:38 +0000
Subject: [Koha-bugs] [Bug 9102] [SECURITY] We should set httponly on our
session cookie
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:52:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:52:41 +0000
Subject: [Koha-bugs] [Bug 9102] [SECURITY] We should set httponly on our
session cookie
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14618|0 |1
is obsolete| |
--- Comment #17 from M. de Rooy ---
Created attachment 14994
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14994&action=edit
Bug 9102 : Followup Set HttpOnly on the CGISESSID cookie
Signed-off-by: Galen Charlton
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:53:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:53:12 +0000
Subject: [Koha-bugs] [Bug 9102] [SECURITY] We should set httponly on our
session cookie
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:53:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:53:22 +0000
Subject: [Koha-bugs] [Bug 9102] [SECURITY] We should set httponly on our
session cookie
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:53:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:53:35 +0000
Subject: [Koha-bugs] [Bug 9497] Make it easier to add to the the list of
possible encodings for Z39.50 servers and add ISO 8859-1
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |chris at bigballofwax.co.nz
--- Comment #9 from Chris Cormack ---
Pushed to 3.10.x, will be in 3.10.3
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 09:56:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 08:56:49 +0000
Subject: [Koha-bugs] [Bug 9102] [SECURITY] We should set httponly on our
session cookie
In-Reply-To: ---
Tested. See the HttpOnly flag in Firebug. Checked cookie processing in IE9 and
FF with opac language and session. Also added an item without problems.
Code looks good to me.
Passed QA
Note for RM: Will take a look too at the related report of Galen.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 10:51:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 09:51:22 +0000
Subject: [Koha-bugs] [Bug 9526] Patron statistics table is not pretty,
the page needs the circ toolbar added
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |jonathan.druart at biblibre.co
| |m
Patch complexity|--- |Trivial patch
QA Contact| |jonathan.druart at biblibre.co
| |m
--- Comment #3 from Jonathan Druart ---
Thanks Owen of your patch.
QA comment:
This patch improves the ergonomic of the statistics patron page according to
the others patron pages.
Marked as Passed QA.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 10:51:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 09:51:46 +0000
Subject: [Koha-bugs] [Bug 9526] Patron statistics table is not pretty,
the page needs the circ toolbar added
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14989|0 |1
is obsolete| |
--- Comment #4 from Jonathan Druart ---
Created attachment 14995
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14995&action=edit
Bug 9526 - Patron statistics table is not pretty, needs circ toolbar
This patch adds the circ/members toolbar, corrects page title and
breadcrumbs, and adds some handling for column names which are coming
from the database. The table of statistics can display any items table
column specified in the StatisticsFields preference, but we can at least
embed the most obvious cases in the template for human readability: item
type, collection code, location, home library, and holding library.
To test, view the patron statistics page. For a patron with no
statistics you should see a message saying so. For a patron with
statistics you should see human-friendly labels for the columns
referenced above.
Signed-off-by: Bernardo Gonzalez Kriegel
Comment: Works as described. No errors.
Wouldn't be better with centered cell contents?
Signed-off-by: Jonathan Druart
FIX a typo:
- Statistcs for [% UNLESS ( I ) %][% title %] [% firstname %] [% END %] [%
surname %] ([% cardnumber %])
+ Statistics for [% UNLESS ( I ) %][% title %] [% firstname %] [% END %] [%
surname %] ([% cardnumber %])
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 10:59:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 09:59:06 +0000
Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and
frequencies
In-Reply-To: ---
Created attachment 14996
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14996&action=edit
Bug 7688: Fix generating next serial when there is no 'Expected' issue
It can happen when the Expected issue is claimed. In this case the
status of the last serial is 'Claimed'
This patch change the API of GetNextSeq and GetSeq
Test plan:
- Create a subscription which starts a long time ago so that serials
automatically appear in late issues
- Receive the first serial
- Go to claims page and claim the 2nd serial.
- Go back to the subscription page and click on 'Serial collection'
- You should have 2 serials, one 'Arrived' and one 'Claimed'.
- Click on Generate Next. This should fail with a software error message
("can't call method output ...")
- Apply this patch and click again on Generate Next. A new issue must be
created with status 'Expected'.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:00:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 10:00:49 +0000
Subject: [Koha-bugs] [Bug 9161] Translate only specific files
In-Reply-To: ---
Created attachment 14997
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14997&action=edit
Bug 9161: Allow to specificy a complete relpath instead of a filename
Now you can call the translate script with a -f parameter containing a
complete relpath
(koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt or
admin/preferences.tt for e.g.)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:02:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 10:02:39 +0000
Subject: [Koha-bugs] [Bug 9401] Javascript used for tags handling wants
access to CGISESSID cookie
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14617|0 |1
is obsolete| |
--- Comment #2 from M. de Rooy ---
Created attachment 14998
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14998&action=edit
bug 9401: remove direct reads of CGISESSID cookie by JavaScript
Having embedded JavaScript read the session cookie directly
is unnecessary and prevents the CGISESSID cookie being marked
httpOnly as a security measure. The only Koha JS attempting
this was the AJAX tags code.
To test:
- In general, verify that there are no regression withs
adding tags in the OPAC or reviewing them in the staff interface.
- In specific, for the OPAC
- log into the OPAC
- retrieve a bib record
- add a tag
- refresh the bib details page to verify that the
tag was added
- make sure the TagsInputOnList syspref is on
- perform a search
- add a tag to more than one record from the search results page
- repeat the preceding using the CCSR theme
- And in the staff interface
- Go to the review tags tool
- Reject a tag
- Refresh to verify that the tag was rejected
Signed-off-by: Galen Charlton
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:02:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 10:02:38 +0000
Subject: [Koha-bugs] [Bug 9401] Javascript used for tags handling wants
access to CGISESSID cookie
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:03:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 10:03:17 +0000
Subject: [Koha-bugs] [Bug 9401] Javascript used for tags handling wants
access to CGISESSID cookie
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
Patch complexity|--- |Small patch
QA Contact| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:12:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 10:12:46 +0000
Subject: [Koha-bugs] [Bug 9401] Javascript used for tags handling wants
access to CGISESSID cookie
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #3 from M. de Rooy ---
QA Comment:
Welcome addition to the cookies HTTPOnly patch!
Tested adding tags, accepting and rejecting (toggling TagsModeration as well).
Works fine still. Note that the session parameter from the javascript already
was a plan-B-measure in the perl code, but it should not be. This patch nicely
removes that.
Code looks good to me.
Just one remark (had to find something :)
Line 279 (and below) still mentions CGISESSID as ajax post parameter in
comments.. (opac-tags.pl)
Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:21:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 10:21:25 +0000
Subject: [Koha-bugs] [Bug 9418] Some corrections and additions to about.tt
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:21:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 10:21:27 +0000
Subject: [Koha-bugs] [Bug 9418] Some corrections and additions to about.tt
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14889|0 |1
is obsolete| |
--- Comment #9 from M. de Rooy ---
Created attachment 14999
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14999&action=edit
Bug 9418: Some corrections and additions to about.tt
Test plan:
- Apply patch
- See if KEEP SOLUTIONS and C & P Bibliography Services
- Software Coop should be now software.coop
Bug 9418: Some corrections and additions to about.tt
Replaced & with & according codelines.
Sponsored-by: KEEP SOLUTIONS
Combined to patches into one.
Reorder C-entries as per sort order.
Signed-off-by: Owen Leonard
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:21:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 10:21:42 +0000
Subject: [Koha-bugs] [Bug 9418] Some corrections and additions to about.tt
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:24:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 10:24:41 +0000
Subject: [Koha-bugs] [Bug 9418] Some corrections and additions to about.tt
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
QA Contact| |m.de.rooy at rijksmuseum.nl
--- Comment #10 from M. de Rooy ---
Trivial change.
Passing QA since Jared is RM and can answer now if he agrees with the addition
of C&P in the list. (I assume you contacted him about that already..) From the
comments of MJ Ray in the report I assume implicit agreement from his part on
the other modification.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:27:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 10:27:45 +0000
Subject: [Koha-bugs] [Bug 9342] zebra UNIMARC dom indexing does not work
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mathieu.saby at univ-rennes2.f
| |r
--- Comment #1 from mathieu saby ---
Hello
I have just tried with Unimarc and ICU.
It seems to work.
M. Saby
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:30:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 10:30:48 +0000
Subject: [Koha-bugs] [Bug 9418] Some corrections and additions to about.tt
In-Reply-To: ---
Hi Marcel,
Yes it was Jared that told me in the Koha IRC, so there isn't any problem with
that.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:41:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 10:41:39 +0000
Subject: [Koha-bugs] [Bug 5790] Deleting a biblio should alert/fail if there
are existent subscriptions and holds
In-Reply-To: ---
Hi Kyle,
I think we will also want to check for existing orders (checkouts, holds,
subscriptions, orders). In acquisitions you can delete records when none of
those conditions is met - maybe the code could be reused?
Haven't looked at the code, just wanted to leave a short note.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:41:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 10:41:43 +0000
Subject: [Koha-bugs] [Bug 9274] Software error in bibtex export
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
QA Contact| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:02:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 11:02:31 +0000
Subject: [Koha-bugs] [Bug 9274] Software error in bibtex export
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #11 from M. de Rooy ---
The patches fixes the problem with several authors. So, no crash. That is
great!
But if the marc fields include more information than the name in $a, they are
attached as well in the string.
For instance a 700$a with a name and a 700$4 with a relator code sht
(supporting host?), make this as author name (marc21):
author = "Bohlmann, Carolin and Museumslandschaft Hessen Kassel and Museum
Schloss Wilhelmsh?he and sht"
The part "and sht" comes from the $4 and should not be included. The results
from GetMarcAuthors need one more level of "grepping" on code equals $a. In my
view this report could address that now too.
I do not feel that this report should also address the "who is an author"
discussion here. But note that not everybody in 7XX will be an author. In my
testcase above Carolin is author, the second 700 is editor and the third is the
host for the exhibition (the book is the exhibition catalog). But as said, we
leave the scope of this report now.
Note that this patch is marked trivial (one line), but reading multiple maps
and greps on one line is certainly not that trivial :)
Could you please send a correction or followup?
Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:13:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 11:13:33 +0000
Subject: [Koha-bugs] [Bug 9126] Receiving orders create too much items
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Stable |RESOLVED
Resolution|--- |FIXED
--- Comment #15 from Julian Maurice ---
Ok in 3.8.x, 3.10.x and master.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:16:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 11:16:35 +0000
Subject: [Koha-bugs] [Bug 9529] New: Adding a patron shows javascript on
screen under login section
Message-ID: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--- Comment #23 from Julian Maurice ---
Ok in master.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:47:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 11:47:33 +0000
Subject: [Koha-bugs] [Bug 5790] Deleting a biblio should alert/fail if there
are existent subscriptions and holds
In-Reply-To: ---
(In reply to comment #19)
> Hi Kyle,
>
> I think we will also want to check for existing orders (checkouts, holds,
> subscriptions, orders). In acquisitions you can delete records when none of
> those conditions is met - maybe the code could be reused?
>
> Haven't looked at the code, just wanted to leave a short note.
This code probably wouldn't help too much for those cases, but they would not
be difficult to implement anyway.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:57:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 11:57:48 +0000
Subject: [Koha-bugs] [Bug 5790] Deleting a biblio should alert/fail if there
are existent subscriptions and holds
In-Reply-To: ---
Yeah, this looks like a nice fix!
As Katrin said the problem exists in a few other places.
This bug describes the problem with orders in acquisitions :
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5781
Ideally checkouts and subscriptions should also be dealt with.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:07:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 12:07:44 +0000
Subject: [Koha-bugs] [Bug 9529] Adding a patron shows javascript on screen
under login section
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bgkriegel at gmail.com
--- Comment #1 from Bernardo Gonzalez Kriegel ---
This appears with EnhancedMessagingPreferences set to Allow.
The code is in
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
The JS code can be hidden with .
The confirm message needs to be between " (double quotes), can't produce a
situation to trigger it. Don't know if this code is used.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:24:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 12:24:48 +0000
Subject: [Koha-bugs] [Bug 9322] If multiple transfers exist (from
circ/branchtransfers.pl), completing one completes them all
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
--- Comment #4 from Kyle M Hall ---
Would it not make sense for any given item to only ever have a single row in
the branch transfers table at any given time? I.e. initiating a transfer from
LibraryA to LibraryB, and then a transfer from LibraryA to LibraryC will cause
the system to delete the A to B, and replace it with A to C.
I cannot think of a scenario where multiple open branch transfers for a single
item are useful.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:40:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 12:40:54 +0000
Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages
In-Reply-To: ---
I tried with an isbn-13 (978-*) and the ws does not return any result. But if I
delete the dash, the ws returns the good one.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:41:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 12:41:52 +0000
Subject: [Koha-bugs] [Bug 9343] SIP doesn't handle debarred date/status
correctly
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14718|0 |1
is obsolete| |
--- Comment #6 from Kyle M Hall ---
Created attachment 15000
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15000&action=edit
Bug 9343: handles the new format of Debarred [3.10.x]
The debarred status in DB switched from a boolean to a date.
Signed-off-by: Kyle M Hall
Signed-off-by: Elliott Davis
Correctly pulls debared flag instead of debarment date.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:42:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 12:42:54 +0000
Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages
In-Reply-To: ---
Created attachment 15001
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15001&action=edit
Bug 8733: Follow-up The isbn sent to idream contains dash
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:43:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 12:43:31 +0000
Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages
In-Reply-To: ---
Jared, do you think this patch is relevant?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:10:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 13:10:26 +0000
Subject: [Koha-bugs] [Bug 9439] Enforce superlibrarian mutual exclusivity of
other permissions
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |jonathan.druart at biblibre.co
| |m
Patch complexity|--- |Trivial patch
QA Contact| |jonathan.druart at biblibre.co
| |m
--- Comment #4 from Jonathan Druart ---
QA comment:
Works nicely.
Simple patch with some javascript lines added.
Marked as Passed QA.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:10:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 13:10:42 +0000
Subject: [Koha-bugs] [Bug 9439] Enforce superlibrarian mutual exclusivity of
other permissions
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14733|0 |1
is obsolete| |
Attachment #14805|0 |1
is obsolete| |
--- Comment #5 from Jonathan Druart ---
Created attachment 15002
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15002&action=edit
Bug 9439 - Enforce superlibrarian mutual exclusivity of other permissions
Basically, when you check the checkbox for the superlibrarian permission
in the patron record, it will disable and uncheck all the other
permission checkboxes. When you uncheck the checkbox for the
superlibrarian permission, it will renable those boxes. There is also
some JS code there to ensure that the other boxes are disabled when
returning to the change permission screen (i.e. the patch is not just a
click handler).
In the event that the checkboxes for superlibrarian and other
permissions are already checked, the user will be shown a pop-up window
explaining that the superlibrarian permission is mutually exclusive to
the others (since it already includes the others) and that the
permissions for that patron will then be reset to just include the
superlibrarian permission.
Comment: Tested on master. Works as described.
Signed-off-by: Bernardo Gonzalez Kriegel
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:13:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 13:13:19 +0000
Subject: [Koha-bugs] [Bug 9530] New: Allow separate 'Reply To' and 'From'
email address for notices
Message-ID: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14968|0 |1
is obsolete| |
--- Comment #2 from Kyle M Hall ---
Created attachment 15003
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15003&action=edit
Bug 8682 - Renewals do not appear on quick slips
To test:
Issue two books to a patron.
Do a renewal on one of them.
update the issuedate on the item that has been renewed to something before
today (renewals on the same day will work even without this patch)
I did: select * from issues;
update issues set issuedate="2013-01-25 14:00:00" where itemnumber = 948;
(itemnumber is variable depending on your test data.)
Print a quick slip before the patch - the renewal will not show up as one of
today's issues.
Print a quick slip after the patch - the renewal will show up as one of today's
issues.
If you need reasoning as to why a renewal should show up on the quick slip,
think of it as a record of everything
a borrower did today, without the hassle of overdues.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:35:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 13:35:53 +0000
Subject: [Koha-bugs] [Bug 8682] quick slip: renewals do not appear on quick
slips
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:36:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 13:36:15 +0000
Subject: [Koha-bugs] [Bug 8682] quick slip: renewals do not appear on quick
slips
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #15003|Bug 8682 - Renewals do not |[SIGNED-OFF] Bug 8682 -
description|appear on quick slips |Renewals do not appear on
| |quick slips
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:39:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 13:39:03 +0000
Subject: [Koha-bugs] [Bug 9520] Update default LOC Z39.50 target
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14983|0 |1
is obsolete| |
--- Comment #2 from Kyle M Hall ---
Created attachment 15004
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15004&action=edit
[SIGNED-OFF] Bug 9520 - Update default LOC Z39.50 target
This patch updates (if present) target settings
of Library of Congress Z39.50 server.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:39:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 13:39:14 +0000
Subject: [Koha-bugs] [Bug 9520] Update default LOC Z39.50 target
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:40:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 13:40:43 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |julian.maurice at biblibre.com
--- Comment #49 from Julian Maurice ---
Hi,
I tested some simple use cases and found some errors/things that can be
improved:
The bibliographic record used for these tests has only one field 200 with
various subfields (5abefg) and no field 300.
1/ Copy field 200 to 300
=> Problem: No 300 field is created. Is this a bug or a missing feature?
Same remark for 'Move'
2/ Copy field 200 to 300$a
=> Problem: 300$a = "MARC::Field::HASH(0x...)"
Same for 'Move'
3/ Copy field 200$a to 300
=> Problem: No 300 field is created but maybe not a bug.
Same for 'Move'
4/ Copy field 200$a to 300$a
=> Problem: Two fields 300 are created, one is correct with 300$a = but one has just an empty 'a' subfield.
Same for 'Move' but the empty 'a' subfield is now a subfield that contains the
string "don't_erase".
5/ Add/Update field 200 with value 'blob'
=> Problem: create a subfield 'b' with value 'lob'
6/ There is also a problem with Regex. If they contain '\' characters, they are
removed from text input when editing the action. So if I edit an action and
update it without changing anything, regex like "/(word)/\U$1\E/" are saved as
"/(word)/U$1E"
Failing QA for 2, 4 and 6.
For 1, 3 and 5 it would be great if Koha prevent the user to enter invalid
action.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:41:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 13:41:46 +0000
Subject: [Koha-bugs] [Bug 9521] Move common jQuery assets to
koha-tmpl/intranet-tmpl/lib
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14984|0 |1
is obsolete| |
--- Comment #2 from Kyle M Hall ---
Created attachment 15005
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15005&action=edit
[SIGNED-OFF] Bug 9521 - Move common jQuery assets to
koha-tmpl/intranet-tmpl/lib
Assets which are not theme-specific can now be placed in
koha-tmpl/intranet-tmpl/lib. This patch moves jQuery assets referenced
by doc-head-close.inc to this location and corrects the path in the
include.
To test, load any page in the staff client which uses jQuery and confirm
that there are no JavaScript errors. Test keyboard shortcuts (Alt-r,
Alt-u, Alt-q), Search to hold functionality, and search term
highlighting to confirm that jQuery plugins are working correctly.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:41:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 13:41:57 +0000
Subject: [Koha-bugs] [Bug 9521] Move common jQuery assets to
koha-tmpl/intranet-tmpl/lib
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:47:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 13:47:55 +0000
Subject: [Koha-bugs] [Bug 9516] Item Availability/Data missing from OPAC tag
search
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14967|0 |1
is obsolete| |
--- Comment #3 from Kyle M Hall ---
Created attachment 15006
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15006&action=edit
Bug 9516 - Item Availability/Data missing from OPAC tag search
Currently, an OPAC search using the "tag" and "q" query strings will have
results with no item data. Next to "Availability", it will say "No items
available:" (N.B. without reference to why the items are unavailable, like
Checked out, In transit, etc.).
The reason is that the opac-search.pl script is just pulling the marc blob
straight from the database without embedding any item data. I've used the
GetMarcBiblio sub with the embed item data option, and then converted the
resulting Marc object to us marc using the "as_usmarc" method.
Signed-off-by: Kyle M Hall
Appears to work as advertised.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:48:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 13:48:06 +0000
Subject: [Koha-bugs] [Bug 9516] Item Availability/Data missing from OPAC tag
search
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:55:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 13:55:51 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
for fields 1xx)
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|paul.poulain at biblibre.com |mathieu.saby at univ-rennes2.f
| |r
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:56:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 13:56:55 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
for fields 1xx)
In-Reply-To: ---
Created attachment 15007
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15007&action=edit
[PATCH 1/2] Bug 8252: Correct UNIMARC 1xx fields in DOM biblio and GRS-1
In DOM indexing, positions of biblio are not taken into account.
Additionnaly some indexes are not working even in GRS1, and there are a lot of
warns when rebuiding zebra.
This patch correct all 1xx indexes in GRS1 and DOM, and suppress the warns.
It also creates new indexes : Country-heading for 101, Code-langage-original
for 102$c, Material-type for 200$b.
106$a (used for printed docs only) is no more indexed in itype but in ff8-23
instead.
For the moment I keep 200$b indexed in itype and itemtype but if no library use
this field that way.
To test :
Apply on a Koha using GRS1.
Check if all coded fields are searchable in advanced search.
Check in simple search if Material-type, Country heading and
Code-langage-original are searchable (ex :"Material-type:texte" ;
"Country-heading:FR" ; "Code-langage-original:eng")
Apply on a Koha using DOM.
Check if all coded fields are searchable in advanced search.
Check in simple search if Material-type, Country heading and
Code-langage-original are searchable (ex :"Material-type:texte" ;
"Country-heading:FR" ; "Code-langage-original:eng")
M. Saby
Rennes 2 University
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:57:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 13:57:08 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
for fields 1xx)
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:00:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 14:00:54 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
for fields 1xx)
In-Reply-To: ---
Created attachment 15008
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15008&action=edit
[PATCH 2/2] Bug 8252: Followup for Marc21
Followup for Marc21
To test :
Apply on a Koha using GRS1.
Check if all coded fields are searchable in advanced search.
Check in simple search if Country heading and Code-langage-original are
searchable (ex "Country-heading:FR" ; "Code-langage-original:eng")
Apply on a Koha using DOM.
same tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:03:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 14:03:02 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
for fields 1xx)
In-Reply-To: ---
Of course, in my description, I mean "In DOM indexing, positions of biblio
CODED FIELDS are not taken into account."
M. Saby
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:14:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 14:14:14 +0000
Subject: [Koha-bugs] [Bug 8620] Barcode searching not working correctly
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ian.bays at ptfs-europe.com
--- Comment #4 from Ian Bays ---
It seems the line "all any" in record.abs is not carried through to the dom xml
and xsl files used.
Another workaround to add barcode back in to the general search is to add the
"any" index for the barcode in record.abs, re-generate the xml and xsl then
rebuild the zebra indexes.
So the line in record.abs:
melm 952$p barcode,barcode:n
becomes:
melm 952$p barcode,barcode:n,any:w
Then follow the wiki to remake xml and xsl (don't just copy/paste as the
example is unimarc):
http://wiki.koha-community.org/wiki/Switching_to_dom_indexing
It still does not explain how other main fields are retrieved with "any" but
have no explicit "any" index in record.abs, but at least it is not changing the
code only to be changed back when fixed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:16:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 14:16:36 +0000
Subject: [Koha-bugs] [Bug 9516] Item Availability/Data missing from OPAC tag
search
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |RESOLVED
Resolution|--- |INVALID
--- Comment #4 from Kyle M Hall ---
Neither I nor Owen have been able to reproduce this bug.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:17:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 14:17:34 +0000
Subject: [Koha-bugs] [Bug 9516] Item Availability/Data missing from OPAC tag
search
In-Reply-To: ---
I should probably note that I forgot to test the pre-patch conditions before
signing this patch. My bad!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:19:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 14:19:33 +0000
Subject: [Koha-bugs] [Bug 9508] the dateformat variable is not standardized
in template files
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14954|0 |1
is obsolete| |
--- Comment #3 from Kyle M Hall ---
Created attachment 15009
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15009&action=edit
Bug 9508: Standardize the dateformat value from C4::Auth
- the dateformat value is send to all templates (from
C4::Auth::get_template_and_user)
- remove all assignment of dateformat in all .pl files
- Remove "all" occurrences (those I found!) of dateformat_*
>From now the only way to get the date format is a string comparaison
(dateformat == "metric")
Checked with the command:
git grep "\(dateformat_us\|dateformat_metric\|dateformat_iso\)" | grep
-v translator
Signed-off-by: Kyle M Hall
Tested all the datepickers I could find, looks good.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:19:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 14:19:40 +0000
Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14244|0 |1
is obsolete| |
--- Comment #6 from Bernardo Gonzalez Kriegel ---
Created attachment 15010
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15010&action=edit
[SIGNED-OFF] Bug 9254: Problem with EnhancedMessagingPreferences
First I don't know the right component to this bug.
The problem is the following:
- when enabling EnhancedMessagingPreferences, the staff client if able to set
the messaging preferences for the patrons categories, and then for the patron
(normally the messaging preferences are the same for everyone)
- when enabling EnhancedMessagingPreferences, the patrons can set in the OPAC
their messaging preferences, which can be against the library rules
Solution:
- enabling EnhancedMessagingPreferences, should allow the the staff client to
set the patrons messaging preferences
- enabling EnhancedMessagingPreferences, should't allow patrons to set their
messaging preferences (the link doesn't appear in the usermenu.inc)
- should be another preference to allow the patrons to set their messaging
preferences.
Test plan:
- apply the patch
- enable EnhancedMessagingPreferences, the messaging page should appear in OPAC
- disable OPACEnhancedMessagingPreferences, the messaging page shouldn't appear
in OPAC
- disable EnhancedMessagingPreferences, the messaging page shouldn't appear in
OPAC
Sponsored-by: KEEP SOLUTIONS
Signed-off-by: Kyle M Hall
Signed-off-by: Bernardo Gonzalez Kriegel
Rebased on master (2013-02-01)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:19:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 14:19:49 +0000
Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14246|0 |1
is obsolete| |
--- Comment #7 from Bernardo Gonzalez Kriegel ---
Created attachment 15011
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15011&action=edit
[SIGNED-OFF] Bug 9254 - Problem with EnhancedMessagingPreferences - Followup -
Rename pref to EnhancedMessagingPreferencesOPAC
If the new pref is named EnhancedMessagingPreferencesOPAC, it will show up
adjacent to EnhancedMessagingPreferences
Signed-off-by: Bernardo Gonzalez Kriegel
Comment: Works as described. But the patch only hides the link,
not disable the feature. If you refresh OPAC after unset
EnhancedMessagingPreferencesOPAC, you can still change
your messaging preferences.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:20:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 14:20:01 +0000
Subject: [Koha-bugs] [Bug 9508] the dateformat variable is not standardized
in template files
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:22:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 14:22:26 +0000
Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |bgkriegel at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:03:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:03:25 +0000
Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and
default_circ_rules tables useless
In-Reply-To: ---
(In reply to comment #18)
> Is there a reason we couldn't keep the foreign key constraint and use NULL
> to mean all branches/all patron types/all item types? It seems a shame to
> lose the database-enforced consistency.
Yes, it is not possible to have a primary key on branchcode, categorycode and
itemtype if they can be NULL :-/
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:06:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:06:17 +0000
Subject: [Koha-bugs] [Bug 9516] Item Availability/Data missing from OPAC tag
search
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|INVALID |WORKSFORME
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:08:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:08:15 +0000
Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and
default_circ_rules tables useless
In-Reply-To: ---
(In reply to comment #19)
> (In reply to comment #18)
> > Is there a reason we couldn't keep the foreign key constraint and use NULL
> > to mean all branches/all patron types/all item types? It seems a shame to
> > lose the database-enforced consistency.
>
> Yes, it is not possible to have a primary key on branchcode, categorycode
> and itemtype if they can be NULL :-/
But perhaps I can use a multiple unique key column on them
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:15:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:15:35 +0000
Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and
default_circ_rules tables useless
In-Reply-To: ---
The '*' is used for the issuingrules table, so why don't use it for theses 3
tables? Don't you think it is more consistent?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:15:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:15:48 +0000
Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and
default_circ_rules tables useless
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |In Discussion
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:15:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:15:59 +0000
Subject: [Koha-bugs] [Bug 9274] Software error in bibtex export
In-Reply-To: ---
(In reply to comment #11)
> The patches fixes the problem with several authors. So, no crash. That is
> great!
> But if the marc fields include more information than the name in $a, they
> are attached as well in the string.
That is why I didn't use C4::Biblio::GetMarcAuthors in my first patch
(attachment 14387).
Maybe someone can use it to add MARC21 specific cases ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:40:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:40:39 +0000
Subject: [Koha-bugs] [Bug 9531] New: Make SIP2 message terminator
configurable via SIPconfig.xml
Message-ID: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14980|0 |1
is obsolete| |
--- Comment #25 from Jared Camins-Esakov ---
Created attachment 15012
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15012&action=edit
Bug 8733 follow-up: restore isbn class in details page
For some reason the isbn CSS class was missing from the details
page, presumably due to a bad merge. This one-line commit re-adds
it so that the critics reviews will show up.
Signed-off-by: Jared Camins-Esakov
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:42:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:42:01 +0000
Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #15001|0 |1
is obsolete| |
--- Comment #26 from Jared Camins-Esakov ---
Created attachment 15013
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15013&action=edit
Bug 8733: Follow-up The isbn sent to idream contains dash
Signed-off-by: Jared Camins-Esakov
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:46:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:46:24 +0000
Subject: [Koha-bugs] [Bug 7619] 3M self checkout don't work in France
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=9531
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:46:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:46:24 +0000
Subject: [Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable
via SIPconfig.xml
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=7619
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:46:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:46:29 +0000
Subject: [Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable
via SIPconfig.xml
In-Reply-To: ---
Created attachment 15014
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15014&action=edit
Bug 9531 - Make SIP2 message terminator configurable via SIPconfig.xml
Add a delimeter option to SIPConfig.xml, choices for 'delimeter' are 'CR' or
'CRLF'.
The default continues to be 'CRLF' if 'delimeter' is undefined.
Test Plan:
1) Apply patch
2) Start SIP server
3) Run C4/SIP/t/04patron_status.t
4) Stop SIP server
5) Add terminator="CR" for account login 'term1'
6) Run 04patron_status.t again, you should see no change
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:46:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:46:57 +0000
Subject: [Koha-bugs] [Bug 9521] Move common jQuery assets to
koha-tmpl/intranet-tmpl/lib
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at biblibre.co
| |m
--- Comment #3 from Jonathan Druart ---
Why don't you place the lib directory at the root (koha-tmpl) in order to share
libs with opac?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:46:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:46:53 +0000
Subject: [Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable
via SIPconfig.xml
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:49:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:49:17 +0000
Subject: [Koha-bugs] [Bug 9454] NewBasket does not use placeholders in sql
In-Reply-To: ---
> The original code says: if a variable ($basketcontractnumber, $deliveryplace
> or $billingplace) is equal to 0 or an empty string, we call ModBasketHeader
> with an undefined value.
>
> If someone calls the routine with "", we want to insert undef, not ""
The only call of the routine in basketheader.pl already forces
basketcontractnumber to undef in these conditions and this would seem the
appropriate place to validate inputs.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:49:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:49:29 +0000
Subject: [Koha-bugs] [Bug 9102] [SECURITY] We should set httponly on our
session cookie
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #19 from Jared Camins-Esakov ---
This patch has been pushed to master.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:49:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 15:49:53 +0000
Subject: [Koha-bugs] [Bug 9521] Move common jQuery assets to
koha-tmpl/intranet-tmpl/lib
In-Reply-To: ---
Because intranet and OPAC do not share a common web-accessible directory in
standard installations.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 17:08:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 16:08:19 +0000
Subject: [Koha-bugs] [Bug 9401] Javascript used for tags handling wants
access to CGISESSID cookie
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #4 from Jared Camins-Esakov ---
This patch has been pushed to Master. Tagging worked for me both before and
after applying this patch on top of the patch for bug 9102. I am not entirely
sure why. However, since it worked after, I am pushing the patch anyway since
it removes unnecessary cruft.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 17:18:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 16:18:36 +0000
Subject: [Koha-bugs] [Bug 9526] Patron statistics table is not pretty,
the page needs the circ toolbar added
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #5 from Jared Camins-Esakov ---
This patch has been pushed to master.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 17:25:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 16:25:15 +0000
Subject: [Koha-bugs] [Bug 9418] Some corrections and additions to about.tt
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #12 from Jared Camins-Esakov ---
This patch has been pushed to master.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 17:26:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 16:26:43 +0000
Subject: [Koha-bugs] [Bug 9330] Patron duplication : should duplicate with
empty title (salutation field)
In-Reply-To: ---
Why shouldn't the salutation be copied by default when duplicating a patron?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 17:36:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 16:36:12 +0000
Subject: [Koha-bugs] [Bug 9439] Enforce superlibrarian mutual exclusivity of
other permissions
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #6 from Jared Camins-Esakov ---
This patch has been pushed to master. I love this feature. I might have liked
to see the checkboxes remain active so that clicking any checkbox other than
the superlibrarian cleared the superlibrarian box, but I the way it works now
is good too.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 17:41:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 16:41:02 +0000
Subject: [Koha-bugs] [Bug 9503] Link from histsearch via invoicenumber
results in error
In-Reply-To: ---
How do I get to the histsearch page? I can't seem to find it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 17:44:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 16:44:15 +0000
Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages
In-Reply-To: ---
(In reply to comment #24)
> Jared, do you think this patch is relevant?
Yes, I think it was a very good idea. I signed off on your follow-up.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 17:48:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 16:48:57 +0000
Subject: [Koha-bugs] [Bug 9507] In order not to submit a form unexpectedly
some code is duplicated
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14947|0 |1
is obsolete| |
--- Comment #2 from Kyle M Hall ---
Created attachment 15015
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15015&action=edit
Bug 9507: prevent submit: factorize some code in a js file
This patch factorize code in a js file.
Test plan:
On acqui/neworderempty.pl, acqui/orderreceive.pl and
serials/serials-edit.tt try to scan a barcode (or press enter) on the
form and check that it is not sent.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 17:49:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 16:49:05 +0000
Subject: [Koha-bugs] [Bug 9330] Patron duplication : should duplicate with
empty title (salutation field)
In-Reply-To: ---
(In reply to comment #5)
> Why shouldn't the salutation be copied by default when duplicating a patron?
I would say because the duplicate function would be used most often for members
of the same family, where the odds are against everyone having the same title.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 17:49:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 16:49:07 +0000
Subject: [Koha-bugs] [Bug 9507] In order not to submit a form unexpectedly
some code is duplicated
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 17:51:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 16:51:44 +0000
Subject: [Koha-bugs] [Bug 9532] New: reserve rules with itemtype on biblio
Message-ID: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #7 from Jared Camins-Esakov ---
Thanks for the explanation. That makes sense. This patch has been pushed to
master.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 18:15:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 17:15:10 +0000
Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co
|ity.org |m
--- Comment #1 from Fridolyn SOMERS ---
Created attachment 15016
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15016&action=edit
Proposed patch
See commit message
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 18:52:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 17:52:18 +0000
Subject: [Koha-bugs] [Bug 6209] Standardize on one javascript library for
client-side form validation
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Needs Signoff
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 18:52:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 17:52:27 +0000
Subject: [Koha-bugs] [Bug 6209] Standardize on one javascript library for
client-side form validation
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #8474|0 |1
is obsolete| |
Attachment #8520|0 |1
is obsolete| |
--- Comment #9 from Owen Leonard ---
Created attachment 15017
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15017&action=edit
Bug 6209 - Standardize on one plugin for client-side form validation
This patch adds the jQuery "Validation" plugin
(http://docs.jquery.com/Plugins/Validation) and includes it by
default in the staff client along with an include file containing
translatable strings for all of the plugin's possible messages.
The staff client's main JavaScript file has been modified to perform
automatic validation of any form with the class "validated."
For a simple example I have modified the library entry form
to mark required fields as required (something which had not
been done before). Each required field has been given a class,
"required" and the HTML5 attribute "required." The former adds
the hook for the plugin, the latter adds browser-based validation
in recent browsers (and which will be superceded by the plugin
if JavaScript is enabled).
This will check for inputs classed "required" without any
additional configuration. More complex forms (with specific
data types, for instance) will require more inline JavaScript
configuration.
$("#FormID").validate({ /* configuration details */ });
Also added to the library entry form are checks on the email and URL
fields via classes ("email" and "url", respectively). This demonstrates
validation of content without forcing the field to be required.
To test, go to Administration -> Libraries and Groups and choose
"New library." Submit the form without entering a library code
or name. You should be prevented from submitting the form and be
shown an error message by each field. Perform the same check with an
existing entry.
To test browser-based validation, disable JavaScript and follow
the same procedure.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 19:46:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 18:46:02 +0000
Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tomascohen at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 21:11:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Feb 2013 20:11:17 +0000
Subject: [Koha-bugs] [Bug 5609] Holds Rewrite
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |skushner at mtpl.org
--- Comment #8 from scott kushner ---
Currently, when a Suspended HOLD is un-suspended, it does not show up in the
Holds to Pull report.
Is this part of the Holds re-write development?
If not, can it be?
It's kind of an important feature.
Thanks.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 01:22:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 00:22:53 +0000
Subject: [Koha-bugs] [Bug 5790] Deleting a biblio should alert/fail if there
are existent subscriptions and holds
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
CC| |liz at catalyst.net.nz
--- Comment #22 from Liz Rea (CatalystIT) ---
Gah!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 01:32:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 00:32:14 +0000
Subject: [Koha-bugs] [Bug 9293] action_logs not tracking payments
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |liz at catalyst.net.nz
--- Comment #3 from Liz Rea (CatalystIT) ---
This patch certainly works, but I think the output in the log needs to be
clearer.
Where money is involved, you do not want *any* ambiguity as to what happened,
and you average librarian is going to look at that and probably have trouble
understanding what happened.
I know that the same output appears in other logs, but the other logs don't
involve money and financial "paper trail."
Please make the output a bit easier to understand, something like "borrower:
Action: Amount:
It doesn't have to be exactly like that, but it should have those elements.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 03:28:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 02:28:05 +0000
Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 03:28:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 02:28:07 +0000
Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #15016|0 |1
is obsolete| |
--- Comment #2 from Liz Rea ---
Created attachment 15018
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15018&action=edit
Bug 9532: reserve rules with itemtype on biblio
When itemtype is defined on biblio (item-level_itypes syspref), the method
C4::Reserves::CanItemBeReserved uses item->{itemtype}. But item comes from
C4::Items::GetItem and it does not have a 'itemtype' key, in this method the
item type value is always in 'itype' key.
This patch corrects it.
Test plan:
You must have itemtype on biblio and 'item-level_itypes' syspref on biblio.
This test plan is with ReservesControlBranch on ItemHomeLibrary.
- Choose a branch, a borrower category and an item type, for example 'NYC',
'CHILD' and 'DVD'
- Set an issuing rule for 'NYC', CHILD' and 'DVD' with 'Holds allowed' on 10
- Set an issuing rule for 'NYC', CHILD' and all item types with 'Holds allowed'
on 0
- Choose an item of a biblio with itemtype 'DVD', that can be reserved, with
'NYC' as homebranch
- Choose a borrower with category 'CHILD'
- try to reverse the item for the borrower
=> without the patch, you can
=> with the patch, you can't
You may check reserve is allowed with 'Holds allowed' > 0 on issuing rule for
'DVD'.
Signed-off-by: Liz Rea
Great test plan - thanks!
Confirmed the bug, and the fix. Looks good to me.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 03:29:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 02:29:55 +0000
Subject: [Koha-bugs] [Bug 9293] action_logs not tracking payments
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 04:20:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 03:20:22 +0000
Subject: [Koha-bugs] [Bug 9534] New: No way to get back to bib detail from
edit record screen
Message-ID: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 04:25:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 03:25:02 +0000
Subject: [Koha-bugs] [Bug 9504] URL escape in OPAC more searches
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14921|0 |1
is obsolete| |
--- Comment #2 from Liz Rea ---
Created attachment 15019
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15019&action=edit
Bug 9504: URL escape in OPAC more searches
OPACSearchForTitleIn is a syspref used to add links as "more searches" in OPAC
record detail page.
The links can contain vars depending on record values like title, ISBN, ...
Thoses values must be URL-escaped because they can contain special characters
that will brake URL and/or HTML.
This patch add a method C4::Output::parametrized_url() that replaces vars in
URL usign escape and UTF-8 encoding.
Test plan :
- Define in OPACSearchForTitleIn a link with all possible vars : TITLE, AUTHOR,
ISBN, ISSN, CONTROLNUMBER, BIBLIONUMBER
- Edit a record to add special characters in title : ", &, ? ...
- Go to OPAC detail pages of this record
=> Check that URL is well encoded
=> Click on link to check the term is well encoded (diacritical characters,
...)
Signed-off-by: Liz Rea
Nice test plan, thanks!
Verified bug and fix - both look good.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 04:32:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 03:32:48 +0000
Subject: [Koha-bugs] [Bug 9509] batchMod.pl does not ensure each barcode is
unique
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 04:32:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 03:32:49 +0000
Subject: [Koha-bugs] [Bug 9509] batchMod.pl does not ensure each barcode is
unique
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14960|0 |1
is obsolete| |
--- Comment #2 from Liz Rea ---
Created attachment 15020
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15020&action=edit
Bug 9509 - batchMod.pl does not ensure each barcode is unique
Test plan:
1) Browse to Tools ? Batch item deletion
2) Enter a list of barcodes, make sure you have at
least one barcode listed more than once
3) Click continue
4) Verify the duplicated barcode shows up multiple times in the table
5) Apply patch
6) Refresh the page
7) Verify each barcode now displays only once
Signed-off-by: Liz Rea
verified bug and fix - both good.
Nice test plan, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 05:30:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 04:30:26 +0000
Subject: [Koha-bugs] [Bug 5514] fewer clicks when creating a report
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |liz at catalyst.net.nz
Resolution|--- |FIXED
--- Comment #1 from Liz Rea (CatalystIT) ---
This was fixed in 3.6.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 07:20:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 06:20:19 +0000
Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |liz at catalyst.net.nz
--- Comment #3 from Liz Rea (CatalystIT) ---
I agree - we need to be able to remove them.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 07:38:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 06:38:22 +0000
Subject: [Koha-bugs] [Bug 9174] Item type image does not display for
biblio-level itemtypes in list display in OPAC
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |chris at bigballofwax.co.nz
--- Comment #10 from Chris Cormack ---
Pushed to 3.10.x will be in 3.10.3
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 08:03:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 07:03:26 +0000
Subject: [Koha-bugs] [Bug 8942] Translation process breaks javascript in
calendar.inc
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 08:03:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 07:03:43 +0000
Subject: [Koha-bugs] [Bug 8942] Translation process breaks javascript in
calendar.inc
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 08:03:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 07:03:46 +0000
Subject: [Koha-bugs] [Bug 8942] Translation process breaks javascript in
calendar.inc
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14934|0 |1
is obsolete| |
Attachment #14935|0 |1
is obsolete| |
Attachment #14936|0 |1
is obsolete| |
--- Comment #37 from Chris Cormack ---
Created attachment 15021
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15021&action=edit
Bug 8942 : Adding a test to make sure we don't use single quotes for js
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 08:03:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 07:03:58 +0000
Subject: [Koha-bugs] [Bug 8942] Translation process breaks javascript in
calendar.inc
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|Medium patch |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 08:09:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Feb 2013 07:09:43 +0000
Subject: [Koha-bugs] [Bug 8108] Remove unused images from the OPAC
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
--- Comment #17 from Chris Cormack